Re: [PATCH v2] drm/i915/hwmon: Get rid of devm

2024-04-16 Thread Armin Wolf
@@ -849,5 +849,26 @@ void i915_hwmon_register(struct drm_i915_private *i915) void i915_hwmon_unregister(struct drm_i915_private *i915) { - fetch_and_zero(>hwmon); + struct i915_hwmon *hwmon = fetch_and_zero(>hwmon); Why is fetch_and_zero() necessary here? Thanks, Arm

Re: [PATCH] drm/i915/hwmon: Get rid of devm

2024-04-15 Thread Armin Wolf
by drm_dev_enter() and drm_dev_exit(). That said, since the i915 driver is already removing the hwmon device manually with i915_hwmon_unregister(), i agree that not using devres in this case seems to be the solution. Thanks, Armin Wolf Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10366 Signed-off