[Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-07 Thread Feng Tang
= 32: [0.465818] calling i915_init+0x0/0x51 @ 1 [0.925831] initcall i915_init+0x0/0x51 returned 0 after 449219 usecs Signed-off-by: Feng Tang <feng.t...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 22 +++--- 1 file changed, 15 insertions(+), 7 del

Re: [Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-07 Thread Feng Tang
Hi Chris, Thanks for the prompt review! On Mon, May 07, 2018 at 11:40:45AM +0100, Chris Wilson wrote: > Quoting Feng Tang (2018-05-07 11:36:09) > > To fulfil the Dell 4K monitor, the dpcd max retries has been bumped > > from 7 to 32, which may hurt the boot/init time for

Re: [Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-07 Thread Feng Tang
On Mon, May 07, 2018 at 05:09:21PM +0200, Daniel Vetter wrote: > On Mon, May 07, 2018 at 02:33:25PM +0100, Chris Wilson wrote: > > Quoting Feng Tang (2018-05-07 22:26:34) > > > Hi Chris, > > > > > > Thanks for the prompt review! > > > > > >

Re: [Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-09 Thread Feng Tang
On Tue, May 08, 2018 at 10:30:19PM +0300, Jani Nikula wrote: > On Wed, 09 May 2018, Feng Tang <feng.t...@intel.com> wrote: > > >> > > > On Mon, May 07, 2018 at 11:40:45AM +0100, Chris Wilson wrote: > >> >> > > > > Quoting Feng Tang (201

Re: [Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-09 Thread Feng Tang
On Wed, May 09, 2018 at 10:53:53AM +0300, Jani Nikula wrote: > On Wed, 09 May 2018, Feng Tang <feng.t...@intel.com> wrote: > > On Tue, May 08, 2018 at 10:30:19PM +0300, Jani Nikula wrote: > >> On Wed, 09 May 2018, Feng Tang <feng.t...@intel.com> wrote: > >> &

Re: [Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-10 Thread Feng Tang
On Wed, May 09, 2018 at 12:28:15PM +0300, Jani Nikula wrote: > On Wed, 09 May 2018, Feng Tang <feng.t...@intel.com> wrote: > > On Wed, May 09, 2018 at 10:53:53AM +0300, Jani Nikula wrote: > >> On Wed, 09 May 2018, Feng Tang <feng.t...@intel.com> wrote: > >&g

Re: [Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-08 Thread Feng Tang
>> > > > On Mon, May 07, 2018 at 11:40:45AM +0100, Chris Wilson wrote: > >> > > > > Quoting Feng Tang (2018-05-07 11:36:09) > >> > > > > > To fulfil the Dell 4K monitor, the dpcd max retries has been > >> > > > >

Re: [Intel-gfx] [PATCH] drm/dp: add module parameter for the dpcd access max retries

2018-05-08 Thread Feng Tang
On Mon, May 07, 2018 at 05:09:21PM +0200, Daniel Vetter wrote: > On Mon, May 07, 2018 at 02:33:25PM +0100, Chris Wilson wrote: > > Quoting Feng Tang (2018-05-07 22:26:34) > > > Hi Chris, > > > > > > Thanks for the prompt review! > > > > > >

[Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-03 Thread Feng Tang
if it will have other side effects and drawbacks, so I would throw it out for reviews and comments, thanks Signed-off-by: Feng Tang Cc: Daniel Vetter Cc: Jani Nikula Cc: Ville Syrjälä Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-05 Thread Feng Tang
Hi Jani, On Tue, Jun 05, 2018 at 10:41:04AM +0300, Jani Nikula wrote: > On Mon, 04 Jun 2018, Feng Tang wrote: > > i915 driver's probe is one of the longest of pci devices, which takes > > about hundreds of microseconds or more, make the probe async will help > > much on

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-06 Thread Feng Tang
Hi Jani, On Tue, Jun 05, 2018 at 11:18:46AM +0300, Jani Nikula wrote: > On Tue, 05 Jun 2018, Feng Tang wrote: > > Hi Jani, > > > > On Tue, Jun 05, 2018 at 10:41:04AM +0300, Jani Nikula wrote: > >> On Mon, 04 Jun 2018, Feng Tang wrote: > >> > i915 d

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-25 Thread Feng Tang
On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > > > The binding with i915 from HD-audio controller is done in an async > > work invoked from the probe callback. It makes harder to deal with > > EPROBEDEFER. > > > > IMO, a saner way would be to rather wait for the component

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi Jani/Chris/Takashi, On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote: > >> > >> http://patchwork.freedesktop.org/patch/msgid/20180323083048.13327-1-ch...@chris-wilson.co.uk > > > > IIUC, you are waiting for the HDA audio driver to first handle the > > i915 sync probel case? > > I

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi Takashi, On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > On Wed, 20 Jun 2018 08:25:23 +0200, > Feng Tang wrote: > > > > Hi Jani/Chris/Takashi, > > > > On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote: > > > >> &g

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi Jani, On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > On Wed, 20 Jun 2018, Feng Tang wrote: > > Hi Takashi, > > > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > >> On Wed, 20 Jun 2018 08:25:23 +0200, > >> Feng Tang wrot

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-08-16 Thread Feng Tang
On Tue, Aug 14, 2018 at 11:39:48AM +0200, Takashi Iwai wrote: > On Tue, 14 Aug 2018 11:34:07 +0200, > Daniel Vetter wrote: > > > > On Tue, Aug 14, 2018 at 02:54:31PM +0800, Feng Tang wrote: > > > Hi Jani, Daniel > > > > > > Could you

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-08-14 Thread Feng Tang
Hi Jani, Daniel Could you help to comment? thanks, - Feng On Thu, Jul 12, 2018 at 03:51:34PM +0800, Feng Tang wrote: > Hi Daniel, > > On Thu, Jul 12, 2018 at 08:54:34AM +0200, Daniel Vetter wrote: > > On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > > > On

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-11 Thread Feng Tang
On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > Hi Daneil/Jani/Takashi, > > When I was testing this patch from Takashi, I further checked the kernel > module code, and found that: we may need NOT to ad

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-12 Thread Feng Tang
Hi Daniel, On Thu, Jul 12, 2018 at 08:54:34AM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > > On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: > > > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > >

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-12 Thread Feng Tang
On Thu, Jul 12, 2018 at 09:37:41AM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 8:56 AM, Takashi Iwai wrote: > > On Thu, 12 Jul 2018 08:54:34 +0200, > > Daniel Vetter wrote: > >> > >> On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > >

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-21 Thread Feng Tang
Hi, On Wed, Jun 20, 2018 at 11:45:25AM +0200, Takashi Iwai wrote: > > > > > > > > Thanks for the info, I see your intension now. > > > > > > > > In previous discussion, Jani suggested to use a completion to indicate > > > > the probe done, I can't figure out another way :) > > > > > > I