function be
called in a number of places.
Signed-off-by: Jani Nikula
---
Use 'git show -w --color-words' for easy review.
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 68 +--
drivers/gpu/drm/i915/display/intel_de.h | 20 +++---
drivers/gpu/drm/i915/display/intel_
On Wed, 20 Mar 2024, Julia Lawall wrote:
> On Wed, 20 Mar 2024, Jani Nikula wrote:
>> Okay, I have another one wrt macros. :)
>>
>> I'm trying to add a completely new variadic macro, but it fails at
>> "...". I've tried all sorts of things, but can'
On Wed, 20 Mar 2024, Ville Syrjälä wrote:
> I have basically that same patch sitting in some branch.
I would expect no less. ;D
> With commit messages polished the series is
> Reviewed-by: Ville Syrjälä
Thanks, fixed up the commit messages and posted v1 for CI.
BR,
Jani.
--
Ja
The encoder is a much more useful thing to pass around than the i915 and
port combo. Also drive-by clean up some cases where both i915 and
encoder are passed; only the latter is needed.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 258
The intel_is_c10phy() is now unused. Remove.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 14 --
drivers/gpu/drm/i915/display/intel_cx0_phy.h | 2 --
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers
Pass encoder to intel_wait_ddi_buf_active(). The encoder will be more
helpful than just port in the subsequent changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff
Pass encoder to the _port_to_ddc_pin() functions, and rename to
_encoder_to_ddc_pin(). The encoder will be more helpful than just port
in the subsequent changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 60 ++-
1
coder_to_phy()
intel_port_to_tc() -> intel_encoder_to_tc()
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 36 ++
drivers/gpu/drm/i915/display/intel_ddi.c | 116 +++---
.../drm/i915/display/intel_ddi_buf_t
-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 9 +
drivers/gpu/drm/i915/display/intel_cx0_phy.h | 1 +
drivers/gpu/drm/i915/display/intel_display.c | 40
drivers/gpu/drm/i915/display/intel_display.h | 7
4 files changed
Pass encoder to intel_snps_phy_update_psr_power_state(). The encoder
will be more helpful than just port in the subsequent changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_psr.c | 7 ++-
drivers/gpu/drm/i915/display/intel_snps_phy.c
v1 after the reviewed RFC [1].
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1710253533.git.jani.nik...@intel.com
Jani Nikula (7):
drm/hdmi: convert *_port_to_ddc_pin() to *_encoder_to_ddc_pin()
drm/i915/ddi: pass encoder to intel_wait_ddi_buf_active()
drm/i915/snps: pass encoder
tested that my cocci patch works with x's:
+ #define fn(p, xxx) foo(__VA_ARGS__)
but when I try to make it actually variadic like:
+ #define fn(p, ...) foo(__VA_ARGS__)
it gives me error. Is there a way to escape? Even tried to use a fresh
identifier vararg = "..."; but cocci made them unique with numbering
"...0" and "...1" etc.
BR,
Jani.
--
Jani Nikula, Intel
On Tue, 19 Mar 2024, Luca Coelho wrote:
> On Tue, 2024-03-19 at 17:06 +0200, Jani Nikula wrote:
>> On Tue, 19 Mar 2024, Lucas De Marchi wrote:
>> > On Thu, Mar 14, 2024 at 08:52:21AM +0200, Luca Coelho wrote:
>> > > Some of the backported intel_uncore_re
gt;>Signed-off-by: Luca Coelho
>
> if a patch affects xe, please always Cc the xe mailing list so it
> triggers CI on those machines
Indeed. I just bounced the patch to intel-xe to trigger CI.
BR,
Jani.
>
> Lucas De Marchi
--
Jani Nikula, Intel
for ((__port) = PORT_A; (__port) < I915_MAX_PORTS; (__port)++)
+#define for_each_port(__i915, __port) \
+ for_each_set_bit(__port, _RUNTIME_INFO(__i915)->port_mask,
sizeof(DISPLAY_RUNTIME_INFO(__i915)->port_mask))
but then we have DSI code that reli
ncoder_supports_dp_dual_mode(const
> struct intel_bios_encoder_da
> {
> const struct child_device_config *child = >child;
The above oopses already.
BR,
Jani.
>
> + if (!devdata)
> + return false;
> +
> if (!intel_bios_encoder_supports_dp(devdata) ||
&g
On Tue, 19 Mar 2024, Jani Nikula wrote:
> Amend drm_dp_read_mst_cap() to return an enum, indicating "SST", "SST
> with sideband messaging", or "MST". Modify all call sites to take the
> new return value into account.
drm-misc and nouveau maintainers, ack
Abstract the MST mode disconnect to a separate function.
Cc: Arun R Murthy
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers
of the
register.
Cc: Arun R Murthy
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915/display/intel_dp.c
Clarify the conditions for choosing the MST mode to use by adding a new
function intel_dp_mst_mode_choose(). This also prepares for being able
to extend the MST modes to single-stream sideband messaging.
Cc: Arun R Murthy
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
Murthy
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_types.h| 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 21 ---
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915
tect before early returns from intel_dp_detect_dpcd()
Cc: Arun R Murthy
Cc: Ville Syrjälä
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 52 ++---
1 file changed, 37 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/
ude Paul
Cc: Danilo Krummrich
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 20 ++--
drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
drivers/gpu/drm/nouveau/nouveau_dp.c | 2 +-
include/drm/display/
Resend because I forgot to Cc: dri-devel on the original submission.
Jani Nikula (6):
drm/mst: read sideband messaging cap
drm/i915/mst: improve debug logging of DP MST mode detect
drm/i915/mst: abstract choosing the MST mode to use
drm/i915/mst: use the MST mode detected previously
drm
e/drm/display/drm_dp_helper.h | 30 +
> 13 files changed, 325 insertions(+), 3 deletions(-)
--
Jani Nikula, Intel
rule in kernel
development.
BR,
Jani.
PS. Please try to reply inline instead of top-posting in public mailing
lists.
>
>
> On 3/15/24 19:02, Ville Syrjälä wrote:
>> On Wed, Mar 06, 2024 at 12:19:42PM +0200, Jani Nikula wrote:
>>> On Wed, 06 Mar 2024, gareth...@inte
On Wed, 13 Mar 2024, Jani Nikula wrote:
> On Wed, 13 Mar 2024, Jonathon Hall wrote:
>> Since commit 0c65dc062611 ("drm/i915/jsl: s/JSL/JASPERLAKE for
>> platform/subplatform defines"), boot freezes on a Jasper Lake tablet
>> (Librem 11), usually with graphica
On Thu, 07 Mar 2024, Jani Nikula wrote:
> Switch a handful of places over to drm device based logging and WARNs,
> unify connector and crtc logging, etc.
Ping for review, please. :)
>
> Jani Nikula (6):
> drm/modes: add drm_mode_print() to dump mode in drm_printer
>
gt;> if (intel_de_wait_for_set(dev_priv,
>> dp_tp_status_reg(encoder, crtc_state),
>>- DP_TP_STATUS_IDLE_DONE, 1))
>>+ DP_TP_STATUS_IDLE_DONE, 2))
>> drm_err(_priv->drm,
>> "Timed out waiting for DP idle patterns\n");
>> }
>>--
>>2.34.1
>>
--
Jani Nikula, Intel
ve IS_JASPERLAKE() to fix the regression.
>
> Signed-off-by: Jonathon Hall
> Cc: sta...@vger.kernel.org
Thanks for the patch!
Fixes: 0c65dc062611 ("drm/i915/jsl: s/JSL/JASPERLAKE for platform/subplatform
defines")
Cc: # v6.6+
Reviewed-by: Jani Nikula
> ---
> drive
no
compiler warnings, and you'd be screwed because you wouldn't even have a
way of checking. You'd just get 4294967284 modes.
BR,
Jani.
--
Jani Nikula, Intel
el_connector
> *connector)
> return NULL;
> }
>
> +static inline bool intel_opregion_vbt_present(struct drm_i915_private *i915)
> +{
> + return false;
> +}
> +
> static inline const void *
> intel_opregion_get_vbt(struct drm_i915_private *i915, size_t *size)
> {
--
Jani Nikula, Intel
On Tue, 12 Mar 2024, "Sripada, Radhakrishna"
wrote:
> LGTM,
> Reviewed-by: Radhakrishna Sripada
Thanks for the review, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 258 ++-
1 file changed, 136 insertions(+), 122 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
b/drivers/gpu/drm/i915/display/intel_cx0_phy.c
index b88ffc75cf4a..d2e4439562e3
Unused.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 14 --
drivers/gpu/drm/i915/display/intel_cx0_phy.h | 2 --
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c
b/drivers/gpu/drm/i915
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 36 ++
drivers/gpu/drm/i915/display/intel_ddi.c | 116 +++---
.../drm/i915/display/intel_ddi_buf_trans.c| 14 +--
.../i915/display/intel_display_power_well.c | 2 +-
drivers/gpu/drm/i915
-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cx0_phy.c | 9 +
drivers/gpu/drm/i915/display/intel_cx0_phy.h | 1 +
drivers/gpu/drm/i915/display/intel_display.c | 40
drivers/gpu/drm/i915/display/intel_display.h | 7
4 files changed, 57 insertions(+)
diff --git
Pass encoder to intel_snps_phy_update_psr_power_state().
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_psr.c | 7 ++-
drivers/gpu/drm/i915/display/intel_snps_phy.c | 6 --
drivers/gpu/drm/i915/display/intel_snps_phy.h | 4 ++--
3 files changed, 8 insertions
Pass encoder to intel_wait_ddi_buf_active().
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
b/drivers/gpu/drm/i915/display/intel_ddi.c
index
Pass encoder to the _port_to_ddc_pin() functions, and rename to
_encoder_to_ddc_pin().
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 60 ++-
1 file changed, 37 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
ely not being
able to do stuff unless you have that encoder for that specific
port/phy. And have a reference to it.
Thoughts?
BR,
Jani.
[1] https://lore.kernel.org/r/87y1dnswgo@intel.com
Jani Nikula (7):
drm/hdmi: convert *_port_to_ddc_pin() to *_encoder_to_ddc_pin()
drm/i915/ddi: pass enco
2f174 100644
>> --- a/drivers/gpu/drm/display/drm_dp_helper.c
>> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
>> @@ -3982,6 +3982,13 @@ int drm_dp_bw_overhead(int lane_count, int hactive,
>> u32 overhead = 100;
>> int symbol_cycles;
>>
>> +if (bpp_x16 == 0) {
>> +DRM_DEBUG("drm_dp_bw_overhead called with bpp 0\n");
>> +}
>> +if (lane_count == 0 || hactive == 0 || bpp_x16 == 0) {
>
> Could you add lane_count and hactive to the debug print as well?
> Something like "Invalid BW overhead params: lane_count %d, hactive %d,
> bpp_x16 %d.04d".
And within one if instead of two, and use DRM_DEBUG_KMS, and it debug
logs the function, no need to duplicate it.
BR,
Jani.
>
>> +return 0;
>> +}
>> +
>> /*
>> * DP Standard v2.1 2.6.4.1
>> * SSC downspread and ref clock variation margin:
>> --
>> 2.39.2
>>
--
Jani Nikula, Intel
he report, fix at
https://lore.kernel.org/r/20240312115757.683584-1-jani.nik...@intel.com
BR,
Jani.
--
Jani Nikula, Intel
check")
Cc: Radhakrishna Sripada
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_opregion.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_opregion.h
b/drivers/gpu/drm/i915/display/intel_opregion.h
index 63573c38d735..4b2b8e752
t
>> > drm_buddy ttm drm_display_helper drm_kms_helper cec rc_core drm nvme
>> > nvme_core mxm_wmi xhci_pci xhci_pci_renesas video wmi
>> > pinctrl_cannonlake mac_hid ---[ end trace ]---
>> >
>> > Fix this by avoiding the divide if bpp is 0.
>> >
>> > Fixes: c1d6a22b7219 ("drm/dp: Add helpers to calculate the link BW
>> > overhead")
>> > Signed-off-by: Chris Bainbridge
>> > ---
>> > drivers/gpu/drm/display/drm_dp_helper.c | 3 +++
>> > 1 file changed, 3 insertions(+)
>> >
>> > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
>> > b/drivers/gpu/drm/display/drm_dp_helper.c
>> > index b1ca3a1100da..bb8794c8f99c 100644
>> > --- a/drivers/gpu/drm/display/drm_dp_helper.c
>> > +++ b/drivers/gpu/drm/display/drm_dp_helper.c
>> > @@ -4024,6 +4024,9 @@ int drm_dp_bw_overhead(int lane_count, int
>> hactive,
>> > bpp_x16,
>> symbol_size,
>> > is_mst);
>> >
>> > + /* Avoid potential divide by zero in DIV_ROUND_UP_ULL */
>> > + if (bpp_x16 == 0)
>> > + return 0;
>> >return DIV_ROUND_UP_ULL(mul_u32_u32(symbol_cycles *
>> symbol_size * lane_count,
>> >overhead * 16),
>> >hactive * bpp_x16);
>>
>> P. P.S.:
>>
>> #regzbot duplicate:
>> https://lore.kernel.org/all/ZcfpqwnkSoiJxeT9@debian.local/
>> #regzbot poke
--
Jani Nikula, Intel
On Fri, 08 Mar 2024, Jani Nikula wrote:
> Follow-up to [1], with the already merged patches dropped, review
> comments addressed, some new patches added, etc.
>
> I did still leave in the FIXME comments in "drm/i2c: silence ch7006.h
> and sil164.h kernel-doc warnings
On Fri, 08 Mar 2024, Jani Nikula wrote:
> Ensure drm headers build, are self-contained, have header guards, and
> have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y.
>
> The mechanism follows similar patters used in i915, xe, and usr/include.
>
> To cover include/drm,
rs/gpu/drm/i915/display/intel_opregion.c | 58 ++
> drivers/gpu/drm/i915/display/intel_opregion.h | 1 +
> 3 files changed, 92 insertions(+), 75 deletions(-)
--
Jani Nikula, Intel
Some renames, some formatting fixes, add some missing documentation.
v3: Fix struct ttm_buffer_object .sg documentation (Christian)
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Reviewed-by: Christian König
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_bo.h | 17
Just use 0 and 1 directly, instead of the confusing local variable
that's always set to 0.
Cc: Inki Dae
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/exynos/exynos_dp.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu
lt9611uxc_connector_get_modes() propagates the return value of
drm_edid_connector_add_modes() but stores the int temporarily in an
unsigned int. Use the correct type.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/lontium
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Maxime Ripard
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Philipp Zabel
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/imx/ipuv3/parallel-display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Adrien Grassein
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 16 +++-
1 file changed, 7 insertions(+), 9
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Inki Dae
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 4 ++--
drivers/gpu/drm
-by: Jani Nikula
---
drivers/gpu/drm/drm_panel.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index e814020bbcd3..cfbe020de54e 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm
The drm_connector_helper_funcs .get_modes() hooks are not supposed to
return negative error codes. Some do, but they're not checked, and could
lead to mysterious errors. Fix this all over the place.
BR,
Jani.
Jani Nikula (8):
drm/probe-helper: warn about negative .get_modes()
drm/panel: do
.
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_probe_helper.c | 7 +++
include/drm/drm_modeset_helper_vtables.h | 3 ++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c
b/drivers/gpu/drm
*/
>
> #include
> +#include
> +#include
> #include
>
> #include "i915_memcpy.h"
--
Jani Nikula, Intel
/Kbuild files.
Suggested-by: Daniel Vetter
Cc: David Airlie
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: Masahiro Yamada
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
Kbuild | 1 +
drivers/gpu/drm/Kconfig | 11
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper_internal.h
b/drivers/gpu/drm
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/display/drm_dp_mst_topology_internal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology_internal.h
b/drivers/gpu/drm
struct seq_file needs a forward declaration in some configs. Sort the
forward declarations while at it.
Cc: Christian Koenig
Cc: Huang Rui
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202403072259.eec2vf1x-...@intel.com/
Signed-off-by: Jani Nikula
---
include
There's no proper way to document function pointer members, but at least
silence the warnings.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_kmap_iter.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Fix some formatting errors and excess documentation.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_execbuf_util.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/drm/ttm/ttm_execbuf_util.h
Include for pgprot_t.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_caching.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/ttm/ttm_caching.h b/include/drm/ttm/ttm_caching.h
index 235a743d90e1
Some renames, some formatting fixes, add some missing documentation.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_bo.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/include/drm/ttm
From: Geert Uytterhoeven
When just including :
include/asm-generic/pgtable-nop4d.h:9:18: error: unknown type name ‘pgd_t’
9 | typedef struct { pgd_t pgd; } p4d_t;
| ^
Make self-contained by including .
Reported-by: Jani Nikula
Closes: https
Make documentation match code. Slightly fix up the documentation
comments while at it.
v2:
- Move comments next to members instead of struct comment (Lucas)
- Small fixups while at it
Cc: Lucas De Marchi
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm
Make the documentation match code.
v2: Small fixups while at it (Lucas)
Acked-by: Thomas Zimmermann
Reviewed-by: Lucas De Marchi
Signed-off-by: Jani Nikula
---
include/drm/i915_hdcp_interface.h | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/include
There's no proper way to document function pointer members, but at least
silence the warnings.
Acked-by: Thomas Zimmermann
Reviewed-by: Lucas De Marchi
Signed-off-by: Jani Nikula
---
include/drm/i915_gsc_proxy_mei_interface.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Mark some members private to silence kernel-doc warnings, and add FIXME
comments.
Signed-off-by: Jani Nikula
---
include/drm/i2c/ch7006.h | 1 +
include/drm/i2c/sil164.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/drm/i2c/ch7006.h b/include/drm/i2c/ch7006.h
index 8390b437a1f8
Document structs drm_encoder_slave_funcs, drm_encoder_slave, and
drm_i2c_encoder_driver.
v2: Actually document the structs instead of just silencing kernel-doc
Signed-off-by: Jani Nikula
---
include/drm/drm_encoder_slave.h | 91 +++--
1 file changed, 74 insertions
Including the file twice can lead to errors.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_helper_internal.h
b/drivers/gpu/drm/drm_crtc_helper_internal.h
index 28e04e750130
Including the file twice can lead to errors.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_internal.h
b/drivers/gpu/drm/drm_crtc_internal.h
index c0c5d79ed4c9..0c693229a1c9 100644
ostly self-explanatory. I hope
that's fine.
BR,
Jani.
[1] https://lore.kernel.org/all/cover.1709749576.git.jani.nik...@intel.com/
Geert Uytterhoeven (1):
m68k: pgtable: Add missing #include
Jani Nikula (15):
drm: add missing header guards to drm_crtc_internal.h
drm: add missing hea
On Thu, 07 Mar 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Remove the pointless (void*) cast, the incoming pointer is already
> the correct type.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_sdvo.c | 2
rguments to be a bit more
> descriptive than just 'x'.
Reviewed-by: Jani Nikula
>
> TODO: maybe convert *all* container_of() uses to container_of_const()?
I wish they'd made container_of() handle constness directly... but that
approach probably fails all over the place exactly bec
On Thu, 07 Mar 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The connector state passed to .atomic_get_property() is const.
> We should preserve that when downcasting to our version.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> driv
On Thu, 07 Mar 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use enc_to_intel_dsi() instead hand rolling it.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 3 +--
> drivers/gpu/drm/i915/display/vlv_
On Thu, 07 Mar 2024, Lucas De Marchi wrote:
> On Wed, Mar 06, 2024 at 08:31:22PM +0200, Jani Nikula wrote:
>>Make documentation match code.
>>
>>Signed-off-by: Jani Nikula
>>---
>> include/drm/i915_pxp_tee_interface.h | 19 ---
>> 1 file
On Thu, 07 Mar 2024, Jani Nikula wrote:
> Switch to drm device based logging and WARNs, and unify connector and
> crtc logging formats. Pass drm device around a bit more to be able to do
> this.
Forgot to mention that I also stop logging about -ENOMEM, instead of
converting that ov
On Thu, 07 Mar 2024, Jani Nikula wrote:
> @@ -489,7 +489,6 @@ void drm_sysfs_connector_hotplug_event(struct
> drm_connector *connector)
> drm_dbg_kms(connector->dev,
> "[CONNECTOR:%d:%s] generating connector hotplug event\n",
>
Switch to drm device based logging and WARNs, and unify connector and
crtc logging formats. Pass drm device around a bit more to be able to do
this.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_client_modeset.c | 129 +++
1 file changed, 70 insertions(+), 59
Prefer drm_err() over DRM_ERROR().
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_modes.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
index 0fff5a8d4d81..bf0f745dd9bd 100644
Prefer drm_dbg_kms() and drm_dbg_lease() over DRM_DEBUG_KMS() and
DRM_DEBUG() to debug log the drm device info. Fix some debug categories
and unify connector logging while at it.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_sysfs.c | 21 ++---
1 file changed, 10 insertions
to format:
i915 :00:02.0: [drm] Rejected mode: "6144x3456": 60 1378800 6144 6192 6224
6464 3456 3459 3464 3555 0x48 0x9
i915 :00:02.0: [drm] Rejected mode: "6144x3456": CLOCK_HIGH
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_modes.c | 11 +++
1 fi
60 533250 3840 3888 3920
4000 2160 2163 2168 0x48 0x9
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_probe_helper.c | 41 +++---
1 file changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c
b/drivers/gpu/drm/drm_
Add a printer based function for dumping the modeline, so it's not
limited to KMS debug.
Note: The printed output intentionally does not have the "Modeline"
prefix. Prefix, if any, is for the caller to decide when initializing
drm_printer.
Signed-off-by: Jani Nikula
---
drive
Switch a handful of places over to drm device based logging and WARNs,
unify connector and crtc logging, etc.
Jani Nikula (6):
drm/modes: add drm_mode_print() to dump mode in drm_printer
drm/probe-helper: switch to drm device based logging
drm/modes: switch drm_mode_prune_invalid() to use
On Thu, 07 Mar 2024, Geert Uytterhoeven wrote:
> Hi Jani,
>
> On Thu, Mar 7, 2024 at 9:44 AM Jani Nikula wrote:
>> On Thu, 07 Mar 2024, kernel test robot wrote:
>> > kernel test robot noticed the following build errors:
>>
>> So I'm trying to make include/
On Thu, 07 Mar 2024, Thomas Zimmermann wrote:
> Hi
>
> Am 06.03.24 um 19:31 schrieb Jani Nikula:
>> First, fix a bunch of issues in drm headers, uncovered with the last
>> patch. A few kernel-doc warnings are just brushed under the carpet for
>> now, with a FIXME
On Thu, 07 Mar 2024, Alex Deucher wrote:
> On Wed, Mar 6, 2024 at 1:43 PM Jani Nikula wrote:
>>
>> Include for u8.
>>
>> Signed-off-by: Jani Nikula
>
> Acked-by: Alex Deucher
>
> Do you want me to pick this up? Otherwise, feel free to take it via
> wh
On Wed, 28 Feb 2024, Bhanuprakash Modem wrote:
> Rename cpu_transcoder_has_drrs() to intel_cpu_transcoder_has_drrs()
> and make it as non-static, therefore it can be re-used.
>
> V2:
> - Move helpers to intel_drrs.[ch] (Jani)
> - Fix commit message (Jani)
>
> Cc:
On Wed, 06 Mar 2024, Rodrigo Vivi wrote:
> On Wed, Mar 06, 2024 at 02:24:36PM +0200, Jani Nikula wrote:
>> Convert various pointers to struct intel_display * using _Generic().
>>
>> Add some macro magic to make adding new conversions easier, and somewhat
>> abstract th
On Thu, 07 Mar 2024, Thomas Zimmermann wrote:
> Hi
>
> Am 06.03.24 um 19:31 schrieb Jani Nikula:
>> First, fix a bunch of issues in drm headers, uncovered with the last
>> patch. A few kernel-doc warnings are just brushed under the carpet for
>> now, with a FIXME
t-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Jani-Nikula/drm-crtc-make-drm_crtc_internal-h-self-contained/20240307-023603
> base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
> patch link:
> https://lore.kernel.org/r/e22
Including the file twice can lead to errors.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_internal.h
b/drivers/gpu/drm/drm_crtc_internal.h
index c0c5d79ed4c9..0c693229a1c9 100644
Forward declare struct drm_printer and include .
v2: Include (kernel test robot)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_internal.h
b/drivers/gpu/drm/drm_crtc_internal.h
index
/Kbuild files.
Suggested-by: Daniel Vetter
Cc: David Airlie
Cc: Daniel Vetter
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: Masahiro Yamada
Signed-off-by: Jani Nikula
---
Kbuild | 1 +
drivers/gpu/drm/Kconfig | 11 +++
drivers/gpu/drm
301 - 400 of 14886 matches
Mail list logo
