On Fri, 26 Mar 2021, Jani Nikula wrote:
> On Thu, 25 Mar 2021, "Souza, Jose" wrote:
>> On Mon, 2021-03-08 at 15:56 +0200, Jani Nikula wrote:
>>> Add new runtime info field for stepping. Add new helpers for accessing
>>> them. As we'll be
in drm-next they will backmerge, and the -gt-next tree is open for
> business again.
I guess worth noting is that drm-intel-gt-next is now rebased on top of
current drm-next. Since the topic branch is part of drm-tip, I presume
the conflicts are manageable.
BR,
Jani.
--
Jani Nikula, Intel Ope
On Fri, 26 Mar 2021, Jani Nikula wrote:
> v4 of [1], minor tweaks to address review.
>
> BR,
> Jani.
>
> [1] https://patchwork.freedesktop.org/series/87323/
Pushed to drm-intel-next, thanks for the reviews.
BR,
Jani.
>
>
> Jani Nikula (7):
> drm/i915: split o
v2 of [1], addressing Ville's review comments, and adding a couple of
extra patches on top.
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/87802/
Jani Nikula (8):
drm/edid: make a number of functions, parameters and variables const
drm/displayid: add separate drm_displayid.c
If there's no need to change it, it should be const. There's more to be
done, but start off with changes that make follow-up work easier. No
functional changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_ed
lä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/Makefile| 2 +-
drivers/gpu/drm/drm_displayid.c | 59 +
drivers/gpu/drm/drm_edid.c | 58 ++--
include/drm/drm_displayid.h | 8 +
include/drm/drm_edid.h
ille)
- remove __ prefix from displayid_iter_block
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_displayid.c | 74 +
include/drm/drm_displayid.h | 18
2 files changed, 92 insertions(+)
diff --git a/drivers/gpu/drm/drm_displayid.c b/dr
Neatly reduce displayid boilerplate in code. No functional changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 23 ++-
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm
Neatly reduce displayid boilerplate in code. No functional changes.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm
Neatly reduce displayid boilerplate in code. Remove excessive debug
logging while at it, no other functional changes.
The old displayid iterator becomes unused; remove it as well as make
drm_find_displayid_extension() static.
Reviewed-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers
The DisplayID specifications explicitly call out 0 as a valid payload
length for data blocks. The mere presence of a data block, or the
information coded in the block specific data (bits 7:3 in offset 1), may
be enough to convey the necessary information.
Signed-off-by: Jani Nikula
---
drivers
Avoid any confusion with High Dynamic Range. No functional changes.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_displayid.c | 10 +-
include/drm/drm_displayid.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_displayid.c b/drivers
On Fri, 26 Mar 2021, Maxime Ripard wrote:
> Hi,
>
> On Fri, Mar 26, 2021 at 11:47:58AM +0200, Jani Nikula wrote:
>> On Tue, 23 Mar 2021, Ankit Nautiyal wrote:
>> > Currently the FRL training mode (Concurrent, Sequential) and
>> > training type (Normal, Exten
On Thu, 25 Mar 2021, Jani Nikula wrote:
> On Wed, 24 Mar 2021, Anshuman Gupta wrote:
>> HDCP DP 2.2 errata is part of HDCP DP 2.3 specs
>> as well.
>>
>> Anshuman Gupta (2):
>> drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg
>> drm/hdc
}
>> +}
>> +
>> byte = buf;
>> *byte = msg_id;
>>
>> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
>> index ac22c246542a..2b165a0f434f 100644
>> --- a/include/drm/drm_hdcp.h
>> +++ b/include/drm/drm_hdcp.h
>>
On Mon, 29 Mar 2021, Jani Nikula wrote:
> v2 of [1], addressing Ville's review comments, and adding a couple of
> extra patches on top.
>
> BR,
> Jani.
>
> [1] https://patchwork.freedesktop.org/series/87802/
Pushed to drm-misc-next, with Ville's review and Maxim
dst_stride!=width/height
drm/i915: Fix docbook header for __intel_runtime_pm_get_if_active()
Jani Nikula (23):
drm/i915: remove unused ADLS_REVID_* macros
drm/i915/bios: mass convert dev_priv to i915
drm/i915/bios: store bdb version in i915
drm/i915/bios: re
Prefer i915 over drm pointer.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c
b/drivers/gpu/drm/i915/display/intel_hdmi.c
index d69f0a6dc26d
dst_w * dst_h);
> }
>
> +unsigned int intel_plane_pixel_rate(const struct intel_crtc_state
> *crtc_state,
> + const struct intel_plane_state *plane_state)
> +{
> + if (!plane_state->uapi.visible)
Potential functional change not covere
e same
thing after the division?
BR,
Jani.
> - if (pipe_h < pfit_h)
> - pipe_h = pfit_h;
> -
> - if (drm_WARN_ON(crtc_state->uapi.crtc->dev,
> - !pfit_w || !pfit_h))
> - return pixel_rate;
> -
> - return
On Tue, 30 Mar 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Split the glk+ stuff into it's own version of the .min_cdclk()
> vfunc.
>
> Signed-off-by: Ville Syrjälä
For the series,
Reviewed-by: Jani Nikula
> ---
> .../drm/i915/display/
c;
> struct device *dev;
> + struct drm_device *drm_dev;
Bikeshed, I would probably have called it just drm for brevity, but no
strong feelings.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing lis
drm_dp_mst_topology_mgr
> to drm_dp_get_vc_payload_bw()" as this was the style in use
> previously, and 2 chars over the limit looks nicer then trying to
> line-wrap this
> * Don't rewrap comments
For anything touching i915, and for merging via whichever tree or branch
see
On Thu, 01 Apr 2021, Ville Syrjälä wrote:
> On Thu, Apr 01, 2021 at 03:55:20PM +0300, Jani Nikula wrote:
>> On Tue, 30 Mar 2021, Ville Syrjala wrote:
>> > From: Ville Syrjälä
>> >
>> > Replace the hand rolled pfit downscale calculations with
>> > i
by the consumer (opposed to what was actually implemented in
> hardware in reply to the last request). To make this semantic obvious
> rename the function.
>
> Signed-off-by: Uwe Kleine-König
> ---
> drivers/gpu/drm/i915/display/intel_panel.c | 4 +--
Acked-by: Jani Nikula
-
gt_max_freq_mhz_store(struct device *kdev,
> @@ -387,8 +382,7 @@ static ssize_t gt_min_freq_mhz_show(struct device *kdev,
> struct device_attribute
> struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);
> struct intel_rps *rps = &dev_priv->gt.rps;
>
> -
On Tue, 23 Mar 2021, Lyude Paul wrote:
> On Tue, 2021-03-23 at 16:06 +0200, Jani Nikula wrote:
>> On Thu, 18 Mar 2021, Lyude Paul wrote:
>> > Actually-NAK this. I just realized I've been misreading the bug and that
>> > this
>> > doesn't actually s
ce or two different devices.
Cc: Ville Syrjälä
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2794
Signed-off-by: Jani Nikula
---
Is the name "intel_backlight" part of the UABI? In theory the userspace
should only look at the names and types available under
/sys/class/bac
>
> * Linux: CI_DRM_9931 -> Patchwork_19897
>
> CI-20190529: 20190529
> CI_DRM_9931: 88d3a98ecbb1264e9046972e1103ac11b573bf83 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_6059: fae783adafb5face387d2df7a983de5c1d752b45 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19897: 9a58db04f241c83503c0a25dd4d30b78424d3662 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 9a58db04f241 drm/i915/backlight: switch to unique backlight device names
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19897/index.html
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, 07 Apr 2021, Andy Shevchenko wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
>
> Signed-off-by: Andy Shevchenko
That's hardly drm/i915 specific!
Reviewed-by: Jani Nikula
But who's g
res, buf_i, bpp_i;
>
> if (vdsc_cfg->slice_height >= 8)
> rc->first_line_bpg_offset = 12 + DIV_ROUND_UP((9 * min(34,
> vdsc_cfg->slice_height - 8)), 100);
> @@ -409,7 +410,26 @@ calculate_rc_params(struct rc_parameters *rc,
&g
t,
and are all in sync, it's only the drm-next -> drm-misc-next backmerge
that's still needed.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop
; versus "version" but Jani suggested using the
> full word "version" when we were first adding this, so you should
> probably get an ack from him.
For display version there were precious few places where we actually
needed to refer to it, so I thought the longer ve
16c75927a12..405883a8cc84 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -162,6 +162,9 @@ enum intel_ppgtt_type {
> struct intel_device_info {
> u16 gen_mask;
>
> + u8 graphics_ver;
> + u8 media_ver;
> +
> u8 gen;
> u8 gt; /* GT number, 0 if undefined */
> intel_engine_mask_t platform_engine_mask; /* Engines supported by the
> HW */
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, 12 Apr 2021, Jani Nikula wrote:
> On Wed, 07 Apr 2021, Lucas De Marchi wrote:
>> Like it was done in
>> commit 01eb15c9165e ("drm/i915: Add DISPLAY_VER() and related macros")
>> add the correspondent macros for graphics and media. Going forward we
>>
lly in the mmio macros), and it would be a terrible
> flag day.
FWIW, we had the dev_priv/dev macro trickery for a while to not have
that flag day conversion, until everything used i915 or &i915->drm. But
we got rid of it afterwards.
BR,
Jani.
--
Jani Nikula, I
t(dev_priv, PORT_F);
> - /*
> - * On SKL we don't have a way to detect DDI-E so we rely on VBT.
> - */
> - if (IS_DISPLAY_VER(dev_priv, 9)
> - intel_ddi_init(dev_priv, PORT_E);
> } else if (HAS_PCH_SPLIT(dev_priv)) {
> int found;
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
gned-off-by: Lucas De Marchi
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_audio.c
> b/drivers/gpu/drm/i915/display/intel_audio.c
> index
same way use used "gen" rather than "generation", use "ver"
> instead of "version".
>
> Signed-off-by: Lucas De Marchi
> Reviewed-by: José Roberto de Souza
> Acked-by: Jani Nikula
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i
)->caps)
>
> -#define INTEL_GEN(dev_priv) (INTEL_INFO(dev_priv)->gen)
> #define INTEL_DEVID(dev_priv)(RUNTIME_INFO(dev_priv)->device_id)
>
> +/*
> + * Deprecated: this will be replaced by individual IP checks:
> + * GRAPHICS_VER(), MEDIA_VER and DISPLAY_VER()
Nitpi
E1; @@
> - IS_DISPLAY_VER(dev_priv, E1)
> + DISPLAY_VER(dev_priv) == E1
>
> @@ expression dev_priv, from, until; @@
> - IS_DISPLAY_RANGE(dev_priv, from, until)
> + IS_DISPLAY_VER(dev_priv, from, until)
>
Thanks for summing up the discussion in a deligh
t; as is for automatic conversion later.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/gt/intel_engine_cs.c| 40 ++--
> drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 18 -
> 2 files changed, 29 insertions(+), 29 d
On Mon, 12 Apr 2021, Lucas De Marchi wrote:
> Since its introduction 2 years ago, we never used the mask to span more
> than one gen. Replace gen_mask a single number and start using the new
> GRAPHICS_VER().
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Jani Nikula
> ---
6, 7,
> 0x38,
> },
> {
> "RING_MI_MODE",
> - INTEL_GEN_MASK(8, BITS_PER_LONG),
> + 8, U8_MAX,
Makes me wonder if we should add VER_MAX. Can be do
,10 @@ static inline struct drm_i915_private
> *pdev_to_i915(struct pci_dev *pdev)
> * GRAPHICS_VER(), MEDIA_VER and DISPLAY_VER()
> */
> #define INTEL_GEN(dev_priv) (INTEL_INFO(dev_priv)->gen)
> +/*
> + * Deprecated: use IS_GRAPHICS_VER()
> + */
Nitpick, I think this
u64 target_addr)
> {
> - const unsigned int gen = eb->reloc_cache.gen;
> + const unsigned int ver = eb->reloc_cache.graphics_ver;
Nitpick, I think I'd like to use the more specific name throughout, also
for local variables, i.e. graphics_ver, media_ver, or
* Deprecated: use IS_GRAPHICS_VER()
> */
> #define IS_GEN_RANGE(dev_priv, s, e) IS_GRAPHICS_VER(dev_priv, (s), (e))
> +/*
> + * Deprecated: use GRAPHICS_VER()
> + */
Nitpick, also mention media and display variants here.
Reviewed-by: Jani Nikula
> +#define IS_GEN(dev_priv, n)
On Mon, 12 Apr 2021, Lucas De Marchi wrote:
> Since we are now converting from a single gen version to graphics_ver,
> media_ver and display_ver, add the last 2 when printing the device info.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Jani Nikula
> ---
> dr
GEN() macro.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_pci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 1453c1436f31.
, 2) don't
revert it but cherry-pick it to the topic branch also.
Cc: Joonas and Daniel for their input on this as well.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ay.c | 3 ++-
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
> drivers/gpu/drm/i915/display/skl_universal_plane.c| 2 +-
> 5 files changed, 8 insertions(+), 7 deletions(-)
--
Jani Nikula, Intel Open Sourc
On Tue, 13 Apr 2021, Jani Nikula wrote:
> On Mon, 12 Apr 2021, Lucas De Marchi wrote:
>> Like was done for the display part that parted ways with INTEL_GEN(),
>> replacing with DISPLAY_VER(), do a similar conversion for the rest of
>> the driver.
>>
>> v1.1: Remo
: Matt Roper
> Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
I think this should be:
Fixes: 005e95377249 ("drm/i915/display: Eliminate most usage of INTEL_GEN()")
Right?
Reviewed-by: Jani Nikula
> Signed-off-by: Ville Syrjälä
> ---
> driv
On Wed, 14 Apr 2021, Jani Nikula wrote:
> On Mon, 12 Apr 2021, Ville Syrjala wrote:
>> From: Ville Syrjälä
>>
>> We lost the FBC 16bpp 512byte stride requirement on glk when
>> we switched from display version 9 to 10. Restore the w/a to
>> avoid enabling FBC w
on tests")
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c
> b/drivers/gpu/drm/i915/displa
ion.
>
> Cc: Matt Roper
> Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> 1 file changed, 1 insertion(+
ut I find it a bit less confusing when bxt/glk are
> fully separated from the logic for the other platforms.
>
> Signed-off-by: Ville Syrjälä
The whole hpd pin code could use a relocation from intel_ddi.c and some
overhaul.
But first things first,
Reviewed-by: Jani Nikula
>
On Mon, 12 Apr 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Now that glk display version is 10 we can drop a few more glk checks.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
&g
On Tue, 13 Apr 2021, Jani Nikula wrote:
> On Mon, 12 Apr 2021, Ville Syrjala wrote:
>> From: Ville Syrjälä
>>
>> Fix a couple of regressions due to the glk display version 9->10
>> change. I *think* all the ones that slipped through involved
>> either DIS
On Wed, 14 Apr 2021, Jani Nikula wrote:
> On Tue, 13 Apr 2021, Jani Nikula wrote:
>> On Mon, 12 Apr 2021, Lucas De Marchi wrote:
>>> Like was done for the display part that parted ways with INTEL_GEN(),
>>> replacing with DISPLAY_VER(), do a similar conversion for
it from the mask.
We'd still be retaining the range macros as IS_GRAPHICS_VER(),
IS_MEDIA_VER() and IS_DISPLAY_VER(), although more for clarity than for
any other reason.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
I915_FORMAT_MOD_Y_TILED:
> + return DISPLAY_VER(dev_priv) >= 9;
So this adds the version check on I915_FORMAT_MOD_Y_TILED which didn't
have it before?
BR,
Jani.
> + case I915_FORMAT_MOD_X_TILED:
> return true;
>
On Wed, 14 Apr 2021, Tvrtko Ursulin wrote:
> On 14/04/2021 14:13, Jani Nikula wrote:
>> On Wed, 14 Apr 2021, Tvrtko Ursulin wrote:
>>> On 13/04/2021 06:09, Lucas De Marchi wrote:
>>>> Now that it's not used anywhere, remove it from struct
>>>> int
/intel_gtt.h | 5 +
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/i915_pci.c | 22 +
> drivers/gpu/drm/i915/i915_reg.h | 2 +
> drivers/gpu/drm/i915/intel_device_info.c | 1 +
> drivers/gpu/drm/i915/intel
h S3RST any S3 may become S4! */
> simulate_hibernate(i915);
>
> - pm_resume(i915);
> + i915_pm_resume(i915);
>
> err = switch_to_context(ctx);
> out:
> @@ -192,7 +192,7 @@ static int igt_gem_hibernate(void *arg)
> /* Here be dragons! */
&g
915/intel_pm.c| 50 -
drivers/gpu/drm/i915/intel_uncore.c| 8 ++-
drivers/gpu/drm/i915/selftests/intel_uncore.c | 8 ++-
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
51 files changed, 376 inser
On Fri, 16 Apr 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> A bunch of drive-by-cleanup While I was reading through
> the dbuf code.
Good stuff. On the series,
Reviewed-by: Jani Nikula
Some thoughts provoked by the series:
* Time to start splitting up dbuf/ddb/wm stuff f
all pm_ prefixed functions in the file
Signed-off-by: Hsin-Yi Wang
Reported-by: kernel test robot
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/selftests/i915_gem.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests
On Tue, 20 Apr 2021, Rodrigo Vivi wrote:
> On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote:
>> From: Hsin-Yi Wang
>>
>> pm_resume and pm_suspend might be conflict with the ones defined in
>> include/linux/suspend.h. Rename all pm_* to igt_pm_* in selft
On Tue, 20 Apr 2021, Rodrigo Vivi wrote:
> On Tue, Apr 20, 2021 at 05:41:47PM +0300, Jani Nikula wrote:
>> On Tue, 20 Apr 2021, Rodrigo Vivi wrote:
>> > On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote:
>> >> From: Hsin-Yi Wang
>> >>
>&g
tract the dpcd
backlight code from i915 to drm helpers, and I think the min brightness
should be handled after or in connection with that change.
BR,
Jani.
>
> Cc: Jani Nikula
> Cc: Ville Syrjala
> Cc: Lyude Paul
> Cc: Cooper Chiou
>
> Signed-off-by: Lee Shawn C
&g
ssible check
>
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 5 -
> drivers/gpu/drm/i915/gvt/gtt.c | 6 --
> drivers/gpu/drm/i915/gvt/gvt.c| 8
> 3 files changed, 4 insertions(+), 15 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
we can merge it to both drm-intel-next
and drm-intel-gt-next.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, 15 Apr 2021, Jani Nikula wrote:
> On Wed, 14 Apr 2021, Imre Deak wrote:
>> Alder Lake-P adds a new Display Page Table hardware structure, mapping
>> tiled framebuffer pages to the display engine, reducing the address
>> space required in GGTT for these framebuffers
On Wed, 21 Apr 2021, Imre Deak wrote:
> On Wed, Apr 21, 2021 at 02:03:45PM +0300, Jani Nikula wrote:
>> On Thu, 15 Apr 2021, Jani Nikula wrote:
>> > On Wed, 14 Apr 2021, Imre Deak wrote:
>> >> Alder Lake-P adds a new Display Page Table hardware structure, mapping
erly abstracted.
> - allows future junction with CSR_VERSION for simplicity.
> - Enforces dmc file will never change this standard.
>
> v2: define DMC_PATH inside .c (Lucas)
>
> Cc: Fei Yang
> Cc: Jani Nikula
> Cc: Lucas De Marchi
> Signed-off-by: Rodrigo Vivi
>
On Wed, 14 Apr 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pull the fbc enable vs. disable stuff into a small helper so
> we don't have to have it pollute the higher level modeset code.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
>
On Thu, 15 Apr 2021, Ville Syrjälä wrote:
> On Wed, Apr 14, 2021 at 06:09:23PM +0300, Jani Nikula wrote:
>> On Wed, 14 Apr 2021, Ville Syrjala wrote:
>> > From: Ville Syrjälä
>> >
>> > Write the tiling check in a nicer form.
>> >
>> > Signed
On Wed, 14 Apr 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add some tracpoints for frontbuffer tracking so we can
> try to figure out what's going on.
>
> Signed-off-by: Ville Syrjälä
Acked-by: Jani Nikula
> ---
> .../gpu/drm/i915/display/intel_front
_priv)
> @@ -418,6 +414,7 @@ static void intel_fbc_activate(struct drm_i915_private
> *dev_priv)
> drm_WARN_ON(&dev_priv->drm, !mutex_is_locked(&fbc->lock));
>
> intel_fbc_hw_activate(dev_priv);
> + intel_fbc_recompress(dev_priv);
>
> fbc->no_fbc_reason = NULL;
> }
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, 14 Apr 2021, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We try to set no_fbc_reason when FBC is not possible, let's
> consistently clear when activating FBC.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/
uot;Compressing: %s\n", yesno(mask));
> + if (!plane->has_fbc)
> + continue;
> +
> + seq_printf(m, "%c [CRTC:%d:%s]/[PLANE:%d:%s]: %s\n",
> + fbc->crtc == crtc ? '*
915_reg_t pkg_power_sku;
> + i915_reg_t pkg_energy_status;
> + i915_reg_t pkg_rapl_limit;
> + i915_reg_t pkg_rapl_limit_udw;
> + i915_reg_t plt_energy_status;
> + i915_reg_t reg_energy_status;
> +};
> +
> +struct i915_hwmon {
> + struct device *dev;
> +
_attributes")
>> Signed-off-by: Arnd Bergmann
>> ---
>> drivers/gpu/drm/i915/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Oh kconfig stuff like this makes my head hurt, thanks for finding it
>
> I also can't see an alternati
disable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
> @@ -1271,6 +1274,8 @@ static int i915_drm_resume(struct drm_device *dev)
>
> intel_gvt_resume(dev_priv);
>
> + intel_bxt_dsm_detect(pdev);
> +
In intel_display_resume() perhaps?
(Yay for confusing naming wrt display and modeset, it's a
work-in-progress.)
BR,
Jani.
> enable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
>
> return 0;
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
gt; + "failed to register backlight (%d)\n", ret);
> + goto free_ddc;
> + }
> +
> + platform_set_drvdata(pdev, bd);
> +
> + return 0;
> +
> +free_ddc:
> + if (ddc)
> + put_device(&ddc->dev);
> +
>
On Mon, 26 Apr 2021, Kai-Heng Feng wrote:
> On Fri, Apr 23, 2021 at 3:35 PM Jani Nikula
> wrote:
>>
>> On Fri, 23 Apr 2021, Kai-Heng Feng wrote:
>> > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX
>> > to discrete GFX after S3. This
NGE(i915, 1, 6) instead of IS_GEN(i915, 6) ?
Please see the new deprecation comments in i915_drv.h. We're moving from
GEN to VER. In short, please use the new VER macros for individual
components instead of the generic GEN.
Thanks,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_
i915/hdcp: Fix
uninitialized symbol 'msg_end'").
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> + * recommendation, port should be enabled before plane & pipe */
> if (is_cmd_mode(intel_dsi)) {
> for_each_dsi_port(port, intel_dsi->ports)
> intel_de_write(dev_priv,
--
Jani Nikula, Intel Open Source Graphics Center
_
rst bad commit.
>
> I hope this is the correct mailing list for this issue.
>
> Let me know if you need more information or someone to test it.
This seems to have fallen between the cracks, apologies. Is this still
an issue with newer kernels? If yes, please file a bug at [1].
BR,
Jani
ways
> just use the intel_ types in our vfunc implementations.
>
> intel_crtc we've cleaned up the most I think, intel_encoder a bit less
> perhaps, and intel_connector not really at all. Hence you see a lot more
> of intel_connector floating around. We also don't usually
> class is a module")
> Fixes: 44c1220a441c ("drm/i915: extract intel_panel.h from intel_drv.h")
> Signed-off-by: Randy Dunlap
> Cc: Ville Syrjälä
> Cc: Jani Nikula
> Cc: Damien Lespiau
> Cc: Daniel Vetter
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
&
n fix (Maarten)
Dan Carpenter (2):
drm/i915/gvt: Fix error code in intel_gvt_init_device()
drm/i915: fix an error code in intel_overlay_do_put_image()
Jani Nikula (1):
Merge tag 'gvt-next-fixes-2021-04-21' of
http
; Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_pipe_crc.c | 51 ++-
> 1 file changed, 26 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_pipe_crc.c
> b/drivers/gpu/drm/i9
Add separate intel_dp_hdcp.h to go with intel_dp_hdcp.c, and rename the
init function intel_dp_hdcp_init() to follow naming where function
prefix matches the file name.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 5 +++--
drivers/gpu/drm/i915/display
The definitions are in the crtc and dpll files; move the declarations to
the corresponding headers.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/icl_dsi.c| 1 +
drivers/gpu/drm/i915/display/intel_crt.c | 1 +
drivers/gpu/drm/i915/display/intel_crtc.h | 3
elevant for legacy drivers. In a later patchset, we may want to
> convert these as well and remove pdev entirely.
On the series,
Reviewed-by: Jani Nikula
How should we merge these?
>
> v7:
> * fix instances of pdev that have benn added under i915/
> v6:
> *
quot;drm/i915: Create stolen memory region from local
> memory")
> Cc: CQ Tang
> Cc: Matthew Auld
> Cc: Tvrtko Ursulin
> Cc: Xinyun Liu
> Cc: Tvrtko Ursulin
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: Chris Wilson
> Cc: Mika Kuo
On Tue, 27 Apr 2021, Thomas Zimmermann wrote:
> Hi Jani
>
> Am 27.04.21 um 14:04 schrieb Jani Nikula:
>> On Tue, 27 Apr 2021, Thomas Zimmermann wrote:
>>> V7 of the patchset fixes some bitrot in the intel driver.
>>>
>>> The pdev field in struct drm_d
901 - 1000 of 16156 matches
Mail list logo
