uot;)
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Cc: Andi Shyti
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_active.c
b/drivers/gpu/drm/i91
Hi Andy,
Thanks for review.
On Thursday, 2 March 2023 01:42:05 CET Andi Shyti wrote:
> Hi Janusz,
>
> On Sat, Feb 25, 2023 at 11:12:18PM +0100, Janusz Krzysztofik wrote:
> > Users reported oopses on list corruptions when using i915 perf with a
> > number of concurre
t;), v5.4,
- reword commit description.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Fixes: 311770173fac ("drm/i915/gt: Schedule request retirement when timeline
idles")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Signed-off-by: Janusz Krzyszt
Dummy cover letter to prevent CI / patchwork from picking up a previous
one with an outdated Test-with: clause.
Janusz Krzysztofik (1):
drm/i915/active: Fix misuse of non-idle barriers as fence trackers
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14
t;), v5.4,
- reword commit description.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Fixes: 311770173fac ("drm/i915/gt: Schedule request retirement when timeline
idles")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Signed-off-by: Janusz Krzyszt
Dummy cover letter to prevent CI / patchwork from picking up a previous
one with an outdated Test-with: clause.
Janusz Krzysztofik (1):
drm/i915/active: Fix misuse of non-idle barriers as fence trackers
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14
t;), v5.4,
- reword commit description.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Fixes: 311770173fac ("drm/i915/gt: Schedule request retirement when timeline
idles")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Signed-off-by: Janusz Krzyszt
On Friday, 24 February 2023 09:38:54 CET Kamil Konieczny wrote:
> On 2023-02-13 at 15:34:45 +0100, Janusz Krzysztofik wrote:
> > If any of *-without-i915 subtests fails or skips for any reason, it may
> > leave the i915 module unloaded while keeping our device list populated
>
On Monday, 20 February 2023 21:49:46 CET Kamil Konieczny wrote:
> On 2023-02-20 at 14:24:45 +0100, Janusz Krzysztofik wrote:
> > This test can work not only on render engines, as its current code
> > suggests, but also on compute class engines. Add them to the set of
> > eng
This test can work not only on render engines, as its current code
suggests, but also on compute class engines. Add them to the set of
engine classes supported by the test, in case a future platform has only
those and no RCS available.
Suggested-by: Chris Wilson
Signed-off-by: Janusz
On Thursday, 16 February 2023 01:30:47 CET Patchwork wrote:
> == Series Details ==
>
> Series: tests: Exercise remote request vs barrier handling race
> URL : https://patchwork.freedesktop.org/series/114045/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12741_full
/6333
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
Cc: Kamil Konieczny
Cc: Ashutosh Dixit
Cc: Umesh Nerlige Ramappa
---
tests/i915/gem_barrier_race.c | 153 ++
tests/meson.build | 8 ++
2 files changed, 161 insertions(+)
create mode 100644
Hi Kamil,
Thanks for review.
On Tuesday, 14 February 2023 22:20:10 CET Kamil Konieczny wrote:
> Hi Janusz,
>
> On 2023-02-13 at 10:31:32 +0100, Janusz Krzysztofik wrote:
> > Users reported oopses on list corruptions when using i915 perf with a
> > number of concurre
On Tuesday, 14 February 2023 04:38:12 CET Patchwork wrote:
> == Series Details ==
>
> Series: Resolve barrier tasks list related issues
> URL : https://patchwork.freedesktop.org/series/113975/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12734_full ->
On Tuesday, 14 February 2023 01:11:42 CET Patchwork wrote:
> == Series Details ==
>
> Series: Resolve barrier tasks list related issues
> URL : https://patchwork.freedesktop.org/series/113975/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12734 -> Patchwork_113975v1
from other
kernel requests")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.4
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 6 +++
.../gpu/drm/i915/gt/intel_engine_heartbeat.c | 10 -
drivers/gpu/drm/i915/gt/intel_engine_pm.c | 4 ++
drivers/gpu/d
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.4
---
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_active.c
b/drivers/gpu/drm/i915/i915_active.c
index 7412abf166a8c..f92
rriers from an engine's barrier tasks list.
Note:
Again, I'm submitting this series with a request to CI for testing it
with trybot submission of the new igt@gem_barrier_race@remote-request
subtest, not yet in upstream IGT, to get comparable results from the
widest possible HW range.
Janusz Krzyszto
On Monday, 13 February 2023 19:28:50 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/active: Serialize access to barrier tasks lists
> URL : https://patchwork.freedesktop.org/series/113962/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12732 ->
from other
kernel requests")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.4
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 6 +++
.../gpu/drm/i915/gt/intel_engine_heartbeat.c | 10 -
drivers/gpu/drm/i915/gt/intel_engine_pm.c | 4 ++
drivers/gpu/d
ce
trackers", I'm submitting this fix with a request to CI for testing it
with trybot submission of the new igt@gem_barrier_race@remote-request
subtest, not yet in upstream IGT, to get comparable results from the
widest possible HW range.
Janusz Krzysztofik (1):
drm/i915/active: Serialize access
On Monday, 13 February 2023 14:47:42 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/active: Fix misuse of non-idle barriers as fence trackers
> URL : https://patchwork.freedesktop.org/series/113950/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from
On Monday, 13 February 2023 12:19:10 CET Patchwork wrote:
> == Series Details ==
>
> Series: tests/i915/perf: Add stress / race exercises (rev3)
> URL : https://patchwork.freedesktop.org/series/113522/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from IGT_7160_full ->
t_main@@GLIBC_2.34()
(i915_suspend:9050) igt_core-INFO: #6 [_start+0x2a]
END
Fixes: f7aff600ab16 ("tests/i915/i915_suspend: Disable d3cold_allowed for
basic-s2idle-without-i915")
Signed-off-by: Janusz Krzysztofik
Cc: Riana Tauro
---
lib/drmtest.c | 2 +-
lib/i
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.4
---
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_active.c
b/drivers/gpu/drm/i915/i915_active.c
index 7412abf166a8c..f92
esting it with a new
subtest igt@gem_barrier_race@remote-request, developed for that case,
not yet in upstream IGT. I've selected trybot submission of the test,
with the test added to BAT testlist, to get results from the widest
possible HW range.
Janusz Krzysztofik (1):
drm/i915/active: Fix
On Monday, 13 February 2023 10:51:39 CET Zbigniew Kempczyński wrote:
> On Fri, Feb 10, 2023 at 10:33:21PM +0100, Janusz Krzysztofik wrote:
> > On Thursday, 9 February 2023 20:32:31 CET Janusz Krzysztofik wrote:
> > > If any of *-without-i915 subtests fails or skips for
On Friday, 10 February 2023 12:56:12 CET Janusz Krzysztofik wrote:
> On Friday, 10 February 2023 12:21:58 CET Kamil Konieczny wrote:
> > Hi,
> >
> > On 2023-02-10 at 08:53:12 +0100, Janusz Krzysztofik wrote:
> > > Hi,
> > >
> > > On Thursday, 9 Feb
.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
Cc: Kamil Konieczny
Cc: Ashutosh Dixit
Cc: Umesh Nerlige Ramappa
---
tests/i915/gem_barrier_race.c | 159 ++
tests/meson.build | 8
subtest out of tests/i915/perf.c (Ashutosh).
Janusz Krzysztofik (1):
tests: Exercise remote request vs barrier handling race
tests/i915/gem_barrier_race.c | 159 ++
tests/meson.build | 8 ++
2 files changed, 167 insertions(+)
create mode 100644
Hi Umesh,
On Friday, 10 February 2023 18:24:53 CET Umesh Nerlige Ramappa wrote:
> On Fri, Feb 10, 2023 at 09:20:25AM -0800, Umesh Nerlige Ramappa wrote:
> >On Thu, Feb 09, 2023 at 12:50:39PM +0100, Janusz Krzysztofik wrote:
> >>Users reported oopses on list corruptions wh
On Thursday, 9 February 2023 20:32:31 CET Janusz Krzysztofik wrote:
> If any of *-without-i915 subtests fails or skips for any reason, it may
> leave the i915 module unloaded while keeping our device list populated
> with initially collected data. In a follow up igt_fixture section we t
On Friday, 10 February 2023 15:02:59 CET Kamil Konieczny wrote:
> Hi Janusz,
>
> I have one nit, see below.
>
> On 2023-02-09 at 20:32:31 +0100, Janusz Krzysztofik wrote:
> > If any of *-without-i915 subtests fails or skips for any reason, it may
> > leave the i915 mo
On Friday, 10 February 2023 12:21:58 CET Kamil Konieczny wrote:
> Hi,
>
> On 2023-02-10 at 08:53:12 +0100, Janusz Krzysztofik wrote:
> > Hi,
> >
> > On Thursday, 9 February 2023 12:50:38 CET Janusz Krzysztofik wrote:
> > > Users reported oopses on l
Hi,
On Thursday, 9 February 2023 12:50:38 CET Janusz Krzysztofik wrote:
> Users reported oopses on list corruptions when using i915 perf with a
> number of concurrently running graphics applications. That indicates we
> are currently missing some important tests for such scenario
Fixes: f7aff600ab16 ("tests/i915/i915_suspend: Disable d3cold_allowed for
basic-s2idle-without-i915")
Signed-off-by: Janusz Krzysztofik
Cc: Riana Tauro
---
lib/drmtest.c | 2 +-
lib/igt_device_scan.c | 4
tests/i915/i915_suspend.c | 10 +-
3 files change
/gem_ctx_exec.c.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Signed-off-by: Janusz Krzysztofik
---
tests/i915/gem_ctx_exec.c | 123 ++
tests/meson.build | 9 ++-
2 files changed, 131 insertions(+), 1 deletion(-)
diff --git a/tests/i915
reported bug, but triggering other bugs which I can't see any fixes
for queued yet,
- move the other new subtest out of tests/i915/perf.c (Ashutosh).
Janusz Krzysztofik (1):
tests/gem_ctx_exec: Exercise barrier race
tests/i915/gem_ctx_exec.c | 123
Hi Umesh,
Thanks for taking a look.
On Friday, 3 February 2023 20:21:38 CET Umesh Nerlige Ramappa wrote:
> On Tue, Jan 31, 2023 at 10:17:29AM +0100, Janusz Krzysztofik wrote:
> >Users reported oopses on list corruptions when using i915 perf with a
> >number of concurrently r
Hi Kamil,
On Wednesday, 1 February 2023 19:21:57 CET Kamil Konieczny wrote:
> Hi Janusz,
>
> please send patches to igt ML and add other addresses to cc:
> I have one nit, see below.
>
> On 2023-01-31 at 10:17:31 +0100, Janusz Krzysztofik wrote:
> > Add a new subte
Hi Ashutosh,
On Tuesday, 31 January 2023 19:36:50 CET Dixit, Ashutosh wrote:
> On Tue, 31 Jan 2023 09:36:30 -0800, Janusz Krzysztofik wrote:
> >
> > Since Chris' subtest didn't help in triggering the list corruption, I've
> > developed a new subtest that can do it. Since i
On Tuesday, 31 January 2023 17:55:54 CET Dixit, Ashutosh wrote:
> On Tue, 31 Jan 2023 08:19:48 -0800, Dixit, Ashutosh wrote:
> >
> > On Tue, 31 Jan 2023 01:17:29 -0800, Janusz Krzysztofik wrote:
> > >
> >
> > Hi Janusz,
> >
> > > Users repor
On Tuesday, 31 January 2023 17:19:48 CET Dixit, Ashutosh wrote:
> On Tue, 31 Jan 2023 01:17:29 -0800, Janusz Krzysztofik wrote:
> >
>
> Hi Janusz,
>
> > Users reported oopses on list corruptions when using i915 perf with a
> > number of concurrently running graphics
Hi Kamil,
Thanks for review.
On Tuesday, 31 January 2023 12:59:10 CET Kamil Konieczny wrote:
...
> > @@ -5259,6 +5324,15 @@ igt_main
> > igt_subtest("whitelisted-registers-userspace-config")
> > test_whitelisted_registers_userspace_config();
> >
>
> Please add description to
/-/issues/6333
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
tests/i915/perf.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index e33cacc443..11a3ec21ab 100644
--- a/tests/i915/perf.c
-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Cc: Andi Shyti
---
tests/i915/perf.c | 74 +++
1 file changed, 74 insertions(+)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index dd1f1ac399..e33cacc443 100644
--- a/tests/i915/perf.c
+++ b/tests
existing
contexts
Janusz Krzysztofik (1):
tests/i915/perf: Exercise barrier race
tests/i915/perf.c | 111 ++
1 file changed, 111 insertions(+)
--
2.25.1
On Wednesday, 23 November 2022 13:57:26 CET Tvrtko Ursulin wrote:
>
> On 23/11/2022 09:28, Janusz Krzysztofik wrote:
> > Hi Tvrtko,
> >
> > Thanks for your comments.
> >
> > On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote:
> >>
>
On Tuesday, 22 November 2022 11:41:29 CET Tvrtko Ursulin wrote:
>
> On 21/11/2022 23:19, Janusz Krzysztofik wrote:
> > Hi Andrzej,
> >
> > Thanks for providing your R-b.
> >
> > On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote:
> >>
Hi Tvrtko,
Thanks for your comments.
On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote:
>
> On 21/11/2022 14:56, Janusz Krzysztofik wrote:
> > Users of intel_gt_retire_requests_timeout() expect 0 return value on
> > success. However, we have no protection f
Hi Andrzej,
Thanks for providing your R-b.
On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote:
> On 21.11.2022 15:56, Janusz Krzysztofik wrote:
> > Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work
> > with Gu
Hajda wrote:
> On 21.11.2022 11:59, Janusz Krzysztofik wrote:
> > On Monday, 21 November 2022 11:51:15 CET Janusz Krzysztofik wrote:
> >> Hi Andrzej,
> >>
> >> Thanks for your comment.
> >>
> >> On Monday, 21 November 2022 11:17:42 CET Andrze
() is not affected.
Fixes: f33a8a51602c ("drm/i915: Merge wait_for_timelines with retire_request")
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Andrzej Hajda
Cc: sta...@vger.kernel.org # v5.5+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
.
Janusz Krzysztofik (2):
drm/i915: Fix negative value passed as remaining time
drm/i915: Never return 0 if not all requests retired
drivers/gpu/drm/i915/gt/intel_gt.c | 9 +++--
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +-
2 files changed, 8 insertions(+), 3 deletions
d back via remaining_timeout.
v2: Fix the issue on the caller side, not the provider.
Fixes: b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with
GuC")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.15+
---
drivers/gpu/drm/i915/gt/intel_gt.c | 9 +
On Monday, 21 November 2022 11:51:15 CET Janusz Krzysztofik wrote:
> Hi Andrzej,
>
> Thanks for your comment.
>
> On Monday, 21 November 2022 11:17:42 CET Andrzej Hajda wrote:
> >
> > On 21.11.2022 09:30, Janusz Krzysztofik wrote:
> > > Hi Ni
Hi Andrzej,
Thanks for your comment.
On Monday, 21 November 2022 11:17:42 CET Andrzej Hajda wrote:
>
> On 21.11.2022 09:30, Janusz Krzysztofik wrote:
> > Hi Nimroy,
> >
> > Thanks for looking at this.
> >
> > On Friday, 18 November 2022 20:56:50 CET Das, Ni
On Friday, 18 November 2022 11:42:21 CET Janusz Krzysztofik wrote:
> Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work
> with GuC") extended the API of intel_gt_retire_requests_timeout() with an
> extra argument 'remaining_timeout', intended for pass
Hi Nimroy,
Thanks for looking at this.
On Friday, 18 November 2022 20:56:50 CET Das, Nirmoy wrote:
>
> On 11/18/2022 11:42 AM, Janusz Krzysztofik wrote:
> > Users of intel_gt_retire_requests_timeout() expect 0 return value on
> > success. However, we have no protection f
the timeout value as return
code, so -ETIME is returned if there are still some requests not retired
after timeout, 0 otherwise.
v2: Move the added lines down so flush_submission() is not affected.
Fixes: f33a8a51602c ("drm/i915: Merge wait_for_timelines with retire_request")
Signed-off-
7060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with
GuC")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.15+
---
drivers/gpu/drm/i915/gt/intel_gt.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/i
() is not affected,
reword commit message and description.
PATCH 3: drop -- controversial, not needed.
Janusz Krzysztofik (2):
drm/i915: Fix negative value passed as remaining time
drm/i915: Never return 0 if not all requests retired
drivers/gpu/drm/i915/gt/intel_gt.c | 11
On Wednesday, 16 November 2022 15:42:46 CET Andrzej Hajda wrote:
> On 16.11.2022 12:25, Janusz Krzysztofik wrote:
> > According to the docs of i915_request_wait_timeout(), its return value
> > "may be zero if the request is unfinished after the timeout expires."
> &
he timeout is 0, it will return 1 if the
fence is signaled.", return 1 also when the fence is found signaled after
non-zero timeout has expired.
Fixes: 7e2e69ed4678 ("drm/i915: Fix i915_request fence wait semantics")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v
Merge wait_for_timelines with retire_request")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.5+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_requests.c
b/drivers/gpu/drm/i915/gt/intel_gt_
ot;drm/i915/guc: Update intel_gt_wait_for_idle to work with
GuC")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.15+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 23 ++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/dri
this series and individual patches as v2.
Janusz Krzysztofik (3):
drm/i915: Fix negative remaining time after retire requests
drm/i915: Never return 0 on timeout when retiring requests
drm/i915: Never return 0 if request wait succeeds
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 26
A comma is missing, fix it.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_vma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 3b969d679c1e2..947fde68e5f53 100644
--- a/drivers/gpu/drm
On Wednesday, 9 November 2022 20:09:34 CET Janusz Krzysztofik wrote:
> Fixes for issues discovered via code review while working on
> https://gitlab.freedesktop.org/drm/intel/issues/7349.
>
> Janusz Krzysztofik (3):
> drm/i915: Fix timeout handling when retiring requests
&g
uccess, don't touch it, update the i915_fence_wait() wrapper
instead. Return 1 instead of 0, but keep -ETIME in case of timeout since
some i915 users of dma_fence_wait_timeout() may expect it.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
1 file changed, 1 ins
was intended.
Fix it by replacing -ETIME value of the argument with 0.
Fixes: 09137e945437 ("drm/i915/gem: Unpin idle contexts from kswapd reclaim")
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
lines with retire_request")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.5+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_requests.c
b/drivers/gpu/d
Fixes for issues discovered via code review while working on
https://gitlab.freedesktop.org/drm/intel/issues/7349.
Janusz Krzysztofik (3):
drm/i915: Fix timeout handling when retiring requests
drm/i915: Fix unintended submission flush after retire times out
drm/i915: Fix 0 return value from
I think this issue can hit any user with a platform that loads iommu and
coretemp drivers. Adding regressi...@lists.linux.dev to the loop.
Thanks,
Janusz
On Thursday, 22 September 2022 14:09:35 CEST Robin Murphy wrote:
> On 22/09/2022 11:10 am, Janusz Krzysztofik wrote:
> > From: Chr
On Thursday, 29 September 2022 11:35:23 CEST Patchwork wrote:
> == Series Details ==
>
> Series: iommu: Remove iova cpu hotplugging flushing (rev2)
> URL : https://patchwork.freedesktop.org/series/108880/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12193_full ->
On Wednesday, 28 September 2022 11:22:21 CEST Tvrtko Ursulin wrote:
>
> On 28/09/2022 09:58, Janusz Krzysztofik wrote:
> > Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to
> > flush rcaches"). It is trying to instantiate a cpuhp notifier from
+0x3c1/0x900
<4>[6.961106] ? dev_set_name+0x4e/0x70
<4>[6.961109] platform_device_add+0x108/0x240
<4>[6.961112] coretemp_cpu_online+0xe1/0x15e [coretemp]
<4>[6.961117] ? create_core_data+0x550/0x550 [coretemp]
<4>[6.961120] cpuhp_invoke_callback+
tter in place.
Note: I'm no longer CCing IOMMU nor mainstream, they have been already
warned.
Chris Wilson (1):
iommu: Remove iova cpu hotplugging flushing
Janusz Krzysztofik (1):
Restore "iommu/dma: Fix race condition during iova_domain
initialization"
d
This reverts commit bc79ef6d5a223ea59acf874f0493b79c835b17d4 that
reverted commit ac9a5d522bb80be50ea84965699e1c8257d745ce. That revert is
no longer needed with "iommu: Remove iova cpu hotplugging flushing" in
place that breaks more instances of the same lockdep loop.
Signed-off-
On Thursday, 22 September 2022 21:18:51 CEST Patchwork wrote:
> == Series Details ==
>
> Series: iommu: Remove iova cpu hotplugging flushing
> URL : https://patchwork.freedesktop.org/series/108880/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12166_full ->
On Thursday, 22 September 2022 14:09:35 CEST Robin Murphy wrote:
> On 22/09/2022 11:10 am, Janusz Krzysztofik wrote:
> > From: Chris Wilson
> >
> > Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to
> > flush rcaches"). It is trying
On Thursday, 22 September 2022 12:50:05 CEST Patchwork wrote:
> == Series Details ==
>
> Series: iommu: Remove iova cpu hotplugging flushing
> URL : https://patchwork.freedesktop.org/series/108880/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12166 ->
+0x3c1/0x900
<4>[6.961106] ? dev_set_name+0x4e/0x70
<4>[6.961109] platform_device_add+0x108/0x240
<4>[6.961112] coretemp_cpu_online+0xe1/0x15e [coretemp]
<4>[6.961117] ? create_core_data+0x550/0x550 [coretemp]
<4>[6.961120] cpuhp_invoke_callback+
Hi Robin,
On Wednesday, 14 September 2022 17:54:36 CEST Robin Murphy wrote:
> On 2022-09-14 16:01, Lucas De Marchi wrote:
> > On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote:
> >> This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce.
> >>
> >> This change introduces a
On Friday, 16 September 2022 17:12:30 CEST Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/gem: Really move i915_gem_context.link under ref protection
> (rev4)
> URL : https://patchwork.freedesktop.org/series/105975/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes
d9a9 ("drm/i915/gem: Drop free_work for GEM contexts")
Signed-off-by: Chris Wilson
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
Signed-off-by: Janusz Krzysztofik
Cc: Tvrtko Ursulin
Cc: # v5.12+
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
1 file changed, 4 insert
per around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.
Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Andi S
.
Unfortunately, it is not flushed on driver release. Fix it.
Chris Wilson (1):
drm/i915/gem: Really move i915_gem_context.link under ref protection
Janusz Krzysztofik (1):
drm/i915/gem: Flush contexts on driver release
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
drivers/gpu/drm/
' and so will leak any of the
> common objects allocated.
>
> v2:
> - Drop the destroy_pinned_context() helper for now. It's not really
>worth it with just a single callsite at the moment. (Janusz)
>
> Signed-off-by: Chris Wilson
> Cc: Janusz Krzysztofik
> Si
Please ignore this series, it has issues. I'll update it and resubmit.
Thanks,
Janusz
On Thursday, 15 September 2022 18:52:08 CEST Janusz Krzysztofik wrote:
> i915_perf assumes that it can use the i915_gem_context reference to
> protect its i915->gem.contexts.list iteration
gned-off-by: Chris Wilson
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
Signed-off-by: Janusz Krzysztofik
Cc: Tvrtko Ursulin
Cc: # v5.12+
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_ge
per around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.
Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Andi S
.
Unfortunately, it is not flushed on driver release. Fix it.
Chris Wilson (1):
drm/i915/gem: Really move i915_gem_context.link under ref protection
Janusz Krzysztofik (1):
drm/i915/gem: Flush contexts on driver release
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
drivers/gpu/drm/
se == NULL' and so will leak any of the
> common objects allocated.
>
> Signed-off-by: Chris Wilson
> Cc: Janusz Krzysztofik
> Signed-off-by: Matt Roper
> ---
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 16 +---
> 1 file changed, 13 insertions(+), 3 dele
Hi Tvrtko,
Thanks for review.
On Wednesday, 14 September 2022 17:37:19 CEST Tvrtko Ursulin wrote:
>
> On 13/09/2022 17:10, Janusz Krzysztofik wrote:
> > From: Chris Wilson
> >
> > i915_perf assumes that it can use the i915_gem_context reference to
> > prote
On Wednesday, 14 September 2022 17:15:02 CEST Andi Shyti wrote:
> Hi Krzysztofik,
>
> if you are going to resend it, I just have a little thing if you
> don't mind,
>
> On Tue, Sep 13, 2022 at 06:10:39PM +0200, Janusz Krzysztofik wrote:
> > From: Chris Wilson
&g
per around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.
Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Cc: sta...@kerne
15/gem: Drop free_work for GEM contexts")
Signed-off-by: Chris Wilson
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
Signed-off-by: Janusz Krzysztofik
Cc: Tvrtko Ursulin
Cc: # v5.12+
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++---
drivers/gpu/d
.
Unfortunately, it is not flushed on driver release. Fix it.
Chris Wilson (1):
drm/i915/gem: Really move i915_gem_context.link under ref protection
Janusz Krzysztofik (1):
drm/i915/gem: Flush contexts on driver release
drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++---
drive
result in using different set of
health checks should device filters not work as expected.
Always use the stored chipset type instead of identifying it now and
again.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
201 - 300 of 808 matches
Mail list logo
