On Thu, 2020-10-15 at 09:40 +0200, Marcin Bernatowicz wrote:
> On Wed, 2020-10-14 at 18:55 +0200, Janusz Krzysztofik wrote:
> > The test was designed to keep track of open device file descriptors
> > for safe driver unbind on recovery from a failed subtest. In that
> > conte
alth check a better chance to detect issues - run it
before sysfs health checks.
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
tests/core_hotunplug.c | 61 ++
1 file changed, 56 insertions(+), 5 deletions(-)
diff --git a/tests/core_hotunplug
ugfs areas.
Also, split hotrebind/hotreplug scenarios into a pair of each, one that
performs the health check right after hot rebind/replug and delegates
the device late close step to a follow up recovery phase while the
other one checks device health only after late closing it.
Signed-off-
ng it.
v2: Give GPU health check a better chance to detect issues - run it
before sysfs health checks.
v3: Run sysfs health check on any hardware, not only i915.
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
Even if the root cause has occurred to be sitting on the IGT lib side
an
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
tests/core_hotunplug.c | 46 --
1 file changed, 35 insertions(+), 11 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 70669c590..d6db02bad 100644
--- a/tests/core_hotunplug.c
+
Device bus address structure field is always initialized with a pointer
to a substring of the device sysfs path and never used for its
modification. Declare it as a constant string.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file
in post_healthcheck function name.
v3: Don't fail on close error after successful health check, warn only,
- move duplicated messages to helpers.
v4: On start of each subtest assert device file descriptors closed
cleanly.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests
There is a new library helper that asserts validity of open file
descriptors. Use it instead of open coding.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests
Return value of igt_device_filter_add() representing a number of
successfully installed device filters is now ignored. Fail if not 1.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
bodies.
v2: Rebase only.
v3: Refresh and extend over new case (local_drm_open_driver),
- allow callers to specify a message suffix as well where applicable.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests/core_hotunplug.c | 39
instead of aborting.
For that to be possible, maintain a single instance of hotunplug
structure at igt_main level and pass it down to subtests.
v2: Commit description refreshed.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 56
Return values of driver bind/unbind / device remove/recover sysfs
operations are now ignored. Assert their correctness.
v2: Add trailing newlines missing from igt_assert messages.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 14
e have a look and confirm if
you are still OK with them.
@Tvrtko: As I already asked before, please support my attempt to remove
the unbind test variants from the blocklist.
@Petri, @Martin: Assuming CI results will be as good as those obtained
on Trybot, please give me your green light for me
.
v2: Refresh,
- don't time out on hot driver rebind / hot device restore in
*-lateclose variants, those operations haven't been covered by
other subtests.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 38 --
1 file changed, 20
so display a warning to preserve visibility of the issue. Also
tag the workaround with a FIXME comment.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 361d601af.
-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 305c57a3f..361d601af 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -52,6
Some return values are not useful and can be ignored. Wrap those cases
inside igt_ignore_warn(), not only to make sure compilers are happy but
also to clearly document our decisions.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 6 +++---
1 file
Since health checks are now run from follow-up fixture sections, it is
safe to fail subtests without the need to abort the test execution. Do
that on device close errors instead of just emitting warnings.
v2: Rebase only.
v3: Refresh.
v4: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed
A pointer to fatal error messages can be passed around via hotunplug
structure, no need to declare it as global.
v2: Rebase only.
v3: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 96 +-
1 file
Don't rely on successful write to sysfs control files, assert existence
/ non-existence of a respective device sysfs node as well.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 14 ++
1 file changed, 14 insertions(+)
diff --git
.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index a4071f51e..e576a6c6c 100644
--- a/tests/core_hotunplug.c
+++ b/tests
Subtests which don't remove the device, only unbind the driver from it,
seem relatively safe and harmless for CI. Remove them from the CI
blocklist.
Signed-off-by: Janusz Krzysztofik
---
tests/intel-ci/blacklist.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
Since we no longer open a device DRM sysfs node, only a PCI one, driver
unbind operations are no longer affected by missed or unsuccessful
sysfs file close attempts. Skip only affected subtests if that
happens.
v2: Rebase only.
v3: Refresh.
v4: Refresh.
Signed-off-by: Janusz Krzysztofik
recovery,
- drop caches on i915 health check completion.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 114 +
1 file changed, 104 insertions(+), 10 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 923b8cdfd
closed cleanly on subtest
start, a device sysfs file descriptor still before open.
Suggested-by: Michał Winiarski
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests/core_hotunplug.c | 85 --
1 file changed, 33 insertions
devices also before late
close,
- in order to be able to safely run a health check while still
keeping an unbound / unplugged device instance open, also preserve
the open device fd, not only a close error,
- adjust subtest descriptions.
Signed-off-by: Janusz Krzysztofik
Reviewed
matter.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests/core_hotunplug.c | 100 ++---
1 file changed, 74 insertions(+), 26 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 25508db85..b7236190
On Fri, 2020-08-28 at 11:53 +, Patchwork wrote:
> Patch Details
> Series: tests/core_hotunplug: Fixes and enhancements (rev5)
> URL: https://patchwork.freedesktop.org/series/79671/
> State:failure
> Details: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4914/index.html
>
The purpose of debug messages displayed by the test is to make
identification of a subtest phase that fails more easy. Since issues
exhibited by the test are mostly reported to dmesg, print those debug
messages to /dev/kmsg as well.
v2: Rebase on upstream.
v3: Refresh.
Signed-off-by: Janusz
Subtests which don't remove the device, only unbind the driver from it,
seem relatively safe and harmless for CI. Remove them from the CI
blocklist.
Signed-off-by: Janusz Krzysztofik
---
tests/intel-ci/blacklist.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
Return value of igt_device_filter_add() representing a number of
successfully installed device filters is now ignored. Fail if not 1.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
g but clean the mark only on
health check success,
- call cleanup() also from post_healthcheck() in order to close a
device file descriptor potentially left open by a failed health
check,
- reword commit message and update description.
Signed-off-by: Janusz Krzysztofik
Reviewed-
Return values of driver bind/unbind / device remove/recover sysfs
operations are now ignored. Assert their correctness.
v2: Add trailing newlines missing from igt_assert messages.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 14
There is a new library helper that asserts validity of open file
descriptors. Use it instead of open coding.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests
.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 38 --
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index e048f3a15..572c66474 100644
--- a/tests/core_hotunplug.c
+++ b/tests
Since health checks are now run from follow-up fixture sections, it is
safe to fail subtests without the need to abort the test execution. Do
that on device close errors instead of just emitting warnings.
v2: Rebase only.
v3: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał
running by a failed health check attempt.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 97 ++
1 file changed, 89 insertions(+), 8 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 24beed81a..13e7aa46f 100644
-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 85 +++---
1 file changed, 31 insertions(+), 54 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index f7a54010b..849a774ff 100644
--- a/tests
Don't rely on successful write to sysfs control files, assert existence
/ non-existence of a respective device sysfs node as well.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 14 ++
1 file changed, 14 insertions(+)
diff --git
in post_healthcheck function name.
v3: Don't fail on close error after successful health check, warn only,
- move duplicated messages to helpers.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests/core_hotunplug.c | 64 +-
1 file changed, 50
-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v2
---
tests/core_hotunplug.c | 114 +++--
1 file changed, 109 insertions(+), 5 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 13e7aa46f..f919fa6de 100644
--- a/tests
Since we no longer open a device DRM sysfs node, only a PCI one, driver
unbind operations are no longer affected by missed or unsuccessful
sysfs file close attempts. Skip only affected subtests if that
happens.
v2: Rebase only.
v3: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał
A pointer to fatal error messages can be passed around via hotunplug
structure, no need to declare it as global.
v2: Rebase only.
v3: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 96 +-
1 file
.
For that to be possible, maintain a single instance of hotunplug
structure at igt_main level and pass it down to subtests.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 56 --
1 file changed, 26 insertions(+), 30 deletions
bodies.
v2: Rebase only.
v3: Refresh and extend over new case (local_drm_open_driver),
- allow callers to specify a message suffix as well where applicable.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests/core_hotunplug.c | 39
e give me
your green light for merging this series if you have no objections.
Thanks,
Janusz
Janusz Krzysztofik (20):
tests/core_hotunplug: Use igt_assert_fd()
tests/core_hotunplug: Constify dev_bus_addr string
tests/core_hotunplug: Clean up device open error handling
tests/core_hotunplug: C
Device bus address structure field is always initialized with a pointer
to a substring of the device sysfs path and never used for its
modification. Declare it as a constant string.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file
Some return values are not useful and can be ignored. Wrap those cases
inside igt_ignore_warn(), not only to make sure compilers are happy but
also to clearly document our decisions.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 6 +++---
1 file
.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index a4071f51e..e576a6c6c 100644
--- a/tests/core_hotunplug.c
+++ b/tests
On Thu, 2020-08-20 at 16:51 +0200, Janusz Krzysztofik wrote:
> Clean up the test code, add some new basic subtests, then unblock
> unbind test variants.
Hi,
CI results show that i915 recovery after a failed healthcheck still
needs some work, so please hold on with your reviews. I'm
give me your green lite for merging this
series if you have no objections.
Thanks,
Janusz
Janusz Krzysztofik (19):
tests/core_hotunplug: Use igt_assert_fd()
tests/core_hotunplug: Constify dev_bus_addr string
tests/core_hotunplug: Clean up device open error handling
tests/core_hotunplug
There is a new library helper that asserts validity of open file
descriptors. Use it instead of open coding.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests
.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 34 +++---
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index a4071f51e..e576a6c6c 100644
--- a/tests/core_hotunplug.c
+++ b/tests
Since we no longer open a device DRM sysfs node, only a PCI one, driver
unbind operations are no longer affected by missed or unsuccessful
sysfs file close attempts. Skip only affected subtests if that
happens.
v3: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
Device bus address structure field is always initialized with a pointer
to a substring of the device sysfs path and never used for its
modification. Declare it as a constant string.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file
g but clean the mark only on
health check success,
- call cleanup() also from post_healthcheck() in order to close a
device file descriptor potentially left open by a failed health
check,
- reword commit message and update description.
Signed-off-by: Janusz Krzysztofik
Reviewed-
Return value of igt_device_filter_add() representing a number of
successfully installed device filters is now ignored. Fail if not 1.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
.
For that to be possible, maintain a single instance of hotunplug
structure at igt_main level and pass it down to subtests.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 56 --
1 file changed, 26 insertions(+), 30 deletions
' function accordingly.
A side benefit of using the PCI device sysfs node, not the DRM one,
while removing the device is that a future subtest may now easily
perform both driver unbind and device remove operations in a row.
v3: Refresh.
Suggested-by: Michał Winiarski
Signed-off-by: Janusz
bodies.
v3: Refresh and extend over new case (local_drm_open_driver),
- allow callers to specify a message suffix as well where applicable.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests/core_hotunplug.c | 39 ---
1 file
in post_healthcheck function name.
v3: Don't fail on close error after successful health check, warn only,
- move duplicated messages to helpers.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v1
---
tests/core_hotunplug.c | 64 +-
1 file changed, 50
Return values of driver bind/unbind / device remove/recover sysfs
operations are now ignored. Assert their correctness.
v2: Add trailing newlines missing from igt_assert messages.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 14
Some return values are not useful and can be ignored. Wrap those cases
inside igt_ignore_warn(), not only to make sure compilers are happy but
also to clearly document our decisions.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 6 +++---
1 file
A pointer to fatal error messages can be passed around via hotunplug
structure, no need to declare it as global.
v3: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 96 +-
1 file changed, 47
Since health checks are now run from follow-up fixture sections, it is
safe to fail subtests without the need to abort the test execution. Do
that on device close errors instead of just emitting warnings.
v3: Refresh.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests
.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 38 --
1 file changed, 20 insertions(+), 18 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index e048f3a15..572c66474 100644
--- a/tests/core_hotunplug.c
+++ b/tests
IGT
test section on GPU hang so we are still able to perform the reset and
retry.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 88 ++
1 file changed, 80 insertions(+), 8 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests
Subtests which don't remove the device, only unbind the driver from it,
seem relatively safe and harmless for CI. Remove them from the CI
blocklist.
Signed-off-by: Janusz Krzysztofik
---
tests/intel-ci/blacklist.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
Don't rely on successful write to sysfs control files, assert existence
/ non-existence of a respective device sysfs node as well.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 14 ++
1 file changed, 14 insertions(+)
diff --git
-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski # v2
---
tests/core_hotunplug.c | 114 +++--
1 file changed, 109 insertions(+), 5 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 277679ea1..42a13f8b5 100644
--- a/tests
On Fri, 2020-08-21 at 17:40 +, Patchwork wrote:
> Patch Details
> Series: tests/core_hotunplug: Fixes and enhancements (rev4)
> URL: https://patchwork.freedesktop.org/series/79671/
> State:failure
> Details: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4901/index.html
>
Hi Petri,
On Mon, 2020-08-24 at 12:26 +0300, Petri Latvala wrote:
> On Mon, Aug 24, 2020 at 10:42:10AM +0200, Janusz Krzysztofik wrote:
> > On Fri, 2020-08-21 at 17:40 +, Patchwork wrote:
> > > Patch Details
> > > Series: tests/core_hotunplug: Fixes and en
On Wed, 2020-05-27 at 21:12 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-05-18 20:17:19)
> > GGTT including its scratch page is not cleaned up until driver release.
> > Since DMA mappings still exist before scratch page cleanup, unmapping
> > them on la
Hi Michał,
On Wed, 2020-05-27 at 21:15 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-05-18 20:17:20)
> > UC firmware is stored in a GEM object. Clean it up on driver remove to
>^ double whitespace
That's a result of
Hi Tvrtko,
On Thu, 2020-05-28 at 11:14 +0100, Tvrtko Ursulin wrote:
> On 18/05/2020 19:17, Janusz Krzysztofik wrote:
> > Contexts associated with open device file descriptors together with
> > their assigned address spaces are now closed on device file close. On
>
> i915_ge
Hi Chris,
On Thu, 2020-05-28 at 14:41 +0100, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2020-05-28 14:34:42)
> > On 28/05/2020 13:10, Janusz Krzysztofik wrote:
> > > Hi Tvrtko,
> > >
> > > On Thu, 2020-05-28 at 11:14 +0100, Tvrtko Ursulin wrote:
> > &
eck the test requirements. For this we want to specify the baseline
> measurement timeout in milliseconds, allowing us to speed up our other
> baseline measurements elsewhere as well.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Janusz Krzysztofik
Thanks,
Janusz
> ---
>
,
- rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 61 --
1 file changed, 47 insertions(+), 14 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
Device bus address structure field is always initialized with a pointer
to a substring of the device sysfs path and never used for its
modification. Declare it as a constant string.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
igt_require() with 'if() return;' construct in recover() to
reduce noise,
- replace "subtest failure" message used as a request for healthcheck
with a more appropriate "need healthcheck" for clarity,
- rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 91 --
1 file changed, 35 insertions(+), 56 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index ffba32568..71ac4d169 100644
--- a/tests
Since we no longer open a device DRM sysfs node, only a PCI one, driver
unbind operations are no longer affected by missed or unsuccessful
sysfs file close attempts. Skip only affected subtests if that
happens.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed
Some return values are not useful and can be ignored. Wrap those cases
inside igt_ignore_warn(), not only to make sure compilers are happy but
also to clearly document our decisions.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
There is a new library helper that asserts validity of open file
descriptors. Use it instead of open coding.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 10 +-
1 file changed, 5 insertions(+), 5
.
For that to be possible, maintain a single instance of hotunplug
structure at igt_main level and pass it down to subtests.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 56 --
1 file changed
bodies.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index
Since health checks are now run from follow-up fixture sections, it is
safe to fail subtests without the need to abort the test execution. Do
that on device close errors instead of emitting warnings.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał
Clean up the test code and unblock unbind variants.
@Michał: Since most v2 updates are trivial, I've preserved your
Reviewd-by: except for patch 11/16 "Follow failed subtests with health
checks" - please have a look and confirm if you are still OK with it.
Thanks,
Janusz
Janusz Krzys
Don't rely on successful write to sysfs control files, assert existence
/ non-existence of a respective device sysfs node as well.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 14 ++
1 file
A trailing newline is missing from one of fatal error messages, fix it.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/core_hotunplug.c
Return values of driver bind/unbind / device remove/recover sysfs
operations are now ignored. Assert their correctness.
v2: Add trailing newlines missing from igt_assert messages,
- rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests
Return value of igt_device_filter_add() representing a number of
successfully installed device filters is now ignored. Fail if not 1.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1
A pointer to fatal error messages can be passed around via hotunplug
structure, no need to declare it as global.
v2: Rebase on current upstream master.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Michał Winiarski
---
tests/core_hotunplug.c | 92 +-
1
Subtests which don't remove the device, only unbind the driver from it,
seem relatively safe and harmless for CI. Remove them from the CI
blocklist.
Signed-off-by: Janusz Krzysztofik
---
tests/intel-ci/blacklist.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
On Fri, 2020-08-07 at 11:19 +0200, Janusz Krzysztofik wrote:
> Clean up the test code and unblock unbind variants.
From the CI report it looks for me like driver (hot)unbind-rebind
operations affect hardware and the driver doesn't handle this
correctly. Moreover, the test doesn't curren
Hi Michał,
On Thu, 2020-06-25 at 22:02 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-06-22 18:44:15)
> > Verify if a device with a GEM batch job still running on a GPU can be
> > hot-unplugged cleanly and released, then recovered.
> >
>
Hi Michał,
thanks for review.
On Thu, 2020-06-25 at 21:42 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-06-22 18:44:12)
> > Verify if an additional address space associated with an open device
> > file descriptor is cleaned up correctly on device hotunpl
Hi Michał,
Thanks for review.
On Thu, 2020-06-25 at 21:51 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-06-22 18:44:13)
> > GEM objects belonging to user file descriptors still open on device
> > hotunplug may exhibit still more driver issues.
Hi Michał,
Thanks for review.
On Thu, 2020-06-25 at 17:27 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-06-22 18:44:08)
> > The purpose of debug messages displayed by the test is to make
> > identification of a subtest phase that fails more easy. Since issue
Hi Michał,
On Thu, 2020-06-25 at 21:57 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-06-22 18:44:14)
> > Even if all device file descriptors are closed on device hotunplug,
> > PRIME exported objects may still exists, referenced by still open
> > dma-b
301 - 400 of 813 matches
Mail list logo