[PATCH v6 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-02-29 Thread Janusz Krzysztofik
s, - update commit message and description. v2: Get the wakeref before VM mutex to avoid circular locking dependency, - drop questionable Fixes: tag. Fixes: d93939730347 ("drm/i915: Remove the vma refcount") Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875 Signed-off-b

Re: ✗ Fi.CI.IGT: failure for drm/i915/selftest_hangcheck: Check sanity with more patience

2024-03-01 Thread Janusz Krzysztofik
On Thursday, 29 February 2024 23:16:22 CET Patchwork wrote: > == Series Details == > > Series: drm/i915/selftest_hangcheck: Check sanity with more patience > URL : https://patchwork.freedesktop.org/series/130512/ > State : failure > > == Summary == > > CI Bug Log - changes from

Re: ✗ Fi.CI.IGT: failure for drm/i915/selftests: Fix dependency of some timeouts on HZ

2024-03-01 Thread Janusz Krzysztofik
On Friday, 23 February 2024 05:10:10 CET Patchwork wrote: > == Series Details == > > Series: drm/i915/selftests: Fix dependency of some timeouts on HZ > URL : https://patchwork.freedesktop.org/series/130249/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14316_full

[PATCH] drm/i915/selftest_hangcheck: Check sanity with more patience

2024-02-28 Thread Janusz Krzysztofik
with the i915 module also when loaded in selftest mode, relax our expectations on time consumed by the sanity check request before it completes. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v7 0/3] drm/i915: Fix VMA UAF on destroy against deactivate race

2024-03-05 Thread Janusz Krzysztofik
es (Nirmoy). - clean up commit message and description a bit. v3: Identify root cause more precisely, and a commit to blame, - identify and drop former workarounds, - update commit message and description. v2: Get the wakeref before VM mutex to avoid circular locking dependency, - drop question

[PATCH v7 2/3] drm/i915: Remove extra multi-gt pm-references

2024-03-05 Thread Janusz Krzysztofik
o drop the no longer used .wakeref_gt0 field from struct i915_execbuffer. v2: Avoid the word "revert" in commit message (Rodrigo), - update commit description reusing relevant chunks dropped from the description of the proper fix (Rodrigo). Signed-off-by: Janusz Krzysztofik Cc

[PATCH v7 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-03-05 Thread Janusz Krzysztofik
age and description. v2: Get the wakeref before VM mutex to avoid circular locking dependency, - drop questionable Fixes: tag. Fixes: d93939730347 ("drm/i915: Remove the vma refcount") Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875 Signed-off-by: Janusz Krzysztofik Cc: Thomas He

[PATCH v7 3/3] Revert "drm/i915: Wait for active retire before i915_active_fini()"

2024-03-05 Thread Janusz Krzysztofik
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik Cc: Nirmoy Das --- drivers/gpu/drm/i915/i915_vma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gp

Re: [PATCH] drm/i915/selftest_hangcheck: Fix potential UAF after HW fence revoke

2024-05-29 Thread Janusz Krzysztofik
On Wednesday, 29 May 2024 13:37:23 GMT+2 Janusz Krzysztofik wrote: > CI is sporadically reporting the following issue triggered by > igt@i915_selftest@live@hangcheck test case: > > <6> [414.049203] i915: Running > intel_hangcheck_live_selftests/igt_reset_evict_fence > ...

[PATCH] drm/i915/selftest_hangcheck: Fix potential UAF after HW fence revoke

2024-05-29 Thread Janusz Krzysztofik
triggers for actual completion of a request that it forced to claim using a hardware fence before it releases allocated resources. Fix it. Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i91

[PATCH] drm/i915/gt: Fix potential UAF by revoke of fence registers

2024-06-03 Thread Janusz Krzysztofik
tial execution of signal callbacks invoked on completion of a request that was using them on the other, still processed in parallel to revocation of those fence registers. Fix it by waiting for idleness of vma->fence->active in i915_vma_revoke_fence(). Fixes: 0d86ee35097a ("drm/i915/gt:

Re: ✗ Fi.CI.IGT: failure for drm/i915/gt: Fix potential UAF by revoke of fence registers

2024-06-04 Thread Janusz Krzysztofik
On Tuesday, 4 June 2024 12:01:43 GMT+2 Patchwork wrote: > == Series Details == > > Series: drm/i915/gt: Fix potential UAF by revoke of fence registers > URL : https://patchwork.freedesktop.org/series/134411/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14870_full

Re: [PATCH] drm/i915/gt: Fix potential UAF by revoke of fence registers

2024-06-04 Thread Janusz Krzysztofik
Hi Andi, Thanks for review. On Tuesday, 4 June 2024 02:48:43 GMT+2 Andi Shyti wrote: > Hi Janusz, > > On Mon, Jun 03, 2024 at 09:54:45PM +0200, Janusz Krzysztofik wrote: > > CI has been sporadically reporting the following issue triggered by > > igt@i915_selftest@li

<    4   5   6   7   8   9