Re: [Intel-gfx] [PATCH v2 07/12] drm/i915: Read out display FIFO size on VLV/CHV

2015-02-27 Thread Jesse Barnes
), + size); + + return size; +} + static int i9xx_get_fifo_size(struct drm_device *dev, int plane) { struct drm_i915_private *dev_priv = dev-dev_private; Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org ___ Intel-gfx

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Pass plane to vlv_compute_drain_latency()

2015-02-27 Thread Jesse Barnes
); + vlv_compute_drain_latency(crtc, plane); else wm.ddl[pipe].sprite[sprite] = 0; Nice. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Make sure PND deadline mode is enabled on VLV/CHV

2015-02-27 Thread Jesse Barnes
bug filed? Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Pass plane to vlv_compute_drain_latency()

2015-02-27 Thread Jesse Barnes
On 02/27/2015 10:09 AM, Ville Syrjälä wrote: On Fri, Feb 27, 2015 at 09:57:20AM -0800, Jesse Barnes wrote: On 02/10/2015 05:28 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Now that we have drm_planes for the cursor and primary we can move

Re: [Intel-gfx] [RFC v2] drm/i915: Android native sync support

2015-02-25 Thread Jesse Barnes
On 01/28/2015 02:07 AM, Chris Wilson wrote: On Wed, Jan 28, 2015 at 10:50:18AM +0100, Daniel Vetter wrote: On Wed, Jan 28, 2015 at 09:23:46AM +, Chris Wilson wrote: On Wed, Jan 28, 2015 at 10:22:15AM +0100, Daniel Vetter wrote: On Mon, Jan 26, 2015 at 09:08:03AM +, Chris Wilson wrote:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Disallow pin ioctl completely for kms drivers

2015-02-23 Thread Jesse Barnes
On 11/24/2014 06:13 AM, Chris Wilson wrote: On Mon, Nov 24, 2014 at 03:10:05PM +0100, Daniel Vetter wrote: On Mon, Nov 24, 2014 at 10:35:29AM +, Chris Wilson wrote: Pinning is a useful tool and it would also be useful to have again on gen6+. I think softpin or similar is doable with

Re: [Intel-gfx] [PATCH 1/5] agp/intel: Serialise after GTT updates

2015-02-05 Thread Jesse Barnes
On Wed, 14 Jan 2015 11:20:55 + Chris Wilson ch...@chris-wilson.co.uk wrote: diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c index 92aa43fa8d70..15685ca39193 100644 --- a/drivers/char/agp/intel-gtt.c +++ b/drivers/char/agp/intel-gtt.c @@ -225,7 +225,7 @@ static

Re: [Intel-gfx] [PATCH 2/4] drm/cache: Try to be smarter about clflushing on x86

2014-12-14 Thread Jesse Barnes
On 12/14/2014 4:59 AM, Chris Wilson wrote: One of the things wbinvd is considered evil for is that it blocks the CPU for an indeterminate amount of time - upsetting latency critcial aspects of the OS. For example, the x86/mm has similar code to use wbinvd for large clflushes that caused a bit of

Re: [Intel-gfx] [PATCH] drm/i915/i9xx: check for panel on pipe before asserting panel unlock bits

2014-12-11 Thread Jesse Barnes
with '*' Based on this log and the one for saving and restoring the GMbus clock, it looks like we have some inconsistent results on ILK. Can you look into the logs and file bugs against those tests if they're no already filed? Thanks, -- Jesse Barnes, Intel Open Source Technology Center

[Intel-gfx] [PATCH] drm/i915: save/restore GMBUS freq across suspend/resume on gen4

2014-12-10 Thread Jesse Barnes
-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/i915_suspend.c | 8 3 files changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index

Re: [Intel-gfx] [PATCH] drm/i915: save/restore GMBUS freq across suspend/resume on gen4

2014-12-10 Thread Jesse Barnes
On Wed, 10 Dec 2014 22:35:37 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Dec 10, 2014 at 12:16:05PM -0800, Jesse Barnes wrote: Should probably just init this in the GMbus code all the time, based on the cdclk and HPLL like we do on newer platforms. Ville has code

[Intel-gfx] [PATCH] drm/i915/i9xx: check for panel on pipe before asserting panel unlock bits

2014-12-10 Thread Jesse Barnes
Should address a warning reported in #79824. References: https://bugs.freedesktop.org/show_bug.cgi?id=79824 Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 2/2] drm/i915: calculate pfit changes in set_config v3

2014-12-09 Thread Jesse Barnes
On Tue, 11 Nov 2014 12:30:47 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: This should allow us to avoid mode sets for some panel fitter config changes. v2: - fixup pfit comment (Ander) v3: - fixup pfit disable shortcut, only apply to gen4 for now (Jesse) Daniel pointed out

Re: [Intel-gfx] [PATCH 2/2] drm/i915: calculate pfit changes in set_config v3

2014-12-09 Thread Jesse Barnes
On Tue, 9 Dec 2014 22:16:33 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Dec 9, 2014 at 6:51 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 11 Nov 2014 12:30:47 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: This should allow us to avoid mode sets for some panel

Re: [Intel-gfx] [PATCH] drm/i915: Don't complain about stolen conflicts on gen3

2014-12-05 Thread Jesse Barnes
) but does make things messier for us. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org Looks like the reporter gave a t-b too. Jesse ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Android sync points for i915 v3

2014-12-04 Thread Jesse Barnes
On Thu, 4 Dec 2014 12:21:01 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Wed, Dec 03, 2014 at 11:49:06AM -0800, Jesse Barnes wrote: Expose an ioctl to create Android fences based on the Android sync point infrastructure (which in turn is based on DMA-buf fences). Just a sketch

Re: [Intel-gfx] [PATCH] drm/i915: don't always do full mode sets when infoframes are enabled

2014-12-04 Thread Jesse Barnes
On Mon, 1 Dec 2014 09:54:28 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: Partial revert of commit 206645910b9796bff13fcdb67bdca166b724ba62 Author: Jesse Barnes jbar...@virtuousgeek.org Date: Wed Nov 5 14:26:09 2014 -0800 drm/i915: check for audio and infoframe changes across

[Intel-gfx] [PATCH 3/3] drm/i915: add fences to the request struct

2014-12-03 Thread Jesse Barnes
additional debugging as needed, so it's probably fine to keep either way. We still need to add support for other rings here; we ought to be able to do that with the timeline field of the ioctl (which will include other rings like the display flip queue for example). Signed-off-by: Jesse Barnes jbar

[Intel-gfx] [PATCH 2/3] drm/i915: Android sync points for i915 v3

2014-12-03 Thread Jesse Barnes
Maarten's new interface v3: use new i915 request structure (Jesse) make i915 fences a compile time option since Android support is still in staging (Jesse) check for request complete after arming IRQs (Chris) add timeline id to ioctl (Tvrtko) Signed-off-by: Jesse Barnes jbar

[Intel-gfx] [RFC] Updated Android sync patches

2014-12-03 Thread Jesse Barnes
Still have a few remaining todo items, but I'd like some feedback on these before adding a bunch of stuff on top. Rough todo list: - support for other rings - support for display - tests - userspace usage (I have a Mesa patch that needs a refresh, but it's trivial, the interesting bit

[Intel-gfx] [PATCH 1/3] android: add sync_fence_create_dma

2014-12-03 Thread Jesse Barnes
From: Maarten Lankhorst maarten.lankho...@canonical.com This allows users of dma fences to create a android fence. Cc: Daniel Vetter dan...@ffwll.ch Cc: Jesse Barnes jbar...@virtuousgeek.org Signed-off-by: Maarten Lankhorst maarten.lankho...@canonical.com --- drivers/staging/android/sync.c | 13

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Jesse Barnes
On Mon, 01 Dec 2014 12:25:45 +0200 Jani Nikula jani.nik...@linux.intel.com wrote: On Thu, 06 Nov 2014, Jesse Barnes jbar...@virtuousgeek.org wrote: If these change (e.g. after a modeset following a fastboot), we need to do a full mode set. v2: - put under pipe_config check so we

Re: [Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-12-01 Thread Jesse Barnes
On Mon, 1 Dec 2014 17:16:25 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Dec 01, 2014 at 12:25:45PM +0200, Jani Nikula wrote: On Thu, 06 Nov 2014, Jesse Barnes jbar...@virtuousgeek.org wrote: If these change (e.g. after a modeset following a fastboot), we need to do a full mode set

[Intel-gfx] [PATCH] drm/i915: don't always do full mode sets when infoframes are enabled

2014-12-01 Thread Jesse Barnes
Partial revert of commit 206645910b9796bff13fcdb67bdca166b724ba62 Author: Jesse Barnes jbar...@virtuousgeek.org Date: Wed Nov 5 14:26:09 2014 -0800 drm/i915: check for audio and infoframe changes across mode sets v2 References: https://bugs.freedesktop.org/show_bug.cgi?id=86683 Signed-off

Re: [Intel-gfx] [PATCH] drm/i915/ddi: set has_infoframe flag on DDI too v2

2014-11-20 Thread Jesse Barnes
On Thu, 20 Nov 2014 16:49:42 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 18, 2014 at 09:45:52AM -0800, Jesse Barnes wrote: Just like we do in the HDMI code, set the infoframe flag if we detect that infoframes are enabled. v2: check for actual infoframe status as in hdmi code

[Intel-gfx] [PATCH 2/2] drm/i915/ibx: check port in infoframe_enabled

2014-11-20 Thread Jesse Barnes
Just like on g4x we need to check the port enable bit here. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_hdmi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c

[Intel-gfx] [PATCH 1/2] drm/i915/g4x: fix g4x infoframe readout

2014-11-20 Thread Jesse Barnes
Need to check the port too. Reported-by: Daniel Vetter dan...@ffwll.ch Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_hdmi.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915/vlv: check port in infoframe_enabled

2014-11-20 Thread Jesse Barnes
Same as IBX and G4x, they all share the same genetic material. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_hdmi.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915/vlv: check port in infoframe_enabled v2

2014-11-20 Thread Jesse Barnes
Same as IBX and G4x, they all share the same genetic material. v2: we all need a bit more port in our lives Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_hdmi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 2/2] drm/i915/ibx: check port in infoframe_enabled

2014-11-20 Thread Jesse Barnes
On Thu, 20 Nov 2014 22:57:32 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 20, 2014 at 01:24:14PM -0800, Jesse Barnes wrote: Just like on g4x we need to check the port enable bit here. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_hdmi.c

Re: [Intel-gfx] [PATCH] drm/i915: add turbo boost trace point

2014-11-19 Thread Jesse Barnes
) ILK: Intel_gpu_tools, igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset, DMESG_WARN(1, M26)PASS(3, M37M26) - DMESG_WARN(1, M26)PASS(3, M26) Looks like these two tests are flakey; this patch shouldn't affect those cases. Do we have bugs open for these subtests already? Thanks, -- Jesse

Re: [Intel-gfx] [PATCH] drm/i915: add turbo boost trace point

2014-11-19 Thread Jesse Barnes
On Wed, 19 Nov 2014 15:00:04 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 18, 2014 at 01:12:29PM -0800, Jesse Barnes wrote: Might be helpful for debugging places where userspace ends up boosting or waiting where it doesn't intend to. Might be feels a bit weak justification

Re: [Intel-gfx] [PATCH] drm/i915: add turbo boost trace point

2014-11-19 Thread Jesse Barnes
On Wed, 19 Nov 2014 17:19:23 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Wed, Nov 19, 2014 at 07:39:17AM -0800, Jesse Barnes wrote: On Wed, 19 Nov 2014 15:00:04 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 18, 2014 at 01:12:29PM -0800, Jesse Barnes wrote: Might

Re: [Intel-gfx] [PATCH 4/5] drm/i915: remove intel_pipe_set_base() (v4)

2014-11-19 Thread Jesse Barnes
); /* * We need to make sure the primary plane is re-enabled if it Acked-and-mourned-by: Jesse Barnes jbar...@virtuousgeek.org -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915/ddi: set has_infoframe flag on DDI too

2014-11-18 Thread Jesse Barnes
On Tue, 18 Nov 2014 09:14:05 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Mon, Nov 17, 2014 at 01:08:46PM -0800, Jesse Barnes wrote: Just like we do in the HDMI code, set the infoframe flag if we detect an HDMI sink. Reported-by: Paulo Zanoni przan...@gmail.com Signed-off-by: Jesse

Re: [Intel-gfx] [PATCH] drm/i915: expose a fixed brightness range to userspace

2014-11-18 Thread Jesse Barnes
, except use the range [0..1000] instead; which was recommended by Jesse Barnes for smoother backlight transitions. Reference: http://lists.freedesktop.org/archives/intel-gfx/2014-November/055221.html Signed-off-by: U. Artie Eoff ullysses.a.e...@intel.com --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915/ddi: set has_infoframe flag on DDI too v2

2014-11-18 Thread Jesse Barnes
Just like we do in the HDMI code, set the infoframe flag if we detect that infoframes are enabled. v2: check for actual infoframe status as in hdmi code (Daniel) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_ddi.c | 8 1 file changed, 8 insertions

[Intel-gfx] [PATCH] drm/i915: add turbo boost trace point

2014-11-18 Thread Jesse Barnes
Might be helpful for debugging places where userspace ends up boosting or waiting where it doesn't intend to. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_gem.c | 6 -- drivers/gpu/drm/i915/i915_trace.h | 15 +++ drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 5/5] drm/i915: remove intel_pipe_set_base() (v3)

2014-11-18 Thread Jesse Barnes
and set_pipe_base anymore, always got that wrong when searching. -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Propagate invalid setcrtc cloning errors back to userspace

2014-11-17 Thread Jesse Barnes
the error code into the return value variable, leading us to return 0 (success) to userspace. Testcase: igt/kms_setmode Signed-off-by: Matt Roper matthew.d.ro...@intel.com I guess this is a regression from commit 50f5275698df4490046cc5b4ed2018abb642a803 Author: Jesse Barnes

[Intel-gfx] [PATCH 1/2] drm/i915/ddi: set has_infoframe flag on DDI too

2014-11-17 Thread Jesse Barnes
Just like we do in the HDMI code, set the infoframe flag if we detect an HDMI sink. Reported-by: Paulo Zanoni przan...@gmail.com Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_ddi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/2] drm/i915/ddi: add break in DDI mode select switch

2014-11-17 Thread Jesse Barnes
The lack of a break here wasn't for falling through to some other important code, so made me do a double take. Add a break just to make things a little less confusing. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_ddi.c | 1 + 1 file changed, 1 insertion

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Add debugfs interface for Displayport debug and compliance testing

2014-11-13 Thread Jesse Barnes
On Thu, 23 Oct 2014 17:43:01 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Oct 23, 2014 at 10:58:59AM -0200, Paulo Zanoni wrote: 2014-10-23 10:50 GMT-02:00 Daniel Vetter dan...@ffwll.ch: I think it's better to expose this as drm properties on the DP connector. This has a pile of

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Add debugfs interface for Displayport debug and compliance testing

2014-11-13 Thread Jesse Barnes
On Fri, 14 Nov 2014 07:00:17 +1000 Dave Airlie airl...@gmail.com wrote: Aside from all this (and now with my community hat on) just adding code to get a sticker (labelled passed DP validation) which is separate code and not used by actual users is imo not useful for merging upstream. But

Re: [Intel-gfx] [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2

2014-11-11 Thread Jesse Barnes
On Tue, 11 Nov 2014 16:23:03 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 11, 2014 at 05:19:46PM +0200, Ville Syrjälä wrote: On Tue, Nov 11, 2014 at 04:00:12PM +0100, Daniel Vetter wrote: On Wed, Nov 05, 2014 at 02:26:08PM -0800, Jesse Barnes wrote: This is useful for checking

Re: [Intel-gfx] [PATCH] drm/i915: Use correct pipe config to update pll dividers. V2

2014-11-11 Thread Jesse Barnes
-dpll_hw_state.fp1 = fp; } } Fixes things on my 945 here. Thanks. Tested-by: Jesse Barnes jbar...@virtuousgeek.org ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/2] drm/i915: calculate pfit changes in set_config v3

2014-11-11 Thread Jesse Barnes
This should allow us to avoid mode sets for some panel fitter config changes. v2: - fixup pfit comment (Ander) v3: - fixup pfit disable shortcut, only apply to gen4 for now (Jesse) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 73

[Intel-gfx] [PATCH 1/2] drm/i915/hdmi: fetch infoframe status in get_config v3

2014-11-11 Thread Jesse Barnes
This is useful for checking things later. v2: - fix hsw infoframe enabled check (Ander) v3: - set infoframe status in compute_config too (Ville) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2

2014-11-10 Thread Jesse Barnes
On Mon, 10 Nov 2014 18:20:56 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 11/06/2014 12:26 AM, Jesse Barnes wrote: This should allow us to avoid mode sets for some panel fitter config changes. v2: - fixup pfit comment (Ander) Signed-off-by: Jesse Barnes jbar

Re: [Intel-gfx] [PATCH] drm/i915: intel_backlight scale() math WA v2

2014-11-10 Thread Jesse Barnes
On Mon, 10 Nov 2014 16:15:57 +0200 Jani Nikula jani.nik...@linux.intel.com wrote: On Mon, 10 Nov 2014, Jani Nikula jani.nik...@linux.intel.com wrote: On Sat, 08 Nov 2014, Eoff, Ullysses A ullysses.a.e...@intel.com wrote: On 09/24/2014 10:42 AM, Eoff, Ullysses A wrote: -Original

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-10 Thread Jesse Barnes
On Thu, 6 Nov 2014 14:10:49 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 06, 2014 at 02:49:12PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We may need to access various hardware bits in the .global_resources() hook, so move

Re: [Intel-gfx] [PATCH] drm/i915/dp: Don't stop the link when retraining

2014-11-10 Thread Jesse Barnes
On Mon, 3 Nov 2014 11:39:24 +0100 Daniel Vetter daniel.vet...@ffwll.ch wrote: On pre-ddi platforms we don't shut down the link when changing link training parameters. Except when clock recovery fails too hard and we restart with channel eq training. Which doesn't make a lot of sense really,

Re: [Intel-gfx] [PATCH] drm/i915: Mark fastboot as unsafe

2014-11-10 Thread Jesse Barnes
On Fri, 7 Nov 2014 18:41:16 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 04, 2014 at 03:29:57PM +0100, Daniel Vetter wrote: Fastboot in its current incarnation assumes that the pfit isn't relevatn for the state and that it can be disabled without restarting the crtc.

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Move the .global_resources() hook call into modeset_update_crtc_power_domains()

2014-11-10 Thread Jesse Barnes
On Mon, 10 Nov 2014 19:24:37 +0200 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Mon, Nov 10, 2014 at 09:14:11AM -0800, Jesse Barnes wrote: On Thu, 6 Nov 2014 14:10:49 +0100 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Nov 06, 2014 at 02:49:12PM +0200, ville.syrj

Re: [Intel-gfx] [RFC] dpms handling on atomic drivers

2014-11-10 Thread Jesse Barnes
On Thu, 6 Nov 2014 19:35:51 -0500 Rob Clark robdcl...@gmail.com wrote: On Thu, Nov 6, 2014 at 6:29 PM, Daniel Vetter dan...@ffwll.ch wrote: That aside I guess I need to elaborate on what makes dpms special in i915, and why there's a real difference between crtc-enable == true -active ==

Re: [Intel-gfx] [PATCH 2/6] drm/i915: use compute_config in set_config v3

2014-11-07 Thread Jesse Barnes
On Fri, 07 Nov 2014 11:41:48 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 11/06/2014 12:26 AM, Jesse Barnes wrote: This will allow us to consult more info before deciding whether to flip or do a full mode set. v2: - don't use uninitialized or incorrect pipe masks

[Intel-gfx] [PATCH] drm/i915: use compute_config in set_config v4

2014-11-07 Thread Jesse Barnes
path (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index a3ebab8..72123e0

Re: [Intel-gfx] [PATCH 08/16] drm/i915: remove unused restore_gtt_mappings optimization during suspend

2014-11-06 Thread Jesse Barnes
On Tue, 21 Oct 2014 16:50:12 +0300 Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Sep 11, 2014 at 07:15:27AM -0700, Jesse Barnes wrote: On Thu, 11 Sep 2014 14:59:35 +0300 Imre Deak imre.d...@intel.com wrote: On Thu, 2014-09-11 at 08:49 +0100, Chris Wilson wrote: On Wed

[Intel-gfx] [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2

2014-11-05 Thread Jesse Barnes
This is useful for checking things later. v2: - fix hsw infoframe enabled check (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_drv.h | 4 +++ drivers/gpu/drm/i915/intel_hdmi.c | 62 +++ 2 files changed, 66

[Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets v2

2014-11-05 Thread Jesse Barnes
If these change (e.g. after a modeset following a fastboot), we need to do a full mode set. v2: - put under pipe_config check so we don't deref a null state (Jesse) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 12 +++- 1 file changed

[Intel-gfx] [PATCH 2/6] drm/i915: use compute_config in set_config v3

2014-11-05 Thread Jesse Barnes
This will allow us to consult more info before deciding whether to flip or do a full mode set. v2: - don't use uninitialized or incorrect pipe masks in set_config failure path (Ander) v3: - fixup for pipe_config changes in compute_config (Jesse) Signed-off-by: Jesse Barnes jbar

[Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v3

2014-11-05 Thread Jesse Barnes
) - fix arg order in set_mode (Jesse) - fix failure path of set_config (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 105 --- 1 file changed, 74 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 5/6] drm/i915: update pipe size at set_config time

2014-11-05 Thread Jesse Barnes
. This sets us up for better pipe tracking in later patches. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2

2014-11-05 Thread Jesse Barnes
This should allow us to avoid mode sets for some panel fitter config changes. v2: - fixup pfit comment (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 61 +--- 1 file changed, 50 insertions(+), 11

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2

2014-10-31 Thread Jesse Barnes
Thanks for the review, Ander. Daniel, in case you're tempted to merge this, don't just yet. Shaung's test bot found an issue with the refactoring patch I'm still tracking down. I'll post a v3 with the fix in reply to this... Thanks, Jesse On Thu, 30 Oct 2014 11:53:59 -0700 Jesse Barnes jbar

Re: [Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

2014-10-30 Thread Jesse Barnes
On Wed, 29 Oct 2014 16:30:43 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 10/23/2014 09:50 PM, Jesse Barnes wrote: This allows us to calculate the full pipe config before we do any mode setting work. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

Re: [Intel-gfx] [PATCH 2/6] drm/i915: use compute_config in set_config

2014-10-30 Thread Jesse Barnes
On Wed, 29 Oct 2014 16:31:56 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 10/23/2014 09:50 PM, Jesse Barnes wrote: This will allow us to consult more info before deciding whether to flip or do a full mode set. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

Re: [Intel-gfx] [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config

2014-10-30 Thread Jesse Barnes
On Thu, 30 Oct 2014 15:20:43 +0200 Ander Conselvan de Oliveira conselv...@gmail.com wrote: On 10/23/2014 09:50 PM, Jesse Barnes wrote: This is useful for checking things later. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_drv.h | 4

[Intel-gfx] [PATCH 2/6] drm/i915: use compute_config in set_config v2

2014-10-30 Thread Jesse Barnes
This will allow us to consult more info before deciding whether to flip or do a full mode set. v2: - don't use uninitialized or incorrect pipe masks in set_config failure path (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 30

[Intel-gfx] [PATCH 6/6] drm/i915: calculate pfit changes in set_config v2

2014-10-30 Thread Jesse Barnes
This should allow us to avoid mode sets for some panel fitter config changes. v2: - fixup pfit comment (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 61 +--- 1 file changed, 50 insertions(+), 11

[Intel-gfx] [PATCH 5/6] drm/i915: update pipe size at set_config time

2014-10-30 Thread Jesse Barnes
. This sets us up for better pipe tracking in later patches. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config v2

2014-10-30 Thread Jesse Barnes
This is useful for checking things later. v2: - fix hsw infoframe enabled check (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_drv.h | 4 +++ drivers/gpu/drm/i915/intel_hdmi.c | 62 +++ 2 files changed, 66

[Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets

2014-10-30 Thread Jesse Barnes
If these change (e.g. after a modeset following a fastboot), we need to do a full mode set. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b

[Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode v2

2014-10-30 Thread Jesse Barnes
This allows us to calculate the full pipe config before we do any mode setting work. v2: - clarify comments about global vs. per-crtc mode set (Ander) - clean up unnecessary pipe_config = NULL setting (Ander) Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: don't try using training pattern 3 on pre-haswell

2014-10-30 Thread Jesse Barnes
that at least, assuming we're not hitting the link_bw == DP_LINK_BW_5_4 case. -- Jesse Barnes, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/4] drm/i915: preserve swizzle settings if necessary v4

2014-10-30 Thread Jesse Barnes
On Tue, 21 Oct 2014 16:49:12 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Oct 09, 2014 at 12:57:43PM -0700, Jesse Barnes wrote: Some machines (like MBAs) might use a tiled framebuffer but not enable display swizzling at boot time. We want to preserve that configuration if possible

Re: [Intel-gfx] i915.fastboot bug report - not working on coreboot

2014-10-30 Thread Jesse Barnes
approximately. We could adjust the fastboot code to handle that, or change coreboot to use the preferred mode from the EDID of the display or make the VBT match, which is presumably what the kernel is using. -- Jesse Barnes, Intel Open Source Technology Center

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Do vlv cmnlane toggle w/a in more cases

2014-10-28 Thread Jesse Barnes
panel power sequencer fixes. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Enable pipe-a power well on chv

2014-10-28 Thread Jesse Barnes
. Reviewed-by: Jesse Barnes jbar...@virtuousgeek.org ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Move flags describing VMA mappings into the VMA

2014-10-27 Thread Jesse Barnes
to not have materialized afaics. Jesse? Actually cc Jesse ... The only thing I'm aware of here is this task: https://jira01.devtools.intel.com/browse/VIZ-4123 which Mika already closed. If there's still some breakage, do we have bugs open on them? Thanks, -- Jesse Barnes, Intel Open

Re: [Intel-gfx] [PATCH 3/4] drm: add drm_mode_same_size function

2014-10-24 Thread Jesse Barnes
On Tue, 21 Oct 2014 16:49:37 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Oct 09, 2014 at 12:57:44PM -0700, Jesse Barnes wrote: From: Kristian Høgsberg hoegsb...@gmail.com Like mode_equal but w/o the clock checks. Useful for checking if modes are close enough to re-use to avoid

[Intel-gfx] [PATCH 2/5] drm/i915: factor compute_config out of __intel_mode_set

2014-10-24 Thread Jesse Barnes
This allows us to calculate the full pipe config before we do any mode setting work. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 40 ++-- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 3/5] drm/i915: use compute_config in set_config

2014-10-23 Thread Jesse Barnes
This will allow us to consult more info before deciding whether to flip or do a full mode set. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 4/5] drm/i915/hdmi: fetch infoframe status in get_config

2014-10-23 Thread Jesse Barnes
This is useful for checking things later. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_drv.h | 4 +++ drivers/gpu/drm/i915/intel_hdmi.c | 61 +++ 2 files changed, 65 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/5] drm/i915: factor out compute_config from __intel_set_mode

2014-10-23 Thread Jesse Barnes
So we can call it earlier for use in computing mode config changes. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 63 +++- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 5/5] drm/i915: check for audio and infoframe changes across mode sets

2014-10-23 Thread Jesse Barnes
If these change (e.g. after a modeset following a fastboot), we need to do a full mode set. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b

Re: [Intel-gfx] [PATCH 3/5] drm/i915: use compute_config in set_config

2014-10-23 Thread Jesse Barnes
On Thu, 23 Oct 2014 19:28:18 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 23, 2014 at 06:59:14PM +0200, Jesse Barnes wrote: This will allow us to consult more info before deciding whether to flip or do a full mode set. Signed-off-by: Jesse Barnes jbar

[Intel-gfx] [PATCH 6/6] drm/i915: calculate pfit changes in set_config

2014-10-23 Thread Jesse Barnes
This should allow us to avoid mode sets for some panel fitter config changes. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 48 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/6] drm/i915/hdmi: fetch infoframe status in get_config

2014-10-23 Thread Jesse Barnes
This is useful for checking things later. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_drv.h | 4 +++ drivers/gpu/drm/i915/intel_hdmi.c | 61 +++ 2 files changed, 65 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/6] drm/i915: factor out compute_config from __intel_set_mode

2014-10-23 Thread Jesse Barnes
This allows us to calculate the full pipe config before we do any mode setting work. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 93 +--- 1 file changed, 65 insertions(+), 28 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 5/6] drm/i915: update pipe size at set_config time

2014-10-23 Thread Jesse Barnes
. This sets us up for better pipe tracking in later patches. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 4/6] drm/i915: check for audio and infoframe changes across mode sets

2014-10-23 Thread Jesse Barnes
If these change (e.g. after a modeset following a fastboot), we need to do a full mode set. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b

[Intel-gfx] [PATCH 2/6] drm/i915: use compute_config in set_config

2014-10-23 Thread Jesse Barnes
This will allow us to consult more info before deciding whether to flip or do a full mode set. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode

2014-10-22 Thread Jesse Barnes
On Tue, 21 Oct 2014 16:53:02 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Thu, Oct 09, 2014 at 12:57:45PM -0700, Jesse Barnes wrote: From: Kristian Høgsberg hoegsb...@gmail.com The BIOS may set a native mode that doesn't quite match the preferred mode timings. It should be ok to use

Re: [Intel-gfx] v3.17, i915 vs nouveau: possible recursive locking detected

2014-10-18 Thread Jesse Barnes
On Thu, 16 Oct 2014 13:47:38 +0200 Daniel Vetter dan...@ffwll.ch wrote: We need ww mutexes and need to rewrite i915 a bit fo fix this all. I.e. known issue. As long as your userspace isn't nasty nothing bad will ever happen though. So do we already have a bug open with a good description of

Re: [Intel-gfx] [PATCH] drm/i915: use delayed work for resume hotplug v2

2014-10-09 Thread Jesse Barnes
On Thu, 9 Oct 2014 11:11:32 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Oct 08, 2014 at 07:32:12AM -0700, Jesse Barnes wrote: On Wed, 8 Oct 2014 07:43:34 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, Oct 07, 2014 at 01:25:23PM -0700, Jesse Barnes wrote

[Intel-gfx] [PATCH] drm/i915: use delayed work for resume hotplug v4

2014-10-09 Thread Jesse Barnes
Gets the detect code (which may take awhile) out of the resume path, speeding things up a bit. v2: use a delayed work queue instead (Daniel) v3: cancel delayed work at unload and suspend time (Jesse) v4: make delayed work comment less scary (Chris) Signed-off-by: Jesse Barnes jbar

[Intel-gfx] [PATCH 2/4] drm/i915: preserve swizzle settings if necessary v4

2014-10-09 Thread Jesse Barnes
) check display swizzle setting in detect_bit_6_swizzle (Daniel) use gen6 as cutoff point (Daniel) v4: fixup swizzle preserve again, had wrong init order (Daniel) Reported-by: Kristian Høgsberg hoegsb...@gmail.com Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/4] drm: add drm_mode_same_size function

2014-10-09 Thread Jesse Barnes
From: Kristian Høgsberg hoegsb...@gmail.com Like mode_equal but w/o the clock checks. Useful for checking if modes are close enough to re-use to avoid a boot time mode set for example. Signed-off-by: Kristian Høgsberg hoegsb...@gmail.com Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org

[Intel-gfx] [PATCH 4/4] drm/i915: use current mode if the size matches the preferred mode

2014-10-09 Thread Jesse Barnes
-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_fbdev.c | 47 +++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c index 9b584f3..79dd814 100644

<    1   2   3   4   5   6   7   8   9   10   >