; drivers/gpu/drm/i915/intel_lrc.c | 2 +-
> > drivers/gpu/drm/i915/intel_ringbuffer.h | 6 +-
> > 9 files changed, 617 insertions(+), 77 deletions(-)
> >
> > --
> > 2.15.1
> > ___
> > Intel-gfx mailin
l-gtt.c
> @@ -872,6 +872,8 @@ void intel_gtt_insert_sg_entries(struct sg_table *st,
> }
> }
> wmb();
> + if (intel_private.driver->chipset_flush)
> + intel_private.driver->chipset_flush();
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open So
nce in mocs switch
>
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 19 +++
> drivers/gpu/drm/i915/gvt/render.c | 252
> +-
> drivers/gpu/drm/i915/gvt/trace.h | 15 +-
> 3 files changed, 152 insertions(+), 134 deletions(-)
>
--
get igt_log over netconsole?
With igt-runner? If the idea wasn't rejected :P
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ough the drm-tip tree
as previously discussed.
Regards, Joonas
On Mon, 2017-12-11 at 12:14 +, Matthew Auld wrote:
> From: Joonas Lahtinen
>
> To give upcoming SKU BIOSes more flexibility in placing the Intel
> graphics stolen memory, make all variables storing the placement or s
+ Jani, who'll continue with -fixes
On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote:
> On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen
> wrote:
> > On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote:
> > > CFL was missing from intel_early_ids[].
&g
(and on some older hw, there is only mappable). As such, we have
> to allow the very large bo to either succeed in being flipped, or fail
> with the expected E2BIG.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source
++---
> drivers/gpu/drm/i915/gvt/trace.h| 15 +-
> 3 files changed, 151 insertions(+), 119 deletions(-)
>
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freede
of Paulo' stolen series[1], addressing the feedback from
> Joonas and
> Chris.
>
> [1] https://patchwork.freedesktop.org/series/30923/
>
> Joonas Lahtinen (1):
> x86/early-quirks: Extend Intel graphics stolen memory placement to
> 64bit
>
> Matthew Auld (
;
> v2: Rebase
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Daniel Vetter
> Cc: Matthew Auld
Yes, a much preferred improvement.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_
les, so make use of the same timeout.
>
> References: 5427f207852d ("drm/i915: Bump wait-times for the final CS
> interrupt before parking")
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Mika Kuoppala
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
On Mon, 2017-12-11 at 19:41 +, Chris Wilson wrote:
> If wait_for_engines() fails and we resort to declaring the HW wedged,
> dump the engine state for debugging.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Mika Kuoppala
Reviewed-by: Joonas Lahtinen
CI_DEVFN(0, 0));
> > + int domain = pci_domain_nr(dev_priv->drm.pdev->bus);
> > +
> > + dev_priv->bridge_dev =
> > + pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0));
> > if (!dev_priv->bridge_dev) {
> > DRM_ERROR(
On Tue, 2017-12-12 at 19:07 -0500, Sinan Kaya wrote:
> On 12/12/2017 9:04 AM, Joonas Lahtinen wrote:
> > Hi,
> >
> > I sent this individual i915 patch to our CI, and it is passing on
> > all platforms:
> >
> > https://patchwork.freedesktop.org/series/3482
WOPCM
> related definitions int to a new header intel_guc_wopcm.h
> and moving GuC WOPCM related functions to a new source file
> intel_guc_wopcm.c
>
> Cc: Michal Wajdeczko
> Cc: Sagar Arun Kamble
> Cc: Chris Wilson
> Cc: Joonas Lahtinen
> Signed-off-by: Jackie Li
a feature that happens to be used by GuC (and
equally can be used by HuC too).
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, 2017-12-12 at 17:22 +, Chris Wilson wrote:
> As a simple fail-safe against a bad installation, check the tools exist
> before testing whether they work.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102935
> Signed-off-by: Chris Wilson
Reviewed-by:
On Tue, 2017-12-12 at 16:17 -0800, Lucas De Marchi wrote:
> On Tue, Dec 12, 2017 at 1:53 AM, Joonas Lahtinen
> wrote:
> > + Jani, who'll continue with -fixes
> >
> > On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote:
> > > On Mon, Dec 11, 2017 at
; [ 950.859341] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b
> [ 950.859343] Code: e8 30 60 01 00 83 c4 10 83 c3 04 39 f3 75 e0 8b 45 d8 8b
> 80 14 37 00 00 85 c0 74 13 68 dd 33 e4 c0 68 49 6f e3 c0 e8 4a 55 be ff <0f>
> ff 5e 5f b8 fe ff ff 3f bb 0a 00 00 00 e8
On Tue, 2017-12-12 at 18:06 +, Chris Wilson wrote:
> As kmalloc is allowed to block (if given the right flags), mark up the
> two i915_sw_fence routines that may call kmalloc as potential sleeping
> routines.
>
> Signed-off-by: Chris Wilson
> Cc: Tvrtko Ursulin
>
to throttle malicious clients that are consuming lots of system
> resources by capping the amount of memory used by fences.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Claim checks out,
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology
stem
> resources in requests, instead of causing a system-wide oom.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Maybe throw a Testcase: here?
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
construction) whilst under severe mempressure.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Mostly surprised we didn't have this test already :)
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technolog
imit, maybe throw this right
after the base? OTOH, it'll yell if it breaks...
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
e(&tl->last_request, NULL);
> INIT_LIST_HEAD(&tl->requests);
> i915_syncmap_init(&tl->sync);
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, 2017-12-13 at 16:06 +0100, Sebastian Andrzej Siewior wrote:
> On 2017-12-13 16:00:49 [+0200], Joonas Lahtinen wrote:
> > On Thu, 2017-11-30 at 16:19 +0100, Sebastian Andrzej Siewior wrote:
> > > The code has an ifdef and uses two functions to either init the bare
> &g
On Wed, 2017-12-13 at 14:59 -0800, Yaodong Li wrote:
> On 12/13/2017 01:34 PM, Michal Wajdeczko wrote:
> > On Wed, 13 Dec 2017 19:19:06 +0100, Yaodong Li
> > wrote:
> >
> > > On 12/13/2017 01:11 AM, Joonas Lahtinen wrote:
> > > > On Tue,
written to the supplied one. Without lockdep the set
name/class function vanishes.
Reported-by: kbuild test robot
Signed-off-by: Sebastian Andrzej Siewior
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_gem_timeline.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
di
On Thu, 2017-12-14 at 12:26 +, Chris Wilson wrote:
> Knowing the state of the engine when hangcheck thinks it is stalling is
> useful for both debugging hangcheck itself and the potential cause of an
> unwanted stall.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
&
s
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7495/issues.html
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
:1683 dwarn:1 dfail:0 fail:27 skip:1001
> time:13864s
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7496/shards.html
> _______
> Intel-gfx mailing lis
On Thu, 2017-12-14 at 20:55 -0800, Yaodong Li wrote:
> On 12/14/2017 03:43 AM, Joonas Lahtinen wrote:
> > On Wed, 2017-12-13 at 14:59 -0800, Yaodong Li wrote:
> > > On 12/13/2017 01:34 PM, Michal Wajdeczko wrote:
> > > > On Wed, 13 Dec 2017 19:19:06 +0
On Thu, 2017-12-14 at 19:57 +, Chris Wilson wrote:
> Why open code a printf/write loop, when we already have a function
> providing it?
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
Reviewed-by: Joonas Lahtinen
Will merge the patch.
Regards, Joonas
--
Joona
that will be rewritten every time. As they are
> temporary constructs, quietly report -ENOMEM back along the callchain
> rather than subject the system to oomkiller if an allocation fails.
>
> Signed-off-by: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Matthew Auld
Reviewed-by: Joo
Quoting Jani Nikula (2018-04-17 12:02:52)
> On Mon, 16 Apr 2018, "Srivatsa, Anusha" wrote:
> >>-Original Message-
> >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com]
> >>Sent: Wednesday, April 11, 2018 5:27 AM
> >>To: Ian W MORRISON
> >>Cc: Vivi, Rodrigo ; Srivatsa, Anusha
> >>; Wa
n_atomic_t()
> usage to the new wait_var_event() API")
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
IMEDOUT from wait_var_event_timeout() into another errno.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
the request/fence tracking.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> Signed-off-by: Chris Wilson
"i915_sched_node" might be a less confusing name compared to the DRM
core scheduler.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://l
const struct drm_i915_private *i915,
> +const struct i915_sched_attr *attr)
> +{
> + if (attr->priority == I915_PRIORITY_INVALID)
> + return;
This will yield a double space in the output. Just sayin'
> +
> + drm_pri
Quoting Chris Wilson (2018-04-18 12:14:15)
> Quoting Joonas Lahtinen (2018-04-18 10:10:17)
> > Quoting Chris Wilson (2018-04-17 20:06:38)
> > > The old wait_on_atomic_t used a custom callback to perform the
> > > schedule(), which used my return semantics of
lowed. As we need an ever growing number of parameters for
> scheduling, move those into a struct for convenience.
>
> v2: Move the anonymous struct into its own function for legibility and
> ye olde gcc.
>
> Signed-off-by: Chris Wilson
Reviewed
Quoting Tvrtko Ursulin (2018-04-18 12:33:42)
> From: Tvrtko Ursulin
>
> Currently our driver assumes BSD2 means hardware engine instance number
> two. This does not work for Icelake parts with two VCS engines, but which
> are hardware instances 0 and 2, and not 0 and 1 as with previous parts.
>
n handle_g2v_notification
Jani Nikula (1):
drm/i915/bios: filter out invalid DDC pins from VBT child devices
Joonas Lahtinen (1):
Merge tag 'gvt-fixes-2018-04-03' of https://github.com/intel/gvt-linux
into drm-intel-next-fixes
Tina Zhang (1):
drm/i915/gvt: Add drm_f
Quoting Daniel Vetter (2018-04-20 09:51:57)
> Control nodes are no more!
>
> Signed-off-by: Daniel Vetter
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> Cc: intel-gfx@lists.freedesktop.org
Reviewed-by: Joonas Lahti
Hi Dave,
And welcome back! Hope you had a good one.
We got a few -rc2 induced 3rd party bugs to CI (but that's nowadays
more the rule than an exception), but other than that the results look
solid.
Main thing are the fixes for the user reported black screen (DP MST)
and HDA codec interop issues
where supported.
>
> v2: Fix offset of CTX_R_PWR_CLK_STATE in intel_lr_context_set_sseu() (Lionel)
>
> v3: Add ability to program this per engine (Chris)
>
> v4: Move most get_sseu() into i915_gem_context.c (Lionel)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=
Quoting Jani Nikula (2018-04-27 12:20:55)
> On Wed, 25 Apr 2018, Ian W MORRISON wrote:
> > Can I ask if this is on anyone's radar as I'm concerned this patch will
> > stall otherwise?
>
> Pushed to drm-intel-next-queued, thanks for the patch.
>
> I opted to drop the Cc: stable for now. This does
Hi Dave,
Just the addition of Geminilake MODULE_FIRMWARE for DMC now when it's in
linux-firmware.git.
Regards, Joonas
drm-intel-fixes-2018-05-02:
Add DMC firmware for Geminilake.
The following changes since commit 6da6c0db5316275015e8cc2959f12a17584aeb64:
Linux v4.17-rc3 (2018-04-29 14:17:42
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
son
> Cc: Mika Kuoppala
Reviewed-by: Joonas Lahtinen
Regards, joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Paulo Zanoni (2018-05-03 03:23:52)
> ICL changes the registers and addresses to 64 bits.
>
> I also briefly looked at implementing an u64 version of the PCI config
> read functions, but I concluded this wouldn't be trivial, so it's not
> worth doing it for a single user that can't have any
esn't change:
>
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-5 (-5)
> Function old new delta
> i915_request_retire 17821777 -5
>
> Signed-off-by: Chris Wilson
> Cc: Tvrtko Ursulin
Reviewed
infinite timeout afterwards.
>
> Signed-off-by: Chris Wilson
May wanna Cc igt-dev@...
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Lionel Landwerlin (2018-04-26 13:22:30)
> On 26/04/18 11:00, Joonas Lahtinen wrote:
> > Quoting Lionel Landwerlin (2018-04-25 14:45:21)
> >> From: Chris Wilson
> >>
> >> We want to allow userspace to reconfigure the subslice configuration for
> >
Quoting Chris Wilson (2018-05-03 18:35:48)
> Quoting Paulo Zanoni (2018-05-03 16:24:47)
> > Em Qui, 2018-05-03 às 12:59 +0300, Joonas Lahtinen escreveu:
> > > Please split the patch here and add a respective Fixes: tag to when
> > > base Icelake support was introduced
el free to merge this through an appropriate tree, I guess you could
get some acks from LKML.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
> ---
> drivers/gpu/drm/i915/i915_utils.h | 12 ++--
> include/linux/kernel.h| 12
> 2 files changed, 14 inserti
Quoting Lis, Tomasz (2018-03-20 19:23:03)
>
>
> On 2018-03-19 15:26, Chris Wilson wrote:
>
> Quoting Lis, Tomasz (2018-03-19 14:14:19)
>
>
> On 2018-03-19 13:43, Chris Wilson wrote:
>
> Quoting Tomasz Lis (2018-03-19 12:37:35)
>
> The patch adds a para
gt; References: f773568b6ff8 ("drm/i915: nuke the duplicated stolen discovery")
> Signed-off-by: Chris Wilson
> Cc: Matthew Auld
> Cc: Joonas Lahtinen
> Cc: Ville Syrjälä
Reviewed-by: Joonas Lahtinen
Regards, Joonas
___
Intel-gfx
t; References: https://bugs.freedesktop.org/show_bug.cgi?id=106423
> Fixes: d15d7538c6d2 ("drm/i915: Tune down init error message due to failure
> injection")
> Signed-off-by: Chris Wilson
> Cc: Imre Deak
> Cc: Jani Nikula
> Cc: Joonas Lahtinen
> Cc: Rodrigo Vivi
> ---
>
s should not be needed, it was introduced in v4.17-rc1 only.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
> Cc: Ingo Molnar
> Cc: H. Peter Anvin
> Cc: x...@kernel.org
> Cc: Daniele Ceraolo Spurio
> Cc: Joonas Lahtinen
> Signed-off-by: Paulo Zanoni
> ---
> arch/x
Quoting Chris Wilson (2018-05-08 03:30:45)
> lookup_priolist() no longer attaches the request into the priolist, it
> just returns the priolist for the given priority instead. Drop the
> unused parameter.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
y: Chris Wilson
Comment below.
Reviewed-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c
> b/drivers/gpu/drm/i915/intel_lrc.c
> index a9d211f28ab8.
Hi Dave,
Not quite the explosion you were afraid of, but three fixes to avoid
a some WARNs and *ERROR*s. I'm still trying to get an Ack for merging
the ICL stolen early quirks through our tree and then including them
in the next -fixes (I know we're bit late :( )
I'm travelling for the rest of th
Quoting Souptick Joarder (2018-04-17 22:02:02)
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Reference id ->
This is a purely a gvt patch too, so the patch subject should reflect
that.
Regards, Joonas
Quoting changbin...@intel.com (2018-05-08 12:05:16)
> From: Changbin Du
>
> Now GVTg supports shadowing both 2M/64K huge gtt pages. So let's turn on
> the cap info bit VGT_CAPS_HUGE_GTT.
>
> v2: Split
Hi Dave,
Nothing too big this time either, a missing W/A added and fix
for rare HW race in addition to early IOCTL error check.
We got kthread_park related splats to CI from -rc5, so the results
are to be taken with a pinch of salt. The fix to factor around it is
bit too much for -fixes and there
e-a:
> > pass -> DMESG-WARN (ro-bdw-i7-5557U)
> https://bugs.freedesktop.org/show_bug.cgi?id=96913
Patch merged, thanks for the patch and review.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
> @@ -232,6 +232,11 @@ struct i915_vma {
> struct drm_i915_gem_exec_object2 *exec_entry;
> };
>
> +struct i915_vma *
> +i915_vma_create(struct drm_i915_gem_object *obj,
> + struct i915_address_space *vm,
> +
On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> It's an outright programming error, so explode if it is ever hit.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/i915/i915_gem_request.c | 10 ++
> 1 file chan
re available. However, anything that may be frequently pinned
> (such as logical contexts) we want to use the fast search & insert.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/i915/intel_lrc.c| 2 +-
> drivers/gpu/drm/i915
or_state *error,
> ee->head = I915_READ_HEAD(engine);
> ee->tail = I915_READ_TAIL(engine);
> ee->ctl = I915_READ_CTL(engine);
> + if (INTEL_GEN(dev_priv) > 2)
> + ee->mode = I915_READ_MODE(engine);
IS_GEN2 is used el
t; - if (ret == 0) {
> + err = i915_gem_object_fence_ok(obj, args->tiling_mode);
> + if (!err) {
> if (obj->pages &&
> obj->madv == I915_MADV_WILLNEED &&
> dev_priv->quirks & QUIRK_PIN_SWIZZLED_PAGES) {
> @@ -281,7 +290,7 @@ err:
>
> intel_runtime_pm_put(dev_priv);
>
> - return ret;
> + return err;
> }
>
> /**
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
side critical sections have
ended after calling rcu_synchronize()? And will be valid during
rcu_read_lock().
If we do not use read side critical sections, how do we expect the
synchronization to happen by RCU code?
Regards, Joonas
> I think I am
> overestimating the barriers in place for RCU,
On ti, 2016-08-09 at 08:14 +0100, Chris Wilson wrote:
> On Tue, Aug 09, 2016 at 09:36:48AM +0300, Joonas Lahtinen wrote:
> >
> > On ma, 2016-08-08 at 10:45 +0100, Chris Wilson wrote:
> > >
> > > On Mon, Aug 08, 2016 at 10:30:25AM +0100, Chris Wilson wrote:
>
ging request. And now we can cross-reference the request's
> context state with that loaded by the GPU.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/i915/i915_gpu_error.c | 28
> 1 file changed, 4 inser
t; 32;
> + val |= vma->node.start & 0xf000;
> + val |= (u64)((stride / 128) - 1) << fence_pitch_shift;
This was rather magicy before, but it could be much better. The rest
are less so. Can be added to TODO.
With above converted to
y: Chris Wilson
Reviewed-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 49
> -
> 1 file changed, 49 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
>
m_gtt_info, 0, 0},
"i915_gem_pin_display" then? Otherwise it's a fragile change.
Regards, Joonas
> {"i915_gem_stolen", i915_gem_stolen_list_info },
> {"i915_gem_pageflip", i915_gem_pageflip_info, 0},
> {"i915_gem_request", i915_gem_request_info, 0},
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On ti, 2016-08-09 at 11:46 +0100, Chris Wilson wrote:
> On Tue, Aug 09, 2016 at 01:39:02PM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > > @@ -5327,7 +5320,7 @@ static const struct drm_info_list
; drm_i915_error_state_buf *m,
> err_printf(m, " --- gtt_offset = 0x%08x %08x\n",
If intended for userspace parsing "0x%08x %08x" vs. "0x%08x_%08x" would
be good to be consistent. And to reduce such error in future, I'd also
mak
link)
> + j++;
> +
> + bo = NULL;
Initialize at declaration as this is one-shot.
> /* Capture all registers which don't fit into another category. */
> static void i915_capture_reg_state(struct drm_i915_private *dev_priv,
> struct drm_i915_e
++pin_count;
variables names to form pin_display_*
> + seq_printf(m, "%u mapped objects, %llu bytes\n",
> + mapped_count, mapped_size);
> + seq_printf(m, "%u pinned objects, %llu bytes\n",
"display pinned objects"
With those
nce handling of the request->batch_obj next to
> where the active tracking is set up for the request.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
i915_gem_object_unpin_map(ce->state->obj);
> +unpin_vma:
> + __i915_vma_unpin(ce->state);
err_vma while at it?
> @@ -2161,7 +2162,7 @@ static int execlists_context_deferred_alloc(struct
> i915_gem_context *ctx,
> }
>
> ce->ring = ring;
> - ce->state = ctx_obj;
> + ce->state = vma;
Maybe the member name could be just ce->vma too?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On ke, 2016-08-10 at 08:15 +0100, Chris Wilson wrote:
> On Wed, Aug 10, 2016 at 10:04:16AM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > >
> > > - if (i) {
> > > + active_bo = NULL;
> > Could be i
On ke, 2016-08-10 at 08:38 +0100, Chris Wilson wrote:
> On Wed, Aug 10, 2016 at 10:29:59AM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > >
> > > if (obj->pin_display) {
> > > -
/*
> * Clear this page out of any CPU caches for coherent swap-in/out.
> */
Move/update the comment too?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
e into a zlib function?
> @@ -629,6 +680,18 @@ i915_error_object_create(struct drm_i915_private *i915,
>
> dst->gtt_offset = vma->node.start;
> dst->page_count = 0;
> + dst->unused = 0;
> +
> + memset(&zstream, 0, sizeof(zstr
On ke, 2016-08-10 at 10:02 +0100, Chris Wilson wrote:
> On Wed, Aug 10, 2016 at 11:41:39AM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > >
> > > @@ -771,6 +771,13 @@ static int do_rcs_switch(struct drm_i915_ge
On ke, 2016-08-10 at 09:36 +0100, Chris Wilson wrote:
> On Wed, Aug 10, 2016 at 11:07:46AM +0300, Joonas Lahtinen wrote:
> >
> > On ke, 2016-08-10 at 08:15 +0100, Chris Wilson wrote:
> > >
> > > On Wed, Aug 10, 2016 at 10:04:16AM +0300, Joonas Lahtinen wrote
On ke, 2016-08-10 at 09:25 +0100, Chris Wilson wrote:
> On Wed, Aug 10, 2016 at 11:03:39AM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > >
> > > - if (!i915_gem_obj_ggtt_bound(ctx_obj))
> > > -
On ti, 2016-08-09 at 12:53 +0100, Chris Wilson wrote:
> On Tue, Aug 09, 2016 at 02:44:41PM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > > @@ -446,15 +458,7 @@ int i915_error_state_to_str(struct
> >
On ma, 2016-08-08 at 10:09 +0100, Chris Wilson wrote:
> On Mon, Aug 08, 2016 at 12:01:07PM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > > @@ -390
On ke, 2016-08-10 at 12:13 +0200, Daniel Vetter wrote:
> On Wed, Aug 10, 2016 at 12:12:37PM +0200, Daniel Vetter wrote:
> >
> > On Tue, Aug 09, 2016 at 10:05:30AM +0100, Chris Wilson wrote:
> > >
> > > On Tue, Aug 09, 2016 at 11:48:56AM +0300, Joonas Lahtinen wr
On ke, 2016-08-10 at 11:52 +0100, Chris Wilson wrote:
> On Wed, Aug 10, 2016 at 01:32:29PM +0300, Joonas Lahtinen wrote:
> >
> > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote:
> > >
> > > @@ -309,12 +310,30 @@ void i915_error_printf(struct
> > >
t;i915, size);
> + if (IS_ERR(vma)) {
> kfree(ring);
> - return ERR_PTR(ret);
> + return ERR_CAST(vma);
> }
> + ring->vma = vma;
> + if (HAS_LLC(engine->i915) && !vma->obj->stolen
node.start + 2*CACHELINE_BYTES;
While correcting formatting; add spaces around *
With those two tweaks;
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
object *old_vid_bo;
> + struct i915_vma *vma, *old_vma;
Only nitpick here; I'd keep two line form.
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel
j, &dev_priv->ggtt.base, NULL);
> + if (IS_ERR(vma)) {
> + i915_gem_object_put(obj);
> + i915.semaphores = 0;
> + return;
Goto teardown.
> + }
> +
> + ret = i915_vma_pin(vma,
701 - 800 of 2919 matches
Mail list logo
