Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest

2023-08-16 Thread Kalvala, Haridhar
On 8/16/2023 12:10 PM, Kalvala, Haridhar wrote: On 8/11/2023 5:16 AM, Matt Roper wrote: Rather than picking random tiling formats from a pool that contains both TileY and Tile4 and then trying to replace one with the other depending on the platform, it's simpler to just use a single enum

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Eliminate has_4tile feature flag

2023-08-16 Thread Kalvala, Haridhar
On 8/16/2023 8:48 PM, Matt Roper wrote: On Wed, Aug 16, 2023 at 12:16:25PM +0530, Kalvala, Haridhar wrote: On 8/11/2023 5:16 AM, Matt Roper wrote: We don't really need a feature flag for has_4tile since there's a well-defined cutover point (DG2) at which all new platforms started using Tile4

Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftest: Simplify Y-major tiling in blit selftest

2023-08-16 Thread Kalvala, Haridhar
On 8/11/2023 5:16 AM, Matt Roper wrote: Rather than picking random tiling formats from a pool that contains both TileY and Tile4 and then trying to replace one with the other depending on the platform, it's simpler to just use a single enum value that represents whatever the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Eliminate has_4tile feature flag

2023-08-16 Thread Kalvala, Haridhar
On 8/11/2023 5:16 AM, Matt Roper wrote: We don't really need a feature flag for has_4tile since there's a well-defined cutover point (DG2) at which all new platforms started using Tile4 as their Y-major tiling layout. The GT side of the code already handles Tile4 vs legacy TileY with checks

Re: [Intel-gfx] [PATCH v1.1] drm/i915/mtl: Implement Wa_14019141245

2023-04-26 Thread Kalvala, Haridhar
On 4/26/2023 9:41 PM, Sripada, Radhakrishna wrote: -Original Message- From: Kalvala, Haridhar Sent: Wednesday, April 26, 2023 5:36 AM To: Sripada, Radhakrishna ; intel- g...@lists.freedesktop.org Cc: Vivi, Rodrigo Subject: Re: [Intel-gfx] [PATCH v1.1] drm/i915/mtl: Implement

Re: [Intel-gfx] [PATCH v1.1] drm/i915/mtl: Implement Wa_14019141245

2023-04-26 Thread Kalvala, Haridhar
On 4/26/2023 12:00 AM, Radhakrishna Sripada wrote: Enable strict RAR to prevent spurious GPU hangs. v1.1: Rebase Cc: Rodrigo Vivi Cc: Umesh Nerlige Ramappa Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 5 +

Re: [Intel-gfx] [PATCH 2/2] drm/i915/mtl: Copy c10 phy pll sw state from master to slave for bigjoiner

2023-04-26 Thread Kalvala, Haridhar
On 4/21/2023 3:42 AM, Radhakrishna Sripada wrote: From: Stanislav Lisovskiy We try to verify pll registers in sw state for slave crtc with the hw state. However in case of bigjoiner we don't calculate those at all, so this verification will then always fail. So we should either skip the

Re: [Intel-gfx] [PATCH 1/2] drm/i915/mtl: Add the missing CPU transcoder mask in intel_device_info

2023-04-26 Thread Kalvala, Haridhar
On 4/21/2023 3:42 AM, Radhakrishna Sripada wrote: CPU transcoder mask is used to iterate over the available CPU transcoders in the macro for_each_cpu_transcoder(). The macro is broken on MTL and got highlighted when audio state was being tracked for each transcoder added in [1]. Add the

Re: [Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-03-31 Thread Kalvala, Haridhar
On 3/30/2023 10:49 PM, Lionel Landwerlin wrote: On 29/03/2023 01:49, Matt Atwood wrote: On Tue, Mar 28, 2023 at 04:14:33PM +0530, Kalvala, Haridhar wrote: On 3/9/2023 8:56 PM, Lionel Landwerlin wrote: By default the indirect state sampler data (border colors) are stored in the same heap

Re: [Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-04-03 Thread Kalvala, Haridhar
On 3/31/2023 12:35 PM, Kalvala, Haridhar wrote: On 3/30/2023 10:49 PM, Lionel Landwerlin wrote: On 29/03/2023 01:49, Matt Atwood wrote: On Tue, Mar 28, 2023 at 04:14:33PM +0530, Kalvala, Haridhar wrote: On 3/9/2023 8:56 PM, Lionel Landwerlin wrote: By default the indirect state sampler

Re: [Intel-gfx] [v3] drm/i915: disable sampler indirect state in bindless heap

2023-04-03 Thread Kalvala, Haridhar
On 3/31/2023 2:12 AM, Lionel Landwerlin wrote: By default the indirect state sampler data (border colors) are stored in the same heap as the SAMPLER_STATE structure. For userspace drivers that can be 2 different heaps (dynamic state heap & bindless sampler state heap). This means that border

Re: [Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-03-28 Thread Kalvala, Haridhar
On 3/9/2023 8:56 PM, Lionel Landwerlin wrote: By default the indirect state sampler data (border colors) are stored in the same heap as the SAMPLER_STATE structure. For userspace drivers that can be 2 different heaps (dynamic state heap & bindless sampler state heap). This means that border

Re: [Intel-gfx] [PATCH v2] drm/i915: Extend Wa_14015795083 platforms

2023-06-22 Thread Kalvala, Haridhar
On 6/17/2023 4:20 AM, Matt Roper wrote: This workaround was already implemented for DG2, PVC, and some steppings of MTL, but the workaround database has now been updated to extend this workaround to TGL, RKL, DG1, and ADL. v2: - Skip readback verification for these extra gen12lp platforms.

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mtl: Extend Wa_16014892111 to MTL A-step

2023-05-14 Thread Kalvala, Haridhar
On 5/13/2023 7:44 AM, Radhakrishna Sripada wrote: The dg2 workaround which is used for performance tuning is needed for Meteorlake A-step. v2: Limit the WA for A-step Bspec: 68331 Cc: Haridhar Kalvala Cc: Matt Roper Cc: Gustavo Sousa Signed-off-by: Radhakrishna Sripada ---

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/mtl: Add MTL performance tuning changes

2023-05-14 Thread Kalvala, Haridhar
On 5/13/2023 7:44 AM, Radhakrishna Sripada wrote: MTL reuses the tuning parameters for DG2. Extend the dg2 performance tuning parameters to MTL. v2: Add DRAW_WATERMARK tuning parameter. Bspec: 68331 Cc: Haridhar Kalvala Cc: Matt Roper Cc: Gustavo Sousa Signed-off-by: Radhakrishna Sripada

Re: ✗ Fi.CI.IGT: failure for Extend ARL support

2024-01-19 Thread Kalvala, Haridhar
On 1/19/2024 5:03 AM, Matt Roper wrote: On Mon, Jan 08, 2024 at 03:37:29PM -, Patchwork wrote: == Series Details == Series: Extend ARL support URL : https://patchwork.freedesktop.org/series/128322/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14092_full ->

Re: [PATCH] drm/i915/xelpg: Add fake PCH for xelpg

2023-12-19 Thread Kalvala, Haridhar
On 12/18/2023 9:24 PM, Matt Roper wrote: Oh, and one more thing I forgot to mention before hitting send...the title for this patch doesn't make sense. Xe_LPG is the graphics IP used by MTL; that's completely unrelated to the display IP (which is Xe_LPD+). Since we're assigning the fake PCH

Re: [PATCH] drm/i915/mtl: Add fake PCH for Meteor Lake

2023-12-19 Thread Kalvala, Haridhar
On 12/19/2023 10:39 PM, Matt Roper wrote: On Tue, Dec 19, 2023 at 02:58:00PM +0530, Haridhar Kalvala wrote: Correct the implementation trying to detect MTL PCH with the MTL fake PCH id. On MTL, both the North Display (NDE) and South Display (SDE) functionality reside on the same die (the SoC

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_14019877138

2023-12-12 Thread Kalvala, Haridhar
On 12/11/2023 9:26 PM, Matt Roper wrote: On Mon, Dec 11, 2023 at 05:08:48PM +0530, Kalvala, Haridhar wrote: On 12/6/2023 1:54 AM, Matt Roper wrote: On Tue, Dec 05, 2023 at 02:41:05PM +0530, Haridhar Kalvala wrote: Enable Force Dispatch Ends Collection for DG2. BSpec: 46001 Signed-off

Re: [PATCH v2] drm/i915/mtl: Add fake PCH for Meteor Lake

2023-12-21 Thread Kalvala, Haridhar
On 12/21/2023 3:41 AM, Matt Roper wrote: On Wed, Dec 20, 2023 at 12:22:33AM +0530, Haridhar Kalvala wrote: Correct the implementation trying to detect MTL PCH with the MTL fake PCH id. On MTL, both the North Display (NDE) and South Display (SDE) functionality reside on the same die (the SoC

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_14019877138

2023-12-11 Thread Kalvala, Haridhar
On 12/6/2023 1:54 AM, Matt Roper wrote: On Tue, Dec 05, 2023 at 02:41:05PM +0530, Haridhar Kalvala wrote: Enable Force Dispatch Ends Collection for DG2. BSpec: 46001 Signed-off-by: Haridhar Kalvala --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 +++