[Intel-gfx] [CI 15/21] drm/i915/tgl: apply Display WA #1178 to fix type C dongles

2019-07-10 Thread Lucas De Marchi
Add port C to workaround to cover Tiger Lake. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-22-lucas.demar...@intel.com --- drivers/gpu/drm/i915/display/intel_display_power.c | 11

[Intel-gfx] [CI 12/21] drm/i915/tgl: Add additional ports for Tiger Lake

2019-07-10 Thread Lucas De Marchi
. v2: Rebase on new modular FIA code (Lucas) v3: Also add new port in port_identifier(), even though it can't possibly be used there (requested by José) Cc: Anusha Srivatsa Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza Link: https

[Intel-gfx] [CI 14/21] drm/i915/tgl: init ddi port A-C for Tiger Lake

2019-07-10 Thread Lucas De Marchi
From: Mahesh Kumar This patch initializes DDI PORT A, B & C for Tiger lake. Other TC ports need to be initialized later once corresponding code is there. Cc: Madhav Chauhan Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza Link: h

[Intel-gfx] [CI 19/21] drm/i915/tgl: Add vbt value mapping for DDC Bus pin

2019-07-10 Thread Lucas De Marchi
From: Mahesh Kumar Add VBT-value to DDC bus pin mapping for the same. Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-21-lucas.demar...@intel.com --- drivers/gpu/drm/i915

[Intel-gfx] [CI 20/21] drm/i915/tgl: Add DPLL registers

2019-07-10 Thread Lucas De Marchi
On TGL the port programming for combophy is very similar to ICL, so adapt the callers to possibly use the different register values. v2 (Lucas): Add TODO with about DPLL4 (requested by Ville) Cc: Vandita Kulkarni Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä Link

[Intel-gfx] [CI 02/21] drm/i915/tgl: add initial Tiger Lake definitions

2019-07-10 Thread Lucas De Marchi
: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-3-lucas.demar...@intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu

[Intel-gfx] [CI 05/21] drm/i915/tgl: Add TGL PCI IDs

2019-07-10 Thread Lucas De Marchi
Current list of PCI IDs for Tiger Lake. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi Reviewed-by: Mika Kahola Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-6-lucas.demar...@intel.com --- drivers/gpu/drm/i915/i915_pci.c | 1 + include

[Intel-gfx] [CI 13/21] drm/i915/tgl: extend intel_port_is_combophy/tc

2019-07-10 Thread Lucas De Marchi
From: Mahesh Kumar TGL has 3 combophy ports, so extend check for tigerlake in intel_port_is_combophy/tc function. Cc: Mika Kahola Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza Link: https://patchwork.freedesktop.org/patch/msgid

[Intel-gfx] [CI 11/21] drm/i915/tgl: Add pll manager

2019-07-10 Thread Lucas De Marchi
From: Vandita Kulkarni Add a new pll array for Tiger Lake. The TC pll functions for type C will be covered in later patches after its phy is implemented. Cc: Madhav Chauhan Cc: Rodrigo Vivi Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi Link

[Intel-gfx] [CI 03/21] drm/i915/tgl: Introduce Tiger Lake PCH

2019-07-10 Thread Lucas De Marchi
From: Radhakrishna Sripada Add the enum additions to TGP. Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: David Weinehall Cc: James Ausmus Signed-off-by: Radhakrishna Sripada Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi Link: https://patchwork.freedesktop.org/patch/msgid

[Intel-gfx] [CI 21/21] drm/i915/tgl: Update DPLL clock reference register

2019-07-10 Thread Lucas De Marchi
From: José Roberto de Souza This register definition changed from ICL and has now another meaning. Use the right bits on TGL. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid

[Intel-gfx] [CI 18/21] drm/i915/tgl: port to ddc pin mapping

2019-07-10 Thread Lucas De Marchi
function for TGL, but rather reuse the ICL one (suggested by Rodrigo) Cc: Anusha Srivatsa Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi Link: https://patchwork.freedesktop.org/patch/msgid/20190709170044.29489-1-lucas.demar...@intel.com --- drivers/gpu/drm/i915

[Intel-gfx] [CI 08/21] drm/i915/tgl: Add power well support

2019-07-10 Thread Lucas De Marchi
Cc: Anusha Srivatsa Cc: Rodrigo Vivi Cc: José Roberto de Souza Signed-off-by: Imre Deak Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-10-lucas.demar...@intel.com --- .../drm/i915/display

[Intel-gfx] [CI 07/21] drm/i915/tgl: rename TRANSCODER_EDP_VDSC to use on transcoder A

2019-07-10 Thread Lucas De Marchi
en) v3 (Lucas): - Rename power domain so it's clear it can also be used for transcoder A in TGL (requested by José and Manasi) Cc: Imre Deak Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi Acked-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_p

[Intel-gfx] [CI 06/21] drm/i915/tgl: Check if pipe D is fused

2019-07-10 Thread Lucas De Marchi
From: José Roberto de Souza On Tiger Lake there is one more pipe - check if it's fused. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi Reviewed-by: Mika Kahola Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-8-lucas.demar...@intel.com

[Intel-gfx] [CI 16/21] drm/i915/gen12: MBUS B credit change

2019-07-10 Thread Lucas De Marchi
-off-by: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-23-lucas.demar...@intel.com --- drivers/gpu/drm/i915/display/intel_display.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

[Intel-gfx] [CI 10/21] drm/i915/tgl: Add new pll ids

2019-07-10 Thread Lucas De Marchi
-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-12-lucas.demar...@intel.com --- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 23 +++ 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers

[Intel-gfx] [CI 17/21] drm/i915/tgl: Add gmbus gpio pin to port mapping

2019-07-10 Thread Lucas De Marchi
From: Mahesh Kumar Add default GPIO pin mapping for all ports. Tiger Lake has 3 combophy ports and 6 TC ports, gpio pin1-3 are mapped to combophy & pin9-14 are mapped to TC ports. Cc: Anusha Srivatsa Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Revi

[Intel-gfx] [CI 04/21] drm/i915/tgl: Add TGL PCH detection in virtualized environment

2019-07-10 Thread Lucas De Marchi
From: Mahesh Kumar Assume PCH_TGP when platform is TGL. Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-5-lucas.demar...@intel.com --- drivers/gpu/drm/i915

[Intel-gfx] [CI 01/21] drm/i915: Add 4th pipe and transcoder

2019-07-10 Thread Lucas De Marchi
Add pipe D and transcoder D to prepare for platforms having them. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20190708231629.9296-2-lucas.demar...@intel.com --- drivers/gpu/drm/i915/display/intel_display.c | 3

[Intel-gfx] [PATCH v3 12/21] drm/i915/tgl: Add additional ports for Tiger Lake

2019-07-11 Thread Lucas De Marchi
ita Kulkarni Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_ddi.c | 12 drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/display/intel_display.h | 8 include/drm/i915_component.h | 2 +- include/

[Intel-gfx] [PATCH v3 02/21] drm/i915/tgl: add initial Tiger Lake definitions

2019-07-11 Thread Lucas De Marchi
: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_pci.c | 29 drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 05/21] drm/i915/tgl: Add TGL PCI IDs

2019-07-11 Thread Lucas De Marchi
Current list of PCI IDs for Tiger Lake. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi Reviewed-by: Mika Kahola --- drivers/gpu/drm/i915/i915_pci.c | 1 + include/drm/i915_pciids.h | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH v3 07/21] drm/i915/tgl: rename TRANSCODER_EDP_VDSC to use on transcoder A

2019-07-11 Thread Lucas De Marchi
en) v3 (Lucas): - Rename power domain so it's clear it can also be used for transcoder A in TGL (requested by José and Manasi) Cc: Imre Deak Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi Acked-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_p

[Intel-gfx] [PATCH v3 00/21] Initial support for Tiger Lake

2019-07-11 Thread Lucas De Marchi
A drm/i915/tgl: Update DPLL clock reference register Lucas De Marchi (6): drm/i915: Add 4th pipe and transcoder drm/i915/tgl: Add TGL PCI IDs drm/i915/tgl: Add additional PHYs for Tiger Lake drm/i915/tgl: apply Display WA #1178 to fix type C dongles drm/i915/tgl: port to ddc pin mapping

[Intel-gfx] [PATCH v3 20/21] drm/i915/tgl: Add DPLL registers

2019-07-11 Thread Lucas De Marchi
On TGL the port programming for combophy is very similar to ICL, so adapt the callers to possibly use the different register values. v2 (Lucas): Add TODO with about DPLL4 (requested by Ville) Cc: Vandita Kulkarni Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä

[Intel-gfx] [PATCH v3 18/21] drm/i915/tgl: port to ddc pin mapping

2019-07-11 Thread Lucas De Marchi
function for TGL, but rather reuse the ICL one (suggested by Rodrigo) v3: rebase after the introduction of enum phy and use it for the conversions Cc: Anusha Srivatsa Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_hdmi.c | 36 ++- 1

[Intel-gfx] [PATCH v3 06/21] drm/i915/tgl: Check if pipe D is fused

2019-07-11 Thread Lucas De Marchi
From: José Roberto de Souza On Tiger Lake there is one more pipe - check if it's fused. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi Reviewed-by: Mika Kahola --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_device_info.c | 3 +++ 2 files

[Intel-gfx] [PATCH v3 09/21] drm/i915/tgl: Add power well to support 4th pipe

2019-07-11 Thread Lucas De Marchi
From: Mika Kahola Add power well 5 to support 4th pipe and transcoder on TGL. Cc: James Ausmus Cc: Imre Deak Signed-off-by: Mika Kahola Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- .../drm/i915/display/intel_display_power.c| 28 +-- .../drm/i915/display

[Intel-gfx] [PATCH v3 19/21] drm/i915/tgl: Add vbt value mapping for DDC Bus pin

2019-07-11 Thread Lucas De Marchi
From: Mahesh Kumar Add VBT-value to DDC bus pin mapping for the same. Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 17 - drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3

[Intel-gfx] [PATCH v3 21/21] drm/i915/tgl: Update DPLL clock reference register

2019-07-11 Thread Lucas De Marchi
From: José Roberto de Souza This register definition changed from ICL and has now another meaning. Use the right bits on TGL. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 8

[Intel-gfx] [PATCH v3 13/21] drm/i915/tgl: Add additional PHYs for Tiger Lake

2019-07-11 Thread Lucas De Marchi
Tiger Lake has up to 3 combo phys and 6 TC phys. Extend the helper conversion functions from port to phy. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c | 5 - drivers/gpu/drm/i915/display/intel_display.h | 3 +++ 2 files changed, 7 insertions(+), 1 deletion

[Intel-gfx] [PATCH v3 14/21] drm/i915/tgl: init ddi port A-C for Tiger Lake

2019-07-11 Thread Lucas De Marchi
From: Mahesh Kumar This patch initializes DDI PORT A, B & C for Tiger lake. Other TC ports need to be initialized later once corresponding code is there. Cc: Madhav Chauhan Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza --- drivers/gpu

[Intel-gfx] [PATCH v3 15/21] drm/i915/tgl: apply Display WA #1178 to fix type C dongles

2019-07-11 Thread Lucas De Marchi
Add port C to workaround to cover Tiger Lake. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel_display_power.c | 7 +++ drivers/gpu/drm/i915/i915_reg.h| 4 +++- 2 files changed, 10 insertions(+), 1

[Intel-gfx] [PATCH v3 03/21] drm/i915/tgl: Introduce Tiger Lake PCH

2019-07-11 Thread Lucas De Marchi
From: Radhakrishna Sripada Add the enum additions to TGP. Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: David Weinehall Cc: James Ausmus Signed-off-by: Radhakrishna Sripada Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 4 drivers/gpu/drm

[Intel-gfx] [PATCH v3 08/21] drm/i915/tgl: Add power well support

2019-07-11 Thread Lucas De Marchi
Cc: Anusha Srivatsa Cc: Rodrigo Vivi Cc: José Roberto de Souza Signed-off-by: Imre Deak Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä --- .../drm/i915/display/intel_display_power.c| 474 +- .../drm/i915/display/intel_display_power.h| 26 +- drivers/gpu

[Intel-gfx] [PATCH v3 16/21] drm/i915/gen12: MBUS B credit change

2019-07-11 Thread Lucas De Marchi
-off-by: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v3 04/21] drm/i915/tgl: Add TGL PCH detection in virtualized environment

2019-07-11 Thread Lucas De Marchi
From: Mahesh Kumar Assume PCH_TGP when platform is TGL. Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 01/21] drm/i915: Add 4th pipe and transcoder

2019-07-11 Thread Lucas De Marchi
Add pipe D and transcoder D to prepare for platforms having them. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- drivers/gpu/drm/i915/display/intel_display.h | 4 drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH v3 17/21] drm/i915/tgl: Add gmbus gpio pin to port mapping

2019-07-11 Thread Lucas De Marchi
From: Mahesh Kumar Add default GPIO pin mapping for all ports. Tiger Lake has 3 combophy ports and 6 TC ports, gpio pin1-3 are mapped to combophy & pin9-14 are mapped to TC ports. Cc: Anusha Srivatsa Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Revi

[Intel-gfx] [PATCH v3 10/21] drm/i915/tgl: Add new pll ids

2019-07-11 Thread Lucas De Marchi
-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 23 +++ 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h index

[Intel-gfx] [PATCH v3 11/21] drm/i915/tgl: Add pll manager

2019-07-11 Thread Lucas De Marchi
From: Vandita Kulkarni Add a new pll array for Tiger Lake. The TC pll functions for type C will be covered in later patches after its phy is implemented. Cc: Madhav Chauhan Cc: Rodrigo Vivi Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915: Add modular FIA

2019-07-11 Thread Lucas De Marchi
On Thu, Jul 11, 2019 at 04:15:42PM -0700, Summers, Stuart wrote: On Thu, 2019-07-11 at 13:58 -0700, Lucas De Marchi wrote: From: Anusha Srivatsa Some platforms may have Modular FIA. If Modular FIA is used in the SOC, then Display Driver will access the additional instances of FIA based on pre

[Intel-gfx] [PATCH v4 1/2] drm/i915: Add modular FIA

2019-07-11 Thread Lucas De Marchi
): Add comment about the mapping between FIA and TC port (suggested by Stuart) Cc: Jani Nikula Signed-off-by: Anusha Srivatsa Signed-off-by: Lucas De Marchi Acked-by: Ville Syrjälä Reviewed-by: Stuart Summers --- drivers/gpu/drm/i915/display/intel_display.h | 6 +++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 2/2] drm/i915/tgl: add modular FIA to device info

2019-07-11 Thread Lucas De Marchi
Tiger Lake has modular FIA bit indicating if we are using it, so add to the device info. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index e83c94cf2744

[Intel-gfx] [PATCH v4 0/2] Modular FIA

2019-07-11 Thread Lucas De Marchi
https://patchwork.freedesktop.org/series/63175/ Changes: - Add comment explaining mapping port <-> FIA - Add commit to apply modular FIA on TGL Anusha Srivatsa (1): drm/i915: Add modular FIA Lucas De Marchi (1): drm/i915/tgl: add modular FIA to device info drivers/gpu/drm/i915/d

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915: Add modular FIA

2019-07-12 Thread Lucas De Marchi
t;= 12. Or we can leave as is and change it to be a gen check when next platforms come. Lucas De Marchi Lucas De Marchi > >Thanks, >Stuart > >>func(has_overlay); \ >>func(has_psr); \ >>func(overlay_needs_physical); \ >> diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/tgl: add modular FIA to device info

2019-07-12 Thread Lucas De Marchi
On Fri, Jul 12, 2019 at 10:48:48AM -0700, Summers, Stuart wrote: On Thu, 2019-07-11 at 22:57 -0700, Lucas De Marchi wrote: Tiger Lake has modular FIA bit indicating if we are using it, so add to the device info. Signed-off-by: Lucas De Marchi Reviewed-by: Stuart Summers Both patches

[Intel-gfx] [PATCH] x86/gpu: add TGL stolen memory support

2019-07-12 Thread Lucas De Marchi
From: Michel Thierry Reuse Gen11 stolen memory changes since Tiger Lake uses the same BSM register (and format). Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: x...@kernel.org Signed-off-by: Michel Thierry Signed-off-by: Lucas De Marchi

[Intel-gfx] [PATCH 09/22] drm/i915/tgl: re-indent code to prepare for DKL changes

2019-07-12 Thread Lucas De Marchi
The final save operation into pll_state of the calculations done will be different for DKL PHY. Prepare for that by reindenting code so it's easier to check for correctness. This one has no change in behavior. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c

[Intel-gfx] [PATCH 02/22] drm/i915/tgl: select correct bit for port select

2019-07-12 Thread Lucas De Marchi
tate() in intel_display.c that was missing - Define macros using the _SHIFT macros so we don't lose other users Cc: Ville Syrjälä Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_ddi.c | 47 +++- drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH 01/22] drm/i915/tgl: skip setting PORT_CL_DW12_* on initialization

2019-07-12 Thread Lucas De Marchi
phy introduction Cc: Imre Deak Cc: Matt Roper Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c

[Intel-gfx] [PATCH 10/22] drm/i915/tgl: Add DKL phy pll state calculations

2019-07-12 Thread Lucas De Marchi
From: Vandita Kulkarni Reuse the existing calculate icl_calc_mg_pll_state() function. Since the pll variables are calculated differently for DKL phy, add support for the same. Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c

[Intel-gfx] [PATCH 16/22] drm/i915/tgl: Implement Wa_1604555607

2019-07-12 Thread Lucas De Marchi
From: Michel Thierry Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). FF_MODE2 is part of the register state context, that's why it is implemented here. Signed-off-by: Michel Thierry Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 8

[Intel-gfx] [PATCH 06/22] drm/i915/tgl: handle DP aux interrupts

2019-07-12 Thread Lucas De Marchi
For Tiger Lake the DE Port Interrupt Definition bits changed, so use the new bit definitions. Cc: Jose Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_irq.c | 16 +++- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed, 14 insertions(+), 5 deletions

[Intel-gfx] [PATCH 05/22] drm/i915/tgl: Update north display hotplug detection to TGL connections

2019-07-12 Thread Lucas De Marchi
From: José Roberto de Souza TGL has 3 combophys and 6 TC/TBT ports, so it has 2 more TC/TBT ports than ICL and the PORT_C on TGL is a combophy. So here adding a new hpd north table and function to detect long pulse for TGL. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi

[Intel-gfx] [PATCH 03/22] drm/i915/tgl: update ddi/tc clock_off bits

2019-07-12 Thread Lucas De Marchi
From: Mahesh Kumar In GEN 12 PORT_C DDI clk_off bit is not equally distanced to A/B, it's at offset 24. Similarly TC port (5/6) clk off bits are at offset 22/23. Extend the macros to cover the additional ports. Cc: Matt Roper Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi

[Intel-gfx] [PATCH 22/22] drm/i915/mst: Do not hardcoded the crtcs that encoder can connect

2019-07-12 Thread Lucas De Marchi
(). Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 11/22] drm/i915/tgl: start adding the DKL PLLs to use on TC ports

2019-07-12 Thread Lucas De Marchi
The disable function can be the same as for MG phy since the same registers are used. The others are different as registers change - prepare for that using an empty dkl_pll_write() to be implemented later. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 98

[Intel-gfx] [PATCH 18/22] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-12 Thread Lucas De Marchi
to work. Although we are changing the gen11 table, those changes are supposed to be backward compatible since we are only touching previously undefined entries. Cc: Joonas Lahtinen Cc: Mika Kuoppala Cc: Daniele Ceraolo Spurio Signed-off-by: Tomasz Lis Signed-off-by: Lucas De Marchi --- drivers

[Intel-gfx] [PATCH 12/22] drm/i915/tgl: Add support for dkl pll write

2019-07-12 Thread Lucas De Marchi
From: Vandita Kulkarni Add a new function to write to dkl phy pll registers. As per the spec all the registers are read modify write. Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 65 ++- 1 file changed, 64

[Intel-gfx] [PATCH 00/22] Tiger Lake part 2

2019-07-12 Thread Lucas De Marchi
connect Lucas De Marchi (5): drm/i915/tgl: skip setting PORT_CL_DW12_* on initialization drm/i915/tgl: Add hpd interrupt handling drm/i915/tgl: handle DP aux interrupts drm/i915/tgl: re-indent code to prepare for DKL changes drm/i915/tgl: start adding the DKL PLLs to use on TC ports

[Intel-gfx] [PATCH 20/22] drm/i915: Move MOCS setup to intel_mocs.c

2019-07-12 Thread Lucas De Marchi
From: Tvrtko Ursulin Hide the details of MOCS setup from i915_gem by moving both current calls into one in intel_mocs_init. Cc: Stuart Summers Signed-off-by: Tvrtko Ursulin Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_mocs.c | 15 +++ drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 15/22] drm/i915/tgl: Introduce initial Tigerlake Workarounds

2019-07-12 Thread Lucas De Marchi
Ceraolo Spurio Signed-off-by: Michel Thierry Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_lrc.c | 2 ++ drivers/gpu/drm/i915/gt/intel_workarounds.c | 40 +++-- drivers/gpu/drm/i915/i915_reg.h | 3 ++ drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 08/22] drm/i915/tgl: Add DKL phy pll registers

2019-07-12 Thread Lucas De Marchi
From: Vandita Kulkarni These are the registers needed to program Dekel PHY. Some register definitions reuse the MG PHY definitions. Add a comment on those so we don't need to duplicate the functions for programming them. Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi

[Intel-gfx] [PATCH 14/22] drm/i915/tgl: allow the reg_read ioctl to read the RCS TIMESTAMP register

2019-07-12 Thread Lucas De Marchi
De Marchi --- drivers/gpu/drm/i915/intel_uncore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 475ab3d4d91d..2b839acfa0f6 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm

[Intel-gfx] [PATCH 04/22] drm/i915/tgl: Add hpd interrupt handling

2019-07-12 Thread Lucas De Marchi
Add hotdplug detection for all ports on TGP. icp_hpd_detection_setup() is refactored to be shared with TGP. While we increase the number of pins, add a BUILD_BUG_ON() to avoid going over the number of bits allowed. Cc: Jose Souza Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers

[Intel-gfx] [PATCH 19/22] drm/i915/tgl: Tigerlake only has global MOCS registers

2019-07-12 Thread Lucas De Marchi
part of the PPAT. Also cacheability control (1:0) field has changed, 00 no longer means 'use controls from page table', but uncacheable (UC). Cc: Daniele Ceraolo Spurio Cc: Tomasz Lis Signed-off-by: Michel Thierry Signed-off-by: Tvrtko Ursulin Signed-off-by: Lucas De Marchi --- drivers/gpu

[Intel-gfx] [PATCH 21/22] drm/i915/tgl: Add and use new DC5 and DC6 residency counter registers

2019-07-12 Thread Lucas De Marchi
From: José Roberto de Souza Tiger Lask has a new register offset for DC5 and DC6 residency counters. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_debugfs.c | 21 + drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files

[Intel-gfx] [PATCH 07/22] drm/i915/dmc: Load DMC on TGL

2019-07-12 Thread Lucas De Marchi
From: Anusha Srivatsa Add Support to load DMC v2.02 on TGL. Signed-off-by: Anusha Srivatsa Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_csr.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index

[Intel-gfx] [PATCH 17/22] drm/i915/tgl: Implement Wa_1406941453

2019-07-12 Thread Lucas De Marchi
From: Michel Thierry Enable Small PL for power benefit. Signed-off-by: Michel Thierry Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 13/22] drm/i915/gen12: add support for reading the timestamp frequency

2019-07-12 Thread Lucas De Marchi
From: Michel Thierry There are no changes with respect to GEN11, which Paulo wrote. This gets rid of the "Missing switch case in read_timestamp_frequency" message at boot for Tiger Lake. Cc: Paulo Zanoni Cc: Lionel Landwerlin Signed-off-by: Michel Thierry Signed-off-by: Lucas

[Intel-gfx] [PATCH v2 11/25] drm/i915/tgl: Add new pll ids

2019-07-08 Thread Lucas De Marchi
-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 23 +++ 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h b/drivers/gpu/drm/i915/display/intel_dpll_mgr.h index

[Intel-gfx] [PATCH v2 23/25] drm/i915/tgl: skip setting PORT_CL_DW12_* on initialization

2019-07-08 Thread Lucas De Marchi
According to the spec when initializing the display in TGL we should not set PORT_CL_DW12 for the Aux channel of the combo PHYs. We will re-use the power well hooks from ICL so just check for IS_TIGERLAKE() inside it. Cc: Imre Deak Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 06/25] x86/gpu: add TGL stolen memory support

2019-07-08 Thread Lucas De Marchi
From: Michel Thierry Reuse Gen11 stolen memory changes since Tiger Lake uses the same BSM register (and format). Cc: Rodrigo Vivi Signed-off-by: Michel Thierry Signed-off-by: Lucas De Marchi --- arch/x86/kernel/early-quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86

[Intel-gfx] [PATCH v2 09/25] drm/i915/tgl: Add power well support

2019-07-08 Thread Lucas De Marchi
-by: Imre Deak Signed-off-by: Lucas De Marchi --- .../drm/i915/display/intel_display_power.c| 480 +- .../drm/i915/display/intel_display_power.h| 26 +- drivers/gpu/drm/i915/i915_debugfs.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 18 + 4 files changed

[Intel-gfx] [PATCH v2 01/25] drm/i915: Add 4th pipe and transcoder

2019-07-08 Thread Lucas De Marchi
Add pipe D and transcoder D to prepare for platforms having them. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- drivers/gpu/drm/i915/display/intel_display.h | 4 drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH v2 03/25] drm/i915/tgl: Introduce Tiger Lake PCH

2019-07-08 Thread Lucas De Marchi
From: Radhakrishna Sripada Add the enum additions to TGP. Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: David Weinehall Cc: James Ausmus Signed-off-by: Radhakrishna Sripada Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_drv.c | 4 drivers/gpu/drm/i915/i915_drv.h | 3 +++ 2

[Intel-gfx] [PATCH v2 25/25] drm/i915/tgl: Update DPLL clock reference register

2019-07-08 Thread Lucas De Marchi
From: José Roberto de Souza This register definition changed from ICL and has now another meaning. Use the right bits on TGL. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 8 ++-- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH v2 05/25] drm/i915/tgl: Add TGL PCI IDs

2019-07-08 Thread Lucas De Marchi
Current list of PCI IDs for Tiger Lake. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_pci.c | 1 + include/drm/i915_pciids.h | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] [PATCH v2 16/25] drm/i915/tgl: port to ddc pin mapping

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar Create a helper function to get ddc pin according to port number. Cc: Anusha Srivatsa Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_hdmi.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff

[Intel-gfx] [PATCH v2 02/25] drm/i915/tgl: add initial Tiger Lake definitions

2019-07-08 Thread Lucas De Marchi
: Joonas Lahtinen Cc: Rodrigo Vivi Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_pci.c | 29 drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 08/25] drm/i915/tgl: use TRANSCODER_EDP_VDSC on transcoder A

2019-07-08 Thread Lucas De Marchi
n) Cc: Imre Deak Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_vdsc.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c

[Intel-gfx] [PATCH v2 19/25] drm/i915/tgl: init ddi port A-C for Tiger Lake

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar This patch initializes DDI PORT A, B & C for Tiger lake. Other TC ports need to be initialized later once corresponding code is there. Cc: Madhav Chauhan Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH v2 04/25] drm/i915/tgl: Add TGL PCH detection in virtualized environment

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar Assume PCH_TGP when platform is TGL. Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi Reviewed-by: Anusha Srivatsa --- drivers/gpu/drm/i915/i915_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 18/25] drm/i915/tgl: extend intel_port_is_combophy/tc

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar TGL has 3 combophy ports, so extend check for tigerlake in intel_port_is_combophy/tc function. Cc: Mika Kahola Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c | 12 +--- 1 file changed, 9 insertions(+), 3

[Intel-gfx] [PATCH v2 21/25] drm/i915/tgl: apply Display WA #1178 to fix type C dongles

2019-07-08 Thread Lucas De Marchi
Add port C to workaround to cover Tiger Lake. Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display_power.c | 11 --- drivers/gpu/drm/i915/i915_reg.h| 4 +++- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH v2 12/25] drm/i915/tgl: Add pll manager

2019-07-08 Thread Lucas De Marchi
From: Vandita Kulkarni Add a new pll array for Tiger Lake. The TC pll functions for type C will be covered in later patches after its phy is implemented. Cc: Madhav Chauhan Cc: Rodrigo Vivi Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v2 20/25] drm/i915/tgl: Add vbt value mapping for DDC Bus pin

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar Add VBT-value to DDC bus pin mapping for the same. Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_bios.c | 17 - drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +++ 2 files changed, 19 insertions

[Intel-gfx] [PATCH v2 17/25] drm/i915/tgl: select correct bit for port select

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar Bit definitions for port-select got changed for TRANS_CLK_SEL & TRANS_DDI_FUNC_CTL registers in TGL. Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_ddi.c | 48 +++- drivers/gpu/drm/i915/i915_r

[Intel-gfx] [PATCH v2 22/25] drm/i915/gen12: MBUS B credit change

2019-07-08 Thread Lucas De Marchi
-off-by: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 9ccf58ff4dba

[Intel-gfx] [PATCH v2 15/25] drm/i915/tgl: Add gmbus gpio pin to port mapping

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar Add default GPIO pin mapping for all ports. Tiger Lake has 3 combophy ports and 6 TC ports, gpio pin1-3 are mapped to combophy & pin9-14 are mapped to TC ports. Cc: Anusha Srivatsa Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- dri

[Intel-gfx] [PATCH v2 13/25] drm/i915/tgl: Add additional ports for Tiger Lake

2019-07-08 Thread Lucas De Marchi
. v2: Rebase on new modular FIA code (Lucas) Cc: Anusha Srivatsa Signed-off-by: Vandita Kulkarni Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_ddi.c | 12 drivers/gpu/drm/i915/display/intel_display.h | 2 ++ include/drm/i915_component.h

[Intel-gfx] [PATCH v2 24/25] drm/i915/tgl: Add DPLL registers

2019-07-08 Thread Lucas De Marchi
On TGL the port programming for combophy is very similar to ICL, so adapt the callers to possibly use the different register values. Cc: Vandita Kulkarni Cc: Rodrigo Vivi Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 24 +++ drivers/gpu/drm

[Intel-gfx] [PATCH v2 07/25] drm/i915/tgl: Check if pipe D is fused

2019-07-08 Thread Lucas De Marchi
From: José Roberto de Souza On Tiger Lake there is one more pipe - check if it's fused. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_device_info.c | 3 +++ 2 files changed, 4 insertions

[Intel-gfx] [PATCH v2 14/25] drm/i915/tgl: update ddi/tc clock_off bits

2019-07-08 Thread Lucas De Marchi
From: Mahesh Kumar In GEN 12 PORT_C DDI clk_off bit is not equally distanced to A/B, it's at offset 24. Similarly TC port (5/6) clk off bits are at offset 22/23. Extend the macros to cover the additional ports. Signed-off-by: Mahesh Kumar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm

[Intel-gfx] [PATCH v2 00/25] Initial support for Tiger Lake

2019-07-08 Thread Lucas De Marchi
clock reference register Lucas De Marchi (5): drm/i915: Add 4th pipe and transcoder drm/i915/tgl: Add TGL PCI IDs drm/i915/tgl: apply Display WA #1178 to fix type C dongles drm/i915/tgl: skip setting PORT_CL_DW12_* on initialization drm/i915/tgl: Add DPLL registers Mahesh Kumar (8): drm

[Intel-gfx] [PATCH v2 10/25] drm/i915/tgl: Add power well to support 4th pipe

2019-07-08 Thread Lucas De Marchi
From: Mika Kahola Add power well 5 to support 4th pipe and transcoder on TGL. Cc: James Ausmus Cc: Imre Deak Signed-off-by: Mika Kahola Signed-off-by: Lucas De Marchi --- .../drm/i915/display/intel_display_power.c| 30 --- .../drm/i915/display/intel_display_power.h

[Intel-gfx] [PATCH v3 2/4] drm/i915: fix include order in intel_tc.*

2019-07-09 Thread Lucas De Marchi
Separate local includes with a blank line and sort the groups alphabetically. v2: don't make intel_tc.h be the first include v3: don't make local includes be included first Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_tc.c | 2 +- drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH v2 24/25] drm/i915/tgl: Add DPLL registers

2019-07-09 Thread Lucas De Marchi
On Tue, Jul 09, 2019 at 03:56:51PM +0300, Ville Syrjälä wrote: On Mon, Jul 08, 2019 at 04:16:28PM -0700, Lucas De Marchi wrote: On TGL the port programming for combophy is very similar to ICL, so adapt the callers to possibly use the different register values. Cc: Vandita Kulkarni Cc: Rodrigo

<    1   2   3   4   5   6   7   8   9   10   >