Re: [Intel-gfx] [PATCH] Revert "drm/i915: Make prepare_plane_fb fully interruptible."

Op 17-11-15 om 18:44 schreef Daniel Vetter: > On Mon, Nov 02, 2015 at 05:38:07PM +0200, Ville Syrjälä wrote: >> On Mon, Nov 02, 2015 at 01:41:03PM +0100, Maarten Lankhorst wrote: >>> Hey, >>> >>> Op 30-10-15 om 22:06 schreef ville.syrj...@linux.intel.com:

[Intel-gfx] [PATCH 10/12] drm/i915: Nuke fbc members from intel_crtc->atomic.

This leaves intel_crtc->atomic empty, so zap it as well. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 87 ++-- drivers/gpu/drm/i915/intel_drv.h | 16 --- 2 files changed, 33 i

[Intel-gfx] [PATCH 07/12] drm/i915: Remove atomic.pre_disable_primary.

This can be derived from the atomic state in pre_plane_update, which makes it more clear when it's supposed to be called. Reviewed-by: Ander Conselvan de Oliveira <conselv...@gmail.com> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 08/12] drm/i915: Remove update_sprite_watermarks.

Commit 791a32be6eb2 ("drm/i915: Drop intel_update_sprite_watermarks") removes the use of this variable, but forgot to remove it. Reviewed-by: Matt Roper <matthew.d.ro...@intel.com> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 04/12] drm/i915: Remove double wait_for_vblank on broadwell.

wait_vblank is already set in intel_plane_atomic_calc_changes for broadwell, waiting for a double vblank is overkill. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 8 1 file changed, 8 deletions(-) diff --git a/d

[Intel-gfx] [PATCH 00/12] Remove intel_crtc->atomic and fix BAT!

H 0/8] Make plane updates use the atomic state. Maarten Lankhorst (12): drm/i915: Move disable_cxsr to the crtc_state. drm/i915: Calculate watermark related members in the crtc_state, v3. drm/i915/skl: Update watermarks before the crtc is disabled. drm/i915: Remove double wait_for_vbl

[Intel-gfx] [PATCH 02/12] drm/i915: Calculate watermark related members in the crtc_state, v3.

This removes pre/post_wm_update from intel_crtc->atomic, and creates atomic state for it in intel_crtc. Changes since v1: - Rebase on top of wm changes. Changes since v2: - Split disable_cxsr into a separate patch. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> ---

[Intel-gfx] [PATCH 01/12] drm/i915: Move disable_cxsr to the crtc_state.

intel_crtc->atomic will be removed later on, move this member to intel_crtc_state. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_display.c | 12 +++- drivers/gpu/drm/i915/in

[Intel-gfx] [PATCH 03/12] drm/i915/skl: Update watermarks before the crtc is disabled.

: https://bugs.freedesktop.org/show_bug.cgi?id=92181 Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Cc: sta...@vger.kernel.org Cc: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[Intel-gfx] [PATCH 09/12] drm/i915: Remove some post-commit members from intel_crtc->atomic, v2.

wording, remove comment about loop. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_display.c | 29 - drivers/gpu/drm/i915/intel_drv.h | 3 +-- 3 files chang

[Intel-gfx] [PATCH 12/12] drm/i915: Calculate visibility in check_plane correctly regardless of dpms.

off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_atomic_plane.c | 4 ++-- drivers/gpu/drm/i915/intel_display.c | 9 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu

[Intel-gfx] [PATCH 05/12] drm/i915: Kill off intel_crtc->atomic.wait_vblank, v2.

on. The broadwell vblank workaround may look gone entirely but this is not the case. pipe_config->wm_changed is set to true when any plane is turned on, which forces a vblank wait. Changes since v1: - Removing the double vblank wait on broadwell moved to its own commit. Signed-off-by: Maarten Lankho

[Intel-gfx] [PATCH 11/12] drm/i915: Keep track of the cdclk as if all crtc's were active.

ere active. This is required to get the same calculations done correctly regardless of dpms mode. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_display.c | 55

[Intel-gfx] [PATCH 06/12] drm/i915: Remove intel_crtc->atomic.disable_ips.

This is a revert of commit 066cf55b9ce3 "drm/i915: Fix IPS related flicker". intel_pre_disable_primary already handles this, and now everything goes through the atomic path there's no need to try to disable ips twice. Signed-off-by: Maarten Lankhorst <maarten.lankho...@li

[Intel-gfx] [PATCH v2] drm/i915: Do a better job at disabling primary plane in the noatomic case.

Op 13-11-15 om 14:28 schreef Ander Conselvan De Oliveira: > On Thu, 2015-11-12 at 14:58 +0100, Maarten Lankhorst wrote: >> Op 12-11-15 om 14:37 schreef Ander Conselvan De Oliveira: >>> On Wed, 2015-11-11 at 15:36 +0100, Maarten Lankhorst wrote: >>>> When disable

Re: [Intel-gfx] [RFC 01/12] staging/android/sync: Support sync points created from dma-fences

bout this. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: de...@driverdev.osuosl.org > Cc: Riley Andrews <riandr...@android.com> > Cc: Greg Kroah-Hartman <gre...@linuxfou

Re: [Intel-gfx] [RFC 02/12] staging/android/sync: add sync_fence_create_dma

Op 23-11-15 om 12:34 schreef john.c.harri...@intel.com: > From: Maarten Lankhorst <maarten.lankho...@canonical.com> > > This allows users of dma fences to create a android fence. > > v2: Added kerneldoc. (Tvrtko Ursulin). > > Signed-off-by: Maarten Lankhorst <m

Re: [Intel-gfx] [RFC 02/12] staging/android/sync: add sync_fence_create_dma

Op 23-11-15 om 14:44 schreef Tvrtko Ursulin: > > On 23/11/15 13:38, John Harrison wrote: >> On 23/11/2015 13:27, Maarten Lankhorst wrote: >>> Op 23-11-15 om 12:34 schreef john.c.harri...@intel.com: >>>> From: Maarten Lankhorst <maarten.lankho...@canonical.com

[Intel-gfx] [PATCH 4/4] drm/i915/bxt: Use the bypass frequency if there are no active pipes.

Now that pixel clock is set to 0 when there are no active pipes it's easy to set the bypass frequency for this case. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[Intel-gfx] [PATCH 2/4] drm/i915: Handle cdclk limits on broadwell.

As the comment indicates this can only fail gracefully when called from compute_config. Fortunately this is now what's happening, so the fixme can be removed and the DRM_ERROR downgraded. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/dr

[Intel-gfx] [PATCH 3/4] drm/i915: Do not acquire crtc state to check clock during modeset, v3.

elated to max_pixel_rate calculations more readable. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 5 ++ drivers/gpu/drm/i915/intel_atomic.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 139 +-- drivers/

[Intel-gfx] [PATCH 1/4] drm/i915/skl: Do not allow scaling when crtc is disabled.

. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 764eeb05492d..351ecb69e5eb

[Intel-gfx] [PATCH 1/2] drm/i915: Use a crtc mask instead of a active refcount for dpll functions.

This makes it easier to verify correct dpll setup with only a single crtc. It it also useful to detect double dpll enable/disable. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 2/2] drm/i915: Perform dpll commit first.

Warn for the wrong mask in enable only. Disable will have the wrong mask now because the new state is committed before disabling the old state. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 10 +++--- 1 file chan

[Intel-gfx] [PATCH 0/4] cdclk fixes

the state without locking other crtc's. This will allow modesets on newer platforms without locking all planes and crtc's. The final patch is a small removal of a FIXME for broxton. Hopefully useful to have. Maarten Lankhorst (4): drm/i915/skl: Do not allow scaling when crtc is disabled. drm/i915

[Intel-gfx] [PATCH 3/9] drm/core: Add drm_encoder_index.

This is useful for adding encoder_mask in crtc_state. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/drm_crtc.c | 23 +++ include/drm/drm_crtc.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/drm_cr

[Intel-gfx] [PATCH 4/9] drm/core: Add drm_for_each_encoder_mask.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- include/drm/drm_crtc.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 29cfb4f8f99d..c54da2d297ec 100644 --- a/include/drm/drm_crtc.h +++ b/inclu

[Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/tegra/dsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index f0a138ef68ce..6b8ae3d08eeb 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 1/9] drm/i915: Set connector_state->connector correctly.

I can't believe we didn't trip over this sooner.. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 6/9] drm/i915: Update connector_mask during readout.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index dcc7ec

[Intel-gfx] [PATCH 0/9] drm/atomic: Add encoder_mask and connector_mask to crtc_state.

ons over connectors and encoders with just the crtc_state. The drm/tegra patch is compile tested only. Maarten Lankhorst (9): drm/i915: Set connector_state->connector correctly. drm/tegra: Assign conn_state->connector when allocating connector state. drm/core: Add drm_encoder_ind

[Intel-gfx] [PATCH 9/9] drm/atomic: Add encoder_mask to crtc_state.

This allows iteration over encoders without requiring connection_mutex. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 4 drivers/gpu/drm/i915/intel_display.c | 3 +++ include/drm/drm_crtc.h | 2 ++ 3

[Intel-gfx] [PATCH 8/9] drm/atomic: Remove drm_atomic_connectors_for_crtc.

Now that connector_mask is reliable there's no need for this function any more. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/drm_atomic.c| 29 - drivers/gpu/drm/drm_atomic_helper.c | 9 ++--- drivers/gpu/d

[Intel-gfx] [PATCH 7/9] drm/atomic: Small documentation fix.

Use the correct function name for drm_atomic_clean_old_fb docs. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/drm_atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_at

[Intel-gfx] [PATCH 5/9] drm/atomic: add connector mask to drm_crtc_state.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/drm_atomic.c | 11 +++ include/drm/drm_crtc.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index d8cc23

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Calculate watermark related members in the crtc_state, v3.

Op 24-11-15 om 15:03 schreef Ander Conselvan De Oliveira: > On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote: >> This removes pre/post_wm_update from intel_crtc->atomic, and >> creates atomic state for it in intel_crtc. >> >> Changes since v1: >> - Reb

Re: [Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

Op 24-11-15 om 11:51 schreef Thierry Reding: > On Tue, Nov 24, 2015 at 11:37:47AM +0100, Daniel Vetter wrote: >> On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote: >>> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> >>> --- >

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Update connector_mask during readout.

Op 24-11-15 om 11:38 schreef Daniel Vetter: > On Tue, Nov 24, 2015 at 10:34:33AM +0100, Maarten Lankhorst wrote: >> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> >> --- >> drivers/gpu/drm/i915/intel_display.c | 11 --- >> 1 file chan

[Intel-gfx] [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset.

This is useful for drivers that subclass connector_state, like tegra. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 30 ++ include/drm/drm_atomic_helper.h | 2 ++ 2 files changed, 28 inse

[Intel-gfx] [PATCH 1/3] drm/i915: Set connector_state->connector using the helper.

The atomic helper sets connector_state->connector, which the i915 code didn't. This will become a problem when we start using it. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/intel_display.c | 6 ++ 1 file changed, 2 insertions(+), 4

[Intel-gfx] [PATCH 3/3] drm/tegra: Use __drm_atomic_helper_reset_connector for subclassing connector state.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/tegra/dsi.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index f0a138ef68ce..33ad50487f2e 100644 --- a/drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: Handle error paths during watermark sanitization properly (v2)

ake sure any EDEADLK's are handled > earlier. > This patch still doesn't handle failure from intel_atomic_check and lock_all_ctx correctly. If you fix that you can add: Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> ___ Inte

Re: [Intel-gfx] [PATCH] drm/i915: Assign crtc correctly in load detection.

Op 12-01-16 om 13:34 schreef Daniel Vetter: > On Tue, Jan 12, 2016 at 12:35:59PM +0100, Maarten Lankhorst wrote: >> drm_atomic_set_crtc_for_connector should be used, >> and crtc->primary->crtc is assigned by atomic_commit. >> >> Rely on the helpers for setting thi

[Intel-gfx] [PATCH] drm/i915: Assign crtc correctly in load detection.

drm_atomic_set_crtc_for_connector should be used, and crtc->primary->crtc is assigned by atomic_commit. Rely on the helpers for setting this correctly, so connector_mask gets updated too. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- Should this be applied

Re: [Intel-gfx] [PATCH 07/13] drm/i915: Introduce dedicated object VMA iterator

Op 12-01-16 om 17:19 schreef Daniel Vetter: > On Mon, Jan 11, 2016 at 09:51:38AM +, Tvrtko Ursulin wrote: >> On 11/01/16 08:43, Daniel Vetter wrote: >>> On Fri, Jan 08, 2016 at 01:29:14PM +, Tvrtko Ursulin wrote: On 08/01/16 11:29, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin

[Intel-gfx] [PATCH] drm/i915: Force vblanks around evasion when i915.watermark_test is set.

This will make it more likely that intermediary watermarks cause fifo underruns, which is useful when writing watermark specific tests, to make it more likely to trigger FIFO underruns in intermediary watermarks. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- d

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/kms_chv_cursor_fail: Run the tests with fewer steps.

Op 08-06-16 om 15:12 schreef Ville Syrjälä: > On Wed, Jun 08, 2016 at 01:25:32PM +0200, Maarten Lankhorst wrote: >> This reduces the runtime of the tests from ~200s on my 30 fps 4k panel >> to 10s. > Does it still find the problem reliably on CHV pipe C (if you remove the &

[Intel-gfx] [PATCH v2] drm/core: Change declaration for gamma_set.

gt; Cc: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> Cc: Ben Skeggs <bske...@redhat.com> Cc: Eric Anholt <e...@anholt.net> Cc: VMware Graphics <linux-graphics-maintai...@vmware.com> Cc: Mathieu Larouche <mathieu.larou...@matrox.com> Cc: Thierry Reding <tred...@nvi

Re: [Intel-gfx] [PATCH v9 1/6] drm/i915: Add per context timelines for fence objects

in patch series so no longer needs to remove the > quick hack timeline that was being added before. > > v9: Updated to another newer nightly (changes to context structure > naming). Also updated commit message to match previous changes. > > For: VIZ-5190 > Signed-off-by: John Harrison

[Intel-gfx] [PATCH] drm/core: Change declaration for gamma_set.

: Thierry Reding <tred...@nvidia.com> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 10 ++ drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 10 ++ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 10 ++ driv

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_chv_cursor_fail: Remove extra igt_pipe_crc_start.

<ville.syrj...@linux.intel.com> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- tests/kms_chv_cursor_fail.c | 3 - tests/kms_rmfb.c| 180 2 files changed, 180 insertions(+), 3 deletions(-) create mode 100644 test

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_chv_cursor_fail: Run the tests with fewer steps.

This reduces the runtime of the tests from ~200s on my 30 fps 4k panel to 10s. Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- tests/kms_chv_cursor_fail.c | 18 +++--- 1 file changed, 11 inse

Re: [Intel-gfx] [PATCH v9 3/6] drm/i915: Removed now redundant parameter to i915_gem_request_completed()

the interface. > > v6: Updated to newer nightly and resolved conflicts. > > v7: Updated to newer nightly (lots of ring -> engine renaming). > > For: VIZ-5190 > Signed-off-by: John Harrison <john.c.harri...@intel.com> > Cc: Maarten Lankhorst <maarten.lankho...@linux.inte

Re: [Intel-gfx] [PATCH v9 6/6] drm/i915: Cache last IRQ seqno to reduce IRQ overhead

Op 01-06-16 om 19:07 schreef john.c.harri...@intel.com: > From: John Harrison > > The notify function can be called many times without the seqno > changing. Some are to prevent races due to the requirement of not > enabling interrupts until requested. However, when

Re: [Intel-gfx] [PATCH v9 5/6] drm/i915: Updated request structure tracing

otify function itself. > > v3: Added the current ring seqno to the notify trace point. > > v5: Line wrapping to keep the style checker happy. > > v7: Updated to newer nightly (lots of ring -> engine renaming). > > For: VIZ-5190 > Signed-off-by: John Harrison <john

Re: [Intel-gfx] [PATCH v9 2/6] drm/i915: Convert requests to use struct fence

Rebased to newer nightly - no longer needs to worry about mutex >> locking in the request free code path. Moved to after fence timeline >> patch so no longer needs to add a horrid hack timeline. >> >> Removed commented out code block. Added support for possible RCU usage >

Re: [Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

n >> interface change on get_seqno(). Also added a list_empty() check >> before acquring spinlocks and doing list processing. >> >> v8: Updated to newer nightly - changes to request clean up code mean >> non of the deferred free mess is nee

Re: [Intel-gfx] ✓ Ro.CI.BAT: success for drm/atomic: Provide default ->best_encoder() behavior (rev2)

Op 07-06-16 om 14:03 schreef Patchwork: > == Series Details == > > Series: drm/atomic: Provide default ->best_encoder() behavior (rev2) > URL : https://patchwork.freedesktop.org/series/8164/ > State : success > > == Summary == > > Series 8164v2 drm/atomic: Provide default ->best_encoder()

Re: [Intel-gfx] [PATCH] drm/core: Change declaration for gamma_set.

Op 06-06-16 om 18:17 schreef Emil Velikov: > Hi Maarten, > > On 6 June 2016 at 10:18, Maarten Lankhorst > <maarten.lankho...@linux.intel.com> wrote: > >> --- a/drivers/gpu/drm/drm_fb_helper.c >> +++ b/drivers/gpu/drm/drm_fb_helper.c >> @@ -1076,8 +1076,6

Re: [Intel-gfx] [PATCH] drm/core: Change declaration for gamma_set.

Op 06-06-16 om 18:11 schreef Emil Velikov: > On 6 June 2016 at 17:00, Daniel Vetter <dan...@ffwll.ch> wrote: >> On Mon, Jun 06, 2016 at 11:18:09AM +0200, Maarten Lankhorst wrote: >>> Change return value to int to propagate errors from gamma_set, >>> and remove st

Re: [Intel-gfx] [PATCH] drm/core: Change declaration for gamma_set.

Op 06-06-16 om 18:25 schreef Emil Velikov: > On 6 June 2016 at 17:15, Maarten Lankhorst > <maarten.lankho...@linux.intel.com> wrote: >> Op 06-06-16 om 18:11 schreef Emil Velikov: >>> On 6 June 2016 at 17:00, Daniel Vetter <dan...@ffwll.ch> wrote: >>>

Re: [Intel-gfx] [PATCH] drm/i915: Revert async unpin and nonblocking atomic commit

sages. Especially when > doing more than one thing, and especially when touching critical and > tricky core code. > > - Building a patch series and r-b stamping it when it has a built-in > bisect breakage is not a good idea. > > - I also think we need to stop building up techni

Re: [Intel-gfx] [PATCH v2 18/21] drm/i915: Make unpin async.

Op 24-05-16 om 16:00 schreef Daniel Vetter: > On Tue, May 17, 2016 at 03:08:01PM +0200, Maarten Lankhorst wrote: >> All of intel_post_plane_update is handled there now, so move it over. >> This is run after the hw state checker because it can't handle checking >>

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gen9: Initialize intel_state->active_crtcs during WM sanitization

Op 10-06-16 om 00:14 schreef Matt Roper: > intel_state->active_crtcs is usually only initialized when doing a > modeset. During our first atomic commit after boot, we're effectively > faking a modeset to sanitize the DDB/wm setup, so ensure that this field > gets initialized before use. > >

Re: [Intel-gfx] [PATCH v9 2/6] drm/i915: Convert requests to use struct fence

Op 10-06-16 om 13:26 schreef John Harrison: > On 07/06/2016 12:42, Maarten Lankhorst wrote: >> Op 02-06-16 om 13:07 schreef Tvrtko Ursulin: >>> On 01/06/16 18:07, john.c.harri...@intel.com wrote: >>>> From: John Harrison <john.c.harri...@intel.com> >>

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gen9: Initialize intel_state->active_crtcs during WM sanitization

Op 13-06-16 om 10:59 schreef Maarten Lankhorst: > Op 10-06-16 om 00:14 schreef Matt Roper: >> intel_state->active_crtcs is usually only initialized when doing a >> modeset. During our first atomic commit after boot, we're effectively >> faking a modeset to sanitize the

[Intel-gfx] [PATCH i-g-t] kms_universal_plane: Add testcase for when no plane is visible on the crtc.

the cursor altogether. This triggers a WARN_ON in the kernel: WARN_ON(cstate->plane_mask && total_data_rate == 0); Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c index b06b51e6934c..30

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gen9: Compute data rates for all planes on first commit

d-off-by: Matt Roper <matthew.d.ro...@intel.com> Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gen9: Drop invalid WARN() during data rate calculation

triggers this warn? Something for kms_universal_planes perhaps? Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Testcase: kms_universal_planes.cursor-only-pipe-* (will reply here as a patch) ___ Intel-gfx mailing list Intel-gfx@lists.freedeskt

Re: [Intel-gfx] [PATCH v3] drm/i915/opregion: update cadl based on actually active outputs

Op 13-06-16 om 12:00 schreef Jani Nikula: > Previously we've just shoved the first eight devices in DIDL to CADL > (list of active outputs). Some of the active outputs may have been left > outside of CADL. The problem is, some BIOS implementations prevent > laptop brightness hotkey propagation if

Re: [Intel-gfx] [PATCH 3/5] drm/i915: nonblocking commit

pdate FIXME for intel_atomic_commit - more stuff works now. > > v5: Still reject nonblocking modeset commits (Maarten). > > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> if (intel_

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Signal drm events for atomic

Op 13-06-16 om 16:13 schreef Daniel Vetter: > This is part of what atomic must implement. And it's also required > to be able to use the helper nonblocking support. > > v2: Always send out the drm event, remove the planes_changed check. Hey, There used to be a patch to add a test in kms_atomic

Re: [Intel-gfx] [PATCH] drm/i915: Force vblanks around evasion when i915.watermark_test is set.

Op 13-06-16 om 16:45 schreef Daniel Vetter: > On Thu, Jun 09, 2016 at 01:36:50PM +0200, Maarten Lankhorst wrote: >> This will make it more likely that intermediary watermarks cause fifo >> underruns, which is useful when writing watermark specific tests, >> to make it more l

[Intel-gfx] [PATCH 2.5/5] Reapply "drm/i915: Pass atomic states to fbc update, functions."

in as pointers. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1463490484-19540-17-git-send-email-maarten.lankho...@linux.intel.com Reviewed-by: Patrik Jakobsson <patrik.jakobs...@linux.intel.com> --- drivers/

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/kms_chv_cursor_fail: Run the tests with fewer steps.

Op 08-06-16 om 16:52 schreef Ville Syrjälä: > On Wed, Jun 08, 2016 at 04:47:48PM +0200, Maarten Lankhorst wrote: >> Op 08-06-16 om 15:35 schreef Ville Syrjälä: >>> On Wed, Jun 08, 2016 at 03:23:33PM +0200, Maarten Lankhorst wrote: >>>> Op 08-06-16 om 15:12 schreef Vi

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_rmfb: Use for_each_pipe_with_valid_output.

Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- tests/kms_rmfb.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c index a3fde9f43788..89aa323210dd 100644 --- a/tests/kms_rmfb.c +++ b/tests/kms_

[Intel-gfx] [PATCH i-g-t 1/2] lib/igt_kms: Add for_each_pipe_with_valid_output and for_each_valid_output_on_pipe.

ted_output() /* Run subtest */ } The former should be replaced with for_each_valid_output_on_pipe, the latter with for_each_pipe_with_valid_output. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- lib/igt_kms.c | 29 - li

Re: [Intel-gfx] [isg-gms] [RFC 3/6] drm/i915/vlv: Move fifo_size from intel_plane_wm_parameters to vlv_wm_state

Op 14-06-16 om 23:52 schreef Matt Roper: > On Wed, Jun 08, 2016 at 05:22:41PM +0200, Chi Ding wrote: >> From: Maarten Lankhorst <maarten.lankho...@linux.intel.com> >> >> This commit saves watermark for each plane in vlv_wm_state to prepare >> for two-level waterma

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Use atomic commits for legacy page_flips

> .atomic_destroy_state = intel_crtc_destroy_state, > }; Change this to __maybe_unused and you have my Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> for the whole series. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/kms_chv_cursor_fail: Run the tests with fewer steps.

Op 08-06-16 om 15:35 schreef Ville Syrjälä: > On Wed, Jun 08, 2016 at 03:23:33PM +0200, Maarten Lankhorst wrote: >> Op 08-06-16 om 15:12 schreef Ville Syrjälä: >>> On Wed, Jun 08, 2016 at 01:25:32PM +0200, Maarten Lankhorst wrote: >>>> This reduces the runtime of the

Re: [Intel-gfx] [PATCH 15/26] drm/arc: Implement nonblocking commit correctly

Op 29-05-16 om 20:35 schreef Daniel Vetter: > Committing with block it is not. > > Thanks to the fixed up vblank event handling we can just use the > helper support for nonblocking commits now. > > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc:

[Intel-gfx] [PATCH v2 4/9] drm/i915: Rework intel_crtc_page_flip to be almost atomic, v5.

since v3: - Update for legacy cursor work. - null pointer to request_unreference is no longer allowed. Changes since v4: - Only call trace_i915_flip_request once. (Ville) Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 36 +- d

[Intel-gfx] [PATCH 5/9] drm/i915: Remove cs based page flip support, v3.

With mmio flips now available on all platforms it's time to remove support for cs flips. Changes since v1: - Rebase for legacy cursor updates. Changes since v2: - Silence remainder of cs page flip handler. Signed-off-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> --- drivers/g

Re: [Intel-gfx] [PATCH] mutex: Report recursive ww_mutex locking early

ever release the lock, we spin until > kicked, whereupon the deadlock is discovered and reported. > > A simple solution for the now common problem is to move the recursive > deadlock discovery to the first action when taking the ww_mutex. > > Testcase: igt/kms_cursor_legacy >

Re: [Intel-gfx] [PATCH] mutex: Report recursive ww_mutex locking early

Op 30-05-16 om 11:11 schreef Peter Zijlstra: > On Mon, May 30, 2016 at 09:43:53AM +0200, Maarten Lankhorst wrote: >> Op 26-05-16 om 22:08 schreef Chris Wilson: >>> Recursive locking for ww_mutexes was originally conceived as an >>> exception. However, it is hea

Re: [Intel-gfx] [PATCH 06/26] drm/atomic: Add __drm_atomic_get_current_plane_state

Op 29-05-16 om 20:35 schreef Daniel Vetter: > ... and use it in msm Again just want to encapsulate > drm_atomic_state internals a bit. > > The const threading is a bit awkward in vc4 since C sucks, but I still > think it's worth to enforce this. Eventually I want to make all the > obj->state

Re: [Intel-gfx] [PATCH] mutex: Report recursive ww_mutex locking early

Op 30-05-16 om 12:45 schreef Chris Wilson: > On Mon, May 30, 2016 at 12:27:46PM +0200, Peter Zijlstra wrote: >> On Mon, May 30, 2016 at 11:43:31AM +0200, Maarten Lankhorst wrote: >>> Patch not applied, SCHED_RR: >> ww_mutex isn't RT aware at all; its one of the things I

Re: [Intel-gfx] [PATCH 04/26] drm/rcar-du: Use for_each_*_in_state

Op 30-05-16 om 11:18 schreef Laurent Pinchart: > Hi Daniel, > > Thank you for the patch. > > This looks good to me as the resulting code is mostly similar. However, the > for_each_*_in_state macros end with an for_each_if() that tests if the > object's state is NULL, which isn't present in this

Re: [Intel-gfx] [PATCH 15/26] drm/arc: Implement nonblocking commit correctly

Op 30-05-16 om 11:24 schreef Daniel Vetter: > On Mon, May 30, 2016 at 10:15:14AM +0200, Maarten Lankhorst wrote: >> Op 29-05-16 om 20:35 schreef Daniel Vetter: >>> Committing with block it is not. >>> >>> Thanks to the fixed up vblank event handling we

Re: [Intel-gfx] [PATCH 01/26] drm/atomic-helper: use for_each_*_in_state more

Op 29-05-16 om 20:34 schreef Daniel Vetter: > This avois leaking drm_atomic_state internals into the helpers. The > only place where this still happens after this patch is > drm_atomic_helper_swap_state(). > It's unavoidable there, and maybe a good indicator we should actually > move that

Re: [Intel-gfx] [PATCH 02/26] drm/i915: Use drm_atomic_get_existing_plane_state

Op 29-05-16 om 20:34 schreef Daniel Vetter: > We want to encapsulate the drm_atomic_state internals. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/intel_atomic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 12/26] drm/atomic-helper: Massage swap_state signature somewhat

Op 29-05-16 om 20:35 schreef Daniel Vetter: > - dev is redundant, we have state->atomic > - add stall parameter, which must be set when swapping needs to stall > for preceeding commits to stop looking at ->state pointers. Currently > all drivers need this to be, just prep work for a glorious

Re: [Intel-gfx] [PATCH 06/26] drm/atomic: Add __drm_atomic_get_current_plane_state

Op 30-05-16 om 17:05 schreef Daniel Vetter: > On Mon, May 30, 2016 at 01:42:40PM +0200, Maarten Lankhorst wrote: >> Op 29-05-16 om 20:35 schreef Daniel Vetter: >>> ... and use it in msm Again just want to encapsulate >>> drm_atomic_state internals a bit. >>&

Re: [Intel-gfx] [PATCH 12/26] drm/atomic-helper: Massage swap_state signature somewhat

Op 30-05-16 om 17:09 schreef Daniel Vetter: > On Mon, May 30, 2016 at 03:08:39PM +0200, Maarten Lankhorst wrote: >> Op 29-05-16 om 20:35 schreef Daniel Vetter: >>> - dev is redundant, we have state->atomic >>> - add stall parameter, which must be se

Re: [Intel-gfx] [PATCH 01/38] drm/atomic-helper: use for_each_*_in_state more

ually > move that function into drm_atomic.c. > > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists

Re: [Intel-gfx] [PATCH 02/38] drm/i915: Use drm_atomic_get_existing_plane_state

drm_atomic_get_existing_plane_state(drm_state, > + plane)); > scaler_id = _state->scaler_id; > } > intel_plane_get_atomic_state(drm_state, intel_pla

Re: [Intel-gfx] [PATCH 11/38] drm: Consolidate crtc arrays in drm_atomic_state

use this to store a pointer to the preceeding > state, making an atomic update entirely free-standing. This will be > needed to be able to queue them up with a depth > 1. Patch 9,10,11: Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>

Re: [Intel-gfx] [PATCH] drm/atomic: Add __drm_atomic_get_current_plane_state

he > obj->state pointers const too, but that's a lot more work ... > > v2: Provide safe macro to wrap up the unsafe helper better, suggested > by Maarten. Much better, thanks! Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>

Re: [Intel-gfx] [PATCH 05/38] drm/vc4: Use for_each_plane_in_state

Op 02-06-16 om 00:06 schreef Daniel Vetter: > We want to hide drm_atomic_stat internals a bit better. > > Cc: Eric Anholt <e...@anholt.net> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Reviewed-by: Maarten Lankhorst <maarte

Re: [Intel-gfx] [PATCH 07/38] drm/exynos: Use for_each_crtc_in_state

;crtcs[i]); > - } > + for_each_crtc_in_state(state, crtc, crtc_state, i) > + commit->crtcs |= 1 << drm_crtc_index(crtc); > > wait_event(priv->wait, !commit_is_pending(priv, commit->crtcs)); > Reviewed-by: Maarten Lankhorst <maarten.lankho...

<    4   5   6   7   8   9   10   11   12   13   >