("drm/i915/execlists: Inhibit context save/restore for the
fake preempt context")
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
Cc: Michel Thierry <mic
n <ch...@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiar...@intel.com>
> Cc: Michel Thierry <michel.thie...@intel.com>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> ---
>
for its clarity.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Michał Winiarski <m
On Tue, Feb 06, 2018 at 02:31:37PM +, Chris Wilson wrote:
> We only need to wake up the RPS worker once when initially enabling the
> client boost, it remains in effect then until the last client no longer
> requires the boost.
Reviewed-by: Michał Winiarski <michal.winiar.
On Wed, Jan 31, 2018 at 11:44:38AM +0530, Sagar Arun Kamble wrote:
> On some systems like skl-gvtdvm, SSE4.1 movntdqa might not be available.
> movntdqa is needed for efficient capture of the logs from uncached GuC
> log buffer. GuC init was tied with this support and other setup needed
> for
On Tue, Jan 30, 2018 at 09:02:45AM +, Chris Wilson wrote:
> Quoting Daniele Ceraolo Spurio (2018-01-30 00:24:04)
> >
> >
> > > @@ -979,17 +979,19 @@ static int guc_clients_create(struct intel_guc *guc)
> > > }
> > > guc->execbuf_client = client;
> > >
> > > - client =
ry to unsubmit a completed request" in the subject?
(what does it mean to "finish the seqno"?)
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915
.062924]
>which lock already depends on the new lock.
>
I'd leave the lockdep splat out of here, since that's just the tip of the
iceberg :)
> Fixes: 0ed87953532652 ("drm/i915/guc: Redefine guc_log_level modparam values")
s/Fixes/References
It allows us t
kage. Assert that it doesn't move.
>
> Complete, but expensive checking is done by swfence, this assert is more
> about documenting the topologically ordered list.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiar...@in
gar Arun Kamble <sagar.a.kam...@intel.com>
> Fixes: 3176ff49bc3e ("drm/i915/guc: Move GuC workqueue allocations outside of
> the mutex")
> Cc: Michał Winiarski <michal.winiar...@intel.com>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> ---
> drivers/g
99] 8806bf20f480: fb fb fb fb fb fb fb fb fc fc fc fc fc fc
> fc fc
> [ 3083.158201] 8806bf20f500: fb fb fb fb fb fb fb fb fc fc fc fc fc fc
> fc fc
> [ 3083.158203]
> ======
>
> Reported-by: Alexandru Chirvasitu <achi
On Tue, Jan 02, 2018 at 07:25:00PM +, Chris Wilson wrote:
> We should never insert the invalid seqno into the wait tree, so assert
> we do not.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Mich
ahtinen <joonas.lahti...@linux.intel.com>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> drivers/gpu/drm/i915/i915_gem_request.c | 9 -
> drivers/gpu/drm/i915/i915_gem_request.h | 6 ++
> drivers/gpu/drm/i915/intel_lrc.c| 9 ++--
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 11 ---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/
chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c
> b/drivers/gpu/drm/i915/intel_lr
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/
d-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 33 +
> 1 file changed, 21 insertions(+), 12 deletions(-)
_
On Tue, Jan 02, 2018 at 03:12:33PM +, Chris Wilson wrote:
> Currently, we record the elsp register offset inside init-hw but we only
> need to do it once during engine setup (after we know the mmio
> iomapping).
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
On Tue, Jan 02, 2018 at 03:12:34PM +, Chris Wilson wrote:
> Move the register settings for enabling execlists into its own function
> for clarity.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-
sses/fds, it can only share GTT belonging
> to this fd.
> Testcase: igt/gem_ctx_shared
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: Mika K
We have the selftest that's checking doorbell create/destroy, so there's
no need to check all doorbells delaying the reset every time.
We do want to have that extra sanity check at module load/unload though.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wils
We can now move the clients allocation to submission_init path, rather
than keeping the condition inside submission_enable called on every
reset.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen &
on module unload.
Note that I've also removed one of the tests (bitmap out of sync), since
it doesn't make much sense anymore - bitmaps are now not expected to
change during the lifetime of a client.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chr
Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i
80 98 00 00 00 01 0f
RIP: intel_guc_suspend+0x34/0x140 [i915] RSP: c9483df8
CR2: 00f9
---[ end trace 23a192a61d937a3e ]---
Fixes: b8e5eb960b28 ("drm/i915/guc: Allocate separate shared data object for
GuC communication")
Signed-off-by: Michał Winiarski <michal.winiar
on suspend/resume.
v2: Do not duplicate disable_communication / reset_guc_interrupts
v3: Add proper teardown after rebase
References: 04f7b24eccdf ("drm/i915/guc: Assert that we switch between known
ggtt->invalidate functions")
Signed-off-by: Michał Winiarski <michal.winiar...@inte
005a0
R10: 55e847c2a830 R11: 0002 R12: 0001
R13: 55e847c1d040 R14: 7ffd6ffc3400 R15: 7f98d6752ba0
v2: Init preempt_work unconditionally (Chris)
v3: Mention that we need the enable_guc=1 for lockdep splat (Chris)
Testcase: igt/debugfs_test/read_all_entries #
Generated using make header_install.
Generated from drm-intel-next-queued commit
53ff2641a817099e1c6d1aef409ba004c3a9f1ea
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
---
include/drm/i915_drm.h | 215 ++---
1 file change
Also:
Revert "drm/i915/GuC/GLK: Load GuC on GLK"
Now that we no longer have fallback to execlists submission available,
if the firmware is selected by the driver but is not available on the
system (like in this case - where the FW is not yet released), we're
unable to get a clean CI run.
This
We have the selftest that's checking doorbell create/destroy, so there's
no need to check all doorbells delaying the reset every time.
We do want to have that extra sanity check at module load/unload though.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wils
We can now move the clients allocation to submission_init path, rather
than keeping the condition inside submission_enable called on every
reset.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen &
on module unload.
Note that I've also removed one of the tests (bitmap out of sync), since
it doesn't make much sense anymore - bitmaps are now not expected to
change during the lifetime of a client.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chr
005a0
R10: 55e847c2a830 R11: 0002 R12: 0001
R13: 55e847c1d040 R14: 7ffd6ffc3400 R15: 7f98d6752ba0
v2: Init preempt_work unconditionally (Chris)
Testcase: igt/debugfs_test/read_all_entries
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
C
on suspend/resume.
v2: Do not duplicate disable_communication / reset_guc_interrupts
References: 04f7b24eccdf ("drm/i915/guc: Assert that we switch between known
ggtt->invalidate functions")
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@
Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 4
1 file changed, 4 insertions(+)
diff
80 98 00 00 00 01 0f
RIP: intel_guc_suspend+0x34/0x140 [i915] RSP: c9483df8
CR2: 00f9
---[ end trace 23a192a61d937a3e ]---
Fixes: b8e5eb960b28 ("drm/i915/guc: Allocate separate shared data object for
GuC communication")
Signed-off-by: Michał Winiarski <michal.winiar
---
drivers/gpu/drm/i915/i915_params.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_params.h
b/drivers/gpu/drm/i915/i915_params.h
index 792ce26d7449..9725c5ad8ac6 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++
on suspend/resume.
References: 04f7b24eccdf ("drm/i915/guc: Assert that we switch between known
ggtt->invalidate functions")
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahti...@linux.int
80 98 00 00 00 01 0f
RIP: intel_guc_suspend+0x34/0x140 [i915] RSP: c9483df8
CR2: 00f9
---[ end trace 23a192a61d937a3e ]---
Fixes: b8e5eb960b28 ("drm/i915/guc: Allocate separate shared data object for
GuC communication")
Signed-off-by: Michał Winiarski <michal.winiar
005a0
R10: 55e847c2a830 R11: 0002 R12: 0001
R13: 55e847c1d040 R14: 7ffd6ffc3400 R15: 7f98d6752ba0
Testcase: igt/debugfs_test/read_all_entries
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk&g
ers/gpu/drm/i915/i915_gem.c
> index c7b5db78fbb4..ee243e1ef706 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
[SNIP]
> +err_ggtt:
> +err_unlock:
So... Just unlock? :>
Does what it says on the tin (fixing WARN_ON galore on guc load failure):
he test (Chris)
>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Michal Winiarski <michal.winiar...@intel.com>
> Signed-off-by: Antonio Argenziano <antonio.argenzi...@intel.com>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
>
winiar...@intel.com>
> Signed-off-by: Antonio Argenziano <antonio.argenzi...@intel.com>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
> ---
> tests/gem_exec_schedule.c | 37 +
> 1 file changed, 37 insertions(+)
ion, we lost the skip over the first port if set for the
> non-preemption path. Restore it.
>
> Reported-by: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Fixes: c41937fd994a ("drm/i915/guc: Preemption! With GuC")
> Signed-off-by: Chris Wilson <ch...@chris-wilso
on <ch...@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuopp...@linux.intel.com>
> Cc: Michał Winiarski <michal.winiar...@intel.com>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> drivers/gpu/drm/i915/intel_guc_submission.
tial backoff if we manage to miss the fast timeout.
> References: 1758b90e38f5 ("drm/i915: Use a hybrid scheme for fast register
> waits")
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Cc: John Harriso
Michał)
Signed-off-by: Dave Gordon <david.s.gor...@intel.com>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
Cc: Jeff McGee <jeff.mc...@intel.com>
preempt postprocessing (Chris)
v5: Make wq NULL after destroying it
v6: Swap struct guc_preempt_work members (Michał)
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Joonas Laht
intel.com>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com&
)
Move clients into an array.
v3: And move clients back from an array, to get rid of the enum (Michał)
v4: Use is_high_priority, move DRM_ERROR into __create_doorbell, move
GEM_BUG_ON inside guc_clients_create (Michał)
Signed-off-by: Dave Gordon <david.s.gor...@intel.com>
Signed-off-by: Mich
On Thu, Oct 26, 2017 at 12:04:11PM +0100, Chris Wilson wrote:
> Quoting Michał Winiarski (2017-10-26 11:52:31)
> > On Thu, Oct 26, 2017 at 08:31:27AM +0100, Chris Wilson wrote:
> > > For measuring the cost of preemption, inject a low priority spinner
> > > b
eviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> CC: Michał Winiarski <michal.winiar...@intel.com>
> ---
> tests/gem_exec_latency.c | 88
>
rgenziano <antonio.argenzi...@intel.com>
>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiar...@intel.com>
> ---
> benchmarks/gem_exec_ctx.c | 6 ++---
> benchmarks/gem_exec_trace.c | 4 +--
> lib/i915/gem_co
preempt postprocessing (Chris)
v5: Make wq NULL after destroying it
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
C
preempt postprocessing (Chris)
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Oscar Mateo <oscar.ma...@intel.com>
C
Also:
Revert "drm/i915/guc: Assert that we switch between known ggtt->invalidate
functions"
This reverts commit 04f7b24eccdfae680a36e9825fe0d61dcd5ed528.
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++--
drivers/gpu/drm/i915/i915_params.h | 4 ++--
2 files changed, 4 insertions(+), 8
-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
Cc: Oscar Mateo <oscar.ma...@intel.com>
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk&
we're introducing
HAS_LOGICAL_RING_PREEMPTION macro instad, converting other users that
were previously touching device info directly.
v2: s/intel_engine/execlists and pass execlists to unwind (Chris)
v3: use locked version for exporting, drop const qual (Chris)
Signed-off-by: Michał Winiarski
We also want to support preemption with GuC submission backend.
In order to do that, we need to remember the priority, like we do on
execlists path.
v2: Remove completed prio == INT_MAX optimization
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch
and
ringing the doorbell, and guc_wq_item_append - used by the function
above, not tied to the concept of gem request.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Michal Wajdec
emit_pipe_control, s/render/rcs (Chris)
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
Reviewed-by: Chris Wilson <
)
Move clients into an array.
v3: And move clients back from an array, to get rid of the enum (Michał)
Signed-off-by: Dave Gordon <david.s.gor...@intel.com>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc
definitions.
v2: Drop unused INTEL_GUC_PREEMPT_OPTION_IMMEDIATE
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
Cc: Oscar Mateo <oscar.ma...@intel.com>
Reviewed-by: Jeff McG
Since it's a two-step process, we can have a cleaner error handling in
the caller if we do the allocations in a helper.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@inte
page?). Let's allocate a separate object instead.
v2: Drop kernel_context from GuC suspend/resume action handlers (Michel)
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chr
ed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com>
Reviewed-by: Sagar Arun Kamble <sagar.a.kam...@intel.com>
---
drivers/gpu/drm/i915/i915_guc_submission.c | 7 +--
1 fi
No major changes from previous iteration.
Dropped the workaround for missing interrupt (which turned out to be
self-inflicted, now properly fixed by Chris), and applied the review comments.
Dave Gordon (1):
drm/i915/guc: Add a second client, to be used for preemption
Michał Winiarski (11
ll; be specific!
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103324
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> CC: Michał Winiarski <michal.winiar...@intel.com>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> tests/gem_exec_nop.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c
> index ce3a8ef7..c9280795 1006
ll do the job of exhausting the fdtable.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103365
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
But do we really need this test? Perhaps w
s that subsequent GPU hangs are not prominently recorded, as
> the kernel believes they are secondary hangs (and we only announce the
> first).
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> li
for waiters.
> -Chris
With additional note that as a consequence, we're basically postponing the
irq_disable until idle_work_handler.
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ___
> Intel-g
Fixes: 1f181225f8ec ("drm/i915/execlists: Keep request->priority for its
> lifetime")
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Michał Winiarski <michal.winiar...@intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: John Harrison <john.c.harri...@intel.com>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
---
drivers/gpu/drm/i
Also:
Revert "drm/i915/guc: Assert that we switch between known ggtt->invalidate
functions"
This reverts commit 04f7b24eccdfae680a36e9825fe0d61dcd5ed528.
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++--
drivers/gpu/drm/i915/i915_params.h | 4 ++--
2 files changed, 4 insertions(+), 8
we're introducing
HAS_LOGICAL_RING_PREEMPTION macro instad, converting other users that
were previously touching device info directly.
v2: s/intel_engine/execlists and pass execlists to unwind (Chris)
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch
We also want to support preemption with GuC submission backend.
In order to do that, we need to remember the priority, like we do on
execlists path.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc..
)
Use ordered workqueue for inject_preempt worker to avoid GuC quirks.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
C
-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
Cc: Oscar Mateo <oscar.ma...@intel.com>
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk&
emit_pipe_control, s/render/rcs (Chris)
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com
Reviewed-by: Chris Wilson <ch
and
ringing the doorbell, and guc_wq_item_append - used by the function
above, not tied to the concept of gem request.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Michal Wajdec
definitions.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Jeff McGee <jeff.mc...@intel.com>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
Cc: Oscar Mateo <oscar.ma...@intel.com>
Reviewed-by: Jeff McGee <jeff.mc...@intel.com>
---
drivers/gpu/
)
Move clients into an array.
Signed-off-by: Dave Gordon <david.s.gor...@intel.com>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
Cc: Jeff McGee <
.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
Cc: Michel Thierry <michel.thie...@intel.com>
Cc: Mika Kuoppala <mika.kuopp...@intel.com>
Cc: Oscar Mateo &l
Since it's a two-step process, we can have a cleaner error handling in
the caller if we do the allocations in a helper.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@inte
page?). Let's allocate a separate object instead.
v2: Drop kernel_context from GuC suspend/resume action handlers (Michel)
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Chris Wilson <ch...@chr
Apparently, this value is reserved and may be interpreted as changing
doorbell ownership. Even though we're not observing any side effects
now, let's skip over it to be consistent with the spec.
Suggested-by: Sagar Arun Kamble <sagar.a.kam...@intel.com>
Signed-off-by: Michał Win
for preemption
Michał Winiarski (13):
drm/i915/guc: Do not use 0 for GuC doorbell cookie
drm/i915/guc: Extract GuC stage desc pool creation into a helper
drm/i915/guc: Allocate separate shared data object for GuC
communication
drm/i915/guc: Initialize GuC before restarting engines
drm/i915/guc
("lib: Extract helpers for determining submission method")
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
---
.../intel-gpu-tools/intel-gpu-tools-docs.xml |
Another example of something that is used across different tests, and
should be moved to lib.
v2: Break the trend of expanding ioctl_wrappers
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Cc: Chris Wilson <ch...@chr
We'd like to make ioctl_wrappers a bit thinner, and we plan to add new
helpers in the following patch. Let's move context related helpers before
adding more content.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Cc: Chri
Couple of tests are using either determining submission method, or
pretty printing. Let's move those to helpers in lib.
v2: s/igt_show/gem_show
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Cc: Chris Wilson <ch...@chr
Couple of tests are using either determining scheduler capabilities or
pretty printing. Let's move those to helpers in lib. We can also keep
the value obtained from getparam static.
v2: Break the trend of expanding ioctl_wrappers
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com&
On Mon, Oct 16, 2017 at 08:12:46AM +, Chris Wilson wrote:
> For per-engine checks, check the engine actually exists (important for
> bsd aliasing).
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
chris-wilson.co.uk>
> ---
> tests/Makefile.sources | 1 +
> tests/core_suspend.c | 60
> ++
> 2 files changed, 61 insertions(+)
> create mode 100644 tests/core_suspend.c
Missing changes in meson.build
With that:
Revie
We'd like to make ioctl_wrappers a bit thinner, and we plan to add new
helpers in the following patch. Let's move context related helpers before
adding more content.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Cc: Chri
Another example of something that is used across different tests, and
should be moved to lib.
v2: Break the trend of expanding ioctl_wrappers
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Cc: Chris Wilson <ch...@chr
Couple of tests are using either determining scheduler capabilities or
pretty printing. Let's move those to helpers in lib. We can also keep
the value obtained from getparam static.
v2: Break the trend of expanding ioctl_wrappers
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com&
Couple of tests are using either determining submission method, or
pretty printing. Let's move those to helpers in lib.
Signed-off-by: Michał Winiarski <michal.winiar...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
n.co.uk>
Reviewed-by: Michał Winiarski <michal.winiar...@intel.com>
-Michał
> ---
> tests/gem_eio.c | 48
> 1 file changed, 48 insertions(+)
___
Intel-gfx mailing list
Intel-gfx@lists.freedeskt
201 - 300 of 616 matches
Mail list logo
