[Intel-gfx] [PATCH i-g-t 1/5] tests/kms_plane_multiple: Add TEST_ONLY flag

Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 79 -- 1 file changed, 49 insertions(+), 30 deletions(-) diff --git a

Re: [Intel-gfx] [PATCH v2] drm/i915/bxt: add bxt dsi gpio element support

Hi Bob, On Tue, 2016-12-20 at 09:53 -0800, Bob Paauwe wrote: > On Tue, 13 Dec 2016 16:11:20 +0200 > Jani Nikula <jani.nik...@intel.com> wrote: > > > > > On Mon, 05 Dec 2016, Mika Kahola <mika.kah...@intel.com> wrote: > > > > > > From: Jani

[Intel-gfx] [PATCH i-g-t v3] tests/kms_plane_lowres: Plane visibility after atomic modesets

option for multiple test iterations (Daniel Vetter) Cc: Daniel Stone <dan...@fooishbar.org> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- lib/igt_kms.c| 161 ++ lib/igt_kms.h| 23 tests/Makefile.sources | 1 + tests/kms_pl

[Intel-gfx] [PATCH 2/3] drm/i915: Intel panel downclock cleanup

Let's switch to use dev_priv instead of dev when calling intel_find_panel_downclock() function. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c| 2 +- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_panel.c | 6 +++--- 3

[Intel-gfx] [PATCH 3/3] drm/i915: Hz to PWM for i965

Unify function structure as any other *_hz_to_pwm() functions are structured. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_panel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/dr

[Intel-gfx] [PATCH 1/3] drm/i915: Intel panel detection cleanup

Let's switch to use private dev_priv instead of dev when detecting intel panels. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c| 3 ++- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_lvds.c | 4 ++-- drivers/gpu/dr

[Intel-gfx] [PATCH 0/3] Various cleanups on intel_panel.c

Proposal for cleanup. Let's favor dev_priv instead of dev in intel_panel.c functions. Cleanup for HZ to PWM functions to unify the look and feel of these functions. Mika Kahola (3): drm/i915: Intel panel detection cleanup drm/i915: Intel panel downclock cleanup drm/i915: Hz to PWM for i965

Re: [Intel-gfx] [PATCH] drm/i915: Parse panel BL controller from VBT

Tested-by: Mika Kahola <mika.kah...@intel.com> On Wed, 2016-12-07 at 20:32 +0530, Vidya Srinivas wrote: > Currently the backlight controller is taken as 0. It needs to derive > value from the VBT. Adding the necessary changes. > > v2: Updated the commit header > > Si

[Intel-gfx] [PATCH v2] drm/i915/bxt: add bxt dsi gpio element support

anel"* when requesting gpio for MIPI/DSI panel. (Mika) Signed-off-by: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 38 +- 1 file changed, 32 insertions(+), 6 deletions(

Re: [Intel-gfx] [PATCH alternative #1] drm/i915/bxt: add bxt dsi gpio element support

On Tue, 2016-11-15 at 14:08 +0200, Jani Nikula wrote: > Request the GPIO by index through the consumer API. For now, use a > quick > hack to store the already requested ones, simply because I have no > idea > whether this actually works or not, and I have no way to test it. >

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix CRC based atomic correctness test

en.lankho...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c index bedee16..5e12be4 100644 --- a/tests/kms_plane_mult

[Intel-gfx] [PATCH i-g-t v2] tests/kms_plane_lowres: Plane visibility after atomic modesets

(Daniel) add tiling MODE_NONE (Daniel) Cc: Daniel Stone <dan...@fooishbar.org> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- lib/igt_kms.c| 93 +++ lib/igt_kms.h| 9 ++ tests/Makefile.sources | 1 + tests/kms_plane_lo

[Intel-gfx] [PATCH CI run 3/3] drm/i915: Adding the parsing logic for the i2c element

- rebase Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: vkorjani <vikas.korj...@intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> Signed-off-by: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com

[Intel-gfx] [PATCH CI run 0/3] MIPI/DSI display support for APL

Test MIPI/DSI display suspend/resume cycle on Apollolake. Jani Nikula (1): drm/i915/bxt: add bxt dsi gpio element support Mika Kahola (2): drm/i915: Get the i2c bus number from the ACPI drm/i915: Adding the parsing logic for the i2c element drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH CI run 2/3] drm/i915: Get the i2c bus number from the ACPI

nik...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Deepak M <m.dee...@intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 10 +++ drivers/gpu/dr

[Intel-gfx] [PATCH CI run 1/3] drm/i915/bxt: add bxt dsi gpio element support

From: Jani Nikula <jani.nik...@intel.com> Use a table similar to vlv to check for accepted gpio indexes. For now, add all, but this list should be trimmed down. Use managed gpio request, which will be automatically released when the driver is detached. Cc: Mika Kahola <mika.kah...@

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Plane visibility after atomic modesets

'i915_display_info' that the plane is invisible - switch back to higher resolution mode - check from debugfs 'i915_display_info' that the plane is visible again - repeat number of iterations, default 64 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 +

Re: [Intel-gfx] [PATCH v5 3/3] drm/i915/bxt: add bxt dsi gpio element support

Tested-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2016-04-26 at 13:27 +0300, Jani Nikula wrote: > Request the GPIO by index through the consumer API. For now, use a > quick > hack to store the already requested ones, simply because I have no > idea > whether this actuall

[Intel-gfx] [PATCH i-g-t v7] tests/kms_plane_multiple: CRC based atomic correctness test

variable to max_planes To optimize test execution, run iterations after the modeset v2: Keep a logfile on random number seeds per subtest that are not skipped due to unmet test requirements Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 +

Re: [Intel-gfx] [PATCH i-g-t v6] tests/kms_plane_multiple: CRC based atomic correctness test

On Tue, 2016-11-08 at 14:14 +0100, Maarten Lankhorst wrote: > Op 08-11-16 om 12:54 schreef Mika Kahola: > > > > This is a testcase with multiple planes. The idea here is the > > following > > > >  - draw a uniform frame with blue color > >  - grab crc f

[Intel-gfx] [PATCH i-g-t v6] tests/kms_plane_multiple: CRC based atomic correctness test

the modeset v2: Keep a logfile on random number seeds per subtest that are not skipped due to unmet test requirements Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 + tests/kms_plane_multiple.c | 501 ++

Re: [Intel-gfx] [PATCH i-g-t v5] tests/kms_plane_multiple: CRC based atomic correctness test

Thanks for the review.  On Mon, 2016-11-07 at 14:04 +0100, Maarten Lankhorst wrote: > Op 02-11-16 om 10:32 schreef Mika Kahola: > > > > This is a testcase with multiple planes. The idea here is the > > following > > > >  - draw a uniform frame with blue co

[Intel-gfx] [PATCH i-g-t v5] tests/kms_plane_multiple: CRC based atomic correctness test

nplanes variable to max_planes To optimize test execution, run iterations after the modeset v2: Keep a logfile on random number seeds per subtest that are not skipped due to unmet test requirements Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources

Re: [Intel-gfx] [PATCH i-g-t v4] tests/kms_plane_multiple: CRC based atomic correctness test

On Tue, 2016-11-01 at 09:25 +0100, Maarten Lankhorst wrote: > Op 20-10-16 om 11:27 schreef Mika Kahola: > > > > This is a testcase with multiple planes. The idea here is the > > following > > > >  - draw a uniform frame with blue color > >  - grab crc f

Re: [Intel-gfx] [PATCH i-g-t v4] tests/kms_plane_multiple: CRC based atomic correctness test

On Mon, 2016-10-24 at 10:28 +0200, Daniel Vetter wrote: > On Thu, Oct 20, 2016 at 12:27:23PM +0300, Mika Kahola wrote: > > > > This is a testcase with multiple planes. The idea here is the > > following > > > >  - draw a uniform frame with blue color > &g

[Intel-gfx] [PATCH i-g-t v4] tests/kms_plane_multiple: CRC based atomic correctness test

to unmet test requirements Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 + tests/kms_plane_multiple.c | 475 + 2 files changed, 476 insertions(+) create mode 100644 tests/kms_plane_multiple.c diff --git a

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

On Mon, 2016-10-17 at 16:30 +0200, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 02:28:37PM +0300, Mika Kahola wrote: > > > > + for (int i = 0; i < iterations; i++) { > > + igt_info("%d/%d: Testing connector %s using pipe > > %s with %d plan

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 + tests/kms_plane_multiple.c | 423 + 2 files changed, 424 insertions(+) create mode 100644 tests/kms_plane_multiple.c diff --git a/tests/Makefile.sources b

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

On Wed, 2016-10-12 at 14:54 +0200, Maarten Lankhorst wrote: > Op 07-10-16 om 13:45 schreef Mika Kahola: > > > > This is a testcase with multiple planes. The idea here is the > > following > > > >  - draw a uniform frame with blue color > >  - grab crc f

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

to unmet test requirements Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 421 + 1 file changed, 421 insertions(+) create mode 100644 tests/kms_plane_multiple.c diff --git a/tests/kms_plane_multiple.c b

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

these holes so that the output is the identical to reference crc - composite all with one ioctl call - grab crc and verify that the reference crc is equal - repeat this for dozen iterations to maximize coverage Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources

Re: [Intel-gfx] [PATCH 1/5] drm/i915/skl: drop workarounds for A0 and B0 revisions

READ(GEN8_GARBCNTL) > | > -    GEN9_GAPS_TSV_CREDIT_DISA > BLE)); > - } > - > - /* WaDisablePowerCompilerClockGating:skl */ > - if (IS_SKL_REVID(dev_priv, SKL_REVID_B0, SKL_REVID_B0)) > - WA_SET_BIT_MASKED(HIZ_CHICKEN, > -   BDW_HIZ_POWER_COMPILER_CLOCK_GATIN > G_DISABLE); > + I915_WRITE(GEN8_GARBCNTL, (I915_READ(GEN8_GARBCNTL) | > +    GEN9_GAPS_TSV_CREDIT_DISABLE)); >   >   /* WaBarrierPerformanceFixDisable:skl */ >   if (IS_SKL_REVID(dev_priv, SKL_REVID_C0, SKL_REVID_D0)) -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm: Fix DisplayPort branch device ID

Fix missing parameter description for DisplayPort branch device ID. This fixes warning of "No description found for parameter 'id[6]'" when creating documentation by 'make htmldocs'. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 1 + 1

Re: [Intel-gfx] [drm-intel:for-linux-next 6/12] htmldocs: drivers/gpu/drm/drm_dp_helper.c:523: warning: No description found for parameter 'id[6]'

I'll fix this. Cheers, Mika On Fri, 2016-09-16 at 10:53 +0300, Jani Nikula wrote: > Mika, please send in the documentation fix. > > BR, > Jani. > > > On Fri, 16 Sep 2016, kbuild test robot > wrote: > > > > tree:   git://anongit.freedesktop.org/drm-intel

Re: [Intel-gfx] [PATCH v6 1/6] drm/i915: Fallback to lower link rate and lane count during link training

with Channel EQ. > In case of Channel EQ failures, it should fallback to > lower link rate and lane count and start the CR phase again. > > v6: > * Do not split quoted string across line (Mika Kahola) > v5: > * Reset the link rate index to the max link rate index > before

Re: [Intel-gfx] [PATCH v3 3/6] drm/i915: Change the placement of some static functions in intel_dp.c

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2016-09-15 at 17:04 -0700, Manasi Navare wrote: > These static helper functions are required to be used within upfront > link training related functions so they need to be placed at the top > of the file. It also ch

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Code cleanup to use dev_priv and INTEL_GEN

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2016-09-15 at 17:04 -0700, Manasi Navare wrote: > Replace dev with dev_priv and INTEL_INFO with INTEL_GEN > > Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> > --- >  drivers/gpu/drm/i915/intel_dp.c |

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Change the placement of some static functions in intel_dp.c

common_rates[k] = source_rates[i]; > - ++k; > - ++i; > - ++j; > - } else if (source_rates[i] < sink_rates[j]) { > - ++i; > - } else { > -

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: Fallback to lower link rate and lane count during link training

in intel_dp_link_rate_index > v4: > * Fixed the link rate fallback loop (Manasi Navare) > v3: > * Fixed some rebase issues (Mika Kahola) > v2: > * Add a helper function to return index of requested link rate > into common_rates array > * Changed the link rate fallb

Re: [Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

On Fri, 2016-09-09 at 12:09 +0300, Ville Syrjälä wrote: > On Fri, Sep 09, 2016 at 10:45:27AM +0300, Mika Kahola wrote: > > > > On Thu, 2016-09-08 at 15:48 +0300, Ville Syrjälä wrote: > > > > > > On Wed, Aug 17, 2016 at 01:49:49PM +0300, Mika Kahola wrote: >

[Intel-gfx] [PATCH v9 03/12] drm: Helper to read max clock rate

) Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/dri

[Intel-gfx] [PATCH v9 05/12] drm: Read DP branch device id

Read DisplayPort branch device id string. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --g

[Intel-gfx] [PATCH v9 01/12] drm: Add missing DP downstream port types

Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --g

[Intel-gfx] [PATCH v9 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 4 +

[Intel-gfx] [PATCH v9 09/12] drm/i915: Check pixel rate for DP to VGA dongle

lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed

[Intel-gfx] [PATCH v9 08/12] drm/i915: Read DP branch device SW revision

info to dmesg (Ville) v4: commit message fix (Jim Bride) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/d

[Intel-gfx] [PATCH v9 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 ++

[Intel-gfx] [PATCH v9 11/12] drm: Add DP branch device info on debugfs

to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines v7: indentation fixes (Jim Bride) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c

[Intel-gfx] [PATCH v9 10/12] drm/i915: Update bits per component for display info

(Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config v5: Indentation fixes (Jim Bride) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.

[Intel-gfx] [PATCH v9 07/12] drm/i915: Read DP branch device HW revision

(Ville) Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [PATCH v9 02/12] drm: Drop VGA from bpc definitions

Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- include/drm/drm_dp_helper.h | 10 +- 1 file

[Intel-gfx] [PATCH v9 04/12] drm: Helper to read max bits per component

Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika

[Intel-gfx] [PATCH v9 00/12] drm/i915: DP branch devices

: Indentation fixes (Jim Bride) Mika Kahola (12): drm: Add missing DP downstream port types drm: Drop VGA from bpc definitions drm: Helper to read max clock rate drm: Helper to read max bits per component drm: Read DP branch device id drm/i915: Cleanup DisplayPort AUX channel initialization drm

Re: [Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

On Thu, 2016-09-08 at 15:48 +0300, Ville Syrjälä wrote: > On Wed, Aug 17, 2016 at 01:49:49PM +0300, Mika Kahola wrote: > > > > Respect max TMDS clock frequency from DPCD for active > > DP to HDMI adapters. > > > > Signed-off-by: Mika Kahola <mika.kah...@int

Re: [Intel-gfx] [PATCH v13 13/14] drm/i915/dp: Enable Upfront link training for typeC DP support on HSW/BDW/SKL/BXT (DDI platforms)

uent modeset is not aware of these changes. > > Changes since v12: > * Fix Rebase issues (Mika Kahola) > Changes since v11: > * Change the fallback link rate logic (Manasi) > Changes since v10: > * Use the ddi link train function that loops through all the link > rates > an

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/dp/mst: Add support for upfront link training for DP MST

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Wed, 2016-09-07 at 13:53 +0300, Mika Kahola wrote: > On Tue, 2016-09-06 at 17:13 -0700, Manasi Navare wrote: > > > > From: Jim Bride <jim.br...@linux.intel.com> > > > > Add upfront link training to intel_

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/dp/mst: Add support for upfront link training for DP MST

On Wed, 2016-09-07 at 09:40 -0700, Jim Bride wrote: > On Wed, Sep 07, 2016 at 01:53:31PM +0300, Mika Kahola wrote: > > > > On Tue, 2016-09-06 at 17:13 -0700, Manasi Navare wrote: > > > > > > From: Jim Bride <jim.br...@linux.intel.com>

Re: [Intel-gfx] [PATCH v4 11/14] drm/i915: Fallback to lower link rate and lane count during link training

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Wed, 2016-09-07 at 17:30 -0700, Manasi Navare wrote: > According to the DisplayPort Spec, in case of Clock Recovery failure > the link training sequence should fall back to the lower link rate > followed by lower lane count un

Re: [Intel-gfx] [PATCH v3 9/14] drm/dp/i915: Make clock recovery in the link training compliant with DP Spec 1.2

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Wed, 2016-09-07 at 11:28 -0700, Manasi Navare wrote: > From: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> > > This function cleans up clock recovery loop in link training > compliant > tp Dp Spec 1.2. It tries

Re: [Intel-gfx] [PATCH v3 8/14] drm/i915/dp: Move max. vswing check to it's own function

-by: Mika Kahola <mika.kah...@intel.com> On Wed, 2016-09-07 at 11:28 -0700, Manasi Navare wrote: > From: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> > > Wrap the max. vswing check in a separate function. > This makes the clock recovery phase of DP link training

Re: [Intel-gfx] [PATCH v2 14/14] drm/i915/dp/mst: Add support for upfront link training for DP MST

_dp_add_properties(struct intel_dp *intel_dp, struct > drm_connector *connector); >  void intel_dp_mst_suspend(struct drm_device *dev); >  void intel_dp_mst_resume(struct drm_device *dev); > +u8 intel_dp_max_lane_count(struct intel_dp *intel_dp); >  int intel_dp_max_link_rate(struct intel_dp *intel_dp); >  int intel_dp_link_rate_index(struct intel_dp *intel_dp, int > *common_rates, >    int link_rate); > @@ -1448,6 +1449,8 @@ intel_dp_pre_emphasis_max(struct intel_dp > *intel_dp, uint8_t voltage_swing); >  void intel_dp_compute_rate(struct intel_dp *intel_dp, int > port_clock, >      uint8_t *link_bw, uint8_t *rate_select); >  bool intel_dp_source_supports_hbr2(struct intel_dp *intel_dp); > +int intel_dp_common_rates(struct intel_dp *intel_dp, int > *common_rates); > +bool intel_dp_upfront_link_train(struct intel_dp *intel_dp); >  bool >  intel_dp_get_link_status(struct intel_dp *intel_dp, uint8_t > link_status[DP_LINK_STATUS_SIZE]); >   -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 11/14] drm/i915: Fallback to lower link rate and lane count during link training

make use > of common_rates array (Mika Kahola) > * Changed INTEL_INFO to INTEL_GEN (David Weinehall) > > Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> > --- >  drivers/gpu/drm/i915/intel_ddi.c  | 125 > +++--- >  drivers/gpu/

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Make DP link training channel equalization DP 1.2 Spec compliant

Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Fri, 2016-09-02 at 22:05 +0300, Pandiyan, Dhinakaran wrote: > On Fri, 2016-09-02 at 14:20 +0300, Mika Kahola wrote: > > > > On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > > > > > > Fix the

Re: [Intel-gfx] [PATCH v2 9/14] drm/dp/i915: Make clock recovery in the link training compliant with DP Spec 1.2

ate training set as requested by target */ >   intel_get_adjust_train(intel_dp, link_status); >   if (!intel_dp_update_link_train(intel_dp)) { >   DRM_ERROR("failed to update link > training\n"); > - break; > +

Re: [Intel-gfx] [PATCH v2 8/14] drm/i915/dp: Move max. vswing check to it's own function

On Tue, 2016-09-06 at 17:13 -0700, Manasi Navare wrote: > From: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> > > Wrap the max. vswing check in a separate function. > This makes the clock recovery phase of DP link training cleaner > > v2: > Fixed the Co

Re: [Intel-gfx] [PATCH 08/14] drm/i915/dp: Move max. vswing check to it's own function

On Fri, 2016-09-02 at 11:05 +0300, Mika Kahola wrote: > +1 for this cleanup > > Reviewed-by: Mika Kahola <mika.kah...@intel.com> Received couple of compiler warnings to be cleaned up drivers/gpu/drm/i915/intel_dp_link_training.c: In function ‘intel_dp_link_max_vswing_reached’:

Re: [Intel-gfx] [PATCH 12/14] drm/i915: Reverse the loop in intel_dp_compute_config

_lane_count; > +  lane_count >= min_lane_count; > +  lane_count >>= 1) { >   >   link_clock = common_rates[clock]; >   link_avail = > intel_dp_max_data_rate(link_clock, -- Mika Kahola - Intel OTC ___

Re: [Intel-gfx] [PATCH 11/14] drm/i915: Fallback to lower link rate and lane count during link training

 struct intel_crtc_state *pipe_config); >  void intel_ddi_set_vc_payload_alloc(struct drm_crtc *crtc, bool > state); >  uint32_t ddi_signal_levels(struct intel_dp *intel_dp); > +bool intel_ddi_link_train(struct intel_dp *intel_dp, int >

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Make DP link training channel equalization DP 1.2 Spec compliant

urn intel_dp->channel_eq_status; > + >  } >   >  void intel_dp_stop_link_train(struct intel_dp *intel_dp) > diff --git a/drivers/gpu/drm/i915/intel_drv.h > b/drivers/gpu/drm/i915/intel_drv.h > index efcd80b..e5bc976 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -878,6 +878,7 @@ struct intel_dp { >   bool link_mst; >   bool has_audio; >   bool detect_done; > + bool channel_eq_status; >   enum hdmi_force_audio force_audio; >   bool limited_color_range; >   bool color_range_auto; -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 09/14] drm/dp/i915: Make clock recovery in the link training compliant with DP Spec 1.2

el_dp->train_set[0] & > DP_TRAIN_VOLTAGE_SWING_MASK; >   >   /* Update training set as requested by target */ >   intel_get_adjust_train(intel_dp, link_status); >   if (!intel_dp_update_link_train(intel_dp)) { >   DRM_ERROR("failed to upd

Re: [Intel-gfx] [PATCH 08/14] drm/i915/dp: Move max. vswing check to it's own function

+1 for this cleanup Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > From: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> > > Wrap the max. vswing check in a separate function. > This makes the clock r

Re: [Intel-gfx] [PATCH] drm/i915/dp: add lane_count check in intel_dp_check_link_status

gt; + >   /* if link training is requested we should perform it always > */ >   if ((intel_dp->compliance_test_type == > DP_TEST_LINK_TRAINING) || >   (!drm_dp_channel_eq_ok(link_status, intel_dp- > >lane_count))) { Should we place this chec

[Intel-gfx] [PATCH v8 11/12] drm: Add DP branch device info on debugfs

to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 81 + drivers/gpu/dr

[Intel-gfx] [PATCH v8 09/12] drm/i915: Check pixel rate for DP to VGA dongle

lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/driver

[Intel-gfx] [PATCH v8 10/12] drm/i915: Update bits per component for display info

(Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 17 - 1 file chang

[Intel-gfx] [PATCH v8 07/12] drm/i915: Read DP branch device HW revision

(Ville) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3

[Intel-gfx] [PATCH v8 02/12] drm: Drop VGA from bpc definitions

Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- include/drm/drm_dp_helper.h | 10 +- 1 file

[Intel-gfx] [PATCH v8 00/12] drm/i915: DP branch devices

routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers v8: Cleanups and TMDS clock frequency check for HDMI adapter Mika Kahola

[Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff

[Intel-gfx] [PATCH v8 03/12] drm: Helper to read max clock rate

) Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/dri

[Intel-gfx] [PATCH v8 01/12] drm: Add missing DP downstream port types

Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --g

[Intel-gfx] [PATCH v8 08/12] drm/i915: Read DP branch device SW revision

(Ville) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9

[Intel-gfx] [PATCH v8 05/12] drm: Read DP branch device id

Read DisplayPort branch device id string. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --g

[Intel-gfx] [PATCH v8 09/12] Check pixel rate for DP to VGA dongle

lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/driver

[Intel-gfx] [PATCH v8 04/12] drm: Helper to read max bits per component

Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika

[Intel-gfx] [PATCH v8 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[Intel-gfx] [PATCH v8 12/12] drm/i915: Check TMDS clock DP to HDMI dongle

Respect max TMDS clock frequency from DPCD for active DP to HDMI adapters. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_drv.h | 3 +++ drivers/gpu/drm/i915/intel_hdmi.c | 27 +++ 2 files changed, 30 insertions(+) diff

[Intel-gfx] [PATCH v8 10/12] drm/i915: Update bits per component for display info

(Daniel) v4: remove updating bpc for display info as it may be overridden when parsing EDID. Instead, check bpc for DP branch device during compute_config Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 17 - 1 file chang

[Intel-gfx] [PATCH v8 11/12] drm: Add DP branch device info on debugfs

to move debugging info from intel_dp. to drm_dp_helper.c (Daniel) v6: read hw and sw revision without using specific drm_dp_helper routines Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 81 + drivers/gpu/dr

[Intel-gfx] [PATCH v8 09/12] drm/i915: Check pixel rate for DP to VGA dongle

lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/driver

[Intel-gfx] [PATCH v8 09/12] Check pixel rate for DP to VGA dongle

lle) v6: Move DP branch device check to drm_dp_helper.c (Daniel) v7: Cleanup as suggested by Ville Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/driver

[Intel-gfx] [PATCH v8 08/12] drm/i915: Read DP branch device SW revision

(Ville) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 20 include/drm/drm_dp_helper.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 9

[Intel-gfx] [PATCH v8 07/12] drm/i915: Read DP branch device HW revision

(Ville) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 21 + include/drm/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 3

[Intel-gfx] [PATCH v8 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization

Let's remove reference to "struct intel_connector *connector" in intel_dp_aux_init() function as it is no longer required. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[Intel-gfx] [PATCH v8 05/12] drm: Read DP branch device id

Read DisplayPort branch device id string. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --g

[Intel-gfx] [PATCH v8 03/12] drm: Helper to read max clock rate

) Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/dri

[Intel-gfx] [PATCH v8 04/12] drm: Helper to read max bits per component

Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika

[Intel-gfx] [PATCH v8 02/12] drm: Drop VGA from bpc definitions

Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- include/drm/drm_dp_helper.h | 10 +- 1 file

[Intel-gfx] [PATCH v8 01/12] drm: Add missing DP downstream port types

Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --g

[Intel-gfx] [PATCH v8 00/12] drm/i915: DP branch devices

routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup v7: Structure cleanups and initial step to move DP debugging info to drm_dp_helpers v8: Cleanups and TMDS clock frequency check for HDMI adapter Mika Kahola

<    1   2   3   4   5   6   7   8   9   10   >