Re: [Intel-gfx] [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Philippe CORNU
g.com> > Cc: Kukjin Kim <kg...@kernel.org> > Cc: Krzysztof Kozlowski <k...@kernel.org> > Cc: Ben Skeggs <bske...@redhat.com> > Cc: Tomi Valkeinen <tomi.valkei...@ti.com> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Benjamin Gaignard

Re: [Intel-gfx] [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Philippe CORNU
pinchart+rene...@ideasonboard.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Shawn Guo <shawn@linaro.org> > Cc: Eric Engestrom <e...@engestrom.ch> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: "Ville Syrjälä" <ville.syrj...@

Re: [Intel-gfx] [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Philippe CORNU
Vasut <ma...@denx.de> > Cc: Ben Skeggs <bske...@redhat.com> > Cc: Tomi Valkeinen <tomi.valkei...@ti.com> > Cc: Eric Anholt <e...@anholt.net> > Cc: Mark Yao <mark@rock-chips.com> > Cc: Heiko Stuebner <he...@sntech.de> > Cc: Benjamin Gaignard <

Re: [Intel-gfx] [PATCH 0/4] [v2] Blobifiers (FKA GET_PLANE2)

2017-07-25 Thread Philippe CORNU
| 2 +- > drivers/gpu/drm/sti/sti_hqvdp.c | 2 +- > drivers/gpu/drm/stm/ltdc.c | 2 +- for stm, Acked-by: Philippe Cornu <philippe.co...@st.com> Tested-by: Philippe Cornu <philippe.co...@st.com> Many thanks Philippe :-) >

Re: [Intel-gfx] [PATCH v2 13/14] drm: stm: remove dead code and pointless local lut storage

2017-06-22 Thread Philippe CORNU
On 06/22/2017 08:06 AM, Peter Rosin wrote: > The redundant fb helper .load_lut is no longer used, and can not > work right without also providing the fb helpers .gamma_set and > .gamma_get thus rendering the code in this driver suspect. > Hi Peter, STM32 chipsets supports 8-bit CLUT mode but

Re: [Intel-gfx] [PATCH 31/37] drm/stm: Drop drm_vblank_cleanup

2017-05-29 Thread Philippe CORNU
On 05/24/2017 04:52 PM, Daniel Vetter wrote: > Again seems just cargo-culted. > > Cc: Yannick Fertre <yannick.fer...@st.com> > Cc: Philippe Cornu <philippe.co...@st.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > --- > drivers/gpu/drm/

Re: [Intel-gfx] [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Philippe CORNU
c: Maarten Lankhorst > Cc: Harry Wentland > Cc: Leo Li > Cc: amd-...@lists.freedesktop.org > Cc: James (Qian) Wang > Cc: Liviu Dudau > Cc: Mali DP Maintainers > Cc: CK Hu > Cc: Philipp Zabel > Cc: Yannick Fertre > Cc: Philippe Cornu > Cc: Benjamin Gaignard >

Re: [Intel-gfx] [PATCH 30/59] drm/stm: Drop drm_gem_prime_export/import

2019-06-18 Thread Philippe CORNU
Hi Daniel, Acked-by: Philippe Cornu We will have a look to simplify this part of the code. Thank you for your patch. Philippe :-) On 6/14/19 10:35 PM, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs.

Re: [Intel-gfx] [PATCH v4 15/22] drm/stm: Convert to CRTC VBLANK callbacks

2020-01-24 Thread Philippe CORNU
Dear Thomas, Thank you for your patch, For this stm part, Acked-by: Philippe Cornu Philippe :-) On 1/23/20 2:59 PM, Thomas Zimmermann wrote: > VBLANK callbacks in struct drm_driver are deprecated in favor of > their equivalents in struct drm_crtc_funcs. Convert stm over. > >

Re: [Intel-gfx] [PATCH v4 14/22] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

2020-01-24 Thread Philippe CORNU
Dear Thomas, Thank you for your patch, For this stm part, Acked-by: Philippe Cornu Philippe :-) On 1/23/20 2:59 PM, Thomas Zimmermann wrote: > The callback struct drm_driver.get_scanout_position() is deprecated in > favor of struct drm_crtc_helper_funcs.get_scanout_position(). Conve

Re: [Intel-gfx] [PATCH 39/52] drm/stm: Drop explicit drm_mode_config_cleanup call

2020-02-20 Thread Philippe CORNU
Hi Daniel, On 2/19/20 11:21 AM, Daniel Vetter wrote: > It's right above the drm_dev_put(). > > Aside: Another driver with a bit much devm_kzalloc, which should > probably use drmm_kzalloc instead ... > > Signed-off-by: Daniel Vetter > Cc: Yannick Fertre > Cc: Philip

Re: [Intel-gfx] [PATCH 06/11] drm/: drm_gem_plane_helper_prepare_fb is now the default

2021-05-28 Thread Philippe CORNU
Hu Cc: Matthias Brugger Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome Brunet Cc: Martin Blumenstingl Cc: Marek Vasut Cc: Stefan Agner Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Yannick Fertre Cc: Philippe Cornu For stm Acked-by: Philippe Cornu Many thanks Philippe :-) Cc

Re: [Intel-gfx] [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

2022-01-13 Thread Philippe CORNU
On 1/7/22 6:26 PM, José Expósito wrote: Hi Simon, On Wed, Jan 05, 2022 at 11:54:43PM +, Simon Ser wrote: Pushed patches 1 & 2 to drm-misc-next. Thanks for your contribution! Thanks a lot for the review and for applying the changes, appreciate it. Is there something that needs to

Re: [Intel-gfx] [PATCH 7/8] drm/stm: Don't set allow_fb_modifiers explicitly

2021-04-29 Thread Philippe CORNU - foss
Hi Daniel, Many thanks for your patch, Acked-by: Philippe Cornu Philippe :-) De : Daniel Vetter Envoyé : mardi 27 avril 2021 11:20 À : DRI Development Cc : Intel Graphics Development; Daniel Vetter; Daniel Vetter; Yannick FERTRE - foss; Philippe CORNU