Read desired PWM frequency from panel vbt and calculate the
value for divider in DPCD address 0x724 and 0x728 to match
that frequency as close as possible.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backlight.
Some panel will default to zero brightness when turning the
panel off and on again. This patch stores last brightness level
before turning off and set them back when panel is turning on.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backl
-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/i915_params.c| 6 ++---
drivers/gpu/drm/i915/i915_params.h| 2 +-
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 33 +++
3 files changed, 27 insertions(+), 14 deletions(-)
intel_dp_aux_enable_backlight() assumed that the register
BACKLIGHT_BRIGHTNESS_CONTROL_MODE can only has value 01
(DP_EDP_BACKLIGHT_CONTROL_MODE_PRESET) when initialize.
This patch fixed that by handling all cases of that register.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.
This patch adds the following definition
- Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap
register which only use bit 0:4
- Base frequency (27 MHz) for backlight PWM frequency
generator.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
include/drm/drm_dp_helper.h | 2
This patch enables dynamic backlight by default for eDP
panel that supports this feature via DPCD register and
set minimum / maximum brightness to 0% and 100% of the
normal brightness.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backl
last brightness level after
turning display off and on.
- Last two patches set the PWM freqency to match data in panel vbt.
Change log:
v2:
- Drop PWM frequency patch
- Addess suggestion from Jani Nikula
v3:
- Add new implementation of PWM frequency patch
v4:
- Rebase / minor typo fix.
Puthikorn
Friendly ping. Can anyone please review this?
Thanks
On Wed, Mar 22, 2017 at 3:54 PM, Puthikorn Voravootivat <put...@chromium.org
> wrote:
> Rebase since this is not applied cleanly now.
>
> This patch set contain 6 patches.
> - First two patches allow enable DPCD backlight
Some panel will default to zero brightness when turning the
panel off and on again. This patch stores last brightness level
before turning off and set them back when panel is turning on.
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Signed-off-by: Puthikorn Voravootivat <put...@chr
last brightness level after
turning display off and on.
- Last two patches set the PWM freqency to match data in panel vbt.
Change log:
v2:
- Drop PWM frequency patch
- Addess suggestion from Jani Nikula
v3:
- Add new implementation of PWM frequency patch
v4:
- Rebase / minor typo fix.
Puthikorn
<jani.nik...@linux.intel.com>
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/i915_params.c| 6 ++---
drivers/gpu/drm/i915/i915_params.h| 2 +-
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 33 +++-
ed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 29 +--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
b/drivers/gpu/drm/i915/intel_dp_aux_backl
Read desired PWM frequency from panel vbt and calculate the
value for divider in DPCD address 0x724 and 0x728 to match
that frequency as close as possible.
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/
This patch enables dynamic backlight by default for eDP
panel that supports this feature via DPCD register and
set minimum / maximum brightness to 0% and 100% of the
normal brightness.
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Signed-off-by: Puthikorn Voravootivat <put...@chr
This patch adds the following definition
- Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap
register which only use bit 0:4
- Base frequency (27 MHz) for backlight PWM frequency
generator.
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Signed-off-by: Puthikorn Voravootiva
intel_dp_aux_enable_backlight() assumed that the register
BACKLIGHT_BRIGHTNESS_CONTROL_MODE can only has value 01
(DP_EDP_BACKLIGHT_CONTROL_MODE_PRESET) when initialize.
This patch fixed that by handling all cases of that register.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.
From: Puthikorn Voravootivat <put...@google.com>
This patch set contain 6 patches.
- First two patches allow enable DPCD backlight control when panel
can also do that via PWM pin and fix the usage of enable register.
- Next patch adds enable DBC by default
- Next patch makes the driver r
-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/i915_params.c| 6 ++---
drivers/gpu/drm/i915/i915_params.h| 2 +-
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 33 +++
3 files changed, 27 insertions(+), 14 deletions(-)
This patch adds the following definition
- Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap
register which only use bit 0:4
- Base frequency (27 MHz) for backlight PWM frequency
generator.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
include/drm/drm_dp_helper.h | 2
This patch enables dynamic backlight by default for eDP
panel that supports this feature via DPCD register and
set minimum / maximum brightness to 0% and 100% of the
normal brightness.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backl
From: Puthikorn Voravootivat <put...@google.com>
This patch set contain 6 patches.
- First two patches allow enable DPCD backlight control when panel
can also do that via PWM pin and fix the usage of enable register.
- Next patch adds enable DBC by default
- Next patch makes the driver r
Read desired PWM frequency from panel vbt and calculate the
value for divider in DPCD address 0x724 and 0x728 to match
that frequency as close as possible.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backlight.
Some panel will default to zero brightness when turning the
panel off and on again. This patch stores last brightness level
before turning off and set them back when panel is turning on.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backl
and on.
Change log:
v2:
- Drop PWM frequency patch
- Addess suggestion from Jani Nikula
Puthikorn Voravootivat (4):
drm/i915: Add DPCD prefered mode for backlight control
drm/i915: Correctly enable blacklight adjustment via DPCD
drm/i915: Support dynamic backlight via DPCD register
drm
Some panel will default to zero brightness when turning the
panel off and on again. This patch stores last brightness level
before turning off and set them back when panel is turning on.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backl
-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 29 +--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
b/drivers/gpu/drm/i915/intel_dp_aux_backlight.c
This patch enables dynamic backlight by default for eDP
panel that supports this feature via DPCD register and
set minimum / maximum brightness to 0% and 100% of the
normal brightness.
Change-Id: I7140d4e838c654b6527df38b5780ad1533848d6c
Signed-off-by: Puthikorn Voravootivat <put...@chromium.
-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/i915_params.c| 6 ++---
drivers/gpu/drm/i915/i915_params.h| 2 +-
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 33 +++
3 files changed, 27 insertions(+), 14 deletions(-)
Agree that your suggestion is better. I will drop this patch in the
next version of the set.
Thanks
On Thu, Mar 9, 2017 at 2:40 AM, Jani Nikula <jani.nik...@linux.intel.com> wrote:
> On Wed, 08 Mar 2017, Puthikorn Voravootivat <put...@chromium.org> wrote:
>> TCON tend to h
wrote:
> On Wed, 08 Mar 2017, Puthikorn Voravootivat <put...@chromium.org> wrote:
>> Currently the intel_dp_aux_backlight driver requires eDP panel
>> to support these conditions to allow the backlight adjust via
>> dpcd register.
>> 1) DP
TCON tend to have better brightness scaling with lower
PWM frequency. This patch set the divider to highest
value to lower the PWM frequency.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 11 +++
1 file chang
Some panel will default to zero brightness when turning the
panel off and on again. This patch stores last brightness level
before turning off and set them back when panel is turning on.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backl
This patch enables dynamic backlight by default for eDP
panel that supports this feature via DPCD register and
set minimum / maximum brightness to 0% and 100% of the
normal brightness.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backl
display off and on.
Puthikorn Voravootivat (5):
drm/i915: Fix condition check for backlight control via DPCD
drm/i915: Correctly enable blacklight adjustment via DPCD
drm/i915: Support dynamic backlight via DPCD register
drm/i915: Use highest frequency divider for PWM
drm/i915: Store
intel_dp_aux_enable_backlight() assumed that the register
BACKLIGHT_BRIGHTNESS_CONTROL_MODE can only has value 01
(DP_EDP_BACKLIGHT_CONTROL_MODE_PRESET) when initialize.
This patch fixed that by handling all cases of that register.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.
ment
can be done via BL_ENABLE eDP connector pin in the case that
it does not support doing that via AUX.
Signed-off-by: Puthikorn Voravootivat <put...@chromium.org>
---
drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --
101 - 136 of 136 matches
Mail list logo
