[Intel-gfx] [PATCH 0/5] drm/i915: Fix backlight regression caused by misconfigured VBT

2014-06-27 Thread Scot Doyle
commit c675949ec58ca50d5a3ae3c757892f1560f6e896 drm/i915: do not setup backlight if not available according to VBT caused a regression on machines with a misconfigured VBT. Add a quirk to assert the presence of a controllable backlight, overriding the VBT. Then apply this quirk to four

[Intel-gfx] [PATCH 1/5] quirk asserts controllable backlight presence, overriding VBT

2014-06-27 Thread Scot Doyle
Add a quirk to assert the presence of a controllable backlight. Use it to ignore the VBT backlight presence check during backlight setup. Tested-by: James Duley jagdu...@gmail.com Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu

[Intel-gfx] [PATCH 2/5] Acer C720 has a controllable backlight

2014-06-27 Thread Scot Doyle
The Acer C720 laptop has a controllable backlight although its VBT reports otherwise. Tested-by: James Duley jagdu...@gmail.com Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] Dell 11 Chromebook has a controllable backlight

2014-06-27 Thread Scot Doyle
The Dell 11 Chromebook laptop has a controllable backlight although its VBT reports otherwise. Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2855d29

[Intel-gfx] [PATCH 4/5] HP 14 Chromebook has a controllable backlight

2014-06-27 Thread Scot Doyle
The HP 14 (Celeron 2955U) Chromebook laptop has a controllable backlight although its VBT reports otherwise. Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index

[Intel-gfx] [PATCH 5/5] Toshiba CB35 Chromebook has a controllable backlight

2014-06-27 Thread Scot Doyle
The Toshiba CB35 Chromebook laptop has a controllable backlight although its VBT reports otherwise. Patch tested by author on Toshiba CB35. Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu

[Intel-gfx] [PATCH v2 0/3] drm/i915: fix backlight regression caused by misconfigured VBT

2014-06-30 Thread Scot Doyle
Jani, here are the changes you suggested plus: 1) Against newer drm-intel-nightly 2) Added Acer C720P (touchscreen), tested by Michael 3) Removed HP 14 and Dell 11 Chromebooks since no testers yet 4) Clarified these are for the Haswell (Celeron 2955U) boards since upcoming Chromebooks may be

[Intel-gfx] [PATCH v2 1/3] drm/i915: quirk asserts controllable backlight presence, overriding VBT

2014-06-30 Thread Scot Doyle
during backlight setup. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79813 Tested-by: James Duley jagdu...@gmail.com Tested-by: Michael Mullin masmul...@gmail.com Signed-off-by: Scot Doyle lkm...@scotdoyle.com Reviewed-by: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 2/3] drm/i915: Acer C720 and C720P have controllable backlights

2014-06-30 Thread Scot Doyle
...@gmail.com Tested-by: Michael Mullin masmul...@gmail.com Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7b5f193..18089bf 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 3/3] drm/i915: Toshiba CB35 has a controllable backlight

2014-06-30 Thread Scot Doyle
Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 18089bf..b3a99e9 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH v3 0/3] drm/i915: fix backlight regression caused by misconfigured VBT

2014-07-03 Thread Scot Doyle
Submitted with git to correct whitespace problems. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v3 1/3] drm/i915: quirk asserts controllable backlight presence, overriding VBT

2014-07-03 Thread Scot Doyle
during backlight setup. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79813 Tested-by: James Duley jagdu...@gmail.com Tested-by: Michael Mullin masmul...@gmail.com Reviewed-by: Jani Nikula jani.nik...@intel.com Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v3 3/3] drm/i915: Toshiba CB35 has a controllable backlight

2014-07-03 Thread Scot Doyle
Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/intel_display.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7345441..c12a5da 100644

[Intel-gfx] [PATCH v3 2/3] drm/i915: Acer C720 and C720P have controllable backlights

2014-07-03 Thread Scot Doyle
...@gmail.com Tested-by: Michael Mullin masmul...@gmail.com Signed-off-by: Scot Doyle lkm...@scotdoyle.com CC: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/intel_display.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915: Ignore VBT backlight presence check on HP Chromebook 14

2014-07-11 Thread Scot Doyle
. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79813 Signed-off-by: Scot Doyle lkm...@scotdoyle.com Tested-by: Stefan Nagy pub...@stefan-nagy.at Cc: Jani Nikula jani.nik...@intel.com Cc: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/intel_display.c |3 +++ 1 file

[Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-18 Thread Scot Doyle
...@intel.com Signed-off-by: Scot Doyle lkm...@scotdoyle.com --- drivers/gpu/drm/i915/intel_panel.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index 59b028f..8e37444 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-21 Thread Scot Doyle
On Tue, 19 Aug 2014, Daniel Vetter wrote: On Tue, Aug 19, 2014 at 4:07 AM, Scot Doyle lkm...@scotdoyle.com wrote: BIOS or firmware can modify hardware state during suspend/resume, for example on the Toshiba CB35 or Lenovo T400, so log a debug message instead of a warning if the backlight

[Intel-gfx] [PATCH] drm/i915: Ignore VBT backlight presence check on Acer C720 (4005U)

2014-08-21 Thread Scot Doyle
. Signed-off-by: Scot Doyle lkm...@scotdoyle.com Tested-by: Tyler Cleveland siraluca...@openmailbox.org Cc: Jani Nikula jani.nik...@intel.com Cc: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/intel_display.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Render moot context reset and switch with Execlists

2014-08-25 Thread Scot Doyle
On Mon, 25 Aug 2014, Daniel Vetter wrote: On Wed, Aug 20, 2014 at 04:36:05PM +0100, Chris Wilson wrote: On Wed, Aug 20, 2014 at 04:29:24PM +0100, Thomas Daniel wrote: These two functions make no sense in an Logical Ring Context Execlists world. v2: We got rid of lrc_enabled and centralized

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Scot Doyle
On Tue, 26 Aug 2014, Daniel Vetter wrote: On Thu, Aug 21, 2014 at 07:12:59AM +, Scot Doyle wrote: When we enter intel_modeset_setup_hw_state during resume - BLC_PWM_CPU_CTL2 == BLM_PWM_ENABLE - the physical backlight is off Hm, this is actually interesting - we have some other evidence

Re: [Intel-gfx] [PATCH] drm/i915: don't warn if backlight unexpectedly enabled

2014-08-26 Thread Scot Doyle
On Tue, 26 Aug 2014, Daniel Vetter wrote: On Tue, Aug 26, 2014 at 07:33:25PM +0200, Daniel Vetter wrote: Indeed the bios seems to just but gunk into that register. And if we add in all the knobs there's piles of them (you have semi-duplicated backlight registers on hsw on the PCH), so I guess