Re: [Intel-gfx] A wrong DDI encoder override from HDMI to DP at hotplug

2015-11-18 Thread Takashi Iwai
On Wed, 18 Nov 2015 16:38:03 +0100, Ville Syrjälä wrote: > > On Wed, Nov 18, 2015 at 04:23:06PM +0100, Takashi Iwai wrote: > > Hi, > > > > currently a DDI port may register both DP and HDMI and it shares the > > same encoder. The bug we've got a report is abo

Re: [Intel-gfx] A wrong DDI encoder override from HDMI to DP at hotplug

2015-11-18 Thread Takashi Iwai
On Wed, 18 Nov 2015 22:30:32 +0100, Dave Airlie wrote: > > On 19 November 2015 at 02:00, Takashi Iwai wrote: > > On Wed, 18 Nov 2015 16:38:03 +0100, > > Ville Syrjälä wrote: > >> > >> On Wed, Nov 18, 2015 at 04:23:06PM +0100, Takashi Iwai wrote: > >>

Re: [Intel-gfx] [PATCH 1/1] drm/i915/audio: apply SKL codec wake up patch to BXT

2015-11-19 Thread Takashi Iwai
On Thu, 19 Nov 2015 10:09:01 +0100, Jani Nikula wrote: > > On Thu, 19 Nov 2015, Jani Nikula wrote: > > On Thu, 19 Nov 2015, han...@intel.com wrote: > >> From: "Lu, Han" > >> > >> Signed-off-by: Lu, Han > >> > >> diff --git a/drivers/gpu/drm/i915/intel_audio.c > >> b/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH] drm/i915: Don't override output type for DDI HDMI

2015-11-19 Thread Takashi Iwai
915: add DP 1.2 MST support (v0.7)') Cc: # v3.17+ Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 09bdd94ca3ba..d34e64300d66 100644 -

Re: [Intel-gfx] [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

2017-06-21 Thread Takashi Iwai
On Wed, 21 Jun 2017 17:23:57 +0200, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-06-21 16:08:54) > > So back when the i915 power well support landed in > > > > commit 99a2008d0b32d72dfc2a54e7be1eb698dd2e3bd6 > > Author: Wang Xingchao > > Date: Thu May 30 22:07:10 2013 +0800 > > > >

Re: [Intel-gfx] [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

2017-06-26 Thread Takashi Iwai
On Mon, 26 Jun 2017 18:16:30 +0200, Daniel Vetter wrote: > > On Wed, Jun 21, 2017 at 05:30:10PM +0200, Takashi Iwai wrote: > > On Wed, 21 Jun 2017 17:23:57 +0200, > > Chris Wilson wrote: > > > > > > Quoting Daniel Vetter (2017-06-21 16:08:54) > > &g

Re: [Intel-gfx] [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

2017-06-28 Thread Takashi Iwai
On Mon, 26 Jun 2017 19:54:49 +0200, Daniel Vetter wrote: > > On Mon, Jun 26, 2017 at 7:47 PM, Takashi Iwai wrote: > > On Mon, 26 Jun 2017 18:16:30 +0200, > > Daniel Vetter wrote: > >> > >> On Wed, Jun 21, 2017 at 05:30:10PM +0200, Takashi Iwai wrote: >

[Intel-gfx] [REGRESSION 4.12] i915 Oops at intel_fbdev_invalidate()

2017-06-30 Thread Takashi Iwai
fabef825626d7bd05a321e4427fdf31a169b5173 drm/i915: Drop struct_mutex around frontbuffer flushes The band-aid patch below seems fixing it. thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] drm/i915: Fix NULL-dereference at intel_fbdev_invalidate() The commit fabef825626d ("drm/i915: Drop struct_mute

Re: [Intel-gfx] [REGRESSION 4.12] i915 Oops at intel_fbdev_invalidate()

2017-06-30 Thread Takashi Iwai
On Fri, 30 Jun 2017 17:40:43 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2017-06-30 16:38:46) > > Hi, > > > > I hit an Oops with the latest Linus tree (4.12-rc7+) on a HSW machine > > like the following at boot: > > > > BUG: unable to

Re: [Intel-gfx] [PATCH] BUG-REPORT: snd-hda: hacked-together EPROBE_DEFER support

2017-07-04 Thread Takashi Iwai
ix > this we need to disable snd-hda-intel there too. I spotted out a typo in my previous patch that leads to the module reference unbalance. The fix is already in sound.git tree today: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=for-linus&am

Re: [Intel-gfx] sound tree breaks make clean

2017-10-31 Thread Takashi Iwai
On Tue, 31 Oct 2017 10:41:15 +0100, Daniel Vetter wrote: > > Hi all, > > The following commit > > commit 60d4981ccf3603669c8de304619048ad5da707bd > Author: Takashi Iwai > Date: Tue Oct 24 09:15:23 2017 +0200 > > sound: Retire OSS > > > bre

Re: [Intel-gfx] [PATCH 3/3] just some guess work to findout the culprit. If this breaks then we know what do.

2018-02-14 Thread Takashi Iwai
On Wed, 14 Feb 2018 10:06:19 +0100, Kumar, Abhijeet wrote: > > > > On 2/14/2018 2:17 PM, Chris Wilson wrote: > > Quoting Kumar, Abhijeet (2018-02-14 04:53:57) > >> > >> On 2/14/2018 9:36 AM, abhijeet.ku...@intel.com wrote: > >> > >> From: Abhijeet Kumar > >> > >> --- > >> sound/

Re: [Intel-gfx] [PATCH] AWOOGA: Revert "ALSA: hda: Make use of core codec functions to sync power state"

2018-02-12 Thread Takashi Iwai
On Mon, 12 Feb 2018 18:29:53 +0100, Chris Wilson wrote: > > This reverts commit 3b5b899ca67db07a4c4825911072221f99e157e2. > > Fixes: 3b5b899ca67d ("ALSA: hda: Make use of core codec functions to sync > power state") > Cc: Abhijeet Kumar > Cc: Takashi Iwai

Re: [Intel-gfx] [PATCH] AWOOGA: Revert "ALSA: hda: Make use of core codec functions to sync power state"

2018-02-13 Thread Takashi Iwai
On Tue, 13 Feb 2018 08:34:40 +0100, Saarinen, Jani wrote: > > HI, > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of > > Takashi Iwai > > Sent: tiistai 13. helmikuuta 2018 7.11 >

Re: [Intel-gfx] [PATCH] AWOOGA: Revert "ALSA: hda: Make use of core codec functions to sync power state"

2018-02-13 Thread Takashi Iwai
On Tue, 13 Feb 2018 09:26:32 +0100, Saarinen, Jani wrote: > > Hi, > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: tiistai 13. helmikuuta 2018 10.14 > > To: Saarinen, Jani > > Cc: Chris Wilson ; > > intel-gfx@

Re: [Intel-gfx] [PATCH] ALSA: hda: Remove finite loop from snd_hdac_sync_power_state()

2018-02-13 Thread Takashi Iwai
On Tue, 13 Feb 2018 10:09:48 +0100, abhijeet.ku...@intel.com wrote: > > From: Abhijeet Kumar > > Finite loop was causing few igt@pm_rpm tests failure for HSW and BDW. > Thus changing it back to infinite one. This missing the explanation why the finite loop fails. I can guess, but some more deta

Re: [Intel-gfx] [PATCH v2] ALSA: hda: Remove finite loop from snd_hdac_sync_power_state()

2018-02-13 Thread Takashi Iwai
On Tue, 13 Feb 2018 13:47:25 +0100, Chris Wilson wrote: > > Quoting Kumar, Abhijeet (2018-02-13 12:41:42) > > > > > > On 2/13/2018 3:54 PM, abhijeet.ku...@intel.com wrote: > > > > From: Abhijeet Kumar > > > > Finite loop and msleep was causing few igt@pm_rpm tests failure > > for

[Intel-gfx] Panic after S3 resume and modeset with MST

2017-03-27 Thread Takashi Iwai
Hi, the upstream fix a16b7658f4e0d4aec9bc3e75a5f0cc3f7a3a0422 drm/i915: Call intel_dp_mst_resume() before resuming displays seems to trigger a kernel panic when some modeset change happens after S3 resume. The details are found in openSUSE bugzilla, https://bugzilla.suse.com/show_bug.cgi?i

Re: [Intel-gfx] Panic after S3 resume and modeset with MST

2017-03-29 Thread Takashi Iwai
On Mon, 27 Mar 2017 18:02:13 +0200, Takashi Iwai wrote: > > Hi, > > the upstream fix a16b7658f4e0d4aec9bc3e75a5f0cc3f7a3a0422 > drm/i915: Call intel_dp_mst_resume() before resuming displays > > seems to trigger a kernel panic when some modeset change happens after >

Re: [Intel-gfx] Panic after S3 resume and modeset with MST

2017-03-29 Thread Takashi Iwai
On Wed, 29 Mar 2017 15:34:15 +0200, Ville Syrjälä wrote: > > On Wed, Mar 29, 2017 at 03:10:09PM +0200, Takashi Iwai wrote: > > On Mon, 27 Mar 2017 18:02:13 +0200, > > Takashi Iwai wrote: > > > > > > Hi, > > > > > > the upstream fix a16b7

Re: [Intel-gfx] Panic after S3 resume and modeset with MST

2017-03-29 Thread Takashi Iwai
On Thu, 30 Mar 2017 02:24:37 +0200, Lyude Paul wrote: > > On Wed, 2017-03-29 at 15:54 +0200, Takashi Iwai wrote: > > On Wed, 29 Mar 2017 15:34:15 +0200, > > Ville Syrjälä wrote: > > > > > > On Wed, Mar 29, 2017 at 03:10:09PM +0200, Takashi Iwai wrote: > &

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Implement cdclk restrictions based on Azalia BCLK

2017-03-30 Thread Takashi Iwai
On Thu, 30 Mar 2017 13:42:09 +0200, Ville Syrjälä wrote: > > On Wed, Mar 29, 2017 at 09:16:36PM +, Pandiyan, Dhinakaran wrote: > > On Wed, 2017-03-29 at 11:50 +0300, Ville Syrjälä wrote: > > > On Tue, Mar 07, 2017 at 04:12:52PM -0800, Dhinakaran Pandiyan wrote: > > > > According to BSpec, "The

[Intel-gfx] [PATCH] drm/i915: Fix crash after S3 resume with DP MST mode change

2017-03-30 Thread Takashi Iwai
ning. Fixes: a16b7658f4e0 ("drm/i915: Call intel_dp_mst_resume() before resuming displays") Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1029634 Reviewed-by: Lyude Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 d

Re: [Intel-gfx] Panic after S3 resume and modeset with MST

2017-03-30 Thread Takashi Iwai
On Thu, 30 Mar 2017 20:07:42 +0200, Lyude Paul wrote: > > On Thu, 2017-03-30 at 07:55 +0200, Takashi Iwai wrote: > > On Thu, 30 Mar 2017 02:24:37 +0200, > > Lyude Paul wrote: > > > > > > On Wed, 2017-03-29 at 15:54 +0200, Takashi Iwai wrote: > &

Re: [Intel-gfx] Panic after S3 resume and modeset with MST

2017-03-30 Thread Takashi Iwai
On Thu, 30 Mar 2017 22:01:31 +0200, Lyude Paul wrote: > > On Thu, 2017-03-30 at 20:50 +0200, Takashi Iwai wrote: > > > > > Sure, if we get a proper stack dump, we can analyze it somehow.  You > > can use addr2line, or even check objdump output manually. >

Re: [Intel-gfx] [PATCH 0/7] DisplayPort audio support on Cherrytrail

2017-03-30 Thread Takashi Iwai
On Fri, 31 Mar 2017 08:29:55 +0200, Daniel Vetter wrote: > > On Mon, Mar 13, 2017 at 9:33 AM, Daniel Vetter wrote: > > On Tue, Jan 31, 2017 at 10:36:42PM +0100, Takashi Iwai wrote: > >> Hi, > >> > >> the following patches enable DisplayPort Audio on Cherry

Re: [Intel-gfx] [alsa-devel] [PATCH v4 0/3] support DP MST audio

2017-01-10 Thread Takashi Iwai
guys need to merge to i915 tree, feel free to pull from that branch. thanks, Takashi > > Regards, > Libin > > > >-----Original Message- > >From: Takashi Iwai [mailto:ti...@suse.de] > >Sent: Tuesday, December 6, 2016 4:11 PM > >To: Daniel Vetter &g

Re: [Intel-gfx] [alsa-devel] [PATCH v4 0/3] support DP MST audio

2017-01-10 Thread Takashi Iwai
On Tue, 10 Jan 2017 09:45:31 +0100, Yang, Libin wrote: > > Hi Takashi, > > >-Original Message- > >From: Takashi Iwai [mailto:ti...@suse.de] > >Sent: Tuesday, January 10, 2017 4:19 PM > >To: Yang, Libin > >Cc: Daniel Vetter ; intel-gfx > >;

Re: [Intel-gfx] [alsa-devel] [PATCH v4 0/3] support DP MST audio

2017-01-11 Thread Takashi Iwai
On Wed, 11 Jan 2017 08:39:13 +0100, Daniel Vetter wrote: > > On Tue, Jan 10, 2017 at 9:49 AM, Takashi Iwai wrote: > > On Tue, 10 Jan 2017 09:45:31 +0100, > >> >-Original Message----- > >> >From: Takashi Iwai [mailto:ti...@suse.de] > >> >Sent:

Re: [Intel-gfx] [PATCH v5 0/3] support DP MST audio

2017-01-12 Thread Takashi Iwai
On Thu, 12 Jan 2017 09:53:35 +0100, Jani Nikula wrote: > > On Thu, 12 Jan 2017, "Yang, Libin" wrote: > >>-Original Message- > >>From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > >>Sent: Thursday, January 12, 2017 4:19 PM > >>To: Yang, Libin ; intel-gfx@lists.freedesktop.org; > >>vi

Re: [Intel-gfx] [PATCH V3 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T

2017-01-18 Thread Takashi Iwai
On Tue, 10 Jan 2017 06:08:39 +0100, Jerome Anand wrote: > > On Baytrail and Cherrytrail, HDaudio may be fused out or disabled > by the BIOS. This driver enables an alternate path to the i915 > display registers and DMA. > > Although there is no hardware path between i915 display and LPE/SST > aud

Re: [Intel-gfx] [PATCH V3 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

2017-01-18 Thread Takashi Iwai
On Tue, 10 Jan 2017 06:08:40 +0100, Jerome Anand wrote: > > Hdmi audio driver based on the child platform device > created by gfx driver is implemented. > This audio driver is derived from legacy intel > hdmi audio driver. > > The interfaces for interaction between gfx and audio > are updated and

Re: [Intel-gfx] [PATCH V3 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T

2017-01-19 Thread Takashi Iwai
On Thu, 19 Jan 2017 11:39:29 +0100, Anand, Jerome wrote: > > > +void mid_hdmi_audio_signal_event(enum had_event_type event) { > > > + struct hdmi_lpe_audio_ctx *ctx; > > > + > > > + dev_dbg(&hlpe_pdev->dev, "%s: Enter\n", __func__); > > > + > > > + ctx = platform_get_drvdata(hlpe_pdev); > > > + > >

Re: [Intel-gfx] [alsa-devel] [PATCH V3 3/5] ALSA: add Intel HDMI LPE audio driver for BYT/CHT-T

2017-01-19 Thread Takashi Iwai
On Fri, 20 Jan 2017 06:46:05 +0100, Anand, Jerome wrote: > > > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Thursday, January 19, 2017 4:22 PM > > To: Anand, Jerome > > Cc: alsa-de...@alsa-project.org;

Re: [Intel-gfx] [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

2017-01-20 Thread Takashi Iwai
On Fri, 20 Jan 2017 23:22:31 +0100, Jerome Anand wrote: > > + had_ops_v1 = had_ops_v1;/* unused */ Until now I didn't realize that the whole v1 stuff is never used in the current patchset. Will it be ever used in future? If not, can't we clean it up? It's a bunch of codes, includin

Re: [Intel-gfx] [alsa-devel] [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

2017-01-20 Thread Takashi Iwai
On Fri, 20 Jan 2017 17:45:53 +0100, Pierre-Louis Bossart wrote: > > On 1/20/17 5:15 AM, Takashi Iwai wrote: > > On Fri, 20 Jan 2017 23:22:31 +0100, > > Jerome Anand wrote: > >> > >> + had_ops_v1 = had_ops_v1;/* unused */ > > > > Until now I

Re: [Intel-gfx] [PATCH v4 0/5] Add support for Legacy HDMI audio drivers

2017-01-23 Thread Takashi Iwai
On Fri, 20 Jan 2017 23:22:27 +0100, Jerome Anand wrote: > > Legacy (CherryTrail/ Baytrail) HDMI audio drivers added > Legacy hdmi audio-Gfx interaction/ interfacing is updated to use > irq chip framework > > This patch series has only been tested on hardware with > a single HDMI connector/pipe

[Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

2017-01-25 Thread Takashi Iwai
Hi, we've got a bug report about the blank monitor on Cherry Trail machines. And, Intel team (Cc'ed) spotted out that this seems triggered by DPMS transition. A patch like below actually fixes the problem. Of course it doesn't look like a right "fix". Do you guys have any hint for further debu

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

2017-01-25 Thread Takashi Iwai
On Tue, 24 Jan 2017 23:57:48 +0100, Jerome Anand wrote: > > Legacy (CherryTrail/ Baytrail) HDMI audio drivers added > Legacy hdmi audio-Gfx interaction/ interfacing is updated to use > irq chip framework > > This patch series has only been tested on hardware with > a single HDMI connector/pipe

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

2017-01-25 Thread Takashi Iwai
On Wed, 25 Jan 2017 15:45:05 +0100, Jani Nikula wrote: > > On Wed, 25 Jan 2017, Takashi Iwai wrote: > > On Tue, 24 Jan 2017 23:57:48 +0100, > > Jerome Anand wrote: > >> > >> Legacy (CherryTrail/ Baytrail) HDMI audio drivers added > >> Legacy hdmi aud

Re: [Intel-gfx] [PATCH] ALSA: x86: hdmi: fix returnvar.cocci warnings

2017-01-25 Thread Takashi Iwai
On Tue, 24 Jan 2017 17:07:48 +0100, Julia Lawall wrote: > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > CC: Jerome Anand > Signed-off-by: Julia Lawall > Signed-off-by: Fengguang Wu > --- > > In-Reply-To: <20170124225753.9

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

2017-01-25 Thread Takashi Iwai
On Tue, 24 Jan 2017 23:57:48 +0100, Jerome Anand wrote: > > This patch series has only been tested on hardware with > a single HDMI connector/pipe and additional work may be needed for newer > machines with 2 connectors BTW, I have such a machine, CHV with two DP outputs. If you have a test pat

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: setup bridge for HDMI LPE audio driver

2017-01-26 Thread Takashi Iwai
-doc:: drivers/gpu/drm/i915/intel_lpe_audio.c > > > + :doc: LPE Audio integration for HDMI or DP playback > > > + > > > +.. kernel-doc:: drivers/gpu/drm/i915/intel_lpe_audio.c > > > + :internal: > > > + > > Please apply a follow-up patch to mo

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: setup bridge for HDMI LPE audio driver

2017-01-26 Thread Takashi Iwai
On Thu, 26 Jan 2017 11:23:41 +0100, Jani Nikula wrote: > > On Thu, 26 Jan 2017, Takashi Iwai wrote: > > On Thu, 26 Jan 2017 10:21:47 +0100, > > Daniel Vetter wrote: > >> > >> On Tue, Jan 24, 2017 at 03:25:14PM +0200, Jani Nikula wrote: > >&g

Re: [Intel-gfx] [PATCH] ALSA: hda/hdmi: disable KAE for Intel DG2

2023-04-13 Thread Takashi Iwai
On Thu, 13 Apr 2023 21:11:53 +0200, Kai Vehmanen wrote: > > Use of keep-alive (KAE) has resulted in loss of audio on some A750/770 > cards as the transition from keep-alive to stream playback is not > working as expected. As there is limited benefit of the new KAE mode > on discrete cards, revert

Re: [Intel-gfx] [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.

2023-11-14 Thread Takashi Iwai
On Tue, 14 Nov 2023 12:06:45 +0100, Ville Syrjälä wrote: > > On Mon, Oct 02, 2023 at 09:38:44PM +0200, maarten.lankho...@linux.intel.com > wrote: > > From: Maarten Lankhorst > > > > Now that we can use -EPROBE_DEFER, it's no longer required to spin off > > the snd_hdac_i915_init into a workqueu

Re: [Intel-gfx] [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.

2023-11-14 Thread Takashi Iwai
On Tue, 14 Nov 2023 15:39:16 +0100, Maarten Lankhorst wrote: > > > Hey, > > Den 2023-11-14 kl. 14:39, skrev Ville Syrjälä: > > On Tue, Nov 14, 2023 at 02:35:10PM +0200, Jani Nikula wrote: > > On Tue, 14 Nov 2023, Ville Syrjälä > wrote: > > On Mon, Oct 02,

Re: [Intel-gfx] [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.

2023-11-14 Thread Takashi Iwai
On Tue, 14 Nov 2023 14:31:25 +0100, Saarinen, Jani wrote: > > Hi, > > -Original Message- > > From: Maarten Lankhorst > > Sent: Tuesday, November 14, 2023 3:30 PM > > To: Jani Nikula ; Ville Syrjälä > > > > Cc: Takashi Iwai ; int

Re: [Intel-gfx] [PATCH] ALSA: hda: i915: Alays handle -EPROBE_DEFER

2023-11-15 Thread Takashi Iwai
ssion when HDA-intel is loaded before i915. > > Reported-by: Ville Syrjälä > Signed-off-by: Maarten Lankhorst > Tested-by: Kai Vehmanen > Fixes: e6d0c13e9f46 ("ALSA: hda: i915: Remove extra argument from > snd_hdac_i915_init") > Cc: Takashi Iwai >

Re: [Intel-gfx] [PATCH v2 0/3] ALSA: hda/hdmi: i915 keepalive fixes

2022-12-09 Thread Takashi Iwai
On Fri, 09 Dec 2022 11:18:19 +0100, Kai Vehmanen wrote: > > A series with multiple fixes to i915 keepalive (KAE) > functionality. First patch fixes issue that is hit on > some A750/770 cards: > https://gitlab.freedesktop.org/drm/intel/-/issues/7353 > > The two other improve behaviour especially w

Re: [PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-23 Thread Takashi Iwai
On Thu, 22 Feb 2024 21:54:42 +0100, Rodrigo Vivi wrote: > > On Thu, Feb 22, 2024 at 06:53:12PM +0100, Cezary Rojewski wrote: > > On 2024-02-22 6:24 PM, Ville Syrjälä wrote: > > > On Thu, Feb 22, 2024 at 06:06:11PM +0100, Cezary Rojewski wrote: > > > > Commit 78f613ba1efb ("drm/i915: finish removal

Re: [PATCH v2 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-23 Thread Takashi Iwai
On Fri, 23 Feb 2024 12:46:24 +0100, Cezary Rojewski wrote: > > If i915 does not support given platform but the hardware i.e.: HDAudio > codec is still there, the codec-probing procedure will succeed for such > device but the follow up initialization will always end up with -ENODEV. > > While bus

Re: [PATCH v2 0/4] ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-02-23 Thread Takashi Iwai
On Fri, 23 Feb 2024 12:46:22 +0100, Cezary Rojewski wrote: > > A small set of changes to improve initialization of the audio stack on > HDAudio devices and pair of cleanups. > > As the first change is the most important one here, following is the > technical background for it: > > Commit 78f613b

Re: [PATCH v2 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-26 Thread Takashi Iwai
On Fri, 23 Feb 2024 18:09:59 +0100, Cezary Rojewski wrote: > > On 2024-02-23 3:44 PM, Takashi Iwai wrote: > > On Fri, 23 Feb 2024 12:46:24 +0100, > > Cezary Rojewski wrote: > >> > >> If i915 does not support given platform but the hardware i.e.: HDAudio

Re: [PATCH v3 0/5] ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-03-04 Thread Takashi Iwai
On Mon, 26 Feb 2024 13:44:27 +0100, Cezary Rojewski wrote: > > A small set of changes to improve initialization of the audio stack on > HDAudio devices and pair of cleanups. > > As the first change is the most important one here, following is the > technical background for it: > > Commit 78f613b

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Takashi Iwai
.org/ > > Cc: Masami Hiramatsu > Cc: Mathieu Desnoyers > Cc: Linus Torvalds > Cc: Julia Lawall > Signed-off-by: Steven Rostedt (Google) For the sound part Acked-by: Takashi Iwai thanks, Takashi

Re: [Intel-gfx] [PATCH] drm/i915: fix up the edp power well check

2013-05-31 Thread Takashi Iwai
t; > For reference see > > commit 2124b72e6283c4e84a55e71077fee91793f4c801 > Author: Paulo Zanoni > Date: Fri Mar 22 14:07:23 2013 -0300 > > drm/i915: don't disable the power well yet > > Cc: Takashi Iwai Sorry, I have no hardware that showed the proble

Re: [Intel-gfx] [PATCH 1/4] ALSA: hda - Haswell converter power state D0 verify

2013-06-17 Thread Takashi Iwai
At Fri, 14 Jun 2013 23:20:26 +0800, Wang Xingchao wrote: > > Haswell converters maybe in wrong power state before usage. > i.e. only converter 0 is in D0, converter 1/2 are in D3. > When pin choose converter 1/2, there's no audio output. > > Signed-off-by: Wang Xingchao Isn't this needed in hdm

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Add display audio routing API for haswell

2013-06-17 Thread Takashi Iwai
At Fri, 14 Jun 2013 23:20:29 +0800, Wang Xingchao wrote: > > ALSA side use these apis to know display audio routing map > in gfx side. And use the API to disable unused pin's audio output. Adding more and more such exported functions doesn't look scaling. Better to define an ops struct and export

Re: [Intel-gfx] [PATCH] ALSA: hda - Haswell converter power state D0 verify

2013-06-17 Thread Takashi Iwai
At Tue, 18 Jun 2013 10:41:53 +0800, Wang Xingchao wrote: > > Haswell converters maybe in wrong power state before usage. > i.e. only converter 0 is in D0, converter 1/2 are in D3. > When pin choose converter 1/2, there's no audio output, this > cause dependency when playing differnt stream on pins

Re: [Intel-gfx] [PATCH] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Takashi Iwai
At Tue, 18 Jun 2013 16:32:01 +0800, Wang Xingchao wrote: > > For Intel Haswell HDMI codecs, the pins choose converter 0 by default. > This would cause conflict when playing audio on unused pins,the pin with > physical device connected would get audio data too. > i.e. Pin 0/1/2 default choose conve

Re: [Intel-gfx] [PATCH V1] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Takashi Iwai
At Tue, 18 Jun 2013 21:42:14 +0800, Wang Xingchao wrote: > > For Intel Haswell HDMI codecs, the pins choose converter 0 by default. > This would cause conflict when playing audio on unused pins,the pin with > physical device connected would get audio data too. > i.e. Pin 0/1/2 default choose conve

Re: [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-05 Thread Takashi Iwai
r at module init time > >> >> >>- change function name > >> >> >> > >> >> >>change between V2-->V3: > >> >> >>- make SND_HDA_I915 selectable > >> >> >>- use snd_printdd to output mes

Re: [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-08 Thread Takashi Iwai
At Sun, 7 Jul 2013 19:59:33 -0400, Wang xingchao wrote: > > On Sat, Jul 06, 2013 at 08:20:59AM +0200, Takashi Iwai wrote: > > > >> >> > drm-intel-next. I'll show up in the next linux-next and I'll > > > >> >> > forward it t

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
At Wed, 17 Jul 2013 02:52:41 +, Wang, Xingchao wrote: > > Hi Takashi/Paulo, > > > > > would you change it to "auto" and test again. > > > > Runtime power save should be enabled with "auto". > > > > > > Doesn't solve the problem. Should I open a bug report somewhere? > > > Having the power wel

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
At Wed, 17 Jul 2013 08:03:38 +, Wang, Xingchao wrote: > > > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, July 17, 2013 3:34 PM > > To: Wang, Xingchao > > Cc: Paulo Zanoni; alsa-de...@alsa-pro

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
At Wed, 17 Jul 2013 10:31:26 -0300, Paulo Zanoni wrote: > > 2013/7/17 Wang, Xingchao : > > > > > >> -Original Message----- > >> From: Takashi Iwai [mailto:ti...@suse.de] > >> Sent: Wednesday, July 17, 2013 4:18 PM > >> To: Wang, Xingc

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
At Wed, 17 Jul 2013 16:05:43 +0200, David Henningsson wrote: > > On 07/17/2013 04:00 PM, Takashi Iwai wrote: > > At Wed, 17 Jul 2013 10:31:26 -0300, > > Paulo Zanoni wrote: > >> > >> 2013/7/17 Wang, Xingchao : > >>> > >>> > >&

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
#x27;s in active mode, this may cause some > confuse. Yes. In general, such a force-to-suspend-the-active-stream event should happen only when the device is really unavailable, but never be done just for saving power. Takashi > Thanks > --xingchao > > > -----Original Me

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-18 Thread Takashi Iwai
> Cc: Paulo Zanoni; daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; > > Daniel > > Vetter; intel-gfx@lists.freedesktop.org; Wang xingchao; Girdwood, Liam R; > > Jin, > > Gordon; Takashi Iwai; David Henningsson > > Subject: Re: [alsa-devel] [Intel-gfx] [PATCH 0/

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Takashi Iwai
em is that these flags are set. You're trying to implement an "ignore stop-signs on the street if no other cars are running around you" feature in a new auto-cruise system. It would work, but it's not what's accepted in general. (And it makes things complicated and fragi

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Takashi Iwai
At Wed, 24 Jul 2013 13:57:55 +0200, David Henningsson wrote: > > On 07/24/2013 01:33 PM, Wang, Xingchao wrote: > > Yes, I agree. I'm debugging this issue on Ubuntu, not sure it happens on > > other distribution too. > > If it's related to Ubuntu, maybe need check Ubuntu power policy. Does > > an

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Takashi Iwai
At Wed, 24 Jul 2013 13:30:16 +, Wang, Xingchao wrote: > > > > > -Original Message- > > From: Wysocki, Rafael J > > Sent: Wednesday, July 24, 2013 9:15 PM > > To: David Henningsson > > Cc: Wang, Xingchao; Takashi Iwai; Paulo Zanoni; Daniel Vett

[Intel-gfx] [PATCH] drm/i915: dp: increase probe retries

2013-08-06 Thread Takashi Iwai
d fix, increase the number of retries from 5 to 10. This seems enough for our cases. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 26

Re: [Intel-gfx] [PATCH] drm/i915: Cancel outstanding modeset workers before suspend

2013-08-06 Thread Takashi Iwai
> The issue was first raised whilst tackling a suspend issue with Takashi > Iwai (http://lists.freedesktop.org/archives/intel-gfx/2012-April/016738.html) > and then it was independently rediscovered by Chuanshen Lui. > > v2: Rebase for the lost year. > > Signed-off-by: Chris Wil

Re: [Intel-gfx] [PATCH] drm/i915: dp: increase probe retries

2013-08-06 Thread Takashi Iwai
At Tue, 6 Aug 2013 13:51:32 +0100, Chris Wilson wrote: > > On Tue, Aug 06, 2013 at 02:40:24PM +0200, Takashi Iwai wrote: > > We've seen a problem that the DP port on a docking station is often > > not detected properly or misconfigured (no proper native modes) with a &

Re: [Intel-gfx] [RFC] set up an sync channel between audio and display driver (i.e. ALSA and DRM)

2014-05-20 Thread Takashi Iwai
At Tue, 20 May 2014 02:52:19 +, Lin, Mengdong wrote: > > This RFC is based on previous discussion to set up a generic communication > channel between display and audio driver and > an internal design of Intel MCG/VPG HDMI audio driver. It's still an initial > draft and your advice would be a

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Takashi Iwai
At Tue, 18 Feb 2014 12:34:42 +0200, Mika Westerberg wrote: > > On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > > + { > > + .callback = video_set_use_native_backlight, > > + .ident = "HP EliteBook 2013 models", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlet

Re: [Intel-gfx] [PATCH] drm/i915: Undo gtt scratch pte unmapping again

2014-03-26 Thread Takashi Iwai
isable GGTT PTEs on GEN6+ suspend > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64841 > Reported-and-Tested-by: Brad Jackson > Cc: sta...@vger.kernel.org > Cc: Takashi Iwai > Cc: Paulo Zanoni > Cc: Todd Previte > Signed-off-by: Daniel Vetter The commit was the fi

Re: [Intel-gfx] [PATCH] drm/i915: Undo gtt scratch pte unmapping again

2014-03-27 Thread Takashi Iwai
At Thu, 27 Mar 2014 07:55:57 +0100, Daniel Vetter wrote: > > On Thu, Mar 27, 2014 at 7:41 AM, Takashi Iwai wrote: > >> It apparently blows up on some machines. This functionally reverts > >> > >> commit 828c79087cec61eaf4c76bb32c222fbe35ac3930 > >> Aut

Re: [Intel-gfx] [PATCH] drm/i915: Undo gtt scratch pte unmapping again

2014-03-27 Thread Takashi Iwai
At Thu, 27 Mar 2014 07:41:41 +0100, Takashi Iwai wrote: > > At Wed, 26 Mar 2014 20:10:09 +0100, > Daniel Vetter wrote: > > > > It apparently blows up on some machines. This functionally reverts > > > > commit 828c79087cec61eaf4c76bb32c222fbe35ac3930 > > Au

Re: [Intel-gfx] [PATCH v2] drm/i915: move power domain init earlier during system resume

2014-04-02 Thread Takashi Iwai
t; And having a hdmi sink bus would allow us to throw all kinds of crap into > > > a clearly-defined interface, e.g. eld handling, hdcp synchronization, hpd > > > forwarding and all the other fun stuff. > > > > > > So not sure what I should do with this here now. &

Re: [Intel-gfx] [PATCH v2] drm/i915: move power domain init earlier during system resume

2014-04-03 Thread Takashi Iwai
At Thu, 3 Apr 2014 17:23:10 +0200, Daniel Vetter wrote: > > On Wed, Apr 02, 2014 at 02:59:54PM +0200, Takashi Iwai wrote: > > At Tue, 1 Apr 2014 22:26:20 +0200, > > Daniel Vetter wrote: > > > > > > On Tue, Apr 01, 2014 at 09:50:43PM +0300, Imre Deak wrote:

[Intel-gfx] [PATCH] drm/i915: Retry reading DPCD when bogus values are read

2013-11-22 Thread Takashi Iwai
intermittently without plug state changes and even after the first few reads succeeded. As a workaround, add a sanity check for such bogus values and retry reading if it hits. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion

Re: [Intel-gfx] [PATCH] drm/i915: Retry reading DPCD when bogus values are read

2013-11-25 Thread Takashi Iwai
At Mon, 25 Nov 2013 16:47:25 +0100, Daniel Vetter wrote: > > On Fri, Nov 22, 2013 at 09:36:09AM +0100, Takashi Iwai wrote: > > I got kernel WARNINGs frequently on Haswell laptops complaining about > > invalid max DP link bw. With drm.debug=0x0e, it turned out that the &g

Re: [Intel-gfx] [PATCH 05/19] drm/i915: add initial Runtime PM functions

2013-11-29 Thread Takashi Iwai
At Wed, 27 Nov 2013 18:10:30 -0200, Paulo Zanoni wrote: > > From: Paulo Zanoni > > This patch adds the initial infrastructure to allow a Runtime PM > implementation that sets the device to its D3 state. The patch just > adds the necessary callbacks and the initial infrastructure. > > We still d

Re: [Intel-gfx] [PATCH] drm/i915: Retry reading DPCD when bogus values are read

2013-12-04 Thread Takashi Iwai
At Wed, 04 Dec 2013 12:17:03 +0200, Jani Nikula wrote: > > On Fri, 22 Nov 2013, Takashi Iwai wrote: > > I got kernel WARNINGs frequently on Haswell laptops complaining about > > invalid max DP link bw. With drm.debug=0x0e, it turned out that the > > obtained DPCD

Re: [Intel-gfx] [PATCH 05/19] drm/i915: add initial Runtime PM functions

2013-12-08 Thread Takashi Iwai
At Fri, 6 Dec 2013 20:31:04 -0200, Paulo Zanoni wrote: > > 2013/11/29 Takashi Iwai : > > At Wed, 27 Nov 2013 18:10:30 -0200, > > Paulo Zanoni wrote: > >> > >> From: Paulo Zanoni > >> > >> This patch adds the initial infrastructure to allow a

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-01-22 Thread Takashi Iwai
At Wed, 22 Jan 2014 10:45:26 -0500, Rob Clark wrote: > > On Wed, Jan 22, 2014 at 10:20 AM, Daniel Vetter wrote: > > On Wed, Jan 22, 2014 at 10:04:14AM -0500, Rob Clark wrote: > >> sorry to jump into this a bit late, so maybe this was covered already > >> earlier.. > > > > It just started, I've q

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-01-22 Thread Takashi Iwai
gt; > Sent: Tuesday, January 21, 2014 9:11 PM > > > To: Lin, Mengdong > > > Cc: Takashi Iwai (ti...@suse.de); Barnes, Jesse; Zanoni, Paulo R; > > > alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org > > > Subject: Re: Need your advice: Add a

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-01-22 Thread Takashi Iwai
At Thu, 23 Jan 2014 06:35:12 +, Lin, Mengdong wrote: > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Thursday, January 23, 2014 1:19 AM > > To: Daniel Vetter > > Cc: Lin, Mengdong; Barnes, Jesse; Zanoni, Paulo R; >

[Intel-gfx] How to work around zero-initialized BLC_PWM_PCH_CTL2?

2013-08-29 Thread Takashi Iwai
Hi, a new laptop model we've been struggling has some strange hardware configuration. BIOS turns off backlight and skips its initialization when the machine is booted with the lid closed. This leaves BLC_PWM_PCH_CTL2 and other registers uninitialized. Because a proper max brightness value can't

[Intel-gfx] [PATCH] drm/i915: Use proper print format for debug prints

2013-09-09 Thread Takashi Iwai
Replace "%8x" with "%08x". The hex number should be shown with zero stuffed instead of spaces. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.

Re: [Intel-gfx] [PATCH 2/2] [v2] drm/i915: Disable GGTT PTEs on GEN6+ suspend

2013-10-17 Thread Takashi Iwai
At Wed, 16 Oct 2013 18:27:33 +0100, Chris Wilson wrote: > > On Wed, Oct 16, 2013 at 10:06:27AM -0700, Ben Widawsky wrote: > > On Wed, Oct 16, 2013 at 05:58:31PM +0100, Chris Wilson wrote: > > > So clearing the valid bit should result in the GPU reporting errors for > > > delayed accesses, but none

Re: [Intel-gfx] [PATCH 2/2] [v2] drm/i915: Disable GGTT PTEs on GEN6+ suspend

2013-10-17 Thread Takashi Iwai
At Thu, 17 Oct 2013 10:24:07 +0100, Chris Wilson wrote: > > On Thu, Oct 17, 2013 at 09:41:09AM +0200, Takashi Iwai wrote: > > At Wed, 16 Oct 2013 18:27:33 +0100, > > Chris Wilson wrote: > > > > > > On Wed, Oct 16, 2013 at 10:06:27AM -0700, Ben Widawsky wrote

Re: [Intel-gfx] [PATCH] drm/i915: write backlight harder

2013-02-06 Thread Takashi Iwai
At Wed, 6 Feb 2013 11:24:41 +0100, Daniel Vetter wrote: > > 770c12312ad617172b1a65b911d3e6564fc5aca8 is the first bad commit > commit 770c12312ad617172b1a65b911d3e6564fc5aca8 > Author: Takashi Iwai > Date: Sat Aug 11 08:56:42 2012 +0200 > > drm/i915: Fix blank p

Re: [Intel-gfx] [PATCH] Build: Add --disable-tests configure flag to avoid tests build - v2

2013-02-06 Thread Takashi Iwai
and adding more and more tests. > > v2: wait for Ben's spacin fixes and adjusted for new space rules. /spacin/spacing/ ? Reviewed-by: Takashi Iwai Thanks! We can drop one more patch from SLE package now ;) Takashi > > Signed-off-by: Rodrigo Vivi > > Conflicts: >

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-02-11 Thread Takashi Iwai
At Sun, 10 Feb 2013 02:16:14 +0100, David Härdeman wrote: > > On Thu, Feb 07, 2013 at 11:00:13AM +0100, Daniel Vetter wrote: > >On Wed, Feb 06, 2013 at 10:35:33PM +0100, David Härdeman wrote: > >> I'll break etiquette here and include the entire original message below > >> (and top-post!) since I'

Re: [Intel-gfx] Regression: Backlight not coming on after resume.

2013-02-28 Thread Takashi Iwai
At Thu, 28 Feb 2013 17:33:56 +0200, Jani Nikula wrote: > > On Thu, 28 Feb 2013, James Courtier-Dutton wrote: > > Bisect done on tree: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git > > Worked on 3.7. > > Broken on 3.8 > > > > Problem: "Backlight not coming on after resu

[Intel-gfx] [PATCH] Revert "drm/i915: try to train DP even harder"

2013-03-11 Thread Takashi Iwai
commit recovers the framebuffer (but X is still broken by other reasons...) Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f61cb79

<    1   2   3   4   5   6   7   >