[Intel-gfx] [PATCH 2/2] drm/i915: Use the fixed pixel clock for eDP in intel_dp_set_m_n()

2013-03-12 Thread Takashi Iwai
-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 7d250aa..ddbf50f 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/2] Fix eDP breakages on HP Z1 desktop

2013-03-12 Thread Takashi Iwai
Hi, this is a patch series to fix the breakages of eDP output on HP Z1 desktop machine with IvyBridge since 3.6 kernel. The first patch is identical as what I already sent yesterday, reverting a bogus check in the dp train loop. The second one is the patch I cooked today, for using the correct p

[Intel-gfx] [PATCH 1/2] Revert "drm/i915: try to train DP even harder"

2013-03-12 Thread Takashi Iwai
check for the intended purpose of that commit, but let's revert the wrong "fix" at first. Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/

[Intel-gfx] Regression: HSW eDP broken on 3.9-rc[12]

2013-03-14 Thread Takashi Iwai
Hi, I noticed that a Haswell desktop machine with eDP gets only the blank screen on the latest Linus tree. It works fine with 3.8, so it's a regression since 3.9-rc1. Actually, it's not a regression. It's three regressions in a shot! (I had to do painful bisections three times...) c464b2a17c59

Re: [Intel-gfx] [PATCH] Revert "drm/i915: try to train DP even harder"

2013-03-18 Thread Takashi Iwai
At Sun, 17 Mar 2013 22:59:22 +0100, Daniel Vetter wrote: > > On Mon, Mar 11, 2013 at 06:40:16PM +0100, Takashi Iwai wrote: > > This reverts commit 0d71068835e2610576d369d6d4cbf90e0f802a71. > > > > Not only that the commit introduces a bogus check (voltage_tries == 5 &g

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use the fixed pixel clock for eDP in intel_dp_set_m_n()

2013-03-18 Thread Takashi Iwai
At Sun, 17 Mar 2013 23:12:03 +0100, Daniel Vetter wrote: > > On Tue, Mar 12, 2013 at 04:32:28PM +0100, Takashi Iwai wrote: > > The eDP output on HP Z1 is still broken when X is started even after > > fixing the infinite link-train loop. The regression was introduced in

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Revert backlight cargo-culting

2013-03-22 Thread Takashi Iwai
broke the originally fixed > machines again with the new trick. So remove it all and start over. > > References: > http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg18788.html > Cc: Jani Nikula > Cc: Takashi Iwai > Signed-off-by: Daniel Vetter Well, although I f

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Revert backlight cargo-culting

2013-03-22 Thread Takashi Iwai
At Fri, 22 Mar 2013 11:22:57 +0100, Daniel Vetter wrote: > > On Fri, Mar 22, 2013 at 11:13 AM, Daniel Vetter > wrote: > > On Fri, Mar 22, 2013 at 11:00 AM, Takashi Iwai wrote: > >> At Fri, 22 Mar 2013 10:53:41 +0100, > >> Daniel Vetter wrote: > >>

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Revert backlight cargo-culting

2013-03-22 Thread Takashi Iwai
At Fri, 22 Mar 2013 12:22:42 +0100, Daniel Vetter wrote: > > On Fri, Mar 22, 2013 at 11:42 AM, Takashi Iwai wrote: > > At Fri, 22 Mar 2013 11:22:57 +0100, > > Daniel Vetter wrote: > >> On Fri, Mar 22, 2013 at 11:13 AM, Daniel Vetter > >> wrote: > >>

Re: [Intel-gfx] [PATCH] Revert "drm/i915: write backlight harder"

2013-03-22 Thread Takashi Iwai
At Fri, 22 Mar 2013 15:44:46 +0100, Daniel Vetter wrote: > > This reverts commit cf0a6584aa6d382f802f2c3cacac23ccbccde0cd. > > Turns out that cargo-culting breaks systems. Note that we can't revert > further, since > > commit 770c12312ad617172b1a65b911d3e6564fc5a

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Takashi Iwai
Jocelyn > > Cc: Wang, Xingchao; Zanoni, Paulo R; ville.syrj...@linux.intel.com; Lin, > > Mengdong; Girdwood, Liam R; intel-gfx@lists.freedesktop.org; > > alsa-de...@alsa-project.org; Wang Xingchao; Takashi Iwai; Barnes, Jesse; > > Wysocki, Rafael J; Hindman, Gavin > > S

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Takashi Iwai
At Fri, 26 Apr 2013 17:42:07 +0200, Daniel Vetter wrote: > > On Fri, Apr 26, 2013 at 05:12:34PM +0200, Takashi Iwai wrote: > > At Fri, 26 Apr 2013 16:57:08 +0200, > > Daniel Vetter wrote: > > > > > > On Fri, Apr 26, 2013 at 07:53:41AM +, Li, Jocelyn

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Takashi Iwai
At Mon, 29 Apr 2013 08:02:19 -0700, Jesse Barnes wrote: > > On Sat, 27 Apr 2013 13:35:29 +0200 > Daniel Vetter wrote: > > > On Sat, Apr 27, 2013 at 09:20:39AM +, Wang, Xingchao wrote: > > > Let me throw a basic proposal on Audio driver side, please give your > > > comments freely. > > > >

Re: [Intel-gfx] [alsa-devel] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Takashi Iwai
At Fri, 03 May 2013 14:02:04 +0200, David Henningsson wrote: > > On 05/03/2013 10:28 AM, Wang, Xingchao wrote: > > Hi David, > > > > Thank you very much for your draft patch. > > I have some more work on a new patchset, some ideas are from your patch. > > Thanks. > > > Here's a brief introductio

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Takashi Iwai
At Thu, 9 May 2013 11:23:21 +0200, Daniel Vetter wrote: > > 2. On a quick read of the hda driver stuff I don't think the power > well enable/disable places are at the right spot: We force the power > well on whenever the hda codec is used, but we must only do that when > we want to output audio to

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 10:55:46 +0200, Jaroslav Kysela wrote: > > Date 13.5.2013 10:28, David Henningsson wrote: > > On 05/13/2013 09:37 AM, Wang Xingchao wrote: > >> I915 module maybe loaded after snd_hda_intel, the power-well > >> API doesnot exist in such case. This patch intended to avoid > >> lo

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 11:55:14 +, Wang, Xingchao wrote: > > Hi David, > > > > -Original Message- > > From: alsa-devel-boun...@alsa-project.org > > [mailto:alsa-devel-boun...@alsa-project.org] On Behalf Of David Henningsson > > Sent: Monday, May 13, 2013 4:29 PM > > To: Wang Xingchao >

Re: [Intel-gfx] [alsa-devel] [PATCH 1/5] drm/915: Add private api for power well usage

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 15:37:24 +0800, Wang Xingchao wrote: > > Haswell Display audio depends on power well in graphic side, it should > request power well before use it and release power well after use. > I915 will not shutdown power well if it detects audio is using. > This patch protects display a

Re: [Intel-gfx] [alsa-devel] [PATCH 2/5] ALSA: hda - Add external module hda-i915 for power well

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 15:37:25 +0800, Wang Xingchao wrote: > > This new added external module hda_i915 only built in when > gfx i915 module built in. It includes hda_display_power() > api implementation for hda controller driver, which will > ask gfx driver for reqeust/release power well on Intel Ha

Re: [Intel-gfx] [alsa-devel] [PATCH 4/5] ALSA: hda - Fix module dependency with gfx i915

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 15:37:27 +0800, Wang Xingchao wrote: > > hda_i915 has dependency on i915 module, this patch check whether > symbol exist before calling API there. If i915 module not loaded it > will try to load before use. > > Signed-off-by: Wang Xingchao You need to manage the symbols more

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 15:37:28 +0800, Wang Xingchao wrote: > > I915 module maybe loaded after snd_hda_intel, the power-well > API doesnot exist in such case. This patch intended to avoid > loading dependency between snd-hda-intel and i915 module. > > Signed-off-by: Wang Xingchao Hm somehow th

Re: [Intel-gfx] [PATCH 2/2] ALSA: hda - Add power-welll support for haswell HDA

2013-05-14 Thread Takashi Iwai
At Tue, 14 May 2013 19:44:19 +0800, Wang Xingchao wrote: > > For Intel Haswell chip, HDA controller and codec have > power well dependency from GPU side. This patch added support > to request/release power well in audio driver. Power save > feature should be enabled to get runtime power saving. >

Re: [Intel-gfx] [alsa-devel] [PATCH 1/2] drm/915: Add private api for power well usage

2013-05-14 Thread Takashi Iwai
At Tue, 14 May 2013 19:44:18 +0800, Wang Xingchao wrote: > > Haswell Display audio depends on power well in graphic side, it should > request power well before use it and release power well after use. > I915 will not shutdown power well if it detects audio is using. > This patch protects display a

Re: [Intel-gfx] [PATCH 2/2] ALSA: hda - Add power-welll support for haswell HDA

2013-05-15 Thread Takashi Iwai
At Thu, 16 May 2013 03:51:16 +, Wang, Xingchao wrote: > > Hi Takashi, > > Thanks your quick feedback, please see my comments below. > > > -Original Message----- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Tuesday, May 14, 2013 8:15 PM

Re: [Intel-gfx] [PATCH 1/2 V4] i915/drm: Add private api for power well usage

2013-05-21 Thread Takashi Iwai
At Mon, 20 May 2013 19:26:57 +0800, Wang Xingchao wrote: > > Haswell Display audio depends on power well in graphic side, it should > request power well before use it and release power well after use. > I915 will not shutdown power well if it detects audio is using. > This patch protects display a

Re: [Intel-gfx] [PATCH 2/2 V4] ALSA: hda - Add power-welll support for haswell HDA

2013-05-21 Thread Takashi Iwai
At Mon, 20 May 2013 19:26:58 +0800, Wang Xingchao wrote: > > For Intel Haswell chip, HDA controller and codec have > power well dependency from GPU side. This patch added support > to request/release power well in audio driver. Power save > feature should be enabled to get runtime power saving. >

Re: [Intel-gfx] [PATCH 2/2 V4] ALSA: hda - Add power-welll support for haswell HDA

2013-05-21 Thread Takashi Iwai
At Tue, 21 May 2013 10:58:36 +, Wang, Xingchao wrote: > > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Tuesday, May 21, 2013 3:19 PM > > To: Wang Xingchao > > Cc: dan...@ffwll.ch; Girdwood, Liam R; david.hennings

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-22 Thread Takashi Iwai
At Thu, 23 May 2013 01:04:15 +0800, Wang Xingchao wrote: > > The device can support runtime PM no matter whether > it support signal wakeup or not. For some chips like Haswell > which doesnot support PME by default, this patch let haswell > Display HD-A controller enter runtime suspend, and bring

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-22 Thread Takashi Iwai
At Thu, 23 May 2013 01:04:16 +0800, Wang Xingchao wrote: > > There's deadlock when request_module(i915) in azx_probe. > It looks like: > device_lock(audio pci device) -> azx_probe -> module_request > (or symbol_request) -> modprobe (userspace) -> i915 init -> > drm_pci_init -> pci_register_driver

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-22 Thread Takashi Iwai
At Thu, 23 May 2013 09:51:07 +0800, Wang Xingchao wrote: > > There's deadlock when request_module(i915) in azx_probe. > It looks like: > device_lock(audio pci device) -> azx_probe -> module_request > (or symbol_request) -> modprobe (userspace) -> i915 init -> > drm_pci_init -> pci_register_driver

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 07:53:00 +, Wang, Xingchao wrote: > > Hi Takashi, > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Thursday, May 23, 2013 2:03 PM > > To: Wang Xingchao > > Cc: dan...@ffwll.ch; als

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 10:19:27 +, Wang, Xingchao wrote: > > Hi Takashi, > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Thursday, May 23, 2013 2:49 PM > > To: Wang Xingchao > > Cc: alsa-de...@alsa-proje

Re: [Intel-gfx] [alsa-devel] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 14:34:09 +0200, David Henningsson wrote: > > On 05/22/2013 07:04 PM, Wang Xingchao wrote: > > The device can support runtime PM no matter whether > > it support signal wakeup or not. For some chips like Haswell > > which doesnot support PME by default, this patch let haswell >

Re: [Intel-gfx] [PATCH 1/4 V5] i915/drm: Add private api for power well usage

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 01:04:13 +0800, Wang Xingchao wrote: > > Haswell Display audio depends on power well in graphic side, it should > request power well before use it and release power well after use. > I915 will not shutdown power well if it detects audio is using. > This patch protects display a

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-24 Thread Takashi Iwai
At Thu, 23 May 2013 19:41:58 +0200, David Henningsson wrote: > > On 05/23/2013 12:29 PM, Wang, Xingchao wrote: > > > > > >> -Original Message----- > >> From: Takashi Iwai [mailto:ti...@suse.de] > >> Sent: Thursday, May 23, 2013 6:27 PM > >&

[Intel-gfx] Broken LVDS output at mode changes

2012-03-28 Thread Takashi Iwai
Hi, we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the LVDS is turned off once. And, there is no signficant difference betw

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Takashi Iwai
At Thu, 29 Mar 2012 14:51:32 +0200, Daniel Vetter wrote: > > On Thu, Mar 29, 2012 at 01:44:28PM +0100, Chris Wilson wrote: > > On Thu, 29 Mar 2012 14:16:38 +0200, Daniel Vetter wrote: > > > On Wed, Mar 28, 2012 at 03:29:04PM +0200, Takashi Iwai wrote: > > >

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Takashi Iwai
At Thu, 29 Mar 2012 08:07:05 -0700, Keith Packard wrote: > > On Thu, 29 Mar 2012 13:44:28 +0100, Chris Wilson > wrote: > > > In conjunction with bits Power Sequence Progress field and Power Cycle > > Delay Active, this bit set to a one indicates that the panel is > > currently powered up or is

Re: [Intel-gfx] Broken LVDS output at mode changes

2012-03-29 Thread Takashi Iwai
At Thu, 29 Mar 2012 09:57:41 -0700, Keith Packard wrote: > > <#part sign=pgpmime> > On Thu, 29 Mar 2012 18:12:56 +0200, Takashi Iwai wrote: > > > The strange thing is that, although you can recover the display by > > turning off LVDS and on again once when the pro

Re: [Intel-gfx] [PATCH] drm/edid: Adding common CVT inferred modes when monitor allows range limited ones trough EDID.

2012-04-12 Thread Takashi Iwai
At Wed, 11 Apr 2012 21:59:28 -0300, Rodrigo Vivi wrote: > > There are many bugs open on fd.o regarding missing modes that are supported > on Windows and other closed source drivers. > >From EDID spec we can (might?) infer modes using GTF and CVT when monitor > >allows it trough range limited fla

Re: [Intel-gfx] [PATCH] drm/edid: Adding common CVT inferred modes when monitor allows range limited ones trough EDID.

2012-04-13 Thread Takashi Iwai
At Fri, 13 Apr 2012 10:14:46 -0400, Adam Jackson wrote: > > On 4/12/12 7:09 PM, Rodrigo Vivi wrote: > > >> CVT monitors _must_ accept GTF as well, EDID says so. So functionally > >> there's nothing wrong with the existing code. > > > > Actually the current code just check for gtf flag... so if a

Re: [Intel-gfx] [PATCH] drm/edid: Adding common CVT inferred modes when monitor allows range limited ones trough EDID.

2012-04-13 Thread Takashi Iwai
At Fri, 13 Apr 2012 15:35:04 +0100, Dave Airlie wrote: > > > I don't think we need to support all wild modes, too.  But the _very_ > > common modes like 1366x768 and 1600x900 should be really supported as > > default. > > You guys still haven't answered the basic question, what HW is this broken?

Re: [Intel-gfx] [PATCH] drm/edid: Adding common CVT inferred modes when monitor allows range limited ones trough EDID.

2012-04-13 Thread Takashi Iwai
At Fri, 13 Apr 2012 10:55:16 -0400, Adam Jackson wrote: > > On 4/13/12 10:29 AM, Takashi Iwai wrote: > > At Fri, 13 Apr 2012 10:14:46 -0400, > > Adam Jackson wrote: > >> Yeah, that's a bug. That's why I said it should be renamed > >> drm_dmt_modes_

Re: [Intel-gfx] [PATCH] drm/edid: Adding common CVT inferred modes when monitor allows range limited ones trough EDID.

2012-04-13 Thread Takashi Iwai
At Fri, 13 Apr 2012 11:30:01 -0400, Alex Deucher wrote: > > On Fri, Apr 13, 2012 at 11:13 AM, Takashi Iwai wrote: > > At Fri, 13 Apr 2012 15:35:04 +0100, > > Dave Airlie wrote: > >> > >> > I don't think we need to support all wild modes, too.  But the

Re: [Intel-gfx] [PATCH] drm/edid: Adding common CVT inferred modes when monitor allows range limited ones trough EDID.

2012-04-13 Thread Takashi Iwai
At Fri, 13 Apr 2012 12:31:25 -0400, Adam Jackson wrote: > > On 4/13/12 11:41 AM, Takashi Iwai wrote: > > At Fri, 13 Apr 2012 11:30:01 -0400, Alex Deucher wrote: > >> One thing to be careful of is that some monitors (especially LCD > >> panels) don't like mod

Re: [Intel-gfx] [PATCH 09/12] drm/edid: Update range descriptor struct for EDID 1.4

2012-04-17 Thread Takashi Iwai
At Fri, 13 Apr 2012 16:33:37 -0400, Adam Jackson wrote: > > Signed-off-by: Adam Jackson > --- > include/drm/drm_edid.h | 26 -- > 1 files changed, 20 insertions(+), 6 deletions(-) > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index bcb9a66..8cefbbe

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-17 Thread Takashi Iwai
At Fri, 13 Apr 2012 16:56:26 -0400, Adam Jackson wrote: > > On 4/13/12 4:33 PM, Adam Jackson wrote: > > Incorporates some feedback from Rodrigo and Takashi. Major themes of the > > series: > > > > - Fix the DMT list to include reduced-blanking modes > > - Add modes from DMT for any range descript

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-17 Thread Takashi Iwai
At Fri, 13 Apr 2012 16:33:28 -0400, Adam Jackson wrote: > > Incorporates some feedback from Rodrigo and Takashi. Major themes of the > series: > > - Fix the DMT list to include reduced-blanking modes > - Add modes from DMT for any range descriptor type > - Add an extra modes list for things not

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-17 Thread Takashi Iwai
At Tue, 17 Apr 2012 17:33:17 +0200, Takashi Iwai wrote: > > At Fri, 13 Apr 2012 16:33:28 -0400, > Adam Jackson wrote: > > > > Incorporates some feedback from Rodrigo and Takashi. Major themes of the > > series: > > > > - Fix the DMT list to include redu

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-19 Thread Takashi Iwai
At Tue, 17 Apr 2012 17:26:26 +0200, Takashi Iwai wrote: > > At Fri, 13 Apr 2012 16:56:26 -0400, > Adam Jackson wrote: > > > > On 4/13/12 4:33 PM, Adam Jackson wrote: > > > Incorporates some feedback from Rodrigo and Takashi. Major themes of the > > > se

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 14:03:58 +0200, Takashi Iwai wrote: > > At Tue, 17 Apr 2012 17:26:26 +0200, > Takashi Iwai wrote: > > > > At Fri, 13 Apr 2012 16:56:26 -0400, > > Adam Jackson wrote: > > > > > > On 4/13/12 4:33 PM, Adam Jackson wrote: > &

[Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
patch adds a flag to disable the hotplug during PM operation for avoiding such a race. Cc: Signed-off-by: Takashi Iwai --- It's a pretty simplistic solution that just ignores the hotplug work. We may keep some pending flag and process it later, if ignoring the event matters... drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 17:22:47 +0100, Chris Wilson wrote: > > On Thu, 19 Apr 2012 18:10:18 +0200, Takashi Iwai wrote: > > The hotplug work can be still kicked off via irq during PM, and this > > may conflict with the resume procedure. For example, eDP on SNB > > machine

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 18:29:47 +0200, Daniel Vetter wrote: > > On Thu, Apr 19, 2012 at 06:10:18PM +0200, Takashi Iwai wrote: > > The hotplug work can be still kicked off via irq during PM, and this > > may conflict with the resume procedure. For example, eDP on SNB > > ma

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 13:55:04 -0400, Adam Jackson wrote: > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > > > This patch adds a flag to disable the hotplug during PM operation for > > avoiding such a race. > > > > Cc: > > Signed-off-by

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-20 Thread Takashi Iwai
At Fri, 20 Apr 2012 13:04:42 +0100, Dave Airlie wrote: > > On Thu, Apr 19, 2012 at 1:03 PM, Takashi Iwai wrote: > > At Tue, 17 Apr 2012 17:26:26 +0200, > > Takashi Iwai wrote: > >> > >> At Fri, 13 Apr 2012 16:56:26 -0400, > >> Adam Jackson wrote: &

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-20 Thread Takashi Iwai
At Fri, 20 Apr 2012 13:05:48 +0100, Dave Airlie wrote: > > On Thu, Apr 19, 2012 at 3:58 PM, Takashi Iwai wrote: > > At Thu, 19 Apr 2012 14:03:58 +0200, > > Takashi Iwai wrote: > >> > >> At Tue, 17 Apr 2012 17:26:26 +0200, > >> Takashi Iwai wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-25 Thread Takashi Iwai
At Thu, 19 Apr 2012 20:11:53 +0200, Takashi Iwai wrote: > > At Thu, 19 Apr 2012 13:55:04 -0400, > Adam Jackson wrote: > > > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > > > > > This patch adds a flag to disable the hotplug during PM oper

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-09 Thread Takashi Iwai
At Wed, 25 Apr 2012 10:14:51 +0200, Takashi Iwai wrote: > > At Thu, 19 Apr 2012 20:11:53 +0200, > Takashi Iwai wrote: > > > > At Thu, 19 Apr 2012 13:55:04 -0400, > > Adam Jackson wrote: > > > > > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wr

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Takashi Iwai
At Thu, 10 May 2012 10:29:19 +0200, Daniel Vetter wrote: > > On Thu, May 10, 2012 at 08:34:43AM +0200, Takashi Iwai wrote: > > At Wed, 25 Apr 2012 10:14:51 +0200, > > Takashi Iwai wrote: > > > > > > At Thu, 19 Apr 2012 20:11:53 +0200, > > > Takash

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Takashi Iwai
At Thu, 10 May 2012 11:06:46 +0200, Daniel Vetter wrote: > > On Thu, May 10, 2012 at 10:40:52AM +0200, Takashi Iwai wrote: > > At Thu, 10 May 2012 10:29:19 +0200, > > Daniel Vetter wrote: > > > > > > On Thu, May 10, 2012 at 08:34:43AM +0200, Takashi Iwai wrot

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-05-10 Thread Takashi Iwai
At Thu, 10 May 2012 10:25:44 +0100, Chris Wilson wrote: > > On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai wrote: > > At Thu, 10 May 2012 11:06:46 +0200, > > Daniel Vetter wrote: > > > This patch is not just for hotplug, but for all the delayed work and timer >

Re: [Intel-gfx] [PATCH] drm/i915: cache the EDID for eDP panels

2012-06-06 Thread Takashi Iwai
At Tue, 5 Jun 2012 16:54:27 -0400, Jesse Barnes wrote: > > They aren't going anywhere, and probing on DDC can cause the panel to > blank briefly, so read them up front and cache them for later queries. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_dp.c | 43 > ++

[Intel-gfx] [PATCH] drm/i915: Fix eDP blank screen after S3 resume on HP desktops

2012-06-20 Thread Takashi Iwai
ister write restores the backlight gracefully. Tested with 3.5-rc3 kernel. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49233 Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_drv.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/driver

Re: [Intel-gfx] [PATCH] drm/i915: Fix eDP blank screen after S3 resume on HP desktops

2012-06-20 Thread Takashi Iwai
At Wed, 20 Jun 2012 10:05:12 +0200, Daniel Vetter wrote: > > On Wed, Jun 20, 2012 at 09:17:41AM +0200, Takashi Iwai wrote: > > This patch fixes the problem on some HP desktop machines with eDP > > which give blank screens after S3 resume. > > > > The problem looks

Re: [Intel-gfx] [PATCH] drm/i915: Fix eDP blank screen after S3 resume on HP desktops

2012-06-20 Thread Takashi Iwai
At Wed, 20 Jun 2012 11:36:51 +0200, Daniel Vetter wrote: > > On Wed, Jun 20, 2012 at 11:21:11AM +0200, Takashi Iwai wrote: > > At Wed, 20 Jun 2012 10:05:12 +0200, > > Daniel Vetter wrote: > > > > > > On Wed, Jun 20, 2012 at 09:17:41AM +0200, Takashi Iwai

Re: [Intel-gfx] [PATCH] drm/i915: Fix eDP blank screen after S3 resume on HP desktops

2012-06-21 Thread Takashi Iwai
At Wed, 20 Jun 2012 11:39:51 +0200, Takashi Iwai wrote: > > At Wed, 20 Jun 2012 11:36:51 +0200, > Daniel Vetter wrote: > > > > On Wed, Jun 20, 2012 at 11:21:11AM +0200, Takashi Iwai wrote: > > > At Wed, 20 Jun 2012 10:05:12 +0200, > > > Daniel Vetter wrote

Re: [Intel-gfx] [PATCH] drm/i915: Fix eDP blank screen after S3 resume on HP desktops

2012-06-21 Thread Takashi Iwai
At Thu, 21 Jun 2012 14:33:07 +0200, Daniel Vetter wrote: > > On Thu, Jun 21, 2012 at 02:11:50PM +0200, Takashi Iwai wrote: > > At Wed, 20 Jun 2012 11:39:51 +0200, > > Takashi Iwai wrote: > > > > > > At Wed, 20 Jun 2012 11:36:51 +0200, > > > Daniel

[Intel-gfx] [PATCH v2] drm/i915: Fix eDP blank screen after S3 resume on HP desktops

2012-06-21 Thread Takashi Iwai
https://bugs.freedesktop.org/show_bug.cgi?id=49233 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/i915_suspend.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c index 0ede02a..a748e5c 100644

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-06-27 Thread Takashi Iwai
At Tue, 26 Jun 2012 15:08:32 -0400, Giacomo Comes wrote: > > I have a dell latitude E6420 with Sandybridge Mobile (GT2). > Since I got it (about one year ago), it has been a nightmare to run linux on > it. > At the beginning I installed openSUSE 11.4 (kernel 2.6.37.6) and the laptop > would freez

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Takashi Iwai
At Thu, 28 Jun 2012 14:23:04 -0400, Giacomo Comes wrote: > > On Thu, Jun 28, 2012 at 07:52:18AM +0200, Takashi Iwai wrote: > > At Tue, 26 Jun 2012 15:08:32 -0400, > > Giacomo Comes wrote: > > > > > > I have a dell latitude E6420 with Sandybridge Mobile (GT2).

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Takashi Iwai
ashi > > Kind regards, > Georg > > On Mon, Jul 2, 2012 at 10:18 AM, Takashi Iwai wrote: > > At Thu, 28 Jun 2012 14:23:04 -0400, > > Giacomo Comes wrote: > >> > >> On Thu, Jun 28, 2012 at 07:52:18AM +0200, Takashi Iwai wrote: > >> > At Tue,

Re: [Intel-gfx] Trouble with dell latitude E6420

2012-07-02 Thread Takashi Iwai
> What comes to my mind reading your message - why should dual channel > on HD+ be treated differently than on panels with lower resolution? I have no answer to "why", too. It's just my wild guess. Only panel vendors know... Takashi > > Kind regards, > Georg >

[Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Takashi Iwai
x27;t give any visible drawback on machines I've tested, enable it generically for HD+ panels for SCH-split case. Tested-by: Giacomo Comes Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_lvds.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-)

Re: [Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Takashi Iwai
At Mon, 2 Jul 2012 18:53:29 +0200, Daniel Vetter wrote: > > On Mon, Jul 02, 2012 at 06:14:54PM +0200, Takashi Iwai wrote: > > Some SNB/IVY Laptops with 1600x900 HD+ panel (e.g. Dell Latitude E6420 > > and HP ProBook 65xx) are known to show the whole black/white garbage > &g

Re: [Intel-gfx] [PATCH] drm/i915: Disable LVDS while modesetting for HD+ panels

2012-07-02 Thread Takashi Iwai
At Mon, 2 Jul 2012 19:55:17 +0200, Daniel Vetter wrote: > > On Mon, Jul 2, 2012 at 7:51 PM, Takashi Iwai wrote: > > It's just for avoiding the possible regressions by this change. > > We definitely need a fix for HD+ panels ASAP, while other panels work > > in the c

Re: [Intel-gfx] [PATCH 09/81] drm/i915/lvds: ditch ->prepare special case

2012-07-22 Thread Takashi Iwai
easier and just rip it out. > > > > Also note that this seems to fix actual bugs with enabling the lvds > > output, see: > > > > http://lists.freedesktop.org/archives/intel-gfx/2012-July/018614.html > > > > Cc: Takashi Iwai > > Cc: Giacomo Come

Re: [Intel-gfx] [PATCH V2 4/4] ALSA HDA: Force HDMI pins enabled

2012-07-31 Thread Takashi Iwai
At Tue, 31 Jul 2012 10:47:05 +0800, Wang Xingchao wrote: > > There's one issue for HDMI pins, even the related pin will be enabled > when the stream is active but the GPU registers show the PIN is not in > active state, so we force all pins in active state and donot close it > when the stream is c

Re: [Intel-gfx] [PATCH V2 4/4] ALSA HDA: Force HDMI pins enabled

2012-08-01 Thread Takashi Iwai
At Wed, 1 Aug 2012 00:27:02 +, Wang, Xingchao wrote: > > Hi Takashi, > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Tuesday, July 31, 2012 7:18 PM > > To: Wang, Xingchao > > Cc: intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [PATCH v4 0/3] Haswell HDMI/DP audio enable

2012-08-06 Thread Takashi Iwai
At Mon, 6 Aug 2012 18:43:57 +0800, Wang Xingchao wrote: > > This patch series enable HDMI audio on Haswell platform, not DP audio. > The DP enablement will come after the DP patches are upstream. > > I tested this patch on Sharkbay machine and i could hear clear sound from > HDMI port. > > V2 p

Re: [Intel-gfx] HD audio not working

2012-08-08 Thread Takashi Iwai
At Wed, 08 Aug 2012 00:33:56 +0200, Øyvind Kvålsvoll wrote: > > Ref. to filed bug https://bugs.freedesktop.org/show_bug.cgi?id=49055: > > DTS-HD and Dolby TrueHD audio is not working in Intel Sandy Bridge. > This must have been well known for quite some time now, and I consider > this to be a se

Re: [Intel-gfx] HD audio not working

2012-08-09 Thread Takashi Iwai
anks, Takashi > > > Øyvind Kvålsvoll > (+47) 41306243 > N-6008 Ålesund, Norway > > > On 08.08.2012 09:31, Takashi Iwai wrote: > > At Wed, 08 Aug 2012 00:33:56 +0200, > > Øyvind Kvålsvoll wrote: > >> Ref. to filed bug https://bugs.freedesktop.org/show_bug.

Re: [Intel-gfx] [alsa-devel] [PATCH v2] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug unconditionally

2012-09-13 Thread Takashi Iwai
At Thu, 13 Sep 2012 11:19:00 +0800, Wang Xingchao wrote: > > Clear Audio Enable bit to trigger unsolicated event to notify Audio > Driver part the HDMI hot plug change. The patch fixed the bug when > remove HDMI cable the bit was not cleared correctly. > > In intel_enable_hdmi(), if intel_hdmi->h

Re: [Intel-gfx] [alsa-devel] [PATCH v2] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug unconditionally

2012-09-13 Thread Takashi Iwai
At Thu, 13 Sep 2012 21:53:12 +0800, Wang Xingchao wrote: > > Hi Takashi, > > 2012/9/13 Takashi Iwai : > > At Thu, 13 Sep 2012 11:19:00 +0800, > > Wang Xingchao wrote: > >> > >> Clear Audio Enable bit to trigger unsolicated event to notify Audio >

Re: [Intel-gfx] [alsa-devel] [PATCH v2] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug unconditionally

2012-09-13 Thread Takashi Iwai
At Thu, 13 Sep 2012 16:18:08 +0200, Daniel Vetter wrote: > > On Thu, Sep 13, 2012 at 4:00 PM, Takashi Iwai wrote: > > But, this makes me wonder why this patch can't go into 3.6. It's a > > clear bug and the fix is trivial. > > > > Daniel, isn't it

[Intel-gfx] Valid DP connection without EDID?

2012-09-14 Thread Takashi Iwai
Hi, we've got a machine showing a ghost DP2 output on a docking station. The docking station has only one DP port and it's connected to DP1. As a result, we get an DP2 active output containing the bogus VESA standard modes 1024x768, 800x600, 640x480 although it's not connected at all. Looking a b

Re: [Intel-gfx] Valid DP connection without EDID?

2012-09-17 Thread Takashi Iwai
Hi Adam, At Fri, 14 Sep 2012 11:25:03 -0400, Adam Jackson wrote: > > On 9/14/12 10:19 AM, Takashi Iwai wrote: > > Hi, > > > > we've got a machine showing a ghost DP2 output on a docking station. > > The docking station has only one DP port and it's conn

Re: [Intel-gfx] Valid DP connection without EDID?

2012-09-17 Thread Takashi Iwai
At Mon, 17 Sep 2012 18:21:47 +1000, Dave Airlie wrote: > > On Mon, Sep 17, 2012 at 6:16 PM, Takashi Iwai wrote: > > Hi Adam, > > > > At Fri, 14 Sep 2012 11:25:03 -0400, > > Adam Jackson wrote: > >> > >> On 9/14/12 10:19 AM, Takashi Iwai wrote: >

Re: [Intel-gfx] Valid DP connection without EDID?

2012-09-17 Thread Takashi Iwai
At Mon, 17 Sep 2012 19:11:34 +1000, Dave Airlie wrote: > > On Mon, Sep 17, 2012 at 6:28 PM, Takashi Iwai wrote: > > At Mon, 17 Sep 2012 18:21:47 +1000, > > Dave Airlie wrote: > >> > >> On Mon, Sep 17, 2012 at 6:16 PM, Takashi Iwai wrote: > >> >

Re: [Intel-gfx] Valid DP connection without EDID?

2012-09-18 Thread Takashi Iwai
At Mon, 17 Sep 2012 12:24:36 -0400, Adam Jackson wrote: > > On Mon, 2012-09-17 at 11:32 +0200, Takashi Iwai wrote: > > At Mon, 17 Sep 2012 19:11:34 +1000, > > Dave Airlie wrote: > > > On Mon, Sep 17, 2012 at 6:28 PM, Takashi Iwai wrote: > > > > At Mon, 1

Re: [Intel-gfx] Valid DP connection without EDID?

2012-09-18 Thread Takashi Iwai
At Tue, 18 Sep 2012 10:04:33 -0400, Adam Jackson wrote: > > On Tue, 2012-09-18 at 13:01 +0200, Takashi Iwai wrote: > > > > I started a patch series for this a bit ago, I'll send it on > > > momentarily. > > > > Thanks! I evaluated it now (with a ty

Re: [Intel-gfx] Valid DP connection without EDID?

2012-09-18 Thread Takashi Iwai
At Tue, 18 Sep 2012 10:48:11 -0400, Adam Jackson wrote: > > On Tue, 2012-09-18 at 16:32 +0200, Takashi Iwai wrote: > > > Woohoo, the patch works! > > \o/ > > > Could you brush up and resend the patches for merging to 3.7 kernel? > > Or, would you like to f

[Intel-gfx] [PATCH] drm/i915: Re-enable mt forcewake check for IVB

2012-11-15 Thread Takashi Iwai
Some IVB machines seem to need non-MT forcewake. Using MT forcewake on such machines result in broken or blank screens. Signed-off-by: Takashi Iwai --- The commit 36ec8f877481449bdfa072e6adf2060869e2b970 triggered a regression on my test IVY laptops. Instead of reverting the commit, I cooked a

Re: [Intel-gfx] [PATCH] drm/i915: Re-enable mt forcewake check for IVB

2012-11-15 Thread Takashi Iwai
At Thu, 15 Nov 2012 21:07:33 +0100, Daniel Vetter wrote: > > On Thu, Nov 15, 2012 at 6:03 PM, Takashi Iwai wrote: > > Some IVB machines seem to need non-MT forcewake. Using MT forcewake > > on such machines result in broken or blank screens. > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915: Re-enable mt forcewake check for IVB

2012-11-16 Thread Takashi Iwai
At Thu, 15 Nov 2012 21:22:41 +0100, Takashi Iwai wrote: > > At Thu, 15 Nov 2012 21:07:33 +0100, > Daniel Vetter wrote: > > > > On Thu, Nov 15, 2012 at 6:03 PM, Takashi Iwai wrote: > > > Some IVB machines seem to need non-MT forcewake. Using MT forcewake > >

[Intel-gfx] [PATCH] drm/i915: Enable DP audio for Haswell

2012-11-16 Thread Takashi Iwai
This patch adds the missing code to send ELD for Haswell DisplayPort, based on Xingchao's original patch. A test was performed with HSW-D machine and NEC EA232Wmi DP monitor. Cc: Xingchao Wang Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/intel_ddi.c | 9 + 1 file chang

Re: [Intel-gfx] [PATCH] drm/i915: Enable DP audio for Haswell

2012-11-19 Thread Takashi Iwai
i.c:672:7: note: each undeclared > identifier is reported only once for each function it appears in > make[4]: ** [drivers/gpu/drm/i915/intel_ddi.o] Erro 1 Doh, sorry, I posted a version before refreshing. Will submit the right one soon. > 2012/11/16 Takashi Iwai : > > This patch a

[Intel-gfx] [PATCH v2] drm/i915: Enable DP audio for Haswell

2012-11-19 Thread Takashi Iwai
This patch adds the missing code to send ELD for Haswell DisplayPort, based on Xingchao's original patch. A test was performed with HSW-D machine and NEC EA232Wmi DP monitor. Cc: Xingchao Wang Signed-off-by: Takashi Iwai --- v1->v2: Fixed a typo drivers/gpu/drm/i915/intel_d

[Intel-gfx] [PATCH] drm/i915: Fix garbage pixels on top of LVDS on IVY laptop

2012-12-07 Thread Takashi Iwai
minimum part for fixing this regression, namely, the setup of CHICKEN2 bit in cpt_init_clock_gating(). Signed-off-by: Takashi Iwai --- Don't ask me why this fixes :) The bug is still present in drm-intel-next-queued as of today, at least. Let me know if a better workaround is avai

Re: [Intel-gfx] [PATCH] drm/i915: Fix garbage pixels on top of LVDS on IVY laptop

2012-12-07 Thread Takashi Iwai
At Fri, 7 Dec 2012 16:47:05 +0100, Daniel Vetter wrote: > > On Fri, Dec 7, 2012 at 2:17 PM, Takashi Iwai wrote: > > The commit [23670b322: drm/i915: CPT+ pch transcoder workaround] > > caused a regression on some HP laptops with IvyBridge. On the top of > > laptop scr

<    1   2   3   4   5   6   7   >