Re: [Intel-gfx] [PATCH] drm/i915: Ensure proper HDA suspend/resume ordering with a device link

2018-10-18 Thread Takashi Iwai
robing create the link with DL_FLAG_STATELESS. Since the > probe time ordering has to be optional we use the component framework > for that. > > Cc: Ville Syrjälä > Cc: Takashi Iwai > Signed-off-by: Imre Deak This looks like a good idea! thanks, Takashi > --- > d

Re: [Intel-gfx] [PATCH 1/2] ALSA: x86: Fix runtime PM for hdmi-lpe-audio

2018-11-02 Thread Takashi Iwai
broke runtime PM with lpe audio. We can no longer > > runtime suspend the GPU since the sysfs power/control for the > > lpe-audio device no longer exists and the device is considered > > always active. We can fix this by not marking the device as > > active. > > >

Re: [Intel-gfx] Timing issues between ALSA and i915 drivers

2019-01-16 Thread Takashi Iwai
On Wed, 16 Jan 2019 18:48:25 +0100, Pierre-Louis Bossart wrote: > > Hi, > > I could use some feedback on HDMI audio issues exposed during the 4.21 > merge window. By accident (misleading documentation) we ended up > enabling the Skylake driver instead of the HDaudio legacy, and broke > audio on

Re: [Intel-gfx] [alsa-devel] Timing issues between ALSA and i915 drivers

2019-01-17 Thread Takashi Iwai
On Thu, 17 Jan 2019 20:53:06 +0100, Pierre-Louis Bossart wrote: > > > > I could use some feedback on HDMI audio issues exposed during the > > 4.21 merge window. By accident (misleading documentation) we ended > > up enabling the Skylake driver instead of the HDaudio legacy, and > > broke audio

Re: [Intel-gfx] [PATCH 3/3] snd/hda: Protect concurrent display_power_status with a mutex

2019-01-14 Thread Takashi Iwai
scenario? thanks, Takashi > > Signed-off-by: Chris Wilson > Cc: Takashi Iwai > Cc: Jani Nikula > --- > include/sound/hdaudio.h| 1 + > sound/hda/hdac_component.c | 7 +++ > 2 files changed, 8 insertions(+) > > diff --git a/include/sound/hdaudio.h b/inclu

Re: [Intel-gfx] [PATCH 3/3] snd/hda: Protect concurrent display_power_status with a mutex

2019-01-14 Thread Takashi Iwai
On Mon, 14 Jan 2019 18:51:31 +0100, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-01-14 17:46:57) > > On Mon, 14 Jan 2019 18:37:53 +0100, > > Chris Wilson wrote: > > > > > > Just in case the audio linkage is swapped between components during the > >

Re: [Intel-gfx] [PATCH 2/3] snd/hda: Track the display_power_status using a cookie

2019-01-14 Thread Takashi Iwai
runtime pm leaks. > > Signed-off-by: Chris Wilson > Cc: Takashi Iwai > Cc: Jani Nikula > --- > drivers/gpu/drm/i915/intel_audio.c | 10 +- > include/drm/drm_audio_component.h | 7 +-- > include/sound/hdaudio.h| 4 ++-- > sound/hda/hdac_co

Re: [Intel-gfx] [PATCH 3/3] snd/hda: Protect concurrent display_power_status with a mutex

2019-01-14 Thread Takashi Iwai
On Mon, 14 Jan 2019 21:57:15 +0100, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-01-14 18:00:02) > > On Mon, 14 Jan 2019 18:51:31 +0100, > > Chris Wilson wrote: > > > > > > Quoting Takashi Iwai (2019-01-14 17:46:57) > > > > On Mon, 14 Jan

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)

2019-01-21 Thread Takashi Iwai
4: > * Added some headline docs for the uapi usage. (Joonas/Chris) > > v25: > * Renamed class/instance to engine_class/engine_instance to avoid clash >with C++ keyword. (Tony Ye) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100899 > Bugzilla: ht

Re: [Intel-gfx] [alsa-devel] Timing issues between ALSA and i915 drivers

2019-01-18 Thread Takashi Iwai
On Thu, 17 Jan 2019 21:47:05 +0100, Pierre-Louis Bossart wrote: > > > >> I tried to narrow down the issue further and my current understanding > >> is that the Skylake driver performs link reset operations without the > >> display power turned on - which does not look like a very smart thing >

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-12 Thread Takashi Iwai
On Wed, 12 Sep 2018 15:18:47 +0200, Imre Deak wrote: > > +Takashi > > On Wed, Sep 12, 2018 at 04:18:12PM +0300, Imre Deak wrote: > > Hi Kumar, Takashi, > > > > On Tue, Jun 19, 2018 at 03:01:11PM -0700, Abhay Kumar wrote: > > > From: Ville Syrjälä > > > > > > CDCLK has to be at least twice the

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-12 Thread Takashi Iwai
On Wed, 12 Sep 2018 19:46:58 +0200, Ville Syrjälä wrote: > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote: > > Hi, > > > > I have a system with multiple monitors and would like to send > > notification sounds to the monitor on which corresponding > > window is visible. > > > >

Re: [Intel-gfx] [PATCH v5] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 15:54:37 +0200, Imre Deak wrote: > > On Wed, Sep 12, 2018 at 08:18:37PM +0200, Takashi Iwai wrote: > > On Wed, 12 Sep 2018 15:18:47 +0200, > > Imre Deak wrote: > > > > > > +Takashi > > > > > > On Wed, Sep 12, 2018

Re: [Intel-gfx] i915, HDMI/DP audio with multiple monitors

2018-09-13 Thread Takashi Iwai
On Thu, 13 Sep 2018 09:25:37 +0200, Bruno Prémont wrote: > > On Wed, 12 Sep 2018 20:06:43 +0200 Takashi Iwai wrote: > > On Wed, 12 Sep 2018 19:46:58 +0200, > > Ville Syrjälä wrote: > > > > > > On Tue, Sep 11, 2018 at 03:50:13PM +0200, Bruno Prémont wrote:

Re: [Intel-gfx] [PATCH] snd/hda, drm/i915: Track the display_power_status using a cookie

2019-02-13 Thread Takashi Iwai
e runtime pm leaks. > > v2: Keep using the power abstraction for local wakeref tracking. > > Signed-off-by: Chris Wilson > Cc: Takashi Iwai > Cc: Jani Nikula Feel free to take my ack: Reviewed-by: Takashi Iwai Or let me know if you guys want to apply this t

Re: [Intel-gfx] [PULL] topic/component-typed

2019-02-11 Thread Takashi Iwai
On Mon, 11 Feb 2019 19:25:12 +0100, Sam Ravnborg wrote: > > Hi Daniel. > > On Mon, Feb 11, 2019 at 06:15:20PM +0100, Daniel Vetter wrote: > > Hi all, > > > > Here's the typed component topic branch. > > > > drm-intel maintainers: Please pull, I need this for the mei hdcp work from > > Ram. >

Re: [Intel-gfx] [PATCH v10 02/40] i915/snd_hdac: I915 subcomponent for the snd_hdac

2019-02-04 Thread Takashi Iwai
Daniel Vetter > > Signed-off-by: Ramalingam C > > cc: Greg Kroah-Hartman > > cc: Russell King > > cc: Rafael J. Wysocki > > cc: Jaroslav Kysela > > cc: Takashi Iwai > > cc: Rodrigo Vivi > > cc: Jani Nikula > > Takashi, can you pls take

Re: [Intel-gfx] [PATCH] snd/hda: Balance hda->need_i915_power across runtime_suspend

2019-04-09 Thread Takashi Iwai
X_DCAPS_I915_POWERWELL checks") > Signed-off-by: Chris Wilson > Cc: Takashi Iwai > Cc: Imre Deak > --- > This appears to fix the glk-dsi as it performs a pm_runtime_suspend in > the middle of azx_probe_contime(). Hopefully. > --- > sound/pci/hda/hda_intel.c | 6 +- &

Re: [Intel-gfx] [PATCH] snd/hda: Balance hda->need_i915_power across runtime_suspend

2019-04-09 Thread Takashi Iwai
On Wed, 10 Apr 2019 00:53:31 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-09 22:35:28) > > On Tue, 09 Apr 2019 23:27:41 +0200, > > Chris Wilson wrote: > > > > > > In runtime_resume, we release the local display_power wakeref if we can > >

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
y > tracking the display_power_active cookie. > > Testcase: igt/i915_pm_rpm/module-reload #glk-dsi > Signed-off-by: Chris Wilson > Cc: Takashi Iwai > Cc: Imre Deak I rather prefer a more straightforward conversion, e.g. something like below. Checking the returned cookie as the state flag is

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 12:44:49 +0200, Takashi Iwai wrote: > > On Wed, 10 Apr 2019 12:24:24 +0200, > Chris Wilson wrote: > > > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > > On Wed, 10 Apr 2019 10:17:33 +0200, > > > Chris Wilson wrote: > > > >

Re: [Intel-gfx] [PATCH] snd/hda: Balance hda->need_i915_power across runtime_suspend

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 09:59:19 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-10 06:29:07) > > On Wed, 10 Apr 2019 00:53:31 +0200, > > Chris Wilson wrote: > > > > > > Quoting Takashi Iwai (2019-04-09 22:35:28) > > > > On Tue, 09 Apr

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 12:24:24 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > On Wed, 10 Apr 2019 10:17:33 +0200, > > Chris Wilson wrote: > > > > > > While we only allow a single display power reference, the current > > >

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 15:07:28 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-10 12:03:22) > > On Wed, 10 Apr 2019 12:44:49 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 10 Apr 2019 12:24:24 +0200, > > > Chris Wilson wrote: > >

[Intel-gfx] [PATCH] Revert "ALSA: hda: Add codec on bus address table lately"

2019-08-15 Thread Takashi Iwai
rt for now to make everything back to work. Fixes: ee5f85d9290f ("ALSA: hda: Add codec on bus address table lately") Reported-by: Chris Wilson Signed-off-by: Takashi Iwai --- sound/hda/hdac_device.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) di

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Drop unsol event handler for Intel HDMI codecs"

2019-08-15 Thread Takashi Iwai
ree+0x60/0x90 > <4> [281.912939] pci_device_remove+0x36/0xb0 > <4> [281.912946] device_release_driver_internal+0xd3/0x1b0 > <4> [281.912953] unbind_store+0xc3/0x120 > <4> [281.912962] kernfs_fop_write+0x104/0x190 > <4> [281.912971] vfs_write

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
yway. If that patch broke anything, it means that something else was already broken. Oh well, that ICL crap... Is it about the runtime PM, or S3 or S4? The only case we need to re-issue this verb is only S4, I suppose, so we may skip that in most cases. thanks, Takashi > > Cc: Takashi Iwai

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 10:16:07 +0200, Takashi Iwai wrote: > > On Thu, 25 Jul 2019 10:03:00 +0200, > Chris Wilson wrote: > > > > Just a heads up that icl is consistently showing > > > > <4> [315.478830] snd_hda_intel :00:1f.3: azx_get_response timeout,

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 12:21:11 +0200, Chris Wilson wrote: > > Quoting Chris Wilson (2019-07-25 09:30:25) > > Quoting Takashi Iwai (2019-07-25 09:26:56) > > > On Thu, 25 Jul 2019 10:16:07 +0200, > > > Takashi Iwai wrote: > > > > > > > > On Thu,

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 14:50:18 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-07-25 11:44:08) > > On Thu, 25 Jul 2019 12:21:11 +0200, > > Chris Wilson wrote: > > > > > > Quoting Chris Wilson (2019-07-25 09:30:25) > > > > Quoting Takashi

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 12:49:12 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-07-25 11:44:08) > > On Thu, 25 Jul 2019 12:21:11 +0200, > > Chris Wilson wrote: > > > > > > Quoting Chris Wilson (2019-07-25 09:30:25) > > > > Quoting Takashi

Re: [Intel-gfx] [PATCH] Revert "ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips"

2019-07-25 Thread Takashi Iwai
On Thu, 25 Jul 2019 15:57:10 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-07-25 14:45:10) > > On Thu, 25 Jul 2019 12:49:12 +0200, > > Chris Wilson wrote: > > > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13745/fi-icl-u2/igt@i915_module_l...@reload

Re: [Intel-gfx] [PATCH] snd/hda: Flush interrupts on disabling

2019-07-22 Thread Takashi Iwai
> which has the hallmarks of a worker queued from interrupt after it was > supposedly cancelled (note the POISON_FREE), and I could not see where > the interrupt would be flushed on shutdown so added the likely suspects. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74 > Signe

Re: [Intel-gfx] snd_hda_intel 0000:00:1f.3: No response from codec, resetting bus: last cmd=

2019-11-04 Thread Takashi Iwai
On Mon, 04 Nov 2019 14:10:24 +0100, Mika Westerberg wrote: > > Hi, > > On Mon, Nov 04, 2019 at 01:57:54PM +0100, Paul Menzel wrote: > > Dear Linux folks, > > > > > > On the Dell XPS 13 9380 with Debian Sid/unstable with Linux 5.3.7 > > resuming0with Dell’s Thunderbolt TB16 dock connected,

Re: [Intel-gfx] snd_hda_intel 0000:00:1f.3: No response from codec, resetting bus: last cmd=

2019-11-04 Thread Takashi Iwai
On Mon, 04 Nov 2019 15:58:25 +0100, Mika Westerberg wrote: > > On Mon, Nov 04, 2019 at 02:19:21PM +0100, Takashi Iwai wrote: > > On Mon, 04 Nov 2019 14:10:24 +0100, > > Mika Westerberg wrote: > > > > > > Hi, > > > > > > On Mon, Nov 04, 201

Re: [Intel-gfx] pcm_lock deadlock

2019-10-30 Thread Takashi Iwai
On Wed, 30 Oct 2019 14:50:09 +0100, Ville Syrjälä wrote: > > On Tue, Oct 29, 2019 at 09:52:57PM +0100, Takashi Iwai wrote: > > On Tue, 29 Oct 2019 20:10:50 +0100, > > From: Takashi Iwai > > Subject: [PATCH] ALSA: hda - Fix mutex deadlock in HDMI codec driver > >

Re: [Intel-gfx] pcm_lock deadlock

2019-10-29 Thread Takashi Iwai
t; [ 203.716574] ret_from_fork+0x2e/0x38 > > Looks like commit ade49db337a9 ("ALSA: hda/hdmi - Allow audio > component for AMD/ATI and Nvidia HDMI") introduced pcm_lock > to generic_hdmi_init(). Indeed, that can lead to a deadlock. The patch below should address the

Re: [Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

2020-02-12 Thread Takashi Iwai
t; > Without patch > 2020-02-12T00:55:36.795016-08:00 ERR kernel: [ 125.047502] @@@ cvt_nid power > state: 1 > 2020-02-12T00:55:36.795026-08:00 ERR kernel: [ 125.047565] @@@ nid power > state: 0 > > -Original Message- > From: Takashi Iwai > Sent: Wednesd

Re: [Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

2020-01-03 Thread Takashi Iwai
On Fri, 03 Jan 2020 02:57:03 +0100, wrote: > > Hi Sirs, > Here is chromebook SW team from Compal. > As the mail title, we hit issue that the external monitor will flash once > when play video after hot pluging. > We can reproduce not only on chromebook but also ubuntu 16.04. > There has

Re: [Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

2020-01-07 Thread Takashi Iwai
e fixed this > issue? The first suspect would be 2756d9143aa517b97961e85412882b8ce31371a6 ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips Takashi > > Thanks, > Nathan > > > > Thanks. > > > > > > -Original Message- > > From: Takashi Iwai > >

Re: [Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

2020-01-07 Thread Takashi Iwai
n i915 graphics side, or even thunderbolt or whatever, too... Takashi > > -Original Message- > From: Takashi Iwai > Sent: Wednesday, January 8, 2020 2:57 AM > To: Nathan Ciobanu > Cc: Kao. Lucien (TPE) ; Cheng. AJ (TPE) > ; intel-gfx@lists.freedesktop.org;

[Intel-gfx] [PATCH] drm/i915/gt: Use scnprintf() for avoiding potential buffer overflow

2020-03-11 Thread Takashi Iwai
Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 6 +++--- 1 file changed, 3

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-09 Thread Takashi Iwai
On Fri, 06 Mar 2020 17:45:44 +0100, Kai Vehmanen wrote: > > Hi folks, > > [+Takashi from ALSA] > > On Mon, 6 Jan 2020, Matt Roper wrote: > >>> On Tue, Dec 31, 2019 at 04:00:07PM +0200, Kai Vehmanen wrote: > Revert changes done in commit f6ec9483091f ("drm/i915: extend audio >

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-11 Thread Takashi Iwai
On Wed, 11 Mar 2020 18:04:24 +0100, Kai Vehmanen wrote: > > Hey, > > On Wed, 11 Mar 2020, Takashi Iwai wrote: > > > The remaining question is whether this display_power() call is still > > needed for the recent chips. Basically it's there for HSW/BDW type > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-11 Thread Takashi Iwai
On Wed, 11 Mar 2020 13:16:56 +0100, Kai Vehmanen wrote: > > Hey, > > On Tue, 10 Mar 2020, Takashi Iwai wrote: > > On Tue, 10 Mar 2020 19:25:22 +0100, Ville Syrjälä wrote: > >> On Tue, Mar 10, 2020 at 07:18:58PM +0200, Kai Vehmanen wrote: > >>> One probl

Re: [Intel-gfx] [PATCH v2] drm/i915: Limit audio CDCLK>=2*BCLK constraint back to GLK only

2020-03-10 Thread Takashi Iwai
On Tue, 10 Mar 2020 19:25:22 +0100, Ville Syrjälä wrote: > > On Tue, Mar 10, 2020 at 07:18:58PM +0200, Kai Vehmanen wrote: > > One problematic scenario that this doesn't cover: > > - a single display is used (at low cdclk), and > > - audio block goes to runtime suspend while display stays up.

Re: [Intel-gfx] [PATCH] ALSA: hda/i915 - fix list corruption with concurrent probes

2020-10-09 Thread Takashi Iwai
On Tue, 06 Oct 2020 18:17:22 +0200, Kai Vehmanen wrote: > > From: Takashi Iwai > > Current hdac_i915 uses a static completion instance to wait > for i915 driver to complete the component bind. > > This design is not safe if multiple HDA controllers are active and > comm

Re: [Intel-gfx] [PATCH] ALSA: hda: Release display power reference during shutdown/reboot

2021-06-23 Thread Takashi Iwai
On Tue, 22 Jun 2021 21:58:13 +0200, Imre Deak wrote: > > On Tue, Jun 22, 2021 at 04:18:14PM +0200, Takashi Iwai wrote: > > On Mon, 21 Jun 2021 19:44:15 +0200, > > Imre Deak wrote: > > > > > > Make sure the HDA driver's display power reference is r

Re: [Intel-gfx] [PATCH 1/2] ALSA: hda: Release controller display power during shutdown/reboot

2021-06-23 Thread Takashi Iwai
. > > Tested on HSW. > > v2: > - Fix the build for CONFIG_PM=n (Takashi) > - s/__azx_runtime_suspend/azx_shutdown_chip/ > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3618 > References: > https://lore.kernel.org/lkml/cea1f9a-52e0-b83-593d-52997fe1a

Re: [Intel-gfx] [PATCH] ALSA: hda: Release display power reference during shutdown/reboot

2021-06-22 Thread Takashi Iwai
On Mon, 21 Jun 2021 19:44:15 +0200, Imre Deak wrote: > > Make sure the HDA driver's display power reference is released during > shutdown/reboot. > > During the shutdown/reboot sequence the pci device core calls the > pm_runtime_resume handler for all devices before calling the driver's >

Re: [Intel-gfx] [PATCH] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-02 Thread Takashi Iwai
On Fri, 02 Apr 2021 09:47:49 +0200, Takashi Iwai wrote: > > intel_dsm_platform_mux_info() tries to parse the ACPI package data > from _DSM for the debug information, but it assumes the fixed format > without checking what values are stored in the elements actually. > When an u

[Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-02 Thread Takashi Iwai
, as reported recently. Add the checks of the contents in the returned values and skip the values for invalid cases. v1->v2: Check the info contents before dereferencing, too BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-02 Thread Takashi Iwai
, as reported recently. Add the checks of the contents in the returned values and skip the values for invalid cases. BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/display/intel_acpi.c | 12 1 file changed, 12 insertions

Re: [Intel-gfx] [PATCH] drm/i915/ilk-glk: Fix link training on links with LTTPRs

2021-03-16 Thread Takashi Iwai
t it add a code comment about the platform specific maximum > timeout values. > > Reported-by: Takashi Iwai > References: https://gitlab.freedesktop.org/drm/intel/-/issues/3166 > Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode link > training") &

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-08 Thread Takashi Iwai
On Thu, 08 Apr 2021 09:51:18 +0200, Takashi Iwai wrote: > > On Wed, 07 Apr 2021 23:28:48 +0200, > Ville Syrjälä wrote: > > > > Oh, could you ask the bug reporter to attach an acpidump to the > > bug? Might be good to have that stuff on record somewhere if/when &g

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-08 Thread Takashi Iwai
On Thu, 08 Apr 2021 18:56:06 +0200, Ville Syrjälä wrote: > > On Thu, Apr 08, 2021 at 06:34:06PM +0200, Takashi Iwai wrote: > > On Thu, 08 Apr 2021 09:51:18 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 07 Apr 2021 23:28:48 +0200, > > > Ville Syrj

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-07 Thread Takashi Iwai
On Wed, 07 Apr 2021 18:34:46 +0200, Ville Syrjälä wrote: > > On Fri, Apr 02, 2021 at 10:23:17AM +0200, Takashi Iwai wrote: > > intel_dsm_platform_mux_info() tries to parse the ACPI package data > > from _DSM for the debug information, but it assumes the fixed format > &g

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-08 Thread Takashi Iwai
On Wed, 07 Apr 2021 23:28:48 +0200, Ville Syrjälä wrote: > > On Wed, Apr 07, 2021 at 06:56:15PM +0200, Takashi Iwai wrote: > > On Wed, 07 Apr 2021 18:34:46 +0200, > > Ville Syrjälä wrote: > > > > > > On Fri, Apr 02, 2021 at

Re: [Intel-gfx] [PATCH v2] component: do not leave master devres group open after bind

2021-09-28 Thread Takashi Iwai
On Wed, 22 Sep 2021 10:54:32 +0200, Kai Vehmanen wrote: (snip) > --- a/drivers/base/component.c > +++ b/drivers/base/component.c > @@ -246,7 +246,7 @@ static int try_to_bring_up_master(struct master *master, > return 0; > } > > - if (!devres_open_group(master->parent,

Re: [Intel-gfx] [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK

2021-12-25 Thread Takashi Iwai
a > Cc: Emmanuel Jillela > Cc: Kai Vehmanen > Cc: Takashi Iwai > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2623 > Fixes: 951894cf30f4 ("ALSA: hda/hdmi: Add Intel silent stream support") > Signed-off-by: Ville Syrjälä Thanks, applied now. Takashi

Re: [Intel-gfx] [PATCH] ALSA: hda: fix general protection fault in azx_runtime_idle

2021-11-11 Thread Takashi Iwai
On Wed, 10 Nov 2021 23:15:40 +0100, Kai Vehmanen wrote: > > Hey, > > On Wed, 10 Nov 2021, Takashi Iwai wrote: > > > On Wed, 10 Nov 2021 22:03:07 +0100, Kai Vehmanen wrote: > > > Fix a corner case between PCI device driver remove callback and > > > runti

Re: [Intel-gfx] [PATCH] ALSA: hda: fix general protection fault in azx_runtime_idle

2021-11-10 Thread Takashi Iwai
On Wed, 10 Nov 2021 22:03:07 +0100, Kai Vehmanen wrote: > > Fix a corner case between PCI device driver remove callback and > runtime PM idle callback. > > Following sequence of events can happen: > - at azx_create, context is allocated with devm_kzalloc() and > stored as pci_set_drvdata()

Re: [Intel-gfx] [PATCH] ALSA: hda: fix general protection fault in azx_runtime_idle

2021-11-12 Thread Takashi Iwai
On Thu, 11 Nov 2021 18:39:36 +0100, Kai Vehmanen wrote: > > Hi, > > On Thu, 11 Nov 2021, Takashi Iwai wrote: > > > A potential problem with the current code is that it doesn't disable > > the runtime PM at the release procedure. Could you try the patch > >

Re: [Intel-gfx] [PATCH] ALSA: hda: fix general protection fault in azx_runtime_idle

2021-11-14 Thread Takashi Iwai
On Fri, 12 Nov 2021 13:27:34 +0100, Kai Vehmanen wrote: > > Hi, > > On Fri, 12 Nov 2021, Takashi Iwai wrote: > > > On Thu, 11 Nov 2021 18:39:36 +0100, Kai Vehmanen wrote: > > > And later > > > [ 54.770701] Enabling runtime PM for inactive device (00

Re: [Intel-gfx] [PATCH] ALSA: hda/i915 - avoid hung task timeout in i915 wait

2022-03-08 Thread Takashi Iwai
On Tue, 08 Mar 2022 17:29:21 +0100, Amadeusz SX2awiX4ski wrote: > > On 3/8/2022 3:11 PM, Kai Vehmanen wrote: > > If kernel is built with hung task detection enabled and > > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT set to less than 60 seconds, > > snd_hdac_i915_init() will trigger the hung task timeout in

Re: [Intel-gfx] [PATCH v3] ALSA: hda/i915 - avoid hung task timeout in i915 wait

2022-03-10 Thread Takashi Iwai
On Wed, 09 Mar 2022 19:24:39 +0100, Kai Vehmanen wrote: > > If kernel is built with hung task detection enabled and > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT set to less than 60 seconds, > snd_hdac_i915_init() will trigger the hung task timeout in case i915 is > not available and taint the kernel. > >

Re: [Intel-gfx] [PATCH v2] ALSA: hda/i915 - avoid hung task timeout in i915 wait

2022-03-09 Thread Takashi Iwai
On Wed, 09 Mar 2022 10:02:13 +0100, Tvrtko Ursulin wrote: > > > On 09/03/2022 08:39, Kai Vehmanen wrote: > > Hi, > > > > On Wed, 9 Mar 2022, Tvrtko Ursulin wrote: > > > >>> - /* 60s timeout */ > >> > >> Where does this 60s come from and why is the fix to work around > >>

Re: [Intel-gfx] [PATCH v2] ALSA: hda/i915 - avoid hung task timeout in i915 wait

2022-03-09 Thread Takashi Iwai
On Wed, 09 Mar 2022 09:36:54 +0100, Tvrtko Ursulin wrote: > > > On 08/03/2022 17:27, Kai Vehmanen wrote: > > If kernel is built with hung task detection enabled and > > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT set to less than 60 seconds, > > snd_hdac_i915_init() will trigger the hung task timeout in

Re: [Intel-gfx] [PATCH v2] ALSA: hda/i915 - avoid hung task timeout in i915 wait

2022-03-09 Thread Takashi Iwai
On Wed, 09 Mar 2022 10:48:49 +0100, Tvrtko Ursulin wrote: > > > On 09/03/2022 09:23, Takashi Iwai wrote: > > On Wed, 09 Mar 2022 10:02:13 +0100, > > Tvrtko Ursulin wrote: > >> > >> > >> On 09/03/2022 08:39, Kai Vehmanen wrote: > >>&

Re: [Intel-gfx] [PATCH 2/2] hda/i915: split the wait for the component binding

2022-02-25 Thread Takashi Iwai
On Thu, 24 Feb 2022 17:34:54 +0100, Kai Vehmanen wrote: > > Hi, > > On Thu, 24 Feb 2022, Ramalingam C wrote: > > > Split the wait for component binding from i915 in multiples of > > sysctl_hung_task_timeout_secs. This helps to avoid the possible kworker > > thread hung detection given below. >

Re: [Intel-gfx] [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()

2022-04-18 Thread Takashi Iwai
On Mon, 18 Apr 2022 06:50:32 +0200, Lucas De Marchi wrote: > > On Sun, Apr 17, 2022 at 01:13:49PM +0300, Kai Vehmanen wrote: > >Hi, > > > >On Fri, 15 Apr 2022, Lucas De Marchi wrote: > > > >> pci_get_class() will already unref the pci device passed as argument. > >> So if it's unconditionally

Re: [Intel-gfx] [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()

2022-04-19 Thread Takashi Iwai
On Tue, 19 Apr 2022 08:26:06 +0200, Lucas De Marchi wrote: > > On Tue, Apr 19, 2022 at 07:54:30AM +0200, Takashi Iwai wrote: > >On Mon, 18 Apr 2022 06:50:32 +0200, > >Lucas De Marchi wrote: > >> > >> On Sun, Apr 17, 2022 at 01:13:49PM +0300, Kai Vehmanen wrot

Re: [Intel-gfx] [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()

2022-04-19 Thread Takashi Iwai
On Tue, 19 Apr 2022 08:40:01 +0200, Takashi Iwai wrote: > > On Tue, 19 Apr 2022 08:26:06 +0200, > Lucas De Marchi wrote: > > > > On Tue, Apr 19, 2022 at 07:54:30AM +0200, Takashi Iwai wrote: > > >On Mon, 18 Apr 2022 06:50:32 +0200, > > >Lucas De Marchi wr

Re: [Intel-gfx] [PATCH] ALSA: hda/i915: Fix one too many pci_dev_put()

2022-04-19 Thread Takashi Iwai
Kai Vehmanen > Cc: Takashi Iwai > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5701 > Fixes: 0dc2696a4623 ("ALSA: hda/i915 - skip acomp init if no matching > display") > Signed-off-by: Lucas De Marchi Thanks, applied now. But the Fixes commit id was wr

Re: [Intel-gfx] [PATCH v5 2/2] ALSA: hda - identify when audio is provided by a video driver

2022-05-09 Thread Takashi Iwai
te to the game (just back from vacation), but FWIW: Reviewed-by: Takashi Iwai thanks, Takashi

Re: [Intel-gfx] [PATCH v2 0/3] ALSA: hda/hdmi: i915 keepalive fixes

2022-12-09 Thread Takashi Iwai
On Fri, 09 Dec 2022 11:18:19 +0100, Kai Vehmanen wrote: > > A series with multiple fixes to i915 keepalive (KAE) > functionality. First patch fixes issue that is hit on > some A750/770 cards: > https://gitlab.freedesktop.org/drm/intel/-/issues/7353 > > The two other improve behaviour especially

Re: [Intel-gfx] [PATCH] ALSA: hda/hdmi: disable KAE for Intel DG2

2023-04-13 Thread Takashi Iwai
On Thu, 13 Apr 2023 21:11:53 +0200, Kai Vehmanen wrote: > > Use of keep-alive (KAE) has resulted in loss of audio on some A750/770 > cards as the transition from keep-alive to stream playback is not > working as expected. As there is limited benefit of the new KAE mode > on discrete cards, revert

Re: [Intel-gfx] [PATCH] ALSA: hda: i915: Alays handle -EPROBE_DEFER

2023-11-15 Thread Takashi Iwai
ion when HDA-intel is loaded before i915. > > Reported-by: Ville Syrjälä > Signed-off-by: Maarten Lankhorst > Tested-by: Kai Vehmanen > Fixes: e6d0c13e9f46 ("ALSA: hda: i915: Remove extra argument from > snd_hdac_i915_init") > Cc: Takashi Iwai > >

Re: [Intel-gfx] [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.

2023-11-14 Thread Takashi Iwai
On Tue, 14 Nov 2023 12:06:45 +0100, Ville Syrjälä wrote: > > On Mon, Oct 02, 2023 at 09:38:44PM +0200, maarten.lankho...@linux.intel.com > wrote: > > From: Maarten Lankhorst > > > > Now that we can use -EPROBE_DEFER, it's no longer required to spin off > > the snd_hdac_i915_init into a

Re: [Intel-gfx] [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.

2023-11-14 Thread Takashi Iwai
On Tue, 14 Nov 2023 14:31:25 +0100, Saarinen, Jani wrote: > > Hi, > > -Original Message- > > From: Maarten Lankhorst > > Sent: Tuesday, November 14, 2023 3:30 PM > > To: Jani Nikula ; Ville Syrjälä > > > > Cc: Takashi Iwai ; int

Re: [Intel-gfx] [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.

2023-11-14 Thread Takashi Iwai
On Tue, 14 Nov 2023 15:39:16 +0100, Maarten Lankhorst wrote: > > > Hey, > > Den 2023-11-14 kl. 14:39, skrev Ville Syrjälä: > > On Tue, Nov 14, 2023 at 02:35:10PM +0200, Jani Nikula wrote: > > On Tue, 14 Nov 2023, Ville Syrjälä > wrote: > > On Mon, Oct

Re: [PATCH 1/4] ALSA: hda: Skip i915 initialization on CNL/LKF-based platforms

2024-02-23 Thread Takashi Iwai
On Thu, 22 Feb 2024 21:54:42 +0100, Rodrigo Vivi wrote: > > On Thu, Feb 22, 2024 at 06:53:12PM +0100, Cezary Rojewski wrote: > > On 2024-02-22 6:24 PM, Ville Syrjälä wrote: > > > On Thu, Feb 22, 2024 at 06:06:11PM +0100, Cezary Rojewski wrote: > > > > Commit 78f613ba1efb ("drm/i915: finish

Re: [PATCH v3 0/5] ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-03-04 Thread Takashi Iwai
On Mon, 26 Feb 2024 13:44:27 +0100, Cezary Rojewski wrote: > > A small set of changes to improve initialization of the audio stack on > HDAudio devices and pair of cleanups. > > As the first change is the most important one here, following is the > technical background for it: > > Commit

Re: [PATCH v2 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-26 Thread Takashi Iwai
On Fri, 23 Feb 2024 18:09:59 +0100, Cezary Rojewski wrote: > > On 2024-02-23 3:44 PM, Takashi Iwai wrote: > > On Fri, 23 Feb 2024 12:46:24 +0100, > > Cezary Rojewski wrote: > >> > >> If i915 does not support given platform but the hardware i.e.: HDAudio

Re: [PATCH v2 2/4] ASoC: codecs: hda: Skip HDMI/DP registration if i915 is missing

2024-02-23 Thread Takashi Iwai
On Fri, 23 Feb 2024 12:46:24 +0100, Cezary Rojewski wrote: > > If i915 does not support given platform but the hardware i.e.: HDAudio > codec is still there, the codec-probing procedure will succeed for such > device but the follow up initialization will always end up with -ENODEV. > > While bus

Re: [PATCH v2 0/4] ALSA/ASoC: Conditionally skip i915 init and cleanups

2024-02-23 Thread Takashi Iwai
On Fri, 23 Feb 2024 12:46:22 +0100, Cezary Rojewski wrote: > > A small set of changes to improve initialization of the audio stack on > HDAudio devices and pair of cleanups. > > As the first change is the most important one here, following is the > technical background for it: > > Commit

<    1   2   3   4   5   6