[Intel-gfx] [PATCH 1/5] drm/i915: Replace drm_connector_{un/reference} with put, get functions

This patch unifies the naming of DRM functions for reference counting of struct drm_connector. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/i915/intel_dp_mst.c

[Intel-gfx] [PATCH 5/5] drm/i915: Replace drm_dev_unref with drm_dev_put

This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/selftests/huge_pages.c| 2 +- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 4/5] drm/i915: Replace drm_gem_object_unreference_unlocked with put function

This patch unifies the naming of DRM functions for reference counting of struct drm_gem_object. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/i915_gem_object.h | 3 --- 1 file changed, 3 deletions

[Intel-gfx] [PATCH 3/5] drm/i915: Replace __drm_gem_object_unreference with __drm_gem_object_put

This patch unifies the naming of DRM functions for reference counting of struct drm_gem_object. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/i915_gem_object.h | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] [PATCH 2/5] drm/i915: Replace drm_gem_object_{un/reference} with {put, get} functions

This patch unifies the naming of DRM functions for reference counting of struct drm_gem_object. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/i915_gem_object.h | 8 +--- 1 file changed, 1 insertion

[Intel-gfx] [PATCH 0/5] drm/i915: Replace {un/reference} with {put, get} functions

nameing standard. The patch set does not change driver-internal interfaces. Thomas Zimmermann (5): drm/i915: Replace drm_connector_{un/reference} with put,get functions drm/i915: Replace drm_gem_object_{un/reference} with {put,get} functions drm/i915: Replace __drm_gem_object_unreference

Re: [Intel-gfx] [PATCH 00/16] drm/fb-helper: Move modesetting code to drm_client

+ >> include/drm/drm_fb_helper.h | 127 +-- >> 17 files changed, 2128 insertions(+), 1539 deletions(-) >> create mode 100644 drivers/gpu/drm/drm_bootsplash.c >> > ___ > dri-devel mailing list > dri-de...

Re: [Intel-gfx] [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly

Hi Am 20.05.19 um 10:33 schrieb Thomas Zimmermann: > Hi > > Am 20.05.19 um 10:21 schrieb Daniel Vetter: > ... >> diff --git a/drivers/video/fbdev/core/fbmem.c >> b/drivers/video/fbdev/core/fbmem.c >> index fc3d34a8ea5b..ae2db31eeba7 100644 >> --- a/drive

Re: [Intel-gfx] [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly

*info); > #else > static inline void fb_console_init(void) {} > static inline void fb_console_exit(void) {} > +static inline int fbcon_fb_registered(struct fb_info *info) { return 0; } > +static inline void fbcon_fb_unregistered(struct fb_info *info) {} > #endif > >

Re: [Intel-gfx] [PATCH v4 17/23] drm/ast: Provide ddc symlink in connector sysfs directory

Acked-by: Thomas Zimmermann Am 11.07.19 um 13:26 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/ast/ast_mode.c | 9 + > 1 file changed, 5 insertions(+), 4 dele

Re: [Intel-gfx] [PATCH v4 16/23] drm/mgag200: Provide ddc symlink in connector sysfs directory

Acked-by: Thomas Zimmermann Am 11.07.19 um 13:26 schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/mgag200/mgag200_mode.c | 9 + > 1 file changed, 5 insertio

Re: [Intel-gfx] [PATCH v2 03/12] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

RM_DEBUG_KMS("Enabled: %i, detected: %i\n", > num_connectors_enabled, > - num_connectors_detected); > - fallback = true; > - } > - > - if (fallback) { > -bail: > - DRM_DEBUG_KMS("Not using firmware conf

Re: [Intel-gfx] [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

Hi Am 14.06.19 um 22:35 schrieb Daniel Vetter: > We're kinda going in the wrong direction. Spotted while typing better > gem/prime docs. > > Cc: Thomas Zimmermann > Cc: Gerd Hoffmann > Cc: Rob Herring > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter > --- &g

Re: [Intel-gfx] [PATCH 40/59] drm/vram-helper: Drop drm_gem_prime_export/import

to just mmap the shadow FB from the fbcon emulation. Best regards Thomas > Hope that explains a bit better what's going on here. Step one here for > mmap is definitely to roll out drm_gem_prime_mmap as far as possible, so > it's easier to understand where the exceptions are. >

Re: [Intel-gfx] [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory

connector->ddc = ddc; /* set up sysfs */ return 0; } Best regards Thomas > Andrzej > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedeskt

Re: [Intel-gfx] [PATCH v5 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

if (!mga_connector->i2c) > - DRM_ERROR("failed to add ddc bus\n"); > - > return connector; > } > > Reviewed-by: Thomas Zimmermann -- Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldst

Re: [Intel-gfx] [PATCH v5 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

or_attach_encoder(connector, encoder); > > - ast_connector->i2c = ast_i2c_create(dev); > - if (!ast_connector->i2c) > - DRM_ERROR("failed to add ddc bus for connector\n"); > - > return 0; > } > > Reviewed-by: Thomas Zimmermann -- Thomas

Re: [Intel-gfx] [PATCH v5 02/24] drm: Add drm_connector_init() variant with ddc

n ret; > +} > +EXPORT_SYMBOL(drm_connector_init_with_ddc); > + Thanks for including such a function. Acked-by: Thomas Zimmermann > /** > * drm_connector_attach_edid_property - attach edid property. > * @connector: the connector > diff --git a/include/drm/drm_connector.

Re: [Intel-gfx] [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

own. > Agreed on these two points as well. > > Just adding my 2 cents. > -- Tim > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailma

Re: [Intel-gfx] [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

Hi Am 15.10.19 um 13:54 schrieb Matthew Wilcox: > On Tue, Oct 15, 2019 at 11:25:53AM +0200, Thomas Zimmermann wrote: >>> My preference would be to use 'symbols'. I tried to come up with something >>> but 'symbols' is better than anything I came up with. >> >>

Re: [Intel-gfx] [PATCH 7/8] drm/hibmc: Use drm_gem_fb_create

mp; 0xff, > - (mode_cmd->pixel_format >> 24) & 0xff); > - > - obj = drm_gem_object_lookup(filp, mode_cmd->handles[0]); > - if (!obj) > - return ERR_PTR(-ENOENT); > - > - hibmc_fb = hibmc_framebuffer_init(dev,

Re: [Intel-gfx] [PATCH 7/8] drm/hibmc: Use drm_gem_fb_create

Hi Am 15.11.19 um 10:21 schrieb Daniel Vetter: > Again we could delete a lot more if we'd switch over to the generic > fbdev stuff. > > Signed-off-by: Daniel Vetter There's one comment below. Except for that, Acked-by: Thomas Zimmermann > --- > .../gpu/drm/hisilicon/hi

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Clean up VBLANK callbacks in struct drm_driver (rev8)

ert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/vmwgfx: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm: Clean-up VBLANK-related callbacks in struct drm_driver >> - ~^~~~ >>

Re: [Intel-gfx] [PATCH 1/9] drm: Remove unused arg from drm_fb_helper_init

drm_fb_helper_init(E1,E2, E3) > + drm_fb_helper_init(E1,E2) > > Signed-off-by: Pankaj Bharadiya Reviewed-by: Thomas Zimmermann > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 3 +-- > drivers/gpu/drm/armada/armada_fbdev.c | 2 +- > drivers/gpu/drm/drm_fb_h

[Intel-gfx] Merge conflict between drm-next and drm-tip

on display idleness and commit ceaaf5300f881e54bba4221a710a40b48423f610 Author: José Roberto de Souza Date: Wed Feb 5 13:49:45 2020 -0800 drm/i915/dc3co: Add description of how it works Best regards Thomas -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions

Re: [Intel-gfx] [PATCH 50/51] drm/udl: drop drm_driver.release hook

el Vetter > Cc: Dave Airlie > Cc: Sean Paul > Cc: Daniel Vetter > Cc: Thomas Zimmermann > Cc: Emil Velikov > Cc: Gerd Hoffmann > Cc: "Noralf Trønnes" > Cc: Sam Ravnborg > Cc: Thomas Gleixner > Cc: Alex Deucher > --- > drivers/gpu/drm/udl/udl_d

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

n drmm_add_action fails, we'd be > missing some mutex_destroy and ida_cleanup otherwise (Laurent) > > v4: Add a drmm_add_action_or_reset (like devm_ has) to encapsulate this > pattern (Noralf). > > v5: Fix oversight in the new add_action_or_reset macro (Noralf) > > Cc: Laurent

Re: [Intel-gfx] [PATCH 50/51] drm/udl: drop drm_driver.release hook

Hi Am 28.02.20 um 09:40 schrieb Daniel Vetter: > On Fri, Feb 28, 2020 at 8:44 AM Thomas Zimmermann wrote: >> >> Hi Daniel >> >> Am 27.02.20 um 19:15 schrieb Daniel Vetter: >>> There's only two functions called from that: >>> drm_kms_hel

Re: [Intel-gfx] [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_

Hi Am 28.02.20 um 09:43 schrieb Daniel Vetter: > On Fri, Feb 28, 2020 at 8:30 AM Thomas Zimmermann wrote: >> >> Hi Daniel >> >> Am 27.02.20 um 19:14 schrieb Daniel Vetter: >>> drm_mode_config_cleanup is idempotent, so no harm in calling this >>> twic

Re: [Intel-gfx] [PATCH 50/51] drm/udl: drop drm_driver.release hook

unregistering the driver, > but that's a different issue. > > v2: Use _fini, not _disable in unplug, motivated by discussions with > Thomas. _disable/_enable are for suspend/resume. > > Signed-off-by: Daniel Vetter Acked-by: Thomas Zimmermann > Cc: Dave Airlie > Cc: Sean Paul &

Re: [Intel-gfx] [PATCH 50/51] drm/udl: drop drm_driver.release hook

Hi Daniel Am 28.02.20 um 18:43 schrieb Daniel Vetter: > On Fri, Feb 28, 2020 at 12:46 PM Thomas Zimmermann > wrote: >> >> Hi >> >> Am 28.02.20 um 09:40 schrieb Daniel Vetter: >>> On Fri, Feb 28, 2020 at 8:44 AM Thomas Zimmermann >>> wrote: &g

[Intel-gfx] [PATCH v4 16/22] drm/sti: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert sti over. v2: * remove unnecessary include of sti_crtc.h from sti_drv.c Signed-off-by: Thomas Zimmermann Acked-by: Benjamin Gaignard --- drivers/gpu/drm/sti/sti_crtc.c

[Intel-gfx] [PATCH v4 14/22] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 65

[Intel-gfx] [PATCH v4 18/22] drm/vc4: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff

[Intel-gfx] [PATCH v4 19/22] drm/vkms: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vkms over. Signed-off-by: Thomas Zimmermann Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++--- drivers/gpu/drm/vkms

[Intel-gfx] [PATCH v4 20/22] drm/vmwgfx: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vmwgfx over. v2: * remove accidental whitespace fixes Signed-off-by: Thomas Zimmermann Acked-by: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3

[Intel-gfx] [PATCH v4 17/22] drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 12 +++- drivers/gpu/drm/vc4/vc4_drv.c | 1 - drivers/gpu/drm

[Intel-gfx] [PATCH v4 03/22] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

v2: * rename helper to drm_crtc_vblank_helper_get_vblank_timestamp() * replace drm_calc_vbltimestamp_from_scanoutpos() with drm_crtc_vblank_helper_get_vblank_timestamp() in docs Signed-off-by: Thomas Zimmermann Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_vblank.c

[Intel-gfx] [PATCH v4 02/22] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

drm_calc_vbltimestamp_from_scanoutpos() to minimize code duplication * define types for get_scanout_position() callbacks v2: * fix logical op in drm_calc_vbltimestamp_from_scanoutpos() Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré Reviewed-by: Ville Syrjälä --- drivers

[Intel-gfx] [PATCH v4 04/22] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert amdgpu over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 12 drivers/gpu/drm/amd/amdgpu

[Intel-gfx] [PATCH v4 01/22] drm: Remove internal setup of struct drm_device.vblank_disable_immediate

drm_device.get_vblank_timestamp. v3: * remove internal setup of vblank_disable_immediate Signed-off-by: Thomas Zimmermann Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_vblank.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm

Re: [Intel-gfx] [PATCH v4 2/2] drm/debugfs: also take per device driver features into account

care" > > v2: > - use drm_core_check_all_features() > > Cc: Ville Syrjälä > Cc: Thomas Zimmermann > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/drm_debugfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drive

[Intel-gfx] [PATCH v4 05/22] drm/amdgpu: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert amdgpu over. v2: * don't wrap existing functions; change signature instead Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6

[Intel-gfx] [PATCH v4 11/22] drm/radeon: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert radeon over. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_display.c | 12 -- drivers/gpu/drm/radeon/radeon_drv.c | 7

[Intel-gfx] [PATCH v4 00/22] drm: Clean up VBLANK callbacks in struct drm_driver

for readability (Ville) v2: * reorder patches so the i915 can be converted without duplicating helper code. * merged cleanup patches * changed VBLANK function signatures in amdgpu (Alex) Thomas Zimmermann (22): drm: Remove internal setup of struct

[Intel-gfx] [PATCH v4 22/22] drm: Remove legacy version of get_scanout_position()

The legacy version of get_scanout_position() was only useful while drivers still used drm_driver.get_scanout_position(). With no such drivers left, the related typedef and code can be removed Signed-off-by: Thomas Zimmermann Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_vblank.c| 27

[Intel-gfx] [PATCH v4 21/22] drm: Clean-up VBLANK-related callbacks in struct drm_driver

drm_calc_vbltimestamp_from_scanoutpos() Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter Tested-by: Yannick Fertré --- drivers/gpu/drm/drm_vblank.c | 81 +++ include/drm/drm_drv.h| 153 +-- include/drm/drm_vblank.h | 4 - 3 files

[Intel-gfx] [PATCH v4 12/22] drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert mem over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 67 +++ drivers/gpu/drm/msm/disp/mdp5

[Intel-gfx] [PATCH v4 07/22] drm/i915: Convert to CRTC VBLANK callbacks

for drm_crtc_vblank_helper_get_vblank_timestamp_internal() v2: * use DRM's implementation of get_vblank_timestamp() * simplify function names Signed-off-by: Thomas Zimmermann Reviewed-by: Ville Syrjälä Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 7 +++ drivers/gpu/drm/i915/i915_drv.c

[Intel-gfx] [PATCH v4 15/22] drm/stm: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert stm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 1 + 2 files changed, 1 insertion(+), 1

[Intel-gfx] [PATCH v4 09/22] drm/nouveau: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert nouvean over. v4: * add argument names in function declaration Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 3 +++ drivers/gpu/drm

[Intel-gfx] [PATCH v4 13/22] drm/msm: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert msm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2

[Intel-gfx] [PATCH v4 10/22] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert radeon over. v4: * 80-character line fixes Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 + drivers/gpu

[Intel-gfx] [PATCH v4 06/22] drm/gma500: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert gma500 over. Signed-off-by: Thomas Zimmermann Acked-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_drv.c | 4

[Intel-gfx] [PATCH v4 08/22] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert nouveau over. v4: * add argument names in function declaration Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c

Re: [Intel-gfx] [PATCH] drm/auth: Drop master_create/destroy hooks

t; already does. That should get rid of most ->lastclose implementations, > and I think also subsumes any processing vmwgfx does in > master_set/drop. > > Cc: "Thomas Hellström (VMware)" > Signed-off-by: Daniel Vetter Reviewed-by: Thomas Zimmermann > --- &

Re: [Intel-gfx] [PATCH v2 3/6] drm/exynos: Use drm_encoder_mask()

Am 07.02.20 um 14:59 schrieb Ville Syrjala: > From: Ville Syrjälä > > Replace the hand rolled encoder bitmask thing with drm_encoder_mask() > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH v2 4/6] drm/imx: Remove the bogus possible_clones setup

ossible_clones = ~0; > + encoder->possible_clones = 0; Maybe remove the comment as well. It's pointless. Best regards Thomas > > return 0; > } > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, German

Re: [Intel-gfx] [PATCH v2 5/6] drm: Validate encoder->possible_clones

be noisy. Setting these masks incorrectly could be a bug. > > v2: encoder->possible_clones now includes the encoder itelf > > Cc: Thomas Zimmermann > Cc: Daniel Vetter > Signed-off-by: Ville Syrjälä Acked-by: Thomas Zimmermann > --- > drivers/gpu/drm/drm_encoder.c

Re: [Intel-gfx] [PATCH 0/5] disable drm_global_mutex for most drivers, take 2

Hi, On patches 2 to 5: Acked-by: Thomas Zimmermann I'm not overly knowledgeable on DRM locking semantics, but the patches appear to be correct in general. Best regards Thomas Am 04.02.20 um 16:01 schrieb Daniel Vetter: > CI didn't like my test-with tag :-/ >

Re: [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

t before registering the encoders. > > TODO: Should we do something similar for possible_crtcs==0? > > Cc: Thomas Zimmermann > Cc: Daniel Vetter > Signed-off-by: Ville Syrjälä May this fixup function should warn iff possible_clones was set to non-0 by the driver, but the encod

Re: [Intel-gfx] [PATCH 1/4] drm: Complain if drivers still use the ->load callback

ntly converted several of them. The status here is that only radeon and amdgpu still use load. I've only not been able to convert them because they do some debugfs registering that relies on the device being registered early. I've not had time to convert the code. On the patch: Reviewed-by: Thomas

Re: [Intel-gfx] [PATCH 05/52] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers

function. > > Aside, I think we could perhaps have a tiny additional helper for > these mipi_dbi drivers, the first few lines around devm_drm_dev_init > are all the same (except for the drm_driver pointer). > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zim

Re: [Intel-gfx] [PATCH 05/52] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers

Am 19.02.20 um 12:47 schrieb Thomas Zimmermann: > Hi Daniel, > > good idea. I guess it's the simple encoder's fault. :) I only read > briefly over the whole thing. > > Am 19.02.20 um 11:20 schrieb Daniel Vetter: >> They all share mipi_dbi_release so we need to swi

Re: [Intel-gfx] [PATCH 05/52] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers

Hi Am 19.02.20 um 14:23 schrieb Daniel Vetter: > On Wed, Feb 19, 2020 at 12:47 PM Thomas Zimmermann > wrote: >> >> Hi Daniel, >> >> good idea. I guess it's the simple encoder's fault. :) I only read >> briefly over the whole thing. >> >> Am 19.02

Re: [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

Hi Am 07.02.20 um 17:27 schrieb Daniel Vetter: > On Fri, Feb 07, 2020 at 04:50:01PM +0200, Ville Syrjälä wrote: >> On Fri, Feb 07, 2020 at 03:28:35PM +0100, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 07.02.20 um 14:59 schrieb Ville Syrjala: >>>

Re: [Intel-gfx] [PATCH 0/5] disable drm_global_mutex for most drivers, take 2

Hi, I smoke-tested the patchset by running X11, Weston and fbdev emulation on ast and udl. No apparent problems found, so Tested-by: Thomas Zimmermann Best regards Thomas Am 04.02.20 um 16:01 schrieb Daniel Vetter: > CI didn't like my test-with tag :-/ > > Test-with: 20200128112549

Re: [Intel-gfx] [PATCH 01/23] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

Hi Am 14.01.20 um 16:31 schrieb Yannick FERTRE: > Thanks for the patch. > > Tested-by: Yannick Fertré Thanks for testing all these patches. Best regards Thomas > > BR > Yannick Fertré > > > On 1/10/20 10:21 AM, Thomas Zimmermann wrote: >> The new call

Re: [Intel-gfx] [PATCH 02/23] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

Hi Am 13.01.20 um 19:52 schrieb Alex Deucher: > On Fri, Jan 10, 2020 at 4:21 AM Thomas Zimmermann wrote: >> >> The callback struct drm_driver.get_scanout_position() is deprecated in >> favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert >> amdgpu o

[Intel-gfx] [PATCH v2 16/21] drm/sti: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert sti over. v2: * remove unnecessary include of sti_crtc.h from sti_drv.c Signed-off-by: Thomas Zimmermann Acked-by: Benjamin Gaignard --- drivers/gpu/drm/sti/sti_crtc.c

[Intel-gfx] [PATCH v2 18/21] drm/vc4: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff

[Intel-gfx] [PATCH v2 15/21] drm/stm: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert stm over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v2 13/21] drm/msm: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert msm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2

[Intel-gfx] [PATCH v2 20/21] drm/vmwgfx: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vmwgfx over. v2: * remove accidental whitespace fixes Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 --- drivers/gpu/drm/vmwgfx

[Intel-gfx] [PATCH v2 08/21] drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert nouveau over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 + drivers/gpu/drm/nouveau/dispnv50/head.c | 1

[Intel-gfx] [PATCH v2 17/21] drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 12 +++- drivers/gpu/drm/vc4/vc4_drv.c | 1 - drivers/gpu/drm

[Intel-gfx] [PATCH v2 01/21] drm: Add get_scanout_position() to struct drm_crtc_helper_funcs

() Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/drm_vblank.c | 24 include/drm/drm_drv.h| 7 +--- include/drm/drm_modeset_helper_vtables.h | 47 3 files changed, 65 insertions(+), 13 deletions

[Intel-gfx] [PATCH v2 04/21] drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert amdgpu over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 12 drivers/gpu/drm/amd/amdgpu

[Intel-gfx] [PATCH v2 00/21] drm: Clean up VBLANK callbacks in struct drm_driver

. * merged cleanup patches * changed VBLANK function signatures in amdgpu Thomas Zimmermann (21): drm: Add get_scanout_position() to struct drm_crtc_helper_funcs drm: Evaluate struct drm_device.vblank_disable_immediate on each use drm: Add get_vblank_timestamp() to struct

[Intel-gfx] [PATCH v2 14/21] drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert stm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/stm/drv.c | 1 - drivers/gpu/drm/stm/ltdc.c | 65

[Intel-gfx] [PATCH v2 09/21] drm/nouveau: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert nouvean over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 3 +++ drivers/gpu/drm/nouveau/dispnv50/head.c | 4 drivers/gpu/drm

[Intel-gfx] [PATCH v2 11/21] drm/radeon: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert radeon over. Signed-off-by: Thomas Zimmermann Reviewed-by: Alex Deucher --- drivers/gpu/drm/radeon/radeon_display.c | 12 -- drivers/gpu/drm/radeon/radeon_drv.c | 7

[Intel-gfx] [PATCH v2 06/21] drm/gma500: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert gma500 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/cdv_intel_display.c | 3 +++ drivers/gpu/drm/gma500/psb_drv.c | 4 drivers/gpu/drm

[Intel-gfx] [PATCH v2 10/21] drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert radeon over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/atombios_crtc.c | 1 + drivers/gpu/drm/radeon/radeon_display.c | 13

[Intel-gfx] [PATCH v2 03/21] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

-by: Thomas Zimmermann --- drivers/gpu/drm/drm_vblank.c | 236 +-- include/drm/drm_crtc.h | 46 - include/drm/drm_modeset_helper_vtables.h | 4 +- include/drm/drm_vblank.h | 26 ++- 4 files changed, 292 insertions(+), 20

[Intel-gfx] [PATCH v2 05/21] drm/amdgpu: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert amdgpu over. v2: * don't wrap existing functions; change signature instead Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6

[Intel-gfx] [PATCH v2 07/21] drm/i915: Convert to CRTC VBLANK callbacks

. Instead pass i915's implementation of get_scanout_position() to DRM core's drm_crtc_vblank_helper_get_vblank_timestamp_internal(). v2: * use DRM's implementation of get_vblank_timestamp() * simplify function names Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v2 02/21] drm: Evaluate struct drm_device.vblank_disable_immediate on each use

the settings on each use of vblank_disable_immediate will allow for easy integration of CRTC VBLANK functions. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_vblank.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 19/21] drm/vkms: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vkms over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++--- drivers/gpu/drm/vkms/vkms_drv.c | 1 - drivers/gpu/drm/vkms/vkms_drv.h | 4

[Intel-gfx] [PATCH v2 21/21] drm: Clean-up VBLANK-related callbacks in struct drm_driver

removed is drm_calc_vbltimestamp_from_scanoutpos(). Callers of this function have been converted to use the CRTC instead. v2: * merge with removal of struct drm_driver.get_scanout_position() * remove drm_calc_vbltimestamp_from_scanoutpos() Signed-off-by: Thomas Zimmermann Reviewed

[Intel-gfx] [PATCH v2 12/21] drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position()

The callback struct drm_driver.get_scanout_position() is deprecated in favor of struct drm_crtc_helper_funcs.get_scanout_position(). Convert mem over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 67 +++ drivers/gpu/drm/msm/disp/mdp5

Re: [Intel-gfx] [PATCH v2 02/21] drm: Evaluate struct drm_device.vblank_disable_immediate on each use

Hi Am 15.01.20 um 15:37 schrieb Ville Syrjälä: > On Wed, Jan 15, 2020 at 01:16:33PM +0100, Thomas Zimmermann wrote: >> VBLANK interrupts can be disabled immediately or with a delay, where the >> latter is the default. The former option can be selected by setting >>

Re: [Intel-gfx] [PATCH v2 03/21] drm: Add get_vblank_timestamp() to struct drm_crtc_funcs

Hi Am 15.01.20 um 15:49 schrieb Ville Syrjälä: > On Wed, Jan 15, 2020 at 01:16:34PM +0100, Thomas Zimmermann wrote: >> The callback get_vblank_timestamp() is currently located in struct >> drm_driver, but really belongs into struct drm_crtc_funcs. Add an >> equ

Re: [Intel-gfx] [PATCH 23/23] drm: Cleanup VBLANK callbacks in struct drm_driver

Hi Am 12.01.20 um 23:53 schrieb Daniel Vetter: > On Fri, Jan 10, 2020 at 10:21:27AM +0100, Thomas Zimmermann wrote: >> All non-legacy users of VBLANK functions in struct drm_driver have been >> converted to use the respective interfaces in struct drm_crtc_funcs. The >> rema

[Intel-gfx] [PATCH v3 13/22] drm/msm: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert msm over. Signed-off-by: Thomas Zimmermann Tested-by: Yannick Fertré --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 2

[Intel-gfx] [PATCH v3 19/22] drm/vkms: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vkms over. Signed-off-by: Thomas Zimmermann Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_crtc.c | 9 ++--- drivers/gpu/drm/vkms

[Intel-gfx] [PATCH v3 21/22] drm: Clean-up VBLANK-related callbacks in struct drm_driver

removed is drm_calc_vbltimestamp_from_scanoutpos(). Callers of this function have been converted to use the CRTC instead. v2: * merge with removal of struct drm_driver.get_scanout_position() * remove drm_calc_vbltimestamp_from_scanoutpos() Signed-off-by: Thomas Zimmermann Reviewed

[Intel-gfx] [PATCH v3 18/22] drm/vc4: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vc4 over. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 + drivers/gpu/drm/vc4/vc4_drv.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff

[Intel-gfx] [PATCH v3 16/22] drm/sti: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert sti over. v2: * remove unnecessary include of sti_crtc.h from sti_drv.c Signed-off-by: Thomas Zimmermann Acked-by: Benjamin Gaignard --- drivers/gpu/drm/sti/sti_crtc.c

[Intel-gfx] [PATCH v3 20/22] drm/vmwgfx: Convert to CRTC VBLANK callbacks

VBLANK callbacks in struct drm_driver are deprecated in favor of their equivalents in struct drm_crtc_funcs. Convert vmwgfx over. v2: * remove accidental whitespace fixes Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 --- drivers/gpu/drm/vmwgfx

  1   2   3   4   5   6   7   8   9   10   >