Re: [Intel-gfx] [PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

On 22 June 2015 at 14:02, Daniel Vetter daniel.vet...@ffwll.ch wrote: We should never nest these since in theory kms drivers should know when a pipe is on/off and call the corresponding enable/disable functions for the vblank helper code only once. But for historical reasons (the

[Intel-gfx] [PATCH i-g-t] igt/kms_cursor_legacy: wrap __builtin_ia32_pause inside cpu_relax

So that we can add an alternative implementation for the other arches. This is basically what the kernel does. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_cursor_legacy.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a

[Intel-gfx] [PATCH v1 1/3] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/g

[Intel-gfx] [PATCH v1 3/3] drm/i915: Use new CRC debugfs API

so the current testsuite still passes. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 8 +- drivers/gpu/drm/i915/i915_dma.c | 2 - drivers/gpu/drm/i915/i915_drv.h | 21 -- drivers/gpu/drm/i915/i915_irq.c | 39 +--

[Intel-gfx] [PATCH v1 0/3] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (3): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

Re: [Intel-gfx] [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr.

On 06/22/2016 10:12 AM, Daniel Vetter wrote: > On Tue, Jun 21, 2016 at 02:41:29PM +0100, Emil Velikov wrote: >> On 21 June 2016 at 13:50, Marius Vlad wrote: >>> On Mon, Jun 20, 2016 at 03:52:35PM +0100, Emil Velikov wrote: Hi Rob, A couple of nitpicks and a

Re: [Intel-gfx] [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr.

On 22 June 2016 at 13:41, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Jun 22, 2016 at 12:40 PM, Tomeu Vizoso > <tomeu.viz...@collabora.com> wrote: >>>>>> Thinking about it... I'm not sure that the release manager will find >>>>>> this not

[Intel-gfx] [PATCH i-g-t] lib: Fix build when vc4 headers are present

Automake seems to not like variable assignments indented with tabs. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Fixes: 9e5478dc4345 ("lib: Only compile igt_vc4 is we have it") --- lib/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[Intel-gfx] [PATCH i-g-t] drm_read: Remove use of DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID

Instead of checking that there's a CRTC in pipe 0 with a valid mode, check that we can get a vblank in the primary display controller. This should be equivalent, but also works with drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/drm_read.

[Intel-gfx] [i-g-t PATCH v2 0/2] Avoid calling DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID

Hi, these two patches remove the two last uses of DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID, with the intention of making the tests runnable on !i915. I have looked in the kernel and cannot find any point where the pipe ID didn't match the index of the CRTC as returned by GETRESOURCES, so I'm not

[Intel-gfx] [i-g-t PATCH v2 1/2] lib: update kmstest_get_pipe_from_crtc_id

From: Micah Fedke <micah.fe...@collabora.co.uk> This function uses an intel-specific ioctl to fetch a mapping between pipes and crtc ids, but this technique is outdated as the crtc id is now always equivalent to its index in the array of crtcs returned by the kernel. Signed-off-by: Tomeu

[Intel-gfx] [i-g-t PATCH v2 2/2] overlay: Remove crtc<->pipe mapping code from kms-overlay

From: Micah Fedke <micah.fe...@collabora.co.uk> the crtc id is now always equivalent to its index in the array of crtcs returned by the kernel Signed-off-by: Micah Fedke <micah.fe...@collabora.co.uk> [tomeu: Fixed include path and removed some dead code] Signed-off-by: Tomeu Vizos

[Intel-gfx] [i-g-t PATCH v2 06/17] lib: Call intel_get_drm_devid only from intel code

It only makes sense when testing the i915 driver, so don't call it otherwise. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None lib/igt_fb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/igt_fb.c b/lib/igt_fb.c

[Intel-gfx] [i-g-t PATCH v2 09/17] lib: Add igt_dirty_fb

Just wraps drmModeDirtyFB and for now invalidates the whole FB. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: - Add igt_dirty_fb lib/igt_fb.c | 14 ++ lib/igt_fb.h | 1 + 2 files changed, 15 insertions(+) diff --git a/lib/igt_fb.c b/lib/ig

[Intel-gfx] [i-g-t PATCH v2 11/17] lib: Add igt_create_bo_with_dimensions

igt_create_bo_with_dimensions() is intended to abstract differences between drivers in buffer object creation. The driver-specific ioctls will be called if the driver that is being tested can satisfy the needs of the calling subtest, or it will be skipped otherwise. Signed-off-by: Tomeu Vizoso

[Intel-gfx] [i-g-t PATCH v2 10/17] lib: Map dumb buffers

If a buffer object is dumb, call DRM_IOCTL_MODE_MAP_DUMB when mapping it. Also, don't call DRM_IOCTL_I915_GEM_SET_DOMAIN on dumb buffers. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: - Call dirtyfb after the cairo context associated to a FB backed by a

[Intel-gfx] [i-g-t PATCH v2 02/17] lib: add igt_require_intel

Add function that requires that the driver we are talking to is i915. This allows us to skip subtests that are specific to that driver. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: - Rename is_intel to has_known_intel_chipset as suggested by Chris Wilson.

[Intel-gfx] [i-g-t PATCH v2 03/17] lib: Have gem_set_tiling require intel

-specific way. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None lib/ioctl_wrappers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 5d4972931506..0221b7fef3a1 100644 --- a/lib/ioctl_wrappers.c +++

[Intel-gfx] [i-g-t PATCH v2 00/17] Get a few more tests to run on !i915

instead of dumb_create from igt_create_bo_with_dimensions. - Add missing gtkdoc to igt_create_bo_with_dimensions. - Try to use GEM API when a stride is passed Tomeu Vizoso (17): lib: Rename is_intel to has_known_intel_chipset lib: add igt_require_intel lib: Have gem_set_tiling require

[Intel-gfx] [i-g-t PATCH v2 04/17] lib: Expose is_i915_device

Lib and test code can use this function to avoid i915-specific behavior when running on other drivers. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None lib/drmtest.c | 2 +- lib/drmtest.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [i-g-t PATCH v2 01/17] lib: Rename is_intel to has_known_intel_chipset

As it reflects more clearly what the function actually does. Suggested-by: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None lib/drmtest.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[Intel-gfx] [i-g-t PATCH v2 05/17] lib: Have intel_get_drm_devid call igt_require_intel

I915_PARAM_CHIPSET_ID is a i915-only thing, so if a subtest ends up calling it when testing another driver, let's skip it. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None lib/intel_chipset.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [i-g-t PATCH v2 07/17] lib: Add wrapper for DRM_IOCTL_MODE_CREATE_DUMB

In order to test drivers that don't have support for proper buffer objects, add a wrapper for creating dumb buffer objects that will be called from the lib code for those subtests that don't need to care. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: -

[Intel-gfx] [i-g-t PATCH v2 13/17] kms_addfb_basic: call igt_create_bo_with_dimensions

Many tests can do their work on drivers other than i915 and even with just dumb buffers, so call igt_create_bo_with_dimensions instead of gem_create which will paper out the differences and call the proper ioctls or cause the subtest to be skipped if that's not possible. Signed-off-by: Tomeu

[Intel-gfx] [i-g-t PATCH v2 14/17] kms_addfb_basic: move tiling functionality into each subtest

Because calls to gem_set_tiling will cause the subtest to be skipped on drivers other than i915, move them to each subtest that needs them so the other subtests aren't skipped as well. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None tests/kms_addfb_basic

[Intel-gfx] [i-g-t PATCH v2 08/17] lib: Add helper kmstest_dumb_map_buffer

Which basically just calls DRM_IOCTL_MODE_MAP_DUMB and is similar to gem_mmap__gtt(). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: - Add helper kmstest_dumb_map_buffer as suggested by Daniel Vetter lib/igt_kms.c | 16 lib/igt_kms.h | 3

[Intel-gfx] [i-g-t PATCH v2 15/17] kms_addfb_basic: Split tiling_tests off

Move tests requiring tiled BOs to the end so they don't cause unrelated subtests to be skipped when testing drivers with only dumb buffer support. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None tests/kms_addfb_basic.

[Intel-gfx] [i-g-t PATCH v2 12/17] tests: Open any driver

For those tests that now pass on drivers other than i915, call drm_open_driver_master with DRIVER_ANY. Also do so from igt_enable_connectors. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None lib/igt_kms.c | 2 +- tests/drm_read.c| 2 +-

[Intel-gfx] [i-g-t PATCH v2 17/17] kms_addfb_basic: Get intel gen from within subtest

Because determining the Intel GFX generation requires a call to DRM_IOCTL_I915_GETPARAM, move the code that requires it to a subtest that can be skipped on drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None tests/kms_addfb_basic.

[Intel-gfx] [i-g-t PATCH v2 16/17] kms_addfb_basic: Move calls to gem_set_tiling to the subtests

So they don't cause unrelated subtests to be skipped when testing drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Changes in v2: None tests/kms_addfb_basic.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a

Re: [Intel-gfx] [i-g-t PATCH v1 12/14] kms_addfb_basic: Split tiling_tests off

On 03/05/2016 01:33 PM, Daniel Vetter wrote: > On Wed, Mar 02, 2016 at 03:00:19PM +0100, Tomeu Vizoso wrote: >> Move tests requiring tiled BOs to the end so they don't cause unrelated >> subtests to be skipped when testing drivers with only dumb buffer >> support. > >

Re: [Intel-gfx] [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions

On 03/05/2016 01:30 PM, Daniel Vetter wrote: > On Wed, Mar 02, 2016 at 03:00:15PM +0100, Tomeu Vizoso wrote: >> igt_create_bo_with_dimensions() is intended to abstract differences >> between drivers in buffer object creation. >> >> The driver-specific ioctls w

[Intel-gfx] [i-g-t PATCH v1 01/14] lib: add igt_require_intel

Add function that requires that the driver we are talking to is i915. This allows us to skip subtests that are specific to that driver. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/drmtest.c | 5 + lib/drmtest.h | 2 ++ 2 files changed, 7 insertions(+) diff --git

[Intel-gfx] [i-g-t PATCH v1 05/14] lib: Call intel_get_drm_devid only from intel code

It only makes sense when testing the i915 driver, so don't call it otherwise. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_fb.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/igt_fb.c b/lib/igt_fb.c index 5f23136e01ac..3e76a4

[Intel-gfx] [i-g-t PATCH v1 03/14] lib: Expose is_i915_device

Lib and test code can use this function to avoid i915-specific behavior when running on other drivers. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/drmtest.c | 2 +- lib/drmtest.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/drmtest.c

[Intel-gfx] [i-g-t PATCH v1 02/14] lib: Have gem_set_tiling require intel

-specific way. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/ioctl_wrappers.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 5d4972931506..0221b7fef3a1 100644 --- a/lib/ioctl_wrappers.c +++ b/lib/ioctl_wrappers.c @@

[Intel-gfx] [i-g-t PATCH v1 04/14] lib: Have intel_get_drm_devid call igt_require_intel

I915_PARAM_CHIPSET_ID is a i915-only thing, so if a subtest ends up calling it when testing another driver, let's skip it. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/intel_chipset.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/intel_chipset.c

[Intel-gfx] [i-g-t PATCH v1 00/14] Get a few more tests to run on !i915

to be able to hide differences in the buffer creation API as much as possible. Thanks, Tomeu Tomeu Vizoso (14): lib: add igt_require_intel lib: Have gem_set_tiling require intel lib: Expose is_i915_device lib: Have intel_get_drm_devid call igt_require_intel lib: Call intel_get_drm_devid only

[Intel-gfx] [i-g-t PATCH v1 06/14] lib: Add wrapper for DRM_IOCTL_MODE_CREATE_DUMB

In order to test drivers that don't have support for proper buffer objects, add a wrapper for creating dumb buffer objects that will be called from the lib code for those subtests that don't need to care. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/ioctl_wrappers.

[Intel-gfx] [i-g-t PATCH v1 10/14] kms_addfb_basic: call igt_create_bo_with_dimensions

Many tests can do their work on drivers other than i915 and even with just dumb buffers, so call igt_create_bo_with_dimensions instead of gem_create which will paper out the differences and call the proper ioctls or cause the subtest to be skipped if that's not possible. Signed-off-by: Tomeu

[Intel-gfx] [i-g-t PATCH v1 13/14] kms_addfb_basic: Move calls to gem_set_tiling to the subtests

So they don't cause unrelated subtests to be skipped when testing drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_addfb_basic.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/kms_addfb_basic.c b

[Intel-gfx] [i-g-t PATCH v1 12/14] kms_addfb_basic: Split tiling_tests off

Move tests requiring tiled BOs to the end so they don't cause unrelated subtests to be skipped when testing drivers with only dumb buffer support. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_addfb_basic.c | 50 -

[Intel-gfx] [i-g-t PATCH v1 07/14] lib: Map dumb buffers

If a buffer object is dumb, call DRM_IOCTL_MODE_MAP_DUMB when mapping it. Also, don't call DRM_IOCTL_I915_GEM_SET_DOMAIN on dumb buffers. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_fb.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-)

[Intel-gfx] [i-g-t PATCH v1 14/14] kms_addfb_basic: Get intel gen from within subtest

Because determining the Intel GFX generation requires a call to DRM_IOCTL_I915_GETPARAM, move the code that requires it to a subtest that can be skipped on drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_addfb_basic.

[Intel-gfx] [i-g-t PATCH v1 11/14] kms_addfb_basic: move tiling functionality into each subtest

Because calls to gem_set_tiling will cause the subtest to be skipped on drivers other than i915, move them to each subtest that needs them so the other subtests aren't skipped as well. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_addfb_basic.c | 8

[Intel-gfx] [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions

igt_create_bo_with_dimensions() is intended to abstract differences between drivers in buffer object creation. The driver-specific ioctls will be called if the driver that is being tested can satisfy the needs of the calling subtest, or it will be skipped otherwise. Signed-off-by: Tomeu Vizoso

Re: [Intel-gfx] [PATCH i-g-t v2 0/2] core_getversion: Only verify major version for i915.

On 21 April 2016 at 11:20, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 12:25:50PM -0400, robert.f...@collabora.com wrote: >> From: Robert Foss >> >> This series enables tests/core_getversion to test vc4. >> It's been tested on rpi2 hardware and

[Intel-gfx] [PATCH i-g-t] lib: Actually use provided size when creating BO

up calling just create_bo_for_fb with a zero size because now the later is more generic than the former. Also, create_bo_for_fb now returns the handle of the BO that was created, as there's no point anymore in having it be a parameter passed by reference. Signed-off-by: Tomeu Vizoso <tomeu.

Re: [Intel-gfx] [PATCH i-g-t v3 1/4] lib/igt_kms: Add support for up to 10 planes.

On 25 April 2016 at 17:05, wrote: > From: Robert Foss > > Increase the number of planes supported to 10. > > kmstest_plane_name only previously supported 4 planes, > this patch adds support for up to 10 planes. > > Signed-off-by: Robert Foss

Re: [Intel-gfx] [PATCH i-g-t v2 0/6] Improve kms_panel_fitting.

On 25 April 2016 at 16:35, wrote: > From: Robert Foss > > > Changes since v1: > - Squash patches > - Based patch on > https://lists.freedesktop.org/archives/intel-gfx/2016-March/090617.html Thanks for the patches, you can add my

Re: [Intel-gfx] [PATCH i-g-t v3 4/4] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

On 25 April 2016 at 17:05, wrote: > From: Robert Foss > > Previously crtc0 was statically used for VBLANK tests, but > that assumption is not valid for the VC4 platform. > Instead we're now explicitly setting the mode. > > Also add support

Re: [Intel-gfx] [i-g-t PATCH v1 0/7] Make more tests generic

On 20 April 2016 at 16:12, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Apr 20, 2016 at 03:57:53PM +0200, Tomeu Vizoso wrote: >> On 20 April 2016 at 15:10, Daniel Vetter <dan...@ffwll.ch> wrote: >> > On Mon, Apr 18, 2016 at 01:42:48PM +0200

Re: [Intel-gfx] [i-g-t PATCH v1 0/7] Make more tests generic

On 25 April 2016 at 15:13, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: > On 20 April 2016 at 16:12, Daniel Vetter <dan...@ffwll.ch> wrote: >> On Wed, Apr 20, 2016 at 03:57:53PM +0200, Tomeu Vizoso wrote: >>> On 20 April 2016 at 15:10, Daniel Vetter <dan...@f

[Intel-gfx] [PATCH i-g-t] build: Skip configure step if is NOCONFIGURE set

Allow users of autogen.sh to skip the call to configure, which is needed when building out of tree. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- autogen.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 629a25

[Intel-gfx] [PATCH i-g-t 1/2] tests/testdisplay: Use cairo helpers to draw to plane

Paint the color key with cairo, so the test doesn't have to map the BO by itself, which depends on the driver being tested. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Don't know what's the purpose of drawing this rect, so it would be better to remove it if it isn't

[Intel-gfx] [PATCH i-g-t 2/2] tests/testdisplay: Open DRM device with DRIVER_ANY

So that this test can be run in drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/testdisplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index f821bcc64779..45280e4cad82

[Intel-gfx] [i-g-t PATCH v1 1/7] tests/drm_read: Drop DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID

So the test runs on other drivers, drop the usage of the i915-specific DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID ioctl. Wait for a vblank event on pipe0 and if we get it, then the test can proceed (code copied from kms_vblank). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> ---

[Intel-gfx] [i-g-t PATCH v1 0/7] Make more tests generic

Hi, these patches allow a few more tests to run on drivers other than i915, mainly by removing the last usage of DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID and removing superfluous dependencies on bufmgr and tiled BOs. Thanks, Tomeu Tomeu Vizoso (7): tests/drm_read: Drop

[Intel-gfx] [i-g-t PATCH v1 3/7] tests/kms_flip: Create tiled BOs only when needed

Because attempts to create a tiled BO will cause a igt_require call to fail on drivers that don't support tiling, do so in the subtest that actually needs it so that other subtests aren't skipped without reason. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_flip.

Re: [Intel-gfx] [i-g-t PATCH v2 0/2] Avoid calling DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID

Hello, can these two patches be pushed if everybody is fine with them? Thanks, Tomeu On 9 March 2016 at 16:57, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: > Hi, > > these two patches remove the two last uses of > DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID, with the i

[Intel-gfx] [i-g-t PATCH v1 7/7] tests/kms_flip_event_leak: Open DRM device with DRIVER_ANY

So that this test can be run in drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_flip_event_leak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c index 0a4a75

[Intel-gfx] [i-g-t PATCH v1 5/7] tests/kms_flip: Open DRM device with DRIVER_ANY

So that this test can be run in drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_flip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 58b167d46d90..dc251e902bef 100644 --- a

[Intel-gfx] [i-g-t PATCH v1 4/7] tests/kms_flip: Move bufmgr requirement into subtests

Because bufmgr is currently a i915-only thing and it's only needed in a subset of the subtests, require it only in the subtests that actually need it so that the other subtests aren't skipped without a reason. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_flip.

[Intel-gfx] [i-g-t PATCH v1 6/7] tests/kms_flip_event_leak: Use non-tiled formats

As the test doesn't actually need tiled BOs, drop the tiled formats so the test can run on drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_flip_event_leak.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[Intel-gfx] [i-g-t PATCH v1 2/7] tests/kms_render: Move dependency on i915 into subtest

Batchbuffers are only needed in the subtest that does the blit on the GPU, so move that dependency into it so the other subtest can be ran on !i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_render.c | 21 - 1 file changed, 12 insertions

Re: [Intel-gfx] [i-g-t PATCH v2 1/2] lib: update kmstest_get_pipe_from_crtc_id

On 18 April 2016 at 14:09, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Mar 09, 2016 at 04:57:37PM +0100, Tomeu Vizoso wrote: >> From: Micah Fedke <micah.fe...@collabora.co.uk> >> >> This function uses an intel-specific ioctl to fetch a mapping

Re: [Intel-gfx] [i-g-t PATCH v1 0/7] Make more tests generic

On 20 April 2016 at 15:10, Daniel Vetter <dan...@ffwll.ch> wrote: > On Mon, Apr 18, 2016 at 01:42:48PM +0200, Tomeu Vizoso wrote: >> Hi, >> >> these patches allow a few more tests to run on drivers other than i915, >> mainly by removing the last usage of >&g

[Intel-gfx] [PATCH] tests/kms_addfb_basic: Set tiling in addfb25 subtest

When moving the call to gem_set_tiling into the subtests, the one needed by addfb25-framebuffer-vs-set-tiling was left out. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_addfb_basic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/kms_addfb_basic.c b

[Intel-gfx] [i-g-t PATCH v1 2/2] tests/kms_setmode: Remove superfluous call to kmstest_get_pipe_from_crtc_id

connector_config.crtc_idx already contains the pipe ID, so just use that and drop the call to kmstest_get_pipe_from_crtc_id which is problematic on drivers other than i915 because it uses DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com>

[Intel-gfx] [i-g-t PATCH v1 0/2] Avoid calling DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID on !i915

of querying for the pipe number (which should return the same value). Thanks, Tomeu Tomeu Vizoso (2): lib: Remove superfluous kmstest_connector_config.pipe tests/kms_setmode: Remove superfluous call to kmstest_get_pipe_from_crtc_id lib/igt_kms.c | 24

[Intel-gfx] [i-g-t PATCH v1 1/2] lib: Remove superfluous kmstest_connector_config.pipe

the tests on drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_kms.c | 24 +++- lib/igt_kms.h | 1 - tests/kms_crtc_background_color.c | 2 +- tests/kms_flip.c

[Intel-gfx] [PATCH] tests/kms_addfb_basic: Move tiling tests into their own groups

So those subtests that require tiling don't cause unrelated subtests to be skipped. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_addfb_basic.c | 148 1 file changed, 73 insertions(+), 75 deletions(-) diff --git a

[Intel-gfx] [PATCH] lib: Declare loop variable as volatile before setjmp

_addfb_basic.c:245:3: note: in expansion of macro 'igt_fixture' igt_fixture { Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_core.h b/lib/igt_core.h index b3fa7356e473..1b62371a7138 1

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib/igt_kms: Make sure that default planes aren't overwritten.

On 20 April 2016 at 16:59, wrote: > From: Robert Foss > > Avoid overwriting planes with statically asigned indices > with planes that have dynamically assigned indices. > > Signed-off-by: Robert Foss > --- >

Re: [Intel-gfx] [PATCH i-g-t] lib: Pass format instead of bpp to create_bo_for_fb()

but not all callers were updated. Fix that up. > > Cc: Tomeu Vizoso <tomeu.viz...@collabora.com> > Fixes: 8a1a38661f56 ("lib: Add igt_create_bo_with_dimensions") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93328 > Signed-off-by: Ville Syrjälä <ville.syrj...@

Re: [Intel-gfx] [PATCH i-g-t 2/7] lib/igt_kms: Fix plane counting in igt_display_init.

On 20 April 2016 at 16:59, wrote: > From: Robert Foss > > Fix issue where the plane counting fails due to the number and > configuration of planes being unlike the intel configuration. > > Signed-off-by: Robert Foss

Re: [Intel-gfx] [PATCH i-g-t 4/7] lib/igt_kms: Only move the in cursor plane for Intel hw.

On 20 April 2016 at 16:59, wrote: > From: Robert Foss > > Avoid moving the cursor plane when on non-intel hardware. > Running the move block on hardware with more than IGT_PLANE_CURSOR > number of planes causes planes do be zeroed out. > >

[Intel-gfx] [PATCH v3 1/3] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.

[Intel-gfx] [PATCH v3 0/3] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (3): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

[Intel-gfx] [PATCH v3 3/3] drm/i915: Use new CRC debugfs API

ore is incompatible with it. v3: - Use the "cooked" vblank counter so we have a whole 32 bits. - Make sure we don't mess with the state of the legacy CRC capture ABI implementation. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915: Use new CRC debugfs API

On 3 August 2016 at 10:01, Daniel Vetter <dan...@ffwll.ch> wrote: > On Fri, Jul 22, 2016 at 04:10:45PM +0200, Tomeu Vizoso wrote: >> The core provides now an ABI to userspace for generation of frame CRCs, >> so implement the ->set_crc_source() callback and reuse as

[Intel-gfx] [PATCH v2 0/3] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (3): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

[Intel-gfx] [PATCH v2 3/3] drm/i915: Use new CRC debugfs API

ore is incompatible with it. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/i915/i915_irq.c | 57 --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_pipe_c

[Intel-gfx] [PATCH v2 1/3] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.

[Intel-gfx] [PATCH v4 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.

[Intel-gfx] [PATCH v4 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 inse

[Intel-gfx] [PATCH v4 3/4] drm/i915: Use new CRC debugfs API

. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/i915/i915_irq.c | 69 --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 2 + drivers/gpu/drm/i915/intel_pipe_crc.c | 124

[Intel-gfx] [PATCH v4 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

[Intel-gfx] [PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

?id=99869 Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 24e7b282f16c..d994ccf94f88 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gp

[Intel-gfx] [PATCH i-g-t] kms_flip: Calculate max acceptable delta for TEST_TS_CONT

and calculates an acceptable difference taking into account the vertical refresh rate of the current mode. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> References: https://bugs.freedesktop.org/show_bug.cgi?id=98289 --- tests/kms_flip.c | 16 1 file changed, 12 inse

Re: [Intel-gfx] [PATCH i-g-t] lib: Add basic support for valgrind annotations.

Patch looks good to me, but I think the signal changes should be in their own commit. On 7 February 2017 at 16:12, Maarten Lankhorst wrote: ... > +#define VG(x) x > +#else > +#define VG(x) > +#endif Wouldn't be better to stub VALGRIND_MAKE_MEM_DEFINED instead?

Re: [Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines

On 10 January 2017 at 17:31, Daniel Vetter <dan...@ffwll.ch> wrote: > On Tue, Jan 10, 2017 at 05:54:57PM +0200, Ville Syrjälä wrote: >> On Tue, Jan 10, 2017 at 02:43:05PM +0100, Tomeu Vizoso wrote: >> > Use drm_accurate_vblank_count so we have the full 32 bit to represen

[Intel-gfx] [PATCH i-g-t 1/2] lib: Remove i915ism when checking that debugfs is mounted

Instead of checking for "i915_error_state" within dri/N/, check for "name". This allows more tests to run against drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Intel-gfx] [PATCH i-g-t 2/2] kms_pipe_crc_basic: Skip sequence tests if the source doesn't provide frame numbers

Some frame sources such as sinks aren't able to provide meaningful frame numbers, so in those cases just skip the TEST_SEQUENCE tests. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_pipe_crc_basic.c | 29 +++-- 1 file changed, 23 insertions

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Remove i915ism when checking that debugfs is mounted

On 2 March 2017 at 11:12, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tomeu Vizoso wrote: >> Instead of checking for "i915_error_state" within dri/N/, check for >> "name". >> >> This allows more t

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Remove i915ism when checking that debugfs is mounted

On 2 March 2017 at 14:46, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Mar 02, 2017 at 02:39:16PM +0100, Tomeu Vizoso wrote: >> On 2 March 2017 at 11:12, Chris Wilson <ch...@chris-wilson.co.uk> wrote: >> > On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tom

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Use new CRC debugfs API

On 5 September 2016 at 14:44, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 5 September 2016 at 10:45, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: >> On 2 September 2016 at 17:18, Emil Velikov <emil.l.veli...@gmail.com> wrote: >>> Hi Tomeu, >>

[Intel-gfx] [PATCH v5 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.

[Intel-gfx] [PATCH v5 3/4] drm/i915: Use new CRC debugfs API

p commit. v5: - Skip first frame or two as it's known that they contain wrong data. - A few fixes suggested by Emil Velikov. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i91

[Intel-gfx] [PATCH v5 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 inse

  1   2   3   >