Re: [Intel-gfx] [PATCH v2] drm/i915: Drop WA to fix Voltage not getting dropped to Vmin when Gfx is power gated for latest VLV revision

2014-06-27 Thread Ville Syrjälä
Latest VLV doesn't need to force the gfx clock or something like that. We are still doing this to reduce Vnn after all. Apart from that this matches my observations so: Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com + if (dev-pdev-revision = 0xd) { + valleyview_set_rps

Re: [Intel-gfx] [PATCH] drm/i915: Introduce FBC False Color for debug purposes.

2014-07-28 Thread Ville Syrjälä
i915_fbc_fc_get(void *data, u64 *val) +{ + struct drm_device *dev = data; + struct drm_i915_private *dev_priv = dev-dev_private; + + if (INTEL_INFO(dev)-gen 5) + return -ENODEV; Did you test this on ILK/SNB? Bspec says the bit is MBZ before IVB. -- Ville Syrjälä Intel OTC

Re: [Intel-gfx] [PATCH 03/40] drm/i915: Align chv rps min/max/rpe values

2014-07-28 Thread Ville Syrjälä
On Sat, Jul 12, 2014 at 07:16:15PM +0530, Deepak S wrote: On Saturday 28 June 2014 04:33 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com CHV wants even rps opcodes so make sure the min/max/rpe values are also even. Signed-off-by: Ville

Re: [Intel-gfx] [PATCH 17/40] drm/i915: Add chv cmnlane power wells

2014-07-28 Thread Ville Syrjälä
On Fri, Jul 25, 2014 at 02:55:00PM +0300, Imre Deak wrote: On Sat, 2014-06-28 at 02:04 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com CHV has two display PHYs so there are also two cmnlane power wells. Add the approriate code to power

Re: [Intel-gfx] [PATCH 22/40] drm/i915: Add chv port D TX wells

2014-07-28 Thread Ville Syrjälä
On Fri, Jul 25, 2014 at 04:30:29PM +0300, Imre Deak wrote: On Sat, 2014-06-28 at 02:04 +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Add the TX wells for port D. The Punit subsystem numbers are a total guess at this time. Also I'm not sure

Re: [Intel-gfx] [PATCH] drm: Add rotation_property to mode_config and creating it

2014-07-28 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org

Re: [Intel-gfx] [RFC] drm/i915/bdw: Initialize BDW workarounds in render ring init fn

2014-07-28 Thread Ville Syrjälä
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [RFC] Move BDW workarounds to ring init fn

2014-07-28 Thread Ville Syrjälä
+ 3 files changed, 114 insertions(+), 59 deletions(-) -- 1.9.2 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC

Re: [Intel-gfx] [PATCH] drm: Add rotation_property to mode_config and creating it

2014-07-29 Thread Ville Syrjälä
On Mon, Jul 28, 2014 at 08:47:22PM +0200, Daniel Vetter wrote: On Mon, Jul 28, 2014 at 06:29:41PM +0300, Ville Syrjälä wrote: On Tue, Jul 15, 2014 at 05:43:37PM +0530, sonika.jin...@intel.com wrote: From: Sonika Jindal sonika.jin...@intel.com v2: Adding creation of rotation_property

Re: [Intel-gfx] [PATCH] drm/i915: Fix read back of plane stride register

2014-07-29 Thread Ville Syrjälä
On Mon, Jul 28, 2014 at 07:56:27PM +0100, rafael.barba...@intel.com wrote: From: Rafael Barbalho rafael.barba...@intel.com According to the specifications bit 6 is actually valid in the stride register. Cc: Jesse Barnes jbar...@virtuousgeek.org Cc: Ville Syrjälä ville.syrj

Re: [Intel-gfx] [RFC] drm/i915/bdw: Initialize BDW workarounds in render ring init fn

2014-07-29 Thread Ville Syrjälä
On Mon, Jul 28, 2014 at 09:46:33PM +0100, Siluvery, Arun wrote: On 28/07/2014 18:00, Ville Syrjälä wrote: On Mon, Jul 28, 2014 at 05:31:46PM +0100, arun.siluv...@linux.intel.com wrote: From: Arun Siluvery arun.siluv...@linux.intel.com The workarounds at the moment are initialized

Re: [Intel-gfx] [PATCH 1/3] drm/i915: fix cursor handling when runtime suspended

2014-07-29 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Intel-gfx] [PATCH] drm/i915: Correctly read backlight PWM for pipe B on vlv/chv

2014-07-29 Thread Ville Syrjälä
from that pipe. Cc: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Rafael Barbalho rafael.barba...@intel.com --- drivers/gpu/drm/i915/intel_panel.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c

Re: [Intel-gfx] [PATCH 1/2] drm/i915: factor out intel_edp_panel_vdd_sanitize

2014-07-29 Thread Ville Syrjälä
) + return; I'd move the intel_dp assignment after the encoder type check to avoid anyone thinking that they're allowed to dereference it before we're sure about the type. Apart from that both patches are: Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com + + if (!edp_have_panel_vdd

Re: [Intel-gfx] [PATCH 10/9] drm: Add dev-vblank_disable_immediate flag

2014-07-29 Thread Ville Syrjälä
On Thu, Jun 19, 2014 at 05:41:24PM -0700, Matt Roper wrote: On Mon, May 26, 2014 at 05:26:47PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Add a flag to drm_device which will cause the vblank code to bypass the disable timer and always

Re: [Intel-gfx] [PATCH 34/40] drm/i915: Add DP training pattern 3 for CHV

2014-07-29 Thread Ville Syrjälä
On Tue, Jul 29, 2014 at 08:04:59PM +0200, Daniel Vetter wrote: On Tue, Jul 29, 2014 at 10:01:57AM -0700, Jesse Barnes wrote: On Sat, 28 Jun 2014 02:04:25 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com CHV supports DP training pattern

Re: [Intel-gfx] [PATCH 06/40] drm/i915: Add cdclk change support for chv

2014-07-29 Thread Ville Syrjälä
On Tue, Jul 29, 2014 at 09:51:03AM -0700, Jesse Barnes wrote: On Sat, 28 Jun 2014 02:03:57 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Looks like the Punit is supposed to support the 400MHz cdclk directly on chv, so we don't need

Re: [Intel-gfx] [PATCH 37/40] drm/i915: Fix eDP link training when switching pipes

2014-07-29 Thread Ville Syrjälä
On Tue, Jul 29, 2014 at 08:06:57PM +0200, Daniel Vetter wrote: On Mon, Jun 30, 2014 at 02:52:12PM -0700, Jesse Barnes wrote: On Sat, 28 Jun 2014 02:04:28 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com When switching from one pipe

Re: [Intel-gfx] [RFC] Move BDW workarounds to ring init fn

2014-07-30 Thread Ville Syrjälä
On Tue, Jul 29, 2014 at 11:27:55PM +0100, Siluvery, Arun wrote: On 28/07/2014 18:26, Ville Syrjälä wrote: On Mon, Jul 28, 2014 at 05:31:45PM +0100, arun.siluv...@linux.intel.com wrote: From: Arun Siluvery arun.siluv...@linux.intel.com This patch moves BDW workarounds from

Re: [Intel-gfx] [PATCH 31/40] drm/i916: Init chv workarounds at render ring init

2014-07-30 Thread Ville Syrjälä
Subject: [Intel-gfx] [PATCH 31/40] drm/i916: Init chv workarounds at render ring init From: Ville Syrjälä ville.syrj...@linux.intel.com My bsw is an unhappy camper if we delay the workaround init until init_clock_gating(). Move a bunch of it to the render ring init. FIXME: need to do

Re: [Intel-gfx] [PATCH 7/8] drm/irq: Implement a generic vblank_wait function

2014-07-30 Thread Ville Syrjälä
count first and wait for it (taking wraparound into account obviously). -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 26/40] drm/i915: Parametrize VLV_DDL registers

2014-07-31 Thread Ville Syrjälä
On Wed, Jul 30, 2014 at 05:43:10PM -0300, Paulo Zanoni wrote: 2014-06-27 20:04 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com The VLV/CHV DDL registers are uniform, and neatly enough the register offsets are sane so we can easily unify them

Re: [Intel-gfx] [PATCH] drm/i915: Skip Stolen Memory first page.

2014-07-31 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Intel-gfx] [PATCH 09/12] Do more checks for proposed flip pixmaps

2014-07-31 Thread Ville Syrjälä
believe some people working on just that. We could even change the pixel format, except a check was added to drm_mode_page_flip_ioctl() to prevent that, so I guess it was deemed that the API isn't meant to allow that. -- Ville Syrjälä Intel OTC ___ Intel

Re: [Intel-gfx] [PATCH 23/40] drm/i915: Fix drain latency precision multipler for VLV

2014-07-31 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http

Re: [Intel-gfx] [PATCH 09/12] Do more checks for proposed flip pixmaps

2014-07-31 Thread Ville Syrjälä
On Thu, Jul 31, 2014 at 08:20:20AM -0700, Keith Packard wrote: Ville Syrjälä ville.syrj...@linux.intel.com writes: Now that we have mmio flips in the kernel we can start to relax that restriction. That still needs a bit more work in the mmio flip code but I believe some people working

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Initialize the aliasing ppgtt as part of global gtt

2014-07-31 Thread Ville Syrjälä
-mm.aliasing_ppgtt = ppgtt; + } + return 0; } -- 1.9.3 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC

Re: [Intel-gfx] [PATCH 23/40] drm/i915: Fix drain latency precision multipler for VLV

2014-07-31 Thread Ville Syrjälä
On Thu, Jul 31, 2014 at 02:05:49PM -0300, Paulo Zanoni wrote: 2014-07-31 12:16 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Thu, Jul 31, 2014 at 12:08:09PM -0300, Paulo Zanoni wrote: 2014-06-27 20:04 GMT-03:00 ville.syrj...@linux.intel.com: From: Zhenyu Wang zhen

Re: [Intel-gfx] [PATCH] drm/i915: Introduce FBC False Color for debug purposes.

2014-08-01 Thread Ville Syrjälä
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: don't try and probe dpcd if we have no dp configured

2014-08-01 Thread Ville Syrjälä
; } -- 1.9.3 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 25/40] drm/i915: Fill out the FWx watermark register defines

2014-08-01 Thread Ville Syrjälä
On Thu, Jul 31, 2014 at 05:16:21PM -0300, Paulo Zanoni wrote: 2014-06-27 20:04 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Add defines for all the watermark registers on modernish gmch platforms. VLV has increased the number of bits

Re: [Intel-gfx] [PATCH 28/40] drm/i915: Add cherryview_update_wm()

2014-08-01 Thread Ville Syrjälä
On Thu, Jul 31, 2014 at 05:57:33PM -0300, Paulo Zanoni wrote: 2014-06-27 20:04 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com CHV has a third pipe so we need to compute the watermarks for its planes. Add cherryview_update_wm() to do just

Re: [Intel-gfx] [PATCH] drm/i915: Add a bit of locking to intel_dp_hpd_pulse()

2014-08-01 Thread Ville Syrjälä
it at that point anyways. Dave. -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: fix VDD state tracking after system resume

2014-08-01 Thread Ville Syrjälä
: - unchanged v3: - call edp sanitizing from the encoder reset handler (Daniel) It happens a bit earlier than with the earlier attempt, but if it works it works. Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com Reported-and-tested-by: Jarkko Nikula jarkko.nik...@linux.intel.com Signed-off

Re: [Intel-gfx] [PATCH 24/40] drm/i915: Fix threshold for choosing 32 vs. 64 precisions for VLV DDL values

2014-08-01 Thread Ville Syrjälä
On Thu, Jul 31, 2014 at 03:08:29PM -0300, Paulo Zanoni wrote: 2014-06-27 20:04 GMT-03:00 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com The DDL registers can hold 7bit numbers. Make the most of those seven bits by adjusting the threshold where we switch

Re: [Intel-gfx] [PATCH 14/40] drm/i915: Override display PHY TX FIFO reset master on chv

2014-08-01 Thread Ville Syrjälä
On Tue, Jul 29, 2014 at 09:57:09AM -0700, Jesse Barnes wrote: On Sat, 28 Jun 2014 02:04:05 +0300 ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Just an attempt to frob these bits. Apparently we should not need to touch them (apart from maybe

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-01 Thread Ville Syrjälä
to be handled somewhere a bit higher up. return 0; -- 1.9.3 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC

Re: [Intel-gfx] [PATCH] drm: Add rotation_property to mode_config and creating it

2014-08-04 Thread Ville Syrjälä
On Mon, Aug 04, 2014 at 03:59:23PM +0530, Jindal, Sonika wrote: On 7/31/2014 9:39 AM, Jindal, Sonika wrote: On 7/29/2014 4:00 PM, Daniel Vetter wrote: On Tue, Jul 29, 2014 at 12:40:29PM +0300, Ville Syrjälä wrote: On Mon, Jul 28, 2014 at 08:47:22PM +0200, Daniel Vetter wrote

Re: [Intel-gfx] [PATCH 6/6] drm: Resetting rotation property

2014-08-04 Thread Ville Syrjälä
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Add a bit of locking to intel_dp_hpd_pulse()

2014-08-04 Thread Ville Syrjälä
On Mon, Aug 04, 2014 at 10:10:50AM +0200, Daniel Vetter wrote: On Fri, Aug 01, 2014 at 02:55:22PM +0300, Ville Syrjälä wrote: On Thu, Jul 31, 2014 at 08:59:08PM +1000, Dave Airlie wrote: On 31 July 2014 17:37, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Jul 31, 2014 at 1:49 AM, Dave

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Generalize drain latency computation

2014-08-04 Thread Ville Syrjälä
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Tune down MCH_SSKPD values warning

2014-08-04 Thread Ville Syrjälä
high resolutions. So tune it down to a level where only developers can see it. Also drop some of the end-user fluff. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Both patches make sense to me so: Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 4/7] drm/i915/bdw: cs-stall before state cache invld w/a

2014-08-05 Thread Ville Syrjälä
Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Round-up clock and limit drain latency

2014-08-05 Thread Ville Syrjälä
to me so: Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com + return true; } -- 1.7.9.5 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Generalize drain latency computation

2014-08-05 Thread Ville Syrjälä
http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get CZ clock for VLV

2014-08-05 Thread Ville Syrjälä
, cdclk); } + static int i945_get_display_clock_speed(struct drm_device *dev) { return 40; -- 2.0.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville

Re: [Intel-gfx] [PATCH 0/6 v2] Add 180 degree primary and sprite rotation

2014-08-05 Thread Ville Syrjälä
. It is attached to different planes. v2: Moving the creation of property back to i915 (Ville) and resetting property after disabling plane (Ville) The series looks good to me. For the patches not authored by me: Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com Sonika Jindal (3): drm

Re: [Intel-gfx] [PATCH v2] drm/i915: Add sprite watermark programming for VLV and CHV

2014-08-05 Thread Ville Syrjälä
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get CZ clock for VLV

2014-08-05 Thread Ville Syrjälä
On Tue, Aug 05, 2014 at 08:57:07PM +0530, Vandana Kannan wrote: On Aug-05-2014 6:39 PM, Ville Syrjälä wrote: On Mon, Aug 04, 2014 at 10:44:04PM +0530, Vandana Kannan wrote: CZ clock is related to data flow from memory to display plane. This is required for comparison with CD clock before

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add thread stall DOP clock gating workaround on Broadwell.

2014-08-05 Thread Ville Syrjälä
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 15/19] drm: Update vblank-last in drm_update_vblank_count()

2014-08-06 Thread Ville Syrjälä
On Wed, Aug 06, 2014 at 03:08:25PM +0200, Daniel Vetter wrote: On Wed, Aug 06, 2014 at 02:49:58PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We should update the last in drm_update_vblank_count() to avoid applying the diff more than once

Re: [Intel-gfx] [PATCH 09/19] drm: Fix race between drm_vblank_off() and drm_queue_vblank_event()

2014-08-06 Thread Ville Syrjälä
On Wed, Aug 06, 2014 at 03:23:01PM +0200, Daniel Vetter wrote: On Wed, Aug 06, 2014 at 02:49:52PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Currently it's possible that the following will happen: 1. drm_wait_vblank() calls

Re: [Intel-gfx] [PATCH 17/19] drm/i915: Clear .last vblank count before drm_vblank_off() when sanitizing crtc state

2014-08-06 Thread Ville Syrjälä
On Wed, Aug 06, 2014 at 03:30:17PM +0200, Daniel Vetter wrote: On Wed, Aug 06, 2014 at 02:50:00PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We call drm_vblank_off() during crtc sanitation to make sure the software and hardware states

Re: [Intel-gfx] [PATCH v3] drm/i915: Generalize drain latency computation

2014-08-06 Thread Ville Syrjälä
WARN check for clock and pixel size - Simplified bit masking - Use cursor_base instead of reg read v3: Changed to bitwise shorthand operator for plane_dl assignment. Signed-off-by: Gajanan Bhat gajanan.b...@intel.com Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com

Re: [Intel-gfx] [PATCH V3] drm/i915: Add sprite watermark programming for VLV and CHV

2014-08-07 Thread Ville Syrjälä
to avoid multiple if-else - Changed bit masking to customary form - Changed to bitwise shorthand operator for sprite_dl assignment Signed-off-by: Gajanan Bhat gajanan.b...@intel.com Looks good. Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH] drm/i915: Reset the HEAD pointer for the ring after writing START

2014-08-07 Thread Ville Syrjälä
://bugs.freedesktop.org/show_bug.cgi?id=76554 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_ringbuffer.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers

Re: [Intel-gfx] [PATCH] drm/i915: Reset the HEAD pointer for the ring after writing START

2014-08-07 Thread Ville Syrjälä
unconditionally anyway References: https://bugs.freedesktop.org/show_bug.cgi?id=76554 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Ville Syrjälä ville.syrj...@linux.intel.com Yeah looks sensible to me. So based on my gut feeling just from the seeing the w/a name this is: Reviewed-by: Ville

Re: [Intel-gfx] [PATCH] drm/i915: Continuation of future readiness series

2014-08-08 Thread Ville Syrjälä
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [RFC] drm/i915/bdw: Apply workarounds to the golden render state

2014-08-08 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Program PFI credits for VLV

2014-08-08 Thread Ville Syrjälä
drm_device *dev) { -- 2.0.1 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH] drm/i915: Fix erroneous conversion to u8

2014-08-08 Thread Ville Syrjälä
deepa...@linux.intel.com Cc: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Fix erroneous conversion to u8

2014-08-08 Thread Ville Syrjälä
new_delay an int in case we overflow the u8 in the intermediate computations. new_delay will get clamped at the end anyway. (Ville) Cc: Deepak S deepa...@linux.intel.com Cc: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Damien Lespiau damien.lesp...@intel.com Reviewed-by: Ville

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Remove an unreachable 'return'

2014-08-11 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-11 Thread Ville Syrjälä
@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-11 Thread Ville Syrjälä
On Mon, Aug 11, 2014 at 11:29:21AM -0300, Paulo Zanoni wrote: 2014-08-11 8:32 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Wed, Aug 06, 2014 at 06:26:01PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com If we're runtime suspended and try to use

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-12 Thread Ville Syrjälä
On Mon, Aug 11, 2014 at 02:57:44PM -0300, Paulo Zanoni wrote: 2014-08-11 11:42 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Mon, Aug 11, 2014 at 11:29:21AM -0300, Paulo Zanoni wrote: 2014-08-11 8:32 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Wed, Aug 06, 2014

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after enabling the primary plane on BDW

2014-08-12 Thread Ville Syrjälä
: Reviewed-by: Rodrigo Vivi rodrigo.v...@intel.com Pushed to -fixes, thanks for the patch and review. BR, Jani. On Tue, Jun 24, 2014 at 3:59 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com BDW signals the flip done interrupt

Re: [Intel-gfx] [PATCH] drm: HDMI pixel replication modes now hactive of 720 for pixel replication

2014-08-12 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http

Re: [Intel-gfx] [PATCH 2/4] drm/i915: cancel hotplug and dig_port work during suspend and unload

2014-08-12 Thread Ville Syrjälä
list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/4] drm/i915: don't try to retrain a DP link on an inactive CRTC

2014-08-12 Thread Ville Syrjälä
isn't enough since we don't clear that when we disable the crtcs for system suspend. Maybe we should do that instead? Anyway this check seems fine to me regardless of how we deal with connectors_active during system suspend, so: Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com

Re: [Intel-gfx] [PATCH 3/4] drm/i915: make sure VDD is turned off during system suspend

2014-08-12 Thread Ville Syrjälä
*); int crtc_mask; enum hpd_pin hpd_pin; }; -- 1.8.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC

Re: [Intel-gfx] [PATCH 2/4] drm/i915: cancel hotplug and dig_port work during suspend and unload

2014-08-12 Thread Ville Syrjälä
On Tue, Aug 12, 2014 at 03:36:01PM +0300, Imre Deak wrote: On Tue, 2014-08-12 at 15:13 +0300, Ville Syrjälä wrote: On Mon, Aug 11, 2014 at 09:54:15PM +0300, Imre Deak wrote: Make sure these work handlers don't run after we system suspend or unload the driver. Note that we don't cancel

Re: [Intel-gfx] [PATCH] drm/i915: Wait for vblank after enabling the primary plane on BDW

2014-08-12 Thread Ville Syrjälä
On Tue, Aug 12, 2014 at 11:24:11AM +0300, Ville Syrjälä wrote: On Mon, Aug 11, 2014 at 04:44:23PM -0300, Paulo Zanoni wrote: 2014-06-30 7:10 GMT-03:00 Jani Nikula jani.nik...@linux.intel.com: On Thu, 26 Jun 2014, Rodrigo Vivi rodrigo.v...@gmail.com wrote: I'm sure this might affect Wayne

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix HPD IRQ reenable work cancelation

2014-08-13 Thread Ville Syrjälä
The series seems fine to me. Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com for the rest as well. -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't warn if we restore pm interrupts during reset

2014-08-14 Thread Ville Syrjälä
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 6/6] drm/i915: New drm crtc property for varying the Crtc size

2014-08-14 Thread Ville Syrjälä
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 6/6] drm/i915: New drm crtc property for varying the Crtc size

2014-08-14 Thread Ville Syrjälä
On Thu, Aug 14, 2014 at 05:26:27PM +0200, Daniel Vetter wrote: On Thu, Aug 14, 2014 at 06:06:58PM +0300, Ville Syrjälä wrote: On Thu, Aug 14, 2014 at 04:42:01PM +0200, Daniel Vetter wrote: On Thu, Aug 14, 2014 at 02:54:27PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g

Re: [Intel-gfx] [PATCH 6/6] drm/i915: New drm crtc property for varying the Crtc size

2014-08-14 Thread Ville Syrjälä
On Thu, Aug 14, 2014 at 06:07:44PM +0200, Daniel Vetter wrote: On Thu, Aug 14, 2014 at 5:45 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: My quick grep audit tells me the viewport check and drm_primary_helper_update() are the only places in the core that care. The latter is rather

Re: [Intel-gfx] [PATCH 6/6] drm/i915: New drm crtc property for varying the Crtc size

2014-08-14 Thread Ville Syrjälä
On Thu, Aug 14, 2014 at 07:36:13PM +0200, Daniel Vetter wrote: On Thu, Aug 14, 2014 at 6:45 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Aug 14, 2014 at 06:07:44PM +0200, Daniel Vetter wrote: On Thu, Aug 14, 2014 at 5:45 PM, Ville Syrjälä ville.syrj...@linux.intel.com

Re: [Intel-gfx] [PATCH] drm/edid: Reduce horizontal timings for pixel replicated modes

2014-08-14 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 6/6] drm/i915: New drm crtc property for varying the Crtc size

2014-08-14 Thread Ville Syrjälä
On Thu, Aug 14, 2014 at 08:33:23PM +0200, Daniel Vetter wrote: On Thu, Aug 14, 2014 at 7:58 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: Sure but the user can supply any mode, doesn't have to be on any list. And the only sane rule for the frobbing would be that you can (slightly

Re: [Intel-gfx] [PATCH 00/16] drm/i915: 830M/ns201 fixes again

2014-08-15 Thread Ville Syrjälä
On Fri, Aug 15, 2014 at 01:21:52AM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Thomas asked me to repost my 830/ns2501 patches. So here they are. I added a few more patches (trickle feed and unused ring init) to fix some post-resume issues

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-15 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org

Re: [Intel-gfx] Usage of _PAGE_PCD et al in i915 driver

2014-08-15 Thread Ville Syrjälä
. -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-15 Thread Ville Syrjälä
On Fri, Aug 15, 2014 at 01:47:18PM -0300, Paulo Zanoni wrote: 2014-08-15 5:39 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Thu, Aug 14, 2014 at 12:06:02PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com If we're runtime suspended and try to use

Re: [Intel-gfx] S6010 - brightness adjustment not available

2014-08-16 Thread Ville Syrjälä
the problem or if bisecting is the only reasonable option. -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] Usage of _PAGE_PCD et al in i915 driver

2014-08-18 Thread Ville Syrjälä
On Mon, Aug 18, 2014 at 07:31:58AM +0200, Juergen Gross wrote: On 08/15/2014 12:21 PM, Ville Syrjälä wrote: On Thu, Aug 14, 2014 at 05:55:11AM +0200, Juergen Gross wrote: On 08/13/2014 05:07 PM, Jesse Barnes wrote: On Fri, 8 Aug 2014 15:14:15 +0200 Daniel Vetter daniel.vet...@ffwll.ch

Re: [Intel-gfx] [PATCH] drm/i915: fix plane/cursor handling when runtime suspended

2014-08-18 Thread Ville Syrjälä
-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_display.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3f8e037..15fe3eb 100644 --- a/drivers/gpu

Re: [Intel-gfx] [PATCH 07/14] drm/i915: Warn about want_panel_vdd in edp_panel_vdd_off_sync()

2014-08-19 Thread Ville Syrjälä
On Tue, Aug 19, 2014 at 10:36:52AM +0300, Jani Nikula wrote: On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com If we force vdd off warn if someone is still using it. With this change the delayed vdd off work needs to check

Re: [Intel-gfx] [PATCH 00/14] drm/i915: edp vdd locking and prep for power sequencer kick

2014-08-19 Thread Ville Syrjälä
On Tue, Aug 19, 2014 at 11:08:33AM +0300, Jani Nikula wrote: On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com While wrestling with the VLV/CHV panel power sequencer I noticed the locking in our edp vdd code was rather broken

Re: [Intel-gfx] [PATCH 08/14] drm/i915: Flatten intel_edp_panel_vdd_on()

2014-08-19 Thread Ville Syrjälä
On Tue, Aug 19, 2014 at 10:30:25AM +0300, Jani Nikula wrote: On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Less pointless indentation is always nice. There will be a bit more code in this function once the power sequencer

Re: [Intel-gfx] [PATCH 12/14] drm/i915: Turn on panel power before doing aux transfers

2014-08-19 Thread Ville Syrjälä
On Tue, Aug 19, 2014 at 10:33:15AM +0300, Jani Nikula wrote: On Mon, 18 Aug 2014, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com On VLV/CHV the panel power sequencer may need to be kicked a bit to lock onto the new port, and that needs to happen

Re: [Intel-gfx] [PATCH] drm/i915: Fix to Enable GT/PM Interrupts for cherryview.

2014-08-20 Thread Ville Syrjälä
]); GT_RENDER_USER_INTERRUPT GEN8_VECS_IRQ_SHIFT | GT_CONTEXT_SWITCH_INTERRUPT GEN8_VECS_IRQ_SHIFT }; -- 1.9.1 -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Intel-gfx] [PATCH] drm/i915/dp: Backlight PWM enable before BL Enable assert

2014-08-20 Thread Ville Syrjälä
last_backlight_off; struct notifier_block edp_notifier; -- 1.8.3.2 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC

Re: [Intel-gfx] [PATCH] drm/i915: Make wait-for-pending-flips more defensive

2014-08-20 Thread Ville Syrjälä
Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds using the golden render state

2014-08-20 Thread Ville Syrjälä
, it would be ideal to augment WA values from during the setup state as opposed to using a tool but that would be a follow up patch. I'd still prefer just emitting the LRIs from code rather tha mucking about with null batch. Less hoops to jump through when adding a new w/a. -- Ville Syrjälä Intel

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix to Enable GT/PM Interrupts for cherryview.

2014-08-21 Thread Ville Syrjälä
Widawsky benjamin.widaw...@intel.com Date: Sat Nov 2 21:07:09 2013 -0700 drm/i915/bdw: Implement interrupt changes v2: Kill the loop and init GT interrupts (Ville) Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add 180 degree primary plane rotation support

2014-08-21 Thread Ville Syrjälä
___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add 180 degree primary plane rotation support

2014-08-21 Thread Ville Syrjälä
On Thu, Aug 21, 2014 at 05:14:35PM +0530, Jindal, Sonika wrote: On 8/21/2014 2:03 PM, Ville Syrjälä wrote: On Thu, Aug 21, 2014 at 11:45:41AM +0530, sonika.jin...@intel.com wrote: From: Sonika Jindal sonika.jin...@intel.com Primary planes support 180 degree rotation. Expose

Re: [Intel-gfx] [PATCH 1/2] drm/i915: fix panel unlock register mask

2014-08-21 Thread Ville Syrjälä
On Thu, Aug 21, 2014 at 03:06:25PM +0300, Jani Nikula wrote: Use the correct mask for the unlock bits. In theory this could have lead to incorrect asserts but this is unlikely in practise. Signed-off-by: Jani Nikula jani.nik...@intel.com Reviewed-by: Ville Syrjälä ville.syrj

  1   2   3   4   5   6   7   8   9   10   >