[Intel-gfx] REBASED: [PATCH 1/3] drm: Add vblank prepare and unprepare hooks.

From: Rodrigo Vivi This will allow drivers to control specific power saving feature and power domains when dealing with vblanks. Vblanks code are protected by spin_locks where we can't have anything that can sleep. While power saving features and power domain code have

[Intel-gfx] [PATCH 0/3] CHV vblank failures when PSR is active

IGT vblank tests fail on CHV by timing out on VBIs if PSR is enabled. We do not get VBIs as the source timing generation is disabled when PSR is active. The first two patches written by Rodrigo add drm hooks. Patch 3 deactivates PSR when VBI are needed. [PATCH 1/3] drm: Add vblank prepare and

[Intel-gfx] [PATCH 2/3] drm/i915: Move drm_crtc_vblank_get out of disabled pre-emption area.

From: Rodrigo Vivi drm_crtc_vblank_get call the drm_vblank_prepare that will be used soon to control power saving states or anything else that needs a mutex before the vblank happens. local_irq_disable disables kernel preemption so we won't be able to use mutex inside

[Intel-gfx] [PATCH 3/3] drm/i915/psr: Do not activate PSR when vblank interrupts are enabled

using the vblank prepare hook that gets called before enabling vblank interrupts and keep it disabled until the interrupts are not needed. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH 1/3] drm: Add vblank prepare and unprepare hooks.

From: Rodrigo Vivi This will allow drivers to control specific power saving feature and power domains when dealing with vblanks. Vblanks code are protected by spin_locks where we can't have anything that can sleep. While power saving features and power domain code have

[Intel-gfx] [PATCH] drm/i915: Treat cursor plane as another sprite plane for BSW

From: Maarten Lankhorst Work around the CHV pipe C FIFO underruns that cause display failure by enabling sprite plane for cursor. This patch for BSW is based on Maarten Lankhorst's work that enables universal plane support. Signed-off-by: Maarten Lankhorst

[Intel-gfx] Prep. for DP audio MST support

in Patch 2 will make that easy. Dhinakaran Pandiyan(2) [PATCH 2/3] drm/i915: Move audio_connector to intel_encoder [PATCH 3/3] drm/i915: Fix enc_to_dig_port for MST encoders Libin Yang(1) [PATCH 1/3] drm/i915: start adding dp mst audio ___ Intel-gfx

[Intel-gfx] [PATCH 1/3] drm/i915: start adding dp mst audio

From: Libin Yang (This patch is developed by Dave Airlie originally) This patch adds support for DP MST audio in i915. Enable audio codec when DP MST is enabled if has_audio flag is set. Disable audio codec when DP MST is disabled if has_audio

[Intel-gfx] [PATCH 3/3] drm/i915: Fix enc_to_dig_port for MST encoders

When a MST encoder is passed to enc_to_dig_port(), the container_of() macro does not return the digital port. Handle this by returning the member "primary" in "struct intel_dp_mst_encoder" Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- driver

[Intel-gfx] [PATCH 2/3] drm/i915: Move audio_connector to intel_encoder

audio_connector from struct intel_digital_port to struct intel_encoder. This also simplifies access to the right audio_connector from codec functions in intel_audio.c that receive intel_encoder. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_audio.

[Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

max_bytes); struct i915_audio_component_audio_ops - void (*pin_eld_notify)(void *audio_ptr, int port); + void (*pin_eld_notify)(void *audio_ptr, int port, int dev_id); This patch makes dummy changes in the audio drivers for build to succeed. Signed-off-by: Dhinakaran Pandiyan

[Intel-gfx] DP audio API changes for identifying displays connected to a port

). This patch makes the API changes with dummy changes in the audio driver (Thanks Libin). Implementation to fully enable DP MST audio will follow later. Dhinakaran Pandiyan(1): drm/i915/dp: DP audio API changes for MST ___ Intel-gfx mailing list Intel-gfx

[Intel-gfx] [PATCH v2] drm/i915/dp: Switch to using the DRM function for reading DP link status

Since a DRM function that reads link DP link status is available, let's use that instead of the i915 clone. drm_dp_dpcd_read_link_status() returns a negative error code if the number of bytes read is not DP_LINK_STATUS_SIZE, drm_dp_dpcd_access() does the length check. Signed-off-by: Dhinakaran

[Intel-gfx] [PATCH v3] drm/i915/dp: DP audio API changes for MST

in get_saved_encoder(). (Takashi) Added comment for av_enc_map[] definition. (Takashi) v3: Fixed logic error introduced while renaming 'dev_id' as 'pipe' (Ville) Renamed get_saved_encoder() to get_saved_enc() to reduce line length Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.

[Intel-gfx] [PATCH 2/4] drm/i915/dp: Switch to using the DRM function for reading DP link status

Since a DRM function that reads link DP link status is available, let's use that instead of the i915 clone. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 15 +++ drivers/gpu/drm/i915/intel_dp_link_trai

[Intel-gfx] [PATCH 4/4] drm/i915/dp: Dump DP link status when link training stages fails

A full dump of link status can be handy in debugging link training failures. Let's add that to the debug messages when link training fails. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dp_link_training.c | 11 +++ drivers/gpu/dr

[Intel-gfx] [PATCH 3/4] drm/dp: Clarify clock recovery and channel equalization failures

that with these debug messages in drm. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c

[Intel-gfx] [PATCH 1/4] drm/i915/dp: Add debug messages to print DP link training pattern

Currently we do not print the training pattern used in any of the DP link training stages. Including this piece of information in debug messages will help debugging. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 13 +++--

[Intel-gfx] [PATCH 0/4] Improve logging for DP link training

We do not currently output enough information to help debugging DP link training issues. For e.g., training pattern and link status information. This series aims to correct that by adding debug messages that can help developers. Dhinakaran Pandiyan (4): drm/i915/dp: Add debug messages to print

[Intel-gfx] [PATCH 1/3] drm/i915: Clean up hsw_audio_codec_enable()

No functional change, code clean up and improved debug. Chris suggested this code snippet while reviewing, I just made this into a patch. Credits-to: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Dhinakaran Pandiyan <d

[Intel-gfx] [PATCH 3/3] drm/i915: Eliminate redundant local variable definition

No functional change, just clean up. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_audio.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_a

[Intel-gfx] [PATCH 2/3] drm/dp/i915: Clean up clock configuration for HDMI audio

No functional change, just clean up. Debug messages now print out clock units. Additionally, the configuration bits, which are 1:1 mapped to the clock frequency and don't convey much information are not printed out. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- d

[Intel-gfx] [PATCH v2 2/2] drm/i915/dp: Dump DP link status when link training stages fail

A full dump of link status can be handy in debugging link training failures. Let's add that to the debug messages when link training fails. v2: Removing unrelated clean up (Jani) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dp_link_trai

[Intel-gfx] [PATCH v2 1/2] drm/i915/dp: Add debug messages to print DP link training pattern

: Downgraded log level from error to debug (Chris) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] [PATCH v2 0/2] Improve logging for DP link training

and/or need more changes. Addressed review comments from Jani and Chris. Dhinakaran Pandiyan (2): drm/i915/dp: Add debug messages to print DP link training pattern drm/i915/dp: Dump DP link status when link training stages fail drivers/gpu/drm/i915/intel_dp.c | 13

[Intel-gfx] [PATCH] drm/i915: Minor clean up related to link training function declarations

No functional change. Organizing the declarations for functions implemented in intel_dp_link_training.c Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_drv.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH] drm/i915: Fix braces in conditonal branches

No functional change, just adding braces to all branches of conditional statement because one of them already had. --- drivers/gpu/drm/i915/intel_audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c

[Intel-gfx] [PATCH v2] drm/i915/dp: DP audio API changes for MST

in get_saved_encoder(). (Takashi) Added comment for av_enc_map[] definition. (Takashi) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h| 3 +- drivers/gpu/drm/i915/intel_audio.c | 92 ++ inclu

[Intel-gfx] [PATCH v2] drm/i915/dp: Switch to using the DRM function for reading DP link status

Since a DRM function that reads link DP link status is available, let's use that instead of the i915 clone. drm_dp_dpcd_read_link_status() returns a negative error code if the number of bytes read is not DP_LINK_STATUS_SIZE, drm_dp_dpcd_access() does the length check. Signed-off-by: Dhinakaran

[Intel-gfx] [PATCH] drm/docs: Fix documentation for drm_atomic_set_mode_for_crtc

drm_atomic_set_mode_for_crtc() modifies the .enable member of CRTC state but documentation claims otherwise, fix that. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_atomic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH v2 9/9] drm/dp: Track MST link bandwidth

helper callback ->atomic_release() when CRTCs are disabled. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 9 - drivers/gpu/drm/i915/intel_dp_mst.c | 13 - 2 files changed, 20 insertions(+), 2 deletions

[Intel-gfx] [PATCH v2 3/9] drm/dp: Split drm_dp_mst_allocate_vcpi

if there are enough vcpi slots before allocating them. This brings the check to one place. Additionally drivers that will use MST state tracking for atomic modesets can use the atomic version of find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi() Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pa

[Intel-gfx] [PATCH v2 5/9] drm/dp: Introduce MST topology state

needs to be done during the atomic_check phase to avoid failed modesets. Let's encsapsulate the available link bw information in a private state structure so that bw can be allocated and released atomically for each of the ports sharing the primary link. Signed-off-by: Dhinakaran Pandiyan

[Intel-gfx] [PATCH v2 8/9] drm/dp: Release DP MST shared link bandwidth

Implement the ->atomic_release() callback to release the shared link bandwidth that was originally acquired during compute_config() Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dp_mst.c | 28 1 file ch

[Intel-gfx] [PATCH v2 2/9] drm/dp: Kill unused MST vcpi slot availability tracking

descriptive. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 16 include/drm/drm_dp_mst_helper.h | 12 2 files changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topolog

[Intel-gfx] [PATCH v2 6/9] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

e port. drm_dp_atomic_release_vcpi_slots() should be called from ->atomic_check() to release a port's vcpi slot allocation from the state. Drivers that do not make use of this atomic helper are expected to call drm_dp_find_vcpi_slots() instead before calling drm_dp_mst_allocate_vcpi(). Signed-off-by: Dhinakaran

[Intel-gfx] [PATCH v2 4/9] drm: Add driver private objects to atomic state

types can be managed in the same state array. Suggested-by: Daniel Vetter <daniel.vet...@ffwll.ch> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_atomic.c| 55 + drivers/gpu/drm/drm_atomic_h

[Intel-gfx] [PATCH v2 1/9] drm/dp: Store drm_device in MST topology manager

struct drm_dp_mst_topology_mgr currently stores a pointer to struct dev. Changing this to instead hold a pointer to drm_device is more useful as it gives access to DRM structures. This also makes it consistent with other DRM structures like drm_crtc, drm_connector etc. Signed-off-by: Dhinakaran

[Intel-gfx] [PATCH v2 7/9] drm: Connector helper function to release atomic state

Having a ->atomic_release callback is useful to release shared resources that get allocated in compute_config(). Suggested-by: Daniel Vetter <daniel.vet...@ffwll.ch> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- include/drm/drm_modeset_helper

[Intel-gfx] [PATCH v2 0/9] Adding private objects to atomic state

types can be managed in the same state array. This series also includes some necessary cleanups. Dhinakaran Pandiyan (9): drm/dp: Store drm_device in MST topology manager drm/dp: Kill unused MST vcpi slot availability tracking drm/dp: Split drm_dp_mst_allocate_vcpi drm: Add driver private

[Intel-gfx] [PATCH v3 3/8] drm/dp: Split drm_dp_mst_allocate_vcpi

if there are enough vcpi slots before allocating them. This brings the check to one place. Additionally drivers that will use MST state tracking for atomic modesets can use the atomic version of find_vcpi_slots() and reuse drm_dp_mst_allocate_vcpi() Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pa

[Intel-gfx] [PATCH v3 8/8] drm/dp: Track MST link bandwidth

helper callback ->atomic_release() when CRTCs are disabled. v2: Squashed atomic_release() implementation and caller (Daniel) Fixed logic for connector-crtc switching case (Daniel) Fixed logic for suspend-resume case. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> ---

[Intel-gfx] [PATCH v3 0/8] Adding driver-private objects to atomic state

accounting logic for suspend-resume and connector switching Dhinakaran Pandiyan (8): drm/dp: Kill total_pbn and total_slots in struct drm_dp_mst_topology_mgr drm/dp: Kill unused MST vcpi slot availability tracking drm/dp: Split drm_dp_mst_allocate_vcpi drm: Add driver-private

[Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

ter <daniel.vet...@ffwll.ch> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_atomic_helper.c | 19 +++ include/drm/drm_modeset_helper_vtables.h | 13 + 2 files changed, 32 insertions(+) diff --git a/

[Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

types can be managed in the same state array. v2: Added docs and new iterator to filter private objects (Daniel) Suggested-by: Daniel Vetter <daniel.vet...@ffwll.ch> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_atomic.c

[Intel-gfx] [PATCH v3 5/8] drm/dp: Introduce MST topology state to track available link bandwidth

initialization and switched to kmemdup() for allocation (Daniel) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 71 +++ include/drm/drm_dp_mst_helper.h | 20 ++ 2 files changed, 91 inse

[Intel-gfx] [PATCH v3 2/8] drm/dp: Kill unused MST vcpi slot availability tracking

The avail_slots member in the MST topology manager is never updated to reflect the available vcpi slots. The check is effectively against total slots, 63. So, let's make that check obvious and remove avail_slots. While at it, make debug messages more descriptive. Signed-off-by: Dhinakaran

[Intel-gfx] [PATCH v3 1/8] drm/dp: Kill total_pbn and total_slots in struct drm_dp_mst_topology_mgr

. So, fix this by removing the total_pbn member itself. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 5 ++--- include/drm/drm_dp_mst_helper.h | 9 + 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/d

[Intel-gfx] [PATCH v3 6/8] drm/dp: Add DP MST helpers to atomically find and release vcpi slots

verifying the port reference is valid Moved get_mst_topology_state() into the helpers (Daniel) Changed find_vcpi_slots() to not depend on current allocation Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_dp_mst_

[Intel-gfx] [PATCH v2 3/3] drm/i915: start adding dp mst audio

From: Libin Yang (This patch is developed by Dave Airlie originally) This patch adds support for DP MST audio in i915. Enable audio codec when DP MST is enabled if has_audio flag is set. Disable audio codec when DP MST is disabled if has_audio

[Intel-gfx] [PATCH v2 0/3] Prep. for DP audio MST support

, Lyude) (b) and (c) -no changes since Lyude reviewed them. Reordered the patches (Lyude) Dhinakaran Pandiyan (2): (a) drm/i915: Add function to return port from an encoder (b) drm/i915: Move audio_connector to intel_encoder Libin Yang (1): (c) drm/i915: start adding dp mst audio drivers/gpu

[Intel-gfx] [PATCH v2 1/3] drm/i915: Add function to return port from an encoder

is delegated to the DDI specific function. The idea to have a generic implementation that returned the 'enum port' from 'struct intel_encoder' came from Ville. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c

[Intel-gfx] [PATCH v2 2/3] drm/i915: Move audio_connector to intel_encoder

audio_connector from struct intel_digital_port to struct intel_encoder. This also simplifies access to the right audio_connector from codec functions in intel_audio.c that receive intel_encoder. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@r

[Intel-gfx] [RFC][PATCH] drm: Add DRM_DEBUG_DISPLAY macro for display configuration debug messages

with DRM_DEBUG_KMS. DRM_DEBUG_DISPLAY will specifically address such cases where the developer wants communicate why a display related configuration choice was made. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> --- include/dr

[Intel-gfx] [PATCH v5 4/4] drm/i915: start adding dp mst audio

if has_audio flag is set. Another separated patches to support DP MST audio will be implemented in audio driver. v2: Rebased becaus of atomic changes. Signed-off-by: Libin Yang <libin.y...@linux.intel.com> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> -

[Intel-gfx] [PATCH v5 2/4] drm/i915: Switch to using port stored in intel_encoder

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_audio.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c index 6c70a5b..8

[Intel-gfx] [PATCH v5 1/4] drm/i915: Store port enum in intel_encoder

(thanks danvet). v2: Renamed the port enum member from 'attached_port' to 'port' (danvet) Fixed missing initialization of port in intel_sdvo.c (danvet) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Ville Syrjälä

[Intel-gfx] [PATCH v5 3/4] drm/i915: Move audio_connector to intel_encoder

-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com> --- drivers/gpu/drm/i915/intel_audio.c | 12 drivers/gpu/drm/i915/intel_drv.h | 4 ++-- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v5 0/4] Prep. for DP audio MST support

ember from 'attached_port' to 'port' Fixed commit message typos. v5: Really renamed the port enum member from 'attached_port' to 'port' Rebased on atomic changes. Dhinakaran Pandiyan (3): drm/i915: Store port enum in intel_encoder drm/i915: Switch to using port stored in intel_encoder drm/

[Intel-gfx] [PATCH v5] drm/i915/dp: DP audio API changes for MST

ues in get_saved_enc() (Ville) Switched to for_each_pipe() in get_saved_enc() (Ville) Renamed 'pipe' to 'dev_id' in audio side code (Takashi) v5: Included a comment for the dev_id arg. (Libin) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Takashi Iwai <t

[Intel-gfx] [PATCH v4] drm/i915/dp: DP audio API changes for MST

ues in get_saved_enc() (Ville) Switched to for_each_pipe() in get_saved_enc() (Ville) Renamed 'pipe' to 'dev_id' in audio side code (Takashi) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Takashi Iwai <ti...@suse.de> --- drivers/gpu/drm/i915/i915_drv.h| 3

[Intel-gfx] [PATCH v4 3/4] drm/i915: Move audio_connector to intel_encoder

audio_connector from struct intel_digital_port to struct intel_encoder. This also simplifies access to the right audio_connector from codec functions in intel_audio.c that receive intel_encoder. v2: Removed locals that are not needed anymore. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.

[Intel-gfx] [PATCH v2] drm/i915: Standardize port type for DVO encoders

to valid values for all DVO devices at definition. v2: Changed return type, for real (Jani) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dvo.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH v6 2/5] drm/i915: Store port enum in intel_encoder

(thanks danvet). v2: Renamed the port enum member from 'attached_port' to 'port' (danvet) Fixed missing initialization of port in intel_sdvo.c (danvet) v3: Fixed missing initialization of port in intel_crt.c (Ville) v4: Storing port for DVO encoders too. Signed-off-by: Dhinakaran Pandiyan

[Intel-gfx] [PATCH v6 0/5] Prep. for DP audio MST support

ort' Fixed commit message typos. v5: Really renamed the port enum member from 'attached_port' to 'port' Rebased on atomic changes. v6: Modified the return type for a helper that returns port in intel_dvo.c Dhinakaran Pandiyan (4): drm/i915: Standardize port type for DVO encoders drm/i915: Store

[Intel-gfx] [PATCH v6 3/5] drm/i915: Switch to using port stored in intel_encoder

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com> --- drivers/gpu/drm/i915/intel_audio.c | 32 ++-- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_audio.c b/dri

[Intel-gfx] [PATCH v6 1/5] drm/i915: Standardize port type for DVO encoders

to valid values for all DVO devices at definition. v2: Changed return type, for real (Jani) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dvo.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH v6 5/5] drm/i915: start adding dp mst audio

if has_audio flag is set. Another separated patches to support DP MST audio will be implemented in audio driver. v2: Rebased. Signed-off-by: Libin Yang <libin.y...@linux.intel.com> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com

[Intel-gfx] [PATCH v6 4/5] drm/i915: Move audio_connector to intel_encoder

-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com> --- drivers/gpu/drm/i915/intel_audio.c | 12 drivers/gpu/drm/i915/intel_drv.h | 4 ++-- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH] drm/i915: Standardize port type for DVO encoders

to valid values for all DVO devices at definition. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dvo.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/dr

[Intel-gfx] [PATCH v6 1/4] drm/i915: Store port enum in intel_encoder

(thanks danvet). v2: Renamed the port enum member from 'attached_port' to 'port' (danvet) Fixed missing initialization of port in intel_sdvo.c (danvet) v3: Fixed missing initialization of port in intel_crt.c (Ville) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Daniel

[Intel-gfx] [PATCH] drm/dp/i915: Enable audio codec after the HDA audio driver is initialized

This fixes the underruns that are seen in DP MST multi-monitor setups when audio is enabled with commit 3708d5e082c3 ("drm/i915: start adding dp mst audio"). The underruns triggered continuous cycles of display on/off cycles. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@

[Intel-gfx] [CI-1 v5] drm/i915/dp: DP audio API changes for MST

duce line length v4: Rebased. Parameter check for pipe < -1 values in get_saved_enc() (Ville) Switched to for_each_pipe() in get_saved_enc() (Ville) Renamed 'pipe' to 'dev_id' in audio side code (Takashi) v5: Included a comment for the dev_id arg. (Libin) Signed-off-by: Dhinakaran Pandiya

[Intel-gfx] [PATCH v5] drm/i915/dp: DP audio API changes for MST

duce line length v4: Rebased. Parameter check for pipe < -1 values in get_saved_enc() (Ville) Switched to for_each_pipe() in get_saved_enc() (Ville) Renamed 'pipe' to 'dev_id' in audio side code (Takashi) v5: Included a comment for the dev_id arg. (Libin) Signed-off-by: Dhinakaran Pandiya

[Intel-gfx] [PATCH] drm: Fix typo in encoder docs

Corrected typo in bridge and encoder comparison. Also, added a one-line encoder description from the previous documentation. Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Archit Taneja <arch...@codeaurora.org> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com>

[Intel-gfx] [PATCH v7 0/5] Prep. for DP audio MST support

This series lays the groundwork for more DP MST audio work that will follow. v7: Added R-B tags and rebased. v6: Modified the return type for a helper that returns port in intel_dvo.c v5: Really renamed the port enum member from 'attached_port' to 'port' Rebased on atomic changes. v4: Fixed

[Intel-gfx] [PATCH v7 3/5] drm/i915: Switch to using port stored in intel_encoder

mation. v2: Fix incorrect 'enum port' member names - s/attached_port/port Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com> --- drivers/gpu/drm/i915/intel_audio.c | 32 ++-- 1 file changed, 14 insertio

[Intel-gfx] [PATCH v7 4/5] drm/i915: Move audio_connector to intel_encoder

ded anymore. v3: No code change except for minor change in context. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com> --- drivers/gpu/drm/i915/intel_audio.c | 12 drivers/gpu/drm/i915/intel_drv.h | 4 ++-- 2 files

[Intel-gfx] [PATCH v7 5/5] drm/i915: start adding dp mst audio

if has_audio flag is set. Another separated patches to support DP MST audio will be implemented in audio driver. v2: Rebased. Signed-off-by: Libin Yang <libin.y...@linux.intel.com> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com

[Intel-gfx] [PATCH v7 2/5] drm/i915: Store port enum in intel_encoder

v4: Storing port for DVO encoders too. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Lyude <

[Intel-gfx] [PATCH v7 1/5] drm/i915: Standardize port type for DVO encoders

emoving the last conditional that handles invalid port because dvo_reg is intialized to valid values for all DVO devices at definition. v2: Changed return type, for real (Jani) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Lyude <cp...@redhat.com> --- driv

[Intel-gfx] [PATCH v3 4/4] drm/i915: start adding dp mst audio

From: Libin Yang (This patch is developed by Dave Airlie originally) This patch adds support for DP MST audio in i915. Enable audio codec when DP MST is enabled if has_audio flag is set. Disable audio codec when DP MST is disabled if has_audio

[Intel-gfx] [PATCH v3 0/4] Prep. for DP audio MST support

(danvet). Removed locals that are not needed any more. Minor variable renaming clean up. Rebased on dinq. Retained r-b for "start adding dp mst audio" as it does not change. Dhinakaran Pandiyan (3): drm/i915: Store port enum in intel_encoder drm/i915: Switch to using p

[Intel-gfx] [PATCH v3 2/4] drm/i915: Switch to using port stored in intel_encoder

Now that we have the port enum stored in intel_encoder use that instead of dereferencing intel_dig_port. Saves us a few locals. struct intel_encoder variables have been renamed to be consistent and convey type information. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.

[Intel-gfx] [PATCH v3 3/4] drm/i915: Move audio_connector to intel_encoder

audio_connector from struct intel_digital_port to struct intel_encoder. This also simplifies access to the right audio_connector from codec functions in intel_audio.c that receive intel_encoder. v2: Removed local that are needed anymore. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.

[Intel-gfx] [PATCH v4 0/4] Prep. for DP audio MST support

ort' Fixed commit message typos. Dhinakaran Pandiyan (3): drm/i915: Store port enum in intel_encoder drm/i915: Switch to using port stored in intel_encoder drm/i915: Move audio_connector to intel_encoder Libin Yang (1): drm/i915: start adding dp mst audio drivers/gpu/drm/i915/i915_debu

[Intel-gfx] [PATCH v4 1/4] drm/i915: Store port enum in intel_encoder

(thanks danvet). v2: Renamed the port enum member from 'attached_port' to 'port' (danvet) Fixed missing initialization of port in intel_sdvo.c (danvet) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Ville Syrjälä

[Intel-gfx] [PATCH v4 4/4] drm/i915: start adding dp mst audio

From: Libin Yang (This patch is developed by Dave Airlie originally) This patch adds support for DP MST audio in i915. Enable audio codec when DP MST is enabled if has_audio flag is set. Disable audio codec when DP MST is disabled if has_audio

[Intel-gfx] [PATCH v4 2/4] drm/i915: Switch to using port stored in intel_encoder

Now that we have the port enum stored in intel_encoder, use that instead of dereferencing intel_dig_port. Saves us a few locals. struct intel_encoder variables have been renamed to be consistent and convey type information. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.

[Intel-gfx] [PATCH v4 3/4] drm/i915: Move audio_connector to intel_encoder

audio_connector from struct intel_digital_port to struct intel_encoder. This also simplifies access to the right audio_connector from codec functions in intel_audio.c that receive intel_encoder. v2: Removed locals that are not needed anymore. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.

[Intel-gfx] [PATCH] Revert "drm/i915: start adding dp mst audio"

This reverts 'commit 3708d5e082c3 ("drm/i915: start adding dp mst audio")' because it breaks MST multi-monitor setups on some platforms. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=97907 Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reported-by:

[Intel-gfx] [PATCH] drm: Add frame CRC debugfs files only for drivers that have CRTC

vgem does not do modeset, looping through non-existent CRTC's while registering drm_minor in 'commit 48c787899882 ("drm: Add API for capturing frame CRCs")' caused kernel oops. So, let's add CRC debugfs files only for those drivers that do modeset. Signed-off-by: Dhinakara

[Intel-gfx] [PATCH v4 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

ded TODO comment Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/i915_reg.h| 5 + drivers/gpu/drm/i915/intel_audio.c | 30 +- 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i91

[Intel-gfx] [PATCH v2] drm/i915/dp: Debug log MST active links explicitly

From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> No functional change. Just printing the number of active links without stating what the number means is not very useful. So, add relevant text. v2: Included connector info (Chris) Signed-off-by: Dhinakaran Pandiyan &

[Intel-gfx] [PATCH v3 2/2] drm/i915/dp: BDW cdclk fix for DP audio

and 4 lanes by default. v3: Combine BDW pixel rate adjustments into a function (Jani) v2: Restrict fix to BDW Retain the set cdclk across modesets (Ville) Cc: sta...@vger.kernel.org Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Reviewed-by: Ville Syrjälä <v

[Intel-gfx] [PATCH v3 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

ded TODO comment Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/i915_reg.h| 5 +++ drivers/gpu/drm/i915/intel_audio.c | 62 +++--- 2 files changed, 62 insertions(+), 5 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH v2] drm/dp: Make space for null terminator in the DP device ID char array

(Jani) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/drm_dp_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 3e6fe82..2d42760 100644 --- a/drivers/g

[Intel-gfx] [PATCH] drm/dp: Make space for null terminator in the DP device ID char array

The DP device identification string read from the DPCD registers is 6 characters long at max. and we store it in a char array of the same length without space for the NULL terminator. Fix this by increasing the array size to 7 and initialize it to an empty string. Signed-off-by: Dhinakaran

[Intel-gfx] [PATCH 2/2] drm/i915/dp: Validate mode against max. link data rate for DP MST

of a configuration. Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- drivers/gpu/drm/i915/intel_dp_mst.c | 12 +++- drivers/gpu/drm/i915/intel_drv.h| 2 ++ 3 files changed, 15 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH 1/2] drm/dp/i915: Fix DP link rate math

54 kHz * 4 lanes * (8/10) = 1728000 kBps Similarly, while computing the required link bandwidth for a mode, there is a mysterious 1/10 term. This should simply be pixel_clock kHz * bpp * 1/8 to give the final result in kBps Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.

  1   2   3   4   5   6   7   8   9   >