Re: [RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

2024-08-28 Thread Alex Deucher
djust the MST resume flow") promised > > a follow-up, but that seems to have never materialized. Really should > > materialize though. Patch lgtm > > > > Reviewed-by: Daniel Vetter > > Thanks! > > Cc: AMD folks, ack for merging the series via drm-misc-next?

Re: [PATCH v2 78/86] drm/radeon: Run DRM default client setup

2024-08-22 Thread Alex Deucher
ory, with a default of 32. Adapt this for > the new client interface. > > v2: > - style changes > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: "Christian König" > Cc: Xinhui Pan Acked-by: Alex Deucher > --- > drivers/gpu

Re: [PATCH v2 65/86] drm/amdgpu: Run DRM default client setup

2024-08-22 Thread Alex Deucher
a preferred color mode depending on > the available video memory, with a default of 32. Adapt this for > the new client interface. > > v2: > - style changes > > Signed-off-by: Thomas Zimmermann > Cc: Alex Deucher > Cc: "Christian König" > Cc: Xinhui Pan

[PATCH V3] video/aperture: optionally match the device in sysfb_disable()

2024-08-21 Thread Alex Deucher
iel Vetter Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/firmware/sysfb.c | 19 +-- drivers/of/platform.c| 2 +- drivers/video/aperture.c | 11 +++ include/linux/sysfb.h| 4 ++-- 4 files changed, 19 insertions(+), 17 deletions(-) diff --git

Re: [PATCH V2] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Alex Deucher
I forgot to update the patch title but it should probably be something like: video/aperture: optionally match the device in sysfb_disable() Alex On Mon, Aug 19, 2024 at 1:00 PM Alex Deucher wrote: > > In aperture_remove_conflicting_pci_devices(), we currently only > call sysfb_disable

[PATCH V2] video/aperture: match the pci device when calling sysfb_disable()

2024-08-19 Thread Alex Deucher
emove sysfb on the default vga pci device") Cc: Javier Martinez Canillas Cc: Thomas Zimmermann Cc: Helge Deller Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/firmware/sysfb.c | 11 +-- drivers/of/platform.c| 2 +- dri

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-16 Thread Alex Deucher
ree_information] > > > > url: > > https://github.com/intel-lab-lkp/linux/commits/Alex-Deucher/video-aperture-match-the-pci-device-when-calling-sysfb_disable/20240810-021357 > > base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next > > patch link: &g

Re: [PATCH v6 0/4] drm: Use full allocated minor range for DRM

2024-08-14 Thread Alex Deucher
On Tue, Aug 13, 2024 at 8:19 PM Michał Winiarski wrote: > > On Mon, Aug 12, 2024 at 01:38:38PM GMT, Alex Deucher wrote: > > Are there any objections to this series? We have been running into > > this limit as a problem for a while now on big servers. > > I don't th

Re: [PATCH v6 0/4] drm: Use full allocated minor range for DRM

2024-08-12 Thread Alex Deucher
Are there any objections to this series? We have been running into this limit as a problem for a while now on big servers. Alex On Mon, Jul 24, 2023 at 5:15 PM Michał Winiarski wrote: > > 64 DRM device nodes is not enough for everyone. > Upgrade it to ~512K (which definitely is more than enough

[PATCH] video/aperture: match the pci device when calling sysfb_disable()

2024-08-09 Thread Alex Deucher
nillas Cc: Thomas Zimmermann Cc: Helge Deller Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org --- drivers/video/aperture.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c index 56

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-08 Thread Alex Deucher
On Thu, Aug 8, 2024 at 1:19 AM Thomas Zimmermann wrote: > > Hi > > Am 07.08.24 um 21:47 schrieb Alex Deucher: > > On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann > > wrote: > >> Hi > >> > >> Am 05.08.24 um 21:00 schrieb Deucher, Alexander

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-07 Thread Alex Deucher
immermann ; Deucher, Alexander > >> ; Koenig, Christian > >> ; Pan, Xinhui > >> Subject: [PATCH 1/9] drm/amdgpu: Use backlight power constants > >> > >> Replace FB_BLANK_ constants with their counterparts from the backlight > >> subsystem. The

Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-05-21 Thread Alex Deucher
Applied and pushed out: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8a0a7b98d4b6eeeab337ec25daa4bc0a5e710a15 Alex On Tue, May 21, 2024 at 12:12 PM Alex Deucher wrote: > > I've got it teed up. Is drm-misc-fixes the right branch since we are > in the merge window? >

Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

2024-05-21 Thread Alex Deucher
I've got it teed up. Is drm-misc-fixes the right branch since we are in the merge window? Alex On Tue, May 21, 2024 at 7:20 AM Linux regression tracking (Thorsten Leemhuis) wrote: > > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting > for once, to make this easily accessibl

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-13 Thread Alex Deucher
On Mon, May 13, 2024 at 8:20 AM Jani Nikula wrote: > > On Fri, 10 May 2024, Alex Deucher wrote: > > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: > >> > >> I've sent this some moths ago, let's try again... > >> > >> BR, > >&

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-10 Thread Alex Deucher
d has_audio from display info > drm/radeon: remove radeon_connector_edid() and stop using > edid_blob_ptr > drm/amdgpu: remove amdgpu_connector_edid() and stop using > edid_blob_ptr > drm/edid: add a helper for EDID sysfs property show > drm/connector: update

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Wed, May 8, 2024 at 4:12 PM Easwar Hariharan wrote: > > On 5/8/2024 7:53 AM, Alex Deucher wrote: > > On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan > > wrote: > >> > >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > >>> I2C v7, SMBus

Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-05-08 Thread Alex Deucher
On Tue, May 7, 2024 at 2:32 PM Easwar Hariharan wrote: > > On 5/3/2024 11:13 AM, Easwar Hariharan wrote: > > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > > with more appropriate terms. Inspired by and following on to Wolfram's > > series to fix drivers/i2c/[1], fi

Re: [PATCH 2/5] drm/amdgpu: Use drm_crtc_vblank_crtc()

2024-05-08 Thread Alex Deucher
On Mon, Apr 8, 2024 at 3:06 PM Ville Syrjala wrote: > > From: Ville Syrjälä > > Replace the open coded drm_crtc_vblank_crtc() with the real > thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "Pan, Xinhui" > Cc: amd-...@lists.freedes

Re: [PATCH v2 13/16] drm/ttm: make ttm_pool.h self-contained

2024-03-08 Thread Alex Deucher
re.kernel.org/oe-kbuild-all/202403072259.eec2vf1x-...@intel.com/ > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > include/drm/ttm/ttm_pool.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/drm/ttm/ttm_pool.h b/include/drm/ttm/ttm_poo

Re: [PATCH v2 10/16] drm/ttm: make ttm_caching.h self-contained

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote: > > Include for pgprot_t. > > Cc: Christian Koenig > Cc: Huang Rui > Acked-by: Thomas Zimmermann > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > include/drm/ttm/ttm_caching.h | 2 ++ >

Re: [PATCH v2 02/16] drm: add missing header guards to drm_crtc_helper_internal.h

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote: > > Including the file twice can lead to errors. > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_crtc_helper_internal.h | 5 + > 1 file changed, 5 insertions(+) > > d

Re: [PATCH v2 03/16] drm/encoder: improve drm_encoder_slave.h kernel-doc

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:08 AM Jani Nikula wrote: > > Document structs drm_encoder_slave_funcs, drm_encoder_slave, and > drm_i2c_encoder_driver. > > v2: Actually document the structs instead of just silencing kernel-doc > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deuch

Re: [PATCH v2 01/16] drm: add missing header guards to drm_crtc_internal.h

2024-03-08 Thread Alex Deucher
On Fri, Mar 8, 2024 at 7:03 AM Jani Nikula wrote: > > Including the file twice can lead to errors. > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/drm_crtc_internal.h | 5 + > 1 file changed, 5 insertions(+) > > d

Re: [PATCH 04/22] drm/amdgpu: make amd_asic_type.h self-contained

2024-03-07 Thread Alex Deucher
On Wed, Mar 6, 2024 at 1:43 PM Jani Nikula wrote: > > Include for u8. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher Do you want me to pick this up? Otherwise, feel free to take it via whatever tree makes sense. Alex > --- > include/drm/amd_asic_type.h | 3 +++ &g

Re: [PATCH 0/6 V4] fdinfo shared stats

2024-02-15 Thread Alex Deucher
On Thu, Feb 15, 2024 at 9:18 AM Christian König wrote: > > Am 12.02.24 um 22:04 schrieb Alex Deucher: > > We had a request to add shared buffer stats to fdinfo for amdgpu and > > while implementing that, Christian mentioned that just looking at > > the GEM handle count d

[PATCH 4/6] drm/amdgpu: add shared fdinfo stats

2024-02-12 Thread Alex Deucher
Add shared stats. Useful for seeing shared memory. v2: take dma-buf into account as well v3: use the new gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher Cc: Rob Clark --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c

[PATCH 6/6] drm/xe: Update shared stats to use the new gem helper

2024-02-12 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/xe/xe_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 5/6] drm/i915: Update shared stats to use the new gem helper

2024-02-12 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Tvrtko Ursulin Signed-off-by: Alex Deucher --- drivers/gpu/drm/i915/i915_drm_client.c | 2 +- 1 file changed, 1

[PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

2024-02-12 Thread Alex Deucher
: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Tvrtko Ursulin (v1) Signed-off-by: Alex Deucher --- include/drm/drm_gem.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h index 369505447acd

[PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs

2024-02-12 Thread Alex Deucher
: Alex Deucher Cc: Rob Clark --- drivers/gpu/drm/drm_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index 8c87287c3e16..638ffaf5 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -913,7

[PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-*

2024-02-12 Thread Alex Deucher
Clarify the documentation in preparation for updated helpers which check the handle count as well as whether a dma-buf has been attached. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Tvrtko Ursulin Signed-off-by: Alex Deucher

[PATCH 0/6 V4] fdinfo shared stats

2024-02-12 Thread Alex Deucher
t really matter from a GPU top perspective, but it's more correct if you actually want to see shared buffers. After further discussions, add a helper and update all fdinfo implementations to use that helper for consistency. v4: switch drm_gem_object_is_shared_for_memory_stats() to an inline fu

[PATCH 5/6] drm/i915: Update shared stats to use the new gem helper

2024-01-30 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/i915/i915_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 6/6] drm/xe: Update shared stats to use the new gem helper

2024-01-30 Thread Alex Deucher
Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/xe/xe_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

2024-01-30 Thread Alex Deucher
/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/drm_gem.c | 16 include/drm/drm_gem.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 44a948b80ee1..71b5f628d828

[PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-*

2024-01-30 Thread Alex Deucher
Clarify the documentaiton in preparation for updated helpers which check the handle count as well as whether a dma-buf has been attached. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- Documentation/gpu/drm-usage-stats.rst

[PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs

2024-01-30 Thread Alex Deucher
Show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other subsystem). v2: switch to gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Rob Clark (v1) Signed-off-by: Alex Deucher Cc: Rob Clark

[PATCH 4/6] drm/amdgpu: add shared fdinfo stats

2024-01-30 Thread Alex Deucher
Add shared stats. Useful for seeing shared memory. v2: take dma-buf into account as well v3: use the new gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher Cc: Rob Clark --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c

[PATCH 0/6 V3] fdinfo shared stats

2024-01-30 Thread Alex Deucher
t really matter from a GPU top perspective, but it's more correct if you actually want to see shared buffers. After further discussions, add a helper and update all fdinfo implementations to use that helper for consistency. Alex Deucher (6): Documentation/gpu: Update documentation on drm

Re: [PATCH 3/6] drm/amdgpu: prefer snprintf over sprintf

2024-01-12 Thread Alex Deucher
On Wed, Jan 10, 2024 at 12:39 PM Jani Nikula wrote: > > This will trade the W=1 warning -Wformat-overflow to > -Wformat-truncation. This lets us enable -Wformat-overflow subsystem > wide. > > Cc: Alex Deucher > Cc: Christian König > Cc: Pan, Xinhui > Cc: amd-...@lis

Re: [PATCH 3/3] ASoC: hdmi-codec: drop drm/drm_edid.h include

2024-01-05 Thread Alex Deucher
Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: linux-so...@vger.kernel.org > Acked-by: Maxime Ripard > Signed-off-by: Jani Nikula Series is: Acked-by: Alex Deucher > --- > drivers/gpu/drm/bridge/lontium-lt9611.c| 1 + &g

Re: [Intel-gfx] [PATCH 00/20] remove I2C_CLASS_DDC support

2023-11-16 Thread Alex Deucher
On Mon, Nov 13, 2023 at 3:55 PM Wolfram Sang wrote: > > > > We're not in a hurry. It's just my experience with patch series' affecting > > multiple subsystems that typically the decision was to apply the full > > series via one tree. Also to avoid inquires from maintainers like: > > Shall I take i

Re: [Intel-gfx] [PATCH 0/9] drm: Annotate structs with __counted_by

2023-10-02 Thread Alex Deucher
On Mon, Oct 2, 2023 at 5:20 AM Christian König wrote: > > Am 29.09.23 um 21:33 schrieb Kees Cook: > > On Fri, 22 Sep 2023 10:32:05 -0700, Kees Cook wrote: > >> This is a batch of patches touching drm for preparing for the coming > >> implementation by GCC and Clang of the __counted_by attribute. F

Re: [Intel-gfx] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-25 Thread Alex Deucher
On Mon, Sep 25, 2023 at 1:52 PM Kees Cook wrote: > > On Mon, Sep 25, 2023 at 08:30:30AM +0200, Christian König wrote: > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > > > > Prepare for the coming imple

Re: [Intel-gfx] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-25 Thread Alex Deucher
On Mon, Sep 25, 2023 at 10:07 AM Alex Deucher wrote: > > On Mon, Sep 25, 2023 at 2:30 AM Christian König > wrote: > > > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > > >> Prepare for the com

Re: [Intel-gfx] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-25 Thread Alex Deucher
On Mon, Sep 25, 2023 at 2:30 AM Christian König wrote: > > Am 22.09.23 um 19:41 schrieb Alex Deucher: > > On Fri, Sep 22, 2023 at 1:32 PM Kees Cook wrote: > >> Prepare for the coming implementation by GCC and Clang of the __counted_by > >> attribute. Flexibl

Re: [Intel-gfx] [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by

2023-09-22 Thread Alex Deucher
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ip_hw_instance. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Alex Deuch

Re: [Intel-gfx] [PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-22 Thread Alex Deucher
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct > smu10_voltage_dependency_table. > > [1] > https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci &

Re: [Intel-gfx] [RFC, drm-misc-next v4 3/9] drm/radeon: Implement .be_primary() callback

2023-09-06 Thread Alex Deucher
On Tue, Sep 5, 2023 at 1:25 PM suijingfeng wrote: > > Hi, > > > On 2023/9/5 13:50, Christian König wrote: > > Am 04.09.23 um 21:57 schrieb Sui Jingfeng: > >> From: Sui Jingfeng > >> > >> On a machine with multiple GPUs, a Linux user has no control over > >> which one > >> is primary at boot time.

Re: [Intel-gfx] [PATCH 1/6] drm/edid: add drm_edid_is_digital()

2023-09-01 Thread Alex Deucher
On Thu, Aug 24, 2023 at 9:46 AM Jani Nikula wrote: > > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula Reviewed-by: Alex Deucher Seems to be a few ad

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-09-01 Thread Alex Deucher
On Thu, Aug 31, 2023 at 6:01 PM Alex Hung wrote: > > > > On 2023-08-30 01:29, Jani Nikula wrote: > > On Tue, 29 Aug 2023, Alex Hung wrote: > >> On 2023-08-29 11:03, Jani Nikula wrote: > >>> On Tue, 29 Aug 2023, Jani Nikula wrote: > >>>> On

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-08-29 Thread Alex Deucher
On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote: > > On Wed, 23 Aug 2023, Jani Nikula wrote: > > On Tue, 22 Aug 2023, Alex Hung wrote: > >> On 2023-08-22 06:01, Jani Nikula wrote: > >>> Over the past years I've been trying to unify the override and firmware > >>> EDID handling as well as EDID

Re: [Intel-gfx] [drm-rerere] nightly.conf: drop sound tree from drm-tip altogether

2023-07-06 Thread Alex Deucher
about the sound tree, as nobody has really missed it > since v5.13, and focus on the drm branches. > > Signed-off-by: Jani Nikula Acked-by: Alex Deucher > --- > nightly.conf | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/nightly.conf b/nightly.conf >

Re: [Intel-gfx] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-16 Thread Alex Deucher
On Fri, Jun 16, 2023 at 10:22 AM Sui Jingfeng wrote: > > > On 2023/6/16 21:41, Alex Deucher wrote: > > On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng > > wrote: > >> Hi, > >> > >> On 2023/6/16 05:11, Alex Deucher wrote: > >>> On Wed, J

Re: [Intel-gfx] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-16 Thread Alex Deucher
On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/16 05:11, Alex Deucher wrote: > > On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng > > wrote: > >> Hi, > >> > >> On 2023/6/13 11:01, Sui Jingfeng wrote: > >>> Fro

Re: [Intel-gfx] [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

2023-06-15 Thread Alex Deucher
On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote: > > Hi, > > On 2023/6/13 11:01, Sui Jingfeng wrote: > > From: Sui Jingfeng > > > > Deal only with the VGA devcie(pdev->class == 0x0300), so replace the > > pci_get_subsys() function with pci_get_class(). Filter the non-PCI display > > device(pde

Re: [Intel-gfx] [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-05-16 Thread Alex Deucher
On Tue, May 16, 2023 at 4:05 AM Jani Nikula wrote: > > On Thu, 09 Mar 2023, Jani Nikula wrote: > > On Thu, 09 Mar 2023, Christian König wrote: > >> Am 09.03.23 um 13:37 schrieb Jani Nikula: > >>> Make the struct ttm_device_funcs pointers const so the data can be placed > >>> in rodata. > >>> >

Re: [Intel-gfx] [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Alex Deucher
On Mon, Feb 27, 2023 at 8:04 AM Christian König wrote: > > Am 27.02.23 um 10:00 schrieb Thomas Hellström: > > Hi, Maarten, > > > > On 2/27/23 09:55, Maarten Lankhorst wrote: > >> Hey, > >> > >> I can push this to drm-misc-next, I don't think a drm maintainer ack > >> is needed, as long as we have

Re: [Intel-gfx] [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-23 Thread Alex Deucher
On Thu, Feb 23, 2023 at 10:03 AM Thomas Hellström wrote: > > Hi, Daniel, > > On 2/16/23 21:18, Daniel Vetter wrote: > > On Thu, Feb 16, 2023 at 05:27:28PM +0100, Thomas Hellström wrote: > >> A slightly unusual cover letter for a single patch. > >> > >> The page table walker is currently used by th

Re: [Intel-gfx] [PATCH v3 0/3] drm/{amdgpu, i915, nouveau, radeon}: Fix fbdev and vga-switcheroo

2023-01-16 Thread Alex Deucher
of drm_lastclose() and drivers do not > need their own lastclose helpers any longer. > > I kept the r-bs from v1, but patch 1 is entirely new and patch 3 has > significantly grown in size. Series is: Reviewed-by: Alex Deucher > > v3: > * include drm_fb_helper.h in

Re: [Intel-gfx] [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-09 Thread Alex Deucher
mark scores. > > > > Signed-off-by: Arunpravin Paneer Selvam > > Acked-by: Christian König , but somebody with more > insight of the drm buddy allocator should take a closer look at this. I'm not a drm_buddy expert either, but this patch fixes a lot of issues on both dGPUs

Re: [Intel-gfx] [PATCH 1/9] drm/amdgpu: generally allow over-commit during BO allocation

2022-11-25 Thread Alex Deucher
own to a sane allocation behavior again. > > Signed-off-by: Christian König This looks like a good bug fix and unrelated to the rest of this series. Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 16 +++- > drivers/gpu/drm/amd/amdgpu/a

Re: [Intel-gfx] [PATCH 03/15] drm/amd/display: stop using connector->override_edid

2022-10-11 Thread Alex Deucher
On Tue, Oct 11, 2022 at 10:12 AM Jani Nikula wrote: > > On Tue, 11 Oct 2022, Harry Wentland wrote: > > On 2022-10-11 09:49, Jani Nikula wrote: > >> The connector->override_edid flag is strictly for EDID override debugfs > >> management, and drivers have no busi

Re: [Intel-gfx] [PATCH 0/6] Remove unused declarations for gpu/drm

2022-09-13 Thread Alex Deucher
Pushed patches 1-5 to drm-misc-next. Alex On Tue, Sep 13, 2022 at 2:14 AM Christian König wrote: > > Nice cleanup. Acked-by: Christian König for > the whole series. > > Thanks, > Christian. > > Am 13.09.22 um 04:48 schrieb Gaosheng Cui: > > This series contains a few cleanup patches, to remove

Re: [Intel-gfx] [PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c

2022-08-10 Thread Alex Deucher
Acked-by: Alex Deucher On Mon, Aug 1, 2022 at 10:08 AM Simon Ser wrote: > > Acked-by: Simon Ser > > CC amd-gfx > > On Monday, August 1st, 2022 at 15:52, Imre Deak wrote: > > > The API change introduced in > > > > commit 30c637151cfa ("drm/plane-hel

Re: [Intel-gfx] [PATCH v2 14/29] drm/radeon: Register ACPI video backlight when skipping radeon backlight registration

2022-07-20 Thread Alex Deucher
klight device should be used, it will be available > before the radeon drm_device gets registered with userspace. > > Signed-off-by: Hans de Goede Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_encoders.c | 11 ++- > 1 file changed, 10 insertions(+), 1 delet

Re: [Intel-gfx] [PATCH v2 13/29] drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration

2022-07-20 Thread Alex Deucher
ster_acpi_backlight: > + /* Try registering an ACPI video backlight device instead. */ > + acpi_video_register_backlight(); > + return; Can drop the return here. Either way, Acked-by: Alex Deucher > } > > void > diff --git a/drivers/gpu/drm/amd/display/amd

Re: [Intel-gfx] [PATCH v2 09/29] ACPI: video: Make backlight class device registration a separate step

2022-07-20 Thread Alex Deucher
On Tue, Jul 12, 2022 at 3:40 PM Hans de Goede wrote: > > On x86/ACPI boards the acpi_video driver will usually initializing before initializing -> initialize > the kms driver (except i915). This causes /sys/class/backlight/acpi_video0 > to show up and then the kms driver registers its own native

Re: [Intel-gfx] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
On Wed, Jul 20, 2022 at 12:44 PM Alex Deucher wrote: > > On Tue, Jul 12, 2022 at 3:39 PM Hans de Goede wrote: > > > > Before this commit when we want userspace to use the acpi_video backlight > > device we register both the GPU's native backlight device and acpi_vi

Re: [Intel-gfx] [PATCH v2 04/29] drm/radeon: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
> - To avoid linker errors when radeon is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-of

Re: [Intel-gfx] [PATCH v2 03/29] drm/amdgpu: Don't register backlight when another backlight should be used

2022-07-20 Thread Alex Deucher
> - To avoid linker errors when amdgpu is builtin and video_detect.c is in > a module, select ACPI_VIDEO and its deps if ACPI && X86 are enabled. > When these are not set, ACPI_VIDEO is disabled, ensuring the stubs > from acpi/video.h will be used. > > Signed-of

Re: [Intel-gfx] [PATCH] dma-buf: revert "return only unsignaled fences in dma_fence_unwrap_for_each v3"

2022-07-12 Thread Alex Deucher
in where it makes sense. > >> > >> Signed-off-by: Christian König > > > > After applying the patch, fence merging works and all sw_sync subtests > > are passing. Thanks for taking care of this. > > > > Tested-by: Karolina Drobnik > > can an

Re: [Intel-gfx] linux-next: Tree for Jun 15 (drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c)

2022-06-15 Thread Alex Deucher
Pushed to drm-misc-next. Alex On Wed, Jun 15, 2022 at 7:26 PM Stephen Rothwell wrote: > > Hi all, > > On Wed, 15 Jun 2022 13:52:34 -0700 Nathan Chancellor > wrote: > > > > On Wed, Jun 15, 2022 at 04:45:16PM -0400, Alex Deucher wrote: > > > On Wed, Jun 1

Re: [Intel-gfx] Per file OOM badness

2022-05-31 Thread Alex Deucher
+ dri-devel On Tue, May 31, 2022 at 6:00 AM Christian König wrote: > > Hello everyone, > > To summarize the issue I'm trying to address here: Processes can allocate > resources through a file descriptor without being held responsible for it. > > Especially for the DRM graphics driver subsystem th

Re: [Intel-gfx] [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-16 Thread Alex Deucher
On Mon, May 16, 2022 at 8:40 AM Mike Lothian wrote: > > Hi > > The merge window for 5.19 will probably be opening next week, has > there been any progress with this bug? It took a while to find a combination of GPUs that would repro the issue, but now that we can, it is still being investigated.

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: > > Hi Alex, > > On Wed, 23 Mar 2022 at 14:42, Alex Deucher wrote: > > On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > > On Wed, 23 Mar 2022 at 08:19, Christian König > > > wrote: > > >

Re: [Intel-gfx] Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Alex Deucher
On Wed, Mar 23, 2022 at 10:00 AM Daniel Stone wrote: > > On Wed, 23 Mar 2022 at 08:19, Christian König > wrote: > > Am 23.03.22 um 09:10 schrieb Paul Menzel: > > > Sorry, I disagree. The motivation needs to be part of the commit > > > message. For example see recent discussion on the LWN article

Re: [Intel-gfx] [PATCH 00/22] drm: Review of mode copies

2022-03-15 Thread Alex Deucher
On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä wrote: > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > drm: Add drm_mode_init() > > drm/bridge: Use drm_mode_copy() > > drm/imx: Use drm_mode_duplicate() > > drm/panel: Use drm_mode_duplicate() > > drm/vc4: Use drm_mode

Re: [Intel-gfx] [PATCH 04/22] drm/amdgpu: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
, S) > > + drm_mode_copy(mode, E) > > ) > > > > @depends on !is_mode_copy@ > > struct drm_display_mode mode; > > expression E; > > @@ > > ( > > - mode = E > > + drm_mode_copy(&mode, &E) > > | > > - memcpy(&mode

Re: [Intel-gfx] [PATCH 05/22] drm/radeon: Use drm_mode_copy()

2022-03-15 Thread Alex Deucher
+ drm_mode_copy(mode, &E) > | > - memcpy(mode, E, S) > + drm_mode_copy(mode, E) > ) > > @depends on !is_mode_copy@ > struct drm_display_mode mode; > expression E; > @@ > ( > - mode = E > + drm_mode_copy(&mode, &E) > | > - memcpy(&mode, E, S)

Re: [Intel-gfx] [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies

2022-03-15 Thread Alex Deucher
. > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: amd-...@lists.freedesktop.org > > Cc: Nikola Cornij > > Cc: Aurabindo Pillai > > Signed-off-by: Ville Syrjälä > > Reviewed

Re: [Intel-gfx] [RFC v2 1/2] drm/doc/rfc: VM_BIND feature design document

2022-03-09 Thread Alex Deucher
On Mon, Mar 7, 2022 at 3:30 PM Niranjana Vishwanathapura wrote: > > VM_BIND design document with description of intended use cases. > > Signed-off-by: Niranjana Vishwanathapura > --- > Documentation/gpu/rfc/i915_vm_bind.rst | 210 + > Documentation/gpu/rfc/index.rst

Re: [Intel-gfx] [PATCH v12 1/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-03-02 Thread Alex Deucher
On Wed, Mar 2, 2022 at 10:55 AM Michael Cheng wrote: > > Thanks for the feedback Robin! > > Sorry my choices of word weren't that great, but what I meant is to > understand how ARM flushes a range of dcache for device drivers, and not > an equal to x86 clflush. > > I believe the concern is if the

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Alex Deucher
On Fri, Feb 18, 2022 at 7:13 AM Simon Ser wrote: > > On Friday, February 18th, 2022 at 12:54, Hans de Goede > wrote: > > > On 2/18/22 12:39, Simon Ser wrote: > > > On Friday, February 18th, 2022 at 11:38, Hans de Goede > > > wrote: > > > > > >> What I'm reading in the above is that it is being

Re: [Intel-gfx] [PATCH 6/6] drm/amdgpu: use dma_fence_chain_contained

2022-02-04 Thread Alex Deucher
On Fri, Feb 4, 2022 at 5:04 AM Christian König wrote: > > Instead of manually extracting the fence. > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletion

Re: [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core

2022-02-02 Thread Alex Deucher
Acked-by: Alex Deucher On Wed, Feb 2, 2022 at 6:31 AM Maxime Ripard wrote: > > On Mon, Jan 31, 2022 at 10:05:32PM +0100, Daniel Vetter wrote: > > Ever since Tomi extracted the core code in 2014 it's been defacto me > > maintaining this, with help from others from

Re: [Intel-gfx] [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate

2021-11-02 Thread Alex Deucher
display/intel_hdmi.c | 2 +- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_encoders.c | 2 +- For radeon: Acked-by: Alex Deucher Note that there are several instances of this in amdgpu as well: drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c:

Re: [Intel-gfx] [PATCH 3/4] drm/amd/display: Add DP 2.0 MST DC Support

2021-10-20 Thread Alex Deucher
On Wed, Oct 20, 2021 at 3:50 PM Bhawanpreet Lakha wrote: > > From: Fangzhi Zuo Please include a patch description. Alex > > Signed-off-by: Fangzhi Zuo > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 14 + > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 280 ++ > ..

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-09-22 Thread Alex Deucher
+ Harry, Leo Can you guys get someone to clean this up? Alex On Wed, Sep 22, 2021 at 7:10 AM Jani Nikula wrote: > > On Tue, 21 Sep 2021, Nathan Chancellor wrote: > > On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > >> DP 2.0 brings some new DPCD addresses for PHY repeaters. > >>

Re: [Intel-gfx] [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: > > Replace drm_mm with drm buddy manager for > VRAM memory management Would be good to document why we are doing this and what advantages it brings over the old drm_mm code. Alex > > Signed-off-by: Arunpravin > --- > .../gpu/drm/amd/amdgpu/a

Re: [Intel-gfx] [PATCH 1/2] Enable buddy memory manager support

2021-09-20 Thread Alex Deucher
On Mon, Sep 20, 2021 at 3:21 PM Arunpravin wrote: Please prefix the patch subject with drm. E.g., drm: Enable buddy memory manager support Same for the second patch, but make it drm/amdgpu instead. Alex > > Port Intel buddy system manager to drm root folder > Add CPU mappable/non-mappable reg

Re: [Intel-gfx] [PATCH 00/14] drm/hdcp: Pull HDCP auth/exchange/check into

2021-09-13 Thread Alex Deucher
On Mon, Sep 13, 2021 at 1:57 PM Sean Paul wrote: > > From: Sean Paul > > Hello, > This patchset pulls the HDCP protocol auth/exchange/check logic out from > i915 into a HDCP helper library which drivers can use to implement the > proper protocol and UAPI interactions for achieving HDCP. > > Origi

Re: [Intel-gfx] [PATCH 2/2] drm/amdgpu: Disable PCIE_DPM on Intel RKL Platform

2021-08-25 Thread Alex Deucher
On Wed, Aug 25, 2021 at 10:22 AM Lazar, Lijo wrote: > > > > On 8/25/2021 4:46 PM, Koba Ko wrote: > > On Wed, Aug 25, 2021 at 6:24 PM Jani Nikula > > wrote: > >> > >> On Wed, 25 Aug 2021, Koba Ko wrote: > >>> On Wed, Aug 25, 2021 at 5:22 PM Jani Nikula > >>> wrote: > > On Wed, 25 Aug

Re: [Intel-gfx] [PATCH] drm/amdgpu: switch from 'pci_' to 'dma_' API

2021-08-23 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Aug 23, 2021 at 2:16 AM Christian König wrote: > > Am 22.08.21 um 23:21 schrieb Christophe JAILLET: > > The wrappers in include/linux/pci-dma-compat.h should go away. > > > > The patch has been generated with the coccinelle script below. > > > > It has been compile

Re: [Intel-gfx] [PATCH v2] fbdev/efifb: Release PCI device's runtime PM ref during FB destroy

2021-08-10 Thread Alex Deucher
On Tue, Aug 10, 2021 at 4:36 AM Imre Deak wrote: > > Hi Kai-Heng, Alex, > > could you add your ack if the fix looks ok and you're ok if I push it to > the i915 tree? > Acked-by: Alex Deucher > Thanks, > Imre > > On Mon, Aug 09, 2021 at 04:31:46PM +0300,

Re: [Intel-gfx] [RFC 8/8] drm/amdgpu: Convert to common fdinfo format

2021-07-23 Thread Alex Deucher
+ David, Roy On Thu, Jul 15, 2021 at 5:18 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Convert fdinfo format to one documented in drm-usage-stats.rst. > > Opens: > * Does it work for AMD? > * What are the semantics of AMD engine utilisation reported in percents? >Can it align with

Re: [Intel-gfx] [RFC 0/8] Per client GPU stats

2021-07-23 Thread Alex Deucher
On Fri, Jul 23, 2021 at 9:51 AM Tvrtko Ursulin wrote: > > > On 23/07/2021 12:23, Christian König wrote: > > Am 23.07.21 um 13:21 schrieb Tvrtko Ursulin: > >> > >> On 15/07/2021 10:18, Tvrtko Ursulin wrote: > >>> From: Tvrtko Ursulin > >>> > >>> Same old work but now rebased and series ending with

Re: [Intel-gfx] [PATCH 02/15] dma-buf: Switch to inline kerneldoc

2021-06-22 Thread Alex Deucher
On Tue, Jun 22, 2021 at 12:55 PM Daniel Vetter wrote: > > Also review & update everything while we're at it. > > This is prep work to smash a ton of stuff into the kerneldoc for > @resv. > > Signed-off-by: Daniel Vetter > Cc: Sumit Semwal > Cc: "C

Re: [Intel-gfx] [PATCH 01/15] dma-resv: Fix kerneldoc

2021-06-22 Thread Alex Deucher
by: Daniel Vetter > Cc: Sumit Semwal > Cc: "Christian König" > Cc: linux-me...@vger.kernel.org > Cc: linaro-mm-...@lists.linaro.org Reviewed-by: Alex Deucher > --- > include/linux/dma-resv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

  1   2   3   4   >