Re: [Intel-gfx] [PATCH 6/6] treewide: remove check of list iterator against head past the loop body

11 +++-- This 9p change looks good to me. Reviewed-by: Dominique Martinet # 9p -- Dominique

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

Ville Syrjälä wrote on Thu, Jul 12, 2018: > On Thu, Jul 12, 2018 at 03:55:26PM +0200, Dominique Martinet wrote: > > This could either be 'this commit' as a whole or if you look only at the > > commit message 'this strncpy fix' from the title (which is arguably the >

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

Ville Syrjälä wrote on Thu, Jul 12, 2018: > On Wed, Jul 11, 2018 at 09:46:15AM +0200, Dominique Martinet wrote: > > This is effectively no-op as the next line writes a nul at the final > > What is "This". Please write self contained commit messages. This could either be

[Intel-gfx] [PATCH v2] i915/intel_tv_get_modes: fix strncpy truncation warning

Change it to use strlcpy instead Signed-off-by: Dominique Martinet --- drivers/gpu/drm/i915/intel_tv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c index b55b5c157e38..25fee7dba7e2 100644 --- a/drivers

[Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

This is effectively no-op as the next line writes a nul at the final byte of the buffer, so copying one letter less does not change the behaviour. Signed-off-by: Dominique Martinet --- gcc 8 gives the following warning, which I am not sure why is treated as error for this file, thus making me