Re: [Intel-gfx] [RFC-v4 05/21] drm/i915/pxp: Func to send hardware session termination

2021-01-19 Thread Huang, Sean Z
nal Message- From: Chris Wilson Sent: Thursday, December 10, 2020 1:19 AM To: Huang, Sean Z ; Intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [RFC-v4 05/21] drm/i915/pxp: Func to send hardware session termination Quoting Huang, Sean Z (2020-12-10 07:24:19) > Implement the fun

[Intel-gfx] [RFC-v23 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-01-18 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. rev21: - Fix "Fi.CI.CHECKPATCH" warnings Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew

[Intel-gfx] [RFC-v23 10/13] mei: pxp: export pavp client to me client bus

2021-01-18 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v23 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2021-01-18 Thread Huang, Sean Z
t;recv" Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 6 ++ drivers/gpu/drm/i915/pxp/intel_pxp.c | 5 + drivers/gpu/drm/i915/pxp/i

[Intel-gfx] [RFC-v23 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2021-01-18 Thread Huang, Sean Z
the PXP irq - Remove the unnecessary comment for GEN11_CRYPTO_RSVD_INTR_MASK Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 14 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 99

[Intel-gfx] [RFC-v23 04/13] drm/i915/pxp: Create the arbitrary session after boot

2021-01-18 Thread Huang, Sean Z
pxp_protection_modes from single session patch series. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_arb.c | 122 +++ drivers/gpu/drm/i915/pxp

[Intel-gfx] [RFC-v23 08/13] drm/i915/pxp: Enable PXP power management

2021-01-18 Thread Huang, Sean Z
the power cycle. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++ drivers/gpu/drm/i915/i915_drv.c| 4 ++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c| 65 ++ drivers/gpu/drm/i915

[Intel-gfx] [RFC-v23 05/13] drm/i915/pxp: Func to send hardware session termination

2021-01-18 Thread Huang, Sean Z
() before unpin map - Using "goto label" instead of bool such as is_engine_pm_get - We should always return the error if any, instead of skip with i915_request_set_error_once() Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gp

[Intel-gfx] [RFC-v23 07/13] drm/i915/pxp: Destroy arb session upon teardown

2021-01-18 Thread Huang, Sean Z
, we need to set the PXP_GLOBAL_TERMINATE 0x320f8 register after arb session termination - Remove enum pxp_session_types and enum pxp_protection_modes from single session patch series. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 3 + drivers/gpu/drm

[Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-18 Thread Huang, Sean Z
user_flags instead gem_object_metadata. [Krishna] v3: - intel_pxp_gem_object_status() API changes. Cc: Bommu Krishnaiah Cc: Huang Sean Z Cc: Gaurav Kumar Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [RFC-v23 00/13] Introduce Intel PXP component - Mesa single session

2021-01-18 Thread Huang, Sean Z
- Add Cc of reviewers in commit message. Anshuman Gupta (1): drm/i915/pxp: Add plane decryption support Bommu Krishnaiah (2): drm/i915/uapi: introduce drm_i915_gem_create_ext drm/i915/pxp: User interface for Protected buffer Huang, Sean Z (9): drm/i915/pxp: Introduce Intel PXP

[Intel-gfx] [RFC-v23 02/13] drm/i915/pxp: set KCR reg init during the boot time

2021-01-18 Thread Huang, Sean Z
T reg inly for gen12 during boot, not required for gen13+ Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c index 9bc3c7e30654..4e9cee7df

[Intel-gfx] [RFC-v23 09/13] drm/i915/pxp: Expose session state for display protection flip

2021-01-18 Thread Huang, Sean Z
. rev23: - Require user space to explicitly set recoverable flag to false for protected context creation. Signed-off-by: Huang, Sean Z --- .../gpu/drm/i915/gem/i915_gem_context_types.h | 2 ++ drivers/gpu/drm/i915/pxp/intel_pxp.c | 34 +++ drivers/gpu/drm/i915/pxp

[Intel-gfx] [RFC-v23 01/13] drm/i915/pxp: Introduce Intel PXP component

2021-01-18 Thread Huang, Sean Z
t; from DRM_I915_PXP in Kconfig Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Kconfig | 21 ++ drivers/gpu/drm/i915/Makefile| 5 drivers/gpu/drm/i915/gt/intel_gt.c | 5 drivers/gpu/drm/i915/gt/intel_gt_types.h

[Intel-gfx] [RFC-v23 12/13] drm/i915/pxp: User interface for Protected buffer

2021-01-18 Thread Huang, Sean Z
(i915_gem_context_setparam_ioctl) rev23: - Require user space to explicitly set recoverable flag to false for protected context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 13

Re: [Intel-gfx] [RFC-v21 00/13] Introduce Intel PXP component - Mesa single session

2021-01-18 Thread Huang, Sean Z
Hi Lionel, I'm glad to hear the good news, thank you! Best regards, Sean -Original Message- From: Lionel Landwerlin Sent: Monday, January 18, 2021 5:17 AM To: Huang, Sean Z ; Intel-gfx@lists.freedesktop.org Cc: Gaurav, Kumar Subject: Re: [Intel-gfx] [RFC-v21 00/13] Introduce Intel

Re: [Intel-gfx] [RFC-v19 12/13] drm/i915/pxp: User interface for Protected buffer

2021-01-18 Thread Huang, Sean Z
ange first accordingly, to prevent breaking the integration test. Best regards, Sean -Original Message- From: Vivi, Rodrigo Sent: Thursday, January 7, 2021 7:58 AM To: Huang, Sean Z ; Intel-gfx@lists.freedesktop.org Cc: Kondapally, Kalyan ; Bommu, Krishnaiah Subject: Re: [Intel-gfx] [RFC

Re: [Intel-gfx] [RFC-v19 09/13] drm/i915/pxp: Expose session state for display protection flip

2021-01-18 Thread Huang, Sean Z
- From: Vivi, Rodrigo Sent: Thursday, January 7, 2021 7:55 AM To: Huang, Sean Z ; Intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [RFC-v19 09/13] drm/i915/pxp: Expose session state for display protection flip On Wed, 2021-01-06 at 15:12 -0800, Huang, Sean Z wrote: &

[Intel-gfx] [RFC-v21 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2021-01-17 Thread Huang, Sean Z
the PXP irq - Remove the unnecessary comment for GEN11_CRYPTO_RSVD_INTR_MASK Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 14 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 99 drivers

[Intel-gfx] [RFC-v21 12/13] drm/i915/pxp: User interface for Protected buffer

2021-01-17 Thread Huang, Sean Z
(i915_gem_context_setparam_ioctl) Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 +-- drivers/gpu/drm/i915/gem/i915_gem_context.h | 5 drivers/gpu/drm/i915/gem/i915_gem_create.c

[Intel-gfx] [RFC-v21 08/13] drm/i915/pxp: Enable PXP power management

2021-01-17 Thread Huang, Sean Z
the power cycle. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++ drivers/gpu/drm/i915/i915_drv.c| 4 ++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c| 65 ++ drivers/gpu/drm/i915

[Intel-gfx] [RFC-v21 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-01-17 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. rev21: - Fix "Fi.CI.CHECKPATCH" warnings Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew

[Intel-gfx] [RFC-v21 07/13] drm/i915/pxp: Destroy arb session upon teardown

2021-01-17 Thread Huang, Sean Z
, we need to set the PXP_GLOBAL_TERMINATE 0x320f8 register after arb session termination - Remove enum pxp_session_types and enum pxp_protection_modes from single session patch series. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 3 + drivers/gpu/drm

[Intel-gfx] [RFC-v21 09/13] drm/i915/pxp: Expose session state for display protection flip

2021-01-17 Thread Huang, Sean Z
. Signed-off-by: Huang, Sean Z --- .../gpu/drm/i915/gem/i915_gem_context_types.h | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 26 +++ drivers/gpu/drm/i915/pxp/intel_pxp.h | 18 + include/uapi/drm/i915_drm.h | 9 +++ 4 files changed

[Intel-gfx] [RFC-v21 13/13] drm/i915/pxp: Add plane decryption support

2021-01-17 Thread Huang, Sean Z
user_flags instead gem_object_metadata. [Krishna] Cc: Bommu Krishnaiah Cc: Huang, Sean Z Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 19 insertions(+), 3 deletions

[Intel-gfx] [RFC-v21 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2021-01-17 Thread Huang, Sean Z
t;recv" Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 6 ++ drivers/gpu/drm/i915/pxp/intel_pxp.c | 5 + drivers/gpu/drm/i915/pxp/i

[Intel-gfx] [RFC-v21 05/13] drm/i915/pxp: Func to send hardware session termination

2021-01-17 Thread Huang, Sean Z
() before unpin map - Using "goto label" instead of bool such as is_engine_pm_get - We should always return the error if any, instead of skip with i915_request_set_error_once() Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gp

[Intel-gfx] [RFC-v21 04/13] drm/i915/pxp: Create the arbitrary session after boot

2021-01-17 Thread Huang, Sean Z
pxp_protection_modes from single session patch series. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_arb.c | 122 +++ drivers/gpu/drm/i915/pxp

[Intel-gfx] [RFC-v21 10/13] mei: pxp: export pavp client to me client bus

2021-01-17 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v21 02/13] drm/i915/pxp: set KCR reg init during the boot time

2021-01-17 Thread Huang, Sean Z
T reg inly for gen12 during boot, not required for gen13+ Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c index 9bc3c7e30654..4e9cee7df

[Intel-gfx] [RFC-v21 01/13] drm/i915/pxp: Introduce Intel PXP component

2021-01-17 Thread Huang, Sean Z
t; from DRM_I915_PXP in Kconfig Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Kconfig | 21 ++ drivers/gpu/drm/i915/Makefile| 5 drivers/gpu/drm/i915/gt/intel_gt.c | 5 drivers/gpu/drm/i915/gt/intel_gt_types.h

[Intel-gfx] [RFC-v21 00/13] Introduce Intel PXP component - Mesa single session

2021-01-17 Thread Huang, Sean Z
text creation (i915_gem_context_create_ioctl), but not allow during context set param (i915_gem_context_setparam_ioctl) Anshuman Gupta (1): drm/i915/pxp: Add plane decryption support Bommu Krishnaiah (2): drm/i915/uapi: introduce drm_i915_gem_create_ext drm/i915/pxp:

[Intel-gfx] [RFC-v21 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2021-01-16 Thread Huang, Sean Z
the PXP irq - Remove the unnecessary comment for GEN11_CRYPTO_RSVD_INTR_MASK Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 14 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 99 drivers

[Intel-gfx] [RFC-v21 05/13] drm/i915/pxp: Func to send hardware session termination

2021-01-16 Thread Huang, Sean Z
() before unpin map - Using "goto label" instead of bool such as is_engine_pm_get - We should always return the error if any, instead of skip with i915_request_set_error_once() Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gp

[Intel-gfx] [RFC-v21 04/13] drm/i915/pxp: Create the arbitrary session after boot

2021-01-16 Thread Huang, Sean Z
pxp_protection_modes from single session patch series. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp_arb.c | 122 +++ drivers/gpu/drm/i915/pxp

[Intel-gfx] [RFC-v21 09/13] drm/i915/pxp: Expose session state for display protection flip

2021-01-16 Thread Huang, Sean Z
. Signed-off-by: Huang, Sean Z --- .../gpu/drm/i915/gem/i915_gem_context_types.h | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 26 +++ drivers/gpu/drm/i915/pxp/intel_pxp.h | 18 + include/uapi/drm/i915_drm.h | 9 +++ 4 files changed

[Intel-gfx] [RFC-v21 08/13] drm/i915/pxp: Enable PXP power management

2021-01-16 Thread Huang, Sean Z
the power cycle. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++ drivers/gpu/drm/i915/i915_drv.c| 4 ++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c| 65 ++ drivers/gpu/drm/i915

[Intel-gfx] [RFC-v21 10/13] mei: pxp: export pavp client to me client bus

2021-01-16 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v21 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-01-16 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. rev21: - Fix "Fi.CI.CHECKPATCH" warnings Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew

[Intel-gfx] [RFC-v21 12/13] drm/i915/pxp: User interface for Protected buffer

2021-01-16 Thread Huang, Sean Z
(i915_gem_context_setparam_ioctl) Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 +-- drivers/gpu/drm/i915/gem/i915_gem_context.h | 5 drivers/gpu/drm/i915/gem/i915_gem_create.c

[Intel-gfx] [RFC-v21 13/13] drm/i915/pxp: Add plane decryption support

2021-01-16 Thread Huang, Sean Z
user_flags instead gem_object_metadata. [Krishna] Cc: Bommu Krishnaiah Cc: Huang, Sean Z Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 19 insertions(+), 3 deletions

[Intel-gfx] [RFC-v21 07/13] drm/i915/pxp: Destroy arb session upon teardown

2021-01-16 Thread Huang, Sean Z
, we need to set the PXP_GLOBAL_TERMINATE 0x320f8 register after arb session termination - Remove enum pxp_session_types and enum pxp_protection_modes from single session patch series. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 3 + drivers/gpu/drm

[Intel-gfx] [RFC-v21 02/13] drm/i915/pxp: set KCR reg init during the boot time

2021-01-16 Thread Huang, Sean Z
T reg inly for gen12 during boot, not required for gen13+ Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c index 9bc3c7e30654..4e9cee7df

[Intel-gfx] [RFC-v21 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2021-01-16 Thread Huang, Sean Z
t;recv" Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 6 ++ drivers/gpu/drm/i915/pxp/intel_pxp.c | 5 + drivers/gpu/drm/i915/pxp/i

[Intel-gfx] [RFC-v21 01/13] drm/i915/pxp: Introduce Intel PXP component

2021-01-16 Thread Huang, Sean Z
t; from DRM_I915_PXP in Kconfig Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Kconfig | 21 ++ drivers/gpu/drm/i915/Makefile| 5 drivers/gpu/drm/i915/gt/intel_gt.c | 5 drivers/gpu/drm/i915/gt/intel_gt_types.h

[Intel-gfx] [RFC-v21 00/13] Introduce Intel PXP component - Mesa single session

2021-01-16 Thread Huang, Sean Z
ontext_create_ioctl), but not allow during context set param (i915_gem_context_setparam_ioctl) Anshuman Gupta (1): drm/i915/pxp: Add plane decryption support Bommu Krishnaiah (2): drm/i915/uapi: introduce drm_i915_gem_create_ext drm/i915/pxp: User interface for Protected buffer Huang, Se

Re: [Intel-gfx] [RFC-v19 08/13] drm/i915/pxp: Enable PXP power management

2021-01-12 Thread Huang, Sean Z
that display is stilling rendering/playing-back the protected buffer, and protected surfaces turn corruption garbage if we terminate the session during the suspend(). Best regards, Sean -Original Message- From: Vivi, Rodrigo Sent: Thursday, January 7, 2021 9:53 AM To: Huang, Sean Z

Re: [Intel-gfx] [RFC-v19 05/13] drm/i915/pxp: Func to send hardware session termination

2021-01-12 Thread Huang, Sean Z
Hi Rodrigo, I made the modification as below according to Chris and your suggestion, will reflect at rev20. All my comments (// sean: ...) the won't be checked in. This change can address part of the comment Chris provided. But please let me go through the remaining comments at rev19 first.

Re: [Intel-gfx] [RFC-v19 04/13] drm/i915/pxp: Create the arbitrary session after boot

2021-01-11 Thread Huang, Sean Z
So I think the define GEN12_KCR_SIP should stay in intel_pxp_arb.c since it's no shared users. But anyway please let me know if you insist to move it to i915_reg.h Best regards, Sean -Original Message- From: Vivi, Rodrigo Sent: Thursday, January 7, 2021 7:40 AM To: Huang, Sean Z ;

Re: [Intel-gfx] [RFC-v19 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2021-01-11 Thread Huang, Sean Z
! Best regards, Sean -Original Message- From: Vivi, Rodrigo Sent: Thursday, January 7, 2021 7:36 AM To: Huang, Sean Z ; Intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [RFC-v19 03/13] drm/i915/pxp: Implement funcs to create the TEE channel On Wed, 2021-01-06 at 15:12 -0800

Re: [Intel-gfx] [RFC-v19 01/13] drm/i915/pxp: Introduce Intel PXP component

2021-01-11 Thread Huang, Sean Z
which is encrypted with the leverage of the arbitrary hardware session. Best regards, Sean -Original Message----- From: Vivi, Rodrigo Sent: Thursday, January 7, 2021 7:29 AM To: Huang, Sean Z ; Intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [RFC-v19 01/13] drm/i915/p

Re: [Intel-gfx] [RFC-v19 02/13] drm/i915/pxp: set KCR reg init during the boot time

2021-01-11 Thread Huang, Sean Z
nas Lahtinen Sent: Friday, January 8, 2021 3:31 AM To: Huang, Sean Z ; Intel-gfx@lists.freedesktop.org; Vivi, Rodrigo Subject: Re: [Intel-gfx] [RFC-v19 02/13] drm/i915/pxp: set KCR reg init during the boot time Quoting Vivi, Rodrigo (2021-01-07 17:31:36) > On Wed, 2021-01-06 at 15:12 -0800

[Intel-gfx] [RFC-v19 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2021-01-06 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm

[Intel-gfx] [RFC-v19 02/13] drm/i915/pxp: set KCR reg init during the boot time

2021-01-06 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[Intel-gfx] [RFC-v19 08/13] drm/i915/pxp: Enable PXP power management

2021-01-06 Thread Huang, Sean Z
the power cycle. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++ drivers/gpu/drm/i915/i915_drv.c| 4 ++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c| 65 ++ drivers/gpu/drm/i915

[Intel-gfx] [RFC-v19 09/13] drm/i915/pxp: Expose session state for display protection flip

2021-01-06 Thread Huang, Sean Z
. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 21 + drivers/gpu/drm/i915/pxp/intel_pxp.h | 18 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c index

[Intel-gfx] [RFC-v19 13/13] drm/i915/pxp: Add plane decryption support

2021-01-06 Thread Huang, Sean Z
user_flags instead gem_object_metadata. [Krishna] Cc: Bommu Krishnaiah Cc: Huang, Sean Z Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 19 insertions(+), 3 deletions

[Intel-gfx] [RFC-v19 12/13] drm/i915/pxp: User interface for Protected buffer

2021-01-06 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 19

[Intel-gfx] [RFC-v19 10/13] mei: pxp: export pavp client to me client bus

2021-01-06 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v19 04/13] drm/i915/pxp: Create the arbitrary session after boot

2021-01-06 Thread Huang, Sean Z
needs to be re-created after teardown or power event because hardware encryption key won't be valid after such cases. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.h

[Intel-gfx] [RFC-v19 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-01-06 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen

[Intel-gfx] [RFC-v19 07/13] drm/i915/pxp: Destroy arb session upon teardown

2021-01-06 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v19 05/13] drm/i915/pxp: Func to send hardware session termination

2021-01-06 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c

[Intel-gfx] [RFC-v19 00/13] Introduce Intel PXP component - Mesa single session

2021-01-06 Thread Huang, Sean Z
5/uapi: introduce drm_i915_gem_create_ext drm/i915/pxp: User interface for Protected buffer Huang, Sean Z (9): drm/i915/pxp: Introduce Intel PXP component drm/i915/pxp: set KCR reg init during the boot time drm/i915/pxp: Implement funcs to create the TEE channel drm/i915/pxp: Create the

[Intel-gfx] [RFC-v19 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2021-01-06 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +- drivers/gpu/drm/i915

[Intel-gfx] [RFC-v19 01/13] drm/i915/pxp: Introduce Intel PXP component

2021-01-06 Thread Huang, Sean Z
(a.k.a default session or arbitrary session). So Mesa can allocate the protected buffer, which is encrypted with the leverage of the arbitrary hardware session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Kconfig | 22 +++ drivers/gpu/drm/i915/Makefile

[Intel-gfx] [RFC-v18 12/13] drm/i915/pxp: User interface for Protected buffer

2021-01-03 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 19

[Intel-gfx] [RFC-v18 10/13] mei: pxp: export pavp client to me client bus

2021-01-03 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v18 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2021-01-03 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm

[Intel-gfx] [RFC-v18 08/13] drm/i915/pxp: Enable PXP power management

2021-01-03 Thread Huang, Sean Z
the power cycle. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++ drivers/gpu/drm/i915/i915_drv.c| 4 ++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c| 65 ++ drivers/gpu/drm/i915

[Intel-gfx] [RFC-v18 07/13] drm/i915/pxp: Destroy arb session upon teardown

2021-01-03 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v18 04/13] drm/i915/pxp: Create the arbitrary session after boot

2021-01-03 Thread Huang, Sean Z
needs to be re-created after teardown or power event because hardware encryption key won't be valid after such cases. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.h

[Intel-gfx] [RFC-v18 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-01-03 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen

[Intel-gfx] [RFC-v18 05/13] drm/i915/pxp: Func to send hardware session termination

2021-01-03 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c

[Intel-gfx] [RFC-v18 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2021-01-03 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +- drivers/gpu/drm/i915

[Intel-gfx] [RFC-v18 13/13] drm/i915/pxp: Add plane decryption support

2021-01-03 Thread Huang, Sean Z
user_flags instead gem_object_metadata. [Krishna] Cc: Bommu Krishnaiah Cc: Huang, Sean Z Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 19 insertions(+), 3 deletions

[Intel-gfx] [RFC-v18 00/13] Introduce Intel PXP component - Mesa single session

2021-01-03 Thread Huang, Sean Z
ng protected flag for gem context - In #12, Replace i915_gem_context_set_protected() with intel_pxp_gem_context_set_protected() to check whether the arbitrary session is alive Anshuman Gupta (1): drm/i915/pxp: Add plane decryption support Bommu Krishnaiah (2): drm/i915/uapi: introduce drm_i91

[Intel-gfx] [RFC-v18 02/13] drm/i915/pxp: set KCR reg init during the boot time

2021-01-03 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[Intel-gfx] [RFC-v18 09/13] drm/i915/pxp: Expose session state for display protection flip

2021-01-03 Thread Huang, Sean Z
. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 21 + drivers/gpu/drm/i915/pxp/intel_pxp.h | 18 ++ drivers/gpu/drm/i915/pxp/intel_pxp_arb.c | 4 ++-- drivers/gpu/drm/i915/pxp/intel_pxp_arb.h | 1 + 4 files changed, 42 insertions

[Intel-gfx] [RFC-v18 01/13] drm/i915/pxp: Introduce Intel PXP component

2021-01-03 Thread Huang, Sean Z
(a.k.a default session or arbitrary session). So Mesa can allocate the protected buffer, which is encrypted with the leverage of the arbitrary hardware session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Kconfig | 22 +++ drivers/gpu/drm/i915/Makefile

[Intel-gfx] [RFC-v17 06/13] drm/i915/pxp: Enable PXP irq worker and callback stub

2021-01-02 Thread Huang, Sean Z
Create the irq worker that serves as callback handler, those callback stubs should be called while the hardware key teardown occurs. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 3 +- drivers/gpu/drm/i915

[Intel-gfx] [RFC-v17 09/13] drm/i915/pxp: Expose session state for display protection flip

2021-01-02 Thread Huang, Sean Z
Implement the intel_pxp_gem_object_status() to allow i915 display querying the current PXP session state. In the design, display should not perform protection flip on the protected buffers if there is no PXP session alive. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c

[Intel-gfx] [RFC-v17 04/13] drm/i915/pxp: Create the arbitrary session after boot

2021-01-02 Thread Huang, Sean Z
needs to be re-created after teardown or power event because hardware encryption key won't be valid after such cases. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.h

[Intel-gfx] [RFC-v17 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2021-01-02 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm

[Intel-gfx] [RFC-v17 07/13] drm/i915/pxp: Destroy arb session upon teardown

2021-01-02 Thread Huang, Sean Z
Teardown is triggered when the display topology changes and no long meets the secure playback requirement, and hardware trashes all the encryption keys for display. So as a result, PXP should handle such case and terminate the type0 sessions, which including arb session Signed-off-by: Huang, Sean

[Intel-gfx] [RFC-v17 12/13] drm/i915/pxp: User interface for Protected buffer

2021-01-02 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 ++-- drivers

[Intel-gfx] [RFC-v17 10/13] mei: pxp: export pavp client to me client bus

2021-01-02 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

[Intel-gfx] [RFC-v17 13/13] drm/i915/pxp: Add plane decryption support

2021-01-02 Thread Huang, Sean Z
user_flags instead gem_object_metadata. [Krishna] Cc: Bommu Krishnaiah Cc: Huang, Sean Z Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 19 insertions(+), 3 deletions

[Intel-gfx] [RFC-v17 08/13] drm/i915/pxp: Enable PXP power management

2021-01-02 Thread Huang, Sean Z
the power cycle. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 ++ drivers/gpu/drm/i915/i915_drv.c| 4 ++ drivers/gpu/drm/i915/pxp/intel_pxp_pm.c| 65 ++ drivers/gpu/drm/i915

[Intel-gfx] [RFC-v17 05/13] drm/i915/pxp: Func to send hardware session termination

2021-01-02 Thread Huang, Sean Z
Implement the functions to allow PXP to send a GPU command, in order to terminate the hardware session, so hardware can recycle this session slot for the next usage. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/pxp/intel_pxp.c

[Intel-gfx] [RFC-v17 00/13] Introduce Intel PXP component - Mesa single session

2021-01-02 Thread Huang, Sean Z
- Remove the binary from source code via defining the TEE command header v17 In #04, directly return intel_pxp_tee_component_fini() if pxp_tee_comp_added is off Anshuman Gupta (1): drm/i915/pxp: Add plane decryption support Bommu Krishnaiah (2): drm/i915/uapi: introduce drm_

[Intel-gfx] [RFC-v17 01/13] drm/i915/pxp: Introduce Intel PXP component

2021-01-02 Thread Huang, Sean Z
(a.k.a default session or arbitrary session). So Mesa can allocate the protected buffer, which is encrypted with the leverage of the arbitrary hardware session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Kconfig | 22 +++ drivers/gpu/drm/i915/Makefile

[Intel-gfx] [RFC-v17 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2021-01-02 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen

[Intel-gfx] [RFC-v17 02/13] drm/i915/pxp: set KCR reg init during the boot time

2021-01-02 Thread Huang, Sean Z
Set the KCR init during the boot time, which is required by hardware, to allow us doing further protection operation such as sending commands to GPU or TEE. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[Intel-gfx] [RFC-v16 03/13] drm/i915/pxp: Implement funcs to create the TEE channel

2020-12-30 Thread Huang, Sean Z
Implement the funcs to create the TEE channel, so kernel can send the TEE commands directly to TEE for creating the arbitrary (defualt) session. Signed-off-by: Huang, Sean Z --- drivers/gpu/drm/i915/Makefile| 3 +- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm

[Intel-gfx] [RFC-v16 13/13] drm/i915/pxp: Add plane decryption support

2020-12-30 Thread Huang, Sean Z
user_flags instead gem_object_metadata. [Krishna] Cc: Bommu Krishnaiah Cc: Huang, Sean Z Signed-off-by: Anshuman Gupta --- drivers/gpu/drm/i915/display/intel_sprite.c | 21 ++--- drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 19 insertions(+), 3 deletions

[Intel-gfx] [RFC-v16 11/13] drm/i915/uapi: introduce drm_i915_gem_create_ext

2020-12-30 Thread Huang, Sean Z
From: Bommu Krishnaiah Same old gem_create but with now with extensions support. This is needed to support various upcoming usecases. For now we use the extensions mechanism to support PAVP. Signed-off-by: Bommu Krishnaiah Signed-off-by: Matthew Auld Cc: Joonas Lahtinen

[Intel-gfx] [RFC-v16 00/13] Introduce Intel PXP component - Mesa single session

2020-12-30 Thread Huang, Sean Z
04: - Remove the binary from source code via defining the TEE command header Anshuman Gupta (1): drm/i915/pxp: Add plane decryption support Bommu Krishnaiah (2): drm/i915/uapi: introduce drm_i915_gem_create_ext drm/i915/pxp: User interface for Protected buffer Huang, Sean Z (9):

[Intel-gfx] [RFC-v16 12/13] drm/i915/pxp: User interface for Protected buffer

2020-12-30 Thread Huang, Sean Z
From: Bommu Krishnaiah This api allow user mode to create Protected buffer and context creation. Signed-off-by: Bommu Krishnaiah Cc: Telukuntla Sreedhar Cc: Kondapally Kalyan Cc: Gupta Anshuman Cc: Huang Sean Z --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 ++-- drivers

[Intel-gfx] [RFC-v16 10/13] mei: pxp: export pavp client to me client bus

2020-12-30 Thread Huang, Sean Z
From: Vitaly Lubart Export PAVP client to work with i915_cp driver, for binding it uses kernel component framework. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 2 + drivers/misc/mei/Makefile | 1 + drivers/misc/mei/pxp/Kconfig |

  1   2   3   4   5   6   >