Hi @I915-ci-infra,
On Thursday, 25 April 2024 19:29:17 CEST Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/gt: Disarm breadcrumbs if engines are already idle (rev2)
> URL : https://patchwork.freedesktop.org/series/132786/
> State : failure
>
> == Summary ==
>
> CI Bug Log -
Hi Thomas,
On Tuesday, 16 April 2024 18:40:12 CEST Rodrigo Vivi wrote:
> On Tue, Apr 16, 2024 at 10:09:46AM +0200, Janusz Krzysztofik wrote:
> > Hi Rodrigo,
> >
> > On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote:
> > > On Mon, Apr 15, 2024 at 09:53:
o sleep.
Fixes: 9d5612ca165a ("drm/i915/gt: Defer enabling the breadcrumb interrupt to
after submission")
Closes: https://gitlab.freedesktop.org/drm/intel/issues/10026
Signed-off-by: Chris Wilson
Cc: Andrzej Hajda
Cc: # v5.12+
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/dr
On Wednesday, 17 April 2024 11:37:55 CEST Kamil Konieczny wrote:
> Hi Janusz,
> On 2024-04-15 at 19:31:59 +0200, Janusz Krzysztofik wrote:
> > KUnit can provide KTAP reports from test modules via debugfs files, one
> > per test suite. Using that source of test results ins
On Tuesday, 16 April 2024 12:50:05 CEST Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/vma: Fix UAF on reopen vs destroy race (rev3)
> URL : https://patchwork.freedesktop.org/series/132360/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_14582_full ->
Hi Rodrigo,
On Tuesday, 16 April 2024 03:16:31 CEST Rodrigo Vivi wrote:
> On Mon, Apr 15, 2024 at 09:53:09PM +0200, Janusz Krzysztofik wrote:
> > We defer actually closing, unbinding and destroying a VMA until next idle
> > point, or until the object is freed in the meantime.
nk on VMA park so it
looks like still on a list, don't try to delete it from the list again
after the VMA has been marked as parked.
Fixes: b0647a5e79b1 ("drm/i915: Avoid live-lock with i915_vma_parked()")
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10608
Signed
ike still on a list, don't try to delete it from the list again
after the VMA has been marked as parked.
Fixes: b0647a5e79b1 ("drm/i915: Avoid live-lock with i915_vma_parked()")
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10608
Signed-off-by: Janusz Krzysztofik
Cc: Chris W
, protected from buffer
overflow or truncation with a single check for enough buffer space
(Lucas),
- avoid confusing 'if' statement condition (Lucas).
Signed-off-by: Janusz Krzysztofik
Cc: Kamil Konieczny
Reviewed-by: Lucas De Marchi
---
@Lucas: I've assumed your R-b still applies, I hope
00 ]---
Aso soon as we start unbinding and destroing a VMA, marked it as parked,
and also keep it marked as closed for the rest of its life. When a VMA
to be opened occurs closed, reopen it only if not yet parked.
Fixes: b0647a5e79b1 ("drm/i915: Avoid live-lock with i915_vma_par
Hi Lucas,
On Friday, 5 April 2024 19:54:53 CEST Janusz Krzysztofik wrote:
> KUnit can provide KTAP reports from test modules via debugfs files, one
> per test suite. Using that source of test results instead of extracting
> them from dmesg, where they may be interleaved with oth
pathname
components concatentated to a local buffer, protected from buffer
overflow or truncation with a single check for enough buffer space
(Lucas),
- avoid confusing 'if' statement condition (Lucas).
Signed-off-by: Janusz Krzysztofik
Cc: Kamil Konieczny
Cc: Lucas De Marchi
On Wednesday, 27 March 2024 22:54:53 CET Janusz Krzysztofik wrote:
> On Wednesday, 27 March 2024 17:03:01 CET Lucas De Marchi wrote:
> > On Wed, Mar 27, 2024 at 12:22:54PM +0100, Janusz Krzysztofik wrote:
> > >KUnit can provide KTAP reports from test modules via debugfs files,
On Wednesday, 27 March 2024 18:27:50 CET Kamil Konieczny wrote:
> Hi Janusz,
> On 2024-03-27 at 12:22:54 +0100, Janusz Krzysztofik wrote:
> > KUnit can provide KTAP reports from test modules via debugfs files, one
> > per test suite. Using that source of test results ins
On Wednesday, 27 March 2024 17:03:01 CET Lucas De Marchi wrote:
> On Wed, Mar 27, 2024 at 12:22:54PM +0100, Janusz Krzysztofik wrote:
> >KUnit can provide KTAP reports from test modules via debugfs files, one
> >per test suite. Using that source of test results instead of extracti
debugfs support is found not configured then fall back to legacy
processing path.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 143 -
1 file changed, 105 insertions(+), 38 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index
mon when unregistering i915, and teach hwmon
sysfs accessors to start with checking validity of those pointers and fail
immediately if no longer valid.
Suggested-by: Ashutosh Dixit
Fixes: b3b088e28183 ("drm/i915/hwmon: Add HWMON infrastructure")
Closes: https://gitlab.freedesktop.org
n
> > Cc: Mika Kuoppala
> > Signed-off-by: Janusz Krzysztofik
> > Cc: Chris Wilson
> > Cc: # v5.4+
>
> this tag list is a bit confusing. Let's keep all Cc's together
> and, besides, Cc'eing the author looks a bit redundant.
You're right, please feel free to fix th
e/0x130
<4>[ 167.305997] ret_from_fork+0x2c/0x50
<4>[ 167.306001] ret_from_fork_asm+0x1b/0x30
<4>[ 167.306004]
It is necessary for the queue_priority_hint to be lower than the next
request submission upon waking up, as we rely on the hint to decide when
to kick the
that location as an argument and reset the pointer after freeing
the structure.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 12 +---
lib/igt_ktap.c | 5 +++--
lib/igt_ktap.h | 2 +-
lib/tests/igt_ktap_parser.c | 24
to struct igt_ktap_results pointer handling.
v2: Rebased on invalid test suite name workaround.
Signed-off-by: Janusz Krzysztofik
Cc: Jonathan Cavitt
---
lib/igt_kmod.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index c495d11b16
tailed justification of why we
need these changes.
Signed-off-by: Janusz Krzysztofik
Cc: Mauro Carvalho Chehab
Cc: Jonathan Cavitt
Cc: Kamil Konieczny
---
lib/igt_kmod.c | 156 +
1 file changed, 54 insertions(+), 102 deletions(-)
diff --gi
and parse that report.
Suggested-by: Kamil Konieczny
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index 8a6824ea7e..f0e4d5ec76 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -1204,12
-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index b4b8848983..ca20012a97 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -1207,10 +1207,10 @@ static void
module, and errors they return
are handled,
- update commit description with a more detailed justification of why we
need these changes,
- rebase the former patch 1 on top of the new patch 1, update its commit
message and description and provide it as patch 2.
Janusz Krzysztofik (5
On Thursday, 14 March 2024 11:29:38 CET Kamil Konieczny wrote:
> Hi Janusz,
> On 2024-02-27 at 16:10:41 +0100, Janusz Krzysztofik wrote:
> > Up to now we were loading a KUnit test module in test execution mode only
> > once per subtest, in background, and then, in paral
On Tuesday, 12 March 2024 18:09:37 CET Andi Shyti wrote:
> Hi Janusz,
>
> On Mon, Mar 11, 2024 at 09:34:58PM +0100, Janusz Krzysztofik wrote:
> > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an
> > rpm wakeref. That results in lock inversion:
>
Hi Ashutosh,
On Tuesday, 12 March 2024 17:25:14 CET Dixit, Ashutosh wrote:
> On Mon, 11 Mar 2024 13:34:58 -0700, Janusz Krzysztofik wrote:
> >
> > In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an
> > rpm wakeref. That results in lock inversion:
&g
Hi Bug Filing,
On Tuesday, 12 March 2024 11:02:19 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/hwmon: Fix locking inversion in sysfs getter (rev2)
> URL : https://patchwork.freedesktop.org/series/130966/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
the lock is
also held. Follow that pattern across the whole source file where similar
lock inversion can happen.
v2: Keep hardware read under the lock so the whole operation of updating
energy from hardware is still atomic (Guenter),
- instead, acquire the rpm wakeref before the lock and hold it as l
On Monday, 11 March 2024 18:35:43 CET Guenter Roeck wrote:
> On 3/11/24 09:58, Rodrigo Vivi wrote:
> > On Mon, Mar 11, 2024 at 09:06:46AM +0100, Janusz Krzysztofik wrote:
> >> In i915 hwmon sysfs getter path we now take a hwmon_lock, then acquire an
> >> rpm wak
nergy+0x55/0x100 [i915]
<4> [197.793183] hwm_read+0x9a/0x310 [i915]
<4> [197.797124] hwmon_attr_show+0x36/0x120
<4> [197.800946] dev_attr_show+0x15/0x60
<4> [197.804509] sysfs_kf_seq_show+0xb5/0x100
However, the lock is only intended to protect either a hwmon overflow
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted
by "drm/i915/vma: Fix UAF on destroy against retire race".
Signed-off-by: Janusz Krzysztofik
Cc: Nirmoy Das
---
drivers/gpu/drm/i915/i915_vma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gp
o drop the no longer used .wakeref_gt0 field from struct
i915_execbuffer.
v2: Avoid the word "revert" in commit message (Rodrigo),
- update commit description reusing relevant chunks dropped from the
description of the proper fix (Rodrigo).
Signed-off-by: Janusz Krzysztofik
Cc
age and description.
v2: Get the wakeref before VM mutex to avoid circular locking dependency,
- drop questionable Fixes: tag.
Fixes: d93939730347 ("drm/i915: Remove the vma refcount")
Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875
Signed-off-by: Janusz Krzysztofik
Cc: Thomas He
es (Nirmoy).
- clean up commit message and description a bit.
v3: Identify root cause more precisely, and a commit to blame,
- identify and drop former workarounds,
- update commit message and description.
v2: Get the wakeref before VM mutex to avoid circular locking dependency,
- drop question
On Friday, 23 February 2024 05:10:10 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/selftests: Fix dependency of some timeouts on HZ
> URL : https://patchwork.freedesktop.org/series/130249/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_14316_full
On Thursday, 29 February 2024 23:16:22 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/selftest_hangcheck: Check sanity with more patience
> URL : https://patchwork.freedesktop.org/series/130512/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
o drop the no longer used .wakeref_gt0 field from struct
i915_execbuffer.
v2: Avoid the word "revert" in commit message (Rodrigo),
- update commit description reusing relevant chunks dropped from the
description of the proper fix (Rodrigo).
Signed-off-by: Janusz Krzysztofik
Cc
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted
by "drm/i915/vma: Fix UAF on destroy against retire race".
Signed-off-by: Janusz Krzysztofik
Cc: Nirmoy Das
---
drivers/gpu/drm/i915/i915_vma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gp
s,
- update commit message and description.
v2: Get the wakeref before VM mutex to avoid circular locking dependency,
- drop questionable Fixes: tag.
Fixes: d93939730347 ("drm/i915: Remove the vma refcount")
Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875
Signed-off-b
s and move them to separate patches (Nirmoy).
- clean up commit message and description a bit.
v3: Identify root cause more precisely, and a commit to blame,
- identify and drop former workarounds,
- update commit message and description.
v2: Get the wakeref before VM mutex to avoid circular loc
with the i915 module also when loaded in selftest mode,
relax our expectations on time consumed by the sanity check request before
it completes.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
-
subtests if unloading the test module fails,
- update commit description with a more detailed justification of why we
need these changes.
Signed-off-by: Janusz Krzysztofik
Cc: Mauro Carvalho Chehab
---
lib/igt_kmod.c | 157 -
1 file changed
KTAP report, no matter how many test suites and test cases it
covers. Then, it's a good candidate for reuse in other scenarios when a
single KTAP report is handled, e.g., when we collect a list of test cases
from a single test suite or test module. Go for it.
Signed-off-by: Janusz Krzysztofik
these changes,
- rebase the former patch 1 on top of the new patch 1, update its commit
message and description and provide it as patch 2.
Janusz Krzysztofik (2):
lib/kunit: Execute test cases synchronously
lib/kunit: Minimize code duplication
lib/igt_kmod.c | 172
and custom kernel configs.
Rename the symbol to clearly indicate intended units and convert it to
jiffies before use.
Fixes: 3a4bfa091c46 ("drm/i915/selftest: Fix workarounds selftest for GuC
submission")
Signed-off-by: Janusz Krzysztofik
Cc: Rahul Kumar Singh
Cc: John Harrison
C
Hi John,
On Wednesday, 10 January 2024 22:02:16 CET john.c.harri...@intel.com wrote:
> From: John Harrison
>
> The context persistence code does things like send super high priority
> heartbeat pulses to ensure any leaked context can still be pre-empted
> and thus isn't a total denial of
e() used in DMA fence callbacks. I'm going to
verify some ideas for a fix on trybot.
Thanks,
Janusz
>
>
> Regards,
>
> Nirmoy
>
> On 1/24/2024 6:13 PM, Janusz Krzysztofik wrote:
> > Object debugging tools were sporadically reporting illegal attempts to
> > free a s
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted
by "drm/i915/vma: Fix UAF on destroy against retire race".
Signed-off-by: Janusz Krzysztofik
Cc: Nirmoy Das
---
drivers/gpu/drm/i915/i915_vma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gp
oid the word "revert" in commit message (Rodrigo),
- update commit description reusing relevant chunks dropped from the
description of the proper fix (Rodrigo).
Signed-off-by: Janusz Krzysztofik
Cc: Nirmoy Das
Cc: Rodrigo Vivi
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
it to blame,
- identify and drop former workarounds,
- update commit message and description.
v2: Get the wakeref before VM mutex to avoid circular locking dependency,
- drop questionable Fixes: tag.
Fixes: d93939730347 ("drm/i915: Remove the vma refcount")
Closes: https://git
arate patches (Nirmoy).
- clean up commit message and description a bit.
v3: Identify root cause more precisely, and a commit to blame,
- identify and drop former workarounds,
- update commit message and description.
v2: Get the wakeref before VM mutex to avoid circular locking dependency,
- d
Hi Rodrigo,
Thank you for review.
On Monday, 22 January 2024 22:09:38 CET Rodrigo Vivi wrote:
> On Mon, Jan 22, 2024 at 03:04:42PM +0100, Janusz Krzysztofik wrote:
> > Object debugging tools were sporadically reporting illegal attempts to
> > free a still active i915 VMA obje
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted by
"drm/i915/vma: Fix UAF on destroy against retire race".
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_vma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c
This reverts changes introduced by commit f56fe3e91787, obsoleted by
"drm/i915/vma: Fix UAF on destroy against retire race".
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drive
iption.
v2: Get the wakeref before VM mutex to avoid circular locking dependency,
- drop questionable Fixes: tag.
Fixes: d93939730347 ("drm/i915: Remove the vma refcount")
Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875
Signed-off-by: Janusz Krzysztofik
Cc: Thom
On Friday, 17 November 2023 17:48:03 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/vma: Fix VMA UAF on destroy against deactivate race (rev2)
> URL : https://patchwork.freedesktop.org/series/126530/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
- update commit message and description.
v2: Get the wakeref before VM mutex to avoid circular locking dependency,
- drop questionable Fixes: tag.
Fixes: d93939730347 ("drm/i915: Remove the vma refcount")
Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875
Signed-off-by: Janusz
On Wednesday, 15 November 2023 13:10:33 CET Andrzej Hajda wrote:
> Trace requires new-line at the end of message (in opposition to printk),
> otherwise trace dump becomes messy.
>
> Signed-off-by: Andrzej Hajda
Acked-by: Janusz Krzysztofik
> ---
> drivers/gpu/drm/i915/gt
On Thursday, 9 November 2023 22:44:02 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/vma: Fix potential UAF on multi-tile platforms (rev3)
> URL : https://patchwork.freedesktop.org/series/126012/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13856
On Wednesday, 8 November 2023 22:27:35 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/vma: Fix potential UAF on multi-tile platforms (rev2)
> URL : https://patchwork.freedesktop.org/series/126012/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13852
Lake.
v2: Get the wakeref before vm mutex to avoid circular locking dependency,
- drop questionable Fixes: tag.
Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_vma.c | 26 +++---
1 file changed
On Monday, 6 November 2023 20:16:20 CET Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/vma: Fix potential UAF on multi-tile platforms
> URL : https://patchwork.freedesktop.org/series/126012/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13844 ->
Hi Jani,
Thanks for looking at this.
On Monday, 6 November 2023 10:53:11 CET Jani Nikula wrote:
> On Mon, 06 Nov 2023, Janusz Krzysztofik
wrote:
> > Object debugging tools were sporadically reporting illegal attempts to
> > free a still active i915 VMA object from when par
async variant
of wakeref put.
Closes: https://gitlab.freedesktop.org/drm/intel/issues/8875
Fixes: Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'force_probe' requirement
for Meteor Lake")
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_vma.c | 18
kunit_kmsg_get_result(),
- use kunit_results_free() helper,
- fix typos (Kamil),
- update commit description.
Signed-off-by: Janusz Krzysztofik
Acked-by: Kamil Konieczny # v2
---
lib/igt_kmod.c | 277 ++---
1 file changed, 264 insertions(+), 13
sub-subtests, and do that only from the first actually executed
dynamic sub-subtest.
v2: Always pass last result to next dynamic sub-subtest, fetch first
result right after loading the kunit test module for execution.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib
to kunit and the i915 module potentially
providing three test suites: mock, live and perf).
[1] https://docs.kernel.org/dev-tools/kunit/style.html
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
tests/kms_selftest.c | 37 -
1 file changed
Planned changes require a couple of loops around kunit_result_free().
Since we already have such loop, move it into a helper in preparation for
future uses.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib/igt_kmod.c | 20 ++--
1 file changed, 14
will be performed after the kunit test module is successfully loaded and
there will be no concurrently running modprobe thread, we need to make
synchronization of reads from /dev/kmsg with potential errors modprobe
thread optional.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib
is into
account when composing names for IGT dynamic sub-subtest names and drop
the leading test suite name component when it is the same as subtest name.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Mauro Carvalho Chehab
---
lib/igt_kmod.c | 11 ---
1 file changed, 8 insertions(+),
-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib/igt_kmod.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index df0e650d49..426ae5b26f 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -762,15 +762,6 @@ static void
be failure.
Signed-off-by: Janusz Krzysztofik
Acked-by: Mauro Carvalho Chehab # v2
---
lib/igt_kmod.c | 264 +++
lib/igt_ktap.c | 569 +
lib/igt_ktap.h | 22 --
3 files changed, 226 insertions(+), 629 deletions(-)
diff -
Use a more verbose variant of igt_fail() when failing a dynamic sub-
subtest on kernel taint. Also, print a debug message on string
duplication failure.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib/igt_kmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Function fcntl(..., F_GETFL, ...) that returns file status flags may also
return a negative error code. Handle that error instead of blindly using
the returned value as flags.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib/igt_kmod.c | 4 ++--
1 file changed, 2
always pass last result to next dynamic sub-subtest, fetch first
result right after loading the kunit test module for execution,
- still break the loop of test cases on unexpected return codes from
kunit_kmsg_get_result(),
- fix typos (Kamil),
- update commit descriptions.
Janusz Kr
workaround in place.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_ktap.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/lib/igt_ktap.c b/lib/igt_ktap.c
index 5eac102417..3df4d6950d 100644
--- a/lib/igt_ktap.c
+++ b/lib/igt_ktap.c
@@ -91,9 +91,16 @@ int igt_ktap_p
Hi Mauro,
Thanks for review.
On Tuesday, 10 October 2023 15:33:57 CEST Mauro Carvalho Chehab wrote:
> On Mon, 9 Oct 2023 14:27:55 +0200
> Janusz Krzysztofik wrote:
>
> > There was an attempt to parse KTAP reports in the background while a kunit
> > test module is loa
Hi Kamil,
Thanks for review.
On Tuesday, 10 October 2023 17:59:56 CEST Kamil Konieczny wrote:
> Hi Janusz,
> On 2023-10-09 at 14:27:55 +0200, Janusz Krzysztofik wrote:
> > There was an attempt to parse KTAP reports in the background while a kunit
> > test module is loadin
Hi Kamil,
Thanks for review.
On Monday, 9 October 2023 19:37:31 CEST Kamil Konieczny wrote:
> Hi Janusz,
> On 2023-10-09 at 14:28:00 +0200, Janusz Krzysztofik wrote:
> > We are going to add support for reading a list of kunit test cases
> > provided by a kunit test module
sub-subtests, and do that only from the first actually executed
dynamic sub-subtest.
v2: Always pass last result to next dynamic sub-subtest, fetch first
result right after loading the kunit test module for execution.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 66
dynamic sub-subtest, and we always free last result
before looping to next sub-subtest,
- still break the loop of test cases on unexpected return codes from
kunit_kmsg_get_result(),
- use kunit_results_free() helper,
- fix typos (Kamil),
- update commit description.
Signed-off-by: Janusz
will be performed after the kunit test module is successfully loaded and
there will be no concurrently running modprobe thread, we need to make
synchronization of reads from /dev/kmsg with potential errors modprobe
thread optional.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 50
Planned changes require a couple of loops around kunit_result_free().
Since we already have such loop, move it into a helper in preparation for
future uses.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff
to kunit and the i915 module potentially
providing three test suites: mock, live and perf).
[1] https://docs.kernel.org/dev-tools/kunit/style.html
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
tests/kms_selftest.c | 37 -
1 file changed
has
fixed that issue, that workaround is no longer needed. Drop it.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_ktap.c | 12
lib/tests/igt_ktap_parser.c | 3 +--
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/lib/igt_ktap.c b/lib/igt_ktap.c
index
is into
account when composing names for IGT dynamic sub-subtest names and drop
the leading test suite name component when it is the same as subtest name.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Mauro Carvalho Chehab
---
lib/igt_kmod.c | 11 ---
1 file changed, 8 insertions(+),
been processed,
- fix trailing newlines missing from error messages,
- add more debug statements,
- integrate common code around kunit_result_free() into it.
v2: Interrupt blocking read() on modprobe failure.
Signed-off-by: Janusz Krzysztofik
Acked-by: Mauro Carvalho Chehab # v2
---
lib
-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib/igt_kmod.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index df0e650d49..426ae5b26f 100644
--- a/lib/igt_kmod.c
+++ b/lib/igt_kmod.c
@@ -762,15 +762,6 @@ static void
Function fcntl(..., F_GETFL, ...) that returns file status flags may also
return a negative error code. Handle that error instead of blindly using
the returned value as flags.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib/igt_kmod.c | 4 ++--
1 file changed, 2
Use a more verbose variant of igt_fail() when failing a dynamic sub-
subtest on kernel taint. Also, print a debug message on string
duplication failure.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
---
lib/igt_kmod.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
- still break the loop of test cases on unexpected return codes from
kunit_kmsg_get_result(),
- fix typos (Kamil),
- update commit descriptions.
Janusz Krzysztofik (11):
lib/kunit: Fix handling of potential errors from F_GETFL
lib/kunit: Be more verbose on errors
lib/kunit: Fix
Hi Kamil,
Thanks for review.
On Thursday, 5 October 2023 23:28:44 CEST Kamil Konieczny wrote:
> Hi Janusz,
>
> On 2023-10-03 at 11:10:53 +0200, Janusz Krzysztofik wrote:
> > Recent improvements to the kernel kunit framework allow us to obtain a
> > list of test cases pro
sub-subtests, and do that only from the first actually executed
dynamic sub-subtest.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 59 --
1 file changed, 33 insertions(+), 26 deletions(-)
diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
index
to kunit and the i915 module potentially
providing three test suites: mock, live and perf).
[1] https://docs.kernel.org/dev-tools/kunit/style.html
Signed-off-by: Janusz Krzysztofik
---
tests/kms_selftest.c | 37 -
1 file changed, 16 insertions(+), 21 deletions
has
fixed that issue, that workaround is no longer needed. Drop it.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_ktap.c | 12
lib/tests/igt_ktap_parser.c | 3 +--
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/lib/igt_ktap.c b/lib/igt_ktap.c
index
in advance, then we stop parsing
KTAP report as soon as we get a result from the last test case from the
list.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_kmod.c | 217 +++--
1 file changed, 157 insertions(+), 60 deletions(-)
diff --git a/lib/igt_kmod.c b
is into
account when composing names for IGT dynamic sub-subtest names and drop
the leading test suite name component when it is the same as subtest name.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Mauro Carvalho Chehab
---
lib/igt_kmod.c | 11 ---
1 file changed, 8 insertions(+),
been processed,
- fix trailing newlines missing from error messages,
- add more debug statements,
- integrate common code around kunit_result_free() into it.
v2: Interrupt blocking read() on modprobe failure.
Signed-off-by: Janusz Krzysztofik
Acked-by: Mauro Carvalho Chehab # v2
---
lib
1 - 100 of 804 matches
Mail list logo
