[Intel-gfx] [PATCH v8] drm/i915/edp: Be less aggressive about changing link config on eDP

com> Cc: Jani Nikula <jani.nik...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert DisplayPort fast link training feature") Reviewed-by: Manasi Navare <manasi.d.nav...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c

Re: [Intel-gfx] [PATCH v7] drm/i915/edp: Be less aggressive about changing link config on eDP

im > Thanks, > Rodrigo. > > > > > > Manasi > > > > On Tue, Aug 22, 2017 at 09:34:46AM -0700, Jim Bride wrote: > > > This set of changes has some history to them. There were several attempts > > > to add what was called "fast link t

[Intel-gfx] [PATCH v7] drm/i915/edp: Be less aggressive about changing link config on eDP

Nikula <jani.nik...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert DisplayPort fast link training feature") Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 2 ++ drivers/gpu/drm/i915/intel_dp_link_training.c | 15 ++

Re: [Intel-gfx] [PATCH v6] drm/i915/edp: Be less aggressive about changing link config on eDP

On Mon, Aug 21, 2017 at 11:27:37PM +, Vivi, Rodrigo wrote: > On Mon, 2017-08-21 at 14:03 -0700, Jim Bride wrote: > > This set of changes has some history to them. There were several attempts > > to add what was called "fast link training" to i915, which actually wasn

[Intel-gfx] [PATCH v6] drm/i915/edp: Be less aggressive about changing link config on eDP

is Wilson <ch...@chris-wilson.co.uk> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Manasi D Navare <manasi.d.nav...@intel.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Fixes: 34511dce4 (&q

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp: make is_edp non-static and rename to intel_dp_is_edp

On Fri, Aug 18, 2017 at 12:30:20PM +0300, Jani Nikula wrote: > Expose across driver for future work. No functional changes. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> > Cc: Manasi Navare <manasi.d.nav...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> &

Re: [Intel-gfx] [PATCH] drm/i915/dp: Fix the channel equalization failure condition during Link Training

gh the retry loop has not reached max retries. > So we need to consider this as a failure condition. > Reviewed-by: Jim Bride <jim.br...@linux.intel.com> > Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Cc: J

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: rename intel_dp_is_edp to intel_dp_is_port_edp

On Fri, Aug 18, 2017 at 12:30:19PM +0300, Jani Nikula wrote: > Emphasize that this is based on the port, not intel_dp. This is also in > line with the underlying intel_bios_is_port_edp() function. No > functional changes. Reviewed-by: Jim Bride <jim.br...@linux.intel.com> >

Re: [Intel-gfx] [PATCH v5] drm/i915/edp: Be less aggressive about changing link config on eDP

On Thu, Aug 17, 2017 at 12:20:03PM -0700, Manasi Navare wrote: > On Thu, Aug 17, 2017 at 10:50:04AM -0700, Jim Bride wrote: > > On Wed, Aug 16, 2017 at 03:13:06PM -0700, Manasi Navare wrote: > > > On Wed, Aug 09, 2017 at 02:21:07PM -0700, Jim Bride wrote: > > > >

Re: [Intel-gfx] [PATCH v5] drm/i915/edp: Be less aggressive about changing link config on eDP

On Wed, Aug 16, 2017 at 03:13:06PM -0700, Manasi Navare wrote: > On Wed, Aug 09, 2017 at 02:21:07PM -0700, Jim Bride wrote: > > This set of changes has some history to them. There were several attempts > > to add what was called "fast link training" to i915, which actu

Re: [Intel-gfx] [PATCH v5] drm/i915/psr: Account for sink CRC raciness on some panels

On Tue, Aug 15, 2017 at 04:41:52PM -0700, Rodrigo Vivi wrote: > On Tue, Aug 15, 2017 at 9:58 AM, Jim Bride <jim.br...@linux.intel.com> wrote: > > On Wed, Aug 09, 2017 at 01:40:00PM -0700, Jim Bride wrote: > >> According to the eDP spec, when the count field in TEST_S

Re: [Intel-gfx] [PATCH v6] drm/i915/edp: Allow alternate fixed mode for eDP if available.

On Thu, Aug 10, 2017 at 04:13:44PM +0300, Jani Nikula wrote: > On Wed, 09 Aug 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > Some fixed resolution panels actually support more than one mode, > > with the only thing different being the refresh rate. Having this > &g

[Intel-gfx] [PATCH v5] drm/i915/edp: Be less aggressive about changing link config on eDP

i <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Manasi D Navare <manasi.d.nav...@intel.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert DisplayPort fast link traini

[Intel-gfx] [PATCH v5] drm/i915/psr: Account for sink CRC raciness on some panels

ase v3: * Rebase v4: * Switch from do-while to for loop when reading CRC values (Jani) * Rebase v5: * Checkpatch cleanup and commit message tweaks * Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.co

[Intel-gfx] [PATCH v6] drm/i915/edp: Allow alternate fixed mode for eDP if available.

t;david.weineh...@linux.intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c| 38 +- drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/intel_dsi.c | 2 +- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v2] drm/i915/psr: Preserve SRD_CTL bit 29 on PSR init

age wording (Rodrigo) Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_p

Re: [Intel-gfx] [PATCH] drm/i915/psr: Preserve SRD_CTL bit 29 on PSR init

On Tue, Aug 08, 2017 at 07:42:50PM +, Vivi, Rodrigo wrote: > On Tue, 2017-08-08 at 08:51 -0700, Jim Bride wrote: > > Bit 29 of SRD_CTL needs to have its value preserved, > > probably good to kind of quote spec somehow: > "This field is used for hardware commun

[Intel-gfx] [PATCH] drm/i915/psr: Preserve SRD_CTL bit 29 on PSR init

...@chris-wilson.co.uk> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_psr.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/d

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

On Mon, Aug 07, 2017 at 08:55:00AM -0700, Jim Bride wrote: > On Fri, Aug 04, 2017 at 10:29:33AM +0300, Jani Nikula wrote: > > On Thu, 03 Aug 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > > On Fri, Jul 14, 2017 at 12:34:28PM +0300, Jani Nikula wrote: > >

Re: [Intel-gfx] [PATCH v4 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

On Fri, Aug 04, 2017 at 06:38:02PM +, Pandiyan, Dhinakaran wrote: > > > > On Thu, 2017-08-03 at 11:07 -0700, Rodrigo Vivi wrote: > > On Tue, Jul 18, 2017 at 2:34 PM, Jim Bride <jim.br...@linux.intel.com> > > wrote: > > > According to the eDP spec,

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

On Fri, Aug 04, 2017 at 10:29:33AM +0300, Jani Nikula wrote: > On Thu, 03 Aug 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > On Fri, Jul 14, 2017 at 12:34:28PM +0300, Jani Nikula wrote: > >> On Wed, 12 Jul 2017, Chris Wilson <ch...@chris-wilson.co.uk> wr

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

On Fri, Jul 14, 2017 at 12:34:28PM +0300, Jani Nikula wrote: > On Wed, 12 Jul 2017, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > > Quoting Dhinakaran Pandiyan (2017-07-12 09:47:25) > >> On Tuesday, July 11, 2017 3:19:53 PM PDT Jim Bride wrote: > >> &g

[Intel-gfx] [PATCH v5] drm/i915/edp: Allow alternate fixed mode for eDP if available.

rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c| 38

Re: [Intel-gfx] [PATCH v4 RESEND 0/4] Kernel PSR Fix-ups

On Tue, Jul 25, 2017 at 08:13:03PM +0300, David Weinehall wrote: > On Tue, Jul 25, 2017 at 09:48:07AM -0700, Jim Bride wrote: > > These patches, along with an upcoming series for IGT, enable our > > PSR IGT tests to run reliably once again on HSW, BDW, and SKL. > > The fi

[Intel-gfx] [PATCH v4 RESEND 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

o.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Wayne Boyer <wayne.bo...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v4 RESEND 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Manasi D Navare <manasi.d.nav...@intel.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert Displ

[Intel-gfx] [PATCH v4 RESEND 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

Rebase v3: * Rebase v4: * Switch from do-while to for loop when reading CRC values (Jani) * Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com

[Intel-gfx] [PATCH v4 RESEND 0/4] Kernel PSR Fix-ups

patches for details) * Rebase Jim Bride (4): drm/i915/psr: Clean-up intel_enable_source_psr1() drm/i915/psr: Account for sink CRC raciness on some panels drm/i915/edp: Be less aggressive about changing link config on eDP drm/i915/edp: Allow alternate fixed mode for eDP if available

[Intel-gfx] [PATCH v4 RESEND 4/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c| 34 +- drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/intel_dsi.c | 2 +- drivers/g

[Intel-gfx] [PATCH v4 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

Rebase v3: * Rebase v4: * Switch from do-while to for loop when reading CRC values (Jani) * Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com

[Intel-gfx] [PATCH v4 4/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c| 34 +- drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/intel_dsi.c | 2 +- drivers/g

[Intel-gfx] [PATCH v4 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

o.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Wayne Boyer <wayne.bo...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v4 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Manasi D Navare <manasi.d.nav...@intel.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert Displ

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

On Fri, Jul 14, 2017 at 12:46:08PM +0300, Jani Nikula wrote: > On Tue, 11 Jul 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > According to the eDP spec, when the count field in TEST_SINK_MISC > > increments then the six bytes of sink CRC information in the DPC

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/edp: Be less aggressive about changing link config on eDP

On Wed, Jul 12, 2017 at 02:53:36PM -0700, Manasi Navare wrote: > On Wed, Jul 12, 2017 at 10:38:03PM +0100, Chris Wilson wrote: > > Quoting Manasi Navare (2017-07-12 22:36:49) > > > On Wed, Jul 12, 2017 at 12:16:13AM +0100, Chris Wilson wrote: > > > > Quoting

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

On Wed, Jul 12, 2017 at 12:27:33AM +0100, Chris Wilson wrote: > Quoting Jim Bride (2017-07-11 23:19:55) > > @@ -5869,13 +5891,14 @@ static bool intel_edp_init_connector(struct > > intel_dp *intel_dp, > > } > > intel_connector->edid = edid; > >

[Intel-gfx] [PATCH IGT 06/11] lib: Add function to return PSR active status

Add igt_psr_active() which returns whether PSR is active or not and modify tests to use this function. Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/igt_psr.c| 19 +++ lib/igt_psr.h| 1 + tests/kms_fbcon

[Intel-gfx] [PATCH IGT 11/11] lib: Add igt_psr_get_sink_crc() and change tests to use it.

is retrieved in binary form. Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/igt_psr.c| 59 lib/igt_psr.h| 2 ++ tests/kms_frontbuffer_tracking.c | 25 ++ tests/kms_psr_sink_crc.c

[Intel-gfx] [PATCH IGT 01/11] tests/kms_psr_sink_crc: Change assert_or_manual() to a macro

Make assert_or_manual() a macro so that we get accurate line number information when this assertion fails. v2: Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by:

[Intel-gfx] [PATCH IGT 03/11] tests/kms_frontbuffer_tracking: Remove unneeded HSW work-around.

This work-around actually causes issues on HSW now. Without this code in-place I'm seeing good results on HSW. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_frontbuf

[Intel-gfx] [PATCH IGT 08/11] lib: Add igt_psr_print_status() and change tests to use it.

Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/igt_psr.c| 13 + lib/igt_psr.h| 1 + tests/kms_frontbuffer_tracking.c | 5 + 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/lib/igt_psr.c b/lib/igt_psr.c

[Intel-gfx] [PATCH IGT 02/11] tests/kms_frontbuffer_tracking: Fix multidraw subtest

The multidraw subtest was not taking whether or not the GEM buffer had ever been in write-combining mode when checking for PSR state, so fix that. Reviewed-by: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_frontbuffer_tr

[Intel-gfx] [PATCH IGT 10/11] lib: Add igt_psr_find_good_mode() and modify tests to use it.

Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/igt_psr.c| 34 + lib/igt_psr.h| 2 ++ tests/kms_fbcon_fbt.c| 4 tests/kms_frontbuffer_tracking.c | 2 +- tests/kms_psr_sink_crc.c

[Intel-gfx] [PATCH IGT 07/11] lib: Add igt_psr_await_status() and modify tests to use it.

Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/igt_psr.c| 12 lib/igt_psr.h| 1 + tests/kms_fbcon_fbt.c| 28 tests/kms_frontbuffer_tracking.c | 17 +

[Intel-gfx] [PATCH IGT 00/11] IGT PSR Fix-ups

and SKL: * kms_psr_sink_crc (all) * kms_frontbuffer_tracking (subtests psr-1p* and fbcpsr-1p*) * kms_fbcon_fbt (subtests psr*) Note: Based on review feedback the changes in this series were substantially restructured vs. previous versions. Jim Bride (11): tests

[Intel-gfx] [PATCH IGT 05/11] lib: Add library functions for PSR source and sink support

Add functions to tell whether the source and sink support PSR as well as a function to determine whether PSR is possible (both source and sink support PSR.) Also modify the PSR tests to use these functions. Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/Makefile.s

[Intel-gfx] [PATCH IGT 09/11] lib: Add igt_psr_valid_connector() and change tests to use it.

Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/igt_psr.c| 11 +++ lib/igt_psr.h| 1 + tests/kms_frontbuffer_tracking.c | 12 +++- tests/kms_psr_sink_crc.c | 2 +- 4 files changed, 20 insertions(+), 6 del

[Intel-gfx] [PATCH IGT 04/11] lib: Add utility functions to enable and disable PSR.

Create files to contain PSR-specific IGT functions and add macros to enable and disable PSR. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/Makefile.sources

[Intel-gfx] [PATCH v3 1/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

gt; Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Wayne Boyer <wayne.bo...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/i915_re

[Intel-gfx] [PATCH v3 2/4] drm/i915/psr: Account for sink CRC raciness on some panels

Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> ---

[Intel-gfx] [PATCH v3 3/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

the use of the alternate mode if it's available and it was specifically requested. v2: Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> -

[Intel-gfx] [PATCH v3 0/4] Kernel PSR Fix-ups

) * Reduce amount of changes in the sink CRC patch (Jani) * Field-wise init of EDP_PSR_MAX_SLEEP_TIME (Rodrigo) * Minor commit message / cover letter tweaks v3: * Re-ordered patches to put reviewed patches first. * Rebased to current drm-tip Jim Bride (4): drm/i915/psr: Clean-up

[Intel-gfx] [PATCH v3 4/4] drm/i915/edp: Be less aggressive about changing link config on eDP

.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert DisplayPort fast link training feature") Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c |

Re: [Intel-gfx] [PATCH IGT v2 4/6] tests/kms_frontbuffer_tracking: Refactor to use IGT PSR library functions

asier to review and to make sure that we are not changing the behaviour. I'm testing a new series with the requested structural changes and review feedback to-date. I hope to send them out on Monday (testing takes a while.) Jim > also... > > On Fri, Jun 30, 2017 at 12:12 PM, Jim Bride &l

Re: [Intel-gfx] [PATCH IGT v2 2/6] lib: Add PSR utility functions to igt library.

On Fri, Jun 30, 2017 at 05:54:32PM -0300, Paulo Zanoni wrote: > Em Sex, 2017-06-30 às 12:12 -0700, Jim Bride escreveu: > > Factor out some code that was replicated in three test utilities into > > some new IGT library functions so that we are checking PSR status in > > a cons

Re: [Intel-gfx] [PATCH IGT v2 2/6] lib: Add PSR utility functions to igt library.

On Fri, Jun 30, 2017 at 01:11:52PM -0700, Rodrigo Vivi wrote: > On Fri, Jun 30, 2017 at 12:12 PM, Jim Bride <jim.br...@linux.intel.com> wrote: > > Factor out some code that was replicated in three test utilities into > > some new IGT library functions so that we ar

[Intel-gfx] [PATCH IGT v2 6/6] tests/kms_fbcon_fbt: Refactor to use IGT PSR library functions

v2: * Minor functional tweaks and bug fixes * Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_fbcon_fbt.c | 54 +

[Intel-gfx] [PATCH IGT v2 2/6] lib: Add PSR utility functions to igt library.

o.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- lib/Makefile.sources | 2 + lib/igt.h| 1 + lib/igt_psr.c| 235 +++ lib/igt_psr.h| 43 +

[Intel-gfx] [PATCH IGT v2 5/6] tests/kms_frontbuffer_tracking: Fix multidraw subtest

The multidraw subtest was not taking whether or not the GEM buffer had ever been in write-combining mode when checking for PSR state, so fix that. Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_frontbuffer_tracking.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[Intel-gfx] [PATCH IGT v2 3/6] tests/kms_psr_sink_crc: Refactor to use new PSR library primitives

v2: * Minor functional tweaks & bug fixes * Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_psr_sink_crc.c | 134 +++--

[Intel-gfx] [PATCH IGT v2 4/6] tests/kms_frontbuffer_tracking: Refactor to use IGT PSR library functions

v2: * Minor functional tweaks and bug fixes * Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_frontbuffer_tracking.c | 119 +++--

[Intel-gfx] [PATCH IGT v2 0/6] IGT PSR Fix-ups

*) BDW and SKL: * kms_psr_sink_crc (all) * kms_frontbuffer_tracking (subtests psr-1p* and fbcpsr-1p*) * kms_fbcon_fbt (all) Jim Bride (6): tests/kms_psr_sink_crc: Change assert_or_manual() to a macro lib: Add PSR utility functions to igt library. tests/kms_psr_sink_crc

[Intel-gfx] [PATCH IGT v2 1/6] tests/kms_psr_sink_crc: Change assert_or_manual() to a macro

Make assert_or_manual() a macro so that we get accurate line number information when this assertion fails. v2: Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_p

[Intel-gfx] [PATCH v2 4/4] drm/i915/psr: Account for sink CRC raciness on some panels

Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 40 1 fil

[Intel-gfx] [PATCH v2 2/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

gt; Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Wayne Boyer <wayne.bo...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 4 drivers/gpu/drm/i915/intel_psr.c | 21

[Intel-gfx] [PATCH v2 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP

.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert DisplayPort fast link training feature") Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c |

[Intel-gfx] [PATCH v2 1/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

the use of the alternate mode if it's available and it was specifically requested. v2: Rebase Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Cc: Jani Nikula <jani.nik...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> -

[Intel-gfx] [PATCH v2 0/4] Kernel PSR Fix-ups

) * Reduce amount of changes in the sink CRC patch (Jani) * Field-wise init of EDP_PSR_MAX_SLEEP_TIME (Rodrigo) * Minor commit message / cover letter tweaks Jim Bride (4): drm/i915/edp: Allow alternate fixed mode for eDP if available. drm/i915/psr: Clean-up intel_enable_source_psr1

Re: [Intel-gfx] [PATCH 11/67] drm/i915/cnl: add IS_CNL_REVID macro

On Thu, Apr 06, 2017 at 12:15:07PM -0700, Rodrigo Vivi wrote: > From: Paulo Zanoni <paulo.r.zan...@intel.com> > > We're going to use it in the next commits. > > Signed-off-by: Paulo Zanoni <paulo.r.zan...@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.v...@i

Re: [Intel-gfx] [PATCH 4/4] drm/i915/psr: Account for sink CRC raciness on some panels

On Mon, May 08, 2017 at 09:05:08PM +0300, Jani Nikula wrote: > On Mon, 08 May 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > On Mon, May 08, 2017 at 12:12:47PM +0300, Jani Nikula wrote: > >> On Sat, 06 May 2017, Jim Bride <jim.br...@linux.intel.com> wrote: &g

Re: [Intel-gfx] [PATCH 4/4] drm/i915/psr: Account for sink CRC raciness on some panels

On Mon, May 08, 2017 at 12:12:47PM +0300, Jani Nikula wrote: > On Sat, 06 May 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > According to the eDP spec, when the count field in TEST_SINK_MISC > > increments then the six bytes of sink CRC information in the DPC

Re: [Intel-gfx] [PATCH 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP

On Mon, May 08, 2017 at 11:41:25AM +0300, Jani Nikula wrote: > On Sat, 06 May 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > This set of changes has some history to them. There were several attempts > > to add what was called "fast link training" to i915,

Re: [Intel-gfx] [PATCH 1/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

On Mon, May 08, 2017 at 11:54:15AM +0300, Jani Nikula wrote: > On Sat, 06 May 2017, Jim Bride <jim.br...@linux.intel.com> wrote: > > Some fixed resolution panels actually support more than one mode, > > with the only thing different being the refresh rate. Having this > &g

[Intel-gfx] [PATCH IGT 4/5] tests/kms_frontbuffer_tracking: Refactor to use IGT PSR library functions

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_frontbuffer_tracking.c | 95 +--- 1 file changed, 10 insertions(+), 85 deletions(-)

[Intel-gfx] [PATCH IGT 5/5] tests/kms_fbcon_fbt: Refactor to use IGT PSR library functions

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_fbcon_fbt.c| 56 tests/kms_psr_sink_crc.c | 36 ++

[Intel-gfx] [PATCH IGT 1/5] tests/kms_psr_sink_crc: Change assert_or_manual() to a macro

Make assert_or_manual() a macro so that we get accurate line number information when this assertion fails. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_psr_sink_crc.c

[Intel-gfx] [PATCH IGT 3/5] tests/kms_psr_sink_crc: Refactor to use new PSR library primitives

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_psr_sink_crc.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/tests/km

[Intel-gfx] [PATCH IGT 0/5] PSR IGT Test Fix-ups

psr* and fbcpsr*) * kms_fbcon_fbt (all) Jim Bride (5): tests/kms_psr_sink_crc: Change assert_or_manual() to a macro lib: Add PSR utility functions to igt library. tests/kms_psr_sink_crc: Refactor to use new PSR library primitives tests/kms_frontbuffer_tracking: Refactor to use IGT

[Intel-gfx] [PATCH IGT 2/5] lib: Add PSR utility functions to igt library.

Factor out some code that was replicated in three test utilities into some new IGT library functions so that we are checking PSR status in a consistent fashion across all of our PSR tests. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed

[Intel-gfx] [PATCH 4/4] drm/i915/psr: Account for sink CRC raciness on some panels

a time before trying to read. We still see some occasional failures, but reading the sink CRC is much more reliable, particularly on SKL and KBL, with these changes than without. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by:

[Intel-gfx] [PATCH 2/4] drm/i915/psr: Clean-up intel_enable_source_psr1()

Zanoni <paulo.r.zan...@intel.com> Cc: Wayne Boyer <wayne.bo...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 4 drivers/gpu/drm/i915/intel_psr.c | 21 +++-- 2 files changed, 23 insertions(+), 2 deletions(

[Intel-gfx] [PATCH 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP

Mika Kahola <mika.kah...@intel.com> Fixes: 34511dce4 ("drm/i915: Revert DisplayPort fast link training feature") Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 4 +++- drivers/gpu/drm/i915/intel_dp_link_training.c | 11 +

[Intel-gfx] [PATCH 1/4] drm/i915/edp: Allow alternate fixed mode for eDP if available.

the use of the alternate mode if it's available and it was specifically requested. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 0/4] Kernel PSR Fix-ups

on the link state being the same at PSR exit as it was at PSR entry. The fourth change greatly increases the reliability of reading the sink CRC generated by the eDP panel. Jim Bride (4): drm/i915/edp: Allow alternate fixed mode for eDP if available. drm/i915/psr: Clean-up

Re: [Intel-gfx] [PATCH] drm/i915/psr: Clean-up intel_enable_source_psr1()

On Mon, Apr 03, 2017 at 05:42:39PM +, Vivi, Rodrigo wrote: > On Mon, 2017-04-03 at 10:07 -0700, Jim Bride wrote: > > On SKL+ there is a bit in SRD_CTL that software is not supposed to > > modify, but we currently clobber that bit when we enable PSR. In > > order

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Read link status more times when EQ not done

On Fri, Mar 31, 2017 at 04:25:31PM -0700, Rodrigo Vivi wrote: > On Mon, Mar 13, 2017 at 1:12 AM, Lee, Shawn C wrote: > > From: "Lee, Shawn C" > > > > Display driver read DPCD register 0x202, 0x203 and 0x204 to identify > > eDP sink status.If PSR exit

[Intel-gfx] [PATCH] drm/i915/psr: Clean-up intel_enable_source_psr1()

the register back out. Additionally, go ahead and explicitly disable single-frame update since we aren't currently supporting it. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Wayne Boyer <wayne.bo...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- drivers/gpu/d

[Intel-gfx] [PATCH I-G-T 3/4] tests/kms_frontbuffer_tracking: Refactor to use IGT PSR library functions

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_frontbuffer_tracking.c | 47 1 file changed, 9 insertions(+), 38 deletions(-)

[Intel-gfx] [PATCH I-G-T 1/4] lib: Add PSR utility functions to igt library.

Factor out some code that was replicated in three test utilities into some new IGT library functions so that we are checking PSR status in a consistent fashion across all of our PSR tests. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed

[Intel-gfx] [PATCH I-G-T 2/4] tests/kms_psr_sink_crc: Refactor to use new PSR library primitives

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_psr_sink_crc.c | 53 ++-- 1 file changed, 11 insertions(+), 42 deletions(-) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_ps

[Intel-gfx] [PATCH I-G-T 4/4] tests/kms_fbcon_fbt: Refactor to use IGT PSR library functions

Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> --- tests/kms_fbcon_fbt.c | 47 +++ 1 file changed, 11 insertions(+), 36 deletions(-)

Re: [Intel-gfx] [PATCH 07/10] drm/i915/psr: set PSR_MASK bits for deep sleep

_ENTRY is set 1 , if not set, > flickering is observed on psr2 panel. > > v2: (Ilia Mirkin) > - Remove duplicate bit definition 25:27 > > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Signed-off-by: Vathsala Nagaraju <vath

Re: [Intel-gfx] [PATCH 05/10] drm/i915/psr: enable ALPM for psr2

tel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Signed-off-by: vathsala nagaraju <vathsala.nagar...@intel.com> > Signed-off-by: Patil Deepti <deepti.pa...@intel.com> Reviewed-by: Jim Bride <jim.br...@linux.intel.com> > --- > drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 03/10] drm/i915/psr: fix blank screen issue for psr2

, > as suggested by rodrigo and jim. > > v2: (Vivi Rodrigo) > - Rename hsw_enable_source_psr* to intel_enable_source_psr* > > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Signed-off-by: Vathsala Nagaraju <vat

Re: [Intel-gfx] [PATCH 02/10] drm/i915/psr: program vsc header for psr2

_SU_Y_COORDINATE_REQUIRED > - Change DPRX_FEATURE_ENUMERATION_LIST to DP_DPRX_* > - Change VSC_SDP_EXT_FOR_COLORIMETRY_SUPPORTED to DP_VSC_* > > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Signed-off-by: Vathsala Nagaraju <vathsala.naga

Re: [Intel-gfx] [PATCH v2 i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

On Wed, Dec 07, 2016 at 02:04:52PM -0800, Manasi Navare wrote: > This is the userspace component of the Displayport Compliance > testing software required for compliance testing of the I915 > Display Port driver. This must be running in order to successfully > complete Display Port compliance

Re: [Intel-gfx] [PATCH] drm/i915/psr: fix blank screen issue for psr2

sr2_ctl instead of srd_status and srd_ctl for > psr2 scenario. > > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Signed-off-by: vathsala nagaraju <vathsala.nagar...@intel.com> Reviewed-by: Jim Bride <jim.br...@linux.intel.c

Re: [Intel-gfx] [PATCH] drm/i915/psr: report psr2 hw enabled from psr2_ctl

igo Vivi <rodrigo.v...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Signed-off-by: vathsala nagaraju <vathsala.nagar...@intel.com> Reviewed-by: Jim Bride <jim.br...@linux.intel.com> > --- > drivers/gpu/drm/i915/i915_debugfs.c | 9 ++--- > 1

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Link Rate fallback on Link training failure

On Tue, Oct 25, 2016 at 03:17:47PM +0300, Jani Nikula wrote: > On Sat, 22 Oct 2016, Manasi Navare wrote: > > If link training at a link rate optimal for a particular > > mode fails during modeset's atomic commit phase, then we > > let the modeset complete and then

Re: [Intel-gfx] [PATCH v2 4/4] drm: Add and handle new aspect ratios in DRM layer

On Mon, Oct 17, 2016 at 08:02:49AM +0200, Daniel Vetter wrote: > On Thu, Oct 13, 2016 at 10:28:14AM -0700, Jim Bride wrote: > > On Tue, Aug 09, 2016 at 08:25:50PM +0530, Shashank Sharma wrote: > > > HDMI 2.0/CEA-861-F introduces two new aspect ratios: > > &

  1   2   >