Re: [Intel-gfx] [PATCH v4 0/9] drm/i915: Implement HDCP

Hi Sean, On 07-12-2017 00:00, Sean Paul wrote: > Welcome to version 4 of the patchset. I think we're nearing the finish line > (hopefully) now. This set addresses the review feedback from v3. I applied > some > R-b's from v3 review, and converted others to Cc since other changes were made > to

Re: [Intel-gfx] [PATCH 04/10] drm/uapi: Deprecate DRM_MODE_FLAG_BCAST

ol and kms uapi. > > Since kms fbdev emulation never uses the corresponding fbdev flag > there should be no sane way for this to come back into kms via > userspace either. > > Cc: Jose Abreu <jose.ab...@synopsys.com> > Cc: Adam Jackson <a...@redhat.com> > Cc: Keit

Re: [Intel-gfx] [PATCH 03/10] drm/uapi: Deprecate DRM_MODE_FLAG_PIXMUX

to do the the controller<->ramdac > interface with some ancient S3 graphics adapters. Why someone though > it would be a good idea to expose it directly to users I don't know. > And later on it got copied into the randr protocol and kms uapi. > > Cc: Jose Abreu <jose.ab...@s

Re: [Intel-gfx] [PATCH v2 08/10] drm/uapi: Deprecate nonsense kms mode types

space code that would depend > on these. > > v2: Recommend DRIVER instead of BUILTIN (ajax) > > Cc: Jose Abreu <jose.ab...@synopsys.com> > Cc: Adam Jackson <a...@redhat.com> > Cc: Keith Packard <kei...@keithp.com> > Signed-off-by: Ville Syrjälä <ville.syr

Re: [Intel-gfx] [PATCH v2 02/10] drm/uapi: Validate the mode flags/type

Hi Ville, On 15-11-2017 15:49, Ville Syrjala wrote: > > +#define DRM_MODE_FLAG_ALL (DRM_MODE_FLAG_PHSYNC | \ > + DRM_MODE_FLAG_NHSYNC | \ > + DRM_MODE_FLAG_PVSYNC | \ > +

Re: [Intel-gfx] [PATCH 08/10] video/hdmi: Reject illegal picture aspect ratios

ha...@intel.com> > Cc: "Lin, Jia" <lin.a@intel.com> > Cc: Akashdeep Sharma <akashdeep.sha...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Cc: Jose Abreu <jose.ab...@synopsys.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.c

Re: [Intel-gfx] [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

On 13-11-2017 17:04, Ville Syrjala wrote: > From: Ville Syrjälä > > If the user mode would specify an aspect ratio other than 4:3 or 16:9 > we now silently ignore it. Maybe a better apporoach is to return an > error? Let's try that. > > Also we must be careful

Re: [Intel-gfx] [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

Hi Ville, On 13-11-2017 17:04, Ville Syrjala wrote: > > + if (to_match->picture_aspect_ratio) > + match_flags |= DRM_MODE_MATCH_ASPECT_RATIO; > + > Maybe "if (to_match->picture_aspect_ratio != HDMI_PICTURE_ASPECT_NONE && to_match->picture_aspect_ratio !=

Re: [Intel-gfx] [PATCH 06/11] drm: create hdmi output property

ou parsing them (because in patch 07/11 you reject these properties)? Also, you need to make sure that source and sink supports the color space. Best regards, Jose Miguel Abreu > > Cc: Ville Syrjala <ville.syrj...@linux.intel.com> > Cc: Jose Abreu <joab...@synopsys.com>

Re: [Intel-gfx] [PATCH 07/11] drm: set output colorspace in AVI infoframe

B, this patch adds a function in DRM layer, to > add the output colorspace information in the AVI infoframes. > > Cc: Ville Syrjala <ville.syrj...@linux.intel.com> > Cc: Jose Abreu <jose.ab...@synopsys.com> > Signed-off-by: Shashank Sharma <shashank.sha...@int

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

Hi Ville, On 23-03-2017 18:14, Ville Syrjälä wrote: > On Thu, Mar 23, 2017 at 05:53:34PM +0000, Jose Abreu wrote: >> Hi Ville, >> >> >> On 23-03-2017 17:42, Ville Syrjälä wrote: >>> On Thu, Mar 23, 2017 at 05:11:44PM +, Jose Abreu wrote: >>>>

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

Hi Ville, On 23-03-2017 17:42, Ville Syrjälä wrote: > On Thu, Mar 23, 2017 at 05:11:44PM +0000, Jose Abreu wrote: >> Hi Shashank, >> >> >> On 23-03-2017 16:43, Sharma, Shashank wrote: >>> Regards >>> >>> Shashank >>> &

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

Hi Shashank, On 23-03-2017 16:43, Sharma, Shashank wrote: > Regards > > Shashank > > > On 3/23/2017 6:33 PM, Jose Abreu wrote: >> Hi Shashank, >> >> >> On 23-03-2017 16:08, Sharma, Shashank wrote: >>> Regards >>> >>> Shash

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

Hi Shashank, On 23-03-2017 16:08, Sharma, Shashank wrote: > Regards > > Shashank > > > On 3/23/2017 5:57 PM, Jose Abreu wrote: >> Hi Ville, >> >> >> On 23-03-2017 15:45, Ville Syrjälä wrote: >>> On Thu, Mar 23, 2017 at 03:28:29PM +, Jose Abr

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

Hi Ville, On 23-03-2017 15:45, Ville Syrjälä wrote: > On Thu, Mar 23, 2017 at 03:28:29PM +0000, Jose Abreu wrote: >> Hi Shashank, >> >> >> On 23-03-2017 15:14, Shashank Sharma wrote: >>> HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

Hi Ville, On 23-03-2017 15:36, Ville Syrjälä wrote: > On Thu, Mar 23, 2017 at 05:14:19PM +0200, Shashank Sharma wrote: >> HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). >> For any other mode, the VIC filed in AVI infoframes should be 0. >> HDMI 2.0 sinks, support

Re: [Intel-gfx] [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

o are callers of this function > drm_hdmi_avi_infoframe_from_display_mode but to make sure there is > no change in current behavior, is_hdmi2 is kept as false. > > In case of I915 driver, this patch checks the connector->display_info > to check if the connected display is HDMI 2.0. > > Cc: Ville Syrjala <

Re: [Intel-gfx] [PATCH v6 4/6] drm/edid: detect SCDC support in HF-VSDB

1/40 ratios > - Remove leftovers from old patchset > > Signed-off-by: Shashank Sharma <shashank.sha...@intel.com> > Reviewed-by: Thierry Reding <tred...@nvidia.com> Maybe drm_scdc_set_scrambling() and drm_scdc_set_high_tmds_clock_ratio() should return int error code instead o

Re: [Intel-gfx] [PATCH v6 3/6] drm/edid: detect SCDC support in HF-VSDB

ing function drm_parse_hf_vsdb so that all >of HF-VSDB parsing can be kept in same function, in incremental >patches. > > V3: Rebase. > V4: Rebase. > V5: Rebase. > V6: Rebase. > > Signed-off-by: Shashank Sharma <shashank.sha...@intel.com> > Reviewed-by: Th

Re: [Intel-gfx] [PATCH v2 1/6] drm: Add SCDC helpers

Hi Shashank, On 08-02-2017 12:59, Sharma, Shashank wrote: > Regards > > Shashank > > > On 2/8/2017 4:57 PM, Jose Abreu wrote: >> Hi Shashank, >> >> >> >> On 07-02-2017 16:09, Sharma, Shashank wrote: >>> Thanks for the review Jose,

Re: [Intel-gfx] [PATCH v2 4/6] drm: scrambling support in drm layer

Hi Jani, On 07-02-2017 15:09, Jani Nikula wrote: > On Tue, 07 Feb 2017, Jose Abreu <jose.ab...@synopsys.com> wrote: >> Hi Jani, >> >> >> On 07-02-2017 13:35, Jani Nikula wrote: >>> On Tue, 07 Feb 2017, Jose Abreu <jose.ab...@synopsys.com> wro

Re: [Intel-gfx] [PATCH v2 4/6] drm: scrambling support in drm layer

Hi Shashank, On 07-02-2017 16:19, Sharma, Shashank wrote: > Regards > > Shashank > > > On 2/7/2017 4:44 PM, Jose Abreu wrote: >> Hi Shashank, >> >> >> >> On 06-02-2017 13:59, Shashank Sharma wrote: >>> HDMI 2.0 spec mandates scrambli

Re: [Intel-gfx] [PATCH v2 3/6] drm/edid: detect SCDC support in HF-VSDB

Hi, On 07-02-2017 16:36, Thierry Reding wrote: > On Tue, Feb 07, 2017 at 09:43:15PM +0530, Sharma, Shashank wrote: >> Regards >> >> Shashank >> >> >> On 2/7/2017 4:31 PM, Jose Abreu wrote: >>> Hi Shashank, >>> >>> >&g

Re: [Intel-gfx] [PATCH v2 1/6] drm: Add SCDC helpers

Hi Shashank, On 07-02-2017 16:09, Sharma, Shashank wrote: > Thanks for the review Jose, my comments inline. > > > Regards > > Shashank > > > On 2/7/2017 4:24 PM, Jose Abreu wrote: >> Hi Shashank, >> >> >> Sorry for the late review. >> &

Re: [Intel-gfx] [PATCH v2 4/6] drm: scrambling support in drm layer

Hi Jani, On 07-02-2017 13:35, Jani Nikula wrote: > On Tue, 07 Feb 2017, Jose Abreu <jose.ab...@synopsys.com> wrote: >>> +bool drm_scdc_check_scrambling_status(struct i2c_adapter *adapter) >>> +{ >>> + u8 status; >>> + int ret; >>> + >&

Re: [Intel-gfx] [PATCH v2 4/6] drm: scrambling support in drm layer

Hi Shashank, On 06-02-2017 13:59, Shashank Sharma wrote: > HDMI 2.0 spec mandates scrambling for modes with pixel clock higher > than 340 MHz. This patch adds few new functions in drm layer for > core drivers to enable/disable scrambling. > > This patch adds: > - A function to detect scrambling

Re: [Intel-gfx] [PATCH v2 2/6] drm/edid: check for HF-VSDB block

ed...@nvidia.com> > Signed-off-by: Shashank Sharma <shashank.sha...@intel.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/drm_edid.c | 15 +++ > include/linux/hdmi.h | 1 + > 2 file

Re: [Intel-gfx] [PATCH v2 1/6] drm: Add SCDC helpers

Hi Shashank, Sorry for the late review. On 06-02-2017 13:59, Shashank Sharma wrote: > From: Thierry Reding > > SCDC is a mechanism defined in the HDMI 2.0 specification that allows > the source and sink devices to communicate. > > This commit introduces helpers to access

Re: [Intel-gfx] [PATCH v2 3/6] drm/edid: detect SCDC support in HF-VSDB

Hi Shashank, On 06-02-2017 13:59, Shashank Sharma wrote: > This patch does following: > - Adds a new structure (drm_hdmi_info) in drm_display_info. > This structure will be used to save and indicate if sink > supports advanced HDMI 2.0 features > - Adds another structure drm_scdc within

Re: [Intel-gfx] [PATCH] drm: clean cached display info

s-qhY=wGqvHYK00VvbUVGun4-ZhK6KZ4Ht_lHwPGfC6ajlzxE=7YpJD-fwUixHNz9SNn2B1ijuL5mEVeEUmolbf3NqWcs= > > (still under review) and sending as individual patch. > > Cc: Jose Abreu <joab...@synopsys.com> > Cc: Daniel Vetter <dan...@ffwll.ch> > > Suggested-by: Jose Abreu <joab...@

Re: [Intel-gfx] [PATCH v3 3/3] drm: clean cached display info

Hi Shashank, On 29-12-2016 05:53, Sharma, Shashank wrote: > Regards > > Shashank > > > On 12/27/2016 3:07 PM, Daniel Vetter wrote: >> On Thu, Dec 22, 2016 at 10:21:25AM +, Jose Abreu wrote: >>> Hi Shashank, >>> >>> >>> On 21-12-201

Re: [Intel-gfx] [PATCH v3 3/3] drm: clean cached display info

te, avoiding any errors due to invalid cached data. > > Cc: Jose Abreu <joab...@synopsys.com> > > Suggested-by: Jose Abreu <joab...@synopsys.com> > Signed-off-by: Shashank Sharma <shashank.sha...@intel.com> > --- > drivers/gpu/drm/drm_probe_helper.c | 20 ++

Re: [Intel-gfx] [PATCH v3 2/3] drm: parse hf-vsdb

- Fix the bit nos for YUV420 deep color macros > - write HDMI_IEEE_OUI_HFVSDB value in lower case > > Cc: Thierry Reding <tred...@nvidia.com> > Cc: Daniel Vetter <daniel.vet...@intel.com> > Cc: Jose Abreu <joab...@synopsys.com> > Signed-off-by: Shashank

Re: [Intel-gfx] [PATCH v3 1/3] drm: Create new structure for HDMI info

Hi Shashank, On 21-12-2016 15:29, Shashank Sharma wrote: [snip] > + > + /** > + * @edid_yuv420_dc_modes: bpc for deep color yuv420 encoding. > + * various sinks can support 10/12/16 bit per channel deep > + * color encoding. edid_yuv420_dc_modes = 0 means sink doesn't > +

Re: [Intel-gfx] [PATCH v2 1/2] drm: Create new structure for HDMI info

Hi Shashank, On 21-12-2016 03:49, Sharma, Shashank wrote: > Thanks for the review Jose. > > My comments, inline. > > Regards > Shashank > On 12/20/2016 7:49 PM, Jose Abreu wrote: >> Hi Shashank, >> >> >> On 20-12-2016 13:47, Shashank Sharma

Re: [Intel-gfx] [PATCH v2 2/2] drm: parse hf-vsdb

ros of 36 and 30-bit depths > - Added a sub-class for HDMI related information within drm_display_info > (Thierry, Daniel) and populated it with HF-VSDB specific info. > > Cc: Thierry Reding <tred...@nvidia.com> > Cc: Daniel Vetter <daniel.vet...@intel.com> > C

Re: [Intel-gfx] [PATCH v2 1/2] drm: Create new structure for HDMI info

rrect values in this structure. > We are adding parsing of HF-VSDB In the next patch. > > Cc: Thierry Reding <tred...@nvidia.com> > Cc: Daniel Vetter <daniel.vet...@intel.com> > Cc: Jose Abreu <joab...@synopsys.com> > Suggested-by: Thierry Reding <thierry.red...@gmail.

Re: [Intel-gfx] [PATCH] drm: Complete CEA modedb(VIC 1-107)

;, DRM_MODE_TYPE_DRIVER, 297000, > +3840, 4016, 4104, 4400, 0, > +2160, 2168, 2178, 2250, 0, > +DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC), > + .vrefresh = 25, .picture_aspect_ratio = HDMI_PICTURE_ASPECT_64_27}, 4016 should be instead 4896. 4104 shoul

Re: [Intel-gfx] [PATCH v3 0/4]: Picture aspect ratio support in DRM layer

Hi Shashank, On 17-10-2016 12:32, Shashank Sharma wrote: > This patch series adds 4 patches. > - The first two patches add aspect ratio support in DRM layes > - Next two patches add new aspect ratios defined in CEA-861-F > supported for HDMI 2.0 4k modes. > > Adding aspect ratio support in DRM

Re: [Intel-gfx] [PATCH v2 0/4] Picture aspect ratio support in DRM layer

> drm: add picture aspect ratio flags > drm: Add aspect ratio parsing in DRM layer > video: Add new aspect ratios for HDMI 2.0 > drm: Add and handle new aspect ratios in DRM layer I am using these patches to run HDMI 2.0 compliance so: Tested-by: Jose Abreu <joab...@synops

Re: [Intel-gfx] [PATCH 1/4] drm: add picture aspect ratio flags

Hi Sharma, On 05-08-2016 04:37, Sharma, Shashank wrote: > Regards > > Shashank > > > On 8/4/2016 9:39 PM, Daniel Vetter wrote: >> On Thu, Aug 04, 2016 at 03:31:45PM +0100, Emil Velikov wrote: >>> On 4 August 2016 at 14:15, Sharma, Shashank >>> wrote: On 8/4/2016

Re: [Intel-gfx] [PATCH 0/4]: Picture aspect ratio support in DRM layer

On 04-08-2016 15:29, Sharma, Shashank wrote: > Regards > > Shashank > > > On 8/4/2016 7:46 PM, Jose Abreu wrote: >> Hi Sharma, >> >> >> On 03-08-2016 16:47, Sharma, Shashank wrote: >>> Hello Joes, >>>> I've also seen this before and

Re: [Intel-gfx] [PATCH 0/4]: Picture aspect ratio support in DRM layer

modeset back to libdrm. Do you mean Xserver, the X driver that I am using (which is modesetting), the xrandr or all of them? I guess that if they don't touch the flags field and return the mode exactly the same as it was probed to DRM then it will work as expected. Best regards, Jose Miguel Abre

Re: [Intel-gfx] [PATCH 0/4]: Picture aspect ratio support in DRM layer

Hi, On 03-08-2016 12:48, Daniel Vetter wrote: > On Wed, Aug 03, 2016 at 04:26:24PM +0530, Shashank Sharma wrote: >> This patch series adds 4 patches. >> - The first two patches add aspect ratio support in DRM layes >> - Next two patches add new aspect ratios defined in CEA-861-F >> supported