[Intel-gfx] [PATCH v3] drm/i915: Disable some extra clang warnings

e code has been fixed. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v3: - don't disable -Wunneeded-internal-declaration , the only occurrence can be fixed in the code - removed 'Fixes' tag, since backporting is not necessary drivers/gpu/drm/i915/Makefile | 4 1

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

On Mon, Apr 30, 2018 at 10:01:50PM +0100, Chris Wilson wrote: > Quoting Matthias Kaehlcke (2018-04-30 21:51:45) > > On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > > > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > > > On Mon, Mar 19, 2018

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > > > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") enabled extra warnings for i915 to spot possible > bugs in new code, and then disabled a subset of these warnings to keep

[Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

e code has been fixed. Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full") Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v2: - rebased on drm-tip - added comment indicating that disabled warnings are clang warnings drivers

[Intel-gfx] [PATCH] drm/i915: Disable some extra clang warnings

e code has been fixed. Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full") Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/i915/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/Makef

[Intel-gfx] [PATCH] drm/i915: Mark wait_for_engine() as maybe_unused

lni...@gmail.com> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/i915/i915_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 969bac8404f1..52d0b7d0082b 100644 --- a/drivers/

Re: [Intel-gfx] [PATCH] drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting()

On Thu, Jul 20, 2017 at 1:27 AM, Daniel Vetter <dan...@ffwll.ch> wrote: > On Wed, Jul 19, 2017 at 10:39:28AM -0700, Matthias Kaehlcke wrote: >> Commit a21960339c8c ("drm/i915: Consistently use enum pipe for PCH >> transcoders") misses some pieces, due to a p

[Intel-gfx] [PATCH] drm/i915: Pass enum pipe to intel_set_pch_fifo_underrun_reporting()

Commit a21960339c8c ("drm/i915: Consistently use enum pipe for PCH transcoders") misses some pieces, due to a problem with the patch format, this patch adds the remaining bits. Fixes: a21960339c8c ("drm/i915: Consistently use enum pipe for PCH transcoders") Signed-off-by:

Re: [Intel-gfx] [PATCH v2] drm/i915: Consistently use enum pipe for PCH transcoders

El Wed, Jul 19, 2017 at 08:30:36AM +0200 Daniel Vetter ha dit: > On Tue, Jul 18, 2017 at 01:48:53PM -0700, Matthias Kaehlcke wrote: > > Hi Daniel, > > > > El Tue, Jul 18, 2017 at 08:39:50AM +0200 Daniel Vetter ha dit: > > > > > On Mon, Jul 17, 2017 at 11:14

Re: [Intel-gfx] [PATCH v2] drm/i915: Consistently use enum pipe for PCH transcoders

Hi Daniel, El Tue, Jul 18, 2017 at 08:39:50AM +0200 Daniel Vetter ha dit: > On Mon, Jul 17, 2017 at 11:14:03AM -0700, Matthias Kaehlcke wrote: > > The current code uses in some instances enum transcoder for PCH > > transcoders and enum pipe in others. This is error prone and c

[Intel-gfx] [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V

-internal-declaration] static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.") Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Reviewed-by: Manasi Navare <manasi.d.nav...@intel.com

[Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V

-internal-declaration] static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/i915/intel_ddi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/d

[Intel-gfx] [PATCH v2] drm/i915: Consistently use enum pipe for PCH transcoders

'enum transcoder' [-Wenum-conversion] intel_set_pch_fifo_underrun_reporting(dev_priv, PIPE_A, false); Consistently use the type enum pipe for PCH transcoders. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v2: - rebased on drm-intel/drm-intel-next-queued drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: Consistently use enum pipe for PCH transcoders

El Mon, Jul 17, 2017 at 11:07:01AM +0200 Daniel Vetter ha dit: > On Fri, Jul 14, 2017 at 06:04:03PM -0700, Matthias Kaehlcke wrote: > > The current code uses two different enum types for PCH transcoders and > > performs implicit conversions between the two types. This

[Intel-gfx] [PATCH] drm/i915: Consistently use enum pipe for PCH transcoders

' to different enumeration type 'enum transcoder' [-Wenum-conversion] intel_set_pch_fifo_underrun_reporting(dev_priv, PIPE_A, false); Consistently use the type enum pipe for PCH transcoders. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

om your side) there's > > suddenly mass panic and multiple escalations on all available > > channels, which feels like a rather decent overreaction and not a > > terrible constructive way to collaborate on the upstream codebase. > > I'm sorry - I'm not on th

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

Hi, El Fri, May 05, 2017 at 01:29:32PM -0700 Grant Grundler ha dit: > On Fri, May 5, 2017 at 1:08 PM, Ville Syrjälä > wrote: > ... > >> > I'm not convinced the patch is making things any better really. To > >> > fix this really properly, I think we'd need to

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit: > In several instances the driver passes an 'enum pipe' value to a > function expecting an 'enum transcoder' and viceversa. Since PIPE_x and > TRANSCODER_x have the same values this doesn't cause functional > pro

[Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

-by: Matthias Kaehlcke <m...@chromium.org> --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/i915/intel_dp.c | 6 -- drivers/gpu/drm/i915/intel_hdmi.c| 6 -- drivers/gpu/drm/i915/intel_sdvo.c| 6 -- 4 files changed, 14 insertions(+), 8 deletions(-) diff