Re: [Intel-gfx] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Paul Kocialkowski
6 +- > drivers/gpu/drm/tiny/repaper.c| 8 +- > drivers/gpu/drm/tiny/simpledrm.c | 2 +- > drivers/gpu/drm/tiny/st7586.c | 6 +- > drivers/gpu/drm/tiny/st7735r.c| 4 +- > drivers/gpu/drm/tve200/tve200_display.c

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-20 Thread Paul Kocialkowski
Le lundi 20 mai 2019 à 18:11 +0200, Daniel Vetter a écrit : > On Fri, May 17, 2019 at 01:08:24PM +0300, Pekka Paalanen wrote: > > On Thu, 16 May 2019 14:24:55 +0200 > > Daniel Vetter wrote: > > > > > On Thu, May 16, 2019 at 11:22:11AM +0300, Pekka Paalanen wrote: > > > > On Wed, 15 May 2019

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-15 Thread Paul Kocialkowski
Hi, On Tue, 2019-05-14 at 16:28 +0200, Daniel Vetter wrote: > On Tue, May 14, 2019 at 4:13 PM Paul Kocialkowski > wrote: > > Hi, > > > > On Tue, 2019-05-14 at 13:09 +0200, Daniel Vetter wrote: > > > On Mon, May 13, 2019 at 7:14 PM Paul Kocialkowski > > >

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-15 Thread Paul Kocialkowski
ed me as > > > an event is a device. Squashing together would make sense if the > > > uevent were just updating a device attribute list. Previously when we > > > had just a single kind of uevent, that would not have made a > > > difference, but if we gain differ

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Paul Kocialkowski
Hi, On Tue, 2019-05-14 at 13:09 +0200, Daniel Vetter wrote: > On Mon, May 13, 2019 at 7:14 PM Paul Kocialkowski > wrote: > > Hey, > > > > Le lundi 13 mai 2019 à 11:34 +0200, Daniel Vetter a écrit : > > > On Mon, May 13, 2019 at 11:02 AM Paul Koci

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Paul Kocialkowski
; On Mon, 13 May 2019 11:34:58 +0200 > > > > Daniel Vetter wrote: > > > > > > > > > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski > > > > > wrote: > > > > > > Hi, > > > > > > > > > > > >

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-13 Thread Paul Kocialkowski
Hey, Le lundi 13 mai 2019 à 11:34 +0200, Daniel Vetter a écrit : > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski > wrote: > > Hi, > > > > On Fri, 2019-05-10 at 16:54 +0200, Daniel Vetter wrote: > > > On Fri, May 10, 2019 at 2:12 PM Paul Koci

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-13 Thread Paul Kocialkowski
Hi, On Fri, 2019-05-10 at 16:54 +0200, Daniel Vetter wrote: > On Fri, May 10, 2019 at 2:12 PM Paul Kocialkowski > wrote: > > Hi, > > > > On Tue, 2019-05-07 at 21:57 +0530, Ramalingam C wrote: > > > DRM API for generating uevent for a status chan

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-10 Thread Paul Kocialkowski
> +struct drm_connector; > +struct drm_property; > > int drm_class_device_register(struct device *dev); > void drm_class_device_unregister(struct device *dev); > > void drm_sysfs_hotplug_event(struct drm_device *dev); > - > +void drm_sysfs_connector_status_event(struct drm_connector *connector, > + struct drm_property *property); > #endif -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 1/1] chamelium: Add work in progress test for HDMI audio integrity testing

2017-08-31 Thread Paul Kocialkowski
is currently work in progress and is not working. It is sent only for reference and should not be merged. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac| 9 +++-- lib/igt_chamelium.c | 18 -- lib/igt_chamelium.h | 6 +++- tests/Makefile.am

[Intel-gfx] [PATCH i-g-t 0/1] chamelium: Add work in progress test for HDMI audio

2017-08-31 Thread Paul Kocialkowski
This patch contains a work in progress test for HDMI audio integrity testing. It is currently not working and should not be merged. It is sent as-is for reference, in hope that work in this area will be resumed later on. It is the latest version at the time of my final summer internship day at

Re: [Intel-gfx] [PATCH i-g-t v2] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
On Thu, 2017-08-31 at 11:02 +0300, Paul Kocialkowski wrote: > This introduces a selftest for the audio library. > > It consists of generating a signal from a list of frequencies and > ensuring that the integrity checking function does detect these > frequencies (and only th

[Intel-gfx] [PATCH i-g-t v2] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
This introduces a selftest for the audio library. It consists of generating a signal from a list of frequencies and ensuring that the integrity checking function does detect these frequencies (and only these frequencies). Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.

Re: [Intel-gfx] [PATCH i-g-t] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
Hi, On Wed, 2017-08-30 at 14:53 -0400, Lyude Paul wrote: > On Wed, 2017-08-30 at 17:45 +0300, Paul Kocialkowski wrote: > > This introduces a selftest for the audio library. > > > > It consists of generating a signal from a list of frequencies and > > ensuring that the

Re: [Intel-gfx] [PATCH i-g-t] lib/tests: Add audio selftest

2017-08-31 Thread Paul Kocialkowski
On Wed, 2017-08-30 at 16:44 +0100, Chris Wilson wrote: > Quoting Paul Kocialkowski (2017-08-30 15:45:14) > > This introduces a selftest for the audio library. > > > > It consists of generating a signal from a list of frequencies and > > ensuring that the integrity ch

[Intel-gfx] [PATCH i-g-t] lib/tests: Add audio selftest

2017-08-30 Thread Paul Kocialkowski
This introduces a selftest for the audio library. It consists of generating a signal from a list of frequencies and ensuring that the integrity checking function does detect these frequencies (and only these frequencies). Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.

[Intel-gfx] [PATCH i-g-t] lib/igt_aux: Allow sysfs open to fail when setting suspend/resume delay

2017-08-30 Thread Paul Kocialkowski
with the SuspendResumeDelay parameter set in igtrc configuration. Sysfs access would otherwise cause it to fail. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_aux.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git

Re: [Intel-gfx] [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input

2017-08-30 Thread Paul Kocialkowski
On Tue, 2017-08-29 at 15:08 +0300, Paul Kocialkowski wrote: > On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote: > > Before capturing video, the Chamelium will always wait for the video > > input to be stable (and perform the FSM if it was not). This means > > that

[Intel-gfx] [PATCH i-g-t] tests/audio: Add suspend and hibernate tests for HDMI signal integrity

2017-08-29 Thread Paul Kocialkowski
This introduces tests for HDMI signal integrity after suspend and hibernate. They simply test that signal integrity is ensured before and after suspend or hibernate. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/audio.c | 19 +++ 1 file c

[Intel-gfx] [PATCH i-g-t] docs/chamelium: Explain that the Chamelium should only target one DUT

2017-08-29 Thread Paul Kocialkowski
This adds an explanation about why the Chamelium should only be connected to one target device at once to the in-tree documentation. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- docs/chamelium.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Open DRM driver without master for hpd storm exit

2017-08-29 Thread Paul Kocialkowski
for debugfs access purposes, open the DRM node without requesting master to fix the issue. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index ee

Re: [Intel-gfx] [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input

2017-08-29 Thread Paul Kocialkowski
On Mon, 2017-08-28 at 17:55 +0300, Paul Kocialkowski wrote: > Before capturing video, the Chamelium will always wait for the video > input to be stable (and perform the FSM if it was not). This means > that > there is no need to explicitly do it beforehand. > > When the receiver

[Intel-gfx] [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input

2017-08-28 Thread Paul Kocialkowski
. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/chamelium.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/chamelium.c b/tests/chamelium.c index 484bb537..e3d81357 100644 --- a/tests/chamelium.c +++ b/tests/chamelium.c @@ -474,9 +474,6 @@ enable_

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_chamelium: Remove any special handling for the connector FSM

2017-08-28 Thread Paul Kocialkowski
On Fri, 2017-08-04 at 17:10 +0300, Paul Kocialkowski wrote: > No specific treatment should be required for handling the connector > FSM, > since the chamelium-side daemon will automatically send an HPD event > to > reset the source. > > The event is sufficient

[Intel-gfx] [PATCH i-g-t v2 0/3] Documentation updates, with chamelium and audio

2017-08-28 Thread Paul Kocialkowski
Changes since v1: * Added a note about network timeouts when the Chamelium board is disconnected ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t v2 1/3] lib/igt_core: Use HTML character for documentation comment in example

2017-08-28 Thread Paul Kocialkowski
The gtkdoc output for the example configuration given in the file confuses gtkdoc because of the use of # for comments, that is interpreted as a headline (although it is an example block). This uses the HTML character instead to ensure the rendering is correct. Signed-off-by: Paul Kocialkowski

[Intel-gfx] [PATCH i-g-t v2 2/3] docs: Add user and developer documentation about Chamelium support

2017-08-28 Thread Paul Kocialkowski
reference. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- docs/chamelium.txt | 153 + 1 file changed, 153 insertions(+) create mode 100644 docs/chamelium.txt diff --git a/docs/chamelium.txt b/docs/chamelium.txt ne

[Intel-gfx] [PATCH i-g-t v2 3/3] docs: Add user documentation about audio support

2017-08-28 Thread Paul Kocialkowski
This introduces plain-text documentation about the audio test, aimed at users who wish to setup and run the audio tests. Given the contents of this documentation, it felt more relevant to make it part of the tree instead of the API reference. Signed-off-by: Paul Kocialkowski <paul.kocial

Re: [Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list

2017-08-28 Thread Paul Kocialkowski
int whether support for it is enabled or not in the summary, by the way. Cheers, Paul > On Wed, Aug 23, 2017 at 8:21 AM, Paul Kocialkowski > <paul.kocialkow...@linux.intel.com> wrote: > > This adds the fastest chamelium tests to the Intel CI fast-feedback > > list, with th

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_core: Use HTML character for documentation comment in example

2017-08-25 Thread Paul Kocialkowski
The gtkdoc output for the example configuration given in the file confuses gtkdoc because of the use of # for comments, that is interpreted as a headline (although it is an example block). This uses the HTML character instead to ensure the rendering is correct. Signed-off-by: Paul Kocialkowski

[Intel-gfx] [PATCH i-g-t 2/3] docs: Add user and developer documentation about Chamelium support

2017-08-25 Thread Paul Kocialkowski
reference. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- docs/chamelium.txt | 146 + 1 file changed, 146 insertions(+) create mode 100644 docs/chamelium.txt diff --git a/docs/chamelium.txt b/docs/chamelium.txt ne

[Intel-gfx] [PATCH i-g-t 3/3] docs: Add user documentation about audio support

2017-08-25 Thread Paul Kocialkowski
This introduces plain-text documentation about the audio test, aimed at users who wish to setup and run the audio tests. Given the contents of this documentation, it felt more relevant to make it part of the tree instead of the API reference. Signed-off-by: Paul Kocialkowski <paul.kocial

Re: [Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list

2017-08-25 Thread Paul Kocialkowski
On Wed, 2017-08-23 at 18:21 +0300, Paul Kocialkowski wrote: > This adds the fastest chamelium tests to the Intel CI fast-feedback > list, with the objective of running in under a minute. For the record, here are average run times for the added tests: dp-hpd-fast: 2.397s dp-edid-read: 1.7

[Intel-gfx] [PATCH i-g-t] tests: chamelium: Eliminate reset when preparing output

2017-08-25 Thread Paul Kocialkowski
the chamelium was still reset by the call to prepare_output. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/chamelium.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/chamelium.c b/tests/chamelium.c index 00ae484b..484bb537

[Intel-gfx] [PATCH i-g-t 2/3] tests/chamelium: Introduce fast CRC tests, with a single mode

2017-08-23 Thread Paul Kocialkowski
This introduces a fast fashion of testing display CRC, that only tests a single mode (the highest resolution). It drastically reduces the run time of the test, which is necessary for the fast-feedback test list. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> ---

[Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list

2017-08-23 Thread Paul Kocialkowski
This adds the fastest chamelium tests to the Intel CI fast-feedback list, with the objective of running in under a minute. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/intel-ci/fast-feedback.testlist | 9 + 1 file changed, 9 insertions(+) diff

[Intel-gfx] [PATCH i-g-t 1/3] tests/chamelium: Introduce fast basic hpd tests, with limited toggles

2017-08-23 Thread Paul Kocialkowski
This introduces a fast fashion of testing basic hotplug detect, with only 3 toggles. It drastically reduces the run time of the test, which is necessary for the fast-feedback test list. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/chamelium.

[Intel-gfx] [PATCH i-g-t] tests/Makefile.am: Wrap audio test with dedicated conditional

2017-08-22 Thread Paul Kocialkowski
This uses the dedicated HAVE_AUDIO conditional, that depends on both ALSA and GSL, for wrapping the audio test. This makes the wrapping consistent with what is done for the chamelium test. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/Makefile.am | 4 +---

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib: Add audio library with dedicated helpers

2017-08-21 Thread Paul Kocialkowski
Hi, On Fri, 2017-08-18 at 12:16 -0400, Lyude Paul wrote: > One more small formatting change > > On Thu, 2017-08-17 at 19:05 +0300, Paul Kocialkowski wrote: > > This introduces an audio library, with dedicated helpers for both > > generating signals and detecting peak fr

[Intel-gfx] [PATCH i-g-t v2 0/3] Audio tests support for HDMI, with audio and ALSA helpers

2017-08-21 Thread Paul Kocialkowski
Changes since v1: * Introduced explicit --enable-audio configure option * Added dependencies to README * Removed trailing whitespaces * Fixed alignment in sqrt call * Fixed ALSA overrun/underrun error handling and recovery * Fixed ALSA open/close sequence for more robust behavior

[Intel-gfx] [PATCH i-g-t v2 2/3] lib: Add ALSA library with dedicated helpers

2017-08-21 Thread Paul Kocialkowski
through display connectors, such as HDMI. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac | 3 + .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makefile.am| 7

[Intel-gfx] [PATCH i-g-t v2 3/3] tests: Introduce audio tests, starting with HDMI signal integrity

2017-08-21 Thread Paul Kocialkowski
this back to the DUT's line-in where it can be recorded by ALSA with controls correctly configured. The audio test makes use of the audio and ALSA igt libraries helpers. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- README| 6 ++ configure.ac

[Intel-gfx] [PATCH i-g-t v2 1/3] lib: Add audio library with dedicated helpers

2017-08-21 Thread Paul Kocialkowski
This introduces an audio library, with dedicated helpers for both generating signals and detecting peak frequencies in a signal. This library paves the way for testing audio going through display connectors, such as HDMI. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests: Introduce audio tests, starting with HDMI signal integrity

2017-08-21 Thread Paul Kocialkowski
Hi, On Fri, 2017-08-18 at 12:15 -0400, Lyude Paul wrote: > Nice job! Only one small formatting change Thanks a lot for the timely review! I only have a week and a half left at my internship, so it is much appreciated :) > On Thu, 2017-08-17 at 19:05 +0300, Paul Kocialkowski

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib: Add ALSA library with dedicated helpers

2017-08-21 Thread Paul Kocialkowski
Hi, On Fri, 2017-08-18 at 12:20 -0400, Lyude Paul wrote: > And two more small changes > > On Thu, 2017-08-17 at 19:05 +0300, Paul Kocialkowski wrote: > > This introduces an ALSA library, with dedicated helpers for handling > > playback and capture. It handles ALSA

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib: Add ALSA library with dedicated helpers

2017-08-21 Thread Paul Kocialkowski
On Mon, 2017-08-21 at 10:25 +0300, Arkadiusz Hiler wrote: > On Fri, Aug 18, 2017 at 12:46:38PM +0300, Arkadiusz Hiler wrote: > > On Thu, Aug 17, 2017 at 07:05:56PM +0300, Paul Kocialkowski wrote: > > > This introduces an ALSA library, with dedicated helpers for > > &

[Intel-gfx] [PATCH i-g-t 3/3] tests: Introduce audio tests, starting with HDMI signal integrity

2017-08-17 Thread Paul Kocialkowski
this back to the DUT's line-in where it can be recorded by ALSA with controls correctly configured. The audio test makes use of the audio and ALSA igt libraries helpers. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/Makefile.am | 12 tests/audio.c

[Intel-gfx] [PATCH i-g-t 2/3] lib: Add ALSA library with dedicated helpers

2017-08-17 Thread Paul Kocialkowski
through display connectors, such as HDMI. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac | 3 + .../intel-gpu-tools/intel-gpu-tools-docs.xml | 1 + lib/Makefile.am| 7

[Intel-gfx] [PATCH i-g-t 1/3] lib: Add audio library with dedicated helpers

2017-08-17 Thread Paul Kocialkowski
This introduces an audio library, with dedicated helpers for both generating signals and detecting peak frequencies in a signal. This library paves the way for testing audio going through display connectors, such as HDMI. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.

[Intel-gfx] [PATCH i-g-t] lib/igt_chamelium: Remove any special handling for the connector FSM

2017-08-04 Thread Paul Kocialkowski
-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_chamelium.c | 113 1 file changed, 25 insertions(+), 88 deletions(-) diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c index dcd8855f..4cea5fdb 100644 ---

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Prevent compiler warning on unchecked printf format

2017-08-01 Thread Paul Kocialkowski
], > - i == (crc->n_words - 1) ? '\0' : delimiter); > + len += sprintf(buf + len, "%0*x%c", field_width, > +crc->crc[i], delimiter); > > + /* Eat the last delimiter */ > + buf[len

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-26 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 17:50 +0200, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 03:18:04PM +0300, Paul Kocialkowski wrote: > > On Tue, 2017-07-25 at 10:16 +0200, Daniel Vetter wrote: > > > On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > > > &g

[Intel-gfx] [PATCH i-g-t v2] configure.ac: Disable chamelium by default and add enable argument

2017-07-26 Thread Paul Kocialkowski
automatically enabling it when its dependencies are met. Finally, whether chamelium support is enabled is printed by the information summary at end of the configure run. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac | 18 ++ 1 file chang

Re: [Intel-gfx] [PATCH i-g-t 2/3] configure.ac: Disable chamelium by default and add enable argument

2017-07-26 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 13:07 -0400, Lyude Paul wrote: > I like this patch, however there's a mistake in it: > > On Tue, 2017-07-25 at 15:48 +0300, Paul Kocialkowski wrote: > > Since the chamelium is not a very usual piece of hardware and > > requires > > pulling-in lo

[Intel-gfx] [PATCH i-g-t 2/3] configure.ac: Disable chamelium by default and add enable argument

2017-07-25 Thread Paul Kocialkowski
automatically enabling it when its dependencies are met. Finally, whether chamelium support is enabled is printed by the information summary at end of the configure run. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac | 17 + 1 file chan

[Intel-gfx] [PATCH i-g-t 1/3] configure.ac: Make udev a dependency for chamelium

2017-07-25 Thread Paul Kocialkowski
Chamelium testing has a hard dependency on udev. This makes this dependency explicit in configure instead of failing the build when it is missing. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff

[Intel-gfx] [PATCH i-g-t 3/3] README: Add information about chamelium dependencies

2017-07-25 Thread Paul Kocialkowski
-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- README | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/README b/README index 26171a17..d1ea9529 100644 --- a/README +++ b/README @@ -131,7 +131,7 @@ Requirements This is a non-exhaustiv

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 10:16 +0200, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 10:58:55AM +0300, Paul Kocialkowski wrote: > > On Tue, 2017-07-25 at 09:34 +0200, Daniel Vetter wrote: > > > On Tue, Jul 25, 2017 at 9:25 AM, Paul Kocialkowski > > > <paul.kocia

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 09:34 +0200, Daniel Vetter wrote: > On Tue, Jul 25, 2017 at 9:25 AM, Paul Kocialkowski > <paul.kocialkow...@linux.intel.com> wrote: > > On Tue, 2017-07-25 at 08:53 +0200, Daniel Vetter wrote: > > > On Mon, Jul 24, 2017 at 05:54:46PM +03

Re: [Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-25 Thread Paul Kocialkowski
On Tue, 2017-07-25 at 08:53 +0200, Daniel Vetter wrote: > On Mon, Jul 24, 2017 at 05:54:46PM +0300, Paul Kocialkowski wrote: > > This adds a common drm helper to detect whether the EDID changed > > from > > the last known cached one. This is useful help detect that a monito

[Intel-gfx] [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

2017-07-24 Thread Paul Kocialkowski
the change will not be caught at resume time. Detecting that the EDID changed allows detecting it. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- drivers/gpu/drm/drm_edid.c | 45 + include/drm/drm_edid.h | 3 +++ 2

[Intel-gfx] [PATCH 2/2] drm/i915: Detect monitor change from EDID change after resume

2017-07-24 Thread Paul Kocialkowski
, such as the i2c adapter required to get the EDID. Support for this is introduced for DP, HDMI and VGA. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- drivers/gpu/drm/i915/i915_drv.c | 2 ++ drivers/gpu/drm/i915/i915_drv.h | 5 drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH i-g-t v3] tests/chamelium: Detect analog bridges and handle EDID accordingly

2017-07-21 Thread Paul Kocialkowski
On Wed, 2017-07-19 at 16:50 +0300, Paul Kocialkowski wrote: > Nowadays, many VGA connectors are not actually native VGA but use a > discrete bridge to a digital connector. These bridges usually enforce > their own EDID instead of the one supplied by the chamelium. > > Thus, the

Re: [Intel-gfx] [PATCH i-g-t v3 0/2] Analogue/VGA frame comparison support

2017-07-20 Thread Paul Kocialkowski
akes more sense to split the configure.ac in two parts (as you'll see from v4). Since you may disgree, I haven't added your R-b. > On Wed, 2017-07-19 at 16:48 +0300, Paul Kocialkowski wrote: > > Changes since v2: > > * Changed analogue in favor of analog > > * Integrated analog frame mat

[Intel-gfx] [PATCH i-g-t v4 1/2] lib/igt_frame: Add support for analog frame comparison testing

2017-07-20 Thread Paul Kocialkowski
error threshold and a correlation with the expected error trend for a DAC-ADC chain. It was tested with a couple encoders and provides reliable error detection with few false positives. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac | 2

[Intel-gfx] [PATCH i-g-t v4 2/2] chamelium: Add support for VGA frame comparison testing

2017-07-20 Thread Paul Kocialkowski
if not. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac| 4 ++ lib/igt_chamelium.c | 164 ++-- lib/igt_chamelium.h | 7 ++- tests/chamelium.c | 57 ++ 4 files changed, 226 inse

[Intel-gfx] [PATCH i-g-t v4 0/2] Analogue/VGA frame comparison support

2017-07-20 Thread Paul Kocialkowski
Changes since v3: * Squashed configure.ac changes in this series Changes since v2: * Changed analogue in favor of analog * Integrated analog frame match fixup in the original commit * Rebased on top of the new revisions of the series this depends on Changes since v1: * Split analogue frame

Re: [Intel-gfx] [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

2017-07-20 Thread Paul Kocialkowski
On Wed, 2017-07-19 at 23:11 -0700, Manasi Navare wrote: > On Tue, Jul 18, 2017 at 03:11:42PM +0300, Paul Kocialkowski wrote: > > On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > > > After detecting an IRQ storm, hotplug detection will switch from > > >

Re: [Intel-gfx] [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

2017-07-20 Thread Paul Kocialkowski
On Thu, 2017-07-20 at 01:04 +, Pandiyan, Dhinakaran wrote: > On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > > After detecting an IRQ storm, hotplug detection will switch from > > irq-based detection to poll-based detection. After a short delay or > >

Re: [Intel-gfx] [PATCH i-g-t v5 4/7] Introduce common frame dumping configuration and helpers

2017-07-20 Thread Paul Kocialkowski
On Thu, 2017-07-20 at 09:24 +0200, Daniel Vetter wrote: > On Wed, Jul 19, 2017 at 04:46:07PM +0300, Paul Kocialkowski wrote: > > This introduces a common FrameDumpPath configuration field, as well > > as > > helper functions in dedicated igt_frame for writing cairo surf

[Intel-gfx] [PATCH i-g-t 1/2] lib/igt_core: Move all config-related parsing to common_init_config

2017-07-20 Thread Paul Kocialkowski
This moves all the pieces related to config parsing to the dedicated function for this purpose, renamed common_init_config for consistency. It allows making the common_init function less big and more readable. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --

[Intel-gfx] [PATCH i-g-t 2/2] lib/igt_core: Split out env-related handling to common_init_env

2017-07-20 Thread Paul Kocialkowski
This moves the parts of the code doing env-related handling from common_init to a new dedicated common_init_env function, making common_init a bit more readable. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_core.

[Intel-gfx] [PATCH i-g-t] docs: Update documentation generation with missing entries

2017-07-20 Thread Paul Kocialkowski
when it was missing. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- docs/reference/intel-gpu-tools/Makefile.am | 24 +++- .../intel-gpu-tools/igt_test_programs.xml | 123 + .../intel-gpu-tools/intel-gpu-tools-docs.xml

Re: [Intel-gfx] [PATCH i-g-t v5 0/7] CRC testing with Chamelium improvements

2017-07-20 Thread Paul Kocialkowski
On Thu, 2017-07-20 at 14:41 +0200, Daniel Vetter wrote: > On Thu, Jul 20, 2017 at 1:27 PM, Paul Kocialkowski > <paul.kocialkow...@linux.intel.com> wrote: > > On Thu, 2017-07-20 at 12:39 +0300, Jani Nikula wrote: > > > For future reference, please post new versions

Re: [Intel-gfx] [PATCH i-g-t v5 0/7] CRC testing with Chamelium improvements

2017-07-20 Thread Paul Kocialkowski
; On Wed, 19 Jul 2017, Paul Kocialkowski <paul.kocialkowski@linux.intel. > com> wrote: > > Changes since v4: > > * Moved igt_get_cairo_surface out of the thread function to properly > > handle assert failure > > * Rebased on top of current master > > >

[Intel-gfx] [PATCH i-g-t v2] lib/igt_core: Handle glib errors correctly to avoid stderr spew

2017-07-20 Thread Paul Kocialkowski
GError or uninitialized memory. This indicates a bug in someone's code. You must ensure an error is NULL before it's set. The overwriting error message was: Key file does not have group ?DUT? Fixes: ee31e0b5 ("Introduce common frame dumping configuration...") Cc: Paul Ko

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_core: Handle glib errors correctly to avoid stderr spew

2017-07-20 Thread Paul Kocialkowski
On Thu, 2017-07-20 at 10:45 +0300, Paul Kocialkowski wrote: > This adds the required error clean/free calls after calling > configuration parsing functions. In addition to properly handling > memory, > this avoids glib spewing out error messages on stderr, which breaks > the >

[Intel-gfx] [PATCH i-g-t] lib/igt_core: Handle glib errors correctly to avoid stderr spew

2017-07-20 Thread Paul Kocialkowski
This adds the required error clean/free calls after calling configuration parsing functions. In addition to properly handling memory, this avoids glib spewing out error messages on stderr, which breaks the whole CI. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --

[Intel-gfx] [PATCH i-g-t 3/3] configure.ac: Make gsl dependency and dependent code optional

2017-07-19 Thread Paul Kocialkowski
This adds automake instructions, with matching autoconf macros, to make the dependency on gsl and the code that depends on it optional. This should allow preserving the ability to build IGT on Android, where gsl support may be lacking. Signed-off-by: Paul Kocialkowski <paul.kocial

[Intel-gfx] [PATCH i-g-t 2/3] configure.ac: Make glib dependency optional to preserve Android build

2017-07-19 Thread Paul Kocialkowski
This adds ifdef wrappers, with matching autoconf macros, to make the dependency on glib (used for parsing configuration) optional. This allows preserving the ability to build IGT on Android, where glib support is lacking. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.

[Intel-gfx] [PATCH i-g-t 0/3] Various autoconf fixups

2017-07-19 Thread Paul Kocialkowski
These patches apply on top of: tests/chamelium: Detect analogue bridges and handle EDID accordingly ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 1/3] configure.ac: Enable back chamelium build by default

2017-07-19 Thread Paul Kocialkowski
Introducing an option for chamelium build inadvertently disabled it by default, according to the definition of the AC_ARG_ENABLE macro. This enables it back chamelium by default. Fixes: fd096fcc ("configure.ac: Make building chamelium an option") Signed-off-by: Paul Kocialkowski <p

[Intel-gfx] [PATCH i-g-t v3] tests/chamelium: Detect analog bridges and handle EDID accordingly

2017-07-19 Thread Paul Kocialkowski
modes may also go beyond what the chamelium can support. Thus, only supported resolutions should be tested for the frame dump test and others should be pruned. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/chamelium.

[Intel-gfx] [PATCH i-g-t v3 0/1] tests/chamelium: Detect analogue bridges and handle EDID accordingly

2017-07-19 Thread Paul Kocialkowski
This patch applies on top of: Analogue/VGA frame comparison support Changes since v2: * Changed analogue in favor of analog * Rebased on top of the new revisions of the series this depends on Changes since v1: * Rebased on top of the new revisions of the series this depends on

[Intel-gfx] [PATCH i-g-t v3 2/2] chamelium: Add support for VGA frame comparison testing

2017-07-19 Thread Paul Kocialkowski
if not. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_chamelium.c | 164 ++-- lib/igt_chamelium.h | 7 ++- tests/chamelium.c | 57 ++ 3 files changed, 222 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH i-g-t v3 0/2] Analogue/VGA frame comparison support

2017-07-19 Thread Paul Kocialkowski
Changes since v2: * Changed analogue in favor of analog * Integrated analog frame match fixup in the original commit * Rebased on top of the new revisions of the series this depends on Changes since v1: * Split analogue frame comparison to igt_frame, using cairo surfaces * Added a chamelium

[Intel-gfx] [PATCH i-g-t v3 1/2] lib/igt_frame: Add support for analog frame comparison testing

2017-07-19 Thread Paul Kocialkowski
error threshold and a correlation with the expected error trend for a DAC-ADC chain. It was tested with a couple encoders and provides reliable error detection with few false positives. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- configure.ac| 1 + lib/Makef

[Intel-gfx] [PATCH i-g-t v5 6/7] chamelium: Dump captured and reference frames to png on crc error

2017-07-19 Thread Paul Kocialkowski
-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_chamelium.c | 81 + lib/igt_chamelium.h | 4 +++ tests/chamelium.c | 14 ++--- 3 files changed, 95 insertions(+), 4 deletions(-) diff --git a/lib/igt_chamelium.c

[Intel-gfx] [PATCH i-g-t v5 3/7] lib/igt_debugfs: Introduce CRC check function, with logic made common

2017-07-19 Thread Paul Kocialkowski
the diverging values. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_debugfs.c | 53 ++--- lib/igt_debugfs.h | 1 + 2 files changed, 51 insertions(+), 3 deletions(-) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c

[Intel-gfx] [PATCH i-g-t v5 7/7] tests/chamelium: Merge the crc testing functions into one

2017-07-19 Thread Paul Kocialkowski
This merges the two test_display_crc_single and test_display_crc_multiple functions into one, with a variable number of frames to capture. This reduces code duplication. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/chamelium.

[Intel-gfx] [PATCH i-g-t v5 1/7] lib/igt_fb: Export the cairo surface instead of writing to a png

2017-07-19 Thread Paul Kocialkowski
code, which avoids destroying it too early. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_chamelium.c | 7 +-- lib/igt_fb.c| 36 +--- lib/igt_fb.h| 2 +- 3 files changed, 15 insertions(+), 30 del

[Intel-gfx] [PATCH i-g-t v5 2/7] chamelium: Calculate CRC from framebuffer instead of hardcoding it

2017-07-19 Thread Paul Kocialkowski
the CRC checks to fail on different setups. This allows them to pass regardless of the setup. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_chamelium.c | 143 lib/igt_chamelium.h | 5 ++ tests/chamelium.c

[Intel-gfx] [PATCH i-g-t v5 5/7] lib/igt_debugfs: Add extended helper to format crc to string

2017-07-19 Thread Paul Kocialkowski
This introduces a igt_crc_to_string_extended helper that allows formatting a crc to a string with a given delimiter and size to print per crc word. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/igt_debugfs.c | 27 +++ lib/igt_debugfs.

[Intel-gfx] [PATCH i-g-t v5 0/7] CRC testing with Chamelium improvements

2017-07-19 Thread Paul Kocialkowski
Changes since v4: * Moved igt_get_cairo_surface out of the thread function to properly handle assert failure * Rebased on top of current master Changes since v3: * Renamed structure used by async crc calculation for more clarity * Used const qualifier for untouched buffer when hashing * Split

[Intel-gfx] [PATCH i-g-t v5 4/7] Introduce common frame dumping configuration and helpers

2017-07-19 Thread Paul Kocialkowski
This introduces a common FrameDumpPath configuration field, as well as helper functions in dedicated igt_frame for writing cairo surfaces to png files. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- lib/Makefile.sources | 2 + lib/igt.h| 1

Re: [Intel-gfx] [PATCH i-g-t v2 2/2] chamelium: Add support for VGA frame comparison testing

2017-07-19 Thread Paul Kocialkowski
On Mon, 2017-07-17 at 13:35 -0400, Lyude Paul wrote: > Just one change for this patch below > > On Wed, 2017-07-12 at 17:57 +0300, Paul Kocialkowski wrote: > > This adds support for VGA frame comparison testing with the > > reference > > generated from cair

Re: [Intel-gfx] [PATCH i-g-t v4 2/7] chamelium: Calculate CRC from framebuffer instead of hardcoding it

2017-07-19 Thread Paul Kocialkowski
On Mon, 2017-07-17 at 12:29 -0400, Lyude Paul wrote: > On Wed, 2017-07-12 at 17:50 +0300, Paul Kocialkowski wrote: > > This introduces CRC calculation for reference frames, instead of > > using > > hardcoded values for them. The rendering of reference frames may > &

Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name for DP link training result

2017-07-19 Thread Paul Kocialkowski
On Tue, 2017-07-18 at 12:20 -0700, Manasi Navare wrote: > On Tue, Jul 18, 2017 at 05:25:36PM +0300, Paul Kocialkowski wrote: > > This adds the connector name when printing a debug message about the > > DP > > link training result. It is useful to figure out what connecto

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/chamelium: Skip suspend/resume test with unreliable hotplug event

2017-07-19 Thread Paul Kocialkowski
On Tue, 2017-07-18 at 22:21 +0100, Chris Wilson wrote: > Quoting Paul Kocialkowski (2017-07-18 16:16:26) > > It may occur that a hotplug uevent is detected at resume, even > > though it > > does not indicate that an actual hotplug happened. This is the case > > when >

[Intel-gfx] [PATCH i-g-t 2/2] tests/chamelium: Catch and flush hotplug uevents after each plug

2017-07-18 Thread Paul Kocialkowski
at resume time. Signed-off-by: Paul Kocialkowski <paul.kocialkow...@linux.intel.com> --- tests/chamelium.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/chamelium.c b/tests/chamelium.c index 8af33aaa..0528ffb3 100644 --- a/tests/chamelium.c +++ b

  1   2   3   >