Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-20 Thread Rob Clark
>> > >> Objects with multiple possible placements are reported in multiple regions > >> for > >> total and shared sizes, while other categories are counted only for the > >> currently active region. > >> > >> Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH v2] drm: Update file owner during use

2023-08-28 Thread Rob Clark
therwise) to > systemd-logind. > """ > > v2: > * Fixed typo in commit text and added a fine historical explanation >from Emil. > > Signed-off-by: Tvrtko Ursulin > Cc: "Christian König" > Cc: Daniel Vetter > Acked-by: Christian

Re: [Intel-gfx] [PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

2023-06-09 Thread Rob Clark
On Fri, Jun 9, 2023 at 7:12 AM Tvrtko Ursulin wrote: > > > On 09/06/2023 13:44, Iddamsetty, Aravind wrote: > > On 09-06-2023 17:41, Tvrtko Ursulin wrote: > >> From: Tvrtko Ursulin > >> > >> I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which > >> will return a reference to a

Re: [Intel-gfx] [PATCH i-g-t 0/2] gputop/intel_gpu_top: Move name to be the last field

2023-05-15 Thread Rob Clark
||| kwin_x11 >1837 |▏ ||||||| Xorg > 3429732 ||||| || | kwrite > 2162094 |||||||| thunderbird > > Cc: Rob Clark

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2023-05-12 Thread Rob Clark
On Thu, Apr 6, 2023 at 7:33 AM Tvrtko Ursulin wrote: > > > On 06/04/2023 15:21, Rob Clark wrote: > > On Thu, Apr 6, 2023 at 4:08 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 05/04/2023 18:57, Rob Clark wrote: > >>> On Tue, Jan 31, 202

[Intel-gfx] [PATCH] drm/syncobj: Add deadline support for syncobj waits

2023-04-26 Thread Rob Clark
From: Rob Clark Add a new flag to let userspace provide a deadline as a hint for syncobj and timeline waits. This gives a hint to the driver signaling the backing fences about how soon userspace needs it to compete work, so it can addjust GPU frequency accordingly. An immediate deadline can

Re: [Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-20 Thread Rob Clark
On Thu, Apr 20, 2023 at 6:11 AM Tvrtko Ursulin wrote: > > > On 19/04/2023 15:38, Rob Clark wrote: > > On Wed, Apr 19, 2023 at 7:06 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 18/04/2023 17:08, Rob Clark wrote: > >>> On Tue, Apr 18,

Re: [Intel-gfx] [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-20 Thread Rob Clark
On Thu, Apr 20, 2023 at 6:14 AM Tvrtko Ursulin wrote: > > > On 19/04/2023 15:32, Rob Clark wrote: > > On Wed, Apr 19, 2023 at 6:16 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 18/04/2023 18:18, Rob Clark wrote: > >>>

Re: [Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-19 Thread Rob Clark
On Wed, Apr 19, 2023 at 7:06 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 17:08, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:58 AM Tvrtko Ursulin > > wrote: > >> On 18/04/2023 15:39, Rob Clark wrote: > >>> On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursuli

Re: [Intel-gfx] [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-19 Thread Rob Clark
On Wed, Apr 19, 2023 at 6:16 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 18:18, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> For drivers who only wish to sho

Re: [Intel-gfx] [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > For drivers who only wish to show one memory region called 'system, > and only account the GEM buffer object handles under it. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/drm_file.c | 45

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 9:44 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 17:13, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin > > wrote: > >> On 18/04/2023 15:36, Rob Clark wrote: > >>> On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursuli

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:36, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 18/04/2023 14:49, Rob Clark wrote: > >>>

Re: [Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:58 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Show how more driver specific set of

Re: [Intel-gfx] [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Show how more driver specific set of memory stats could be shown, > more specifically where object can reside in multiple regions, showing all > the supported stats, and where there is more to show than just user

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 14:49, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 17/04/2023 20:39, Rob Clark wrote: > >>>

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 3:47 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 17:20, Christian König wrote: > > Am 17.04.23 um 17:56 schrieb Tvrtko Ursulin: > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM stats to fdinfo. > >> > >> Signed-off-by: Tvrtko Ursulin > >> --- > >>

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 20:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM

Re: [Intel-gfx] [RFC 3/6] drm: Add fdinfo memory stats

2023-04-17 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Add support to dump GEM stats to fdinfo. > > Signed-off-by: Tvrtko Ursulin > --- > Documentation/gpu/drm-usage-stats.rst | 12 +++ > drivers/gpu/drm/drm_file.c| 52 +++ >

Re: [Intel-gfx] [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 6:07 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 23:42, Rob Clark wrote: > > From: Rob Clark > > There is more do to here to remove my client->id fully (would now be > dead code) so maybe easiest if you drop this patch and I do it after you &g

[Intel-gfx] [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-12 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_driver.c | 3 ++- drivers/gpu/drm/i915/i915_drm_client.c | 18 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 +- 3 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 0/6] drm: fdinfo memory stats

2023-04-12 Thread Rob Clark
From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start

[Intel-gfx] [PATCH v3 4/7] drm/i915: Switch to fdinfo helper

2023-04-11 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_driver.c | 3 ++- drivers/gpu/drm/i915/i915_drm_client.c | 18 +- drivers/gpu/drm/i915/i915_drm_client.h | 2 +- 3 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v3 0/7] drm: fdinfo memory stats

2023-04-11 Thread Rob Clark
From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2023-04-06 Thread Rob Clark
On Thu, Apr 6, 2023 at 4:08 AM Tvrtko Ursulin wrote: > > > On 05/04/2023 18:57, Rob Clark wrote: > > On Tue, Jan 31, 2023 at 3:33 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Rudimentary vendor agnostic examp

Re: [Intel-gfx] [PATCH i-g-t 8/8] gputop: Basic vendor agnostic GPU top tool

2023-04-05 Thread Rob Clark
tel_gpu_top does not do. > > Signed-off-by: Tvrtko Ursulin > Cc: Rob Clark > Cc: Christian König > Acked-by: Christian König Reviewed-by: Rob Clark > --- > tools/gputop.c| 260 ++ > tools/meson.build | 5 + > 2 fil

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Rob Clark
ip on inactive crtc (Ville) > > Link: > https://lore.kernel.org/dri-devel/dfc21f18-7e1e-48f0-c05a-d659b9c90...@linaro.org/ > Fixes: d39e48ca80c0 ("drm/atomic-helper: Set fence deadline for vblank") > Cc: Ville Syrjälä > Cc: Rob Clark > Cc: Daniel Vetter > Cc: Maart

Re: [Intel-gfx] [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-04-01 Thread Rob Clark
On Fri, Mar 31, 2023 at 4:30 PM Nathan Chancellor wrote: > > On Fri, Mar 31, 2023 at 03:14:30PM -0700, Rob Clark wrote: > > On Fri, Mar 31, 2023 at 1:44 PM Nathan Chancellor wrote: > > > > > > Hi Rob, > > > > > > On Wed, Mar 08, 2023 at 07:53:02AM

Re: [Intel-gfx] [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-31 Thread Rob Clark
On Fri, Mar 31, 2023 at 1:44 PM Nathan Chancellor wrote: > > Hi Rob, > > On Wed, Mar 08, 2023 at 07:53:02AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > For an atomic commit updating a single CRTC (ie. a pageflip) calculate > > the next

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-21 Thread Rob Clark
On Tue, Mar 21, 2023 at 6:24 AM Jonas Ådahl wrote: > > On Fri, Mar 17, 2023 at 08:59:48AM -0700, Rob Clark wrote: > > On Fri, Mar 17, 2023 at 3:23 AM Jonas Ådahl wrote: > > > > > > On Thu, Mar 16, 2023 at 09:28:55AM -0700, Rob Clark wrote: > > > > O

Re: [Intel-gfx] [PATCH v10 09/15] drm/syncobj: Add deadline support for syncobj waits

2023-03-18 Thread Rob Clark
On Fri, Mar 17, 2023 at 12:08 PM Faith Ekstrand wrote: > > > On Wed, Mar 8, 2023 at 9:54 AM Rob Clark wrote: >> >> From: Rob Clark >> >> Add a new flag to let userspace provide a deadline as a hint for syncobj >> and timeline waits. This gives a hint

Re: [Intel-gfx] [PATCH v10 09/15] drm/syncobj: Add deadline support for syncobj waits

2023-03-17 Thread Rob Clark
On Fri, Mar 17, 2023 at 12:08 PM Faith Ekstrand wrote: > > > On Wed, Mar 8, 2023 at 9:54 AM Rob Clark wrote: >> >> From: Rob Clark >> >> Add a new flag to let userspace provide a deadline as a hint for syncobj >> and timeline waits. This gives a hint

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-17 Thread Rob Clark
On Fri, Mar 17, 2023 at 3:23 AM Jonas Ådahl wrote: > > On Thu, Mar 16, 2023 at 09:28:55AM -0700, Rob Clark wrote: > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > > > O

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-16 Thread Rob Clark
On Thu, Mar 16, 2023 at 3:22 PM Sebastian Wick wrote: > > On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote: > > > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > > > On

Re: [Intel-gfx] [PATCH v10 00/15] dma-fence: Deadline awareness

2023-03-16 Thread Rob Clark
On Wed, Mar 8, 2023 at 7:53 AM Rob Clark wrote: > > From: Rob Clark > > This series adds a deadline hint to fences, so realtime deadlines > such as vblank can be communicated to the fence signaller for power/ > frequency management decisions. > > This is partially inspi

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-16 Thread Rob Clark
On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrote: > > > > > > On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark wrote: > > > > O

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-15 Thread Rob Clark
On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrote: > > On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark wrote: > > On Fri, Mar 10, 2023 at 7:45 AM Jonas Ådahl wrote: > > > > > > On Wed, Mar 08, 2023 at 07:52:52AM -0800, Rob Clark wrote: > > > >

Re: [Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-10 Thread Rob Clark
On Fri, Mar 10, 2023 at 7:45 AM Jonas Ådahl wrote: > > On Wed, Mar 08, 2023 at 07:52:52AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > Add a way to hint to the fence signaler of an upcoming deadline, such as > > vblank, which the fence waiter would prefe

[Intel-gfx] [PATCH v10 15/15] drm/i915: Add deadline based boost support

2023-03-08 Thread Rob Clark
From: Rob Clark I expect this patch to be replaced by someone who knows i915 better. Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH v10 13/15] drm/msm: Add wait-boost support

2023-03-08 Thread Rob Clark
From: Rob Clark Add a way for various userspace waits to signal urgency. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 12 drivers/gpu/drm/msm/msm_gem.c | 5 + include/uapi/drm/msm_drm.h| 14 -- 3 files changed, 25 insertions(+), 6 deletions

[Intel-gfx] [PATCH v10 14/15] drm/msm/atomic: Switch to vblank_start helper

2023-03-08 Thread Rob Clark
From: Rob Clark Drop our custom thing and switch to drm_crtc_next_vblank_start() for calculating the time of the start of the next vblank period. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 15 --- drivers/gpu/drm/msm/msm_atomic.c| 8

[Intel-gfx] [PATCH v10 12/15] drm/msm: Add deadline based boost support

2023-03-08 Thread Rob Clark
From: Rob Clark Track the nearest deadline on a fence timeline and set a timer to expire shortly before to trigger boost if the fence has not yet been signaled. v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fence.c | 74 + drivers/gpu/drm/msm

[Intel-gfx] [PATCH v10 09/15] drm/syncobj: Add deadline support for syncobj waits

2023-03-08 Thread Rob Clark
From: Rob Clark Add a new flag to let userspace provide a deadline as a hint for syncobj and timeline waits. This gives a hint to the driver signaling the backing fences about how soon userspace needs it to compete work, so it can addjust GPU frequency accordingly. An immediate deadline can

[Intel-gfx] [PATCH v10 10/15] drm/vblank: Add helper to get next vblank time

2023-03-08 Thread Rob Clark
From: Rob Clark Will be used in the next commit to set a deadline on fences that an atomic update is waiting on. v2: Calculate time at *start* of vblank period, not end v3: Fix kbuild complaints Signed-off-by: Rob Clark Reviewed-by: Mario Kleiner --- drivers/gpu/drm/drm_vblank.c | 53

[Intel-gfx] [PATCH v10 11/15] drm/atomic-helper: Set fence deadline for vblank

2023-03-08 Thread Rob Clark
From: Rob Clark For an atomic commit updating a single CRTC (ie. a pageflip) calculate the next vblank time, and inform the fence(s) of that deadline. v2: Comment typo fix (danvet) v3: If there are multiple CRTCs, consider the time of the soonest vblank Signed-off-by: Rob Clark Reviewed

[Intel-gfx] [PATCH v10 06/15] dma-buf/sync_file: Add SET_DEADLINE ioctl

2023-03-08 Thread Rob Clark
From: Rob Clark The initial purpose is for igt tests, but this would also be useful for compositors that wait until close to vblank deadline to make decisions about which frame to show. The igt tests can be found at: https://gitlab.freedesktop.org/robclark/igt-gpu-tools/-/commits/fence

[Intel-gfx] [PATCH v10 07/15] dma-buf/sw_sync: Add fence deadline support

2023-03-08 Thread Rob Clark
From: Rob Clark This consists of simply storing the most recent deadline, and adding an ioctl to retrieve the deadline. This can be used in conjunction with the SET_DEADLINE ioctl on a fence fd for testing. Ie. create various sw_sync fences, merge them into a fence-array, set deadline

[Intel-gfx] [PATCH v10 08/15] drm/scheduler: Add fence deadline support

2023-03-08 Thread Rob Clark
a thread calling drm_sched_fence_set_deadline_finished() sees fence->parent set before drm_sched_fence_set_parent() does this test_bit(DMA_FENCE_FLAG_HAS_DEADLINE_BIT). Signed-off-by: Rob Clark Acked-by: Luben Tuikov --- drivers/gpu/drm/scheduler/sched_fence.c |

[Intel-gfx] [PATCH v10 03/15] dma-buf/fence-chain: Add fence deadline support

2023-03-08 Thread Rob Clark
From: Rob Clark Propagate the deadline to all the fences in the chain. v2: Use dma_fence_chain_contained [Tvrtko] Signed-off-by: Rob Clark Reviewed-by: Christian König for this one. --- drivers/dma-buf/dma-fence-chain.c | 12 1 file changed, 12 insertions(+) diff --git

[Intel-gfx] [PATCH v10 05/15] dma-buf/sync_file: Surface sync-file uABI

2023-03-08 Thread Rob Clark
From: Rob Clark We had all of the internal driver APIs, but not the all important userspace uABI, in the dma-buf doc. Fix that. And re-arrange the comments slightly as otherwise the comments for the ioctl nr defines would not show up. v2: Fix docs build warning coming from newly including

[Intel-gfx] [PATCH v10 04/15] dma-buf/dma-resv: Add a way to set fence deadline

2023-03-08 Thread Rob Clark
From: Rob Clark Add a way to set a deadline on remaining resv fences according to the requested usage. Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/dma-buf/dma-resv.c | 22 ++ include/linux/dma-resv.h | 2 ++ 2 files changed, 24 insertions(+) diff

[Intel-gfx] [PATCH v10 02/15] dma-buf/fence-array: Add fence deadline support

2023-03-08 Thread Rob Clark
From: Rob Clark Propagate the deadline to all the fences in the array. Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/dma-buf/dma-fence-array.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence

[Intel-gfx] [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-08 Thread Rob Clark
From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the fence waiter would prefer not to miss. This is to aid the fence signaler in making power management decisions, like boosting frequency as the deadline approaches and awareness of missing

[Intel-gfx] [PATCH v10 00/15] dma-fence: Deadline awareness

2023-03-08 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1

Re: [Intel-gfx] [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-03 Thread Rob Clark
On Fri, Mar 3, 2023 at 7:20 AM Ville Syrjälä wrote: > > On Fri, Mar 03, 2023 at 05:00:03PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 03, 2023 at 06:48:43AM -0800, Rob Clark wrote: > > > On Fri, Mar 3, 2023 at 1:58 AM Tvrtko Ursulin > > > wrote: > > >

Re: [Intel-gfx] [Freedreno] [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-03 Thread Rob Clark
On Fri, Mar 3, 2023 at 7:08 AM Tvrtko Ursulin wrote: > > > On 03/03/2023 14:48, Rob Clark wrote: > > On Fri, Mar 3, 2023 at 1:58 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 03/03/2023 03:21, Rodrigo Vivi wrote: > >>> On Thu, Mar 02,

Re: [Intel-gfx] [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-03 Thread Rob Clark
On Thu, Mar 2, 2023 at 7:21 PM Rodrigo Vivi wrote: > > On Thu, Mar 02, 2023 at 03:53:37PM -0800, Rob Clark wrote: > > From: Rob Clark > > > > missing some wording here... the wording should be "Pls replace this patch, kthx" ;-) > > >

Re: [Intel-gfx] [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-03 Thread Rob Clark
On Fri, Mar 3, 2023 at 1:58 AM Tvrtko Ursulin wrote: > > > On 03/03/2023 03:21, Rodrigo Vivi wrote: > > On Thu, Mar 02, 2023 at 03:53:37PM -0800, Rob Clark wrote: > >> From: Rob Clark > >> > > > > missing some wording here... > >

[Intel-gfx] [PATCH v9 15/15] drm/i915: Add deadline based boost support

2023-03-02 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644

[Intel-gfx] [PATCH v9 00/15] dma-fence: Deadline awareness

2023-03-02 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1

[Intel-gfx] [PATCH v8 16/16] drm/i915: Add deadline based boost support

2023-02-28 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644

[Intel-gfx] [PATCH v8 00/16] dma-fence: Deadline awareness

2023-02-28 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1

Re: [Intel-gfx] [PATCH v7 00/15] dma-fence: Deadline awareness

2023-02-28 Thread Rob Clark
On Tue, Feb 28, 2023 at 4:43 AM Bagas Sanjaya wrote: > > On Mon, Feb 27, 2023 at 11:35:06AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > This series adds a deadline hint to fences, so realtime deadlines > > such as vblank can be communicated to the fence sign

[Intel-gfx] [PATCH v7 15/15] drm/i915: Add deadline based boost support

2023-02-27 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644

[Intel-gfx] [PATCH v7 00/15] dma-fence: Deadline awareness

2023-02-27 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1

[Intel-gfx] [PATCH v6 15/15] drm/i915: Add deadline based boost support

2023-02-24 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644

[Intel-gfx] [PATCH v6 00/15] dma-fence: Deadline awareness

2023-02-24 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2023-02-22 Thread Rob Clark
On Wed, Feb 22, 2023 at 3:14 PM Rob Clark wrote: > > On Thu, Feb 16, 2023 at 3:12 AM Daniel Vetter wrote: > > > > The stuff never really worked, and leads to lots of fun because it > > out-of-order frees atomic states. Which upsets KASAN, among other > > things. &g

Re: [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2023-02-22 Thread Rob Clark
ences: https://bugzilla.kernel.org/show_bug.cgi?id=199425 > Cc: Maxime Ripard > Tested-by: Maxime Ripard > Cc: mikita.lip...@amd.com > Cc: Michel Dänzer > Cc: harry.wentl...@amd.com > Cc: Rob Clark > Cc: "Kazlauskas, Nicholas" > Cc: Dmitry Osipenko > C

[Intel-gfx] [PATCH v5 14/14] drm/i915: Add deadline based boost support

2023-02-20 Thread Rob Clark
From: Rob Clark v2: rebase Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/i915_request.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 7503dcb9043b..44491e7e214c 100644

[Intel-gfx] [PATCH v5 00/14] dma-fence: Deadline awareness

2023-02-20 Thread Rob Clark
From: Rob Clark This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-20 Thread Rob Clark
On Mon, Feb 20, 2023 at 8:51 AM Tvrtko Ursulin wrote: > > > On 20/02/2023 16:44, Tvrtko Ursulin wrote: > > > > On 20/02/2023 15:52, Rob Clark wrote: > >> On Mon, Feb 20, 2023 at 3:33 AM Tvrtko Ursulin > >> wrote: > >>> > >>&g

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-20 Thread Rob Clark
On Mon, Feb 20, 2023 at 8:44 AM Tvrtko Ursulin wrote: > > > On 20/02/2023 15:52, Rob Clark wrote: > > On Mon, Feb 20, 2023 at 3:33 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 17/02/2023 20:45, Rodrigo Vivi wrote: > > [snip] > >

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-20 Thread Rob Clark
On Mon, Feb 20, 2023 at 3:33 AM Tvrtko Ursulin wrote: > > > On 17/02/2023 20:45, Rodrigo Vivi wrote: > > On Fri, Feb 17, 2023 at 09:00:49AM -0800, Rob Clark wrote: > >> On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin > >> wrote: > >>> >

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-20 Thread Rob Clark
On Mon, Feb 20, 2023 at 4:22 AM Tvrtko Ursulin wrote: > > > On 17/02/2023 17:00, Rob Clark wrote: > > On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin > > wrote: > > [snip] > > >>> adapted from your patches.. I think the basic idea of deadlines > &

Re: [Intel-gfx] [RFC 6/9] drm/syncobj: Mark syncobj waits as external waiters

2023-02-20 Thread Rob Clark
On Mon, Feb 20, 2023 at 5:19 AM Tvrtko Ursulin wrote: > > > On 18/02/2023 19:56, Rob Clark wrote: > > On Thu, Feb 16, 2023 at 2:59 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Use the previously added dma

[Intel-gfx] [PATCH v4 14/14] drm/i915: Add deadline based boost support

2023-02-18 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- This should probably be re-written by someone who knows the i915 request/timeline stuff better, to deal with non-immediate deadlines. But as-is I think this should be enough to handle the case where we want syncobj waits to trigger boost. drivers

[Intel-gfx] [PATCH v4 00/14] dma-fence: Deadline awareness

2023-02-18 Thread Rob Clark
From: Rob Clark This series adds deadline awareness to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1

Re: [Intel-gfx] [RFC 6/9] drm/syncobj: Mark syncobj waits as external waiters

2023-02-18 Thread Rob Clark
On Thu, Feb 16, 2023 at 2:59 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Use the previously added dma-fence tracking of explicit waiters. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/drm_syncobj.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [Intel-gfx] [RFC 5/9] dma-fence: Track explicit waiters

2023-02-18 Thread Rob Clark
On Thu, Feb 16, 2023 at 3:00 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Track how many callers are explicity waiting on a fence to signal and > allow querying that via new dma_fence_wait_count() API. > > This provides infrastructure on top of which generic "waitboost" concepts > can

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-17 Thread Rob Clark
On Fri, Feb 17, 2023 at 12:45 PM Rodrigo Vivi wrote: > > On Fri, Feb 17, 2023 at 09:00:49AM -0800, Rob Clark wrote: > > On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin > > wrote: > > > > > > > > > On 17/02/2023 14:55, Rob Clark wrote: > >

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-17 Thread Rob Clark
On Fri, Feb 17, 2023 at 8:03 AM Tvrtko Ursulin wrote: > > > On 17/02/2023 14:55, Rob Clark wrote: > > On Fri, Feb 17, 2023 at 4:56 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 16/02/2023 18:19, Rodrigo Vivi wrote: > >>> On Tue, Feb

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-17 Thread Rob Clark
On Fri, Feb 17, 2023 at 4:56 AM Tvrtko Ursulin wrote: > > > On 16/02/2023 18:19, Rodrigo Vivi wrote: > > On Tue, Feb 14, 2023 at 11:14:00AM -0800, Rob Clark wrote: > >> On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > >> wrote: > >>> > >&

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-16 Thread Rob Clark
On Thu, Feb 16, 2023 at 10:20 AM Rodrigo Vivi wrote: > > On Tue, Feb 14, 2023 at 11:14:00AM -0800, Rob Clark wrote: > > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > > wrote: > > > > > > From: Tvrtko Ursulin > > > > > > In i915 we have th

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-16 Thread Rob Clark
On Thu, Feb 16, 2023 at 3:19 AM Tvrtko Ursulin wrote: > > > On 14/02/2023 19:14, Rob Clark wrote: > > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> In i915 we have this concep

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-14 Thread Rob Clark
On Tue, Feb 14, 2023 at 11:14 AM Rob Clark wrote: > > On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin > wrote: > > > > From: Tvrtko Ursulin > > > > In i915 we have this concept of "wait boosting" where we give a priority > > boost > > for

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-14 Thread Rob Clark
On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > In i915 we have this concept of "wait boosting" where we give a priority boost > for instance to fences which are actively waited upon from userspace. This has > it's pros and cons and can certainly be discussed

Re: [Intel-gfx] [PATCH] drm/i915: Move fd_install after last use of fence

2023-02-03 Thread Rob Clark
On Fri, Feb 3, 2023 at 8:49 AM Rob Clark wrote: > > From: Rob Clark > > Because eb_composite_fence_create() drops the fence_array reference > after creation of the sync_file, only the sync_file holds a ref to the > fence. But fd_install() makes that reference visable to users

[Intel-gfx] [PATCH] drm/i915: Move fd_install after last use of fence

2023-02-03 Thread Rob Clark
From: Rob Clark Because eb_composite_fence_create() drops the fence_array reference after creation of the sync_file, only the sync_file holds a ref to the fence. But fd_install() makes that reference visable to userspace, so it must be the last thing we do with the fence. Signed-off-by: Rob

[Intel-gfx] [PATCH] drm/i915: Fix potential bit_17 double-free

2023-01-27 Thread Rob Clark
From: Rob Clark A userspace with multiple threads racing I915_GEM_SET_TILING to set the tiling to I915_TILING_NONE could trigger a double free of the bit_17 bitmask. (Or conversely leak memory on the transition to tiled.) Move allocation/free'ing of the bitmask within the section protected

[Intel-gfx] [PATCH] drm/i915: Avoid potential vm use-after-free

2023-01-19 Thread Rob Clark
From: Rob Clark Adding the vm to the vm_xa table makes it visible to userspace, which could try to race with us to close the vm. So we need to take our extra reference before putting it in the table. Signed-off-by: Rob Clark --- Note, you could list commit e1a7ab4fca0c ("drm/i915: R

Re: [Intel-gfx] [PATCH] drm/i915: Fix potential context UAFs

2023-01-04 Thread Rob Clark
On Wed, Jan 4, 2023 at 1:34 AM Tvrtko Ursulin wrote: > > > On 03/01/2023 23:49, Rob Clark wrote: > > From: Rob Clark > > > > gem_context_register() makes the context visible to userspace, and which > > point a separate thread can trigger the I915_GEM_CONT

[Intel-gfx] [PATCH] drm/i915: Fix potential context UAFs

2023-01-03 Thread Rob Clark
From: Rob Clark gem_context_register() makes the context visible to userspace, and which point a separate thread can trigger the I915_GEM_CONTEXT_DESTROY ioctl. So we need to ensure that nothing uses the ctx ptr after this. And we need to ensure that adding the ctx to the xarray is the *last

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-23 Thread Rob Clark
On Thu, Dec 22, 2022 at 2:29 PM Matthew Brost wrote: > > In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 > mapping between a drm_gpu_scheduler and drm_sched_entity. At first this > seems a bit odd but let us explain the reasoning below. > > 1. In XE the submission order from

[Intel-gfx] [PATCH] drm/i915: Remove __dma_fence_is_chain()

2022-06-28 Thread Rob Clark
From: Rob Clark drive-by cleanup Signed-off-by: Rob Clark --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index 319936f91ac5

Re: [Intel-gfx] [PATCH v6 00/22] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2022-06-28 Thread Rob Clark
On Tue, Jun 28, 2022 at 5:51 AM Dmitry Osipenko wrote: > > On 6/28/22 15:31, Robin Murphy wrote: > > ->8- > > [ 68.295951] == > > [ 68.295956] WARNING: possible circular locking dependency detected > > [ 68.295963] 5.19.0-rc3+ #400

Re: [Intel-gfx] [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-20 Thread Rob Clark
() On Thu, May 26, 2022 at 4:55 PM Dmitry Osipenko wrote: > > Introduce a common DRM SHMEM shrinker framework that allows to reduce > code duplication among DRM drivers by replacing theirs custom shrinker > implementations with the generic shrinker. > > In order to start using DRM SHMEM shrinker

Re: [Intel-gfx] [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-20 Thread Rob Clark
On Mon, Jun 20, 2022 at 7:09 AM Dmitry Osipenko wrote: > > On 6/19/22 20:53, Rob Clark wrote: > ... > >> +static unsigned long > >> +drm_gem_shmem_shrinker_count_objects(struct shrinker *shrinker, > >> +struct shrink_cont

Re: [Intel-gfx] [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-19 Thread Rob Clark
On Thu, May 26, 2022 at 4:55 PM Dmitry Osipenko wrote: > > Introduce a common DRM SHMEM shrinker framework that allows to reduce > code duplication among DRM drivers by replacing theirs custom shrinker > implementations with the generic shrinker. > > In order to start using DRM SHMEM shrinker

Re: [Intel-gfx] [PATCH v6 17/22] drm/shmem-helper: Add generic memory shrinker

2022-06-05 Thread Rob Clark
On Sun, Jun 5, 2022 at 9:47 AM Daniel Vetter wrote: > > On Fri, 27 May 2022 at 01:55, Dmitry Osipenko > wrote: > > > > Introduce a common DRM SHMEM shrinker framework that allows to reduce > > code duplication among DRM drivers by replacing theirs custom shrinker > > implementations with the

  1   2   3   >