Re: [Intel-gfx] [PATCH] drm/i915: Add some more bits to CURSOR_POS_MASK

2015-11-25 Thread Robert Fekete
On ons, 2015-11-18 at 10:17 +0100, Daniel Vetter wrote: > On Wed, Nov 04, 2015 at 10:59:28AM +0100, Patrik Jakobsson wrote: > > On Wed, Nov 04, 2015 at 10:35:19AM +0100, Robert Fekete wrote: > > > The old value of 0x7FF will wrap the position at 2048 giving wrong > > >

[Intel-gfx] [PATCH] drm/i915: Add some more bits to CURSOR_POS_MASK

2015-11-04 Thread Robert Fekete
-by: Robert Fekete <robert.fek...@linux.intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 894253228947..f351f46f8cb9 100644 --- a/drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH] drm: Describe the Rotation property bits.

2015-11-02 Thread Robert Fekete
On mån, 2015-11-02 at 16:50 +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2015 at 03:24:15PM +0100, Robert Fekete wrote: > > Adds clarification of the rotation property bits. I.e. rotation is > > Counter clockwise and that reflects are applied before any rotation. >

[Intel-gfx] [PATCH] drm: Describe the Rotation property bits.

2015-11-02 Thread Robert Fekete
Adds clarification of the rotation property bits. I.e. rotation is Counter clockwise and that reflects are applied before any rotation. Signed-off-by: Robert Fekete <robert.fek...@linux.intel.com> --- include/drm/drm_crtc.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[Intel-gfx] [PATCH v2] drm: Describe the Rotation property bits.

2015-11-02 Thread Robert Fekete
Adds clarification of the rotation property bits. I.e. rotation is counter clockwise and that reflects are applied before any rotation. v2: Refer to the define names instead of the property values. Signed-off-by: Robert Fekete <robert.fek...@linux.intel.com> --- inclu

Re: [Intel-gfx] [PATCH v2] drm/i915: Add extra plane information in debugfs.

2015-10-28 Thread Robert Fekete
On tis, 2015-10-27 at 17:31 +, Chris Wilson wrote: > On Tue, Oct 27, 2015 at 04:49:49PM +0100, Robert Fekete wrote: > > +static const char *plane_rotation(unsigned int rotation) > > +{ > > + static char buf[48]; > > + /* > > +* According to do

Re: [Intel-gfx] [PATCH] drm/i915: Add extra plane information in debugfs.

2015-10-27 Thread Robert Fekete
On mån, 2015-10-26 at 17:40 +0200, Ville Syrjälä wrote: > On Mon, Oct 26, 2015 at 03:56:33PM +0100, Robert Fekete wrote: > > Hi, thanks for reviewing Maarten. > > See comments inline... > > > > On mån, 2015-10-26 at 09:23 +0100, Maarten Lankhorst wrote: > > >

[Intel-gfx] [PATCH v3] drm/i915: Add extra plane information in debugfs.

2015-10-27 Thread Robert Fekete
for a commit. V2: Fixed comments from Maarten, Ville, and Chris. Fixed printing of 16.16 fixpoint, better rotation bitmask management and some minor fixes V3: Corrected state->src_x & 0x00ff to state->src_x & 0x... Signed-off-by: Robert Fekete <robert.fek...@linux.intel.com>

[Intel-gfx] [PATCH v2] drm/i915: Add extra plane information in debugfs.

2015-10-27 Thread Robert Fekete
for a commit. V2: Fixed comments from Maarten, Ville, and Chris. Fixed printing of 16.16 fixpoint, better rotation bitmask management and some minor fixes Signed-off-by: Robert Fekete <robert.fek...@linux.intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 109 +

Re: [Intel-gfx] [PATCH v2] drm/i915: Add extra plane information in debugfs.

2015-10-27 Thread Robert Fekete
Do not review this one! I just found that I forgot to and(&) state->src_x with 0x. V3 coming in a sec or two. BR /Robert F On tis, 2015-10-27 at 16:49 +0100, Robert Fekete wrote: > Extends i915_display_info so that for each active crtc also print > all planes associated

Re: [Intel-gfx] [PATCH] drm/i915: Add extra plane information in debugfs.

2015-10-26 Thread Robert Fekete
Hi, thanks for reviewing Maarten. See comments inline... On mån, 2015-10-26 at 09:23 +0100, Maarten Lankhorst wrote: > Op 23-10-15 om 16:24 schreef Robert Fekete: > > Extends i915_display_info so that for each active crtc also print > > all planes associated with the pipe. T

[Intel-gfx] [PATCH] drm/i915: Add extra plane information in debugfs.

2015-10-23 Thread Robert Fekete
for a commit. Signed-off-by: Robert Fekete <robert.fek...@linux.intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 124 +++- 1 file changed, 122 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c