Re: [Intel-gfx] [PATCH 0/1] DG2 DMC Support

2022-05-03 Thread Rodrigo Vivi
go on a RIL system showed promising > results when dc5 was completely diabled and i915 took only dc9 paths. > > Sending this so we can check the CI results to confirm the > findings from local testing which will hopefully help narrow > down the root cause of MMIO BAR lost issue >

Re: [Intel-gfx] [PATCH 04/11] drm/i915/pvc: Read correct RP_STATE_CAP register

2022-05-02 Thread Rodrigo Vivi
On Mon, May 02, 2022 at 09:34:10AM -0700, Matt Roper wrote: > The SoC registers, including RP_STATE_CAP, have moved to a new location > in GTTMMADR on Ponte Vecchio. We need to update the register offset > accordingly. > > Cc: Rodrigo Vivi > Signed-off-by: Matt Roper Reviewe

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-05-02 Thread Rodrigo Vivi
minate needless #defines (Rodrigo) > > Cc: Rodrigo Vivi > Cc: Jani Nikula > Cc: Andi Shyti > Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/hsw_ips.c| 4 +- > drivers/gpu/drm/i915/display/intel_bw.c | 6 +- >

Re: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-29 Thread Rodrigo Vivi
his earlier. but some comments below... > > Cc: Rodrigo Vivi > Cc: Jani Nikula > Cc: Andi Shyti > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/i915/gt/intel_gt.c | 17 +++ > drivers/gpu/drm/i915/gt/intel_gt.h | 2 + > drivers/gpu/drm/i915/i915_driver

Re: [Intel-gfx] [PATCH 9/9] drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs

2022-04-29 Thread Rodrigo Vivi
On Thu, Apr 28, 2022 at 05:39:43PM -0700, Ashutosh Dixit wrote: > Add the following sysfs file to gt/gtN/.defaults: > * media_freq_factor > > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH 8/9] drm/i915/gt: Expose per-gt RPS defaults in sysfs

2022-04-29 Thread Rodrigo Vivi
ow userspace to revert to default values when needed. > > This patch adds the following sysfs files to gt/gtN/.defaults: > * default_min_freq_mhz > * default_max_freq_mhz > * default_boost_freq_mhz > > Cc: Rodrigo Vivi > Cc: Andi Shyti > Cc: Joonas Lahtinen > Signed-off

Re: [Intel-gfx] [PATCH 4/4] drm/i915/huc: Don't fail the probe if HuC init fails

2022-04-27 Thread Rodrigo Vivi
ehavior. > > Signed-off-by: Daniele Ceraolo Spurio Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 +- > drivers/gpu/drm/i915/gt/uc/intel_uc.c | 11 ++- > 2 files changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH 1/4] drm/i915/huc: check HW directly for HuC auth status

2022-04-27 Thread Rodrigo Vivi
t;status.mask) == huc->status.value; oh, these variable names look so generic, while it looks like the only usage for them is for mask = loaded and value = loaded... But anyway it is better this indirection with some generic name than duplicating the definition depending on platform in here...

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs

2022-04-21 Thread Rodrigo Vivi
ch adds the following sysfs files to gt/gtN sysfs: > * media_freq_factor > * media_freq_factor.scale > > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen > Signed-off-by: Dale B Stimson > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/i915/gt/intel_gt_regs.h |

Re: [Intel-gfx] [PATCH] drm/i915: Disable DC5 before going to DC9

2022-04-20 Thread Rodrigo Vivi
On Wed, Apr 20, 2022 at 10:21:19PM +0300, Imre Deak wrote: > On Wed, Apr 20, 2022 at 03:09:21PM -0400, Rodrigo Vivi wrote: > > According to BSPec: > > Sequence to Allow DC9: > > 1. Follow Sequence to Disallow DC5. > > > > which is: > &g

[Intel-gfx] [PATCH] drm/i915: Disable DC5 before going to DC9

2022-04-20 Thread Rodrigo Vivi
since DC9 is a software thing, it is better to disable DC5 before to avoid any conflict. And respect the spec to avoid potential future issues. Cc: Imre Deak Cc: Anshuman Gupta Cc: Anusha Srivatsa Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++ 1 file

Re: [Intel-gfx] [PATCH 4/8] drm/i915/pcode: Add a couple of pcode helpers

2022-04-15 Thread Rodrigo Vivi
On Wed, Apr 13, 2022 at 11:11:05AM -0700, Ashutosh Dixit wrote: > Add a couple of helpers to help formatting pcode commands and improve code > readability. > > Cc: Mike Ruhl > Cc: Rodrigo Vivi > Original-author: Dale B Stimson The right thing to do here is to git commit --am

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Introduce has_media_ratio_mode

2022-04-15 Thread Rodrigo Vivi
gt; identify these platforms and set it for XEHPSDV and DG2/ATS-M. > > Cc: Rodrigo Vivi > Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.h | 2 ++ > drivers/gpu/drm/i915/i915_pci.c | 2 ++ > drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 3/8] drm/i915/pcode: Extend pcode functions for multiple gt's

2022-04-15 Thread Rodrigo Vivi
On Thu, Apr 14, 2022 at 03:31:07PM -0700, Dixit, Ashutosh wrote: > On Thu, 14 Apr 2022 06:28:57 -0700, Jani Nikula wrote: > > > > On Wed, 13 Apr 2022, Ashutosh Dixit wrote: > > > Each gt contains an independent instance of pcode. Extend pcode functions > > > to interface with pcode on different

Re: [Intel-gfx] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-14 Thread Rodrigo Vivi
On Thu, Apr 14, 2022 at 03:58:02PM +, Sean Paul wrote: > On Tue, Apr 12, 2022 at 09:25:59AM -0400, Rodrigo Vivi wrote: > > On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > > > From: Sean Paul > > > > > > This patch updates the connector's

[Intel-gfx] [PATCH] drm/i915: Reserving some Multi-thread forcewake bits.

2022-04-13 Thread Rodrigo Vivi
for PCODE. Bit 4: Let's reserve for PSMI. Cc: Tilak Tangudu Cc: Mika Kuoppala Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/d

Re: [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2

2022-04-13 Thread Rodrigo Vivi
SPLAY_VER13_DMC_MAX_FW_SIZE; > + } else if (IS_ALDERLAKE_P(dev_priv)) { > dmc->fw_path = ADLP_DMC_PATH; > dmc->required_version = ADLP_DMC_VERSION_REQUIRED; > dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE; probably worth to rename the dev_priv to i915 on these functions you are touching in here... anyway: Reviewed-by: Rodrigo Vivi > -- > 2.25.1 >

Re: [Intel-gfx] [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:29PM +, Sean Paul wrote: > From: Sean Paul > > Rebased set from November. Fixed a nit from Stephen in the msm patch and > moved hdcp registers into the trogdor dtsi file to avoid differences > with sc7180-based windows devices. The set is 4 patches lighter since

Re: [Intel-gfx] [PATCH v5 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:34PM +, Sean Paul wrote: > From: Sean Paul > > Stick all of the setup for HDCP into a dedicated function. No functional > change, but this will facilitate moving HDCP logic into helpers. Reviewed-by: Rodrigo Vivi > > Acked-by: Jani Ni

Re: [Intel-gfx] [PATCH v5 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:35PM +, Sean Paul wrote: > From: Sean Paul > > The shim functions return error codes, but they are discarded in > intel_hdcp.c. This patch plumbs the return codes through so they are > properly handled. Reviewed-by: Rodrigo Vivi > >

Re: [Intel-gfx] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > From: Sean Paul > > This patch updates the connector's property value in 2 cases which were > previously missed: > > 1- Content type changes. The value should revert back to DESIRED from >ENABLED in case the driver must

Re: [Intel-gfx] [PATCH v5 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2022-04-12 Thread Rodrigo Vivi
at the driver try CP enable. > + */ > + if (new_hdcp == DRM_MODE_CONTENT_PROTECTION_DESIRED && > + new_conn_state->crtc != old_conn_state->crtc) > + return true; I'm with the feeling that this chunk should deserve a separated patch. But th

Re: [Intel-gfx] [PATCH v5 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:30PM +, Sean Paul wrote: > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the > code when moving it over. Reviewed-by: Rodrigo Viv

Re: [Intel-gfx] Backlight Regression in i915 that isn't handled appropriately afaics

2022-03-25 Thread Rodrigo Vivi
On Thu, Mar 24, 2022 at 04:02:41PM +0100, Thorsten Leemhuis wrote: > Hi i915 maintainers, this is your Linux kernel regression tracker! > What's up with the following regression? > > https://gitlab.freedesktop.org/drm/intel/-/issues/5284 > > That report it more than two weeks old now, but seems

Re: [Intel-gfx] [PATCH] docs: gpu: i915.rst: Update DRRS functions names

2022-03-25 Thread Rodrigo Vivi
On Fri, Mar 25, 2022 at 08:10:59PM +0200, Ville Syrjälä wrote: > On Fri, Mar 25, 2022 at 08:34:36AM -0700, José Roberto de Souza wrote: > > intel_drrs_enable and intel_drrs_disable where renamed to > > intel_drrs_activate and intel_drrs_deactivate in commit > > 54903c7a6b40 ("drm/i915:

Re: [Intel-gfx] [PATCH v11 4/5] mei: gsc: add runtime pm handlers

2022-03-22 Thread Rodrigo Vivi
On Tue, Mar 15, 2022 at 03:11:56PM +0200, Alexander Usyskin wrote: > From: Tomas Winkler > > Implement runtime handlers for mei-gsc, to track > idle state of the device properly. > > CC: Rodrigo Vivi > Signed-off-by: Tomas Winkler > Signed-off-by: Alexander Usyskin

Re: [Intel-gfx] [PATCH v10 4/5] mei: gsc: add runtime pm handlers

2022-03-10 Thread Rodrigo Vivi
On Tue, Mar 08, 2022 at 06:36:53PM +0200, Alexander Usyskin wrote: > From: Tomas Winkler > > Implement runtime handlers for mei-gsc, to track > idle state of the device properly. > > CC: Rodrigo Vivi > Signed-off-by: Tomas Winkler > Signed-off-by: Alexander Usyskin &

Re: [Intel-gfx] [PATCH] drm/i915/display: Allow users to disable PSR2

2022-02-24 Thread Rodrigo Vivi
On Thu, Feb 24, 2022 at 02:15:44PM +, Souza, Jose wrote: > + Rodrigo > > On Thu, 2022-02-24 at 15:11 +0200, Ville Syrjälä wrote: > > On Thu, Feb 24, 2022 at 03:06:30PM +0200, Ville Syrjälä wrote: > > > On Thu, Feb 24, 2022 at 01:01:24PM +, Souza, Jose wrote: > > > > On Thu, 2022-02-24 at

[Intel-gfx] [PULL] drm-intel-next

2022-02-23 Thread Rodrigo Vivi
lane_vma to min_page_size of stolen mem drm/i915: More gt idling time with guc submission Rodrigo Vivi (1): Merge tag 'drm-intel-gt-next-2022-02-17' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-next Tejas Upadhyay (1): drm/i915/adl-n: Add PCH Support for Alder La

Re: [Intel-gfx] [PATCH] drm/i915/gt: use get_reset_domain() helper

2022-02-18 Thread Rodrigo Vivi
On Thu, Feb 17, 2022 at 06:02:23PM +0530, Tejas Upadhyay wrote: > We dont need to implement reset_domain in intel_engine > _setup(), but can be done as a helper. Implemented as > engine->reset_domain = get_reset_domain(). > > Cc: Rodrigo Vivi > Signed-off-by: Tejas Upadhy

Re: [Intel-gfx] [PATCH] iommu/vt-d: Add RPLS to quirk list to skip TE disabling

2022-02-18 Thread Rodrigo Vivi
instead of this if we should be listing the devices individually, probably using the DECLARE_PCI_FIXUP_HEADER or some other way to make it clear and explicit the opt-in on the quirk. Anyway, the addition of this one here is needed and the rest can be in a follow-up: Reviewed-by: Rodrigo Vivi Cc: Baolu Lu Cc: David Woodhouse Baolu, David, could we push this through drm-intel? > return; > > if (risky_device(dev)) > -- > 2.34.1 >

Re: [Intel-gfx] [PATCH] drm/i915/gt: prepare reset based on reset domain

2022-02-11 Thread Rodrigo Vivi
On Thu, Dec 16, 2021 at 09:52:26AM +, Tvrtko Ursulin wrote: > > > On 09/12/2021 12:01, Tejas Upadhyay wrote: > > Most code paths does full reset with preparing all > > engines for reset except below two : > > > > 1. Single engine reset needs to prepare engines for > > reset based on its

[Intel-gfx] [PULL] drm-intel-next

2022-02-08 Thread Rodrigo Vivi
/i915/gvt: Constify intel_gvt_sched_policy_ops drm/i915/gvt: Constify gvt_mmio_block drm/i915/gvt: Constify cmd_interrupt_events drm/i915/gvt: Constify formats drm/i915/gvt: Constify gtt_type_table_entry drm/i915/gvt: Constify vgpu_types Rodrigo Vivi (2): Merge tag

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix some error codes in __cancel_reset()

2022-02-04 Thread Rodrigo Vivi
On Fri, Feb 04, 2022 at 06:45:51PM +0100, Andi Shyti wrote: > Hi Dan, > > > There were two error paths in __cancel_reset() which return success > > instead of a negative error code as expected. > > > > Fixes: 4e6835466771 ("drm/i915/selftests: Add a cancel request selftest > > that triggers a

Re: [Intel-gfx] [PATCH v3 1/3] drm: Stop spamming log with drm_cache message

2022-02-02 Thread Rodrigo Vivi
They shouldn't be seen on anything properly supported. > > 2) This seems all to be a layer below drm anyway and could even be used > in places outside easy access to a drm pointer. > > So, it seems the benefit of using the subsystem-specific drm_WARN_ONCE > doesn't justify the

Re: [Intel-gfx] [PATCH] drm/i915: delete shadow "ret" variable

2022-01-27 Thread Rodrigo Vivi
On Thu, Jan 27, 2022 at 11:51:15AM +0300, Dan Carpenter wrote: > This "ret" declaration shadows an existing "ret" variable at the top of > the function. Delete it. > > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi and pushing right now > --- >

Re: [Intel-gfx] [RFC PATCH] drm/i915: Remove all frontbuffer tracking calls from the gem code

2022-01-27 Thread Rodrigo Vivi
On Thu, Jan 27, 2022 at 09:20:14AM +0100, Maarten Lankhorst wrote: > Op 26-01-2022 om 14:09 schreef Jouni Högander: > > We should now rely on userspace doing dirtyfb. There is no > > need to have separate frontbuffer tracking hooks in gem code. > > > > This patch is removing all frontbuffer

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/pxp: Hold RPM wakelock during PXP unbind

2022-01-13 Thread Rodrigo Vivi
eparing to enter system sleep state S5 > reboot: Power down > > Changes since v1: > - Rebase to latest drm-tip > > Fixes: 0cfab4cb3c4e ("drm/i915/pxp: Enable PXP power management") > Suggested-by: Lee Shawn C > Signed-off-by: Juston Li > Reviewed-by: Daniel

Re: [Intel-gfx] [PATCH v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-13 Thread Rodrigo Vivi
On Wed, Jan 12, 2022 at 05:28:29PM -0800, Lucas De Marchi wrote: > On Wed, Jan 12, 2022 at 07:06:45PM -0600, Bjorn Helgaas wrote: > > On Wed, Jan 12, 2022 at 04:21:28PM -0800, Lucas De Marchi wrote: > > > On Wed, Jan 12, 2022 at 06:08:05PM -0600, Bjorn Helgaas wrote: > > > > On Wed, Jan 12, 2022

Re: [Intel-gfx] [PATCH v3 00/11] Start cleaning up register definitions

2022-01-13 Thread Rodrigo Vivi
On Thu, Jan 13, 2022 at 06:58:47PM +0200, Jani Nikula wrote: > On Wed, 12 Jan 2022, Rodrigo Vivi wrote: > > I understand that I'm late to the fun here, but I got myself wondering if > > we couldn't separated the registers in a "regs" directory > > and find some wa

Re: [Intel-gfx] [PATCH v3 00/11] Start cleaning up register definitions

2022-01-12 Thread Rodrigo Vivi
ters (engine registers, SNPS PHY registers) off to their own header > files. > > v3: > - Split out i915_reg_defs.h in its own patch > - Also split out combo PHY and MG/DKL PHY sets of registers > > Cc: Jani Nikula > Cc: Ville Syrjälä > Cc: Rodrigo Vivi > Cc: Luca

Re: [Intel-gfx] [GIT PULL] GVT next changes for drm-intel-next-queued

2022-01-11 Thread Rodrigo Vivi
On Tue, Jan 11, 2022 at 06:08:28AM -0500, Wang, Zhi A wrote: > On 1/11/22 6:08 AM, Wang, Zhi A wrote: > > On 1/11/2022 12:52 AM, Vivi, Rodrigo wrote: > >> On Fri, 2022-01-07 at 14:43 +, Wang, Zhi A wrote: > >>> Hi folks: > >>> > >>> Happy holidays! This pull mostly contains the code re-factors

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-10 Thread Rodrigo Vivi
On Mon, Jan 10, 2022 at 11:32:11AM -0600, Bjorn Helgaas wrote: > On Mon, Jan 10, 2022 at 12:11:36PM -0500, Rodrigo Vivi wrote: > > On Fri, Jan 07, 2022 at 08:57:32PM -0600, Bjorn Helgaas wrote: > > > On Fri, Jan 07, 2022 at 01:05:16PM -0800, Lucas De Marchi wrote: > > >

Re: [Intel-gfx] [PATCH v3 2/3] x86/quirks: Improve line wrap on quirk conditions

2022-01-10 Thread Rodrigo Vivi
ff-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > arch/x86/kernel/early-quirks.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c > index 8b689c2b8cc7..df34963e23bf 100

Re: [Intel-gfx] [PATCH v3 3/3] x86/quirks: Fix stolen detection with integrated + discrete GPU

2022-01-10 Thread Rodrigo Vivi
able. > > > > Signed-off-by: Lucas De Marchi > > I don't know the details of stolen memory, but the implementation of > this quirk looks good to me. Very nice that it's now very clear > exactly what the change is. Reviewed-by: Rodrigo Vivi Bjorn, ack to merge through

[Intel-gfx] [PULL] drm-intel-fixes

2021-12-15 Thread Rodrigo Vivi
Hi Dave and Daniel, First, a heads up that I will be on vacation for the next weeks so Jani will cover the drm-intel-fixes for the next rounds. Now, here goes drm-intel-fixes-2021-12-15: Fix a bound check in the DMC fw load. Thanks, Rodrigo. The following changes since commit

[Intel-gfx] [PULL] drm-intel-fixes

2021-12-09 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-12-09: A fix to a error pointer dereference in gem_execbuffer and a fix for GT initialization when GuC/HuC are used on ICL. Thanks, Rodrigo. The following changes since commit 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1: Linux 5.16-rc4

Re: [Intel-gfx] [PATCH V2] drm/i915/gt: Use hw_engine_masks as reset_domains

2021-12-07 Thread Rodrigo Vivi
ZE(engine_reset_domains) || > +!engine_reset_domains[id]); > + engine->reset_domain = engine_reset_domains[id]; > + } probably better if we could have a function for this. engine->reset_domain = intel_reset_domain()... or something like that... b

[Intel-gfx] [PULL] drm-intel-fixes

2021-12-02 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-12-02: - Fixing a regression where the backlight brightness control stopped working. - Fix the Intel HDR backlight support detection. - Reverting a w/a to fix a gpu Hang in TGL. The w/a itself was also for a hang, but in a much rarer scenario.

[Intel-gfx] [PULL] drm-intel-fixes

2021-11-24 Thread Rodrigo Vivi
Hi Dave and Daniel, Only one fix for this round. Sending earlier today due to Holiday in US tomorrow. Here goes drm-intel-fixes-2021-11-24: Fix wakeref handling of PXP suspend. Thanks, Rodrigo. The following changes since commit 136057256686de39cc3a07c2e39ef6bc43003ff6: Linux 5.16-rc2

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Spread virtual engines over idle engines

2021-11-24 Thread Rodrigo Vivi
On Wed, Nov 24, 2021 at 08:55:39AM -0500, Rodrigo Vivi wrote: > On Wed, Nov 24, 2021 at 08:56:52AM +, Tvrtko Ursulin wrote: > > > > On 23/11/2021 19:52, Rodrigo Vivi wrote: > > > On Tue, Nov 23, 2021 at 09:39:25AM +, Tvrtko Ursulin wrote: > > > >

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Spread virtual engines over idle engines

2021-11-24 Thread Rodrigo Vivi
On Wed, Nov 24, 2021 at 08:56:52AM +, Tvrtko Ursulin wrote: > > On 23/11/2021 19:52, Rodrigo Vivi wrote: > > On Tue, Nov 23, 2021 at 09:39:25AM +, Tvrtko Ursulin wrote: > > > > > > On 17/11/2021 22:49, Vinay Belgaumkar wrote: > > > > From: Chris

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gt: Spread virtual engines over idle engines

2021-11-23 Thread Rodrigo Vivi
he initial implementation vs only once like the in 90a987205c6c). If this one is really fixing the regression by itself: Acked-by: Rodrigo Vivi on this patch here. But I still don't want to take the risk with touching the freq with race to idle, until not convinced that it is absolutely needed

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gt: Improve "race-to-idle" at low frequencies

2021-11-22 Thread Rodrigo Vivi
On Wed, Nov 17, 2021 at 02:49:55PM -0800, Vinay Belgaumkar wrote: > From: Chris Wilson > > While the power consumption is proportional to the frequency, there is > also a static draw for active gates. The longer we are able to powergate > (rc6), the lower the static draw. Thus there is a

Re: [Intel-gfx] [PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-22 Thread Rodrigo Vivi
> > platforms(Syrjala Ville) > > > > v3: Change commit message(Nikula Jani) > It would require to reorder the commit log, version log > need to move after commit message. Well noticed. I changed while pushing. So, for the record: Reviewed-by: Rodrigo Vivi Signed-off-by: Ro

Re: [Intel-gfx] [PATCH] drm/i915/pxp: Trybot - run CI with PXP and MEI_PXP enabled

2021-11-22 Thread Rodrigo Vivi
On Mon, Nov 22, 2021 at 09:57:30AM +0530, Tejas Upadhyay wrote: > Please do not merge this is trybot patch to run CI with PXP > and MEI PXP enabled to get premegre results for > https://patchwork.freedesktop.org/series/96658/#rev3 change. Please don't send this kind of tests to intel-gfx ml.

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dsi: split out icl_dsi.h

2021-11-22 Thread Rodrigo Vivi
On Mon, Nov 22, 2021 at 01:15:04PM +0200, Jani Nikula wrote: > Follow the convention of corresponding .h for .c. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi for the series > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 1 + > drivers/gpu/drm/i915

[Intel-gfx] [PULL] drm-intel-fixes

2021-11-18 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-11-18: One quick fix for return error handling, one fix for ADL-P display and one revert targeting stable 5.4, for TGL's DSI display clocks Thanks, Rodrigo. The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf: Linux

Re: [Intel-gfx] [PATCH] drm/i915/adlp: Remove require_force_probe protection

2021-11-16 Thread Rodrigo Vivi
rmtip.html? hmm... I could swear that I had seen the ADL-P green there a few days ago as well... But right now I couldn't see ADL-P there... So that fails on having a *reliable* green CI picture... Any idea why that is down at this moment? > > Cc: Rodrigo Vivi > > Signed-off-by

Re: [Intel-gfx] [PATCH] drm/i915/guc: fix NULL vs IS_ERR() checking

2021-11-16 Thread Rodrigo Vivi
On Tue, Nov 16, 2021 at 02:49:16PM +0300, Dan Carpenter wrote: > The intel_engine_create_virtual() function does not return NULL. It > returns error pointers. > > Fixes: e5e32171a2cf ("drm/i915/guc: Connect UAPI to GuC multi-lrc interface") > Signed-off-by: Dan Carpent

Re: [Intel-gfx] [PATCH] drm/i915/pxp: fix includes for headers in include/drm

2021-11-16 Thread Rodrigo Vivi
On Tue, Nov 16, 2021 at 03:58:13PM +0200, Jani Nikula wrote: > Use <> not "" for including headers from include/drm. > > Signed-off-by: Jani Nikula Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/pxp/intel_pxp_session.c | 3 ++- > drivers/gpu/dr

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-16 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 09:58:56AM -0500, Rodrigo Vivi wrote: > On Mon, Nov 15, 2021 at 01:44:57PM +0200, Jani Nikula wrote: > > On Mon, 15 Nov 2021, Tilak Tangudu wrote: > > > > The actual commit message with explanations why it will work now and > > didn't work bef

Re: [Intel-gfx] [PATCH] drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-16 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 02:20:36PM -0500, Rodrigo Vivi wrote: > On Mon, Nov 15, 2021 at 09:10:54PM +0530, Tilak Tangudu wrote: > > s2idle and runtime pm puts the pci gfx device in D3Hot, ACPI runtime > > monitors the pci tree,if it sees complete tree as D3Hot,it transitions

Re: [Intel-gfx] [PATCH] drm/i915: Disable D3Cold in s2idle and runtime pm

2021-11-15 Thread Rodrigo Vivi
ernal experiments for s3/s4 failed with that and this approach here was the safest one, so let's move with this and prevent the d3cold for now and then allow the runtime_pm autosuspend enabled by default everywhere. Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.c | 19

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Clean up PIPEMISC register defines

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:06PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for PIPEMISC* bits, and while at it > fill in the missing dithering bits since we already had some > of them defined. > > Signed-off-by: Ville Syrjälä > --- >

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Clean up CRC register defines

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:11PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for the CRC registers. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_reg.h | 77 ++

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Clean up DPINVGTT/VLV_DPFLIPSTAT bits

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:12PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for DPINVTT/VLV_DPFLIPSTAT bits. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > drivers/

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Clean up FPGA_DBG/CLAIM_ER bits

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:13PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use REG_BIT() & co. for FPGA_DBG/CLAIM_ER bits. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_reg.h | 8 > 1 file

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Bump DSL linemask to 20 bits

2021-11-15 Thread Rodrigo Vivi
On Fri, Nov 12, 2021 at 09:38:05PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Since tgl PIPE_DSL has 20 bits for the scanline. Let's bump our > definition to match. And while at it let's also add the define > for the current field readback. > > We can also get rid of the gen2 vs.

Re: [Intel-gfx] [PATCH] drm/i915: Don't read query SSEU for non-existent slice 0 on old platforms

2021-11-15 Thread Rodrigo Vivi
s move the DSS lookup for a DG2 workaround into a helper function > that will only get called after we've already decided that we're on a > DG2 platform. > > Fixes: 645cc0b9d972 ("drm/i915/dg2: Add initial gt/ctx/engine workarounds") > Signed-off-by: Matt Roper Reviewed-by: R

Re: [Intel-gfx] [PATCH v2 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-15 Thread Rodrigo Vivi
On Mon, Nov 15, 2021 at 01:44:57PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Tilak Tangudu wrote: > > The actual commit message with explanations why it will work now and > didn't work before go here. The truth is that: 1. We don't have a good track of *all* the issues with the past

Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

2021-11-10 Thread Rodrigo Vivi
On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote: > On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote: > > Enable runtime pm autosuspend by default for gen12 and > > later versions. > > > > Signed-off-by: Tilak Tangudu > > --- > > drivers/gpu/drm/i915/intel_runtime_pm.c

[Intel-gfx] [PULL] drm-intel-next-fixes

2021-11-09 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2021-11-09: Couple Reverts, build fix, couple virtualization fixes, blank screen and other display rates fixes, and more. Four patches targeting stable in here. Display Fixes: - DP rates related fixes (Imre, Jani) - A Revert on disaling dual

Re: [Intel-gfx] [PATCH] drm/i915: pin: delete duplicate check in intel_pin_and_fence_fb_obj()

2021-11-09 Thread Rodrigo Vivi
On Tue, Nov 09, 2021 at 02:48:50PM +0300, Dan Carpenter wrote: > The "ret" variable is checked on the previous line so we know it's > zero. No need to check again. > > Signed-off-by: Dan Carpenter Reviewed-by: Rodrigo Vivi and pushed. thanks for the patch > --

Re: [Intel-gfx] [PATCH] drm/i915/display: Exit PSR when doing async flips

2021-11-01 Thread Rodrigo Vivi
On Fri, Oct 29, 2021 at 05:18:01PM -0700, José Roberto de Souza wrote: > Changing the buffer in the middle of the scanout then entering an > period of flip idleness will cause part of the previous buffer being > diplayed to user when PSR is enabled. > > So here disabling and scheduling activation

Re: [Intel-gfx] [PATCH] drm/i915: Clean-up bonding debug message.

2021-10-18 Thread Rodrigo Vivi
On Mon, Oct 18, 2021 at 11:24:21AM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Rodrigo Vivi wrote: > > We should stop using the gen name and the "+" to reference > > the newer platforms. > > And on this case specifically we can simplify the debug > >

Re: [Intel-gfx] [PATCH] drm/i915: Don't propagate the gen split confusion further

2021-10-18 Thread Rodrigo Vivi
On Mon, Oct 18, 2021 at 11:25:00AM +0300, Jani Nikula wrote: > On Fri, 15 Oct 2021, Rodrigo Vivi wrote: > > There's no such thing as gen13. It is either display 13 > > or graphics 13. Don't propagate the gen12 confusion > > further. > > Reviewed-by: Jani Nikula th

[Intel-gfx] [PULL] drm-intel-next

2021-10-15 Thread Rodrigo Vivi
Roper (1): drm/i915/uapi: Add comment clarifying purpose of I915_TILING_* values Rodrigo Vivi (2): Merge drm/drm-next into drm-intel-next drm/i915: Clean up PXP Kconfig info. Ville Syrjälä (14): drm/i915: Extend the async flip VT-d w/a to skl/bxt drm/i195: Make

[Intel-gfx] [PATCH] drm/i915: Don't propagate the gen split confusion further

2021-10-15 Thread Rodrigo Vivi
There's no such thing as gen13. It is either display 13 or graphics 13. Don't propagate the gen12 confusion further. Cc: Joonas Lahtinen Cc: Jani Nikula Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[Intel-gfx] [PATCH] drm/i915: Clean-up bonding debug message.

2021-10-15 Thread Rodrigo Vivi
We should stop using the gen name and the "+" to reference the newer platforms. And on this case specifically we can simplify the debug message even further. Cc: Jani Nikula Cc: Matthew Brost Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file

[Intel-gfx] [PATCH] drm/i915: Clean up PXP Kconfig info.

2021-10-15 Thread Rodrigo Vivi
the config menu entry, only in the help. Cc: Alan Previn Cc: Daniele Ceraolo Spurio Signed-off-by: Rodrigo Vivi Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drive

[Intel-gfx] [PATCH 4/5] drm/i915/gt: Random clean up of comments around display version.

2021-10-14 Thread Rodrigo Vivi
Cc: Joonas Lahtinen Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +- drivers/gpu/drm/i915/gt/intel_lrc.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drive

[Intel-gfx] [PATCH 5/5] drm/i915: Other random display and graphics version comment clean-ups

2021-10-14 Thread Rodrigo Vivi
We should prefer Graphics and Display version over the old global "gen" thing. Of course we are not changing functions and variables and the legacy there, but at least let's start to document things properly and set some good examples. Cc: Jani Nikula Cc: Joonas Lahtinen Signed-off-b

[Intel-gfx] [PATCH 3/5] drm/i915/display: Random clean up of comments around display version.

2021-10-14 Thread Rodrigo Vivi
We should prefer Display version over the old global "gen" thing. Of course we are not changing functions and variables and the legacy there, but at least let's start to document things properly and set some good examples. Cc: Jani Nikula Signed-off-by: Rodrigo Vivi --- drivers/gp

[Intel-gfx] [PATCH 1/5] drm/i915: Clean-up bonding debug message.

2021-10-14 Thread Rodrigo Vivi
We should stop using the gen name and the "+" to reference the newer platforms. And on this case specifically we can simplify the debug message even further. Cc: Jani Nikula Cc: Matthew Brost Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file

[Intel-gfx] [PATCH 2/5] drm/i915: Clean up PXP Kconfig info.

2021-10-14 Thread Rodrigo Vivi
the config menu entry, only in the help. Cc: Alan Previn Cc: Daniele Ceraolo Spurio Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 88

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Fix up skl_program_plane() pxp stuff

2021-10-07 Thread Rodrigo Vivi
LOR_CTL RMW in there. I guess because > force_black was computed way too late originally, but that is now > sorted. I would be hesitant in removing that, but since Juston confirmed that everything works well for him with these patches, it is fine by me. Great clean-up. Reviewed-by: Rodrigo Vivi

[Intel-gfx] [PULL] drm-intel-next

2021-10-04 Thread Rodrigo Vivi
ly access SFC_DONE when media domain is not fused off drm/i915/adl_p: Also disable underrun recovery with MSO drm/i915/dg2: Memory latency values from pcode must be doubled Radhakrishna Sripada (1): drm/i915: Update memory bandwidth parameters Rodrigo Vivi (2): Merge tag 'drm-misc-

Re: [Intel-gfx] [PATCH 3/3] drm/i915: remove some debug-only registers from MCHBAR

2021-09-24 Thread Rodrigo Vivi
On Tue, Jul 06, 2021 at 04:44:30PM -0700, Lucas De Marchi wrote: > On Thu, Nov 05, 2020 at 10:02:27AM +0200, Joonas Lahtinen wrote: > > Quoting Lucas De Marchi (2020-11-05 03:04:22) > > > On Wed, Nov 04, 2020 at 11:55:15AM +0200, Joonas Lahtinen wrote: > > > >Quoting Lucas De Marchi (2020-10-27

Re: [Intel-gfx] [PATCH v10 09/17] drm/i915/pxp: Implement PXP irq handler

2021-09-20 Thread Rodrigo Vivi
On Mon, Sep 20, 2021 at 04:18:10PM +, Teres Alexis, Alan Previn wrote: > > On Mon, 2021-09-20 at 12:04 -0400, Rodrigo Vivi wrote: > > On Fri, Sep 17, 2021 at 09:20:00PM -0700, Alan Previn wrote: > > > From: "Huang, Sean Z" > > > > > > The H

Re: [Intel-gfx] [PATCH v10 10/17] drm/i915/pxp: interfaces for using protected objects

2021-09-20 Thread Rodrigo Vivi
etween pxp_inval and > context_close, add usage examples (Rodrigo) can you please add the v10 change explanation here instead of only in the cover letter? (apply this comment to all the modified patches) > > Signed-off-by: Alan Previn > Signed-off-by: Daniele Ceraolo Spurio > Sign

Re: [Intel-gfx] [PATCH v10 09/17] drm/i915/pxp: Implement PXP irq handler

2021-09-20 Thread Rodrigo Vivi
work function. > v4: improve comments, simplify wait logic (Rodrigo) > v5: unconditionally set interrupts, rename state_attacked var (Rodrigo) > > Signed-off-by: Alan Previn > Signed-off-by: Huang, Sean Z > Signed-off-by: Daniele Ceraolo Spurio > Cc: Chris Wilson > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Make wa list per-gt

2021-09-20 Thread Rodrigo Vivi
e GT workaround functions and multicast > steering setup per-gt. > > Cc: Tvrtko Ursulin > Cc: Daniele Ceraolo Spurio > Signed-off-by: Venkata Sandeep Dhanalakota > Signed-off-by: Matt Roper Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gt/intel_gt.c

Re: [Intel-gfx] [PATCH v9 04/17] drm/i915/pxp: allocate a vcs context for pxp usage

2021-09-16 Thread Rodrigo Vivi
On Thu, Sep 16, 2021 at 02:06:56PM +0300, Jani Nikula wrote: > On Wed, 15 Sep 2021, Rodrigo Vivi wrote: > > On Wed, Sep 15, 2021 at 04:53:35PM +0300, Jani Nikula wrote: > >> On Fri, 10 Sep 2021, Daniele Ceraolo Spurio > >> wrote: > >> > diff --git

Re: [Intel-gfx] [PATCH v9 12/17] drm/i915/pxp: Enable PXP power management

2021-09-16 Thread Rodrigo Vivi
On Wed, Sep 15, 2021 at 11:23:45AM -0400, Rodrigo Vivi wrote: > On Wed, Sep 15, 2021 at 08:11:54AM -0700, Daniele Ceraolo Spurio wrote: > > > > > > On 9/14/2021 12:13 PM, Rodrigo Vivi wrote: > > > On Fri, Sep 10, 2021 at 08:36:22AM -0700, Daniele Ceraolo Spurio wro

Re: [Intel-gfx] [PATCH v9 04/17] drm/i915/pxp: allocate a vcs context for pxp usage

2021-09-15 Thread Rodrigo Vivi
On Wed, Sep 15, 2021 at 04:53:35PM +0300, Jani Nikula wrote: > On Fri, 10 Sep 2021, Daniele Ceraolo Spurio > wrote: > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.h > > b/drivers/gpu/drm/i915/pxp/intel_pxp.h > > new file mode 100644 > > index ..e87550fb9821 > > --- /dev/null >

Re: [Intel-gfx] [PATCH v9 03/17] drm/i915/pxp: define PXP device flag and kconfig

2021-09-15 Thread Rodrigo Vivi
IFWIs that do not > > support PXP, so we need it to be an opt-in until we add support to query > > the caps from the mei device. > > > > Signed-off-by: Daniele Ceraolo Spurio > > Reviewed-by: Rodrigo Vivi > > --- > > drivers/gpu/drm/i915/Kconfig

Re: [Intel-gfx] [PATCH v9 12/17] drm/i915/pxp: Enable PXP power management

2021-09-15 Thread Rodrigo Vivi
On Wed, Sep 15, 2021 at 08:11:54AM -0700, Daniele Ceraolo Spurio wrote: > > > On 9/14/2021 12:13 PM, Rodrigo Vivi wrote: > > On Fri, Sep 10, 2021 at 08:36:22AM -0700, Daniele Ceraolo Spurio wrote: > > > From: "Huang, Sean Z" > > > > > &g

Re: [Intel-gfx] [PATCH v9 12/17] drm/i915/pxp: Enable PXP power management

2021-09-14 Thread Rodrigo Vivi
igned-off-by: Huang, Sean Z > Signed-off-by: Daniele Ceraolo Spurio > Cc: Chris Wilson > Cc: Rodrigo Vivi ops, I had missed this patch. Sorry and thanks Alan for the ping. > --- > drivers/gpu/drm/i915/Makefile| 1 + > drivers/gpu/drm/i915/gt/intel_gt_pm.c

Re: [Intel-gfx] [PATCH v9 05/17] drm/i915/pxp: Implement funcs to create the TEE channel

2021-09-10 Thread Rodrigo Vivi
l > > v6: don't use fetch_and_zero in fini (Rodrigo) > > Signed-off-by: Huang, Sean Z > Signed-off-by: Daniele Ceraolo Spurio > Cc: Chris Wilson Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/Makefile | 3 +- > drivers/gpu/drm/i915/pxp

  1   2   3   4   5   6   7   8   9   10   >