RE: [RFC 0/5] Introduce drm sharpening property

2024-03-04 Thread Simon Ser
On Monday, March 4th, 2024 at 15:04, Garg, Nemesa wrote: > This is generic as sharpness effect is applied post blending. Depending > on the color gamut, pixel format and other inputs the image gets > blended and once we get blended output it can be sharpened based on > strength value provided by

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-28 Thread Simon Ser
al hardware (Pekka) > v4: Update the docs to indicate the list is "in order of preference" > Add a a link to the mutter MR > > Cc: Simon Ser > Cc: Jonas Ådahl > Cc: Daniel Stone > Cc: Sameer Lattannavar > Cc: Sebastian Wick > Acked-by: Harry Wentland

Re: [RFC 0/5] Introduce drm sharpening property

2024-02-15 Thread Simon Ser
How much of this is Intel-specific? Are there any hardware vendors with a similar feature? How much is the "sharpness" knob tied to Intel hardware?

Re: [Intel-gfx] [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-23 Thread Simon Ser
Thanks! This iteration of the first 3 patches LGTM, I've pushed them to drm-misc-next. I've made two adjustments to make checkpatch.pl happy: - s/uint64_t/u64/ - Fix indentation for a drm_dbg_atomic()

[Intel-gfx] [PATCH] drm/atomic-helper: relax unregistered connector check

2023-10-05 Thread Simon Ser
://lore.kernel.org/intel-gfx/y6gx7z17wmdsk...@ideak-desk.fi.intel.com/ Signed-off-by: Simon Ser Cc: Ville Syrjälä Cc: Jani Nikula Cc: Lyude Paul Cc: Imre Deak --- drivers/gpu/drm/drm_atomic_helper.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-08-23 Thread Simon Ser
On Wednesday, August 23rd, 2023 at 12:53, Simon Ser wrote: > On Tuesday, August 8th, 2023 at 17:04, James Zhu jam...@amd.com wrote: > > > I have a MR for libdrm to support drm nodes type up to 2^MINORBITS > > nodes which can work with these patches, > > > > https

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-08-23 Thread Simon Ser
On Tuesday, August 8th, 2023 at 17:04, James Zhu wrote: > I have a MR for libdrm to support drm nodes type up to 2^MINORBITS > nodes which can work with these patches, > > https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/305 FWIW, this MR has been merged, so in theory this kernel patch

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-18 Thread Simon Ser
On Thursday, August 17th, 2023 at 21:33, Dmitry Baryshkov wrote: > We have been looking for a way to document that the corresponding DP > port is represented by the USB connector on the device. > > Consequently, I believe the best way to document it, would be to use > DisplayPort / USB, when

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Thursday, August 3rd, 2023 at 22:44, Laurent Pinchart wrote: > On Thu, Aug 03, 2023 at 03:31:16PM +0000, Simon Ser wrote: > > > On Thursday, August 3rd, 2023 at 17:22, Simon Ser cont...@emersion.fr wrote: > > > > > The KMS docs describe "subconnector&qu

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Thursday, August 3rd, 2023 at 17:36, Dmitry Baryshkov wrote: > On Thu, 3 Aug 2023 at 18:31, Simon Ser cont...@emersion.fr wrote: > > > On Thursday, August 3rd, 2023 at 17:22, Simon Ser cont...@emersion.fr wrote: > > > > > The KMS docs describe "subconnect

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Thursday, August 3rd, 2023 at 17:22, Simon Ser wrote: > The KMS docs describe "subconnector" to be defined as "downstream port" for > DP. > Can USB-C (or USB) be seen as a DP downstream port? To expand on this a bit: I'm wondering if we're mixing apples and ora

Re: [Intel-gfx] [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-03 Thread Simon Ser
On Wednesday, August 2nd, 2023 at 21:23, Dmitry Baryshkov wrote: > >> >> + { DRM_MODE_SUBCONNECTOR_USB, "USB" }, /* DP */ > >> > > >> > Should this be DRM_MODE_SUBCONNECTOR_USB_C and "USB-C", in case we get > >> > another USB type later ? > >> > >> Hmm, which id should I use

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-07-28 Thread Simon Ser
On Thursday, July 27th, 2023 at 14:01, Christian König wrote: > > We do need patches to stop trying to infer the node type from the minor > > in libdrm, though. Emil has suggested using sysfs, which we already do > > in a few places in libdrm. > > That sounds like a really good idea to me as

Re: [Intel-gfx] [PATCH v6 3/4] drm: Expand max DRM device number to full MINORBITS

2023-07-26 Thread Simon Ser
On Monday, July 24th, 2023 at 23:14, Michał Winiarski wrote: > Having a limit of 64 DRM devices is not good enough for modern world > where we have multi-GPU servers, SR-IOV virtual functions and virtual > devices used for testing. > Let's utilize full minor range for DRM devices. > To avoid

Re: [Intel-gfx] [PATCH v2] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-07-10 Thread Simon Ser
Any news about this patch?

[Intel-gfx] [PATCH v2] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-06-23 Thread Simon Ser
This adds more information to the hotplug uevent and lets user-space know that it's about a particular connector only. v2: don't rely on the changed HPD pin bitmask to count changed connectors (Jani) Signed-off-by: Simon Ser Cc: Jani Nikula Cc: Ville Syrjälä Cc: Rodrigo Vivi Cc: Gustavo

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-06-23 Thread Simon Ser
On Wednesday, June 21st, 2023 at 14:26, Jani Nikula wrote: > On Wed, 21 Jun 2023, Simon Ser cont...@emersion.fr wrote: > > > On Wednesday, June 21st, 2023 at 14:11, Jani Nikula jani.nik...@intel.com > > wrote: > > > > > On Wed, 21 Jun 2023, Si

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-06-21 Thread Simon Ser
On Wednesday, June 21st, 2023 at 14:11, Jani Nikula wrote: > On Wed, 21 Jun 2023, Simon Ser cont...@emersion.fr wrote: > > > On Wednesday, June 21st, 2023 at 14:05, Jani Nikula jani.nik...@intel.com > > wrote: > > > > > > - if (changed) &

Re: [Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-06-21 Thread Simon Ser
On Wednesday, June 21st, 2023 at 14:05, Jani Nikula wrote: > > - if (changed) > > + if (hweight32(changed) == 1) > > + drm_kms_helper_connector_hotplug_event(first_changed_connector); > > What if more than one connector share the same hpd pin? Ah, I did not believe this could happen. I'll

[Intel-gfx] [PATCH] i915/display/hotplug: use drm_kms_helper_connector_hotplug_event()

2023-06-20 Thread Simon Ser
This adds more information to the hotplug uevent and lets user-space know that it's about a particular connector only. Signed-off-by: Simon Ser Cc: Jani Nikula Cc: Ville Syrjälä Cc: Rodrigo Vivi Cc: Gustavo Sousa Cc: Imre Deak Cc: Lucas De Marchi --- drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH] drm/connector: document enum drm_connector_tv_mode DRM_MODE_TV_MODE_MAX

2023-05-04 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [Intel-gfx] [PATCH 1/6] drm/uapi: Document CTM matrix better

2023-04-28 Thread Simon Ser
Acked-by: Simon Ser

Re: [Intel-gfx] [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-27 Thread Simon Ser
On Wednesday, January 25th, 2023 at 21:04, Thomas Zimmermann wrote: > Not having connectors indicates a driver bug. Is it? What if all connectors are of the DP-MST type, ie. they are created on-the-fly?

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Remove redundant framebuffer format check

2023-01-12 Thread Simon Ser
The Intel counterpart is also: Reviewed-by: Simon Ser

Re: [Intel-gfx] [PATCH 2/5] drm/amdgpu: Remove redundant framebuffer format check

2023-01-12 Thread Simon Ser
Reviewed-by: Simon Ser

[Intel-gfx] [PATCH 2/2] drm/i915/dp_mst: don't pull unregistered connectors into state

2022-12-15 Thread Simon Ser
] is not registered Skip these unregistered connectors to allow user-space to turn them off. Fixes part of this wlroots issue: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3407 Signed-off-by: Simon Ser Cc: Ville Syrjälä Cc: Jani Nikula Cc: Lyude Paul --- drivers/gpu/drm/i915/display/intel_dp_mst.c

[Intel-gfx] [PATCH 1/2] drm/i915/dp_mst: log when pulling CRTCs into atomic state

2022-12-15 Thread Simon Ser
It can be surprising for user-space to see unrelated connectors, CRTCs and planes being implicitly pulled into the atomic commit. Log when that happens. Signed-off-by: Simon Ser Cc: Ville Syrjälä Cc: Jani Nikula Cc: Lyude Paul --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 4 1 file

Re: [Intel-gfx] [PATCH v2 15/16] drm/edid: add [CONNECTOR:%d:%s] to debug logging

2022-10-24 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [Intel-gfx] [PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c

2022-08-01 Thread Simon Ser
Acked-by: Simon Ser CC amd-gfx On Monday, August 1st, 2022 at 15:52, Imre Deak wrote: > The API change introduced in > > commit 30c637151cfa ("drm/plane-helper: Export individual helpers") > > was missed in the conflict resolution of > > commit d93a13bd75b9 (&qu

Re: [Intel-gfx] [v8 3/5] drm/edid: read HF-EEODB ext block

2022-03-23 Thread Simon Ser
On Wednesday, March 23rd, 2022 at 13:02, Jani Nikula wrote: > Simon and Daniel also tell me on IRC we can't just modify the base block > extension count to match HF-EEODB to dodge the problem, because the EDID > gets exposed to userspace. I'm not familiar how the EDID blob gets exposed to

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Simon Ser
On Friday, February 18th, 2022 at 12:54, Hans de Goede wrote: > On 2/18/22 12:39, Simon Ser wrote: > > On Friday, February 18th, 2022 at 11:38, Hans de Goede > > wrote: > > > >> What I'm reading in the above is that it is being considered to allow > >&g

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-18 Thread Simon Ser
On Friday, February 18th, 2022 at 11:38, Hans de Goede wrote: > What I'm reading in the above is that it is being considered to allow > changing the panel-orientation value after the connector has been made > available to userspace; and let userspace know about this through a uevent. > > I

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-15 Thread Simon Ser
On Tuesday, February 15th, 2022 at 15:38, Emil Velikov wrote: > On Tue, 15 Feb 2022 at 13:55, Simon Ser wrote: > > > > On Tuesday, February 15th, 2022 at 13:04, Emil Velikov > > wrote: > > > > > Greetings everyone, > > > > > > Padron fo

Re: [Intel-gfx] [PATCH v8 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-15 Thread Simon Ser
On Tuesday, February 15th, 2022 at 13:04, Emil Velikov wrote: > Greetings everyone, > > Padron for joining in so late o/ > > On Tue, 8 Feb 2022 at 08:42, Hsin-Yi Wang wrote: > > > > drm_dev_register() sets connector->registration_state to > > DRM_CONNECTOR_REGISTERED and dev->registered to

Re: [Intel-gfx] [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

2022-01-07 Thread Simon Ser
On Friday, January 7th, 2022 at 18:26, José Expósito wrote: > Is there something that needs to improve in the other 4 patches? > Or just waiting on maintainers input? Yeah, these patches look good to me. Feel free to add my R-b. Maintainers for these drivers still need to review/ack/apply

Re: [Intel-gfx] [PATCH v3 2/6] drm/plane: Fix typo in format_mod_supported documentation

2022-01-05 Thread Simon Ser
Pushed patches 1 & 2 to drm-misc-next. Thanks for your contribution!

Re: [Intel-gfx] [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

2021-12-23 Thread Simon Ser
On Thursday, December 23rd, 2021 at 12:56, Ville Syrjälä wrote: > > - /* If we can't determine support, just bail */ > > - if (!plane->funcs->format_mod_supported) > > - goto done; > > - > > mod = modifiers_ptr(blob_data); > > for (i = 0; i < plane->modifier_count; i++) {

Re: [Intel-gfx] [PATCH v2 1/6] drm/plane: Make format_mod_supported truly optional

2021-12-23 Thread Simon Ser
On Wednesday, December 22nd, 2021 at 10:05, José Expósito wrote: > Make "create_in_format_blob" behave as documented. LGTM, nice! Reviewed-by: Simon Ser CC Ville just in case

Re: [Intel-gfx] [PATCH v2 2/6] drm/plane: Fix typo in format_mod_supported documentation

2021-12-23 Thread Simon Ser
Reviewed-by: Simon Ser

Re: [Intel-gfx] [PATCH v10 08/10] dyndbg: add print-to-tracefs, selftest with it - RFC

2021-11-23 Thread Simon Ser
First off, let me reiterate that this feature would be invaluable as user-space developers. It's often pretty difficult to figure out the cause of an EINVAL, we have to ask users to follow complicated instructions [1] to grab DRM logs. Then have to skim through several megabytes of logs to find

Re: [Intel-gfx] [PATCH v2 14/17] uapi/drm/dg2: Format modifier for DG2 unified compression and clear color

2021-10-21 Thread Simon Ser
For the include/uapi/drm/drm_fourcc.h changes: Acked-by: Simon Ser

Re: [Intel-gfx] [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-12 Thread Simon Ser
On Tuesday, October 12th, 2021 at 12:30, Pekka Paalanen wrote: > is there a practise of landing proposal documents in the kernel? How > does that work, will a kernel tree carry the patch files? > Or should this document be worded like documentation for an accepted > feature, and then the

Re: [Intel-gfx] [PATCH v2 1/7] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-10-08 Thread Simon Ser
Ping

Re: [Intel-gfx] [PATCH v2 0/7] drm: add per-connector hotplug events

2021-09-07 Thread Simon Ser
Ping, anyone up for a review?

Re: [Intel-gfx] [PATCH v2 7/7] drm/connector: add ref to drm_connector_get in iter docs

2021-08-02 Thread Simon Ser
Pushed this one doc patch with Daniel's R-b on IRC.

Re: [Intel-gfx] [PATCH] include/uapi/drm: fix spelling mistakes in header files

2021-07-03 Thread Simon Ser
Reviewed-by: Simon Ser But this this touches a lot of different drivers, not sure we can just merge this via drm-misc-next? In any case, please ping me again in a week if this hasn't been merged by then. ___ Intel-gfx mailing list Intel-gfx

Re: [Intel-gfx] [PATCH v4 12/17] drm/uAPI: Add "preferred color format" drm property as setting for userspace

2021-06-29 Thread Simon Ser
On Tuesday, June 22nd, 2021 at 09:15, Pekka Paalanen wrote: > yes, I think this makes sense, even if it is a property that one can't > tell for sure what it does before hand. > > Using a pair of properties, preference and active, to ask for something > and then check what actually worked is

Re: [Intel-gfx] [PATCH v4 09/17] drm/uAPI: Add "active color range" drm property as feedback for userspace

2021-06-22 Thread Simon Ser
On Tuesday, June 22nd, 2021 at 11:50, Werner Sembach wrote: > Unknown is when no monitor is connected or is when the > connector/monitor is disabled. I think the other connector props (link-status, non-desktop, etc) don't have a special "unset" value, and instead the value is set to a random

[Intel-gfx] [PATCH v2 2/7] drm/probe-helper: add drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function is the same as drm_kms_helper_hotplug_event, but takes a connector instead of a device. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 23 +++ include/drm/drm_probe_helper.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers

[Intel-gfx] [PATCH v2 6/7] i915/display/dp: send a more fine-grained link-status uevent

2021-06-09 Thread Simon Ser
When link-status changes, send a hotplug uevent which contains the connector and property ID. That way, user-space can more easily figure out that only the link-status property of this connector has been updated. Signed-off-by: Simon Ser --- drivers/gpu/drm/i915/display/intel_dp.c | 2 ++ 1

[Intel-gfx] [PATCH v2 7/7] drm/connector: add ref to drm_connector_get in iter docs

2021-06-09 Thread Simon Ser
Mention that connectors need to be referenced manually if they are to be accessed after the iteration has progressed or ended. Signed-off-by: Simon Ser --- include/drm/drm_connector.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/drm/drm_connector.h b/include/drm

[Intel-gfx] [PATCH v2 5/7] drm/probe-helper: use drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
If an hotplug event only updates a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_probe_helper.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH v2 4/7] amdgpu: use drm_kms_helper_connector_hotplug_event

2021-06-09 Thread Simon Ser
When updating a single connector, use drm_kms_helper_connector_hotplug_event instead of drm_kms_helper_hotplug_event. Signed-off-by: Simon Ser --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 4 ++-- 2 files

[Intel-gfx] [PATCH v2 3/7] drm/connector: use drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
In drm_connector_register, use drm_sysfs_connector_hotplug_event instead of drm_sysfs_hotplug_event, because the hotplug event only updates a single connector. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v2 1/7] drm/sysfs: introduce drm_sysfs_connector_hotplug_event

2021-06-09 Thread Simon Ser
This function sends a hotplug uevent with a CONNECTOR property. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_sysfs.c | 25 + include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c

[Intel-gfx] [PATCH v2 0/7] drm: add per-connector hotplug events

2021-06-09 Thread Simon Ser
when sending HDCP property update uevents, see drm_sysfs_connector_status_event. This has been tested with a wlroots patch [1]. amdgpu and the probe-helper has been updated to use these new fine-grained uevents. [1]: https://github.com/swaywm/wlroots/pull/2959 Simon Ser (7): drm/sysfs

Re: [Intel-gfx] [PATCH 5/7] dma-buf: Add an API for exporting sync files (v11)

2021-05-27 Thread Simon Ser
On Thursday, May 27th, 2021 at 12:33 PM, Daniel Vetter wrote: > > The sync_file is also import/exportable to a certain drm_syncobj timeline > > point (or as binary signal). So no big deal, we are all compatible here :) > > I just thought that it might be more appropriate to return a drm_syncobj

Re: [Intel-gfx] [PATCH 0/7] Per client engine busyness

2021-05-17 Thread Simon Ser
On Monday, May 17th, 2021 at 8:16 PM, Nieto, David M wrote: > Btw is DRM_MAJOR 226 consider uapi? I don't see it in uapi headers. It's not in the headers, but it's de facto uAPI, as seen in libdrm: > git grep 226 xf86drm.c 99:#define DRM_MAJOR 226 /* Linux */

Re: [Intel-gfx] New uAPI for color management proposal and feedback request

2021-05-12 Thread Simon Ser
On Wednesday, May 12th, 2021 at 3:04 PM, Ville Syrjälä wrote: > > Adoption: > > > > A KDE dev wants to implement the settings in the KDE settings GUI: > > > > https://gitlab.freedesktop.org/drm/amd/-/issues/476#note_912370 > > > > Tuxedo Computers (my employer) wants to implement the settings

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-05-04 Thread Simon Ser
Continuing on that idea to push for enabling the cap in more cases: do we have a policy to require new drivers to always support modifiers? That would be nice, even if it's just about enabling LINEAR. ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 8/8] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-27 Thread Simon Ser
Reviewed-by: Simon Ser ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-04-22 Thread Simon Ser
On Thursday, April 22nd, 2021 at 10:54 AM, Hans de Goede wrote: > I guess Marco was waiting for the kernel bits too land before submitting > these, > but I agree that it would probably be good to have these submitted now, we > can mark them as WIP to avoid them getting merged before the kernel

Re: [Intel-gfx] [PATCH v2 0/9] drm: Add privacy-screen class and connector properties

2021-04-22 Thread Simon Ser
Hi, On Wednesday, April 21st, 2021 at 10:47 PM, Hans de Goede wrote: > There now is GNOME userspace code using the new properties: > https://hackmd.io/@3v1n0/rkyIy3BOw Thanks for working on this. Can these patches be submitted as merge requests against the upstream projects? It would be nice

Re: [Intel-gfx] [PATCH] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-16 Thread Simon Ser
Reviewed-by: Simon Ser ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-13 Thread Simon Ser
On Tuesday, April 13th, 2021 at 11:49 AM, Daniel Vetter wrote: > + * Note that userspace can check the DRM_CAP_ADDFB2_MODIFIERS driver Prepend an ampersand like so and a hyperlink will be rendered: Note that userspace can check the _CAP_ADDFB2_MODIFIERS driver

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section

2021-03-25 Thread Simon Ser
Acked-by: Simon Ser ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/doc: Add RFC section

2021-03-23 Thread Simon Ser
Side note: I feel like we could have better lines of communication between kernel devs and user-space devs. The new uAPI requirements seem to be a high barrier to entry for kernel devs. However sometimes user-space devs might be interested in helping out with the user-space part… Maybe it would

Re: [Intel-gfx] [PATCH v3] kcmp: Support selection of SYS_kcmp without CHECKPOINT_RESTORE

2021-02-12 Thread Simon Ser
On Friday, February 12th, 2021 at 1:57 PM, Emil Velikov wrote: > On Fri, 5 Feb 2021 at 22:01, Chris Wilson wrote: > > > > Userspace has discovered the functionality offered by SYS_kcmp and has > > started to depend upon it. In particular, Mesa uses SYS_kcmp for > > os_same_file_description()

Re: [Intel-gfx] [PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-10 Thread Simon Ser
On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter wrote: > On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote: > > > These additional checks added to avoid EBUSY give unnecessary WARN_ON > > in case of big joiner used in i915 in which case even if the modeset > > is

Re: [Intel-gfx] [PATCH v5 1/6] drm/damage_helper: Check if damage clips has valid values

2020-12-14 Thread Simon Ser
failed > due invalid damage clips > > Cc: Simon Ser > Cc: Gwan-gyeong Mun > Cc: Sean Paul > Cc: Fabio Estevam > Cc: Deepak Rawat > Cc: dri-de...@lists.freedesktop.org > Signed-off-by: José Roberto de Souza After looking at the kernel code,

Re: [Intel-gfx] [PATCH] drm/damage_helper: Check if damage clips has valid values

2020-12-13 Thread Simon Ser
Can you add some drm_dbg_atomic logs when the damage is invalid, to make it easier for user-space to understand why an atomic commit failed? ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [drm-tip:drm-tip 1117/1129] drivers/gpu/drm/drm_atomic_uapi.c:342 drm_atomic_set_crtc_for_connector() error: we previously assumed 'crtc' could be null (see line 326)

2020-11-16 Thread Simon Ser
Already fixed in 0003b687ee6d ("drm: fix oops in drm_atomic_set_crtc_for_connector"). Thanks. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Include fb modidier in state dumps

2020-11-03 Thread Simon Ser
Thanks! Acked-by: Simon Ser ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported()

2020-10-23 Thread Simon Ser
On Friday, October 23, 2020 10:39 PM, Ville Syrjala wrote: > From: Ville Syrjälä ville.syrj...@linux.intel.com > > The code responsible for creating the IN_FORMATS > blob is broken when the driver doesn't provide a > .format_mod_supported() hook. It just copies in > the format list, but leaves

Re: [Intel-gfx] drm_modes: signed integer overflow

2020-10-23 Thread Simon Ser
On Friday, October 23, 2020 5:27 PM, Ville Syrjälä wrote: > These are two extreme cases: Thanks! > > I'm trying to get > > a fix for my user-space 1, and I'm wondering if int32_t is enough > > after dividing by mode->htotal. > > CC Pekka, just FYI (I think Weston has similar code). > > What's

Re: [Intel-gfx] drm_modes: signed integer overflow

2020-10-23 Thread Simon Ser
On Thursday, October 22, 2020 12:14 PM, Ville Syrjälä wrote: > On Wed, Oct 21, 2020 at 08:13:43PM -0700, Randy Dunlap wrote: > > > Hi, > > With linux-next 20201021, when booting up, I am seeing this: > > [ 0.560896] UBSAN: signed-integer-overflow in > > ../drivers/gpu/drm/drm_modes.c:765:20 >

Re: [Intel-gfx] [PATCH v7 1/4] drm: Introduce plane and CRTC scaling filter properties

2020-10-20 Thread Simon Ser
For the docs: Acked-by: Simon Ser ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v6 0/5] Introduce drm scaling filter property

2020-10-20 Thread Simon Ser
On Tuesday, October 13, 2020 4:26 PM, Simon Ser wrote: > On Monday, October 12, 2020 8:41 PM, Pankaj Bharadiya > pankaj.laxminarayan.bharad...@intel.com wrote: > > > Now, Sameer has implemented Integer scaling in Kodi Retro gaming > > framework which demonstrate how

Re: [Intel-gfx] [PATCH v6 0/5] Introduce drm scaling filter property

2020-10-13 Thread Simon Ser
On Monday, October 12, 2020 8:41 PM, Pankaj Bharadiya wrote: > Now, Sameer has implemented Integer scaling in Kodi Retro gaming > framework which demonstrate how Integer scaling gives distinctive > look to pixel art games when played on higher resolution monitors. > > Kodi patches are reviewed

Re: [Intel-gfx] [PATCH v6 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-10-13 Thread Simon Ser
On Monday, October 12, 2020 8:41 PM, Pankaj Bharadiya wrote: > +/** > + * DOC: CRTC scaling filter property > + * > + * SCALING_FILTER: > + * > + * Indicates scaling filter to be used for CRTC scaler > + * > + * The value of this property can be one of the following: > + * Default: > + *

Re: [Intel-gfx] [PATCH v6 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-10-13 Thread Simon Ser
> +/** > + * DOC: Plane scaling filter property > + * > + * SCALING_FILTER: > + * > + * Indicates scaling filter to be used for plane scaler > + * > + * The value of this property can be one of the following: > + * Default: > + * Driver's default scaling filter > + * Nearest

Re: [Intel-gfx] [PATCH v7 i-g-t 2/4] kms_writeback: Add initial writeback tests

2020-04-15 Thread Simon Ser
> > + igt_output_set_prop_value(output, > > IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR, (uint64_t)out_fence_ptr); > > On ARM (32bits), this cast creates a compilation error since the > pointer size isn't an uint64_t. Does casting to uintptr_t before uint64_t fix it?

Re: [Intel-gfx] [PATCH v3 0/5] Introduce drm scaling filter property

2020-03-30 Thread Simon Ser
Hi, On Monday, March 30, 2020 8:38 PM, Pankaj Bharadiya wrote: > Userspace patch series link: https://github.com/lrusak/xbmc/pull/24 This pull request is against a fork, not the official Kodi repository. Are there any plans to upstream the change so that users can benefit from it? Is there a

Re: [Intel-gfx] [PATCH v3 2/5] drm/drm-kms.rst: Add plane and CRTC scaling filter property documentation

2020-03-30 Thread Simon Ser
On Monday, March 30, 2020 8:38 PM, Pankaj Bharadiya wrote: > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst > index 906771e03103..b0335e9d887c 100644 > --- a/Documentation/gpu/drm-kms.rst > +++ b/Documentation/gpu/drm-kms.rst > @@ -509,6 +509,18 @@ Variable Refresh

Re: [Intel-gfx] drm core/helpers and MIT license

2019-11-14 Thread Simon Ser
Adding zeis...@freebsd.org for FreeBSD. I'll try to see if I can ping some NetBSD/OpenBSD folks too. On Tuesday, November 12, 2019 4:03 PM, Daniel Vetter wrote: > Hi all, > > Dave and me chatted about this last week on irc. Essentially we have: > > $ git grep SPDX.*GPL --

[Intel-gfx] [PATCH] drm: two planes with the same zpos have undefined ordering

2019-09-10 Thread Simon Ser
zpos values for two different planes, either make the ordering unspecified. To allow drivers that don't know the relative ordering between two planes to still expose the zpos property, choose the latter solution. Signed-off-by: Simon Ser --- drivers/gpu/drm/drm_blend.c | 8 1 file changed

[Intel-gfx] [PATCH] drm/i915: add Type-C port to encoder name

2019-08-29 Thread Simon Ser
This patch adds the Type-C port number to the encoder name. This is an alternative to [1]. [1]: https://patchwork.freedesktop.org/series/65695/ Signed-off-by: Simon Ser Cc: Imre Deak Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 11 ++- 1 file

[Intel-gfx] [PATCH v2] drm/i915: add port info to debugfs

2019-08-23 Thread Simon Ser
This patch adds a line with the port name to connectors in debugfs/i915_debug_info. If the port is Type-C, the Type-C port number is printed too. Signed-off-by: Simon Ser Cc: Imre Deak Cc: Manasi Navare Reviewed-by: Imre Deak --- Resending v2 to the correct mailing list. drivers/gpu/drm

Re: [Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-19 Thread Simon Ser
On Thursday, April 18, 2019 8:20 AM, Simon Ser wrote: > On Wednesday, April 17, 2019 11:35 PM, Simon Ser cont...@emersion.fr wrote: > > > In terms of graphs, if a plane is a node and a two-plane overlap is an > > edge, it means we want a complete graph (each node has an edg

Re: [Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-17 Thread Simon Ser
On Wednesday, April 17, 2019 11:35 PM, Simon Ser wrote: > In terms of graphs, if a plane is a node and a two-plane overlap is an > edge, it means we want a complete graph (each node has an edge to all > other nodes). If we only have square planes, it's already impossible to > get a so

Re: [Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-17 Thread Simon Ser
> > > > > Op 16-04-2019 om 15:20 schreef Ville Syrjälä: > > > > > > > > > On Sat, Apr 13, 2019 at 11:13:27AM +, Simon Ser wrote: > > > > > > > > > > > From: Ville Syrjälä ville.syrj...@linux.intel.com > > > > >

[Intel-gfx] [PATCH v3] drm/i915: add immutable zpos plane properties

2019-04-13 Thread Simon Ser
From: Ville Syrjälä This adds basic immutable support for the zpos property. The zpos increases from bottom to top: primary, sprites, cursor. Signed-off-by: Ville Syrjälä [cont...@emersion.fr: adapted for latest drm-tip] Signed-off-by: Simon Ser --- Maarten, could your review this patch

Re: [Intel-gfx] [PATCH v2] drm/i915: add immutable zpos plane properties

2019-04-09 Thread Simon Ser
Hi Jani, git blame says you are familiar with intel_primary_plane_create! Would you have some time to review this patch? Thanks! -- Simon Ser https://emersion.fr > From: Ville Syrjälä > > This adds basic immutable support for the zpos property. The zpos increases > from bottom to

[Intel-gfx] [PATCH v2] drm/i915: add immutable zpos plane properties

2019-04-03 Thread Simon Ser
From: Ville Syrjälä This adds basic immutable support for the zpos property. The zpos increases from bottom to top: primary, sprites, cursor. Signed-off-by: Ville Syrjälä [cont...@emersion.fr: adapted for latest drm-tip] Signed-off-by: Simon Ser --- Changes in v2: set correct author and S-o

Re: [Intel-gfx] [PATCH] drm/i915: add immutable zpos plane properties

2019-04-02 Thread Simon Ser
On Tuesday, April 2, 2019 3:35 PM, Joonas Lahtinen wrote: > Quoting Simon Ser (2019-03-30 00:19:25) > > > From: emersion cont...@emersion.fr > > Please fix your From: field. Gah. > > This adds basic immutable support for the zpos property. The zpos increases > &g

[Intel-gfx] [PATCH] drm/i915: add immutable zpos plane properties

2019-03-29 Thread Simon Ser
From: emersion This adds basic immutable support for the zpos property. The zpos increases from bottom to top: primary, sprites, cursor. Signed-off-by: Simon Ser --- This is based on a previous patch by Ville [1] that I wanted to review. Unfortunately the patch no longer applies, so here