Re: [Intel-gfx] [PATCH 1/7] drm: Do not round to megabytes for greater than 1MiB sizes in fdinfo stats

2023-09-27 Thread Steven Price
eyeballing fdinfo text directly. > > Signed-off-by: Tvrtko Ursulin > Cc: Rob Clark > Cc: Adrián Larumbe > Cc: steven.pr...@arm.com Reviewed-by: Steven Price > --- > drivers/gpu/drm/drm_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 05/29] drm/panfrost: dynamically allocate the drm-panfrost shrinker

2023-06-23 Thread Steven Price
On 22/06/2023 09:39, Qi Zheng wrote: > From: Qi Zheng > > In preparation for implementing lockless slab shrink, > we need to dynamically allocate the drm-panfrost shrinker, > so that it can be freed asynchronously using kfree_rcu(). > Then it doesn't need to wait for RCU read-side critical >

Re: [Intel-gfx] [PATCH 0/4] log2: make is_power_of_2() more generic

2023-04-05 Thread Steven Price
On 31/03/2023 09:31, Jani Nikula wrote: > On Thu, 30 Mar 2023, Andrew Morton wrote: >> On Thu, 30 Mar 2023 21:53:03 + David Laight >> wrote: >> But wouldn't all these issues be addressed by simply doing #define is_power_of_2(n) (n != 0 && ((n & (n - 1)) == 0)) ?

Re: [Intel-gfx] [PATCH v6 04/22] drm/panfrost: Fix shrinker list corruption by madvise IOCTL

2022-05-30 Thread Steven Price
it. > > Cc: sta...@vger.kernel.org > Fixes: 013b65101315 ("drm/panfrost: Add madvise and shrinker support") > Signed-off-by: Dmitry Osipenko Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 del

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/utils: do not depend on config being defined

2021-09-30 Thread Steven Price
On 29/09/2021 19:33, Lucas De Marchi wrote: > Like the IS_ENABLED() counterpart, we can make IS_CONFIG_NONZERO() to > return the right thing when the config is not defined rather than a > build error, with the limitation that it can't be used on preprocessor > context. > > The trick here is that

Re: [Intel-gfx] [PATCH v3 07/20] drm/panfrost: use scheduler dependency tracking

2021-07-12 Thread Steven Price
as dependencies. > > v2: Correctly clean up the partially set up job, now that job_init() > and job_arm() are apart (Emma). > > Reviewed-by: Steven Price (v1) v2/v3 are also: Reviewed-by: Steven Price Thanks, Steve > Signed-off-by: Daniel Vetter > Cc: Rob Herring &g

Re: [Intel-gfx] [PATCH 03/11] drm/panfrost: Use xarray and helpers for depedency tracking

2021-06-03 Thread Steven Price
On 02/06/2021 19:51, Daniel Vetter wrote: > On Wed, Jun 02, 2021 at 03:06:50PM +0100, Steven Price wrote: >> On 21/05/2021 10:09, Daniel Vetter wrote: [...] >>> + if (!xa_empty(>deps)) >>> + return xa_erase(>deps, job->last_dep++); >> &

Re: [Intel-gfx] [PATCH 03/11] drm/panfrost: Use xarray and helpers for depedency tracking

2021-06-02 Thread Steven Price
le for this too. > > Cc: "Christian König" > Cc: Luben Tuikov > Cc: Alex Deucher > Cc: Lee Jones > Cc: Steven Price > Cc: Rob Herring > Cc: Tomeu Vizoso > Cc: Alyssa Rosenzweig > Cc: Sumit Semwal > Cc: linux-me...@vger.kernel.org > Cc: linaro

Re: [Intel-gfx] [PATCH v5 05/16] swiotlb: Add restricted DMA pool initialization

2021-04-28 Thread Steven Price
On 26/04/2021 17:37, Claire Chang wrote: On Fri, Apr 23, 2021 at 7:34 PM Steven Price wrote: [...] But even then if it's not and we have the situation where debugfs==NULL then the debugfs_create_dir() here will cause a subsequent attempt in swiotlb_create_debugfs() to fail (directory already

Re: [Intel-gfx] [PATCH v5 05/16] swiotlb: Add restricted DMA pool initialization

2021-04-23 Thread Steven Price
On 22/04/2021 09:14, Claire Chang wrote: Add the initialization function to create restricted DMA pools from matching reserved-memory nodes. Signed-off-by: Claire Chang --- include/linux/device.h | 4 +++ include/linux/swiotlb.h | 3 +- kernel/dma/swiotlb.c| 80

Re: [Intel-gfx] [PATCH 1/2] drm/vgem: Do not allocate backing shmemfs file for an import dmabuf object

2020-07-09 Thread Steven Price
On 09/07/2020 09:48, Christian König wrote: Am 08.07.20 um 18:19 schrieb Daniel Vetter: On Wed, Jul 8, 2020 at 6:11 PM Daniel Vetter wrote: On Wed, Jul 8, 2020 at 5:05 PM Christian König wrote: Am 08.07.20 um 17:01 schrieb Daniel Vetter: On Wed, Jul 8, 2020 at 4:37 PM Christian König

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-17 Thread Steven Price
On 17/12/2019 06:37, Randy Dunlap wrote: > On 12/16/19 9:42 PM, Sam Ravnborg wrote: >> Hi Randy. >> >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: >>> On 12/15/19 9:22 PM, Stephen Rothwell wrote: Hi all, Changes since 20191213: >>> >>> on x86_64: >>> >>> ld:

Re: [Intel-gfx] [PATCH 1/3] dma_resv: prime lockdep annotations

2019-11-14 Thread Steven Price
On 11/11/2019 15:42, Daniel Vetter wrote: > On Mon, Nov 11, 2019 at 2:11 PM Steven Price wrote: >> >> On 04/11/2019 17:37, Daniel Vetter wrote: >>> Full audit of everyone: >>> >>> - i915, radeon, amdgpu should be clean per their maintainers. >>&g

Re: [Intel-gfx] [PATCH 1/3] dma_resv: prime lockdep annotations

2019-11-11 Thread Steven Price
claim_acquire(GFP_KERNEL); > + fs_reclaim_release(GFP_KERNEL); > + ww_mutex_unlock(); > + up_read(>mmap_sem); > + Nit: trailing whitespace > + mmput(mm); > +} > +subsys_initcall(dma_resv_lockdep); This expects a function returning int, but dma_resv_lockd