[Intel-gfx] [PATCH v4] prime_mmap_kms: show case dma-buf new API and processes restrictions

support for dma-buf mmap is nonexistent. Signed-off-by: Tiago Vignatti <tiago.vigna...@intel.com> --- tests/Makefile.sources | 1 + tests/prime_mmap_kms.c | 275 + 2 files changed, 276 insertions(+) create mode 100644 tests/prime_mmap_kms.c

[Intel-gfx] [PATCH v3] prime_mmap_kms: show case dma-buf new API and processes restrictions

for color type, increment the variable and add --interactive-debug=paint v3: use igt_display_commit() to mode set the crtc so the rectangle is shown painted; also added Testcase description on the beginning of the file. Signed-off-by: Tiago Vignatti <tiago.vigna...@intel.com> --- OBS: v2 wa

[Intel-gfx] [PATCH] prime_mmap_kms: show case dma-buf new API and processes restrictions

hooks, are exposed to the user-space through the DMA_BUF_IOCTL_SYNC ioctl and have to be used before and after the mapped area is accessed. Signed-off-by: Tiago Vignatti <tiago.vigna...@intel.com> --- tests/Makefile.sources | 1 + tests/prime_mmap_kms.c

Re: [Intel-gfx] [PATCH] dma-buf: Update docs for SYNC ioctl

On 03/29/2016 06:47 AM, David Herrmann wrote: Hi On Mon, Mar 28, 2016 at 9:42 PM, Tiago Vignatti <tiago.vigna...@intel.com> wrote: Do we have an agreement here after all? David? I need to know whether this fixup is okay to go cause I'll need to submit to Chrome OS then. Sure it i

Re: [Intel-gfx] [PATCH] dma-buf: Update docs for SYNC ioctl

On 03/23/2016 12:42 PM, Chris Wilson wrote: On Wed, Mar 23, 2016 at 04:32:59PM +0100, David Herrmann wrote: Hi On Wed, Mar 23, 2016 at 12:56 PM, Chris Wilson wrote: On Wed, Mar 23, 2016 at 12:30:42PM +0100, David Herrmann wrote: My question was rather about why we

Re: [Intel-gfx] [PATCH] dma-buf: Update docs for SYNC ioctl

On 03/21/2016 04:51 AM, Daniel Vetter wrote: Just a bit of wording polish plus mentioning that it can fail and must be restarted. Requested by Sumit. v2: Fix them typos (Hans). Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Tiago Vignatti <tiago.vigna...@intel.com> Cc: Stépha

Re: [Intel-gfx] [PATCH] dma-buf, drm, ion: Propagate error code from dma_buf_start_cpu_access()

e: igt/prime_mmap_coherency/ioctl-errors Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Tiago Vignatti <tiago.vigna...@intel.com> Cc: Stéphane Marchesin <marc...@chromium.org> Cc: David Herrmann <dh.herrm...@gmail.com> Cc: Sumit Semwal <sumit.sem...@linaro.org> Cc: Daniel

[Intel-gfx] [PATCH v3] prime_mmap_coherency: Add return error tests for prime sync ioctl

ris-wilson.co.uk> Signed-off-by: Tiago Vignatti <tiago.vigna...@intel.com> --- tests/prime_mmap_coherency.c | 89 1 file changed, 89 insertions(+) diff --git a/tests/prime_mmap_coherency.c b/tests/prime_mmap_coherency.c index 180d8a4..d2

[Intel-gfx] [PATCH v2] prime_mmap_coherency: Add return error tests for prime sync ioctl

that in case of failure (e.g. in a case where the ioctl wouldn't try again in a return error) this test does not reliably catch the problem with 100% of accuracy. v2: fix prime sync direction when reading mmap'ed file. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Tiago Vignatti <ti

Re: [Intel-gfx] [PATCH] prime_mmap_coherency: Add return error tests for prime sync ioctl

On 03/17/2016 06:01 PM, Chris Wilson wrote: On Thu, Mar 17, 2016 at 03:18:03PM -0300, Tiago Vignatti wrote: This patch adds ioctl-errors subtest to be used for exercising prime sync ioctl errors. The subtest constantly interrupts via signals a function doing concurrent blit to stress out

[Intel-gfx] [PATCH] prime_mmap_coherency: Add return error tests for prime sync ioctl

that in case of failure (e.g. in a case where the ioctl wouldn't try again in a return error) this test does not reliably catch the problem with 100% of accuracy. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Tiago Vignatti <tiago.vigna...@intel.com> --- Chris, your unpolished d

Re: [Intel-gfx] [PATCH v3] prime_mmap_coherency: Add return error tests for prime sync ioctl

On 03/18/2016 03:11 PM, Daniel Vetter wrote: On Fri, Mar 18, 2016 at 03:08:56PM -0300, Tiago Vignatti wrote: This patch adds ioctl-errors subtest to be used for exercising prime sync ioctl errors. The subtest constantly interrupts via signals a function doing concurrent blit to stress out

Re: [Intel-gfx] [PATCH i-g-t] tests/prime_mmap: Encapsulate check_for_dma_buf_mmap() in igt_fixture.

I'm not sure this actually fix the root problem. With or without your patch applied, I'm seeing the following in lib/tests/test-suite.log: ../../tests/prime_mmap: Checking invalid option handling... Checking valid option handling... Checking subtest enumeration... (prime_mmap:24023)

[Intel-gfx] [PATCH igt 4/5] tests: Add kms_mmap_write_crc for cache coherency tests

by running it at most 5 times). v2: use prime_handle_to_fd_for_mmap instead. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_mmap_write_crc.c | 236 + 3 files changed

[Intel-gfx] [PATCH igt 3/5] prime_mmap: Add basic tests to write in a bo using CPU

and available in the lib. v2: adds prime_handle_to_fd_with_mmap for skipping test in older kernels and test for invalid flags. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- lib/ioctl_wrappers.c | 25 +++ lib/ioctl_wrappers.h | 4 +++ tests/prime_mmap.c | 89

[Intel-gfx] [PATCH igt 5/5] tests/kms_mmap_write_crc: Demonstrate the need for end_cpu_access

It requires i915 changes to add end_cpu_access(). v2: Use local definitions so older kernels fail fine. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/kms_mmap_write_crc.c | 82 -- 1 file changed, 72 insertions(+), 10 deletions

[Intel-gfx] [PATCH igt 2/5] prime_mmap: Add new test for calling mmap() on dma-buf fds

userptr for testing. Add test for buffer overlapping. Signed-off-by: Rob Bradford r...@linux.intel.com Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/prime_mmap.c | 417

[Intel-gfx] [PATCH igt 1/5] lib: Add gem_userptr and __gem_userptr helpers

in the caller; bring gem_userptr_sync back to gem_userptr_blits; added gtkdoc. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- benchmarks/gem_userptr_benchmark.c | 55 +++- lib/ioctl_wrappers.c | 41 +++ lib/ioctl_wrappers.h | 13

[Intel-gfx] [PATCH igt] dma-buf mmap

mmap functionality -- hint hint could be applied right now in igt main repo hint hint :) Tiago Rob Bradford (1): prime_mmap: Add new test for calling mmap() on dma-buf fds Tiago Vignatti (4): lib: Add gem_userptr and __gem_userptr helpers prime_mmap: Add basic tests to write in a bo using

Re: [Intel-gfx] [PATCH v4] dma-buf: Add ioctls to allow userspace to flush

On 08/26/2015 09:58 AM, Daniel Vetter wrote: The other is that right now there's no user nor implementation in sight which actually does range-based flush optimizations, so I'm pretty much expecting we'll get it wrong. Maybe instead we should go one step further and remove the range from the

Re: [Intel-gfx] [PATCH v4] dma-buf: Add ioctls to allow userspace to flush

On 08/26/2015 11:51 AM, Daniel Vetter wrote: On Wed, Aug 26, 2015 at 11:32:30AM -0300, Tiago Vignatti wrote: On 08/26/2015 09:58 AM, Daniel Vetter wrote: The other is that right now there's no user nor implementation in sight which actually does range-based flush optimizations, so I'm pretty

[Intel-gfx] [PATCH v4] dma-buf: Add ioctls to allow userspace to flush

Semwal sumit.sem...@linaro.org Signed-off-by: Daniel Vetter daniel.vet...@intel.com Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- I'm unable to test the 2d sync properly, because begin/end access in i915 don't track mapped range for nothing. Documentation/dma-buf-sharing.txt

Re: [Intel-gfx] [PATCH 1/7] prime_mmap: Add new test for calling mmap() on dma-buf fds

Hi Daniel, On 08/13/2015 04:04 AM, Daniel Vetter wrote: On Wed, Aug 12, 2015 at 08:29:14PM -0300, Tiago Vignatti wrote: + /* Map too big */ + handle = gem_create(fd, BO_SIZE); + fill_bo(handle, BO_SIZE); + dma_buf_fd = prime_handle_to_fd(fd, handle); + igt_assert

Re: [Intel-gfx] [PATCH v4] mmap on the dma-buf directly

On 08/13/2015 08:09 AM, Thomas Hellstrom wrote: Tiago, I take it, this is intended to be a generic interface used mostly for 2D rendering. yup. generic is an important point that I've actually forgot to mention in the description, which is probably the whole motivation for bringing this up.

Re: [Intel-gfx] [PATCH 3/7] prime_mmap: Add basic tests to write in a bo using CPU

On 08/13/2015 04:01 AM, Daniel Vetter wrote: On Wed, Aug 12, 2015 at 08:29:16PM -0300, Tiago Vignatti wrote: This patch adds test_correct_cpu_write, which maps the texture buffer through a prime fd and then writes directly to it using the CPU. It stresses the driver to guarantee cache

[Intel-gfx] [PATCH 4/7] lib: Add gem_userptr helpers

This patch moves userptr definitions and helpers implementation that were locally in gem_userptr_benchmark and gem_userptr_blits to the library, so other tests can make use of them as well. There's no functional changes. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- benchmarks

[Intel-gfx] [PATCH 5/7] prime_mmap: Test for userptr mmap

A userptr doesn't have the obj-base.filp, but can be exported via dma-buf, so make sure it fails when mmaping. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- In machine, export the handle to fd is actually returning error and falling before the actual test happens. Same issue happens

[Intel-gfx] [PATCH 2/7] prime_mmap: Fix a few misc stuff

- Remove pattern_check(), which was walking through a useless iterator - Remove superfluous PROT_WRITE from gem_mmap, in test_correct() - Add binary file to .gitignore Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/.gitignore | 1 + tests/prime_mmap.c | 37

[Intel-gfx] [PATCH 3/4] drm/i915: Implement end_cpu_access

Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- drivers/gpu/drm/i915/i915_gem_dmabuf.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/i915_gem_dmabuf.c index e9c2bfd..8447ba4 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 4/4] drm/i915: Use CPU mapping for userspace dma-buf mmap()

the WARN_ON. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- drivers/gpu/drm/i915/i915_gem_dmabuf.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/i915_gem_dmabuf.c index 8447ba4..ecd00d6

[Intel-gfx] [PATCH 3/7] prime_mmap: Add basic tests to write in a bo using CPU

process (priviledged process). This requires kernel modifications (Daniel Thompson's drm: prime: Honour O_RDWR during prime-handle-to-fd). Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- lib/ioctl_wrappers.c | 5 +++- tests/prime_mmap.c | 65

[Intel-gfx] [PATCH 6/7] tests: Add kms_mmap_write_crc for cache coherency tests

-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_mmap_write_crc.c | 236 + 3 files changed, 238 insertions(+) create mode 100644 tests/kms_mmap_write_crc.c diff --git

[Intel-gfx] [PATCH 1/7] prime_mmap: Add new test for calling mmap() on dma-buf fds

checks for buffer reference counting - test_dup chats that dup()ing the fd works - test_errors checks the error return values for failures - test_aperture_limit tests multiple buffer creation at the gtt aperture limit Signed-off-by: Rob Bradford r...@linux.intel.com Signed-off-by: Tiago Vignatti

[Intel-gfx] [PATCH 1/4] drm: prime: Honour O_RDWR during prime-handle-to-fd

the restriction and permit read/write access. This is safe because the flags are seldom touched by drm; mostly they are passed verbatim to dma_buf calls. v3 (Tiago): removed unused flags variable from drm_prime_handle_to_fd_ioctl. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Signed-off-by: Tiago

[Intel-gfx] [PATCH 7/7] tests/kms_mmap_write_crc: Demonstrate the need for end_cpu_access

It requires i915 changes to add end_cpu_access(). Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/kms_mmap_write_crc.c | 63 -- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/tests/kms_mmap_write_crc.c b/tests

[Intel-gfx] [PATCH 2/4] dma-buf: Add ioctls to allow userspace to flush

functions. Check for overflows in start/length. Cc: Sumit Semwal sumit.sem...@linaro.org Signed-off-by: Daniel Vetter daniel.vet...@intel.com Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- Documentation/dma-buf-sharing.txt | 12 ++ drivers/dma-buf/dma-buf.c | 50

[Intel-gfx] [PATCH v4] mmap on the dma-buf directly

documentation and the FIXME missing in that same patch, and also removed WARN in i915 dma-buf mmap (pointed by Chris). PTAL. Best Regards, Tiago Daniel Thompson (1): drm: prime: Honour O_RDWR during prime-handle-to-fd Daniel Vetter (1): dma-buf: Add ioctls to allow userspace to flush Tiago

[Intel-gfx] [PATCH 4/4] drm/i915: Use CPU mapping for userspace dma-buf mmap()

Userspace is the one in charge of flush CPU by wrapping mmap with begin{,end}_cpu_access. v2: Remove LLC check cause we have dma-buf sync providers now. Also, fix return before transferring ownership when mmap fails. v3: Fix return values. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com

[Intel-gfx] [PATCH i-g-t 2/5] prime_mmap: Fix a few misc stuff

- Remove pattern_check(), which was walking through a useless iterator - Remove superfluous PROT_WRITE from gem_mmap, in test_correct() - Add binary file to .gitignore Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/.gitignore | 1 + tests/prime_mmap.c | 37

[Intel-gfx] [PATCH i-g-t 1/5] prime_mmap: Add new test for calling mmap() on dma-buf fds

checks for buffer reference counting - test_dup chats that dup()ing the fd works - test_errors checks the error return values for failures - test_aperture_limit tests multiple buffer creation at the gtt aperture limit Signed-off-by: Rob Bradford r...@linux.intel.com Signed-off-by: Tiago Vignatti

[Intel-gfx] [PATCH i-g-t 3/5] prime_mmap: Add basic tests to write in a bo using CPU

process (priviledged process). This requires kernel modifications (Daniel Thompson's drm: prime: Honour O_RDWR during prime-handle-to-fd). Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- lib/ioctl_wrappers.c | 5 +++- tests/prime_mmap.c | 65

[Intel-gfx] [PATCH v3] mmap on the dma-buf directly

the tests for review now. Please take a look. Tiago Daniel Thompson (1): drm: prime: Honour O_RDWR during prime-handle-to-fd Daniel Vetter (1): dma-buf: Add ioctls to allow userspace to flush Tiago Vignatti (2): drm/i915: Implement end_cpu_access drm/i915: Use CPU mapping for userspace dma

[Intel-gfx] [PATCH i-g-t 4/5] tests: Add kms_mmap_write_crc for cache coherency tests

-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/kms_mmap_write_crc.c | 236 + 3 files changed, 238 insertions(+) create mode 100644 tests/kms_mmap_write_crc.c diff --git

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_mmap_write_crc: Demonstrate the need for end_cpu_access

It requires i915 changes to add end_cpu_access(). Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- tests/kms_mmap_write_crc.c | 63 -- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/tests/kms_mmap_write_crc.c b/tests

[Intel-gfx] [PATCH 1/4] drm: prime: Honour O_RDWR during prime-handle-to-fd

the restriction and permit read/write access. This is safe because the flags are seldom touched by drm; mostly they are passed verbatim to dma_buf calls. v3 (Tiago): removed unused flags variable from drm_prime_handle_to_fd_ioctl. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Signed-off-by: Tiago

[Intel-gfx] [PATCH 2/4] dma-buf: Add ioctls to allow userspace to flush

- vmap and kmap interfaces are much different ... We might need to add a mapping enum to the begin/end dma-buf functions. v2 (Tiago): Fix header file type names (u64 - __u64) Signed-off-by: Daniel Vetter daniel.vet...@intel.com Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- drivers

[Intel-gfx] [PATCH 3/4] drm/i915: Implement end_cpu_access

Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- drivers/gpu/drm/i915/i915_gem_dmabuf.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/i915_gem_dmabuf.c index e9c2bfd..8447ba4 100644 --- a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use CPU mapping for userspace dma-buf mmap()

On 08/05/2015 04:08 AM, Daniel Vetter wrote: On Tue, Aug 04, 2015 at 06:30:25PM -0300, Tiago Vignatti wrote: Nah they don't have to be equal since the problem isn't that nothing goes out to memory where the display can see it, but usually only parts of it. I.e. you need to change your test

[Intel-gfx] [PATCH 3/3] drm/i915: Use CPU mapping for userspace dma-buf mmap()

Userspace is the one in charge of flush CPU by wrapping mmap with begin{,end}_cpu_access. v2: Remove LLC check cause we have dma-buf sync providers now. Also, fix return before transferring ownership when mmap fails. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- drivers/gpu/drm

[Intel-gfx] [PATCH 2/3] dma-buf: Add ioctls to allow userspace to flush

- vmap and kmap interfaces are much different ... We might need to add a mapping enum to the begin/end dma-buf functions. v2 (Tiago): Fix header file type names (u64 - __u64) Signed-off-by: Daniel Vetter daniel.vet...@intel.com Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- drivers

[Intel-gfx] [PATCH v2 0/3] mmap on the dma-buf directly

fd. To validate it I've built a test on top of igt's kms_pwrite_crc (which I'll be sending next for review). Let me know your concerns. Tiago Daniel Thompson (1): drm: prime: Honour O_RDWR during prime-handle-to-fd Daniel Vetter (1): dma-buf: Add ioctls to allow userspace to flush Tiago

[Intel-gfx] [PATCH 1/3] drm: prime: Honour O_RDWR during prime-handle-to-fd

the restriction and permit read/write access. This is safe because the flags are seldom touched by drm; mostly they are passed verbatim to dma_buf calls. v3 (Tiago): removed unused flags variable from drm_prime_handle_to_fd_ioctl. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Signed-off-by: Tiago

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use CPU mapping for userspace dma-buf mmap()

2001 From: Tiago Vignatti tiago.vigna...@intel.com Date: Tue, 4 Aug 2015 13:38:09 -0300 Subject: [PATCH] tests: Add prime_crc for cache coherency This program can be used to detect when the writes don't land in scanout, due cache incoherency. Run it like ./prime_crc --interactive-debug=crc Signed

[Intel-gfx] [PATCH 0/2] mmap on the dma-buf directly

-gpu-tools/commits/prime_mmap Thank you, Tiago Daniel Thompson (1): drm: prime: Honour O_RDWR during prime-handle-to-fd Tiago Vignatti (1): drm/i915: Use CPU mapping for userspace dma-buf mmap() drivers/gpu/drm/drm_prime.c| 10 +++--- drivers/gpu/drm/i915/i915_gem_dmabuf.c

[Intel-gfx] [PATCH 2/2] drm: prime: Honour O_RDWR during prime-handle-to-fd

the restriction and permit read/write access. This is safe because the flags are seldom touched by drm; mostly they are passed verbatim to dma_buf calls. v3 (Tiago): removed unused flags variable from drm_prime_handle_to_fd_ioctl. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Signed-off-by: Tiago

[Intel-gfx] [PATCH 1/2] drm/i915: Use CPU mapping for userspace dma-buf mmap()

ioctls to allow userspace flush, controlling manually the synchronization via begin{,end}_cpu_access. Signed-off-by: Tiago Vignatti tiago.vigna...@intel.com --- drivers/gpu/drm/i915/i915_gem_dmabuf.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/gpu