[Intel-gfx] [PATCH] drm/i915/gt: Do not add same i915_request to intel_context twice

2021-12-09 Thread dong . yang 
From: "Yang, Dong" 

With unknow race condition, the i915_request will be added
to intel_context list twice, and result in system panic.

If node alreay exist then do not add it again.

Signed-off-by: Yang, Dong 
---
 drivers/gpu/drm/i915/gt/intel_breadcrumbs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c 
b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
index 209cf265bf74..9c7bc060d2ae 100644
--- a/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
+++ b/drivers/gpu/drm/i915/gt/intel_breadcrumbs.c
@@ -387,6 +387,9 @@ static void insert_breadcrumb(struct i915_request *rq)
}
}
 
+   if (&rq->signal_link == pos)
+   return;
+
i915_request_get(rq);
list_add_rcu(&rq->signal_link, pos);
GEM_BUG_ON(!check_signal_order(ce, rq));
-- 
2.27.0

[Intel-gfx] [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0

2019-08-14 Thread dong . yang 
From: "Yang, Dong" 

Broxton steppings starting from GT E0 have fixed the bug, remove
WA since stepping GT E0.

v2: use BXT_REVID_D_LAST replace BXT_REVID_D0, by:
Joonas Lahtinen 

Signed-off-by: Yang, Dong 
---
 drivers/gpu/drm/i915/i915_drv.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..b1cda9dcbea4 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define BXT_REVID_B0   0x3
 #define BXT_REVID_B_LAST   0x8
 #define BXT_REVID_C0   0x9
+#define BXT_REVID_D_LAST   0xC
+#define BXT_REVID_E0   0xD
 
 #define IS_BXT_REVID(dev_priv, since, until) \
(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,7 @@ static inline bool intel_scanout_needs_vtd_wa(struct 
drm_i915_private *dev_priv)
 static inline bool
 intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
 {
-   return IS_BROXTON(dev_priv) && intel_vtd_active();
+   return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D_LAST) && 
intel_vtd_active();
 }
 
 /* i915_drv.c */
-- 
2.22.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2] drm/i915: Remove i915 ggtt WA since GT E0

2019-08-14 Thread dong . yang 
From: "Yang, Dong" 

Broxton steppings starting from GT E0 have fixed the bug, remove
WA since stepping GT E0.

v2: add comment in code, by:
Joonas Lahtinen 

Signed-off-by: Yang, Dong 
---
 drivers/gpu/drm/i915/i915_drv.h | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..a0dfd1926b1b 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define BXT_REVID_B0   0x3
 #define BXT_REVID_B_LAST   0x8
 #define BXT_REVID_C0   0x9
+#define BXT_REVID_D0   0xC
+#define BXT_REVID_E0   0xD
 
 #define IS_BXT_REVID(dev_priv, since, until) \
(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,8 @@ static inline bool intel_scanout_needs_vtd_wa(struct 
drm_i915_private *dev_priv)
 static inline bool
 intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
 {
-   return IS_BROXTON(dev_priv) && intel_vtd_active();
+   /* Broxton steppings starting from E0 have fixed the bug. */
+   return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && intel_vtd_active();
 }
 
 /* i915_drv.c */
-- 
2.22.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E0

2019-08-13 Thread Dong Yang 
From: "Yang, Dong" 

Broxton steppings starting from GT E0 have fixed the bug, remove
WA since stepping GT E0.

Signed-off-by: Yang, Dong 
---
 drivers/gpu/drm/i915/i915_drv.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..95519bac8948 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define BXT_REVID_B0   0x3
 #define BXT_REVID_B_LAST   0x8
 #define BXT_REVID_C0   0x9
+#define BXT_REVID_D0   0xC
+#define BXT_REVID_E0   0xD
 
 #define IS_BXT_REVID(dev_priv, since, until) \
(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,7 @@ static inline bool intel_scanout_needs_vtd_wa(struct 
drm_i915_private *dev_priv)
 static inline bool
 intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
 {
-   return IS_BROXTON(dev_priv) && intel_vtd_active();
+   return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && intel_vtd_active();
 }
 
 /* i915_drv.c */
-- 
2.22.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E

2019-08-11 Thread Dong Yang 
From: "Yang, Dong" 

The APL already fixed this bug since GT E, bug exist from
0 to D, apply WA according GT stepping.

Signed-off-by: Yang, Dong 
---
 drivers/gpu/drm/i915/i915_drv.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..95519bac8948 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define BXT_REVID_B0   0x3
 #define BXT_REVID_B_LAST   0x8
 #define BXT_REVID_C0   0x9
+#define BXT_REVID_D0   0xC
+#define BXT_REVID_E0   0xD
 
 #define IS_BXT_REVID(dev_priv, since, until) \
(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,7 @@ static inline bool intel_scanout_needs_vtd_wa(struct 
drm_i915_private *dev_priv)
 static inline bool
 intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
 {
-   return IS_BROXTON(dev_priv) && intel_vtd_active();
+   return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && intel_vtd_active();
 }
 
 /* i915_drv.c */
-- 
2.22.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Remove i915 ggtt WA since GT E

2019-08-11 Thread Dong Yang 
From: "Yang, Dong" 

The APL already fixed this bug since GT E, bug exist from
0 to D, apply WA according GT stepping.

Signed-off-by: Yang, Dong 
---
 drivers/gpu/drm/i915/i915_drv.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5f3e5c13fbaa..ee384c28174a 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2141,6 +2141,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define BXT_REVID_B0   0x3
 #define BXT_REVID_B_LAST   0x8
 #define BXT_REVID_C0   0x9
+#define BXT_REVID_D0   0xC
+#define BXT_REVID_E0   0xD
 
 #define IS_BXT_REVID(dev_priv, since, until) \
(IS_BROXTON(dev_priv) && IS_REVID(dev_priv, since, until))
@@ -2357,7 +2359,7 @@ static inline bool intel_scanout_needs_vtd_wa(struct 
drm_i915_private *dev_priv)
 static inline bool
 intel_ggtt_update_needs_vtd_wa(struct drm_i915_private *dev_priv)
 {
-   return IS_BROXTON(dev_priv) && intel_vtd_active();
+   return return IS_BXT_REVID(dev_priv, 0, BXT_REVID_D0) && 
intel_vtd_active();
 }
 
 /* i915_drv.c */
-- 
2.22.0

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx