Re: [Intel-gfx] [PATCH] RFC drm/i915/pmu: Avoid sleeping rpm_get under atomic PMU read

2018-02-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-02-05 09:47:52) > > On 05/02/2018 09:11, Chris Wilson wrote: > > The pmu_event_read() callchain is in an atomic context which then > > Call-chain. > > > forbids us sleeping, such as required to wake the device up for rpm. > > In this case, we can only read our

Re: [Intel-gfx] [PATCH] RFC drm/i915/pmu: Avoid sleeping rpm_get under atomic PMU read

2018-02-05 Thread Tvrtko Ursulin
On 05/02/2018 09:11, Chris Wilson wrote: The pmu_event_read() callchain is in an atomic context which then Call-chain. forbids us sleeping, such as required to wake the device up for rpm. In this case, we can only read our registers iff the device is already s/iff/if/ awake. In the case

[Intel-gfx] [PATCH] RFC drm/i915/pmu: Avoid sleeping rpm_get under atomic PMU read

2018-02-05 Thread Chris Wilson
The pmu_event_read() callchain is in an atomic context which then forbids us sleeping, such as required to wake the device up for rpm. In this case, we can only read our registers iff the device is already awake. In the case of rc6 this means that we cannot report the latest values when the whole