Re: [Intel-gfx] [PATCH] drm/i915/bios: filter out invalid DDC pins from VBT child devices

2018-04-11 Thread Chris Wilson
Quoting Jani Nikula (2018-04-11 13:53:09) > On Wed, 11 Apr 2018, Chris Wilson wrote: > > Quoting Jani Nikula (2018-04-11 10:01:46) > >> diff --git a/drivers/gpu/drm/i915/intel_bios.c > >> b/drivers/gpu/drm/i915/intel_bios.c > >> index c5c7530ba157..6db845991a69 100644 >

Re: [Intel-gfx] [PATCH] drm/i915/bios: filter out invalid DDC pins from VBT child devices

2018-04-11 Thread Jani Nikula
On Wed, 11 Apr 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-04-11 10:01:46) >> diff --git a/drivers/gpu/drm/i915/intel_bios.c >> b/drivers/gpu/drm/i915/intel_bios.c >> index c5c7530ba157..6db845991a69 100644 >> --- a/drivers/gpu/drm/i915/intel_bios.c >> +++

Re: [Intel-gfx] [PATCH] drm/i915/bios: filter out invalid DDC pins from VBT child devices

2018-04-11 Thread Chris Wilson
Quoting Jani Nikula (2018-04-11 10:01:46) > The VBT contains the DDC pin to use for specific ports. Alas, sometimes > the field appears to contain bogus data, and while we check for it later > on in intel_gmbus_get_adapter() we fail to check the returned NULL on > errors. Oops results. > > The

Re: [Intel-gfx] [PATCH] drm/i915/bios: filter out invalid DDC pins from VBT child devices

2018-04-11 Thread Jani Nikula
On Wed, 11 Apr 2018, Jani Nikula wrote: > The VBT contains the DDC pin to use for specific ports. Alas, sometimes > the field appears to contain bogus data, and while we check for it later > on in intel_gmbus_get_adapter() we fail to check the returned NULL on > errors.

[Intel-gfx] [PATCH] drm/i915/bios: filter out invalid DDC pins from VBT child devices

2018-04-11 Thread Jani Nikula
The VBT contains the DDC pin to use for specific ports. Alas, sometimes the field appears to contain bogus data, and while we check for it later on in intel_gmbus_get_adapter() we fail to check the returned NULL on errors. Oops results. The simplest approach seems to be to catch and ignore the