Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

[Mika Kuoppala]

Chris Wilson  writes:

> On Tue, Oct 18, 2016 at 04:15:22PM +0300, Mika Kuoppala wrote:
>> Mika Kuoppala  writes:
>> 
>> > Arkadiusz Hiler  writes:
>> >
>> >> Dropping WA because it was for early steppings.
>> >>
>> >> It is fixed in newer preproduction and all production revisions.
>> >>
>> >
>> > We have used References tag to point to a relevant document
>> > that has more information. Like for this, it should be:
>> >
>> > References: HSD#2126385
>> >
>> > From there I did figure out that this should be from skl:C0 onwards.
>> >
>> > So based on that, we need this wa still.
>> 
>> I fell victim of out-of-date/conflicting information.
>> Arkadiusz kindly pointed me to the correct sources and cleared
>> the confusion. I am convinced we can drop this workaround.
>
> So documentation link / hint to clear the confusion?

Wa database had FROM_C0 and hsd,bspec has UNTIL_B0.
-Mika

> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

[Chris Wilson]

On Tue, Oct 18, 2016 at 04:15:22PM +0300, Mika Kuoppala wrote:
> Mika Kuoppala  writes:
> 
> > Arkadiusz Hiler  writes:
> >
> >> Dropping WA because it was for early steppings.
> >>
> >> It is fixed in newer preproduction and all production revisions.
> >>
> >
> > We have used References tag to point to a relevant document
> > that has more information. Like for this, it should be:
> >
> > References: HSD#2126385
> >
> > From there I did figure out that this should be from skl:C0 onwards.
> >
> > So based on that, we need this wa still.
> 
> I fell victim of out-of-date/conflicting information.
> Arkadiusz kindly pointed me to the correct sources and cleared
> the confusion. I am convinced we can drop this workaround.

So documentation link / hint to clear the confusion?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

[Mika Kuoppala]

Mika Kuoppala  writes:

> Arkadiusz Hiler  writes:
>
>> Dropping WA because it was for early steppings.
>>
>> It is fixed in newer preproduction and all production revisions.
>>
>
> We have used References tag to point to a relevant document
> that has more information. Like for this, it should be:
>
> References: HSD#2126385
>
> From there I did figure out that this should be from skl:C0 onwards.
>
> So based on that, we need this wa still.

I fell victim of out-of-date/conflicting information.
Arkadiusz kindly pointed me to the correct sources and cleared
the confusion. I am convinced we can drop this workaround.

Reviewed-by: Mika Kuoppala 

>
> -Mika
>
>
>> Cc: Michal Winiarski 
>> Signed-off-by: Arkadiusz Hiler 
>> ---
>>  drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c 
>> b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> index e107455..32786ba 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> @@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs 
>> *engine)
>>   */
>>  }
>>  
>> -/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
>>  /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
>>  WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
>> -  GEN9_ENABLE_YV12_BUGFIX |
>>GEN9_ENABLE_GPGPU_PREEMPTION);
>>  
>>  /* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
>> -- 
>> 2.7.4
>> ___
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

[Mika Kuoppala]

Arkadiusz Hiler  writes:

> Dropping WA because it was for early steppings.
>
> It is fixed in newer preproduction and all production revisions.
>

We have used References tag to point to a relevant document
that has more information. Like for this, it should be:

References: HSD#2126385

From there I did figure out that this should be from skl:C0 onwards.

So based on that, we need this wa still.

-Mika


> Cc: Michal Winiarski 
> Signed-off-by: Arkadiusz Hiler 
> ---
>  drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c 
> b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index e107455..32786ba 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs 
> *engine)
>*/
>   }
>  
> - /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
>   /* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
>   WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
> -   GEN9_ENABLE_YV12_BUGFIX |
> GEN9_ENABLE_GPGPU_PREEMPTION);
>  
>   /* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
> -- 
> 2.7.4
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/gen9: Remove WaEnableYV12BugFixInHalfSliceChicken7

[Arkadiusz Hiler]

Dropping WA because it was for early steppings.

It is fixed in newer preproduction and all production revisions.

Cc: Michal Winiarski 
Signed-off-by: Arkadiusz Hiler 
---
 drivers/gpu/drm/i915/intel_ringbuffer.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c 
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index e107455..32786ba 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -849,10 +849,8 @@ static int gen9_init_workarounds(struct intel_engine_cs 
*engine)
 */
}
 
-   /* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt,kbl */
/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt,kbl */
WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
- GEN9_ENABLE_YV12_BUGFIX |
  GEN9_ENABLE_GPGPU_PREEMPTION);
 
/* Wa4x4STCOptimizationDisable:skl,bxt,kbl */
-- 
2.7.4
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx