Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 12:44:52PM +0200, Tomi Sarvela wrote: > On Thursday, 12 January 2017 10:33:47 EET Chris Wilson wrote: > > On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote: > > > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT > > > offsets used by the GuC are

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-12 Thread Tomi Sarvela
On Thursday, 12 January 2017 10:33:47 EET Chris Wilson wrote: > On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote: > > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT > > offsets used by the GuC are mappable"), we're asserting that GuC > > firmware is in the GuC mappab

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-12 Thread Chris Wilson
On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote: > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT offsets used > by the GuC are mappable"), we're asserting that GuC firmware is in the > GuC mappable range. > Except we're not pinning the object with bias, which means

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-11 Thread Daniele Ceraolo Spurio
On 11/01/17 07:17, Michał Winiarski wrote: Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT offsets used by the GuC are mappable"), we're asserting that GuC firmware is in the GuC mappable range. Except we're not pinning the object with bias, which means it's possible to trigger t

Re: [Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-11 Thread Chris Wilson
On Wed, Jan 11, 2017 at 04:17:39PM +0100, Michał Winiarski wrote: > Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT offsets used > by the GuC are mappable"), we're asserting that GuC firmware is in the > GuC mappable range. > Except we're not pinning the object with bias, which means

[Intel-gfx] [PATCH] drm/i915/guc: Make sure vma containing firmware is GuC mappable

2017-01-11 Thread Michał Winiarski
Since commit 4741da925fa3 ("drm/i915/guc: Assert that all GGTT offsets used by the GuC are mappable"), we're asserting that GuC firmware is in the GuC mappable range. Except we're not pinning the object with bias, which means it's possible to trigger this assert. Let's add a proper bias. Cc: Chris