Re: [Intel-gfx] [PATCH] drm/i915: Cancel persistent contexts if !hangcheck

2019-08-06 Thread Chris Wilson
Quoting Andi Shyti (2019-08-06 09:35:49) > Hi Chris, > > > +static void kill_context(struct i915_gem_context *ctx) > > +{ > > + struct i915_gem_engines_iter it; > > + struct intel_engine_cs *engine; > > + intel_engine_mask_t tmp, active; > > + struct intel_context *ce; > > + > > +

Re: [Intel-gfx] [PATCH] drm/i915: Cancel persistent contexts if !hangcheck

2019-08-06 Thread Andi Shyti
Hi Chris, > +static void kill_context(struct i915_gem_context *ctx) > +{ > + struct i915_gem_engines_iter it; > + struct intel_engine_cs *engine; > + intel_engine_mask_t tmp, active; > + struct intel_context *ce; > + > + if (i915_gem_context_is_banned(ctx)) > +

[Intel-gfx] [PATCH] drm/i915: Cancel persistent contexts if !hangcheck

2019-08-05 Thread Chris Wilson
Normally, we rely on our hangcheck to prevent persistent batches from hogging the GPU. However, if the user disables hangcheck, this mechanism breaks down. Despite our insistence that this is unsafe, the users are equally insistent that they want to use endless batches and will disable the