Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-15 10:08:09) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2018-08-15 09:52:18) > >> Chris Wilson writes: > >> > >> > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted > >> > in RING_MI_MODE resulting in the engine hanging.

Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-08-15 09:52:18) >> Chris Wilson writes: >> >> > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted >> > in RING_MI_MODE resulting in the engine hanging. Unconditionally clear >> > it on the per-engine exit path as we know

Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Chris Wilson
Quoting Mika Kuoppala (2018-08-15 09:52:18) > Chris Wilson writes: > > > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted > > in RING_MI_MODE resulting in the engine hanging. Unconditionally clear > > it on the per-engine exit path as we know that either we skipped the >

Re: [Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-15 Thread Mika Kuoppala
Chris Wilson writes: > If we pardon a per-engine reset, we may leave the STOP_RING bit asserted > in RING_MI_MODE resulting in the engine hanging. Unconditionally clear > it on the per-engine exit path as we know that either we skipped the > reset and so need the cancellation, or the reset was

[Intel-gfx] [PATCH] drm/i915: Clear stop-engine for a pardoned reset

2018-08-14 Thread Chris Wilson
If we pardon a per-engine reset, we may leave the STOP_RING bit asserted in RING_MI_MODE resulting in the engine hanging. Unconditionally clear it on the per-engine exit path as we know that either we skipped the reset and so need the cancellation, or the reset was successful and the cancellation