[Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-25 Thread Chris Wilson
Report back the user error of attempting to setup a CRTC with an invalid framebuffer pitch. This is trickier than it should be as on gen4, there is a restriction that tiled surfaces must have a stride less than 16k - which is less than the largest supported CRTC size. v2: Fix the limits for gen3

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-24 Thread Ville Syrjälä
On Thu, Jun 20, 2013 at 05:14:20PM +0100, Chris Wilson wrote: Report back the user error of attempting to setup a CRTC with an invalid framebuffer pitch. This is trickier than it should be as on gen4, there is a restriction that tiled surfaces must have a stride less than 16k - which is less

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Ville Syrjälä
On Wed, Jun 19, 2013 at 04:50:34PM +0100, Chris Wilson wrote: Report back the user error of attempting to setup a CRTC with an invalid framebuffer pitch. This is trickier than it should be as on gen4, there is a restriction that tiled surfaces must have a stride less than 16k - which is less

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Chris Wilson
On Thu, Jun 20, 2013 at 11:17:16AM +0300, Ville Syrjälä wrote: We already have a bit of pitch checking in intel_framebuffer_init(). In fact there's a FIXME about pre-ilk limits there. It looks tidier to fix that check. We still need to double check the values though as the tiling mode is

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Ville Syrjälä
On Thu, Jun 20, 2013 at 10:14:36AM +0100, Chris Wilson wrote: On Thu, Jun 20, 2013 at 11:17:16AM +0300, Ville Syrjälä wrote: We already have a bit of pitch checking in intel_framebuffer_init(). In fact there's a FIXME about pre-ilk limits there. It looks tidier to fix that check. We still

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Ville Syrjälä
On Thu, Jun 20, 2013 at 10:14:36AM +0100, Chris Wilson wrote: On Thu, Jun 20, 2013 at 11:17:16AM +0300, Ville Syrjälä wrote: Assuming all the planes on a specific piece of hardware have the same pitch limits, I'd like the checks to be live in intel_framebuffer_init() so that the issue gets

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Chris Wilson
On Thu, Jun 20, 2013 at 01:29:10PM +0300, Ville Syrjälä wrote: On Thu, Jun 20, 2013 at 10:14:36AM +0100, Chris Wilson wrote: On Thu, Jun 20, 2013 at 11:17:16AM +0300, Ville Syrjälä wrote: We already have a bit of pitch checking in intel_framebuffer_init(). In fact there's a FIXME about

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Ville Syrjälä
On Thu, Jun 20, 2013 at 01:27:14PM +0100, Chris Wilson wrote: On Thu, Jun 20, 2013 at 01:29:10PM +0300, Ville Syrjälä wrote: On Thu, Jun 20, 2013 at 10:14:36AM +0100, Chris Wilson wrote: On Thu, Jun 20, 2013 at 11:17:16AM +0300, Ville Syrjälä wrote: We already have a bit of pitch

Re: [Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Chris Wilson
On Thu, Jun 20, 2013 at 03:44:56PM +0300, Ville Syrjälä wrote: On Thu, Jun 20, 2013 at 01:27:14PM +0100, Chris Wilson wrote: On Thu, Jun 20, 2013 at 01:29:10PM +0300, Ville Syrjälä wrote: On Thu, Jun 20, 2013 at 10:14:36AM +0100, Chris Wilson wrote: On Thu, Jun 20, 2013 at 11:17:16AM

[Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-20 Thread Chris Wilson
Report back the user error of attempting to setup a CRTC with an invalid framebuffer pitch. This is trickier than it should be as on gen4, there is a restriction that tiled surfaces must have a stride less than 16k - which is less than the largest supported CRTC size. v2: Fix the limits for gen3

[Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-19 Thread Chris Wilson
Report back the user error of attempting to setup a CRTC with an invalid framebuffer pitch. This is trickier than it should be as on gen4, there is a restriction that tiled surfaces must have a stride less than 16k - which is less than the largest supported CRTC size. References:

[Intel-gfx] [PATCH] drm/i915: Detect invalid scanout pitches

2013-06-19 Thread Chris Wilson
Report back the user error of attempting to setup a CRTC with an invalid framebuffer pitch. This is trickier than it should be as on gen4, there is a restriction that tiled surfaces must have a stride less than 16k - which is less than the largest supported CRTC size. v2: Fix the limits for gen3