Re: [Intel-gfx] [PATCH] drm/i915: Don't pretend ips is always enabled on BDW.

2014-07-07 Thread Daniel Vetter 
On Mon, Jun 30, 2014 at 04:17:00PM -0300, Paulo Zanoni wrote:
 2014-06-30 8:45 GMT-03:00 Rodrigo Vivi rodrigo.v...@intel.com:
  As pointed out before we don't have a reliable way to read back ips
  status on BDW without the risk to disable it when reading.
  However now we are pretending that IPS on BDW is always on and getting
  people confused about it.
 
  So this patch allows people to know if ips was ever attempted to be enabled.
  Even if the current status is impossible to be ascertain.
 
  v2: (spotted by Paulo):
   * A version that at least compiles
   * with more clear messages
   * let Cheryview on the safe side until we aren't sure that checking ips
 state on ips won't disable it.
 
  Cc: Paulo Zanoni paulo.r.zan...@intel.com
  Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com
 
 Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Don't pretend ips is always enabled on BDW.

2014-06-30 Thread Rodrigo Vivi 
As pointed out before we don't have a reliable way to read back ips
status on BDW without the risk to disable it when reading.
However now we are pretending that IPS on BDW is always on and getting
people confused about it.

So this patch allows people to know if ips was ever attempted to be enabled.
Even if the current status is impossible to be ascertain.

v2: (spotted by Paulo):
 * A version that at least compiles
 * with more clear messages
 * let Cheryview on the safe side until we aren't sure that checking ips
   state on ips won't disable it.

Cc: Paulo Zanoni paulo.r.zan...@intel.com
Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com
---
 drivers/gpu/drm/i915/i915_debugfs.c | 15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
b/drivers/gpu/drm/i915/i915_debugfs.c
index a93b3bf..380be89 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1523,10 +1523,17 @@ static int i915_ips_status(struct seq_file *m, void 
*unused)
 
intel_runtime_pm_get(dev_priv);
 
-   if (IS_BROADWELL(dev) || I915_READ(IPS_CTL)  IPS_ENABLE)
-   seq_puts(m, enabled\n);
-   else
-   seq_puts(m, disabled\n);
+   seq_printf(m, Enabled by kernel parameter: %s\n,
+  yesno(i915.enable_ips));
+
+   if (INTEL_INFO(dev)-gen = 8) {
+   seq_puts(m, Currently: unknown\n);
+   } else {
+   if (I915_READ(IPS_CTL)  IPS_ENABLE)
+   seq_puts(m, Currently: enabled\n);
+   else
+   seq_puts(m, Currently: disabled\n);
+   }
 
intel_runtime_pm_put(dev_priv);
 
-- 
1.9.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Don't pretend ips is always enabled on BDW.

2014-06-30 Thread Paulo Zanoni 
2014-06-30 8:45 GMT-03:00 Rodrigo Vivi rodrigo.v...@intel.com:
 As pointed out before we don't have a reliable way to read back ips
 status on BDW without the risk to disable it when reading.
 However now we are pretending that IPS on BDW is always on and getting
 people confused about it.

 So this patch allows people to know if ips was ever attempted to be enabled.
 Even if the current status is impossible to be ascertain.

 v2: (spotted by Paulo):
  * A version that at least compiles
  * with more clear messages
  * let Cheryview on the safe side until we aren't sure that checking ips
state on ips won't disable it.

 Cc: Paulo Zanoni paulo.r.zan...@intel.com
 Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com

Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com

 ---
  drivers/gpu/drm/i915/i915_debugfs.c | 15 +++
  1 file changed, 11 insertions(+), 4 deletions(-)

 diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
 b/drivers/gpu/drm/i915/i915_debugfs.c
 index a93b3bf..380be89 100644
 --- a/drivers/gpu/drm/i915/i915_debugfs.c
 +++ b/drivers/gpu/drm/i915/i915_debugfs.c
 @@ -1523,10 +1523,17 @@ static int i915_ips_status(struct seq_file *m, void 
 *unused)

 intel_runtime_pm_get(dev_priv);

 -   if (IS_BROADWELL(dev) || I915_READ(IPS_CTL)  IPS_ENABLE)
 -   seq_puts(m, enabled\n);
 -   else
 -   seq_puts(m, disabled\n);
 +   seq_printf(m, Enabled by kernel parameter: %s\n,
 +  yesno(i915.enable_ips));
 +
 +   if (INTEL_INFO(dev)-gen = 8) {
 +   seq_puts(m, Currently: unknown\n);
 +   } else {
 +   if (I915_READ(IPS_CTL)  IPS_ENABLE)
 +   seq_puts(m, Currently: enabled\n);
 +   else
 +   seq_puts(m, Currently: disabled\n);
 +   }

 intel_runtime_pm_put(dev_priv);

 --
 1.9.3

 ___
 Intel-gfx mailing list
 Intel-gfx@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Don't pretend ips is always enabled on BDW.

2014-06-27 Thread Rodrigo Vivi 
As pointed out before we don't have a reliable way to read back ips
status on BDW without the risk to disable it when reading.
However now we are pretending that IPS on BDW is always on and getting
people confused about it.

So this patch allows people to know if ips was ever attempted to be enabled.
Even if the current status is impossible to be ascertain.

Signed-off-by: Rodrigo Vivi rodrigo.v...@intel.com
---
 drivers/gpu/drm/i915/i915_debugfs.c | 14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c 
b/drivers/gpu/drm/i915/i915_debugfs.c
index a93b3bf..5e36b3c 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1523,10 +1523,16 @@ static int i915_ips_status(struct seq_file *m, void 
*unused)
 
intel_runtime_pm_get(dev_priv);
 
-   if (IS_BROADWELL(dev) || I915_READ(IPS_CTL)  IPS_ENABLE)
-   seq_puts(m, enabled\n);
-   else
-   seq_puts(m, disabled\n);
+   seq_puts(m, Enabled on boot: %s\n, yesno(i915.ips_enabled));
+
+   if (IS_BROADWELL(dev)) {
+   seq_puts(m, Currently: impossible to ascertain\n);
+   } else {
+   if (I915_READ(IPS_CTL)  IPS_ENABLE)
+   seq_puts(m, Currently: enabled\n);
+   else
+   seq_puts(m, Currently: disabled\n);
+   }
 
intel_runtime_pm_put(dev_priv);
 
-- 
1.9.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx