Re: [Intel-gfx] [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better.

2018-03-06 Thread Rodrigo Vivi
On Tue, Mar 06, 2018 at 09:12:02PM +0100, Maarten Lankhorst wrote: > Op 06-03-18 om 21:02 schreef Rodrigo Vivi: > > On Tue, Mar 06, 2018 at 11:22:16AM +0100, Maarten Lankhorst wrote: > >> Op 05-03-18 om 19:50 schreef Rodrigo Vivi: > >>> On Mon, Mar 05, 2018 at 01:36:08PM +0100, Maarten Lankhorst wr

Re: [Intel-gfx] [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better.

2018-03-06 Thread Maarten Lankhorst
Op 06-03-18 om 21:02 schreef Rodrigo Vivi: > On Tue, Mar 06, 2018 at 11:22:16AM +0100, Maarten Lankhorst wrote: >> Op 05-03-18 om 19:50 schreef Rodrigo Vivi: >>> On Mon, Mar 05, 2018 at 01:36:08PM +0100, Maarten Lankhorst wrote: If i915.enable_fbc is cleared at runtime, but FBC was previously

Re: [Intel-gfx] [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better.

2018-03-06 Thread Rodrigo Vivi
On Tue, Mar 06, 2018 at 11:22:16AM +0100, Maarten Lankhorst wrote: > Op 05-03-18 om 19:50 schreef Rodrigo Vivi: > > On Mon, Mar 05, 2018 at 01:36:08PM +0100, Maarten Lankhorst wrote: > >> If i915.enable_fbc is cleared at runtime, but FBC was previously enabled > >> then we don't disable FBC until t

Re: [Intel-gfx] [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better.

2018-03-06 Thread Maarten Lankhorst
Op 05-03-18 om 19:50 schreef Rodrigo Vivi: > On Mon, Mar 05, 2018 at 01:36:08PM +0100, Maarten Lankhorst wrote: >> If i915.enable_fbc is cleared at runtime, but FBC was previously enabled >> then we don't disable FBC until the next time the crtc is disabled. >> >> Make sure that if the module param

Re: [Intel-gfx] [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better.

2018-03-05 Thread Rodrigo Vivi
On Mon, Mar 05, 2018 at 01:36:08PM +0100, Maarten Lankhorst wrote: > If i915.enable_fbc is cleared at runtime, but FBC was previously enabled > then we don't disable FBC until the next time the crtc is disabled. > > Make sure that if the module param is changed, we disable FBC in > intel_fbc_post_

[Intel-gfx] [PATCH] drm/i915: Handle changing enable_fbc parameter at runtime better.

2018-03-05 Thread Maarten Lankhorst
If i915.enable_fbc is cleared at runtime, but FBC was previously enabled then we don't disable FBC until the next time the crtc is disabled. Make sure that if the module param is changed, we disable FBC in intel_fbc_post_update so we never have to worry about disabling. Signed-off-by: Maarten Lan