Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

Rodrigo Vivi writes: > On Sat, Feb 10, 2018 at 09:43:59AM +, Chris Wilson wrote: >> Quoting Andy Lutomirski (2018-02-09 17:55:38) >> > On Fri, Feb 9, 2018 at 7:39 AM, Rodrigo Vivi >> > wrote: >> > > Rodrigo Vivi

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

On Sat, Feb 10, 2018 at 09:43:59AM +, Chris Wilson wrote: > Quoting Andy Lutomirski (2018-02-09 17:55:38) > > On Fri, Feb 9, 2018 at 7:39 AM, Rodrigo Vivi wrote: > > > Rodrigo Vivi writes: > > > So, I move the hacked scheduled to 10s and forced

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

Quoting Andy Lutomirski (2018-02-09 17:55:38) > On Fri, Feb 9, 2018 at 7:39 AM, Rodrigo Vivi wrote: > > Rodrigo Vivi writes: > > So, I move the hacked scheduled to 10s and forced psr_activate 10ms > > after that and the result is this: > > > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

On Thu, 2018-02-08 at 23:39 -0800, Rodrigo Vivi wrote: > Rodrigo Vivi writes: > > > "Pandiyan, Dhinakaran" writes: > > > >> On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: > >>> Hi Andy, > >>> > >>> thanks for getting involved with

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

On Fri, Feb 9, 2018 at 7:39 AM, Rodrigo Vivi wrote: > Rodrigo Vivi writes: > >> "Pandiyan, Dhinakaran" writes: >> >>> On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: Hi Andy, thanks for getting

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

Rodrigo Vivi writes: > "Pandiyan, Dhinakaran" writes: > >> On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: >>> Hi Andy, >>> >>> thanks for getting involved with PSR and sorry for not replying sooner. >>> >>> I first saw this patch on

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

"Pandiyan, Dhinakaran" writes: > On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: >> Hi Andy, >> >> thanks for getting involved with PSR and sorry for not replying sooner. >> >> I first saw this patch on that bugzilla entry but only now I stop to >> really

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

On Thu, 2018-02-08 at 17:01 -0800, Andy Lutomirski wrote: > > > > On Feb 8, 2018, at 4:39 PM, Pandiyan, Dhinakaran > > wrote: > > > > > >> On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: > >> Hi Andy, > >> > >> thanks for getting involved with PSR

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

> On Feb 8, 2018, at 4:39 PM, Pandiyan, Dhinakaran > wrote: > > >> On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: >> Hi Andy, >> >> thanks for getting involved with PSR and sorry for not replying sooner. >> >> I first saw this patch on that bugzilla

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

On Thu, 2018-02-08 at 14:48 -0800, Rodrigo Vivi wrote: > Hi Andy, > > thanks for getting involved with PSR and sorry for not replying sooner. > > I first saw this patch on that bugzilla entry but only now I stop to > really think why I have written the code that way. > > So some clarity below.

Re: [Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

Hi Andy, thanks for getting involved with PSR and sorry for not replying sooner. I first saw this patch on that bugzilla entry but only now I stop to really think why I have written the code that way. So some clarity below. On Mon, Feb 05, 2018 at 10:07:09PM +, Andy Lutomirski wrote: >

[Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

From: Andy Lutomirski The current PSR code has a two call sites that each schedule delayed work to activate PSR. As far as I can tell, each call site intends to keep PSR inactive for the given amount of time and then allow it to be activated. The call sites are: -

[Intel-gfx] [PATCH] drm/i915: Improve PSR activation timing

The current PSR code has a two call sites that each schedule delayed work to activate PSR. As far as I can tell, each call site intends to keep PSR inactive for the given amount of time and then allow it to be activated. The call sites are: - intel_psr_enable(), which explicitly states in a