Re: [Intel-gfx] [PATCH] drm/i915: Remove the WARN when failing to set tiling.

2010-07-06 Thread Eric Anholt
On Sun,  6 Jun 2010 13:21:26 +0100, Chris Wilson ch...@chris-wilson.co.uk 
wrote:
 We generally issue an error message at the point of failure, and so this
 warning with a fairly pointless stacktrace is superfluous and ugly.
 Needless to say, the common trigger for this WARN happens to be EIO
 where this is pure noise.

Applied.  Thanks!


pgpDs4SF28OLT.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] [PATCH] drm/i915: Remove the WARN when failing to set tiling.

2010-06-06 Thread Chris Wilson
We generally issue an error message at the point of failure, and so this
warning with a fairly pointless stacktrace is superfluous and ugly.
Needless to say, the common trigger for this WARN happens to be EIO
where this is pure noise.

Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk
---
 drivers/gpu/drm/i915/i915_gem_tiling.c |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_tiling.c 
b/drivers/gpu/drm/i915/i915_gem_tiling.c
index 4b7c49d..155719e 100644
--- a/drivers/gpu/drm/i915/i915_gem_tiling.c
+++ b/drivers/gpu/drm/i915/i915_gem_tiling.c
@@ -333,8 +333,6 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
i915_gem_release_mmap(obj);
 
if (ret != 0) {
-   WARN(ret != -ERESTARTSYS,
-failed to reset object for tiling switch);
args-tiling_mode = obj_priv-tiling_mode;
args-stride = obj_priv-stride;
goto err;
-- 
1.7.1

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx